Branch: refs/heads/LLP64 Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: c64566a79a17adf88ec7caeb001536792d92402e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c64566a79a17adf88ec... Author: Nicolas Cellier nicolas.cellier.aka.nice@gmail.com Date: 2016-08-08 (Mon, 08 Aug 2016)
Changed paths: M platforms/Cross/plugins/IA32ABI/arm32ia32abicc.c M platforms/Cross/plugins/IA32ABI/x64ia32abicc.c
Log Message: ----------- Authorize usage of Squeak types in vmCallback
For example, vmCallback might rely on sqIntptr_t for LLP64 compatibility. The order of include files must be revised in order to do so This change has been applied to ia32abicc.c cf. https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/336c3d5ba394eb2812d... (336c3d5) It must also be applied to other supported ABI (arm32, x64) Note sure what is needed for ppc32abicc...
On Tue, Aug 9, 2016 at 4:52 AM, GitHub noreply@github.com wrote:
Log Message:
Authorize usage of Squeak types in vmCallback
For example, vmCallback might rely on sqIntptr_t for LLP64 compatibility. The order of include files must be revised in order to do so This change has been applied to ia32abicc.c cf. https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/336c3d5ba394eb2812d... (336c3d5)
It must also be applied to other supported ABI (arm32, x64) Note sure what is needed for ppc32abicc...
For those platforms you don't get to straight away, could you open an Issue on github to track? cheers -ben
Hi Ben, I don't know... The original issue was failing builds in LLP64 branch (like https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/150687436). Build were failing because vmCallback.h uses sqIntptr_t. Since this file is only used in *abicc.c, it's enough to just invert the order of include files so that sqIntptr_t is already defined.
What about ppc? - it does not include vmCallback.h (are callback suppported on ppc?) - there is no ppc automated build set on travis/appveyor - I can't test it myself
So I don't think there's an LLP64 related issue. The issue is more about the fact that ppc support will be roting fast in those conditions.
2016-08-09 1:39 GMT+02:00 Ben Coman btc@openinworld.com:
On Tue, Aug 9, 2016 at 4:52 AM, GitHub noreply@github.com wrote:
Log Message:
Authorize usage of Squeak types in vmCallback
For example, vmCallback might rely on sqIntptr_t for LLP64 compatibility. The order of include files must be revised in order to do so This change has been applied to ia32abicc.c cf. https://github.com/
OpenSmalltalk/opensmalltalk-vm/commit/336c3d5ba394eb2812db7cee5320ce 8c03f6112c (336c3d5)
It must also be applied to other supported ABI (arm32, x64) Note sure what is needed for ppc32abicc...
For those platforms you don't get to straight away, could you open an Issue on github to track? cheers -ben
vm-dev@lists.squeakfoundation.org
-
Ben Coman -
GitHub -
Nicolas Cellier