at least in high sierra this was failing You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/185
-- Commit Summary --
* fix the preparation of windows paths for dir_EntryLookup: if path+name was bigger than 260 but name was smaller, then the conversion was not being applied. * Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into Cog * Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into Cog * Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into Cog * Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into Cog * fix expansion of symlinks * add special build instructions for Pharo (maybe they need to be extended to non-Pharo vms but idk)
-- File Changes --
M build.macos32x86/third-party/Makefile.openssl (4) M platforms/iOS/plugins/SqueakSSL/Makefile (10)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/185.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/185.diff
What is openssl necessary for?
No idea, but SqueakSSL needs it. then, we need it too (for other stuff)
No, SqueakSSL on macOS does _not_ use openssl. In fact, the `-lssl -lcrypto` should be _removed_
If you need openssl for ssh2 and libgit2, Ok, but SqueakSSL is not the place for that
ah well... it was like that (i didn't added the -lssl -lcrypto), and because of them it was failing the build. I just made sure compilation succeeds.
Yeah, I see, not meant to blame you. I think I'll just remove it directly in `Cog`, ok?
On Jan 3, 2018, at 10:20 AM, Tobias Pape notifications@github.com wrote:
Yeah, I see, not meant to blame you. I think I'll just remove it directly in Cog, ok?
Yes please :-)
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
It has been done :D
I presume that the changes for building openssl are still necessary (if openssl is used by some other libs). Esteban, could you remove changes to platforms/iOS/plugins/SqueakSSL/Makefile and commit again?
@estebanlm pushed 1 commit.
b524447 Merge branch 'Cog' into Cog
@estebanlm pushed 1 commit.
697df33 fix bad variable
yeah, on his way
yay
Merged #185.
vm-dev@lists.squeakfoundation.org
-
Eliot Miranda -
Esteban Lorenzano
-
Nicolas Cellier
-
Tobias Pape