David T. Lewis uploaded a new version of VMMaker to project VM Maker Inbox: http://source.squeak.org/VMMakerInbox/VMMaker.oscog-dtl.3185.mcz
==================== Summary ====================
Name: VMMaker.oscog-dtl.3185 Author: dtl Time: 30 May 2022, 2:36:26.668082 pm UUID: 0e7f07b8-eed6-4362-b223-86c98594ddb9 Ancestors: VMMaker.oscog-mt.3184
Let primitiveImageFormatVersion answer the correct image format number when multiple byte codes are active.
=============== Diff against VMMaker.oscog-mt.3184 ===============
Item was changed: ----- Method: InterpreterPrimitives>>primitiveImageFormatVersion (in category 'other primitives') ----- primitiveImageFormatVersion "Answer an integer identifying the type of image. The image version number may identify the format of the image (e.g. 32 or 64-bit word size) or specific requirements of the image (e.g. block closure support required). This is a named (not numbered) primitive in the null module (ie the VM)"
<export: true> + self pop: 1 thenPush: (self positive32BitIntegerFor: self imageFormatVersionForSnapshot) - self pop: 1 thenPush: (self positive32BitIntegerFor: self imageFormatVersion) !
Proposed fix for https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/638
On Mon, May 30, 2022 at 06:36:36PM +0000, commits@source.squeak.org wrote:
David T. Lewis uploaded a new version of VMMaker to project VM Maker Inbox: http://source.squeak.org/VMMakerInbox/VMMaker.oscog-dtl.3185.mcz
==================== Summary ====================
Name: VMMaker.oscog-dtl.3185 Author: dtl Time: 30 May 2022, 2:36:26.668082 pm UUID: 0e7f07b8-eed6-4362-b223-86c98594ddb9 Ancestors: VMMaker.oscog-mt.3184
Let primitiveImageFormatVersion answer the correct image format number when multiple byte codes are active.
=============== Diff against VMMaker.oscog-mt.3184 ===============
Item was changed: ----- Method: InterpreterPrimitives>>primitiveImageFormatVersion (in category 'other primitives') ----- primitiveImageFormatVersion "Answer an integer identifying the type of image. The image version number may identify the format of the image (e.g. 32 or 64-bit word size) or specific requirements of the image (e.g. block closure support required).
This is a named (not numbered) primitive in the null module (ie the VM)"
<export: true>
- self pop: 1 thenPush: (self positive32BitIntegerFor: self imageFormatVersionForSnapshot)
- self pop: 1 thenPush: (self positive32BitIntegerFor: self imageFormatVersion) !
I moved this from VMMaker inbox to the main VMMaker repository.
I did not commit generated code because my generated code has unexplained differences versus the files in github, so I need help from someone with a known good VMMaker image.
Dave
On Mon, May 30, 2022 at 02:43:49PM -0400, David T. Lewis wrote:
Proposed fix for https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/638
On Mon, May 30, 2022 at 06:36:36PM +0000, commits@source.squeak.org wrote:
David T. Lewis uploaded a new version of VMMaker to project VM Maker Inbox: http://source.squeak.org/VMMakerInbox/VMMaker.oscog-dtl.3185.mcz
==================== Summary ====================
Name: VMMaker.oscog-dtl.3185 Author: dtl Time: 30 May 2022, 2:36:26.668082 pm UUID: 0e7f07b8-eed6-4362-b223-86c98594ddb9 Ancestors: VMMaker.oscog-mt.3184
Let primitiveImageFormatVersion answer the correct image format number when multiple byte codes are active.
=============== Diff against VMMaker.oscog-mt.3184 ===============
Item was changed: ----- Method: InterpreterPrimitives>>primitiveImageFormatVersion (in category 'other primitives') ----- primitiveImageFormatVersion "Answer an integer identifying the type of image. The image version number may identify the format of the image (e.g. 32 or 64-bit word size) or specific requirements of the image (e.g. block closure support required).
This is a named (not numbered) primitive in the null module (ie the VM)"
<export: true>
- self pop: 1 thenPush: (self positive32BitIntegerFor: self imageFormatVersionForSnapshot)
- self pop: 1 thenPush: (self positive32BitIntegerFor: self imageFormatVersion) !
Hi Dave --
Done. Well, it is a manual process to revert those unnecessary changes in the generated sources. Maybe this is related to some state in an VMMaker image. Maybe it is a bug in the code generator. I don't know.
Best, Marcel Am 01.06.2022 19:46:41 schrieb David T. Lewis lewis@mail.msen.com:
I moved this from VMMaker inbox to the main VMMaker repository.
I did not commit generated code because my generated code has unexplained differences versus the files in github, so I need help from someone with a known good VMMaker image.
Dave
On Mon, May 30, 2022 at 02:43:49PM -0400, David T. Lewis wrote:
Proposed fix for https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/638
On Mon, May 30, 2022 at 06:36:36PM +0000, commits@source.squeak.org wrote:
David T. Lewis uploaded a new version of VMMaker to project VM Maker Inbox: http://source.squeak.org/VMMakerInbox/VMMaker.oscog-dtl.3185.mcz
==================== Summary ====================
Name: VMMaker.oscog-dtl.3185 Author: dtl Time: 30 May 2022, 2:36:26.668082 pm UUID: 0e7f07b8-eed6-4362-b223-86c98594ddb9 Ancestors: VMMaker.oscog-mt.3184
Let primitiveImageFormatVersion answer the correct image format number when multiple byte codes are active.
=============== Diff against VMMaker.oscog-mt.3184 ===============
Item was changed: ----- Method: InterpreterPrimitives>>primitiveImageFormatVersion (in category 'other primitives') ----- primitiveImageFormatVersion "Answer an integer identifying the type of image. The image version number may identify the format of the image (e.g. 32 or 64-bit word size) or specific requirements of the image (e.g. block closure support required).
This is a named (not numbered) primitive in the null module (ie the VM)"
- self pop: 1 thenPush: (self positive32BitIntegerFor: self imageFormatVersionForSnapshot)
- self pop: 1 thenPush: (self positive32BitIntegerFor: self imageFormatVersion)
!
vm-dev@lists.squeakfoundation.org