should close PR #388 You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524
-- Commit Summary --
* Adding a custom Menu for Pharo VMs * Adding a optional URL for the help, only fr Pharo * Handling correctly the events of the about window * Making the about window property as weak. * Reverting a change I needed to compile in my machine * Use $(SYSTEM)-MainMenu.xib to determine which xib file to use
-- File Changes --
M build.macos32x86/common/Makefile.app (4) M build.macos32x86/pharo.cog.spur.lowcode/Makefile (2) M build.macos32x86/pharo.cog.spur.minheadless/Makefile (2) M build.macos32x86/pharo.cog.v3/Makefile (2) M build.macos64x64/common/Makefile.app (4) R platforms/iOS/vm/English.lproj/Newspeak-MainMenu-cg.xib (0) R platforms/iOS/vm/English.lproj/Newspeak-MainMenu-opengl.xib (0) R platforms/iOS/vm/English.lproj/Newspeak-MainMenu.xib (0) A platforms/iOS/vm/English.lproj/Pharo-MainMenu-opengl.xib (1261) A platforms/iOS/vm/English.lproj/Pharo-MainMenu.xib (1261) A platforms/iOS/vm/English.lproj/Squeak-MainMenu-cg.xib (1261) A platforms/iOS/vm/English.lproj/Squeak-MainMenu-opengl.xib (1261) A platforms/iOS/vm/English.lproj/Squeak-MainMenu.xib (1261) M platforms/iOS/vm/OSX/Pharo-Info.plist (2) M platforms/iOS/vm/OSX/SqueakOSXApplication.m (30) M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (16) M platforms/iOS/vm/OSX/sqSqueakOSXApplication.h (5) M platforms/iOS/vm/OSX/sqSqueakOSXApplication.m (1)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524.diff
@demarey pushed 1 commit.
75b9999dad53f7754506372a77970d79674692e8 Merge branch 'Cog' into customizationForPharo
@eliotmiranda approved this pull request.
Closed #524.
Merged #524 into Cog.
Merged #524 into Cog.
Hi Christophe,
when I try and build a PharoVM from the Cog sources after merging this pull request I get the following error:
```../../platforms/iOS/vm/OSX/SqueakOSXApplication.m:76:37: error: no visible @interface for 'sqSqueakMainApplication' declares the selector 'setAboutWindow:' [gDelegateApp.squeakApplication setAboutWindow: [self keyWindow]]; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~ 1 error generated.```
It's coming from this method:
```@implementation SqueakOSXApplication ... - (void)orderFrontStandardAboutPanel:(id)sender; { [super orderFrontStandardAboutPanel: sender]; [gDelegateApp.squeakApplication setAboutWindow: [self keyWindow]]; }```
vm-dev@lists.squeakfoundation.org