On Tue, Jan 27, 2015 at 1:39 PM, Tobias Pape Das.Linux@gmx.de wrote:
Hi,
On 27.01.2015, at 22:21, Levente Uzonyi leves@elte.hu wrote:
AndreasSystemProfiler
This is not in trunk, right? If so, why?
It came from Qwaq/Terf so it ended up in http://ss3.gemstone.com/ss/AndreasSystemProfiler. Further, as Levente says it depends on support that is in Cog VMs (JIT, Stack & Interpreter) but not (yet) in the trunk Interpreter. So I guess it doesn't belong in trunk until the Cog Interpreter has been merged with the trunk Interpreter. That's a fair amount of work, and neither David nor I have the time for it right now.
On Tue, Jan 27, 2015 at 01:51:52PM -0800, Eliot Miranda wrote:
On Tue, Jan 27, 2015 at 1:39 PM, Tobias Pape Das.Linux@gmx.de wrote:
Hi,
On 27.01.2015, at 22:21, Levente Uzonyi leves@elte.hu wrote:
AndreasSystemProfiler
This is not in trunk, right? If so, why?
It came from Qwaq/Terf so it ended up in http://ss3.gemstone.com/ss/AndreasSystemProfiler. Further, as Levente says it depends on support that is in Cog VMs (JIT, Stack & Interpreter) but not (yet) in the trunk Interpreter. So I guess it doesn't belong in trunk until the Cog Interpreter has been merged with the trunk Interpreter. That's a fair amount of work, and neither David nor I have the time for it right now.
I did spend some time last year trying to get the primitives working in trunk Interpreter, but I was a bit out of my depth and did not get it right.
Reminder and background info is on Mantis at http://bugs.squeak.org/view.php?id=7746
As far as putting the profiler into trunk, I should think that there would be some way to have more than one profiler, and fall back to the old one if the VM does not provide the needed support for AndreasSystemProfiler.
This seems like a worthwhile thing to do. Anyone care to take it on?
Dave
On Jan 27, 2015, at 4:00 PM, "David T. Lewis" lewis@mail.msen.com wrote:
On Tue, Jan 27, 2015 at 01:51:52PM -0800, Eliot Miranda wrote:
On Tue, Jan 27, 2015 at 1:39 PM, Tobias Pape Das.Linux@gmx.de wrote:
Hi,
On 27.01.2015, at 22:21, Levente Uzonyi leves@elte.hu wrote:
AndreasSystemProfiler
This is not in trunk, right? If so, why?
It came from Qwaq/Terf so it ended up in http://ss3.gemstone.com/ss/AndreasSystemProfiler. Further, as Levente says it depends on support that is in Cog VMs (JIT, Stack & Interpreter) but not (yet) in the trunk Interpreter. So I guess it doesn't belong in trunk until the Cog Interpreter has been merged with the trunk Interpreter. That's a fair amount of work, and neither David nor I have the time for it right now.
I did spend some time last year trying to get the primitives working in trunk Interpreter, but I was a bit out of my depth and did not get it right.
Since the code is in the Cog Interpreter the right way to do this IMO us to port bug fixes to primitives etc into the Cog Interpreter and call the Cog VMMaker trunk. Going the other way takes longer to get to the same place.
Reminder and background info is on Mantis at http://bugs.squeak.org/view.php?id=7746
As far as putting the profiler into trunk, I should think that there would be some way to have more than one profiler, and fall back to the old one if the VM does not provide the needed support for AndreasSystemProfiler.
This seems like a worthwhile thing to do. Anyone care to take it on?
Dave
On Tue, Jan 27, 2015 at 04:14:24PM -0800, Eliot Miranda wrote:
On Jan 27, 2015, at 4:00 PM, "David T. Lewis" lewis@mail.msen.com wrote:
On Tue, Jan 27, 2015 at 01:51:52PM -0800, Eliot Miranda wrote:
On Tue, Jan 27, 2015 at 1:39 PM, Tobias Pape Das.Linux@gmx.de wrote:
On 27.01.2015, at 22:21, Levente Uzonyi leves@elte.hu wrote:
AndreasSystemProfiler
This is not in trunk, right? If so, why?
It came from Qwaq/Terf so it ended up in http://ss3.gemstone.com/ss/AndreasSystemProfiler. Further, as Levente says it depends on support that is in Cog VMs (JIT, Stack & Interpreter) but not (yet) in the trunk Interpreter. So I guess it doesn't belong in trunk until the Cog Interpreter has been merged with the trunk Interpreter. That's a fair amount of work, and neither David nor I have the time for it right now.
I did spend some time last year trying to get the primitives working in trunk Interpreter, but I was a bit out of my depth and did not get it right.
Since the code is in the Cog Interpreter the right way to do this IMO us to port bug fixes to primitives etc into the Cog Interpreter and call the Cog VMMaker trunk. Going the other way takes longer to get to the same place.
Hi Eliot,
Was Andreas' profiler fully functional on an Interpreter generated from oscog at one point? I know that Andreas had done at least an initial implementation in that part of the code. I had assumed that his main focus in that time frame would have been on Cog, so I was not entirely sure if the Interpreter implementation was complete.
Of course I was trying to adopt the implementation from the oscog branch when I looked at this last year. But given that I was not successful, I won't attempt to argue that this was the best possible approach.
Thanks, Dave
On Tue, Jan 27, 2015 at 7:15 PM, David T. Lewis lewis@mail.msen.com wrote:
On Tue, Jan 27, 2015 at 04:14:24PM -0800, Eliot Miranda wrote:
On Jan 27, 2015, at 4:00 PM, "David T. Lewis" lewis@mail.msen.com
wrote:
On Tue, Jan 27, 2015 at 01:51:52PM -0800, Eliot Miranda wrote:
On Tue, Jan 27, 2015 at 1:39 PM, Tobias Pape Das.Linux@gmx.de
wrote:
On 27.01.2015, at 22:21, Levente Uzonyi leves@elte.hu wrote:
AndreasSystemProfiler
This is not in trunk, right? If so, why?
It came from Qwaq/Terf so it ended up in http://ss3.gemstone.com/ss/AndreasSystemProfiler. Further, as
Levente says
it depends on support that is in Cog VMs (JIT, Stack & Interpreter)
but not
(yet) in the trunk Interpreter. So I guess it doesn't belong in trunk until the Cog Interpreter has been merged with the trunk Interpreter. That's a fair amount of work, and neither David nor I have the time
for it
right now.
I did spend some time last year trying to get the primitives working in trunk Interpreter, but I was a bit out of my depth and did not get it
right.
Since the code is in the Cog Interpreter the right way to do this IMO us to port bug fixes to primitives etc into the Cog Interpreter and call the Cog VMMaker trunk. Going the other way takes longer to get to the same
place.
Hi Eliot,
Was Andreas' profiler fully functional on an Interpreter generated from oscog at one point? I know that Andreas had done at least an initial implementation in that part of the code. I had assumed that his main focus in that time frame would have been on Cog, so I was not entirely sure if the Interpreter implementation was complete.
When I joined Qwaq, Andreas' fork of VMMaker and svn trunk was the VM in use. The Interpreter contained all of the support for Andreas' profiler. That VMMaker was my starting point for Cog and I simply supported in the Stack and Cog VMs what was in the Interpreter.
There was much else in there too; support for a high-priority media=-processing thread which was used for Qwaq's voice channel; extensions to the host window plugin etc, etc. This had to continue working as the VM was sped-up using first the Stack VM and then Cog. I guess the Qwaq VM forked from trunk in about 2005.
Of course I was trying to adopt the implementation from the oscog branch when I looked at this last year. But given that I was not successful, I won't attempt to argue that this was the best possible approach.
Thanks, Dave
On Tue, Jan 27, 2015 at 07:43:27PM -0800, Eliot Miranda wrote:
On Tue, Jan 27, 2015 at 7:15 PM, David T. Lewis lewis@mail.msen.com wrote:
On Tue, Jan 27, 2015 at 04:14:24PM -0800, Eliot Miranda wrote:
Was Andreas' profiler fully functional on an Interpreter generated from oscog at one point? I know that Andreas had done at least an initial implementation in that part of the code. I had assumed that his main focus in that time frame would have been on Cog, so I was not entirely sure if the Interpreter implementation was complete.
When I joined Qwaq, Andreas' fork of VMMaker and svn trunk was the VM in use. The Interpreter contained all of the support for Andreas' profiler. That VMMaker was my starting point for Cog and I simply supported in the Stack and Cog VMs what was in the Interpreter.
There was much else in there too; support for a high-priority media=-processing thread which was used for Qwaq's voice channel; extensions to the host window plugin etc, etc. This had to continue working as the VM was sped-up using first the Stack VM and then Cog. I guess the Qwaq VM forked from trunk in about 2005.
Thanks Eliot,
That probably sounded like a dumb question, but I actually was not sure if I was looking at a complete and functional implemention, or just a rough draft. Obviously it would have made more sense for me to have asked the question a year or so ago.
I can't look into it further now, but the issue remains documented on Mantis at http://bugs.squeak.org/view.php?id=7746 so hopefully either I or some other motivated person will follow through on it in the not too distant future.
Dave
Of course I was trying to adopt the implementation from the oscog branch when I looked at this last year. But given that I was not successful, I won't attempt to argue that this was the best possible approach.
Thanks, Dave
-- best, Eliot
vm-dev@lists.squeakfoundation.org