64 bit Pharo VM Version from 2019-1-5, Squeak VM version from 2018-12-14 Images Pharo 8 build 136 and Squeak 5.2 18229
Switching to full screen using the Pharo VM hangs, using the Squeak VM works for both images
https://github.com/pharo-project/pharo/issues/2343
And it is a regression. With the PharoLauncher VM I have here for Pharo6.1 from 2018-6-28 5.0.201806281256 I can not reproduce
Hi Stephan, on Squeak with two monitors, while I don't see the Vm lock up (one can still see the clock ticking in the menu bar), I do see the image become completely unresponsive to mouse input. So I see a serious problem with the latest Squeak VM too (I tested a 64-bit system on a home built VM derived from Croquet Closure Cog[Spur] VM [CoInterpreterPrimitives VMMaker.oscog-eem.2530] 5.0.201902020720, with older platform code, avoiding Ronie's latest Metal shader code which doesn't compile on my 10.13.6 MPB).
201810222239 works, 201810230536 is broken
So it looks like it is
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/671517e30e5afd50d75... https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/94e4f2565db5f75f1c0... https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9320885e03ad028ec2d...
Hi, I have checked that if we go into fullscreen from the button in the window it works fine. From the primitive, it blocks.
Cheers, Pablo
On Wed, Mar 20, 2019 at 11:08 AM Stephan Eggermont notifications@github.com wrote:
So it looks like it is
671517e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/671517e30e5afd50d75b90d1a64cb89add6b678c 94e4f25 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/94e4f2565db5f75f1c0a9268eb2288d69f5cc58f 9320885 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9320885e03ad028ec2da8c1f1cc6cddcc83045b1
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/380#issuecomment-474765678, or mute the thread https://github.com/notifications/unsubscribe-auth/AhLyWyiO5pq02TzPKuwjBVzpenqzhIRNks5vYgiFgaJpZM4b8Udd .
I have proposed a PR with the fix to make it work from the primitive and from the button in the window. Stephan, can you check it?
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381
Cheers, Pablo
On Thu, Mar 21, 2019 at 4:13 PM tesonep@gmail.com tesonep@gmail.com wrote:
Hi, I have checked that if we go into fullscreen from the button in the window it works fine. From the primitive, it blocks.
Cheers, Pablo
On Wed, Mar 20, 2019 at 11:08 AM Stephan Eggermont < notifications@github.com> wrote:
So it looks like it is
671517e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/671517e30e5afd50d75b90d1a64cb89add6b678c 94e4f25 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/94e4f2565db5f75f1c0a9268eb2288d69f5cc58f 9320885 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9320885e03ad028ec2da8c1f1cc6cddcc83045b1
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/380#issuecomment-474765678, or mute the thread https://github.com/notifications/unsubscribe-auth/AhLyWyiO5pq02TzPKuwjBVzpenqzhIRNks5vYgiFgaJpZM4b8Udd .
-- Pablo Tesone. tesonep@gmail.com
The primitive is not enough. doIt DisplayScreen toggleFullscreen. and see fullScreen:
Where do I find the build artefacts?
That's a really good question. I don't know if they are kept for each PR.
On Thu, 21 Mar 2019, 22:13 Stephan Eggermont <notifications@github.com wrote:
Where do I find the build artefacts?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/380#issuecomment-475404603, or mute the thread https://github.com/notifications/unsubscribe-auth/AhLyW1tCzL6lb3ImySv85sA8kyvPoqA4ks5vY_XjgaJpZM4b8Udd .
Should that be fixed in pharo.cog.spur_macos64x64_201903251926?. I still manage to get an unresponsive Pharo image when doing in a playground: Display toggleFullscreen
Looks like we still have an issue. I did my testing in a two screen configuration and it worked there. But we've just tried on a one screen laptop and indeed the system stops delivering events into the system wen we switch to full screen. So it looks like the issue has yet to be fixed.
I had a comment in #381 Didn’t understand if the change did the right thing. Also is this random failure or always happens with a chunk of smalltalk I can run?
Always happens. It might be Mac OS version dependent. On 10.14.3 without an external monitor connected on my MBP I can reliably reproduce it in a Pharo 7 or 8 by opening a playground and doing
Display toggleFullscreen.
On Squeak I used
Display fullScreenMode: true. Display newDepth: Display depth
Closed #380.
vm-dev@lists.squeakfoundation.org
-
Eliot Miranda -
johnmci
-
Stephan Eggermont
-
tesonep＠gmail.com