On Sat, Apr 29, 2017 at 10:08:23AM -0600, Daniel Drake wrote:

Hi Dave,

On Sat, Apr 29, 2017 at 9:58 AM, David T. Lewis lewis@mail.msen.com wrote:

...

I don't think that the camera plugin was ever made 64-bit clean. A bug report is at http://bugs.squeak.org/view.php?id=7816

This would be a good project for an interested volunteer :-)

I'm an interested volunteer, knowledgeable of 32 vs 64 bit challenges but with no squeak-vm experience. Can you briefly provide some direction of where to start here?

Are there any other plugins that have previously been made 64-bit clean? (Maybe there is a similar example in svn history and I can find some direction from that.)

Hi Daniel,

Great, thanks for looking into this!

SoundPlugin and SqueakSLL are examples of plugins that required updates for 64-bit.

The majority of issues involve storage of 64-bit pointer values in 32-bit integers. Usually this is fixed by providing correct type declarations throughout the support code, and by making sure that the translated code from the plugin class in VMMaker produces code with type declarations that match the support code.

In the case of CameraPlugin, I would be inclined to start by looking at the support code in platforms/unix/plugins/CameraPlugin/ to get an idea of what the function declarations are (or should be). Look through it for any type casts, usually these are a red flag for something you are going to need to fix.

If everything looks good in platforms/[unix|win32|Moc OS|iOS] then the next thing to check will be the declarations in platforms/Cross/plugins/CameraPlugin/CameraPlugin.h. These will probably be ok, but make sure that anything declared as int is really a 32-bit integer value.

If you are statisfied that the support code is all in good order for compiling on 64-bits, then take a look at CameraPlugin in your VMMaker image, and at it sgenerated source code in src/plugins/CameraPlugin/CameraPlugin.c.

Look for places in the generated code where the support code functions are being called incorrectly, or where methods in the plugin itself use default sqInt variable declarations that should be explicitly declared as something else.

I do this sort of work using an interpreter VM on a 64-bit Linux system because it lets me easily compile 64-bit VMs that run on 32-bit sqInt object memories, which is the combination that most reliably finds type declaration problems.

You will probably want to run your VMs under gdb to locate problems, but don't be afraid to hack some printf's into your generated plugin source in order to find problems. Do a fflush after each printf so you can see the output right before your VM crashes.

Thanks and HTH, Dave

On 29-04-2017, at 8:25 PM, Ben Coman btc@openinworld.com wrote:

http://coweb.cc.gatech.edu/squeakbook/upload

Good grief, that version is so out of date it was written by knotting strings made of woven unicorn hair.

Try http://www.rowledge.org/resources/tim%27s-Home-page/Squeak/OE-Tour.pdf - ad even that is now horribly out of date. I wonder if I’ll ever have time to rewrite it.

tim -- tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim Strange OpCodes: MTP: MounT Programmer

_,,,^..^,,,_ (phone)

On Apr 29, 2017, at 9:08 AM, Daniel Drake drake@endlessm.com wrote:

Hi Dave,

...

On Sat, Apr 29, 2017 at 9:58 AM, David T. Lewis lewis@mail.msen.com wrote: I don't think that the camera plugin was ever made 64-bit clean. A bug report is at http://bugs.squeak.org/view.php?id=7816

This would be a good project for an interested volunteer :-)

I'm an interested volunteer, knowledgeable of 32 vs 64 bit challenges but with no squeak-vm experience. Can you briefly provide some direction of where to start here?

Hi Daniel,

this will get you started with building a tip VMMaker image:

http://www.mirandabanda.org/cogblog/build-image/

There is a glitch. The scripts don't currently download a vm for you but you can build your own in the context of the repository or you can download a vm from bintray or use the vm you're using now. The script explains how to substitute a vm.

There are workspaces in the image that the comatose n how to generate sources.

If you look in the archives for the list you should give me discussion of making sources 32-bit clean and using sqIntptr_t as the type for a parameter that takes a Smalltalk oop in both 32 and 64 bits.

It's likely that headers and support code that use int parameters have to be changed to use sqInt or sqIntptr_t, depending on whether they actually receive an oop or a pointer. Mac & Linux are LP64, windows is LLP64.

Are there any other plugins that have previously been made 64-bit clean? (Maybe there is a similar example in svn history and I can find some direction from that.)

Thanks Daniel

How Daniel,

second attempt to avoid autocorrect ...

On Apr 29, 2017, at 9:08 AM, Daniel Drake drake@endlessm.com wrote:

Hi Dave,

...

On Sat, Apr 29, 2017 at 9:58 AM, David T. Lewis lewis@mail.msen.com wrote: I don't think that the camera plugin was ever made 64-bit clean. A bug report is at http://bugs.squeak.org/view.php?id=7816

This would be a good project for an interested volunteer :-)

I'm an interested volunteer, knowledgeable of 32 vs 64 bit challenges but with no squeak-vm experience. Can you briefly provide some direction of where to start here?

Hi Daniel,

this will get you started with building a tip VMMaker image:

http://www.mirandabanda.org/cogblog/build-image/

There is a glitch. The scripts don't currently download a vm for you but you can build your own in the context of the repository or you can download a vm from bintray or use the vm you're using now. The script explains how to substitute a vm.

There are workspaces in the image that describe how to generate sources.

If you look in the archives for the list you should find discussion of making sources 32-bit clean and using sqIntptr_t as the type for a parameter that takes a Smalltalk oop in both 32 and 64 bits.

It's likely that headers and support code that use int parameters have to be changed to use sqInt or sqIntptr_t, depending on whether they actually receive an oop or a pointer. The issue being, as I'm sure you're aware, that Mac & Linux are LP64, whereas windows is LLP64.

Are there any other plugins that have previously been made 64-bit clean? (Maybe there is a similar example in svn history and I can find some direction from that.)

Yes. If you build a 64-bit vm you can see the plugins that have been built. As David said, many plugins had to have their glue code, typically defined in platforms/Cross/plugins/SomePlugin/SomePlugin.h, redefined to be usable in both 32 and 64 bits. In the old days int was used for almost everything. I think I'm correct in thinks my that we've rewritten all the used plugins.

And welcome! It's great to have another set of hands. Thank you!

Thanks Daniel

_,,,^..^,,,_ (phone)