Hi:
In Pharo there is no #clone anymore and in Squeak 4.5 #shallowCopy seems to be equivalent to #clone in its implementation.
There are a few uses of #clone in the VMMaker, and SmartSyntaxPluginCodeGenerator knows about it as well.
Would it be ok to migrate to #shallowCopy?
Best regards Stefan
On Fri, Feb 14, 2014 at 10:28:25AM +0100, Stefan Marr wrote:
Hi:
In Pharo there is no #clone anymore and in Squeak 4.5 #shallowCopy seems to be equivalent to #clone in its implementation.
There are a few uses of #clone in the VMMaker, and SmartSyntaxPluginCodeGenerator knows about it as well.
Would it be ok to migrate to #shallowCopy?
Looks reasonable to me.
Dave
On Fri, Feb 14, 2014 at 10:28:25AM +0100, Stefan Marr wrote:
Hi:
In Pharo there is no #clone anymore and in Squeak 4.5 #shallowCopy seems to be equivalent to #clone in its implementation.
There are a few uses of #clone in the VMMaker, and SmartSyntaxPluginCodeGenerator knows about it as well.
Would it be ok to migrate to #shallowCopy?
Stefan,
I see three senders of #clone in the trunk (interpreter) VMMaker, and no references in SmartSyntaxPluginCodeGenerator (aside from some code that is commented out). Is this the same as you are seeing? Cog seems to be the same except that the code in SmartSyntaxPluginCodeGenerator is not commented out, but it is unused so probably not relevant.
Dave
Hi Dave:
On 15 Feb 2014, at 02:03, David T. Lewis lewis@mail.msen.com wrote:
Is this the same as you are seeing? Cog seems to be the same except that the code in SmartSyntaxPluginCodeGenerator is not commented out, but it is unused so probably not relevant.
Yes, seems to be the same, it is a minimal change:
https://github.com/smarr/pharo-vm/commit/114f5b3db0ff2185ca5eac0d033eb95b99f... CObjectAccessor #+ and #- And InterpreterProxy>>#clone:
Best regards Stefan
vm-dev@lists.squeakfoundation.org