It seems we're missing some declaration?
- Bert -
Begin forwarded message:
Resent-From: dann frazier dannf@debian.org From: dann frazier dannf@debian.org Date: 28. Januar 2010 09:55:58 GMT-08:00 Resent-To: debian-bugs-dist@lists.debian.org To: submit@bugs.debian.org Resent-Cc: Debian Squeak Team pkg-squeak-devel@lists.alioth.debian.org Subject: [Pkg-squeak-devel] Bug#567366: `memoryAllocate' implicitly converted to pointer Reply-To: dann frazier dannf@debian.org, 567366@bugs.debian.org
Source: squeak-vm Version: 3.11.3+svn2147-1 Severity: serious Usertags: implicit-pointer-conversion
Our automated buildd log filter[1] detected a problem that is likely to cause your package to segfault on architectures where the size of a pointer is greater than the size of an integer, such as ia64 and amd64.
Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/bitstream.c:40 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/libmpeg3.c:47 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3atrack.c:42 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3demux.c:1060 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3io.c:61 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3title.c:41 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3vtrack.c:42 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/audio/mpeg3audio.c:45 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/mpeg3video.c:170 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/slice.c:48
This is often due to a missing function prototype definition. For more information, see [2].
Though it is guaranteed that this codepath will cause a segfault on certain architectures, it is not guaranteed that this codepath would ever be executed (e.g., if the returned pointer is never dereferenced). However, this bug does prevent the ia64 buildd from successfully building this package, resulting in a practical FTBFS issue and warranting the serious severity.
[1] http://people.debian.org/~dannf/check-implicit-pointer-functions [2] http://wiki.debian.org/ImplicitPointerConversions
Pkg-squeak-devel mailing list Pkg-squeak-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-squeak-devel
No, it's pointing out that the Mpeg3Plugin is NOT 64bit clean.
(a) I doubt anyone has looked. (b) I'd guess the api thinks an OOPS is a address, not a pointer to an address so it likely does the final address calculation wrong when passing OOPS address info about. (c) It likely passes back 64bit address information as 32bit values, versus a positive 64bit number. (d) the stuff = (void *) calloc(size,number); in void * memoryAllocate(int number,unsigned size) is a bit ugly looking and since there is no declare in a header it thinks it's (int) memoryAllocate()
I could ask has anyone actually tried using the mpeg plugin on 64bit linux with 64bit VM? You could add the prototype declare, but I think it's a greasy step to having someone confirm it work?
On 2010-01-28, at 11:17 AM, Bert Freudenberg wrote:
It seems we're missing some declaration?
- Bert -
Begin forwarded message:
Resent-From: dann frazier dannf@debian.org From: dann frazier dannf@debian.org Date: 28. Januar 2010 09:55:58 GMT-08:00 Resent-To: debian-bugs-dist@lists.debian.org To: submit@bugs.debian.org Resent-Cc: Debian Squeak Team pkg-squeak-devel@lists.alioth.debian.org Subject: [Pkg-squeak-devel] Bug#567366: `memoryAllocate' implicitly converted to pointer Reply-To: dann frazier dannf@debian.org, 567366@bugs.debian.org
Source: squeak-vm Version: 3.11.3+svn2147-1 Severity: serious Usertags: implicit-pointer-conversion
Our automated buildd log filter[1] detected a problem that is likely to cause your package to segfault on architectures where the size of a pointer is greater than the size of an integer, such as ia64 and amd64.
Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/bitstream.c:40 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/libmpeg3.c:47 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3atrack.c:42 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3demux.c:1060 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3io.c:61 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3title.c:41 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3vtrack.c:42 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/audio/mpeg3audio.c:45 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/mpeg3video.c:170 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/slice.c:48
This is often due to a missing function prototype definition. For more information, see [2].
Though it is guaranteed that this codepath will cause a segfault on certain architectures, it is not guaranteed that this codepath would ever be executed (e.g., if the returned pointer is never dereferenced). However, this bug does prevent the ia64 buildd from successfully building this package, resulting in a practical FTBFS issue and warranting the serious severity.
[1] http://people.debian.org/~dannf/check-implicit-pointer-functions [2] http://wiki.debian.org/ImplicitPointerConversions
Pkg-squeak-devel mailing list Pkg-squeak-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-squeak-devel
-- =========================================================================== John M. McIntosh johnmci@smalltalkconsulting.com Twitter: squeaker68882 Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com ===========================================================================
This is somebody trying to build an Mpeg plugin on a 64 bit machine. It will not work. The set of plugins that are currently safe to use on 64 bit platforms is much smaller than the set of plugins that appear in the generated sources in platforms/unix/src.
Bottom line: Don't do that. If you need the full range of plugins, you must compile in 32 bit mode and load the appropriate 32 bit libraries.
Unless someone speaks up to say otherwise, there is currently no supported Unix VM for 64 bit Unix/Linux platforms. John is working on providing supported 64 bit VMs for OS X, although I can't say whether he has looked at the Mpeg plugin or not (I definely have not done so).
Dave
On Thu, Jan 28, 2010 at 11:17:33AM -0800, Bert Freudenberg wrote:
It seems we're missing some declaration?
- Bert -
Begin forwarded message:
Resent-From: dann frazier dannf@debian.org From: dann frazier dannf@debian.org Date: 28. Januar 2010 09:55:58 GMT-08:00 Resent-To: debian-bugs-dist@lists.debian.org To: submit@bugs.debian.org Resent-Cc: Debian Squeak Team pkg-squeak-devel@lists.alioth.debian.org Subject: [Pkg-squeak-devel] Bug#567366: `memoryAllocate' implicitly converted to pointer Reply-To: dann frazier dannf@debian.org, 567366@bugs.debian.org
Source: squeak-vm Version: 3.11.3+svn2147-1 Severity: serious Usertags: implicit-pointer-conversion
Our automated buildd log filter[1] detected a problem that is likely to cause your package to segfault on architectures where the size of a pointer is greater than the size of an integer, such as ia64 and amd64.
Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/bitstream.c:40 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/libmpeg3.c:47 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3atrack.c:42 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3demux.c:1060 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3io.c:61 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3title.c:41 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3vtrack.c:42 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/audio/mpeg3audio.c:45 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/mpeg3video.c:170 Function `memoryAllocate' implicitly converted to pointer at /build/buildd/squeak-vm-3.11.3+svn2147/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/slice.c:48
This is often due to a missing function prototype definition. For more information, see [2].
Though it is guaranteed that this codepath will cause a segfault on certain architectures, it is not guaranteed that this codepath would ever be executed (e.g., if the returned pointer is never dereferenced). However, this bug does prevent the ia64 buildd from successfully building this package, resulting in a practical FTBFS issue and warranting the serious severity.
[1] http://people.debian.org/~dannf/check-implicit-pointer-functions [2] http://wiki.debian.org/ImplicitPointerConversions
Pkg-squeak-devel mailing list Pkg-squeak-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-squeak-devel
El jue, 28-01-2010 a las 14:43 -0500, David T. Lewis escribió:
This is somebody trying to build an Mpeg plugin on a 64 bit machine. It will not work. The set of plugins that are currently safe to use on 64 bit platforms is much smaller than the set of plugins that appear in the generated sources in platforms/unix/src.
Bottom line: Don't do that. If you need the full range of plugins, you must compile in 32 bit mode and load the appropriate 32 bit libraries.
Unless someone speaks up to say otherwise, there is currently no supported Unix VM for 64 bit Unix/Linux platforms. John is working on providing supported 64 bit VMs for OS X, although I can't say whether he has looked at the Mpeg plugin or not (I definely have not done so).
Dave
Hi, is there any list of the plugins that are currently safe to use in 64 bits platforms? I'll disable in the package the rest for all the architectures excepting i386.
On Thu, Jan 28, 2010 at 09:03:44PM +0100, Jos? L. Redrejo Rodr?guez wrote:
El jue, 28-01-2010 a las 14:43 -0500, David T. Lewis escribi??:
This is somebody trying to build an Mpeg plugin on a 64 bit machine. It will not work. The set of plugins that are currently safe to use on 64 bit platforms is much smaller than the set of plugins that appear in the generated sources in platforms/unix/src.
Bottom line: Don't do that. If you need the full range of plugins, you must compile in 32 bit mode and load the appropriate 32 bit libraries.
Unless someone speaks up to say otherwise, there is currently no supported Unix VM for 64 bit Unix/Linux platforms. John is working on providing supported 64 bit VMs for OS X, although I can't say whether he has looked at the Mpeg plugin or not (I definely have not done so).
Hi, is there any list of the plugins that are currently safe to use in 64 bits platforms? I'll disable in the package the rest for all the architectures excepting i386.
There is not an official list. Here are the plugins that I usually build on my personal system (AMD 64, SuSE):
BalloonEnginePlugin BitBltSimulation FilePlugin SocketPlugin UnixAioPlugin UnixOSProcessPlugin XDisplayControlPlugin LargeIntegersPlugin (*) SoundPlugin (*) AsynchFilePlugin (*) FileCopyPlugin (*) FFIPlugin
(*) These last four require patches (see Mantis) that have not yet been included in the Subversion sources.
I do think that you should be *very* cautious about distributing a VM compiled for -m64 on a mainstream Linux distribution. If it was just for server applications it would be fine, but many Linux users will want to run Etoys or Squeak with multimedia, and for this they need a supported 32-bit VM. They will be very disappointed if they try to run Squeak and the VM crashes, or if part of the system does not work because of missing plugins.
Dave
vm-dev@lists.squeakfoundation.org
-
Bert Freudenberg -
David T. Lewis -
John M McIntosh -
José L. Redrejo Rodríguez