See http://bugs.squeak.org/view.php?id=7103
With these changes, sound works on 64-bit Linux ALSA and OSS for both 32-bit and 64-bit images. There are changes to Cross/plugins/SoundPlugin/SoundPlugin.h so some updates will be required for win32 and Mac OS (minor changes to pass pointers properly).
Dave
On 27.04.2009, at 13:38, David T. Lewis wrote:
See http://bugs.squeak.org/view.php?id=7103
With these changes, sound works on 64-bit Linux ALSA and OSS for both 32-bit and 64-bit images. There are changes to Cross/plugins/SoundPlugin/ SoundPlugin.h so some updates will be required for win32 and Mac OS (minor changes to pass pointers properly).
Yay!
- Bert -
El lun, 27-04-2009 a las 07:38 -0400, David T. Lewis escribió:
See http://bugs.squeak.org/view.php?id=7103
With these changes, sound works on 64-bit Linux ALSA and OSS for both 32-bit and 64-bit images. There are changes to Cross/plugins/SoundPlugin/SoundPlugin.h so some updates will be required for win32 and Mac OS (minor changes to pass pointers properly).
Hi David. I think there are still some code that must be patched and you forgot to include in the patch in mantis. I've compiled the vm, patching the 3.10.4 sources and it still segfaults (using Debian Lenny + alsa).
I'm attaching the patch I've used (it should be the same patch you sent, but unified and all in one file, but it might help to know what is missed). The log is:
patching file platforms/Cross/plugins/SoundPlugin/SoundPlugin.h patching file platforms/unix/plugins/SoundPlugin/sqUnixSound.c patching file platforms/unix/vm-sound-ALSA/sqUnixSoundALSA.c patching file platforms/unix/vm-sound-MacOSX/sqUnixSoundMacOSX.c patching file platforms/unix/vm-sound-NAS/sqUnixSoundNAS.c patching file platforms/unix/vm-sound-null/sqUnixSoundNull.c patching file platforms/unix/vm-sound-OSS/sqUnixSoundOSS.c patching file platforms/unix/vm-sound-Sun/sqUnixSoundSun.c patching file platforms/unix/vm/SqSound.h
Regards José L.
On 27.04.2009, at 18:17, José L. Redrejo Rodríguez wrote:
El lun, 27-04-2009 a las 07:38 -0400, David T. Lewis escribió:
See http://bugs.squeak.org/view.php?id=7103
With these changes, sound works on 64-bit Linux ALSA and OSS for both 32-bit and 64-bit images. There are changes to Cross/plugins/SoundPlugin/ SoundPlugin.h so some updates will be required for win32 and Mac OS (minor changes to pass pointers properly).
Hi David. I think there are still some code that must be patched and you forgot to include in the patch in mantis. I've compiled the vm, patching the 3.10.4 sources and it still segfaults (using Debian Lenny + alsa).
I'm attaching the patch I've used (it should be the same patch you sent, but unified and all in one file, but it might help to know what is missed). The log is:
patching file platforms/Cross/plugins/SoundPlugin/SoundPlugin.h patching file platforms/unix/plugins/SoundPlugin/sqUnixSound.c patching file platforms/unix/vm-sound-ALSA/sqUnixSoundALSA.c patching file platforms/unix/vm-sound-MacOSX/sqUnixSoundMacOSX.c patching file platforms/unix/vm-sound-NAS/sqUnixSoundNAS.c patching file platforms/unix/vm-sound-null/sqUnixSoundNull.c patching file platforms/unix/vm-sound-OSS/sqUnixSoundOSS.c patching file platforms/unix/vm-sound-Sun/sqUnixSoundSun.c patching file platforms/unix/vm/SqSound.h
Regards José L. <sound64bits.dpatch>
You also need to regenerate the src/plugins/SoundPlugin.c file after applying the SoundPlugin-64bit-dtl.1.cs changeset.
- Bert -
El lun, 27-04-2009 a las 19:29 +0200, Bert Freudenberg escribió:
On 27.04.2009, at 18:17, José L. Redrejo Rodríguez wrote:
El lun, 27-04-2009 a las 07:38 -0400, David T. Lewis escribió:
See http://bugs.squeak.org/view.php?id=7103
With these changes, sound works on 64-bit Linux ALSA and OSS for both 32-bit and 64-bit images. There are changes to Cross/plugins/SoundPlugin/ SoundPlugin.h so some updates will be required for win32 and Mac OS (minor changes to pass pointers properly).
Hi David. I think there are still some code that must be patched and you forgot to include in the patch in mantis. I've compiled the vm, patching the 3.10.4 sources and it still segfaults (using Debian Lenny + alsa).
I'm attaching the patch I've used (it should be the same patch you sent, but unified and all in one file, but it might help to know what is missed). The log is:
patching file platforms/Cross/plugins/SoundPlugin/SoundPlugin.h patching file platforms/unix/plugins/SoundPlugin/sqUnixSound.c patching file platforms/unix/vm-sound-ALSA/sqUnixSoundALSA.c patching file platforms/unix/vm-sound-MacOSX/sqUnixSoundMacOSX.c patching file platforms/unix/vm-sound-NAS/sqUnixSoundNAS.c patching file platforms/unix/vm-sound-null/sqUnixSoundNull.c patching file platforms/unix/vm-sound-OSS/sqUnixSoundOSS.c patching file platforms/unix/vm-sound-Sun/sqUnixSoundSun.c patching file platforms/unix/vm/SqSound.h
Regards José L. <sound64bits.dpatch>
You also need to regenerate the src/plugins/SoundPlugin.c file after applying the SoundPlugin-64bit-dtl.1.cs changeset.
Thanks Bert, I had missed that. Now it works perfectly, I'm sending this email from an amd64 Lenny installation where Squeak sounds!!
Thanks very much David for your work, this has been an issue for a long time.
The same problem is still there with RomePlugin and GstreamerPlugin, both used in the eToys image. It would be great if you could also take a look at them. I'll fill a bug in mantis for them if that's better to track the problem.
Regards. José L.
On Mon, Apr 27, 2009 at 08:49:41PM +0200, Jos? L. Redrejo Rodr?guez wrote:
El lun, 27-04-2009 a las 19:29 +0200, Bert Freudenberg escribi??:
You also need to regenerate the src/plugins/SoundPlugin.c file after applying the SoundPlugin-64bit-dtl.1.cs changeset.
Thanks Bert, I had missed that. Now it works perfectly, I'm sending this email from an amd64 Lenny installation where Squeak sounds!!
Great, thanks for trying the patches.
Thanks very much David for your work, this has been an issue for a long time.
The same problem is still there with RomePlugin and GstreamerPlugin, both used in the eToys image. It would be great if you could also take a look at them. I'll fill a bug in mantis for them if that's better to track the problem.
Yes, it would be helpful if you can open Mantis bugs for these also. I am not really familiar with these two plugins, but I will be happy to take a look at them and see if I can get them working on 64-bit systems.
Dave
El lun, 27-04-2009 a las 17:09 -0400, David T. Lewis escribió:
On Mon, Apr 27, 2009 at 08:49:41PM +0200, Jos? L. Redrejo Rodr?guez wrote:
El lun, 27-04-2009 a las 19:29 +0200, Bert Freudenberg escribi??:
You also need to regenerate the src/plugins/SoundPlugin.c file after applying the SoundPlugin-64bit-dtl.1.cs changeset.
Thanks Bert, I had missed that. Now it works perfectly, I'm sending this email from an amd64 Lenny installation where Squeak sounds!!
Great, thanks for trying the patches.
Thanks very much David for your work, this has been an issue for a long time.
The same problem is still there with RomePlugin and GstreamerPlugin, both used in the eToys image. It would be great if you could also take a look at them. I'll fill a bug in mantis for them if that's better to track the problem.
Yes, it would be helpful if you can open Mantis bugs for these also. I am not really familiar with these two plugins, but I will be happy to take a look at them and see if I can get them working on 64-bit systems.
I've filled http://bugs.squeak.org/view.php?id=7344 for the Rome plugin. That one is really easy to reproduce.
I'll do more tests with gstreamer to document its fail as good as possible.
Thanks again. José L.
On Tue, Apr 28, 2009 at 09:32:55AM +0200, Jos? L. Redrejo Rodr?guez wrote:
El lun, 27-04-2009 a las 17:09 -0400, David T. Lewis escribi??:
On Mon, Apr 27, 2009 at 08:49:41PM +0200, Jos? L. Redrejo Rodr?guez wrote:
El lun, 27-04-2009 a las 19:29 +0200, Bert Freudenberg escribi??:
You also need to regenerate the src/plugins/SoundPlugin.c file after applying the SoundPlugin-64bit-dtl.1.cs changeset.
Thanks Bert, I had missed that. Now it works perfectly, I'm sending this email from an amd64 Lenny installation where Squeak sounds!!
Great, thanks for trying the patches.
Thanks very much David for your work, this has been an issue for a long time.
The same problem is still there with RomePlugin and GstreamerPlugin, both used in the eToys image. It would be great if you could also take a look at them. I'll fill a bug in mantis for them if that's better to track the problem.
Yes, it would be helpful if you can open Mantis bugs for these also. I am not really familiar with these two plugins, but I will be happy to take a look at them and see if I can get them working on 64-bit systems.
I've filled http://bugs.squeak.org/view.php?id=7344 for the Rome plugin. That one is really easy to reproduce.
I'll do more tests with gstreamer to document its fail as good as possible.
Thanks.
One more follow-up question concerning sound: Is the SoundCodecPlugin important for you on 64-bit Linux? This is used Klatt (Speaker default say: 'hello'). The plugin is separate from SoundPlugin, and it has not been updated for 64-bit systems. For example, if you evaluate "Speaker manWithEditor" and then put the editor in the trash, the VM will crash on a 64-bit platform. Is this important for EToys?
Dave
On 28.04.2009, at 12:13, David T. Lewis wrote:
On Tue, Apr 28, 2009 at 09:32:55AM +0200, Jos? L. Redrejo Rodr?guez wrote:
El lun, 27-04-2009 a las 17:09 -0400, David T. Lewis escribi??:
On Mon, Apr 27, 2009 at 08:49:41PM +0200, Jos? L. Redrejo Rodr? guez wrote:
El lun, 27-04-2009 a las 19:29 +0200, Bert Freudenberg escribi??:
You also need to regenerate the src/plugins/SoundPlugin.c file after applying the SoundPlugin-64bit-dtl.1.cs changeset.
Thanks Bert, I had missed that. Now it works perfectly, I'm sending this email from an amd64 Lenny installation where Squeak sounds!!
Great, thanks for trying the patches.
Thanks very much David for your work, this has been an issue for a long time.
The same problem is still there with RomePlugin and GstreamerPlugin, both used in the eToys image. It would be great if you could also take a look at them. I'll fill a bug in mantis for them if that's better to track the problem.
Yes, it would be helpful if you can open Mantis bugs for these also. I am not really familiar with these two plugins, but I will be happy to take a look at them and see if I can get them working on 64-bit systems.
I've filled http://bugs.squeak.org/view.php?id=7344 for the Rome plugin. That one is really easy to reproduce.
I'll do more tests with gstreamer to document its fail as good as possible.
Thanks.
One more follow-up question concerning sound: Is the SoundCodecPlugin important for you on 64-bit Linux? This is used Klatt (Speaker default say: 'hello'). The plugin is separate from SoundPlugin, and it has not been updated for 64-bit systems. For example, if you evaluate "Speaker manWithEditor" and then put the editor in the trash, the VM will crash on a 64-bit platform. Is this important for EToys?
Since there is no Etoys tile interface to the speech synthesis, the Etoys image currently does not include the Speech classes. So it's not urgent for us, though it would be a nice future addition.
- Bert -
vm-dev@lists.squeakfoundation.org