Vm-dev April 2024

vm-dev@lists.squeakfoundation.org

12 participants
61 discussions

[OpenSmalltalk/opensmalltalk-vm] af5f4f: use --whole-archive option instead of -whole-archi...
by David T Lewis 19 Apr '24

19 Apr '24

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: af5f4f883b6aca4369b52dc451f4be977f3c6967 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/af5f4f883b6aca4369… Author: David Stes <stes(a)telenet.be> Date: 2024-01-06 (Sat, 06 Jan 2024) Changed paths: M platforms/unix/config/Makefile.in Log Message: ----------- use --whole-archive option instead of -whole-archive for solaris ld Commit: 5473cde3bc0d3b97679633d6333fd9ce40a58d81 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/5473cde3bc0d3b9767… Author: David T Lewis <dtlewis290(a)gmail.com> Date: 2024-04-18 (Thu, 18 Apr 2024) Changed paths: M platforms/unix/config/Makefile.in Log Message: ----------- Merge pull request #673 from dcstes/whole-archive use --whole-archive option instead of -whole-archive for solaris ld Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/d926670ee265...54… To unsubscribe from these emails, change your notification settings at https://github.com/OpenSmalltalk/opensmalltalk-vm/settings/notifications

1 0

VM Maker: VMMaker.oscog-eem.3366.mcz
by commits＠source.squeak.org 18 Apr '24

18 Apr '24

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3366.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3366 Author: eem Time: 18 April 2024, 11:18:57.12491 am UUID: 791f24bd-c2cf-4601-b1a7-3fae30ee6c9b Ancestors: VMMaker.oscog-eem.3365 More concise implementation of FloatMathPlugin>>#primitiveLog10 (& nicer simulation). Simulation fixes (from simulating a Cuis 5.0 image). a) fix the simulation of setting primitiveDoMixedArithmetic & upscaleDisplayIfHighDPI, which can now be overridden on the command line. b) provide a default implementation of ioEventThreadAffinity for the threaded VM c) fix disassembly of jitted V3 methods d) fix simulation of the log: (log: 3) method; it forgot to return a result e) fix simulation of the JPEGReadWriter2Plugin, and the infinite recursion in its #sizeof: method (!!) =============== Diff against VMMaker.oscog-eem.3365 =============== Item was changed: ----- Method: CoInterpreter>>setImageHeaderFlagsFrom: (in category 'image save/restore') ----- setImageHeaderFlagsFrom: headerFlags "Set the flags that are contained in the 7th long of the image header. This is sent at image load time." imageHeaderFlags := headerFlags. "so as to preserve unrecognised flags." fullScreenFlag := headerFlags bitAnd: 1. imageFloatsBigEndian := (headerFlags noMask: 2) ifTrue: [1] ifFalse: [0]. "processHasThreadAffinity := headerFlags anyMask: 4. specific to CoInterpreterMT" flagInterpretedMethods := headerFlags anyMask: 8. preemptionYields := headerFlags noMask: 16. "noThreadingOfGUIThread := headerFlags anyMask: 32. specific to CoInterpreterMT" newFinalization := headerFlags anyMask: 64. sendWheelEvents := headerFlags anyMask: 128. + (self cCode: [primitiveDoMixedArithmetic < 0] + inSmalltalk: [primitiveDoMixedArithmetic isInteger and: [primitiveDoMixedArithmetic < 0]]) ifTrue: "i.e. has it not been set on the command line?" - primitiveDoMixedArithmetic < 0 ifTrue: "i.e. has it not been set on the command line?" [primitiveDoMixedArithmetic := headerFlags noMask: 256]. "N.B. flag mask 512 is responded to by the FilePlugin & FileAttributesPlugin" + (self cCode: [upscaleDisplayIfHighDPI < 0] + inSmalltalk: [upscaleDisplayIfHighDPI isInteger and: [upscaleDisplayIfHighDPI < 0]]) ifTrue: "i.e. has it not been set on the command line?" - upscaleDisplayIfHighDPI < 0 ifTrue: "i.e. has it not been set on the command line?" [upscaleDisplayIfHighDPI := headerFlags noMask: 1024]! Item was added: + ----- Method: CoInterpreterMT>>ioEventThreadAffinity (in category 'threading support') ----- + ioEventThreadAffinity + "Default" + ^-1! Item was changed: ----- Method: Cogit>>methodSelectorStringFor: (in category 'disassembly') ----- methodSelectorStringFor: cogMethod "Answer either the hex string or the selector for a method, if it has a valid selector. For full blocks, prepend ``[full address] '' to the selector." <doNotGenerate> + (cogMethod cmType > CMOpenPIC + and: [cogMethod cmIsFullBlock]) ifTrue: - cogMethod cmIsFullBlock ifTrue: [| rawString | rawString := String streamContents: [:s| s nextPutAll: '[full '. cogMethod asInteger printOn: s base: 16. "omits 16r prefix". s nextPut: $]]. (coInterpreter maybeSelectorOfMethod: cogMethod methodObject) ifNotNil: [:selector| (objectRepresentation couldBeObject: selector) ifTrue: [^rawString, ' ', (coInterpreter stringOf: selector)]]. ^rawString]. cogMethod selector = objectMemory nilObject ifTrue: [^cogMethod asInteger hex,'(nil sel)']. (objectRepresentation couldBeObject: cogMethod selector) ifTrue: [^coInterpreter stringOf: cogMethod selector]. ^cogMethod asInteger hex! Item was changed: ----- Method: FloatMathPlugin>>primitiveLog10 (in category 'float primitives') ----- primitiveLog10 "Computes log10(receiver)" <export: true> <primitiveMetadata: #(FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag)> | rcvr result | <var: #rcvr type: #double> <var: #result type: #double> rcvr := interpreterProxy stackFloatValue: 0. + interpreterProxy failed ifFalse: + [rcvr >= 0.0 ifTrue: + [result := self __ieee754_log10: rcvr. + (self isnan: result) ifFalse: + [^interpreterProxy methodReturnFloat: result]]]. + ^interpreterProxy primitiveFail! - interpreterProxy failed ifTrue:[^nil]. - rcvr < 0.0 ifTrue:[^interpreterProxy primitiveFail]. - result := self cCode: '__ieee754_log10(rcvr)' inSmalltalk: [rcvr log: 10]. - (self isnan: result) ifTrue:[^interpreterProxy primitiveFail]. - ^interpreterProxy methodReturnFloat: result! Item was added: + ----- Method: FloatMathPluginSimulator>>__ieee754_log10: (in category 'float primitives') ----- + __ieee754_log10: aFloat + ^aFloat log: 10! Item was changed: ----- Method: Integer>>coerceTo:sim: (in category '*VMMaker-interpreter simulator') ----- coerceTo: cTypeString sim: interpreter | bits unitSize | cTypeString last == $* ifTrue: "C pointer" [unitSize := cTypeString caseOf: { [#'char *'] -> [1]. [#'short *'] -> [2]. [#'int *'] -> [4]. [#'long long *'] -> [8]. [#'float *'] -> [^CFloatArray basicNew interpreter: interpreter address: self unitSize: 4; yourself]. [#'double *'] -> [^CFloatArray basicNew interpreter: interpreter address: self unitSize: 8; yourself]. [#'unsigned *'] -> [4]. [#'unsigned int *'] -> [4]. [#'unsigned char *'] -> [1]. [#'signed char *'] -> [1]. [#'unsigned short *'] -> [2]. [#'unsigned long long *'] -> [8]. [#'oop *'] -> [interpreter objectMemory bytesPerOop]. } otherwise: [interpreter objectMemory wordSize]. ^CArray basicNew interpreter: interpreter address: self unitSize: unitSize; yourself]. cTypeString first == $u ifTrue: [bits := cTypeString caseOf: { [#usqInt] -> [interpreter objectMemory wordSize * 8]. [#usqLong] -> [64]. [#unsigned] -> [32]. [#'unsigned char'] -> [8]. [#'unsigned int'] -> [8]. [#'unsigned long'] -> [48]. "LLP64 on Windows :-(" [#'unsigned long long'] -> [64]. [#'unsigned short'] -> [16]. } otherwise: [self error: 'unknown unsigned integer type name']. ^self bitAnd: 1 << bits - 1]. bits := cTypeString caseOf: { [#sqInt] -> [interpreter objectMemory wordSize * 8]. [#'sqIntptr_t'] -> [interpreter objectMemory wordSize * 8]. [#sqLong] -> [64]. [#char] -> [^self bitAnd: 255]. "char may be signed, may be unsigned; interpret as unsigned by default" [#'signed char'] -> [8]. [#'short'] -> [16]. [#int] -> [32]. [#long] -> [48]. "LLP64 on Windows :-(" [#'long long'] -> [64]. [#'wint_t'] -> [24]. "unsigned short on Windows; int elsewhere" [#double] -> [^self asFloat]. } + otherwise: + ["exceptions for unusual cases..." + cTypeString == #'j_decompress_ptr' ifTrue: + [^self coerceTo: 'j_decompress *' sim: interpreter]. + "abort..." + self error: 'unknown signed integer type name']. - otherwise: [self error: 'unknown signed integer type name']. ^(self bitAnd: (1 bitShift: bits) - 1) - ((self bitAnd: (1 bitShift: bits - 1)) bitShift: 1)! Item was changed: ----- Method: InterpreterPrimitives>>log: (in category 'primitive support') ----- log: aFloat "Simulate the C library log:(3) function." <doNotGenerate> + ^aFloat = aFloat - aFloat = aFloat ifTrue: [aFloat ln] ifFalse: [Float nan]! Item was changed: ----- Method: JPEGReadWriter2Plugin>>sizeof: (in category 'simulation') ----- sizeof: aSymbol <doNotGenerate> ^aSymbol caseOf: { + [#'struct jpeg_compress_struct'] -> [JPEGReadWriter2 new primJPEGCompressStructSize]. + [#'struct jpeg_decompress_struct'] -> [JPEGReadWriter2 new primJPEGDecompressStructSize]. + [#'struct error_mgr2'] -> [JPEGReadWriter2 new primJPEGErrorMgr2StructSize] } - [self sizeof: #'struct jpeg_compress_struct'] -> [JPEGReadWriter2 new primJPEGCompressStructSize]. - [self sizeof: #'struct jpeg_decompress_struct'] -> [JPEGReadWriter2 new primJPEGDecompressStructSize]. - [self sizeof: #'struct error_mgr2'] -> [JPEGReadWriter2 new primJPEGErrorMgr2StructSize] } otherwise: [super sizeof: aSymbol]!

1 0

VM Maker: VMMaker.oscog-eem.3365.mcz
by commits＠source.squeak.org 18 Apr '24

18 Apr '24

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3365.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3365 Author: eem Time: 17 April 2024, 4:17:09.846667 pm UUID: d067e715-4de3-4931-8c6e-5884b5fbab91 Ancestors: VMMaker.oscog-eem.3364 First pass at getting threaded VM to work on Mac. Only call ioProcessEvents if teh platform doesn't care (doesn't define ioEventThreadAffinity, or defines it as 0) or the current thread id is the same as ioEventThreadAffinity. Nuke vmOwnerAddress & vmOwnerFromMachineCode which were used only by the pre-C-atomics access code to generate the machine code accessors for vmOwner. =============== Diff against VMMaker.oscog-eem.3364 =============== Item was changed: ----- Method: CoInterpreterMT>>checkForEventsMayContextSwitch: (in category 'process primitive support') ----- checkForEventsMayContextSwitch: mayContextSwitch "Check for possible interrupts and handle one if necessary. Answer if a context switch has occurred." + | switched sema now threadingThwartsIOProcessEventsInvocation | - | switched sema now | <inline: false> <var: #now type: #usqLong> self assertSaneThreadAndProcess. cogit assertCStackWellAligned. statCheckForEvents := statCheckForEvents + 1. "restore the stackLimit if it has been smashed." self restoreStackLimit. self externalWriteBackHeadFramePointers. self assert: stackPage = stackPages mostRecentlyUsedPage. "Allow the platform to do anything it needs to do synchronously." self ioSynchronousCheckForEvents. self checkCogCompiledCodeCompactionCalledFor. objectMemory needGCFlag ifTrue: ["sufficientSpaceAfterGC: runs the incremental GC and then, if not enough space is available, the fullGC." (objectMemory sufficientSpaceAfterGC: 0) ifFalse: [self setSignalLowSpaceFlagAndSaveProcess]]. mayContextSwitch ifFalse: [^false]. switched := false. self assert: deferThreadSwitch not. deferThreadSwitch := true. (profileProcess ~= objectMemory nilObject or: [nextProfileTick > 0 and:[self ioHighResClock >= nextProfileTick]]) ifTrue: [self zeroNextProfileTick. "Take a sample (if not already done so) for the profiler if it is active. This must be done before any of the synchronousSignals below or else we will attribute a pause in ioRelinquishProcessor to the newly activated process." profileProcess = objectMemory nilObject ifTrue: [profileProcess := self activeProcess. profileMethod := objectMemory nilObject]. "and signal the profiler semaphore if it is present" (profileSemaphore ~= objectMemory nilObject and: [self synchronousSignal: profileSemaphore]) ifTrue: [switched := true]]. self cppIf: #LRPCheck ifTrue: [self checkDeliveryOfLongRunningPrimitiveSignal ifTrue: [switched := true]]. objectMemory signalLowSpace ifTrue: [objectMemory signalLowSpace: false. "reset flag" sema := objectMemory splObj: TheLowSpaceSemaphore. (sema ~= objectMemory nilObject and: [self synchronousSignal: sema]) ifTrue: [switched := true]]. + threadingThwartsIOProcessEventsInvocation := self checkInvokeIOProcessEvents: (now := self ioUTCMicroseconds). - "inIOProcessEvents prevents reentrancy into ioProcessEvents and allows disabling - ioProcessEvents e.g. for native GUIs. We would like to manage that here but can't - since the platform code may choose to call ioProcessEvents itself in various places." - false - ifTrue: - [((now := self ioUTCMicroseconds) >= nextPollUsecs - and: [inIOProcessEvents = 0]) ifTrue: - [statIOProcessEvents := statIOProcessEvents + 1. - inIOProcessEvents := inIOProcessEvents + 1. - self ioProcessEvents. "sets interruptPending if interrupt key pressed; may callback" - inIOProcessEvents > 0 ifTrue: - [inIOProcessEvents := inIOProcessEvents - 1]. - nextPollUsecs := now + 20000 - "msecs to wait before next call to ioProcessEvents. Note that strictly - speaking we might need to update 'now' at this point since - ioProcessEvents could take a very long time on some platforms"]] - ifFalse: - [(now := self ioUTCMicroseconds) >= nextPollUsecs ifTrue: - [statIOProcessEvents := statIOProcessEvents + 1. - self ioProcessEvents. "sets interruptPending if interrupt key pressed; may callback" - nextPollUsecs := now + 20000 - "msecs to wait before next call to ioProcessEvents. Note that strictly - speaking we might need to update 'now' at this point since - ioProcessEvents could take a very long time on some platforms"]]. interruptPending ifTrue: [interruptPending := false. "reset interrupt flag" sema := objectMemory splObj: TheInterruptSemaphore. (sema ~= objectMemory nilObject and: [self synchronousSignal: sema]) ifTrue: [switched := true]]. nextWakeupUsecs ~= 0 ifTrue: [now >= nextWakeupUsecs ifTrue: [nextWakeupUsecs := 0. "set timer interrupt to 0 for 'no timer'" sema := objectMemory splObj: TheTimerSemaphore. (sema ~= objectMemory nilObject and: [self synchronousSignal: sema]) ifTrue: [switched := true]]]. "signal any pending finalizations" pendingFinalizationSignals > 0 ifTrue: [pendingFinalizationSignals := 0. sema := objectMemory splObj: TheFinalizationSemaphore. (sema ~= objectMemory nilObject and: [self synchronousSignal: sema]) ifTrue: [switched := true]]. "signal all semaphores in semaphoresToSignal" self signalExternalSemaphores ifTrue: [switched := true]. deferThreadSwitch := false. + (threadingThwartsIOProcessEventsInvocation + or: [checkThreadActivation]) ifTrue: - checkThreadActivation ifTrue: [checkThreadActivation := false. self cedeToHigherPriorityThreads]. "N.B. This may not return if we do switch." self threadSwitchIfNecessary: self activeProcess from: CSCheckEvents. ^switched! Item was added: + ----- Method: CoInterpreterMT>>checkInvokeIOProcessEvents: (in category 'process primitive support') ----- + checkInvokeIOProcessEvents: now + "Some platforms allow event resaponse only from a subset of threads (e.g. on Mac, the main application thread). + Override to check if the platform allows us to invoke or not and answer true if ioProcessEvents should have been + invoked but wasn't because of thread affinity." + <inline: #always> + (self ioEventThreadAffinity > 0 + and: [self ioEventThreadAffinity ~= cogThreadManager getVMOwner]) ifTrue: + [^now >= nextPollUsecs]. + super checkInvokeIOProcessEvents: now. + ^false! Item was removed: - ----- Method: CoInterpreterMT>>vmOwnerAddress (in category 'simulation') ----- - vmOwnerAddress - <doNotGenerate> - ^cogThreadManager vmOwnerAddress! Item was removed: - ----- Method: CogThreadManager>>vmOwnerAddress (in category 'Cogit lock implementation') ----- - vmOwnerAddress - <api> "NB. For the JIT only, so it can generate the lock & unlock functions." - <returnTypeC: #usqInt> - self error: 'Deprecated!! Replaced by proper atomic functions'. - ^self - cCode: [(self addressOf: vmOwner) asUnsignedInteger] - inSmalltalk: [cogit simulatedReadWriteVariableAddress: #vmOwnerFromMachineCode in: self]! Item was removed: - ----- Method: CogThreadManager>>vmOwnerFromMachineCode (in category 'Cogit lock implementation') ----- - vmOwnerFromMachineCode - <doNotGenerate> - self error: 'Deprecated!! Replaced by proper atomic C functions'. - ^vmOwner! Item was removed: - ----- Method: CogThreadManager>>vmOwnerFromMachineCode: (in category 'Cogit lock implementation') ----- - vmOwnerFromMachineCode: aValue - <doNotGenerate> - self error: 'Deprecated!! Replaced by proper atomic C functions'. - self assert: (aValue between: 0 and: numThreads). - vmOwner := aValue! Item was changed: ----- Method: StackInterpreter>>checkForEventsMayContextSwitch: (in category 'process primitive support') ----- checkForEventsMayContextSwitch: mayContextSwitch "Check for possible interrupts and handle one if necessary. Answer if a context switch has occurred." | switched sema now | <inline: false> <var: #now type: #usqLong> statCheckForEvents := statCheckForEvents + 1. "restore the stackLimit if it has been smashed." self restoreStackLimit. self externalWriteBackHeadFramePointers. self assert: stackPage = stackPages mostRecentlyUsedPage. "Allow the platform to do anything it needs to do synchronously." self ioSynchronousCheckForEvents. self checkCogCompiledCodeCompactionCalledFor. objectMemory needGCFlag ifTrue: ["sufficientSpaceAfterGC: runs the incremental GC and then, if not enough space is available, the fullGC." (objectMemory sufficientSpaceAfterGC: 0) ifFalse: [self setSignalLowSpaceFlagAndSaveProcess]]. mayContextSwitch ifFalse: [^false]. switched := false. (profileProcess ~= objectMemory nilObject or: [nextProfileTick > 0 and:[self ioHighResClock >= nextProfileTick]]) ifTrue: [self zeroNextProfileTick. "Take a sample (if not already done so) for the profiler if it is active. This must be done before any of the synchronousSignals below or else we will attribute a pause in ioRelinquishProcessor to the newly activated process." profileProcess = objectMemory nilObject ifTrue: [profileProcess := self activeProcess. profileMethod := objectMemory nilObject]. "and signal the profiler semaphore if it is present" (profileSemaphore ~= objectMemory nilObject and: [self synchronousSignal: profileSemaphore]) ifTrue: [switched := true]]. self cppIf: #LRPCheck ifTrue: [self checkDeliveryOfLongRunningPrimitiveSignal ifTrue: [switched := true]]. objectMemory signalLowSpace ifTrue: [objectMemory signalLowSpace: false. "reset flag" sema := objectMemory splObj: TheLowSpaceSemaphore. (sema ~= objectMemory nilObject and: [self synchronousSignal: sema]) ifTrue: [switched := true]]. + self checkInvokeIOProcessEvents: (now := self ioUTCMicroseconds). - "inIOProcessEvents prevents reentrancy into ioProcessEvents and allows disabling - ioProcessEvents e.g. for native GUIs. We would like to manage that here but can't - since the platform code may choose to call ioProcessEvents itself in various places." - false - ifTrue: - [((now := self ioUTCMicroseconds) >= nextPollUsecs - and: [inIOProcessEvents = 0]) ifTrue: - [statIOProcessEvents := statIOProcessEvents + 1. - inIOProcessEvents := inIOProcessEvents + 1. - self ioProcessEvents. "sets interruptPending if interrupt key pressed; may callback" - inIOProcessEvents > 0 ifTrue: - [inIOProcessEvents := inIOProcessEvents - 1]. - nextPollUsecs := now + 20000 - "msecs to wait before next call to ioProcessEvents. Note that strictly - speaking we might need to update 'now' at this point since - ioProcessEvents could take a very long time on some platforms"]] - ifFalse: - [(now := self ioUTCMicroseconds) >= nextPollUsecs ifTrue: - [statIOProcessEvents := statIOProcessEvents + 1. - self ioProcessEvents. "sets interruptPending if interrupt key pressed; may callback" - nextPollUsecs := now + 20000 - "msecs to wait before next call to ioProcessEvents. Note that strictly - speaking we might need to update 'now' at this point since - ioProcessEvents could take a very long time on some platforms"]]. interruptPending ifTrue: [interruptPending := false. "reset interrupt flag" sema := objectMemory splObj: TheInterruptSemaphore. (sema ~= objectMemory nilObject and: [self synchronousSignal: sema]) ifTrue: [switched := true]]. nextWakeupUsecs ~= 0 ifTrue: [now >= nextWakeupUsecs ifTrue: [nextWakeupUsecs := 0. "set timer interrupt to 0 for 'no timer'" sema := objectMemory splObj: TheTimerSemaphore. (sema ~= objectMemory nilObject and: [self synchronousSignal: sema]) ifTrue: [switched := true]]]. "signal any pending finalizations" pendingFinalizationSignals > 0 ifTrue: [pendingFinalizationSignals := 0. sema := objectMemory splObj: TheFinalizationSemaphore. (sema ~= objectMemory nilObject and: [self synchronousSignal: sema]) ifTrue: [switched := true]]. "signal all semaphores in semaphoresToSignal" self signalExternalSemaphores ifTrue: [switched := true]. ^switched! Item was added: + ----- Method: StackInterpreter>>checkInvokeIOProcessEvents: (in category 'process primitive support') ----- + checkInvokeIOProcessEvents: now + "inIOProcessEvents prevents reentrancy into ioProcessEvents and allows disabling + ioProcessEvents e.g. for native GUIs. We would like to manage that here but can't + since the platform code may choose to call ioProcessEvents itself in various places." + <inline: #always> + false + ifTrue: + [(now >= nextPollUsecs + and: [inIOProcessEvents = 0]) ifTrue: + [statIOProcessEvents := statIOProcessEvents + 1. + inIOProcessEvents := inIOProcessEvents + 1. + self ioProcessEvents. "sets interruptPending if interrupt key pressed; may callback" + inIOProcessEvents > 0 ifTrue: + [inIOProcessEvents := inIOProcessEvents - 1]. + nextPollUsecs := now + 20000 + "msecs to wait before next call to ioProcessEvents. Note that strictly + speaking we might need to update 'now' at this point since + ioProcessEvents could take a very long time on some platforms"]] + ifFalse: + [now >= nextPollUsecs ifTrue: + [statIOProcessEvents := statIOProcessEvents + 1. + self ioProcessEvents. "sets interruptPending if interrupt key pressed; may callback" + nextPollUsecs := now + 20000 + "msecs to wait before next call to ioProcessEvents. Note that strictly + speaking we might need to update 'now' at this point since + ioProcessEvents could take a very long time on some platforms"]].!

3 2

VM Maker: VMMaker.oscog-eem.3364.mcz
by commits＠source.squeak.org 18 Apr '24

18 Apr '24

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3364.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3364 Author: eem Time: 17 April 2024, 4:13:25.775126 pm UUID: c0aef66b-b635-4039-897e-d58fa07a050b Ancestors: VMMaker.oscog-eem.3363 A better fix to the non-inlining of isAlien: in assert: is not to mark isAlien: as <inline: #always> but <inline: true>. That was a mistake on my part. Apologies. =============== Diff against VMMaker.oscog-eem.3363 =============== Item was changed: ----- Method: InterpreterPlugin>>isAlien: (in category 'alien support') ----- isAlien: oop "Answer if oop is an Alien. We could ask if isWordsOrBytes: first, but that doesn't help. We still have to do the is:KindOf: walk. We're not interested in fast falsehood, but as fast as possible truth, and with the current API this is it." + <inline: true> - <inline: #always> ^interpreterProxy is: oop KindOfClass: interpreterProxy classAlien! Item was changed: ----- Method: ThreadedFFIPlugin>>isDirectAlien: (in category 'primitive support') ----- isDirectAlien: oop <inline: #always> + self assert: (self isAlien: oop). - "self assert: (self isAlien: oop). -- nested inlining is ignored for #isAlien:. Expand here." - self assert: (interpreterProxy is: oop KindOfClass: interpreterProxy classAlien). ^(self sizeField: oop) > 0!

1 0

VM Maker: VMMaker.oscog-eem.3363.mcz
by commits＠source.squeak.org 18 Apr '24

18 Apr '24

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3363.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3363 Author: eem Time: 17 April 2024, 4:08:09.099496 pm UUID: ef2ede81-25f0-41f4-ab60-14f7bb01111a Ancestors: VMMaker.oscog-mt.3362 A couple of methods should use objectMemory displayObject rather than access TheDisplay directly. =============== Diff against VMMaker.oscog-mt.3362 =============== Item was changed: ----- Method: StackInterpreter>>postGCUpdateDisplayBits (in category 'object memory support') ----- postGCUpdateDisplayBits "Update the displayBits after a GC may have moved it. Answer if the displayBits appear valid. The wrinkle here is that the displayBits could be a surface handle." <inline: false> | displayObj bitsOop bitsNow | + displayObj := objectMemory displayObject. - displayObj := objectMemory splObj: TheDisplay. ((objectMemory isPointers: displayObj) and: [(objectMemory lengthOf: displayObj) >= 4]) ifFalse: [^false]. bitsOop := objectMemory followOopField: 0 ofObject: displayObj. (bitsOop = objectMemory nilObject "it ain't yet set" or: [objectMemory isIntegerObject: bitsOop]) ifTrue: "It's a surface; our work here is done..." [^true]. self assert: ((objectMemory addressCouldBeObj: bitsOop) and: [objectMemory isWordsOrBytes: bitsOop]). (objectMemory hasSpurMemoryManagerAPI and: [objectMemory isPinned: bitsOop]) ifFalse: [(objectMemory hasSpurMemoryManagerAPI and: [stackPage notNil]) ifTrue: "If stackPage is nil we're snapshotting and now is not the time to pin." [objectMemory pinObject: bitsOop. bitsOop := objectMemory followOopField: 0 ofObject: displayObj]. bitsNow := self cCode: [objectMemory firstIndexableField: bitsOop] inSmalltalk: [(objectMemory firstIndexableField: bitsOop) asInteger]. displayBits ~= bitsNow ifTrue: [displayBits := bitsNow. self ioNoteDisplayChanged: displayBits width: displayWidth height: displayHeight depth: displayDepth]]. ^true! Item was changed: ----- Method: StackInterpreter>>showDisplayBits:Left:Top:Right:Bottom: (in category 'I/O primitive support') ----- showDisplayBits: aForm Left: l Top: t Right: r Bottom: b "Repaint the portion of the Smalltalk screen bounded by the affected rectangle. Used to synchronize the screen after a Bitblt to the Smalltalk Display object." (deferDisplayUpdates + or: [aForm ~= objectMemory displayObject]) ifTrue: [^nil]. - or: [aForm ~= (objectMemory splObj: TheDisplay)]) ifTrue: [^nil]. self updateDisplayLeft: l Top: t Right: r Bottom: b!

1 0

[OpenSmalltalk/opensmalltalk-vm] pthread_jit_write_with_callback_np() vs. pthread_jit_write_protect_np() (Issue #682)
by Marcel Taeumel 17 Apr '24

17 Apr '24

Apple suggests `pthread_jit_write_with_callback_np()` and a *JIT callback allow list* via the `com.apple.security.cs.jit-write-allowlist` entitlement as the way to port a JIT to Apple silicon. - https://developer.apple.com/documentation/apple-silicon/porting-just-in-tim… We use `pthread_jit_write_protect_np()` at this point. How much longer is this going to work? Maybe we want to refactor this to the callback approach? - https://keith.github.io/xcode-man-pages/pthread_jit_write_protect_np.3.html… This is just a heads-up. 😺 -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/682 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/issues/682(a)github.com>

2 1

[OpenSmalltalk/opensmalltalk-vm] 8e5c04: CogVM source as per VMMaker.oscog-mt.3362 [ci skip]
by Marcel Taeumel 16 Apr '24

16 Apr '24

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 8e5c04d2d4fbbb1f6357fa7193790e7e261b0d50 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/8e5c04d2d4fbbb1f63… Author: Marcel Taeumel <marcel.taeumel(a)hpi.de> Date: 2024-04-16 (Tue, 16 Apr 2024) Changed paths: M src/plugins/FilePlugin/FilePlugin.c M src/plugins/SocketPlugin/SocketPlugin.c M src/plugins/SqueakFFIPrims/ARM32FFIPlugin.c M src/plugins/SqueakFFIPrims/ARM64AppleFFIPlugin.c M src/plugins/SqueakFFIPrims/ARM64FFIPlugin.c M src/plugins/SqueakFFIPrims/IA32FFIPlugin.c M src/plugins/SqueakFFIPrims/RiscV64FFIPlugin.c M src/plugins/SqueakFFIPrims/SqueakFFIPrims.c M src/plugins/SqueakFFIPrims/X64SysVFFIPlugin.c M src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c M src/plugins/SqueakSSL/SqueakSSL.c M src/spur32.cog.lowcode/cointerp.c M src/spur32.cog.lowcode/cointerp.h M src/spur32.cog.lowcode/gcc3x-cointerp.c M src/spur32.cog.lowcode/interp.h M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/cointerpmt.c M src/spur32.cog/cointerpmt.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.cog/gcc3x-cointerpmt.c M src/spur32.cog/interp.h M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur32.sista/interp.h M src/spur32.stack.newspeak/gcc3x-interp.c M src/spur32.stack.newspeak/interp.c M src/spur32.stack.newspeak/interp.h M src/spur32.stack.newspeak/vmCallback.h M src/spur32.stack/gcc3x-interp.c M src/spur32.stack/interp.c M src/spur32.stack/interp.h M src/spur32.stack/validImage.c M src/spur32.stack/vmCallback.h M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/cointerpmt.c M src/spur64.cog/cointerpmt.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.cog/interp.h M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c M src/spur64.sista/interp.h M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c M src/spur64.stack/interp.h M src/spur64.stack/validImage.c M src/v3.cog/cointerp.c M src/v3.cog/cointerp.h M src/v3.cog/gcc3x-cointerp.c M src/v3.cog/interp.h M src/v3.stack/gcc3x-interp.c M src/v3.stack/interp.c M src/v3.stack/interp.h Log Message: ----------- CogVM source as per VMMaker.oscog-mt.3362 [ci skip] Commit: d926670ee26591e2fe4a33c7aae2569c4679e726 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/d926670ee26591e2fe… Author: Marcel Taeumel <marcel.taeumel(a)hpi.de> Date: 2024-04-16 (Tue, 16 Apr 2024) Changed paths: M platforms/Cross/plugins/IA32ABI/arm32abicc.c M platforms/Cross/plugins/IA32ABI/arm64abicc.c M platforms/Cross/plugins/IA32ABI/ia32abicc.c M platforms/Cross/plugins/IA32ABI/riscv64abicc.c M platforms/Cross/plugins/IA32ABI/x64sysvabicc.c M platforms/Cross/plugins/IA32ABI/x64win64abicc.c M platforms/Cross/vm/sqVirtualMachine.c M platforms/Cross/vm/sqVirtualMachine.h Log Message: ----------- Adjust cross-platform code for new disownVM/ownVM API. Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/1b153ff230c2...d9… To unsubscribe from these emails, change your notification settings at https://github.com/OpenSmalltalk/opensmalltalk-vm/settings/notifications

1 0

VM Maker: VMMaker.oscog-mt.3362.mcz
by commits＠source.squeak.org 16 Apr '24

16 Apr '24

Marcel Taeumel uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-mt.3362.mcz ==================== Summary ==================== Name: VMMaker.oscog-mt.3362 Author: mt Time: 16 April 2024, 6:10:14.519284 pm UUID: b8f74e14-6430-924d-93fb-2fc1cd50ba34 Ancestors: VMMaker.oscog-mt.3361 Minor workarounds for clang18 and Slang code generation: - for COGMTVM, return type for #sqSocketCloseConnection:isPinned: must also be void, not int - #vmHandle must always be void* - nested-inlining seems to be broken for #isDirectAlien:, so expand #isAlien: manually =============== Diff against VMMaker.oscog-mt.3361 =============== Item was changed: ----- Method: SocketPlugin>>sqSocketCloseConnection:isPinned: (in category 'simulation') ----- + sqSocketCloseConnection: socketHandleCArray isPinned: isSocketPinned - sqSocketCloseConnection: socketHandleCArray isPinned: isPinned <private> <option: #COGMTVM> <inline: #always> + | handle | + <var: #handle type: #'void *'> + isSocketPinned ifTrue: [handle := interpreterProxy disownVM: DisownVMForThreading]. + self sqSocketCloseConnection: socketHandleCArray. + isSocketPinned ifTrue: [interpreterProxy ownVM: handle].! - | result handle | - isPinned ifTrue: [handle := interpreterProxy disownVM: DisownVMForThreading]. - result := self sqSocketCloseConnection: socketHandleCArray. - isPinned ifTrue: [interpreterProxy ownVM: handle]. - ^ result! Item was changed: ----- Method: SqueakSSLPlugin>>primitiveConnect (in category 'primitives') ----- primitiveConnect "Primitive. Starts or continues a client handshake using the provided data. Will eventually produce output to be sent to the server. Requires the host name to be set for the session. Returns: > 0 - Number of bytes to be sent to the server 0 - Success. The connection is established. -1 - More input is required. < -1 - Other errors. " | start srcLen dstLen srcOop dstOop handle srcPtr dstPtr result vmHandle canDisown | <var: #srcPtr type: #'char *'> <var: #dstPtr type: #'char *'> + <var: #vmHandle type: #'void *'> <export: true> interpreterProxy methodArgumentCount = 5 ifFalse:[^interpreterProxy primitiveFail]. dstOop := interpreterProxy stackValue: 0. srcLen := interpreterProxy stackIntegerValue: 1. start := interpreterProxy stackIntegerValue: 2. srcOop := interpreterProxy stackValue: 3. handle := interpreterProxy stackIntegerValue: 4. interpreterProxy failed ifTrue:[^nil]. ((start > 0 and:[srcLen >= 0]) and:[(interpreterProxy isBytes: srcOop) and:[(interpreterProxy isBytes: dstOop) and:[(interpreterProxy byteSizeOf: srcOop) >= (start + srcLen - 1)]]]) ifFalse:[^interpreterProxy primitiveFail]. srcPtr := interpreterProxy firstIndexableField: srcOop. dstPtr := interpreterProxy firstIndexableField: dstOop. srcPtr := srcPtr + start - 1. dstLen := interpreterProxy byteSizeOf: dstOop. canDisown := (interpreterProxy isPinned: srcOop) and: [interpreterProxy isPinned: dstOop]. canDisown ifTrue: [vmHandle := interpreterProxy disownVM: DisownVMForThreading]. result := self sqConnectSSL: handle _: srcPtr _: srcLen _: dstPtr _: dstLen. canDisown ifTrue: [interpreterProxy ownVM: vmHandle]. interpreterProxy failed ifFalse: [interpreterProxy methodReturnInteger: result]! Item was changed: ----- Method: ThreadedFFIPlugin>>isDirectAlien: (in category 'primitive support') ----- isDirectAlien: oop <inline: #always> + "self assert: (self isAlien: oop). -- nested inlining is ignored for #isAlien:. Expand here." + self assert: (interpreterProxy is: oop KindOfClass: interpreterProxy classAlien). - self assert: (self isAlien: oop). ^(self sizeField: oop) > 0!

1 0

VM Maker: VMMaker.oscog-mt.3361.mcz
by commits＠source.squeak.org 16 Apr '24

16 Apr '24

Marcel Taeumel uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-mt.3361.mcz ==================== Summary ==================== Name: VMMaker.oscog-mt.3361 Author: mt Time: 16 April 2024, 6:05:40.062284 pm UUID: 42fd33c7-f3f9-2c4a-b874-0415e7cf2bce Ancestors: VMMaker.oscog-mt.3360 For single-threaded VM, following the recent efforts in multi-threaded VM, adjust #disownVM:/#ownVM: - rename 'inFFIFlags' to 'ffiCalloutVMHandle' - add flag DisownVMFromCallback to indicate disown from thunkEntry() - for callbacks push both newMethod and argumentCount on stack (Eliot, is this okay?) because the return value of #ownVM: should only indicate success or failure =============== Diff against VMMaker.oscog-mt.3360 =============== Item was changed: ----- Method: CoInterpreterMT>>ownVM: (in category 'vm scheduling') ----- ownVM: vmThreadHandle <public> <inline: false> <var: #vmThreadHandle type: #'void *'> + <var: #vmThread type: #'CogVMThread *'> + "This is the entry-point for plugins and primitives that wish to reacquire the VM after having + released it via disownVM or callbacks that want to acquire it without knowing their ownership + status. This call will block until the VM is owned by the current thread or an error occurs. + The argument should be the value answered by disownVM, or 0 for callbacks that don't know + if they have disowned or not. This is both an optimization to avoid having to query thread- + local storage for the current thread's index (since it can easily keep it in some local variable), + and a record of when an unbound process becomes affined to a thread for the dynamic + extent of some operation. + + Answer 0 if the current thread is known to the VM (and on return owns the VM). + Answer 1 if the current thread is unknown to the VM and takes ownership. + Answer -1 if the current thread is unknown to the VM and fails to take ownership." + | flags vmThread | + vmThread := self cCoerce: vmThreadHandle to: #'CogVMThread *'. + vmThread ifNil: + [^self ownVMFromUnidentifiedThread]. + + self assert: vmThread = (cogThreadManager vmThreadAt: vmThread index). + + flags := vmThread disownFlags. + + vmThread := cogThreadManager acquireVMFor: vmThread. + disownCount := disownCount - 1. + + (flags anyMask: DisownVMForProcessorRelinquish) ifTrue: + ["Presumably we have nothing to do; this primitive is typically called from the + background process. So we should /not/ try and activate any threads in the + pool; they will waste cycles finding there is no runnable process, and will + cause a VM abort if no runnable process is found. But we /do/ want to allow + FFI calls that have completed, or callbacks a chance to get into the VM; they + do have something to do. DisownVMForProcessorRelinquish indicates this." + relinquishing := false. + self sqLowLevelMFence]. + + disowningVMThread ifNotNil: + [vmThread = disowningVMThread ifTrue: + [self assert: (vmThread cFramePointer isNil + or: [CFramePointer = vmThread cFramePointer and: [CStackPointer = vmThread cStackPointer]]). + self assert: self successful. + self assert: (objectMemory fetchPointer: MyListIndex ofObject: self activeProcess) = objectMemory nilObject. + disowningVMThread := nil. + cogit recordEventTrace ifTrue: + [self recordTrace: TraceOwnVM thing: ConstOne source: 0]. + ^0]. "if not preempted we're done." + self preemptDisowningThread]. + + "We've been preempted; we must restore state and update the threadId + in our process, and may have to put the active process to sleep." + self restoreVMStateFor: vmThread andFlags: flags. + + cogit recordEventTrace ifTrue: + [self recordTrace: TraceOwnVM thing: ConstTwo source: 0]. + ^flags bitAnd: OwnVMForeignThreadFlag! - ^ self ownVM: vmThreadHandle withFlags: 0! Item was removed: - ----- Method: CoInterpreterMT>>ownVM:withFlags: (in category 'vm scheduling') ----- - ownVM: vmThreadHandle withFlags: additionalFlags - <public> - <inline: false> - <var: #vmThreadHandle type: #'void *'> - <var: #vmThread type: #'CogVMThread *'> - "This is the entry-point for plugins and primitives that wish to reacquire the VM after having - released it via disownVM or callbacks that want to acquire it without knowing their ownership - status. This call will block until the VM is owned by the current thread or an error occurs. - The argument should be the value answered by disownVM, or 0 for callbacks that don't know - if they have disowned or not. This is both an optimization to avoid having to query thread- - local storage for the current thread's index (since it can easily keep it in some local variable), - and a record of when an unbound process becomes affined to a thread for the dynamic - extent of some operation. - - Answer 0 if the current thread is known to the VM (and on return owns the VM). - Answer 1 if the current thread is unknown to the VM and takes ownership. - Answer -1 if the current thread is unknown to the VM and fails to take ownership." - | flags vmThread | - vmThread := self cCoerce: vmThreadHandle to: #'CogVMThread *'. - vmThread ifNil: - [^self ownVMFromUnidentifiedThread]. - - self assert: vmThread = (cogThreadManager vmThreadAt: vmThread index). - - flags := vmThread disownFlags bitOr: additionalFlags. - - vmThread := cogThreadManager acquireVMFor: vmThread. - disownCount := disownCount - 1. - - (flags anyMask: DisownVMForProcessorRelinquish) ifTrue: - ["Presumably we have nothing to do; this primitive is typically called from the - background process. So we should /not/ try and activate any threads in the - pool; they will waste cycles finding there is no runnable process, and will - cause a VM abort if no runnable process is found. But we /do/ want to allow - FFI calls that have completed, or callbacks a chance to get into the VM; they - do have something to do. DisownVMForProcessorRelinquish indicates this." - relinquishing := false. - self sqLowLevelMFence]. - - disowningVMThread ifNotNil: - [vmThread = disowningVMThread ifTrue: - [self assert: (vmThread cFramePointer isNil - or: [CFramePointer = vmThread cFramePointer and: [CStackPointer = vmThread cStackPointer]]). - self assert: self successful. - self assert: (objectMemory fetchPointer: MyListIndex ofObject: self activeProcess) = objectMemory nilObject. - disowningVMThread := nil. - cogit recordEventTrace ifTrue: - [self recordTrace: TraceOwnVM thing: ConstOne source: 0]. - ^0]. "if not preempted we're done." - self preemptDisowningThread]. - - "We've been preempted; we must restore state and update the threadId - in our process, and may have to put the active process to sleep." - self restoreVMStateFor: vmThread andFlags: flags. - - cogit recordEventTrace ifTrue: - [self recordTrace: TraceOwnVM thing: ConstTwo source: 0]. - ^flags bitAnd: OwnVMForeignThreadFlag! Item was removed: - ----- Method: CogVMSimulator>>ownVM:withFlags: (in category 'multi-threading simulation switch') ----- - ownVM: vmThreadHandle withFlags: additionalFlags - "This method includes or excludes CoInterpreterMT methods as required. - Auto-generated by CogVMSimulator>>ensureMultiThreadingOverridesAreUpToDate" - - ^self perform: #ownVM:withFlags: - withArguments: {vmThreadHandle. additionalFlags} - inSuperclass: (cogThreadManager ifNil: [CoInterpreterPrimitives] ifNotNil: [CoInterpreterMT])! Item was changed: VMClass subclass: #InterpreterPrimitives + instanceVariableNames: 'objectMemory messageSelector argumentCount newMethod primFailCode secondaryErrorCode exceptionPC ffiCalloutVMHandle profileMethod profileProcess profileSemaphore nextProfileTick preemptionYields sHEAFn ffiExceptionResponse eventTraceMask multipleBytecodeSetsActive' - instanceVariableNames: 'objectMemory messageSelector argumentCount newMethod primFailCode secondaryErrorCode exceptionPC inFFIFlags profileMethod profileProcess profileSemaphore nextProfileTick preemptionYields sHEAFn ffiExceptionResponse eventTraceMask multipleBytecodeSetsActive' classVariableNames: 'CrossedX EndOfRun MillisecondClockMask' poolDictionaries: 'VMBasicConstants VMBytecodeConstants VMMethodCacheConstants VMObjectIndices VMSqueakClassIndices VMStackFrameOffsets' category: 'VMMaker-Interpreter'! !InterpreterPrimitives commentStamp: 'eem 9/23/2021 13:20' prior: 0! InterpreterPrimitives implements most of the VM's core primitives. It is the root of the interpreter hierarchy so as to share the core primitives amongst the varioius interpreters. Instance Variables argumentCount <Integer> eventTraceMask <Integer> exceptionPC <Integer> ffiExceptionResponse <Integer> inFFIFlags <Integer> messageSelector <Integer> newMethod <Integer> nextProfileTick <Integer> objectMemory <ObjectMemory> (simulation only) preemptionYields <Boolean> primFailCode <Integer> secondaryErrorCode <Integer> profileMethod <Integer> profileProcess <Integer> profileSemaphore <Integer> sHEAFn <Integer> argumentCount - the number of arguments of the current message eventTraceMask - a bit mask corresponding to the Event type codes in sq.h that decides what events are printed in primitiveGetNextEvent exceptionPC - the pc of an exception for an exception reporting primitive failure such as PrimErrFFIException ffiExceptionResponse - controls system response to exceptions during FFI calls. See primitiveFailForFFIException:at: inFFIFlags - flags recording currently only whether the system is in an FFI call messageSelector - the oop of the selector of the current message newMethod - the oop of the result of looking up the current message nextProfileTick - the millisecond clock value of the next profile tick (if profiling is in effect) objectMemory - the memory manager and garbage collector that manages the heap preemptionYields - a boolean controlling the process primitives. If true (old, incorrect, blue-book semantics) a preempted process is sent to the back of its run-queue. If false, a process preempted by a higher-priority process is put back at the head of its run queue, hence preserving cooperative scheduling within priorities. primFailCode - primitive success/failure flag, 0 for success, otherwise the reason code for failure profileMethod - the primitive method active when the last profile sample was taken (if any) profileProcess - the process active when the last profile sample was taken profileSemaphore - the semaphore to be signalled when a profile sample is taken; if nil disables profiling secondaryErrorCode - a 64-bit value settable for clonable primitive failures (PrimErrOSError, PrimErrFFIException et al) profileMethod - the oop of the method at the time nextProfileTick was reached profileProcess - the oop of the activeProcess at the time nextProfileTick was reached profileSemaphore - the oop of the semaphore to signal when nextProfileTick is reached secondaryErrorCode - an additional value associated with various primitive failures sHEAFn - the function to call to check if access to the envronment should be granted to primitiveGetenv! Item was changed: ----- Method: InterpreterPrimitives class>>declareCVarsIn: (in category 'C translation') ----- declareCVarsIn: aCCodeGen aCCodeGen var: 'secondaryErrorCode' type: #sqLong; var: 'exceptionPC' type: #usqInt; + var: 'sHEAFn' declareC: 'int (*sHEAFn)() = 0'; "the hasEnvironmentAccess function" + var: 'ffiCalloutVMHandle' type: #'void *'! - var: 'sHEAFn' declareC: 'int (*sHEAFn)() = 0' "the hasEnvironmentAccess function"! Item was changed: ----- Method: InterpreterPrimitives>>initialize (in category 'initialization') ----- initialize "Here we can initialize the variables C initializes to zero. #initialize methods do /not/ get translated." + argumentCount := primFailCode := nextProfileTick := secondaryErrorCode := exceptionPC := ffiExceptionResponse := eventTraceMask := 0. + ffiCalloutVMHandle := nil.! - argumentCount := primFailCode := nextProfileTick := secondaryErrorCode := exceptionPC := inFFIFlags := ffiExceptionResponse := eventTraceMask := 0! Item was changed: ----- Method: InterpreterPrimitives>>primitiveFailForFFIException:at: (in category 'primitive support') ----- primitiveFailForFFIException: exceptionCode at: pc <var: 'exceptionCode' type: #usqLong> <var: 'pc' type: #usqInt> "Set PrimErrFFIException primitive failure and associated exceptionCode (a.k.a. secondaryErrorCode) and exceptionPC. Under control of the ffiExceptionResponse flag, + if in a primitive with an error code and ffiCalloutVMHandle indicates we're in an FFI call, - if in a primitive with an error code and the inFFIFlags indicate we're in an FFI call, then fail the primitive. ffiExceptionResponse < 0 never fail ffiExceptionResponse = 0 fail if method has a primitive error code (default) ffiExceptionResponse > 0 always fail" <public> + (ffiCalloutVMHandle isNil "i.e. not in an FFI call" - ((inFFIFlags noMask: DisownVMForFFICall) "i.e. not in an FFI call" or: [ffiExceptionResponse < 0]) ifTrue: "i.e. never fail" [^self]. secondaryErrorCode := self cCoerceSimple: exceptionCode to: #sqLong. exceptionPC := pc. primFailCode := PrimErrFFIException. (ffiExceptionResponse > 0 "always fail..." or: [(objectMemory isOopCompiledMethod: newMethod) and: [self methodUsesPrimitiveErrorCode: newMethod]]) ifTrue: + [self ownVM: ffiCalloutVMHandle. - [self ownVM: nil withFlags: DisownVMForFFICall. "To take ownership but importantly to reset inFFIFlags" self activateFailingPrimitiveMethod]! Item was changed: ----- Method: StackInterpreter class>>initializeMiscConstants (in category 'initialization') ----- initializeMiscConstants super initializeMiscConstants. STACKVM := true. RevisedSuspend := true. "primitiveSuspendBackingUpV1/2 no longer allow a process waiting on a condition variable to go past the condition variable" "These flags identify a GC operation (& hence a reason to leak check), or just operations the leak checker can be run for." GCModeFull := 1. "stop-the-world global GC" GCModeNewSpace := 2. "Spur's scavenge, or V3's incremental" GCModeIncremental := 4. "incremental global gc (Dijkstra tri-colour marking); as yet unimplemented" GCModeBecome := 8. "v3 post-become sweeping/Spur forwarding" GCCheckImageSegment := 16. "just a flag for leak checking image segments" GCCheckFreeSpace := 32. "just a flag for leak checking free space; Spur only" GCCheckShorten := 64. "just a flag for leak checking object shortening operations; Spur only" GCCheckPrimCall := 128. "just a flag for leak checking external primitive calls" StackPageTraceInvalid := -1. StackPageUnreached := 0. StackPageReachedButUntraced := 1. StackPageTraced := 2. MillisecondClockMask := 16r1FFFFFFF. "Note: The external primitive table should actually be dynamically sized but for the sake of inferior platforms (e.g., Mac :-) who cannot allocate memory in any reasonable way, we keep it static (and cross our fingers...)" MaxExternalPrimitiveTableSize := 4096. "entries" FailImbalancedPrimitives := InitializationOptions at: #FailImbalancedPrimitives ifAbsentPut: [true]. EnforceAccessControl := InitializationOptions at: #EnforceAccessControl ifAbsent: [true]. ReturnToInterpreter := 1. "setjmp/longjmp code." "Because of a hack with callbacks in the non-threaded VM they must not conflct with the VM's tag bits." DisownVMForFFICall := 16. DisownVMForThreading := 32. + DisownVMFromCallback := 64. "The multiple bytecodes active bit in the image format number" MultipleBytecodeSetsBitmask := 512.! Item was changed: ----- Method: StackInterpreter class>>writeVMHeaderTo:bytesPerWord:generator: (in category 'translation') ----- writeVMHeaderTo: aStream bytesPerWord: bytesPerWord generator: aCCodeGenerator super writeVMHeaderTo: aStream bytesPerWord: bytesPerWord generator: aCCodeGenerator. SistaVM ifTrue: [aCCodeGenerator putDefineOf: #SistaVM as: 1 on: aStream]. NewspeakVM ifTrue: [aCCodeGenerator putDefineOf: #NewspeakVM as: 1 on: aStream]. MULTIPLEBYTECODESETS ifTrue: [aCCodeGenerator putDefineOf: #MULTIPLEBYTECODESETS as: 1 on: aStream]. IMMUTABILITY ifTrue: [aCCodeGenerator putConditionalDefineOf: #IMMUTABILITY as: 1 comment: 'Allow this to be overridden on the compiler command line' on: aStream]. SistaVM | NewspeakVM | MULTIPLEBYTECODESETS | IMMUTABILITY ifTrue: [aStream cr]. aCCodeGenerator putDefineOf: #STACKVM as: 1 on: aStream. (InitializationOptions at: #SpurObjectMemory ifAbsent: false) ifTrue: [aCCodeGenerator putDefineOf: #SPURVM as: 1 on: aStream]. aCCodeGenerator putDefineOf: #DisownVMForFFICall as: DisownVMForFFICall on: aStream; + putDefineOf: #DisownVMForThreading as: DisownVMForThreading on: aStream; + putDefineOf: #DisownVMFromCallback as: DisownVMFromCallback on: aStream! - putDefineOf: #DisownVMForThreading as: DisownVMForThreading on: aStream! Item was changed: ----- Method: StackInterpreter>>disownVM: (in category 'vm scheduling') ----- disownVM: flags <public> <inline: false> + <returnTypeC: #'void *'> + <var: #vmHandle type: #'void *'> + | vmHandle | "Release the VM to other threads and answer the current thread's index. Currently valid flags for the non-threaded VM are: DisownVMForThreading - allow the VM to thread-switch; this is ignored - DisownVMLockOutFullGC - prevent fullGCs while this thread disowns the VM DisownVMForFFICall - informs the VM that it is entering an FFI call This is the entry-point for plugins and primitives that wish to release the VM while performing some operation that may potentially block, and for callbacks returning back to some blocking operation. While this exists for the threaded FFI VM we use it to reset newMethod and the argumentCount after a callback." self assert: primFailCode = 0. + self assert: flags ~= 0. + + "In the single-threaded VM here, we treat flags directly as vmHandle. See MTVM." + vmHandle := self cCoerce: flags to: #'void *'. + "We are either in disowning after a callback (see thunkEntry) or before an FFI + callout." + self assert: (flags = DisownVMFromCallback or: + [flags = (flags bitAnd: DisownVMForFFICall+DisownVMForThreading) + and: [flags anyMask: DisownVMForFFICall]]). - flags = DisownVMForThreading ifTrue: - [^flags]. - "Hack encodings of client state. We use non-immediates (bottom three bits clear) - for FFI/Plugin doing - save := self disownVM: FLAGS. ... callout ... self ownVM: save. - We use immediate integer (bottom bit 1) for callbacks doing - save := self ownVM: 0. ... callback ... self disownVM: save. return to C" - self assert: ((objectMemory isImmediate: flags) - ifFalse: - [flags = (flags bitAnd: DisownVMForFFICall+DisownVMForThreading) - and: [flags anyMask: DisownVMForFFICall]] - ifTrue: - [(objectMemory isIntegerObject: flags) - and: [(objectMemory integerValueOf: flags) - between: 0 - and: (self argumentCountOfMethodHeader: -1)]]). - "If DisownVMForFFICall this is from the FFI plugin and we're making a callout; remember the fact." + (flags anyMask: DisownVMForFFICall) ifTrue: - (((objectMemory isImmediate: flags)) not - and: [flags anyMask: DisownVMForFFICall]) ifTrue: [self assert: ((objectMemory isOopCompiledMethod: newMethod) and: [(self argumentCountOf: newMethod) = argumentCount]). + ^ ffiCalloutVMHandle := vmHandle]. - inFFIFlags := DisownVMForFFICall. - ^flags]. - self assert: ((objectMemory isIntegerObject: flags) - and: [(objectMemory integerValueOf: flags) - between: 0 - and: (self argumentCountOfMethodHeader: -1)]). - "Otherwise this is a callback return; restore argumentCount and newMethod as per the ownVM: on callback." + (flags anyMask: DisownVMFromCallback) ifTrue: + [argumentCount := objectMemory integerValueOf: self popStack. + self assert: (argumentCount + between: 0 + and: (self argumentCountOfMethodHeader: -1)). + newMethod := self popStack. + self assert: ((objectMemory isOopCompiledMethod: newMethod) - argumentCount := objectMemory integerValueOf: flags. - newMethod := self popStack. - self assert: ((objectMemory isOopCompiledMethod: newMethod) and: [(self argumentCountOf: newMethod) = argumentCount]). + ^ nil]. + + ^ vmHandle! - ^0! Item was changed: ----- Method: StackInterpreter>>ownVM: (in category 'vm scheduling') ----- + ownVM: vmHandle - ownVM: threadIndexAndFlags <public> <inline: false> + <var: #vmHandle type: #'void *'> + "This is the entry-point for plugins and primitives that wish to reacquire the VM after having + released it via disownVM or callbacks that want to acquire it without knowing their ownership + status. While this exists for the threaded FFI VM we use it to reset newMethod and the + argumentCount after a callback. + + Answer 0 if the current thread is known to the VM (and on return owns the VM). + Answer 1 if the current thread is unknown to the VM and takes ownership. + Answer -1 if the current thread is unknown to the VM and fails to take ownership." + + | flags | + self assert: ((objectMemory isOopCompiledMethod: newMethod) + and: [(self argumentCountOf: newMethod) = argumentCount]). + + "From callbacks (see thunkEntry), we don't know our ownerhip. Stash newMethod + and argumentCount on the stack." + vmHandle ifNil: + [self assert: primFailCode = 0. + self push: newMethod. + self push: (objectMemory integerObjectOf: argumentCount). + ^ 1 "unknown to VM"]. + + flags := self cCoerce: vmHandle to: #sqInt. + (flags anyMask: DisownVMForFFICall) ifTrue: + [ffiCalloutVMHandle := nil]. + + ^0 "already known"! - ^ self ownVM: threadIndexAndFlags withFlags: 0! Item was removed: - ----- Method: StackInterpreter>>ownVM:withFlags: (in category 'vm scheduling') ----- - ownVM: threadIndexAndFlags withFlags: additionalFlags - <public> - <inline: false> - "This is the entry-point for plugins and primitives that wish to reacquire the VM after having - released it via disownVM or callbacks that want to acquire it without knowing their ownership - status. While this exists for the threaded FFI VM we use it to reset newMethod and the - argumentCount after a callback. - - Answer -1 if the current thread is unknown to the VM and fails to take ownership." - <var: 'amInVMThread' declareC: 'extern sqInt amInVMThread(void)'> - | flags | - flags := threadIndexAndFlags bitOr: additionalFlags. - self cppIf: COGMTVM - ifTrue: - [self amInVMThread ifFalse: - [^-1]]. - - self assert: ((objectMemory isOopCompiledMethod: newMethod) - and: [(self argumentCountOf: newMethod) = argumentCount]). - - "Hack encodings of client state. We use non-immediates (bottom three bits clear) - for FFI/Plugin doing - save := self disownVM: FLAGS. ... callout ... self ownVM: save. - We use immediate integer (bottom bit 1) for callbacks doing - save := self ownVM: 0. ... callback ... self disownVM: save. return to C" - - "If DisownVMForFFICall this is from the FFI plugin and we're returning from a callout." - (flags anyMask: DisownVMForFFICall) ifTrue: - [inFFIFlags := 0. - ^flags]. - - "Otherwise this is a callback; stash newMethod on the stack and encode - argumentCount in the flags retrieved when the calback calls disownVM:." - self assert: primFailCode = 0. - self push: newMethod. - ^objectMemory integerObjectOf: argumentCount! Item was changed: ----- Method: ThreadedARM32FFIPlugin>>ffiCalloutTo:SpecOnStack:in: (in category 'callout support') ----- ffiCalloutTo: procAddr SpecOnStack: specOnStack in: calloutState <var: #procAddr type: #'void *'> <var: #calloutState type: #'CalloutState *'> <var: #loadFloatRegs declareC: 'extern void loadFloatRegs(double, double, double, double, double, double, double, double)'> "Go out, call this guy and create the return value. This *must* be inlined because of the alloca of the outgoing stack frame in ffiCall:WithFlags:NumArgs:Args:AndTypes:" + | vmHandle atomicType floatRet intRet | + <var: #vmHandle type: #'void *'> - | myThreadIndex atomicType floatRet intRet | <var: #floatRet type: #double> <var: #intRet type: #usqLong> <inline: #always> + vmHandle := interpreterProxy disownVM: (self disownFlagsFor: calloutState). - myThreadIndex := interpreterProxy disownVM: (self disownFlagsFor: calloutState). calloutState floatRegisterIndex > 0 ifTrue: [self loadFloatRegs: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 0)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 2)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 4)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 6)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 8)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 10)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 12)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 14)) to: #'double *') at: 0)]. (self allocaLiesSoSetSpBeforeCall or: [self mustAlignStack]) ifTrue: [self setsp: calloutState argVector]. atomicType := self atomicTypeOf: calloutState ffiRetHeader. (atomicType >> 1) = (FFITypeSingleFloat >> 1) ifTrue: [atomicType = FFITypeSingleFloat ifTrue: [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'float (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3)] ifFalse: "atomicType = FFITypeDoubleFloat" [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'double (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3)]. "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. + interpreterProxy ownVM: vmHandle. - interpreterProxy ownVM: myThreadIndex. ^interpreterProxy floatObjectOf: floatRet]. intRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'usqIntptr_t (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3). "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. + interpreterProxy ownVM: vmHandle. - interpreterProxy ownVM: myThreadIndex. (calloutState ffiRetHeader anyMask: FFIFlagPointer+FFIFlagStructure) ifTrue: [| returnType | "Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent 'typedef void* VoidPointer' and VoidPointer must be returned as pointer *not* as struct." returnType := self ffiReturnType: specOnStack. (calloutState ffiRetHeader anyMask: FFIFlagPointer) ifTrue: [^self ffiReturnPointer: intRet ofType: returnType in: calloutState]. ^self ffiReturnStruct: (self addressOf: intRet) ofType: returnType in: calloutState]. ^self ffiCreateIntegralResultOop: intRet ofAtomicType: atomicType in: calloutState! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>ffiCalloutTo:SpecOnStack:in: (in category 'callout support') ----- ffiCalloutTo: procAddr SpecOnStack: specOnStack in: calloutState <var: #procAddr type: #'void *'> <var: #calloutState type: #'CalloutState *'> <var: #loadFloatRegs declareC: 'extern void loadFloatRegs(double, double, double, double, double, double, double, double)'> "Go out, call this guy and create the return value. This *must* be inlined because of the alloca of the outgoing stack frame in ffiCall:WithFlags:NumArgs:Args:AndTypes:" + | vmHandle atomicType floatRet intRet structRet specSize | + <var: 'vmHandle' type: #'void *'> - | myThreadIndex atomicType floatRet intRet structRet specSize | <var: 'floatRet' type: #ThirtyTwoByteReturnDF> <var: 'structRet' type: #SixteenByteReturnII> <var: 'intRet' type: #usqLong> <inline: #always> self cCode: [] inSmalltalk: [floatRet := ByteArray new: 32]. "Just a hack to placate the Smalltalk compiler; these should be proper struct types..." + vmHandle := interpreterProxy disownVM: (self disownFlagsFor: calloutState). - myThreadIndex := interpreterProxy disownVM: (self disownFlagsFor: calloutState). calloutState floatRegisterIndex > 0 ifTrue: [self loadFloatRegs: (calloutState floatRegisters at: 0) _: (calloutState floatRegisters at: 1) _: (calloutState floatRegisters at: 2) _: (calloutState floatRegisters at: 3) _: (calloutState floatRegisters at: 4) _: (calloutState floatRegisters at: 5) _: (calloutState floatRegisters at: 6) _: (calloutState floatRegisters at: 7)]. (self allocaLiesSoSetSpBeforeCall or: [self mustAlignStack]) ifTrue: [self setsp: calloutState argVector]. atomicType := self atomicTypeOf: calloutState ffiRetHeader. ((atomicType >> 1) = (FFITypeSingleFloat >> 1) or: [(calloutState ffiRetHeader bitAnd: FFIFlagPointer+FFIFlagStructure) = FFIFlagStructure and: [self structIsHomogenousFloatArrayOfSize: (calloutState ffiRetHeader bitAnd: FFIStructSizeMask) typeSpec: (self cCoerce: (interpreterProxy firstIndexableField: calloutState ffiRetSpec) to: #'unsigned int *') ofLength: (specSize := interpreterProxy byteSizeOf: calloutState ffiRetSpec) / (self sizeof: #'unsigned int')]]) ifTrue: [floatRet d: (self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'struct dprr (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7)). "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. + interpreterProxy ownVM: vmHandle. - interpreterProxy ownVM: myThreadIndex. atomicType = FFITypeDoubleFloat ifTrue: [^interpreterProxy floatObjectOf: (floatRet d doubles at: 0)]. atomicType = FFITypeSingleFloat ifTrue: [^interpreterProxy floatObjectOf: (floatRet f floats at: 0)]. "If the struct is a vector of floats then move float[2] to float[1], float[4] to float[2] and float[6] to float[3], to pack the float data in the double fields. We can tell if the struct is composed of floats if its size is less than the spec size, since the spec size is (1 + n fields) * 4 bytes, and the struct size is n fields * 4 bytes for floats and n fields * 8 bytes for doubles. We can't access the spec post call because it may have moved." specSize > calloutState structReturnSize ifTrue: [floatRet f floats at: 1 put: (floatRet f floats at: 2). floatRet f floats at: 2 put: (floatRet f floats at: 4). floatRet f floats at: 3 put: (floatRet f floats at: 6)]. ^self ffiReturnStruct: (self addressOf: floatRet) ofType: (self ffiReturnType: specOnStack) in: calloutState]. "Integer and Structure returns..." "If struct address used for return value, call is special; struct return pointer must be in x8" (self mustReturnStructOnStack: calloutState structReturnSize) ifTrue: [intRet := 0. self setReturnRegister: (self cCoerceSimple: calloutState limit to: #sqLong) "stack alloca'd struct" andCall: (self cCoerceSimple: procAddr to: #sqLong) withArgsArray: (self cCoerceSimple: (self addressOf: calloutState integerRegisters) to: #sqLong)] ifFalse: [structRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'SixteenByteReturnII (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7). intRet := structRet a]. "X1" "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. + interpreterProxy ownVM: vmHandle. - interpreterProxy ownVM: myThreadIndex. (calloutState ffiRetHeader anyMask: FFIFlagPointer+FFIFlagStructure) ifTrue: [| returnType | "Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent 'typedef void* VoidPointer' and VoidPointer must be returned as pointer *not* as struct." returnType := self ffiReturnType: specOnStack. (calloutState ffiRetHeader anyMask: FFIFlagPointer) ifTrue: [^self ffiReturnPointer: intRet ofType: returnType in: calloutState]. ^self ffiReturnStruct: (((self returnStructInRegisters: calloutState) ifTrue: [self cCoerceSimple: (self addressOf: structRet) to: #'char *'] ifFalse: [calloutState limit])) ofType: returnType in: calloutState]. ^self ffiCreateIntegralResultOop: intRet ofAtomicType: atomicType in: calloutState! Item was changed: ----- Method: ThreadedFFIPlugin>>disownFlagsFor: (in category 'primitive support') ----- disownFlagsFor: calloutState <var: #calloutState type: #'CalloutState *'> <inline: #always> + ^ (calloutState callFlags anyMask: FFICallFlagThreaded) - ^self cppIf: COGMTVM - ifTrue: [(calloutState callFlags anyMask: FFICallFlagThreaded) ifTrue: [DisownVMForFFICall+DisownVMForThreading] + ifFalse: [DisownVMForFFICall]! - ifFalse: [DisownVMForFFICall]] - ifFalse: [DisownVMForFFICall]! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiCalloutTo:SpecOnStack:in: (in category 'callout support') ----- ffiCalloutTo: procAddr SpecOnStack: specOnStack in: calloutState <var: #procAddr type: #'void *'> <var: #calloutState type: #'CalloutState *'> "Go out, call this guy and create the return value. This *must* be inlined because of the alloca of the outgoing stack frame in ffiCall:WithFlags:NumArgs:Args:AndTypes:" + | vmHandle atomicType floatRet intRet | + <var: #vmHandle type: #'void *'> - | myThreadIndex atomicType floatRet intRet | <var: #floatRet type: #double> <var: #intRet type: #usqLong> "Support up to int64_t or uint64_t" <inline: #always> + vmHandle := interpreterProxy disownVM: (self disownFlagsFor: calloutState). - myThreadIndex := interpreterProxy disownVM: (self disownFlagsFor: calloutState). (self allocaLiesSoSetSpBeforeCall or: [self mustAlignStack]) ifTrue: [self setsp: calloutState argVector]. atomicType := self atomicTypeOf: calloutState ffiRetHeader. (atomicType >> 1) = (FFITypeSingleFloat >> 1) ifTrue: [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'double (*)()'). "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. + interpreterProxy ownVM: vmHandle. - interpreterProxy ownVM: myThreadIndex. ^interpreterProxy floatObjectOf: floatRet]. intRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'usqLong (*)()'). "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. + interpreterProxy ownVM: vmHandle. - interpreterProxy ownVM: myThreadIndex. (calloutState ffiRetHeader anyMask: FFIFlagPointer+FFIFlagStructure) ifTrue: [| returnType | "Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent 'typedef void* VoidPointer' and VoidPointer must be returned as pointer *not* as struct." returnType := self ffiReturnType: specOnStack. (calloutState ffiRetHeader anyMask: FFIFlagPointer) ifTrue: [^self ffiReturnPointer: intRet ofType: returnType in: calloutState]. ^self ffiReturnStruct: (self addressOf: intRet) ofType: returnType in: calloutState]. ^self ffiCreateIntegralResultOop: intRet ofAtomicType: atomicType in: calloutState! Item was changed: ----- Method: ThreadedRiscV64FFIPlugin>>ffiCalloutTo:SpecOnStack:in: (in category 'callout support') ----- ffiCalloutTo: procAddr SpecOnStack: specOnStack in: calloutState <var: #procAddr type: #'void *'> <var: #calloutState type: #'CalloutState *'> <var: #loadFloatRegs declareC: 'extern void loadFloatRegs(double, double, double, double, double, double, double, double)'> "Go out, call this guy and create the return value. This *must* be inlined because of the alloca of the outgoing stack frame in ffiCall:WithFlags:NumArgs:Args:AndTypes:" + | vmHandle atomicType floatRet intRet structRet specSize | + <var: 'vmHandle' type: #'void *'> - | myThreadIndex atomicType floatRet intRet structRet specSize | <var: 'doubleRet' type: #double> <var: 'floatRet' type: #ThirtyTwoByteReturnDF> <var: 'structRet' type: #SixteenByteReturnII> <var: 'intRet' type: #usqLong> <inline: #always> self cCode: [] inSmalltalk: [floatRet := ByteArray new: 32]. "Just a hack to placate the Smalltalk compiler; these should be proper struct types..." + vmHandle := interpreterProxy disownVM: (self disownFlagsFor: calloutState). - myThreadIndex := interpreterProxy disownVM: (self disownFlagsFor: calloutState). calloutState floatRegisterIndex > 0 ifTrue: [self loadFloatRegs: (calloutState floatRegisters at: 0) _: (calloutState floatRegisters at: 1) _: (calloutState floatRegisters at: 2) _: (calloutState floatRegisters at: 3) _: (calloutState floatRegisters at: 4) _: (calloutState floatRegisters at: 5) _: (calloutState floatRegisters at: 6) _: (calloutState floatRegisters at: 7)]. (self allocaLiesSoSetSpBeforeCall or: [self mustAlignStack]) ifTrue: [self setsp: calloutState argVector]. "float or double returns" atomicType := self atomicTypeOf: calloutState ffiRetHeader. (atomicType >> 1) = (FFITypeSingleFloat >> 1) ifTrue: [| doubleRet | atomicType = FFITypeDoubleFloat ifTrue: [doubleRet := (self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'double (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7))] ifFalse: [doubleRet := (self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'float (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7))]. "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. + interpreterProxy ownVM: vmHandle. - interpreterProxy ownVM: myThreadIndex. ^self floatObjectOf: doubleRet]. "homogenous array of float/double returns" ((calloutState ffiRetHeader bitAnd: FFIFlagPointer+FFIFlagStructure) = FFIFlagStructure and: [self structIsHomogenousFloatArrayOfSize: (calloutState ffiRetHeader bitAnd: FFIStructSizeMask) typeSpec: (self cCoerce: (interpreterProxy firstIndexableField: calloutState ffiRetSpec) to: #'unsigned int *') ofLength: (specSize := interpreterProxy byteSizeOf: calloutState ffiRetSpec) / (self sizeof: #'unsigned int')]) ifTrue: [floatRet d: (self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'struct dprr (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7)). "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. + interpreterProxy ownVM: vmHandle. - interpreterProxy ownVM: myThreadIndex. "If the struct is a vector of floats then move float[2] to float[1], float[4] to float[2] and float[6] to float[3], to pack the float data in the double fields. We can tell if the struct is composed of floats if its size is less than the spec size, since the spec size is (1 + n fields) * 4 bytes, and the struct size is n fields * 4 bytes for floats and n fields * 8 bytes for doubles. We can't access the spec post call because it may have moved." specSize > calloutState structReturnSize ifTrue: [floatRet f floats at: 1 put: (floatRet f floats at: 2). floatRet f floats at: 2 put: (floatRet f floats at: 4). floatRet f floats at: 3 put: (floatRet f floats at: 6)]. ^self ffiReturnStruct: (self addressOf: floatRet) ofType: (self ffiReturnType: specOnStack) in: calloutState]. "Integer and Structure returns..." (self mustReturnStructOnStack: calloutState structReturnSize) ifTrue: [intRet := 0. self setReturnRegister: (self cCoerceSimple: calloutState limit to: #sqLong) "stack alloca'd struct" andCall: (self cCoerceSimple: procAddr to: #sqLong) withArgsArray: (self cCoerceSimple: (self addressOf: calloutState integerRegisters) to: #sqLong)] ifFalse: [structRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'SixteenByteReturnII (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7). intRet := structRet a]. "X1" "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. + interpreterProxy ownVM: vmHandle. - interpreterProxy ownVM: myThreadIndex. (calloutState ffiRetHeader anyMask: FFIFlagPointer+FFIFlagStructure) ifTrue: [| returnType | "Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent 'typedef void* VoidPointer' and VoidPointer must be returned as pointer *not* as struct." returnType := self ffiReturnType: specOnStack. (calloutState ffiRetHeader anyMask: FFIFlagPointer) ifTrue: [^self ffiReturnPointer: intRet ofType: returnType in: calloutState]. ^self ffiReturnStruct: (((self returnStructInRegisters: calloutState) ifTrue: [self cCoerceSimple: (self addressOf: structRet) to: #'char *'] ifFalse: [calloutState limit])) ofType: returnType in: calloutState]. ^self ffiCreateIntegralResultOop: intRet ofAtomicType: atomicType in: calloutState! Item was changed: ----- Method: ThreadedX64SysVFFIPlugin>>ffiCalloutTo:SpecOnStack:in: (in category 'callout support') ----- ffiCalloutTo: procAddr SpecOnStack: specOnStack in: calloutState <var: #procAddr type: #'void *'> <var: #calloutState type: #'CalloutState *'> <var: #loadFloatRegs declareC: 'extern void loadFloatRegs(double, double, double, double, double, double, double, double)'> "Go out, call this guy and create the return value. This *must* be inlined because of the alloca of the outgoing stack frame in ffiCall:WithFlags:NumArgs:Args:AndTypes:" + | vmHandle atomicType floatRet intRet sddRet sdiRet sidRet siiRet returnStructByValue registerType sRetPtr | + <var: #vmHandle type: #'void *'> - | myThreadIndex atomicType floatRet intRet sddRet sdiRet sidRet siiRet returnStructByValue registerType sRetPtr | <var: #floatRet type: #double> <var: #intRet type: #sqInt> <var: #siiRet type: #SixteenByteReturnII> <var: #sidRet type: #SixteenByteReturnID> <var: #sdiRet type: #SixteenByteReturnDI> <var: #sddRet type: #SixteenByteReturnDD> <var: #sRetPtr type: #'void *'> <inline: #always> returnStructByValue := (calloutState ffiRetHeader bitAnd: FFIFlagStructure + FFIFlagPointer + FFIFlagAtomic) = FFIFlagStructure. + vmHandle := interpreterProxy disownVM: (self disownFlagsFor: calloutState). - myThreadIndex := interpreterProxy disownVM: (self disownFlagsFor: calloutState). calloutState floatRegisterIndex > 0 ifTrue: [self loadFloatRegs: (calloutState floatRegisters at: 0) _: (calloutState floatRegisters at: 1) _: (calloutState floatRegisters at: 2) _: (calloutState floatRegisters at: 3) _: (calloutState floatRegisters at: 4) _: (calloutState floatRegisters at: 5) _: (calloutState floatRegisters at: 6) _: (calloutState floatRegisters at: 7)]. (self allocaLiesSoSetSpBeforeCall or: [self mustAlignStack]) ifTrue: [self setsp: calloutState argVector]. atomicType := self atomicTypeOf: calloutState ffiRetHeader. (atomicType >> 1) = (FFITypeSingleFloat >> 1) ifTrue: [atomicType = FFITypeSingleFloat ifTrue: [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'float (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5)] ifFalse: "atomicType = FFITypeDoubleFloat" [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'double (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5)]. + interpreterProxy ownVM: vmHandle. - interpreterProxy ownVM: myThreadIndex. ^interpreterProxy floatObjectOf: floatRet]. returnStructByValue ifFalse: [intRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'sqInt (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5). + interpreterProxy ownVM: vmHandle. - interpreterProxy ownVM: myThreadIndex. (calloutState ffiRetHeader anyMask: FFIFlagPointer) ifTrue: [^self ffiReturnPointer: intRet ofType: (self ffiReturnType: specOnStack) in: calloutState]. ^self ffiCreateIntegralResultOop: intRet ofAtomicType: atomicType in: calloutState]. registerType := calloutState structReturnType. registerType caseOf: {[2r00] -> [sddRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'SixteenByteReturnDD (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5). sRetPtr := (self addressOf: sddRet) asVoidPointer]. [2r01] -> [sidRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'SixteenByteReturnID (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5). sRetPtr := (self addressOf: sidRet) asVoidPointer]. [2r10] -> [sdiRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'SixteenByteReturnDI (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5). sRetPtr := (self addressOf: sdiRet) asVoidPointer]. [2r11] -> [siiRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'SixteenByteReturnII (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5). sRetPtr := (self addressOf: siiRet) asVoidPointer]. [2r100] -> [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'double (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5). sRetPtr := (self addressOf: floatRet) asVoidPointer]. [2r101] -> [intRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'sqInt (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5). sRetPtr := (self addressOf: intRet) asVoidPointer]. [2r110] -> ["return a pointer to alloca'd memory" intRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'sqInt (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5). sRetPtr := intRet asVoidPointer "address of struct is returned in RAX, which also is calloutState limit"]} otherwise: + [interpreterProxy ownVM: vmHandle. - [interpreterProxy ownVM: myThreadIndex. self ffiFail: FFIErrorWrongType. ^nil]. + interpreterProxy ownVM: vmHandle. - interpreterProxy ownVM: myThreadIndex. ^self ffiReturnStruct: sRetPtr ofType: (self ffiReturnType: specOnStack) in: calloutState! Item was changed: ----- Method: ThreadedX64Win64FFIPlugin>>ffiCalloutTo:SpecOnStack:in: (in category 'callout support') ----- ffiCalloutTo: procAddr SpecOnStack: specOnStack in: calloutState <var: #procAddr type: #'void *'> <var: #calloutState type: #'CalloutState *'> <var: #loadFloatRegs declareC: 'extern void loadFloatRegs(double, double, double, double)'> "Go out, call this guy and create the return value. This *must* be inlined because of the alloca of the outgoing stack frame in ffiCall:WithFlags:NumArgs:Args:AndTypes:" + | vmHandle atomicType floatRet intRet | + <var: #vmHandle type: #'void *'> - | myThreadIndex atomicType floatRet intRet | <var: #floatRet type: #double> <var: #intRet type: #usqLong> <inline: #always> + vmHandle := interpreterProxy disownVM: (self disownFlagsFor: calloutState). - myThreadIndex := interpreterProxy disownVM: (self disownFlagsFor: calloutState). calloutState floatRegisterSignature > 0 ifTrue: [self loadFloatRegs: (calloutState floatRegisters at: 0) _: (calloutState floatRegisters at: 1) _: (calloutState floatRegisters at: 2) _: (calloutState floatRegisters at: 3)]. (self allocaLiesSoSetSpBeforeCall or: [self mustAlignStack]) ifTrue: [self setsp: calloutState argVector]. atomicType := self atomicTypeOf: calloutState ffiRetHeader. (atomicType >> 1) = (FFITypeSingleFloat >> 1) ifTrue: [atomicType = FFITypeSingleFloat ifTrue: [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'float (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3)] ifFalse: "atomicType = FFITypeDoubleFloat" [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'double (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3)]. "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. + interpreterProxy ownVM: vmHandle. - interpreterProxy ownVM: myThreadIndex. ^interpreterProxy floatObjectOf: floatRet]. intRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'usqIntptr_t (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3). "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. + interpreterProxy ownVM: vmHandle. - interpreterProxy ownVM: myThreadIndex. (calloutState ffiRetHeader anyMask: FFIFlagPointer+FFIFlagStructure) ifTrue: [| returnType | "Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent 'typedef void* VoidPointer' and VoidPointer must be returned as pointer *not* as struct." returnType := self ffiReturnType: specOnStack. (calloutState ffiRetHeader anyMask: FFIFlagPointer) ifTrue: [^self ffiReturnPointer: intRet ofType: returnType in: calloutState]. ^self ffiReturnStruct: (self addressOf: intRet) ofType: returnType in: calloutState]. ^self ffiCreateIntegralResultOop: intRet ofAtomicType: atomicType in: calloutState! Item was changed: SharedPool subclass: #VMBasicConstants instanceVariableNames: '' + classVariableNames: 'BaseHeaderSize BytecodeSetHasExtensions BytesPerOop BytesPerWord COGMTVM COGVM CloneOnGC CloneOnScavenge DisownVMForFFICall DisownVMForThreading DisownVMFromCallback DoAssertionChecks DoExpensiveAssertionChecks FastCPrimitiveAlignForFloatsFlag FastCPrimitiveFlag GCCheckFreeSpace GCCheckImageSegment GCCheckPrimCall GCCheckShorten GCModeBecome GCModeFull GCModeIncremental GCModeNewSpace HashMultiplyConstant HashMultiplyMask IMMUTABILITY LowcodeVM MULTIPLEBYTECODESETS NewspeakVM PharoVM PrimErrBadArgument PrimErrBadIndex PrimErrBadMethod PrimErrBadNumArgs PrimErrBadReceiver PrimErrCallbackError PrimErrFFIException PrimErrFFIMarshallingError PrimErrGenericFailure PrimErrInappropriate PrimErrInternalError PrimErrLimitExceeded PrimErrNamedInternal PrimErrNeedCompaction PrimErrNoCMemory PrimErrNoMemory PrimErrNoModification PrimErrNotFound PrimErrOSError PrimErrObjectIsPinned PrimErrObjectMayMove PrimErrObjectMoved PrimErrObjectNotPinned PrimErrOperationFailed PrimEr rUninitialized PrimErrUnsupported PrimErrWritePastObject PrimNoErr PrimNumberHandlerMarker PrimNumberNoContextSwitchMarker PrimNumberUnwindMarker SPURVM STACKVM SistaVM TempVectReadBarrier VMBIGENDIAN' - classVariableNames: 'BaseHeaderSize BytecodeSetHasExtensions BytesPerOop BytesPerWord COGMTVM COGVM CloneOnGC CloneOnScavenge DisownVMForFFICall DisownVMForThreading DoAssertionChecks DoExpensiveAssertionChecks FastCPrimitiveAlignForFloatsFlag FastCPrimitiveFlag GCCheckFreeSpace GCCheckImageSegment GCCheckPrimCall GCCheckShorten GCModeBecome GCModeFull GCModeIncremental GCModeNewSpace HashMultiplyConstant HashMultiplyMask IMMUTABILITY LowcodeVM MULTIPLEBYTECODESETS NewspeakVM PharoVM PrimErrBadArgument PrimErrBadIndex PrimErrBadMethod PrimErrBadNumArgs PrimErrBadReceiver PrimErrCallbackError PrimErrFFIException PrimErrFFIMarshallingError PrimErrGenericFailure PrimErrInappropriate PrimErrInternalError PrimErrLimitExceeded PrimErrNamedInternal PrimErrNeedCompaction PrimErrNoCMemory PrimErrNoMemory PrimErrNoModification PrimErrNotFound PrimErrOSError PrimErrObjectIsPinned PrimErrObjectMayMove PrimErrObjectMoved PrimErrObjectNotPinned PrimErrOperationFailed PrimErrUninitialized PrimEr rUnsupported PrimErrWritePastObject PrimNoErr PrimNumberHandlerMarker PrimNumberNoContextSwitchMarker PrimNumberUnwindMarker SPURVM STACKVM SistaVM TempVectReadBarrier VMBIGENDIAN' poolDictionaries: '' category: 'VMMaker-Interpreter'! !VMBasicConstants commentStamp: '<historical>' prior: 0! I am a shared pool for basic constants upon which the VM as a whole depends. self ensureClassPool. self classPool declare: #BytesPerWord from: VMSqueakV3ObjectRepresentationConstants classPool. self classPool declare: #BaseHeaderSize from: VMSqueakV3ObjectRepresentationConstants classPool (ObjectMemory classPool keys select: [:k| k beginsWith: 'Byte']) do: [:k| self classPool declare: k from: ObjectMemory classPool]!

1 0

VM Maker: VMMaker.oscog-mt.3360.mcz
by commits＠source.squeak.org 16 Apr '24

16 Apr '24

Marcel Taeumel uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-mt.3360.mcz ==================== Summary ==================== Name: VMMaker.oscog-mt.3360 Author: mt Time: 16 April 2024, 5:51:20.916284 pm UUID: b2275220-8fc2-1c4a-b3cf-e5e943310c0f Ancestors: VMMaker.oscog-mt.3359 For COGMTVM, ensure that thread subsystem is initalized *before* the heartbeat thread is started, because the heartbeat might already rely on it. While this does not seem to be necessary on Linux, Windows will directly fire up the heartbeat and thus, for example, crash the thread logging. =============== Diff against VMMaker.oscog-mt.3359 =============== Item was changed: ----- Method: CoInterpreterMT>>initialEnterSmalltalkExecutive (in category 'initialization') ----- initialEnterSmalltalkExecutive "Main entry-point into the interpreter at system start-up." "Ensure that the myList of the activeProcess is nil. Needed to load old images which don't nil myList in transferTo:{from:}" objectMemory storePointerUnchecked: MyListIndex ofObject: self activeProcess withValue: objectMemory nilObject. - cogThreadManager startThreadSubsystem. self threadSchedulingLoop: (cogThreadManager vmThreadAt: 1). "NOTREACHED. The following is to fool Slang" self threadSchedulingLoopImplementation: cogThreadManager currentVMThread! Item was changed: ----- Method: CoInterpreterMT>>loadInitialContext (in category 'initialization') ----- loadInitialContext | activeProc threadAffinity | super loadInitialContext. activeProc := self activeProcess. threadAffinity := self threadAffinityOfProcess: activeProc. self assert: (threadAffinity = 0 or: [threadAffinity = 1]). self cCode: [] inSmalltalk: [self flag: #todoMT "Ensure we cannot save an image, where the 'activeProc' is affined to another thread!!"]. + activeProcessAffined := threadAffinity ~= 0. + + cogThreadManager startThreadSubsystem.! - activeProcessAffined := threadAffinity ~= 0!

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev April 2024