Vm-dev March 2023

vm-dev@lists.squeakfoundation.org

15 participants
63 discussions

VM Maker: Cog-eem.453.mcz
by commits＠source.squeak.org 25 Mar '23

25 Mar '23

Eliot Miranda uploaded a new version of Cog to project VM Maker: http://source.squeak.org/VMMaker/Cog-eem.453.mcz ==================== Summary ==================== Name: Cog-eem.453 Author: eem Time: 24 March 2023, 7:20:21.662521 pm UUID: a5d43c7e-753d-42cc-9db1-911f3865c4a6 Ancestors: Cog-eem.452 Add some validation to SpurImagePreener and don't use isValidObjStackPage: to decide ifg an object is to be cloned; it could exclude objStack pages if it were too picky. Nuke an obsolete script. =============== Diff against Cog-eem.452 =============== Item was removed: - ----- Method: CogScripts class>>defineSpurPigCompactor (in category 'separate vm scripts') ----- - defineSpurPigCompactor - "Define SpurPigCompactor" - "self defineSpurPigCompactor" - | changes pigCompactor | - pigCompactor := SpurMemoryManager superclass - subclass: #SpurPigCompactor - instanceVariableNames: 'manager scavenger coInterpreter firstFreeChunk lastFreeChunk numCompactionPasses' - classVariableNames: 'CompactionPassesForGC CompactionPassesForSnapshot' - poolDictionaries: 'SpurMemoryManagementConstants VMBasicConstants VMSpurObjectRepresentationConstants' - category: SpurMemoryManager category. - changes := CogScripts changedSpurCompactorMethods. - changes do: - [:mr| - pigCompactor compile: mr source classified: (SpurMemoryManager whichCategoryIncludesSelector: mr selector)]. - changes do: - [:mr| - SpurMemoryManager removeSelector: mr selector]. - SpurMemoryManager organization removeEmptyCategories! Item was changed: ----- Method: SpurImagePreener>>cloneObject: (in category 'bootstrap image') ----- cloneObject: oldObj | newObj hash | + self deny: (sourceHeap isSegmentBridge: oldObj). newObj := targetHeap allocateSlots: (sourceHeap numSlotsOf: oldObj) format: (sourceHeap formatOf: oldObj) classIndex: (sourceHeap classIndexOf: oldObj). (hash := sourceHeap rawHashBitsOf: oldObj) ~= 0 ifTrue: [targetHeap setHashBitsOf: newObj to: hash]. (sourceHeap isImmutable: oldObj) ifTrue: [targetHeap setIsImmutableOf: newObj to: true]. (sourceHeap isPinned: oldObj) ifTrue: [targetHeap setIsPinnedOf: newObj to: true]. self deny: (sourceHeap isRemembered: oldObj). self deny: (sourceHeap isMarked: oldObj). self deny: (sourceHeap isGrey: oldObj). reverseMap at: newObj put: oldObj. ^map at: oldObj put: newObj! Item was changed: ----- Method: SpurImagePreener>>fillInObjects (in category 'bootstrap image') ----- fillInObjects "oldInterpreter printOop: oldObj" | i | {sourceHeap markStack. sourceHeap weaklingStack. sourceHeap mournQueue} do: [:obj| obj ~= sourceHeap nilObject ifTrue: [map at: obj put: (map at: sourceHeap nilObject)]]. i := 0. sourceHeap allObjectsDo: [:oldObj| (i := i + 1) >= 10000 ifTrue: [Transcript nextPut: $.; flush. i := 0]. (map at: oldObj ifAbsent: nil) ifNotNil: [:newObj| | format | (targetHeap numSlotsOf: newObj) > 0 ifTrue: "filter-out filtered objStack pages" [format := sourceHeap formatOf: oldObj. (targetHeap isPointersFormat: format) ifTrue: [self fillInPointerObject: newObj from: oldObj] ifFalse: [(targetHeap isCompiledMethodFormat: format) ifTrue: [self fillInCompiledMethod: newObj from: oldObj] + ifFalse: + [(targetHeap classIndexOf: newObj) <= targetHeap lastClassIndexPun + ifTrue: [self assert: (oldObj = sourceHeap freeListsObject + or: [oldObj = sourceHeap rememberedSetObj])] + ifFalse: [self fillInBitsObject: newObj from: oldObj]]]]] - ifFalse: [self fillInBitsObject: newObj from: oldObj]]]] ifNil: [self assert: (self isUnmappedObject: oldObj)]]! Item was added: + ----- Method: SpurImagePreener>>isObjStackPage:inHeap: (in category 'bootstrap image') ----- + isObjStackPage: obj inHeap: theHeap "<SpurMemoryManager>" + ^(theHeap classIndexOf: obj) = theHeap wordSizeClassIndexPun + and: [(theHeap numSlotsOfAny: obj) = theHeap objStackPageSlots]! Item was changed: ----- Method: SpurImagePreener>>preenImage (in category 'public access') ----- preenImage self cloneObjects. self fillInObjects. self fillInClassTable. self fillInHeap. + self validateTargetHeap. self reportSizes! Item was changed: ----- Method: SpurImagePreener>>shouldClone: (in category 'bootstrap image') ----- shouldClone: obj + ^(self isObjStackPage: obj inHeap: sourceHeap) not! - ^(sourceHeap isValidObjStackPage: obj) not! Item was added: + ----- Method: SpurImagePreener>>validateTargetHeap (in category 'bootstrap image') ----- + validateTargetHeap + "check that the result contains only objects that should be there. + Further check that certain objects are all zero." + + {targetHeap freeListsObject. targetHeap rememberedSetObj} do: + [:sbzObj| "shouldBeZeroObj" + 0 to: (targetHeap numSlotsOfAny: sbzObj) - 1 do: + [:i| self assert: (targetHeap fetchPointer: i ofMaybeForwardedObject: sbzObj) isZero]]. + targetHeap allOldSpaceEntitiesDo: + [:obj| | classIndex | + classIndex := targetHeap classIndexOf: obj. + classIndex <= targetHeap lastClassIndexPun ifTrue: + [self deny: (targetHeap isFreeObject: obj). + classIndex = targetHeap segmentBridgePun + ifTrue: "If it is a bridge it must be the one at the end of memory..." + [self assert: obj + targetHeap baseHeaderSize = targetHeap endOfMemory] + ifFalse: "If its not a bridge it must be the hidden roots, the free lists, or a class atble page (& temporariy, or the remembered set)" + [self assert: (obj = targetHeap hiddenRootsObject + or: [obj = targetHeap freeListsObject + or: [obj = targetHeap rememberedSetObj + or: [classIndex = targetHeap arrayClassIndexPun + and: [(targetHeap numSlotsOfAny: obj) = targetHeap classTablePageSize]]]])]]]!

1 0

VM Maker: VMMaker.oscog-eem.3314.mcz
by commits＠source.squeak.org 25 Mar '23

25 Mar '23

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3314.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3314 Author: eem Time: 24 March 2023, 7:10:55.31396 pm UUID: 29de1155-fded-4f58-a753-e8a4b3c06538 Ancestors: VMMaker.oscog-eem.3313 Fix a typo and provide a support method for SpurImagePreener. =============== Diff against VMMaker.oscog-eem.3313 =============== Item was changed: ----- Method: SpurGenerationScavenger>>initializeRememberedSet (in category 'initialization') ----- initializeRememberedSet | obj | obj := manager rememberedSetObj. obj = manager nilObject ifTrue: [obj := manager allocatePinnedSlots: 1024. manager rememberedSetObj: obj] ifFalse: "The Spur32to64BitBootstrap failed to set the type of rememberedSetObj to 64-bit indexability. + This is unimportant except for simulation; rememberedSet is declared as sqInt *, but to have - This is unimportant except for simulation; rememberedSet is declared as sqInt *, but in to have firstIndexableField: below answer a suitable type the format must be wordIndexableFormat." [manager setFormatOf: obj to: manager wordIndexableFormat]. self assert: (manager formatOf: obj) = manager wordIndexableFormat. self assert: (manager isPinned: obj). rememberedSet := manager firstIndexableField: obj. rememberedSetSize := 0. rememberedSetLimit := manager numSlotsOf: obj. self setRememberedSetRedZone! Item was added: + ----- Method: SpurMemoryManager>>objStackPageSlots (in category 'obj stacks') ----- + objStackPageSlots + ^ObjStackPageSlots!

1 0

Minifying Woes
by Tom Beckmann 24 Mar '23

24 Mar '23

Hi list, we're on a bit of an adventure to try and find the minimum size of a Squeak image that can still run a stdio REPL. After narrowing it down to around 6MB, we noticed that SpaceTally reported ~3MB of objects (as opposed to the 6MB that were saved on-disk). After a further deep-dive (in which SqueakJS and later the VM simulator were of immense help), we found that there were 60 objects of class index 19, which took up 3MB of space in the .image file. After some digging, we eventually found out that class index 19 are from SpurMemoryManager>>sixtyFourBitLongsClassIndexPun. As we understand it the "pun" objects are internal clones of the built-in classes (such as WeakArray, Array, ...), to prevent them from being found by a user. We even managed to locate one of the larger class-index=19 objects with the help of Tom (WoC): the hiddenRootsObj contains in its 4099's slot the RememberedSet, which in our image was just over 1MB in size. Now, we're wondering whether we can get closer to our goal of getting to the smallest possible on-disk image size (don't ask why, at this point it's more of a challenge...). Does the RememberedSet need to be persisted or could we (easily?) nil it before saving to disk? Are there other low hanging fruits in terms of VM-internal objects that could be freed during snapshot generation? Best, Jens (jl) and Tom (tobe) PS: A not-so-clean version of the minification process can be found here https://github.com/hpi-swa-lab/cloud-squeak We're in the process of cleaning it up and might send out a proper announcement once it's pretty.

3 3

[OpenSmalltalk/opensmalltalk-vm] 2ab50e: For ClipboardExtended plugin on Windows, fix typo ...
by Marcel Taeumel 24 Mar '23

24 Mar '23

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 2ab50e151090460afe67f3274fa841ca33ac6176 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2ab50e151090460afe… Author: Marcel Taeumel <marcel.taeumel(a)hpi.de> Date: 2023-03-24 (Fri, 24 Mar 2023) Changed paths: M platforms/win32/plugins/ClipboardExtendedPlugin/sqWin32ExtendedClipboard.c Log Message: ----------- For ClipboardExtended plugin on Windows, fix typo and type error.

1 0

[OpenSmalltalk/opensmalltalk-vm] 314e5d: CogVM source as per VMMaker.oscog-eem.3313
by Eliot Miranda 23 Mar '23

23 Mar '23

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 314e5d96bcf71baa216419d0a9cc577876818bba https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/314e5d96bcf71baa21… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2023-03-23 (Thu, 23 Mar 2023) Changed paths: M platforms/iOS/plugins/ClipboardExtendedPlugin/sqMacExtendedClipboard.m M platforms/win32/plugins/ClipboardExtendedPlugin/sqWin32ExtendedClipboard.c M src/plugins/BitBltPlugin/BitBltPlugin.c M src/plugins/ClipboardExtendedPlugin/ClipboardExtendedPlugin.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3313 Have the copyBits primitives answer #'bad receiver' if loadBitBltFrom:warping: fails. Speed up noSource/noHalftone setup there-in. Fix the ClipboardExtendedPlugin on Mac & Win32 so that multiple invocations of addClipboardData:dataFormat: allow different formats to be pasted at once. Regenerate the unchanged src/plugins/ClipboardExtendedPlugin/ClipboardExtendedPlugin.c so that the image can check the version number to see if the new support exists.

1 0

VM Maker: VMMaker.oscog.seperateMarking-eem.3322.mcz
by commits＠source.squeak.org 22 Mar '23

22 Mar '23

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog.seperateMarking-eem.3322.mcz ==================== Summary ==================== Name: VMMaker.oscog.seperateMarking-eem.3322 Author: eem Time: 22 March 2023, 10:58:15.765975 am UUID: 0b878e41-20d6-4948-b58b-c6e30ceb1ed6 Ancestors: VMMaker.oscog.seperateMarking-eem.3321 Merge VMMaker.oscog-eem.3313 =============== Diff against VMMaker.oscog.seperateMarking-eem.3321 =============== Item was removed: - ----- Method: BitBltSimulation>>ignoreSourceOrHalftone: (in category 'setup') ----- - ignoreSourceOrHalftone: formPointer - - formPointer = interpreterProxy nilObject ifTrue: [ ^true ]. - combinationRule = 0 ifTrue: [ ^true ]. - combinationRule = 5 ifTrue: [ ^true ]. - combinationRule = 10 ifTrue: [ ^true ]. - combinationRule = 15 ifTrue: [ ^true ]. - ^false! Item was changed: ----- Method: BitBltSimulation>>loadBitBltFrom:warping: (in category 'interpreter interface') ----- loadBitBltFrom: bbObj warping: aBool "Load context from BitBlt instance. Return false if anything is amiss" "NOTE this should all be changed to minX/maxX coordinates for simpler clipping -- once it works!!" | ok | <inline: false> bitBltOop := bbObj. isWarping := aBool. bitBltIsReceiver := bbObj = (interpreterProxy stackValue: interpreterProxy methodArgumentCount). numGCsOnInvocation := interpreterProxy statNumGCs. combinationRule := interpreterProxy fetchInteger: BBRuleIndex ofObject: bitBltOop. (interpreterProxy failed + or: [(combinationRule < 0 or: [combinationRule > (OpTableSize - 2)])"operation out of range" + or: [(combinationRule between: 16 and: 17)]]) - or: [combinationRule < 0 or: [combinationRule > (OpTableSize - 2)]]) - ifTrue: [^false "operation out of range"]. - (combinationRule >= 16 and: [combinationRule <= 17]) ifTrue: [^false "fail for old simulated paint, erase modes"]. + self noSourceCombinationRule + ifTrue: [noSource := noHalftone := true] + ifFalse: + [sourceForm := interpreterProxy fetchPointer: BBSourceFormIndex ofObject: bitBltOop. + noSource := sourceForm = interpreterProxy nilObject. + halftoneForm := interpreterProxy fetchPointer: BBHalftoneFormIndex ofObject: bitBltOop. + noHalftone := halftoneForm = interpreterProxy nilObject]. - sourceForm := interpreterProxy fetchPointer: BBSourceFormIndex ofObject: bitBltOop. - noSource := self ignoreSourceOrHalftone: sourceForm. - halftoneForm := interpreterProxy fetchPointer: BBHalftoneFormIndex ofObject: bitBltOop. - noHalftone := self ignoreSourceOrHalftone: halftoneForm. destForm := interpreterProxy fetchPointer: BBDestFormIndex ofObject: bbObj. ok := self loadBitBltDestForm. ok ifFalse:[^false]. destX := self fetchIntOrFloat: BBDestXIndex ofObject: bitBltOop ifNil: 0. destY := self fetchIntOrFloat: BBDestYIndex ofObject: bitBltOop ifNil: 0. width := self fetchIntOrFloat: BBWidthIndex ofObject: bitBltOop ifNil: destWidth. height := self fetchIntOrFloat: BBHeightIndex ofObject: bitBltOop ifNil: destHeight. interpreterProxy failed ifTrue: [^false]. noSource ifTrue: [sourceX := sourceY := 0] ifFalse: [ok := self loadBitBltSourceForm. ok ifFalse:[^false]. ok := self loadColorMap. ok ifFalse:[^false]. "Need the implicit setup here in case of 16<->32 bit conversions" (cmFlags bitAnd: ColorMapNewStyle) = 0 ifTrue:[self setupColorMasks]. sourceX := self fetchIntOrFloat: BBSourceXIndex ofObject: bitBltOop ifNil: 0. sourceY := self fetchIntOrFloat: BBSourceYIndex ofObject: bitBltOop ifNil: 0]. ok := self loadHalftoneForm. ok ifFalse:[^false]. clipX := self fetchIntOrFloat: BBClipXIndex ofObject: bitBltOop ifNil: 0. clipY := self fetchIntOrFloat: BBClipYIndex ofObject: bitBltOop ifNil: 0. clipWidth := self fetchIntOrFloat: BBClipWidthIndex ofObject: bitBltOop ifNil: destWidth. clipHeight := self fetchIntOrFloat: BBClipHeightIndex ofObject: bitBltOop ifNil: destHeight. interpreterProxy failed ifTrue: [^ false "non-integer value"]. clipX < 0 ifTrue: [clipWidth := clipWidth + clipX. clipX := 0]. clipY < 0 ifTrue: [clipHeight := clipHeight + clipY. clipY := 0]. clipX+clipWidth > destWidth ifTrue: [clipWidth := destWidth - clipX]. clipY+clipHeight > destHeight ifTrue: [clipHeight := destHeight - clipY]. numGCsOnInvocation ~= interpreterProxy statNumGCs ifTrue: "querySurface could be a callback in loadSourceFor: and loadDestForm:" [interpreterProxy primitiveFailFor: PrimErrObjectMoved. ^false]. ^true! Item was added: + ----- Method: BitBltSimulation>>noSourceCombinationRule (in category 'setup') ----- + noSourceCombinationRule + <inline: #always> + ^combinationRule = 0 + or: [combinationRule = 5 + or: [combinationRule = 10 + or: [combinationRule = 15]]]! Item was changed: ----- Method: BitBltSimulation>>primitiveCompareColorA:to:test: (in category 'primitives') ----- primitiveCompareColorA: colorA to: colorB test: testID "Invoke the pixel color comparing primitive.Only applicable if compiling with ENABLE_FAST_BLT" | rcvr val | <export: true> rcvr := self primitive: 'primitiveCompareColors' parameters: #(#Unsigned #Unsigned #SmallInteger ) receiver: #Oop. self cppIf: #'ENABLE_FAST_BLT' ifTrue: [(self loadBitBltFrom: rcvr) + ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. - ifFalse: [^ interpreterProxy primitiveFail]. self clipRange. (bbW <= 0 or: [bbH <= 0]) ifTrue: ["zero width or height; noop" ^ interpreterProxy primitiveFail]. self cCode: ' compare_operation_t op; op.matchRule = testID & 3; op.tally = testID & (1u<<3); op.srcA.bits = (void *) sourceBits; op.srcA.pitch = sourcePitch; op.srcA.depth = sourceDepth; op.srcA.msb = sourceMSB; op.srcA.x = sx; op.srcA.y = sy; op.srcB.bits = (void *) destBits; op.srcB.pitch = destPitch; op.srcB.depth = destDepth; op.srcB.msb = destMSB; op.srcB.x = dx; op.srcB.y = dy; op.width = bbW; op.height = bbH; op.colorA = colorA; op.colorB = colorB; val = compareColorsDispatch(&op);'. ^val asPositiveIntegerObj] ifFalse: [interpreterProxy primitiveFail]! Item was changed: ----- Method: BitBltSimulation>>primitiveCopyBits (in category 'primitives') ----- primitiveCopyBits "Invoke the copyBits primitive. If the destination is the display, then copy it to the screen." | rcvr | <export: true> rcvr := interpreterProxy stackValue: interpreterProxy methodArgumentCount. (self loadBitBltFrom: rcvr) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. - [^interpreterProxy primitiveFail]. self copyBits. interpreterProxy failed ifTrue: [^nil]. self showDisplayBits. interpreterProxy failed ifTrue: [^nil]. (combinationRule = 22 or: [combinationRule = 32]) ifTrue: [interpreterProxy methodReturnInteger: bitCount] ifFalse: [interpreterProxy methodReturnReceiver]! Item was changed: ----- Method: BitBltSimulation>>primitiveDisplayString (in category 'primitives') ----- primitiveDisplayString <export: true> | kernDelta xTable glyphMap stopIndex startIndex sourceString bbObj maxGlyph ascii glyphIndex sourcePtr left quickBlt | <var: 'sourcePtr' type: #'char *'> interpreterProxy methodArgumentCount = 6 ifFalse: [^interpreterProxy primitiveFail]. kernDelta := interpreterProxy stackIntegerValue: 0. xTable := interpreterProxy stackValue: 1. glyphMap := interpreterProxy stackValue: 2. stopIndex := interpreterProxy stackIntegerValue: 3. startIndex := interpreterProxy stackIntegerValue: 4. sourceString := interpreterProxy stackValue: 5. bbObj := interpreterProxy stackObjectValue: 6. interpreterProxy failed ifTrue: [^nil]. + (self loadBitBltFrom: bbObj) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. - ((interpreterProxy isArray: xTable) and: [(interpreterProxy isArray: glyphMap) and: [(interpreterProxy slotSizeOf: glyphMap) = 256 and: [(interpreterProxy isBytes: sourceString) and: [startIndex > 0 and: [stopIndex >= 0 "to avoid failing for empty strings..." and: [stopIndex <= (interpreterProxy byteSizeOf: sourceString) - and: [(self loadBitBltFrom: bbObj) and: [combinationRule ~= 30 "these two need extra source alpha" + and: [combinationRule ~= 31]]]]]]]]) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - and: [combinationRule ~= 31]]]]]]]]]) ifFalse: - [^interpreterProxy primitiveFail]. stopIndex = 0 ifTrue: [^interpreterProxy pop: 6 "the string is empty; pop args, return rcvr"]. maxGlyph := (interpreterProxy slotSizeOf: xTable) - 2. "See if we can go directly into copyLoopPixMap (usually we can)" quickBlt := destBits ~= 0 "no OS surfaces please" and:[sourceBits ~= 0 "and again" and:[noSource = false "needs a source" and:[sourceForm ~= destForm "no blits onto self" and:[cmFlags ~= 0 or:[sourceMSB ~= destMSB or:[sourceDepth ~= destDepth]]]]]]. "no point using slower version" quickBlt ifTrue: [endOfSource := sourceBits + (sourcePitch * sourceHeight). endOfDestination := destBits + (destPitch * destHeight)] ifFalse: [self lockSurfaces ifFalse: [^interpreterProxy primitiveFail]]. left := destX. sourcePtr := interpreterProxy firstIndexableField: sourceString. startIndex to: stopIndex do: [:charIndex| ascii := interpreterProxy byteAtPointer: sourcePtr + charIndex - 1. glyphIndex := interpreterProxy fetchInteger: ascii ofObject: glyphMap. (glyphIndex < 0 or: [glyphIndex > maxGlyph]) ifTrue: + [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. - [^interpreterProxy primitiveFail]. sourceX := interpreterProxy fetchInteger: glyphIndex ofObject: xTable. width := (interpreterProxy fetchInteger: glyphIndex + 1 ofObject: xTable) - sourceX. interpreterProxy failed ifTrue: [^nil]. self clipRange. "Must clip here" (bbW > 0 and: [bbH > 0]) ifTrue: [quickBlt ifTrue: [self destMaskAndPointerInit. self copyLoopPixMap. "both, hDir and vDir are known to be > 0" affectedL := dx. affectedR := dx + bbW. affectedT := dy. affectedB := dy + bbH] ifFalse: [self copyBitsLockedAndClipped]]. interpreterProxy failed ifTrue: [^nil]. destX := destX + width + kernDelta]. affectedL := left. quickBlt ifFalse: [self unlockSurfaces]. self showDisplayBits. "store destX back" interpreterProxy storeInteger: BBDestXIndex ofObject: bbObj withValue: destX. interpreterProxy pop: 6 "pop args, return rcvr"! Item was changed: ----- Method: BitBltSimulation>>primitiveDrawLoop (in category 'primitives') ----- primitiveDrawLoop "Invoke the line drawing primitive." | rcvr xDelta yDelta | <export: true> rcvr := interpreterProxy stackValue: 2. xDelta := interpreterProxy stackIntegerValue: 1. yDelta := interpreterProxy stackIntegerValue: 0. + (self loadBitBltFrom: rcvr) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. + interpreterProxy failed ifFalse: + [self drawLoopX: xDelta Y: yDelta. + self showDisplayBits. + interpreterProxy failed ifFalse: + [interpreterProxy pop: 2]]! - (self loadBitBltFrom: rcvr) ifFalse:[^interpreterProxy primitiveFail]. - interpreterProxy failed ifFalse:[ - self drawLoopX: xDelta Y: yDelta. - self showDisplayBits]. - interpreterProxy failed ifFalse:[interpreterProxy pop: 2].! Item was changed: ----- Method: SpurGenerationScavenger>>computeRefCountToShrinkRT (in category 'remembered set') ----- computeRefCountToShrinkRT "Some time in every scavenger's life there may come a time when someone writes code that stresses the remembered table. One might conclude that if the remembered table is full, then the right thing + to do is simply to tenure everything, emptying the remembered table. But in some circumstances this - to do is simply to tenure everything, emptying the remembered table. Bt in some circumstances this can be counter-productive, and result in the same situation arising soon after tenuring everything. Instead, we can try and selectively prune the remembered table, tenuring only those objects that are referenced by many objects in the remembered table. That's what this algorithm does. It reference counts young objects referenced from the remembered set, and then sets a threshold used to tenure objects oft referenced from the remembered set, thereby allowing the remembered set to shrink, while not tenuring everything. Once in a network monitoring application in a galaxy not dissimilar from the one this code inhabits, a tree of nodes referring to large integers was in precisely this situation. The nodes were old, and the integers were in new space. Some of the nodes referred to shared numbers, some their own unique numbers. The numbers were updated frequently. Were new space simply tenured when the remembered table was full, the remembered table would soon fill up as new numbers were computed. Only by selectively pruning the remembered table of nodes that shared data, was a balance achieved whereby the remembered table population was kept small, and tenuring rates were low." <inline: #never> | population | <var: 'population' declareC: 'long population[MaxRTRefCount + 1]'> self cCode: [self memset: population _: 0 _: (self sizeof: #long) * (MaxRTRefCount + 1)] inSmalltalk: [population := CArrayAccessor on: (Array new: MaxRTRefCount + 1 withAll: 0)]. self assert: self allNewSpaceObjectsHaveZeroRTRefCount. self referenceCountRememberedReferents: population. self setRefCountToShrinkRT: population "For debugging: (manager allNewSpaceObjectsDo: [:o| manager rtRefCountOf: o put: 0])"! Item was removed: - ----- Method: SpurGenerationScavenger>>followRememberedForwardersAndForgetFreeObjectsForPigCompact (in category 'gc - global') ----- - followRememberedForwardersAndForgetFreeObjectsForPigCompact - "Scan the remembered set. Follow any forwarded objects, - and remove free objects. This is for global scan-mark GC." - | index obj | - index := 0. - [index < rememberedSetSize] whileTrue: - [obj := rememberedSet at: index. - (manager isFreeObject: obj) "free; remove by overwriting with last element" - ifTrue: - [rememberedSetSize := rememberedSetSize - 1. - rememberedSet at: index put: (rememberedSet at: rememberedSetSize)] - ifFalse: - [(manager isForwarded: obj) ifTrue: - [manager setIsRememberedOf: obj to: false. - obj := manager followForwarded: obj. - self assert: (manager isRemembered: obj). - rememberedSet at: index put: obj]. - index := index + 1]]!

1 0

VM Maker: VMMaker.oscog-eem.3313.mcz
by commits＠source.squeak.org 22 Mar '23

22 Mar '23

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3313.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3313 Author: eem Time: 22 March 2023, 10:50:02.472629 am UUID: eec7f9f2-1dea-4660-bacc-8f63d29beb2e Ancestors: VMMaker.oscog-eem.3312 Have the copyBits primitives answer #'bad receiver' if loadBitBltFrom:warping: fails. Speed up noSource/noHalftone setup there-in. Typoe. Nuke unused method. =============== Diff against VMMaker.oscog-eem.3312 =============== Item was removed: - ----- Method: BitBltSimulation>>ignoreSourceOrHalftone: (in category 'setup') ----- - ignoreSourceOrHalftone: formPointer - - formPointer = interpreterProxy nilObject ifTrue: [ ^true ]. - combinationRule = 0 ifTrue: [ ^true ]. - combinationRule = 5 ifTrue: [ ^true ]. - combinationRule = 10 ifTrue: [ ^true ]. - combinationRule = 15 ifTrue: [ ^true ]. - ^false! Item was changed: ----- Method: BitBltSimulation>>loadBitBltFrom:warping: (in category 'interpreter interface') ----- loadBitBltFrom: bbObj warping: aBool "Load context from BitBlt instance. Return false if anything is amiss" "NOTE this should all be changed to minX/maxX coordinates for simpler clipping -- once it works!!" | ok | <inline: false> bitBltOop := bbObj. isWarping := aBool. bitBltIsReceiver := bbObj = (interpreterProxy stackValue: interpreterProxy methodArgumentCount). numGCsOnInvocation := interpreterProxy statNumGCs. combinationRule := interpreterProxy fetchInteger: BBRuleIndex ofObject: bitBltOop. (interpreterProxy failed + or: [(combinationRule < 0 or: [combinationRule > (OpTableSize - 2)])"operation out of range" + or: [(combinationRule between: 16 and: 17)]]) - or: [combinationRule < 0 or: [combinationRule > (OpTableSize - 2)]]) - ifTrue: [^false "operation out of range"]. - (combinationRule >= 16 and: [combinationRule <= 17]) ifTrue: [^false "fail for old simulated paint, erase modes"]. + self noSourceCombinationRule + ifTrue: [noSource := noHalftone := true] + ifFalse: + [sourceForm := interpreterProxy fetchPointer: BBSourceFormIndex ofObject: bitBltOop. + noSource := sourceForm = interpreterProxy nilObject. + halftoneForm := interpreterProxy fetchPointer: BBHalftoneFormIndex ofObject: bitBltOop. + noHalftone := halftoneForm = interpreterProxy nilObject]. - sourceForm := interpreterProxy fetchPointer: BBSourceFormIndex ofObject: bitBltOop. - noSource := self ignoreSourceOrHalftone: sourceForm. - halftoneForm := interpreterProxy fetchPointer: BBHalftoneFormIndex ofObject: bitBltOop. - noHalftone := self ignoreSourceOrHalftone: halftoneForm. destForm := interpreterProxy fetchPointer: BBDestFormIndex ofObject: bbObj. ok := self loadBitBltDestForm. ok ifFalse:[^false]. destX := self fetchIntOrFloat: BBDestXIndex ofObject: bitBltOop ifNil: 0. destY := self fetchIntOrFloat: BBDestYIndex ofObject: bitBltOop ifNil: 0. width := self fetchIntOrFloat: BBWidthIndex ofObject: bitBltOop ifNil: destWidth. height := self fetchIntOrFloat: BBHeightIndex ofObject: bitBltOop ifNil: destHeight. interpreterProxy failed ifTrue: [^false]. noSource ifTrue: [sourceX := sourceY := 0] ifFalse: [ok := self loadBitBltSourceForm. ok ifFalse:[^false]. ok := self loadColorMap. ok ifFalse:[^false]. "Need the implicit setup here in case of 16<->32 bit conversions" (cmFlags bitAnd: ColorMapNewStyle) = 0 ifTrue:[self setupColorMasks]. sourceX := self fetchIntOrFloat: BBSourceXIndex ofObject: bitBltOop ifNil: 0. sourceY := self fetchIntOrFloat: BBSourceYIndex ofObject: bitBltOop ifNil: 0]. ok := self loadHalftoneForm. ok ifFalse:[^false]. clipX := self fetchIntOrFloat: BBClipXIndex ofObject: bitBltOop ifNil: 0. clipY := self fetchIntOrFloat: BBClipYIndex ofObject: bitBltOop ifNil: 0. clipWidth := self fetchIntOrFloat: BBClipWidthIndex ofObject: bitBltOop ifNil: destWidth. clipHeight := self fetchIntOrFloat: BBClipHeightIndex ofObject: bitBltOop ifNil: destHeight. interpreterProxy failed ifTrue: [^ false "non-integer value"]. clipX < 0 ifTrue: [clipWidth := clipWidth + clipX. clipX := 0]. clipY < 0 ifTrue: [clipHeight := clipHeight + clipY. clipY := 0]. clipX+clipWidth > destWidth ifTrue: [clipWidth := destWidth - clipX]. clipY+clipHeight > destHeight ifTrue: [clipHeight := destHeight - clipY]. numGCsOnInvocation ~= interpreterProxy statNumGCs ifTrue: "querySurface could be a callback in loadSourceFor: and loadDestForm:" [interpreterProxy primitiveFailFor: PrimErrObjectMoved. ^false]. ^true! Item was added: + ----- Method: BitBltSimulation>>noSourceCombinationRule (in category 'setup') ----- + noSourceCombinationRule + <inline: #always> + ^combinationRule = 0 + or: [combinationRule = 5 + or: [combinationRule = 10 + or: [combinationRule = 15]]]! Item was changed: ----- Method: BitBltSimulation>>primitiveCompareColorA:to:test: (in category 'primitives') ----- primitiveCompareColorA: colorA to: colorB test: testID "Invoke the pixel color comparing primitive.Only applicable if compiling with ENABLE_FAST_BLT" | rcvr val | <export: true> rcvr := self primitive: 'primitiveCompareColors' parameters: #(#Unsigned #Unsigned #SmallInteger ) receiver: #Oop. self cppIf: #'ENABLE_FAST_BLT' ifTrue: [(self loadBitBltFrom: rcvr) + ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. - ifFalse: [^ interpreterProxy primitiveFail]. self clipRange. (bbW <= 0 or: [bbH <= 0]) ifTrue: ["zero width or height; noop" ^ interpreterProxy primitiveFail]. self cCode: ' compare_operation_t op; op.matchRule = testID & 3; op.tally = testID & (1u<<3); op.srcA.bits = (void *) sourceBits; op.srcA.pitch = sourcePitch; op.srcA.depth = sourceDepth; op.srcA.msb = sourceMSB; op.srcA.x = sx; op.srcA.y = sy; op.srcB.bits = (void *) destBits; op.srcB.pitch = destPitch; op.srcB.depth = destDepth; op.srcB.msb = destMSB; op.srcB.x = dx; op.srcB.y = dy; op.width = bbW; op.height = bbH; op.colorA = colorA; op.colorB = colorB; val = compareColorsDispatch(&op);'. ^val asPositiveIntegerObj] ifFalse: [interpreterProxy primitiveFail]! Item was changed: ----- Method: BitBltSimulation>>primitiveCopyBits (in category 'primitives') ----- primitiveCopyBits "Invoke the copyBits primitive. If the destination is the display, then copy it to the screen." | rcvr | <export: true> rcvr := interpreterProxy stackValue: interpreterProxy methodArgumentCount. (self loadBitBltFrom: rcvr) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. - [^interpreterProxy primitiveFail]. self copyBits. interpreterProxy failed ifTrue: [^nil]. self showDisplayBits. interpreterProxy failed ifTrue: [^nil]. (combinationRule = 22 or: [combinationRule = 32]) ifTrue: [interpreterProxy methodReturnInteger: bitCount] ifFalse: [interpreterProxy methodReturnReceiver]! Item was changed: ----- Method: BitBltSimulation>>primitiveDisplayString (in category 'primitives') ----- primitiveDisplayString <export: true> | kernDelta xTable glyphMap stopIndex startIndex sourceString bbObj maxGlyph ascii glyphIndex sourcePtr left quickBlt | <var: 'sourcePtr' type: #'char *'> interpreterProxy methodArgumentCount = 6 ifFalse: [^interpreterProxy primitiveFail]. kernDelta := interpreterProxy stackIntegerValue: 0. xTable := interpreterProxy stackValue: 1. glyphMap := interpreterProxy stackValue: 2. stopIndex := interpreterProxy stackIntegerValue: 3. startIndex := interpreterProxy stackIntegerValue: 4. sourceString := interpreterProxy stackValue: 5. bbObj := interpreterProxy stackObjectValue: 6. interpreterProxy failed ifTrue: [^nil]. + (self loadBitBltFrom: bbObj) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. - ((interpreterProxy isArray: xTable) and: [(interpreterProxy isArray: glyphMap) and: [(interpreterProxy slotSizeOf: glyphMap) = 256 and: [(interpreterProxy isBytes: sourceString) and: [startIndex > 0 and: [stopIndex >= 0 "to avoid failing for empty strings..." and: [stopIndex <= (interpreterProxy byteSizeOf: sourceString) - and: [(self loadBitBltFrom: bbObj) and: [combinationRule ~= 30 "these two need extra source alpha" + and: [combinationRule ~= 31]]]]]]]]) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - and: [combinationRule ~= 31]]]]]]]]]) ifFalse: - [^interpreterProxy primitiveFail]. stopIndex = 0 ifTrue: [^interpreterProxy pop: 6 "the string is empty; pop args, return rcvr"]. maxGlyph := (interpreterProxy slotSizeOf: xTable) - 2. "See if we can go directly into copyLoopPixMap (usually we can)" quickBlt := destBits ~= 0 "no OS surfaces please" and:[sourceBits ~= 0 "and again" and:[noSource = false "needs a source" and:[sourceForm ~= destForm "no blits onto self" and:[cmFlags ~= 0 or:[sourceMSB ~= destMSB or:[sourceDepth ~= destDepth]]]]]]. "no point using slower version" quickBlt ifTrue: [endOfSource := sourceBits + (sourcePitch * sourceHeight). endOfDestination := destBits + (destPitch * destHeight)] ifFalse: [self lockSurfaces ifFalse: [^interpreterProxy primitiveFail]]. left := destX. sourcePtr := interpreterProxy firstIndexableField: sourceString. startIndex to: stopIndex do: [:charIndex| ascii := interpreterProxy byteAtPointer: sourcePtr + charIndex - 1. glyphIndex := interpreterProxy fetchInteger: ascii ofObject: glyphMap. (glyphIndex < 0 or: [glyphIndex > maxGlyph]) ifTrue: + [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. - [^interpreterProxy primitiveFail]. sourceX := interpreterProxy fetchInteger: glyphIndex ofObject: xTable. width := (interpreterProxy fetchInteger: glyphIndex + 1 ofObject: xTable) - sourceX. interpreterProxy failed ifTrue: [^nil]. self clipRange. "Must clip here" (bbW > 0 and: [bbH > 0]) ifTrue: [quickBlt ifTrue: [self destMaskAndPointerInit. self copyLoopPixMap. "both, hDir and vDir are known to be > 0" affectedL := dx. affectedR := dx + bbW. affectedT := dy. affectedB := dy + bbH] ifFalse: [self copyBitsLockedAndClipped]]. interpreterProxy failed ifTrue: [^nil]. destX := destX + width + kernDelta]. affectedL := left. quickBlt ifFalse: [self unlockSurfaces]. self showDisplayBits. "store destX back" interpreterProxy storeInteger: BBDestXIndex ofObject: bbObj withValue: destX. interpreterProxy pop: 6 "pop args, return rcvr"! Item was changed: ----- Method: BitBltSimulation>>primitiveDrawLoop (in category 'primitives') ----- primitiveDrawLoop "Invoke the line drawing primitive." | rcvr xDelta yDelta | <export: true> rcvr := interpreterProxy stackValue: 2. xDelta := interpreterProxy stackIntegerValue: 1. yDelta := interpreterProxy stackIntegerValue: 0. + (self loadBitBltFrom: rcvr) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. + interpreterProxy failed ifFalse: + [self drawLoopX: xDelta Y: yDelta. + self showDisplayBits. + interpreterProxy failed ifFalse: + [interpreterProxy pop: 2]]! - (self loadBitBltFrom: rcvr) ifFalse:[^interpreterProxy primitiveFail]. - interpreterProxy failed ifFalse:[ - self drawLoopX: xDelta Y: yDelta. - self showDisplayBits]. - interpreterProxy failed ifFalse:[interpreterProxy pop: 2].! Item was changed: ----- Method: SpurGenerationScavenger>>computeRefCountToShrinkRT (in category 'remembered set') ----- computeRefCountToShrinkRT "Some time in every scavenger's life there may come a time when someone writes code that stresses the remembered table. One might conclude that if the remembered table is full, then the right thing + to do is simply to tenure everything, emptying the remembered table. But in some circumstances this - to do is simply to tenure everything, emptying the remembered table. Bt in some circumstances this can be counter-productive, and result in the same situation arising soon after tenuring everything. Instead, we can try and selectively prune the remembered table, tenuring only those objects that are referenced by many objects in the remembered table. That's what this algorithm does. It reference counts young objects referenced from the remembered set, and then sets a threshold used to tenure objects oft referenced from the remembered set, thereby allowing the remembered set to shrink, while not tenuring everything. Once in a network monitoring application in a galaxy not dissimilar from the one this code inhabits, a tree of nodes referring to large integers was in precisely this situation. The nodes were old, and the integers were in new space. Some of the nodes referred to shared numbers, some their own unique numbers. The numbers were updated frequently. Were new space simply tenured when the remembered table was full, the remembered table would soon fill up as new numbers were computed. Only by selectively pruning the remembered table of nodes that shared data, was a balance achieved whereby the remembered table population was kept small, and tenuring rates were low." <inline: #never> | population | <var: 'population' declareC: 'long population[MaxRTRefCount + 1]'> self cCode: [self memset: population _: 0 _: (self sizeof: #long) * (MaxRTRefCount + 1)] inSmalltalk: [population := CArrayAccessor on: (Array new: MaxRTRefCount + 1 withAll: 0)]. self assert: self allNewSpaceObjectsHaveZeroRTRefCount. self referenceCountRememberedReferents: population. self setRefCountToShrinkRT: population "For debugging: (manager allNewSpaceObjectsDo: [:o| manager rtRefCountOf: o put: 0])"! Item was removed: - ----- Method: SpurGenerationScavenger>>followRememberedForwardersAndForgetFreeObjectsForPigCompact (in category 'gc - global') ----- - followRememberedForwardersAndForgetFreeObjectsForPigCompact - "Scan the remembered set. Follow any forwarded objects, - and remove free objects. This is for global scan-mark GC." - | index obj | - index := 0. - [index < rememberedSetSize] whileTrue: - [obj := rememberedSet at: index. - (manager isFreeObject: obj) "free; remove by overwriting with last element" - ifTrue: - [rememberedSetSize := rememberedSetSize - 1. - rememberedSet at: index put: (rememberedSet at: rememberedSetSize)] - ifFalse: - [(manager isForwarded: obj) ifTrue: - [manager setIsRememberedOf: obj to: false. - obj := manager followForwarded: obj. - self assert: (manager isRemembered: obj). - rememberedSet at: index put: obj]. - index := index + 1]]!

1 0

[OpenSmalltalk/opensmalltalk-vm] 9624ac: For Windows, fixes some issues in the ClipboardExt...
by Marcel Taeumel 22 Mar '23

22 Mar '23

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 9624ac8c6bbd13070814a7fe5d3e21fe10faa701 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9624ac8c6bbd130708… Author: Marcel Taeumel <marcel.taeumel(a)hpi.de> Date: 2023-03-22 (Wed, 22 Mar 2023) Changed paths: M platforms/win32/plugins/ClipboardExtendedPlugin/sqWin32ExtendedClipboard.c Log Message: ----------- For Windows, fixes some issues in the ClipboardExtended plugin platform code. Every OpenClipboard must have a CloseClipboard or we would lock out other applications.

1 0

[OpenSmalltalk/opensmalltalk-vm] f20a00: Disable all CI workflows for "virtend" branch.
by Marcel Taeumel 22 Mar '23

22 Mar '23

Branch: refs/heads/virtend Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: f20a00030009a45b8b94a443b5c99eae865270ad https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f20a00030009a45b8b… Author: Marcel Taeumel <marcel.taeumel(a)hpi.de> Date: 2023-03-22 (Wed, 22 Mar 2023) Changed paths: A .github/workflows.ignore/extra-arm.yml A .github/workflows.ignore/extra.yml A .github/workflows.ignore/linux-arm.yml A .github/workflows.ignore/linux.yml A .github/workflows.ignore/macos-arm.yml A .github/workflows.ignore/macos.yml A .github/workflows.ignore/win.yml R .github/workflows/extra-arm.yml R .github/workflows/extra.yml R .github/workflows/linux-arm.yml R .github/workflows/linux.yml R .github/workflows/macos-arm.yml R .github/workflows/macos.yml R .github/workflows/win.yml Log Message: ----------- Disable all CI workflows for "virtend" branch.

1 0

[OpenSmalltalk/opensmalltalk-vm] 41bf62: Merge pull request #657 from LinqLover/docs/HowToB...
by Eliot Miranda 21 Mar '23

21 Mar '23

Branch: refs/heads/virtend Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 41bf62f9aadce6b3c808e573938349609a639236 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/41bf62f9aadce6b3c8… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2023-03-21 (Tue, 21 Mar 2023) Changed paths: M building/win32x86/HowToBuild M building/win64x64/HowToBuild Log Message: ----------- Merge pull request #657 from LinqLover/docs/HowToBuild/win-cygwin-path Revise docs on HowToBuild on Windows: cygwin tools must be in PATH [ci skip] Commit: ce219e01621a9a31c293bd802bf77bfc8538bca3 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/ce219e01621a9a31c2… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2023-03-21 (Tue, 21 Mar 2023) Changed paths: M platforms/iOS/plugins/ClipboardExtendedPlugin/sqMacExtendedClipboard.m M platforms/win32/plugins/ClipboardExtendedPlugin/sqWin32ExtendedClipboard.c Log Message: ----------- ClipboardExtendedPlugin: Make sure the ioAddClipboardData fails on macos if setData:forType: fails and/or raises an exception. Avoid crashing the VM if setData:forType: raises an exception. Fix a bug in the scanline width calculation for importing bitmaps on Windows for depths below 8. Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/b73339e14e17...ce…

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev March 2023