Vm-dev November 2022

vm-dev@lists.squeakfoundation.org

11 participants
72 discussions

Re: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Manually cherry-pick (28b073f)
by Marcel Taeumel 16 Nov '22

16 Nov '22

FYI, compilation via Cygwin/MinGW still fails because of that EXPORT/IMPORT-vs-extern issue. `okToFree` cannot be linked. I changed this in the Cog branch to "extern" for now but now sure whether this affects dynamic linking of the file-dialog plugin: ``` 2022-11-15T16:12:03.5584325Z C:/msys64/mingw64/bin/ld: builddbg/vm/FileDialogPlugin.lib(sqWin32FileDialog.o): in function `runSaveDlg': 2022-11-15T16:12:03.5585383Z D:/a/opensmalltalk-vm/opensmalltalk-vm/building/win64x64/squeak.cog.spur/../../../platforms/win32/plugins/FileDialogPlugin/sqWin32FileDialog.c:117: undefined reference to `__imp_okToFreeSTGMEDIUMHGLOBAL' 2022-11-15T16:12:03.5586566Z C:/msys64/mingw64/bin/ld: D:/a/opensmalltalk-vm/opensmalltalk-vm/building/win64x64/squeak.cog.spur/../../../platforms/win32/plugins/FileDialogPlugin/sqWin32FileDialog.c:119: undefined reference to `__imp_okToFreeSTGMEDIUMHGLOBAL' 2022-11-15T16:12:03.5587465Z C:/msys64/mingw64/bin/ld: builddbg/vm/FileDialogPlugin.lib(sqWin32FileDialog.o): in function `runOpenDlg': 2022-11-15T16:12:03.5588527Z D:/a/opensmalltalk-vm/opensmalltalk-vm/building/win64x64/squeak.cog.spur/../../../platforms/win32/plugins/FileDialogPlugin/sqWin32FileDialog.c:94: undefined reference to `__imp_okToFreeSTGMEDIUMHGLOBAL' 2022-11-15T16:12:03.5589961Z C:/msys64/mingw64/bin/ld: D:/a/opensmalltalk-vm/opensmalltalk-vm/building/win64x64/squeak.cog.spur/../../../platforms/win32/plugins/FileDialogPlugin/sqWin32FileDialog.c:96: undefined reference to `__imp_okToFreeSTGMEDIUMHGLOBAL' ``` -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/28b073f31e2767f14f… You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/commit/28b073f31e2767f14f54bf792a8f02016f0f65a1/90076930(a)github.com>

1 0

[OpenSmalltalk/opensmalltalk-vm] 1369b7: Fix #659
by Eliot Miranda 15 Nov '22

15 Nov '22

Branch: refs/heads/virtend Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 1369b73c6beaedb8513fb9ea446f8ab43fbf99af https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1369b73c6beaedb851… Author: Tobias Pape <tobias(a)netshed.de> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: M platforms/Cross/plugins/SqueakFFIPrims/sqFFIPlugin.c Log Message: ----------- Fix #659 Commit: 28b073f31e2767f14f54bf792a8f02016f0f65a1 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/28b073f31e2767f14f… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: M platforms/win32/vm/sqWin32Window.c Log Message: ----------- Manually cherry-pick commit d6bc6609244ea40346874a546b6f9244918d9de3 Merge: 5a9222c e754c98 Author: Nicolas Cellier <nicolas.cellier(a)sirehna.com> Date: Mon Nov 14 21:17:30 2022 +0100 Merge pull request #658 from OpenSmalltalk/Fix_GDI_leak Fix gdi leak On some win32 configurations and/or with some specific image (presumably when CursorWithAlpha is in use), we observe a GDI leak : numbers of GDI objects rapidly grow up to 10,000 (about 50 new objects/second). when the limit is reached, the image hangs and we have to kill it... With those fixes, the number of GDI objects remains stable at 20. commit e754c98e27c34090c588ddc7eb38f6e420156918 Author: Nicolas Cellier <nicolas.cellier(a)sirehna.com> Date: Mon Nov 14 15:06:48 2022 +0100 Fixup potential GDI leak in getDpiSystem in win32 A call to GetWindowDC() must be paired with a ReleaseDC(). Fortunately, this function is only used as fallback on old systems, normally getDpiMonitor is used instead. commit f0fa4e3781b5a845d585b7226a05c597ff20feae Author: Nicolas Cellier <nicolas.cellier(a)sirehna.com> Date: Mon Nov 14 14:59:50 2022 +0100 Use appropriate function to destroy the currentCursor in Win32 The currentCursor is either created by CreateCursor() in ioSetCursorWithMask() or by CreateIconIndirect() in ioSetCursorARGB() Thus it must be destroyed either by DestroyCursor() or by DestroyIcon() A new global variable currentCursorIsIcon memoize how the currentCursor was created and thus how it must be destroyed if ever the creation of cursor fails, restore the old cursor rather than letting it be null. Thus, only destroy the old cursor if the creation of new cursor succeeds. Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/fdc5fd6cd979...28…

1 0

Windows VM broken for ioShowDisplay
by Nicolas Cellier 15 Nov '22

15 Nov '22

Hi all, as Eliot already reported in October, after a few minutes, the 64bits image locks up on windows. The console reports an error from within ioShowDisplay SetDIBitsToDevice failed (0) width=1364,height=757,bits=7FF7471D68E8,dc=FFFFFFFF9D010B72 then several other gdi calls start to fail, like CreateCursor failed (0) a bit further, SetDIBitsToDevice failed (8), the error message concerns

4 17

[OpenSmalltalk/opensmalltalk-vm] Fix gdi leak (PR #658)
by Nicolas Cellier 15 Nov '22

15 Nov '22

On some win32 configurations and/or with some specific image, we observe a GDI leak : numbers of GDI objects rapidly grow up to 10,000 (about 50 new objects/second). when the limit is reached, the image hangs and we have to kill it... With those fixes, the number of GDI objects remains stable at 20. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/658 -- Commit Summary -- * Use appropriate function to destroy the currentCursor in Win32 * Fixup potential GDI leak in getDpiSystem in win32 -- File Changes -- M platforms/win32/vm/sqWin32Window.c (39) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/658.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/658.diff -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/658 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/pull/658(a)github.com>

3 7

[OpenSmalltalk/opensmalltalk-vm] 103637: Fix #659
by Tobias Pape 15 Nov '22

15 Nov '22

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 10363780d28a7f8ca992c1bcd9a77cd03697dd6d https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/10363780d28a7f8ca9… Author: Tobias Pape <tobias(a)netshed.de> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: M platforms/Cross/plugins/SqueakFFIPrims/sqFFIPlugin.c Log Message: ----------- Fix #659

1 0

[OpenSmalltalk/opensmalltalk-vm] f0fa4e: Use appropriate function to destroy the currentCur...
by Nicolas Cellier 14 Nov '22

14 Nov '22

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: f0fa4e3781b5a845d585b7226a05c597ff20feae https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f0fa4e3781b5a845d5… Author: Nicolas Cellier <nicolas.cellier(a)sirehna.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M platforms/win32/vm/sqWin32Window.c Log Message: ----------- Use appropriate function to destroy the currentCursor in Win32 The currentCursor is either created by CreateCursor() in ioSetCursorWithMask() or by CreateIconIndirect() in ioSetCursorARGB() Thus it must be destroyed either by DestroyCursor() or by DestroyIcon() A new global variable currentCursorIsIcon memoize how the currentCursor was created and thus how it must be destroyed if ever the creation of cursor fails, restore the old cursor rather than letting it be null. Thus, only destroy the old cursor if the creation of new cursor succeeds. Commit: e754c98e27c34090c588ddc7eb38f6e420156918 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/e754c98e27c34090c5… Author: Nicolas Cellier <nicolas.cellier(a)sirehna.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M platforms/win32/vm/sqWin32Window.c Log Message: ----------- Fixup potential GDI leak in getDpiSystem in win32 A call to GetWindowDC() must be paired with a ReleaseDC(). Fortunately, this function is only used as fallback on old systems, normally getDpiMonitor is used instead. Commit: d6bc6609244ea40346874a546b6f9244918d9de3 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/d6bc6609244ea40346… Author: Nicolas Cellier <nicolas.cellier(a)sirehna.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M platforms/win32/vm/sqWin32Window.c Log Message: ----------- Merge pull request #658 from OpenSmalltalk/Fix_GDI_leak Fix gdi leak On some win32 configurations and/or with some specific image (presumably when CursorWithAlpha is in use), we observe a GDI leak : numbers of GDI objects rapidly grow up to 10,000 (about 50 new objects/second). when the limit is reached, the image hangs and we have to kill it... With those fixes, the number of GDI objects remains stable at 20. Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/5a9222cd164d...d6…

1 0

[OpenSmalltalk/opensmalltalk-vm] f0fa4e: Use appropriate function to destroy the currentCur...
by Nicolas Cellier 14 Nov '22

14 Nov '22

Branch: refs/heads/Fix_GDI_leak Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: f0fa4e3781b5a845d585b7226a05c597ff20feae https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f0fa4e3781b5a845d5… Author: Nicolas Cellier <nicolas.cellier(a)sirehna.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M platforms/win32/vm/sqWin32Window.c Log Message: ----------- Use appropriate function to destroy the currentCursor in Win32 The currentCursor is either created by CreateCursor() in ioSetCursorWithMask() or by CreateIconIndirect() in ioSetCursorARGB() Thus it must be destroyed either by DestroyCursor() or by DestroyIcon() A new global variable currentCursorIsIcon memoize how the currentCursor was created and thus how it must be destroyed if ever the creation of cursor fails, restore the old cursor rather than letting it be null. Thus, only destroy the old cursor if the creation of new cursor succeeds. Commit: e754c98e27c34090c588ddc7eb38f6e420156918 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/e754c98e27c34090c5… Author: Nicolas Cellier <nicolas.cellier(a)sirehna.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M platforms/win32/vm/sqWin32Window.c Log Message: ----------- Fixup potential GDI leak in getDpiSystem in win32 A call to GetWindowDC() must be paired with a ReleaseDC(). Fortunately, this function is only used as fallback on old systems, normally getDpiMonitor is used instead. Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/f0fa4e3781b5%5E..…

1 0

Re: [Vm-dev] [squeak-dev] Posits
by Marcel Taeumel 11 Nov '22

11 Nov '22

Hmm... Patrick just pointed out to me that this critique addresses Unum I. "Posits" are Unum III: https://en.wikipedia.org/wiki/Unum_(number_format) [https://en.wikipedia.org/wiki/Unum_(number_format)] Hmm... Best, Marcel Am 11.11.2022 04:34:31 schrieb Craig Latta <craig(a)blackpagedigital.com>: This critique was interesting also, by William Kahan, the main architect of the IEEE 754-1985 floating-point spec: https://people.eecs.berkeley.edu/~wkahan/UnumSORN.pdf -C -- Craig Latta :: research computer scientist :: Black Page Digital :: Berkeley, California :: 663137D7940BF5C0AF :: C1349FB2ADA32C4D5314CE ::

1 0

Fwd: Posits [circular mapping between real numbers and the repressntation]
by Eliot Miranda 09 Nov '22

09 Nov '22

It would be nice to have these alongside Float. Perhaps with a 128 bit representation… Begin forwarded message: > From: Annick Fron <annick.fron(a)afceurope.com> > Date: November 9, 2022 at 1:14:46 AM PST > To: vwnc NC <vwnc(a)cs.uiuc.edu> > Subject: [vwnc] Posits > Reply-To: Annick Fron <annick.fron(a)afceurope.com> > > Hi, > > Does anybody know about posits ? > > https://www.cs.cornell.edu/courses/cs6120/2019fa/blog/posits/ > > Best regards > > Annick Eliot _,,,^..^,,,_ (phone)

1 0

[OpenSmalltalk/opensmalltalk-vm] fdc5fd: CogVM source as per VMMaker.oscog-eem.3275
by Eliot Miranda 09 Nov '22

09 Nov '22

Branch: refs/heads/virtend Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: fdc5fd6cd979e0e471518bcddde204f090bf06f7 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/fdc5fd6cd979e0e471… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2022-11-08 (Tue, 08 Nov 2022) Changed paths: M src/plugins/ClipboardExtendedPlugin/ClipboardExtendedPlugin.c M src/plugins/GeniePlugin/GeniePlugin.c M src/plugins/ImmX11Plugin/ImmX11Plugin.c M src/plugins/JPEGReadWriter2Plugin/JPEGReadWriter2Plugin.c M src/plugins/JoystickTabletPlugin/JoystickTabletPlugin.c M src/plugins/LocalePlugin/LocalePlugin.c M src/plugins/SocketPlugin/SocketPlugin.c M src/spur32.cog.lowcode/cogit.h M src/spur32.cog.lowcode/cogitARMv5.c M src/spur32.cog.lowcode/cogitIA32.c M src/spur32.cog.lowcode/cointerp.c M src/spur32.cog.lowcode/cointerp.h M src/spur32.cog.lowcode/gcc3x-cointerp.c M src/spur32.cog/cogit.h M src/spur32.cog/cogitARMv5.c M src/spur32.cog/cogitIA32.c M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/cointerpmt.c M src/spur32.cog/cointerpmt.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.cog/gcc3x-cointerpmt.c M src/spur32.sista/cogit.h M src/spur32.sista/cogitARMv5.c M src/spur32.sista/cogitIA32.c M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur32.stack.lowcode/gcc3x-interp.c M src/spur32.stack.lowcode/interp.c M src/spur32.stack/gcc3x-interp.c M src/spur32.stack/interp.c M src/spur64.cog.lowcode/cogit.h M src/spur64.cog.lowcode/cogitARMv8.c M src/spur64.cog.lowcode/cogitX64SysV.c M src/spur64.cog.lowcode/cogitX64WIN64.c M src/spur64.cog.lowcode/cointerp.c M src/spur64.cog.lowcode/cointerp.h M src/spur64.cog.lowcode/gcc3x-cointerp.c M src/spur64.cog/cogit.h M src/spur64.cog/cogitARMv8.c M src/spur64.cog/cogitX64SysV.c M src/spur64.cog/cogitX64WIN64.c M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/cointerpmt.c M src/spur64.cog/cointerpmt.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.sista/cogit.h M src/spur64.sista/cogitARMv8.c M src/spur64.sista/cogitX64SysV.c M src/spur64.sista/cogitX64WIN64.c M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c M src/spur64.stack.lowcode/gcc3x-interp.c M src/spur64.stack.lowcode/interp.c M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c M src/v3.cog/cogit.h M src/v3.cog/cogitARMv5.c M src/v3.cog/cogitIA32.c M src/v3.cog/cointerp.c M src/v3.cog/cointerp.h M src/v3.cog/gcc3x-cointerp.c M src/v3.stack/gcc3x-interp.c M src/v3.stack/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3275 Transform better expressions returning integers, floats or booleans in SmartSyntaxInterpreterPlugin methods. Fix an old bug in isBinaryArithmeticOrConditional that is failing to spot effect-free code. Have TSendNode>>hasEffect answer false for sizeof:. Use sizeof: directly in JPEGReadWriter2Plugin to get less junk code.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev November 2022