Vm-dev September 2021

vm-dev@lists.squeakfoundation.org

15 participants
137 discussions

VM Maker: VMMaker.oscog-eem.3061.mcz
by commits＠source.squeak.org 07 Sep '21

07 Sep '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3061.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3061 Author: eem Time: 6 September 2021, 8:04:47.262323 pm UUID: f660358c-9f5e-474e-8a1d-c41b4226a48c Ancestors: VMMaker.oscog-eem.3060 SpurMemoryManager: newSpaceLimit is equal to oldSpaceStart and therefore surplus to requirements. =============== Diff against VMMaker.oscog-eem.3060 =============== Item was changed: ----- Method: Spur32BitCoMemoryManager>>checkMemoryMap (in category 'debug support') ----- checkMemoryMap "Override to check that Cog methods are considered neither young nor old. Being young would cause them to be scavenged. Being old would cause them to be remembered if stored into (but wait, they don't get stored into)." + super checkMemoryMap. - self assert: (self isYoungObject: newSpaceStart). - self assert: (self isYoungObject: newSpaceLimit - self wordSize). - self assert: (self isOldObject: newSpaceStart) not. - self assert: (self isOldObject: newSpaceLimit - self wordSize) not. - self assert: (self isYoungObject: newSpaceLimit) not. - self assert: (self isYoungObject: oldSpaceStart) not. - self assert: (self isYoungObject: endOfMemory) not. - self assert: (self isOldObject: oldSpaceStart). - self assert: (self isOldObject: endOfMemory). "we would like the following to be true, but we either choose one boundary check for cogMethods vs objects (isMachineCodeFrame: et al) or one boundary check for copyAndForward:. We can't have both, and the former is likely the highest dynamic frequency." false ifTrue: [self assert: (self isYoungObject: cogit minCogMethodAddress) not. self assert: (self isYoungObject: cogit maxCogMethodAddress) not]. self assert: (self isOldObject: cogit minCogMethodAddress) not. self assert: (self isOldObject: cogit maxCogMethodAddress) not! Item was changed: ----- Method: Spur32BitCoMemoryManager>>initializeFreeSpaceForFacadeFrom:to: (in category 'simulation only') ----- initializeFreeSpaceForFacadeFrom: base to: limit "c.f. initializeFreeSpacePostLoad: freeListObj." | freeListObj freeBytes | + oldSpaceStart := freeStart := base. - newSpaceLimit := oldSpaceStart := freeStart := base. endOfMemory := limit. scavengeThreshold := limit * 3 // 4. segmentManager initSegmentForInImageCompilationFrom: base to: limit. freeListObj := self allocateSlots: self numFreeLists format: self wordIndexableFormat classIndex: self wordSizeClassIndexPun. freeLists := self firstIndexableField: freeListObj. freeListsMask := 0. 0 to: self numFreeLists - 1 do: [:i| (freeLists at: i) ~= 0 ifTrue: [freeListsMask := freeListsMask bitOr: (1 << i). freeLists at: i put: (segmentManager swizzleObj: (freeLists at: i))]]. freeBytes := segmentManager lastSegment segLimit - self bridgeSize - freeStart. freeLists at: 0 put: (self initFreeChunkWithBytes: freeBytes at: freeStart). totalFreeOldSpace := freeBytes! Item was changed: ----- Method: Spur32BitCoMemoryManager>>isReallyYoungObject: (in category 'object testing') ----- isReallyYoungObject: objOop <api> "Answer if obj is young. Require that obj is non-immediate. Override to filter-out Cog methods" self assert: (self isNonImmediate: objOop). + ^(self oop: objOop isLessThan: oldSpaceStart) - ^(self oop: objOop isLessThan: newSpaceLimit) and: [self oop: objOop isGreaterThanOrEqualTo: newSpaceStart]! Item was changed: ----- Method: Spur64BitCoMemoryManager>>checkMemoryMap (in category 'debug support') ----- checkMemoryMap "Override to check that Cog methods are considered neither young nor old. Being young would cause them to be scavenged. Being old would cause them to be remembered if stored into (but wait, they don't get stored into)." + super checkMemoryMap. - self assert: (self isYoungObject: newSpaceStart). - self assert: (self isYoungObject: newSpaceLimit - self wordSize). - self assert: (self isOldObject: newSpaceStart) not. - self assert: (self isOldObject: newSpaceLimit - self wordSize) not. - self assert: (self isYoungObject: newSpaceLimit) not. - self assert: (self isYoungObject: oldSpaceStart) not. - self assert: (self isYoungObject: endOfMemory) not. - self assert: (self isOldObject: oldSpaceStart). - self assert: (self isOldObject: endOfMemory). "we would like the following to be true, but we either choose one boundary check for cogMethods vs objects (isMachineCodeFrame: et al) or one boundary check for copyAndForward:. We can't have both, and the former is likely the highest dynamic frequency." false ifTrue: [self assert: (self isYoungObject: cogit minCogMethodAddress) not. self assert: (self isYoungObject: cogit maxCogMethodAddress) not]. self assert: (self isOldObject: cogit minCogMethodAddress) not. self assert: (self isOldObject: cogit maxCogMethodAddress) not! Item was changed: ----- Method: Spur64BitCoMemoryManager>>initializeFreeSpaceForFacadeFrom:to: (in category 'simulation only') ----- initializeFreeSpaceForFacadeFrom: base to: limit "c.f. initializeFreeSpacePostLoad: freeListObj." | freeListObj freeBytes | + oldSpaceStart := freeStart := base. - newSpaceLimit := oldSpaceStart := freeStart := base. endOfMemory := limit. scavengeThreshold := limit * 3 // 4. segmentManager initSegmentForInImageCompilationFrom: base to: limit. freeListObj := self allocateSlots: self numFreeLists format: self wordIndexableFormat classIndex: self wordSizeClassIndexPun. freeLists := self firstIndexableField: freeListObj. freeListsMask := 0. 0 to: self numFreeLists - 1 do: [:i| (freeLists at: i) ~= 0 ifTrue: [freeListsMask := freeListsMask bitOr: (1 << i). freeLists at: i put: (segmentManager swizzleObj: (freeLists at: i))]]. freeBytes := segmentManager lastSegment segLimit - self bridgeSize - freeStart. freeLists at: 0 put: (self initFreeChunkWithBytes: freeBytes at: freeStart). totalFreeOldSpace := freeBytes! Item was changed: ----- Method: Spur64BitCoMemoryManager>>isReallyYoungObject: (in category 'object testing') ----- isReallyYoungObject: objOop <api> "Answer if obj is young. Require that obj is non-immediate. Override to filter-out Cog methods" self assert: (self isNonImmediate: objOop). + ^(self oop: objOop isLessThan: oldSpaceStart) - ^(self oop: objOop isLessThan: newSpaceLimit) and: [self oop: objOop isGreaterThanOrEqualTo: newSpaceStart]! Item was changed: CogClass subclass: #SpurMemoryManager (excessive size, no diff calculated) Item was changed: ----- Method: SpurMemoryManager class>>declareCVarsIn: (in category 'translation') ----- declareCVarsIn: aCCodeGenerator self class == thisContext methodClass ifFalse: [^self]. "Don't duplicate decls in subclasses" aCCodeGenerator removeVariable: 'memory'. "memory is a simulation time thing only" + self declareCAsOop: #( freeStart scavengeThreshold newSpaceStart pastSpaceStart + oldSpaceStart lowSpaceThreshold freeOldSpaceStart endOfMemory) - self declareCAsOop: #( freeStart scavengeThreshold newSpaceStart newSpaceLimit pastSpaceStart - lowSpaceThreshold freeOldSpaceStart oldSpaceStart endOfMemory) in: aCCodeGenerator. self declareCAsUSqLong: (self allInstVarNames select: [:ivn| ivn endsWith: 'Usecs']), #(statAllocatedBytes) in: aCCodeGenerator. aCCodeGenerator var: #lastHash type: #usqInt; var: #freeListsMask type: #usqInt; var: #freeLists type: #'sqInt *'; var: #objStackInvalidBecause type: #'char *'; var: #unscannedEphemerons type: #SpurContiguousObjStack; var: #heapGrowthToSizeGCRatio type: #float; var: #heapSizeAtPreviousGC type: #usqInt; var: #totalFreeOldSpace type: #usqInt; var: #maxOldSpaceSize type: #usqInt. aCCodeGenerator var: #oldSpaceUsePriorToScavenge type: #sqLong. aCCodeGenerator var: #remapBuffer declareC: 'sqInt remapBuffer[RemapBufferSize + 1 /* ', (RemapBufferSize + 1) printString, ' */]'. aCCodeGenerator var: #extraRoots declareC: 'sqInt *extraRoots[ExtraRootsSize + 1 /* ', (ExtraRootsSize + 1) printString, ' */]'! Item was changed: ----- Method: SpurMemoryManager>>allocateMemoryOfSize:newSpaceSize:stackSize:codeSize: (in category 'spur bootstrap') ----- allocateMemoryOfSize: memoryBytes newSpaceSize: newSpaceBytes stackSize: stackBytes codeSize: codeBytes "Intialize the receiver for bootsraping an image. Set up a large oldSpace and an empty newSpace and set-up freeStart and scavengeThreshold to allocate in oldSpace. Later on (in initializePostBootstrap) freeStart and scavengeThreshold will be set to sane values." <doNotGenerate> self assert: (memoryBytes \\ self allocationUnit = 0 and: [newSpaceBytes \\ self allocationUnit = 0 and: [codeBytes \\ self allocationUnit = 0]]). self allocateMemoryOfSize: memoryBytes + newSpaceBytes + codeBytes + stackBytes. newSpaceStart := codeBytes + stackBytes. endOfMemory := freeOldSpaceStart := memoryBytes + newSpaceBytes + codeBytes + stackBytes. "leave newSpace empty for the bootstrap" freeStart := newSpaceBytes + newSpaceStart. + oldSpaceStart := newSpaceBytes + newSpaceStart. - oldSpaceStart := newSpaceLimit := newSpaceBytes + newSpaceStart. scavengeThreshold := memory size * memory bytesPerElement. "i.e. /don't/ scavenge." scavenger := SpurGenerationScavenger simulatorClass new. scavenger manager: self. scavenger newSpaceStart: newSpaceStart newSpaceBytes: newSpaceBytes survivorBytes: newSpaceBytes // self scavengerDenominator. compactor := self class compactorClass simulatorClass new manager: self; yourself! Item was changed: ----- Method: SpurMemoryManager>>checkMemoryMap (in category 'debug support') ----- checkMemoryMap self assert: (self isYoungObject: newSpaceStart). - self assert: (self isYoungObject: newSpaceLimit - self wordSize). self assert: (self isOldObject: newSpaceStart) not. + self assert: (self isYoungObject: oldSpaceStart - self wordSize). + self assert: (self isOldObject: oldSpaceStart - self wordSize) not. - self assert: (self isOldObject: newSpaceLimit - self wordSize) not. - self assert: (self isYoungObject: newSpaceLimit) not. self assert: (self isYoungObject: oldSpaceStart) not. - self assert: (self isYoungObject: endOfMemory) not. - self assert: (self isOldObject: newSpaceLimit). self assert: (self isOldObject: oldSpaceStart). + self assert: (self isYoungObject: endOfMemory) not. self assert: (self isOldObject: endOfMemory)! Item was changed: ----- Method: SpurMemoryManager>>checkOkayYoungReferrer: (in category 'debug support') ----- checkOkayYoungReferrer: obj "Verify that the given obj is a valid youngReferrer. Check remembered is set and is in remembered set. Answer true if OK. Otherwise print reason and answer false. Assumes the object contains young references." + (self oop: obj isLessThan: oldSpaceStart) ifTrue: - (self oop: obj isLessThan: newSpaceLimit) ifTrue: [^true]. (self isRemembered: obj) ifFalse: [ self print: 'remembered bit is not set in '; printHex: obj; cr. ^false ]. (scavenger isInRememberedSet: obj) ifTrue: [^true]. self printHex: obj; print: ' has remembered bit set but is not in remembered set'; cr. ^false ! Item was changed: ----- Method: SpurMemoryManager>>flushNewSpace (in category 'gc - scavenging') ----- flushNewSpace "Fush everything in new space. Do so by setting the tenure + threshold above everything in newSpace, i.e. oldSpaceStart." - threshold above everything in newSpace, i.e. newSpaceLimit." | savedTenuringThreshold | savedTenuringThreshold := scavenger getRawTenuringThreshold. + scavenger setRawTenuringThreshold: oldSpaceStart. - scavenger setRawTenuringThreshold: newSpaceLimit. self scavengingGCTenuringIf: TenureByAge. scavenger setRawTenuringThreshold: savedTenuringThreshold. self assert: scavenger rememberedSetSize = 0. self assert: pastSpaceStart = scavenger pastSpace start. self assert: freeStart = scavenger eden start! Item was changed: ----- Method: SpurMemoryManager>>isInNewSpace: (in category 'object testing') ----- isInNewSpace: objOop + ^(self oop: objOop isLessThan: oldSpaceStart) - ^(self oop: objOop isLessThan: newSpaceLimit) and: [self oop: objOop isGreaterThanOrEqualTo: newSpaceStart]! Item was changed: ----- Method: SpurMemoryManager>>isYoung: (in category 'object testing') ----- isYoung: oop <api> "Answer if oop is young." ^(self isNonImmediate: oop) + and: [self oop: oop isLessThan: oldSpaceStart]! - and: [self oop: oop isLessThan: newSpaceLimit]! Item was changed: ----- Method: SpurMemoryManager>>isYoungObject: (in category 'object testing') ----- isYoungObject: objOop <api> "Answer if obj is young. Require that obj is non-immediate." self assert: (self isNonImmediate: objOop). + ^self oop: objOop isLessThan: oldSpaceStart! - ^self oop: objOop isLessThan: newSpaceLimit! Item was removed: - ----- Method: SpurMemoryManager>>newSpaceLimit (in category 'accessing') ----- - newSpaceLimit - <cmacro: '() GIV(newSpaceLimit)'> - ^newSpaceLimit! Item was changed: ----- Method: SpurMemoryManager>>objectAfter: (in category 'object enumeration') ----- objectAfter: objOop <api> "Object parsing. 1. all objects have at least a word following the header, for a forwarding pointer. 2. objects with an overflow size have a preceeing word with a saturated slotSize. If the word following an object doesn't have a saturated size field it must be a single-header object. If the word following does have a saturated slotSize it must be the overflow size word." <inline: false> + (self oop: objOop isLessThan: oldSpaceStart) ifTrue: - (self oop: objOop isLessThan: newSpaceLimit) ifTrue: [(self isInEden: objOop) ifTrue: [^self objectAfter: objOop limit: freeStart]. (self isInPastSpace: objOop) ifTrue: [^self objectAfter: objOop limit: pastSpaceStart]. ^self objectAfter: objOop limit: scavenger futureSurvivorStart]. ^self objectAfter: objOop limit: endOfMemory! Item was changed: ----- Method: SpurMemoryManager>>objectBefore: (in category 'object enumeration') ----- objectBefore: objOop <api> | prev | prev := nil. + (self oop: objOop isLessThan: oldSpaceStart) ifTrue: - (self oop: objOop isLessThan: newSpaceLimit) ifTrue: [self allNewSpaceEntitiesDo: [:o| (self oop: o isGreaterThanOrEqualTo: objOop) ifTrue: [^prev]. prev := o]. ^prev]. self allOldSpaceEntitiesDo: [:o| (self oop: o isGreaterThanOrEqualTo: objOop) ifTrue: [^prev]. prev := o]. ^prev! Item was changed: ----- Method: SpurMemoryManager>>scavengingGCTenuringIf: (in category 'gc - scavenging') ----- scavengingGCTenuringIf: tenuringCriterion "Run the scavenger." <inline: false> self assert: remapBufferCount = 0. (self asserta: scavenger eden limit - freeStart > coInterpreter interpreterAllocationReserveBytes) ifFalse: [coInterpreter tab; printNum: scavenger eden limit - freeStart; space; printNum: coInterpreter interpreterAllocationReserveBytes; space; printNum: coInterpreter interpreterAllocationReserveBytes - (scavenger eden limit - freeStart); cr]. self checkMemoryMap. self checkFreeSpace: GCModeNewSpace. self runLeakCheckerFor: GCModeNewSpace. coInterpreter preGCAction: GCModeNewSpace; "would prefer this to be in mapInterpreterOops, but compatibility with ObjectMemory dictates it goes here." + flushMethodCacheFrom: newSpaceStart to: oldSpaceStart. - flushMethodCacheFrom: newSpaceStart to: newSpaceLimit. needGCFlag := false. gcStartUsecs := coInterpreter ioUTCMicrosecondsNow. self doScavenge: tenuringCriterion. statScavenges := statScavenges + 1. statGCEndUsecs := coInterpreter ioUTCMicrosecondsNow. statSGCDeltaUsecs := statGCEndUsecs - gcStartUsecs. statScavengeGCUsecs := statScavengeGCUsecs + statSGCDeltaUsecs. statRootTableCount := scavenger rememberedSetSize. scavenger logScavenge. coInterpreter postGCAction: GCModeNewSpace. self runLeakCheckerFor: GCModeNewSpace. self checkFreeSpace: GCModeNewSpace! Item was changed: ----- Method: SpurMemoryManager>>setHeapBase:memoryLimit:endOfMemory: (in category 'snapshot') ----- setHeapBase: baseOfHeap memoryLimit: memLimit endOfMemory: memEnd "Set the dimensions of the heap, answering the start of oldSpace. edenBytes holds the desired ``size of eden'' which is actually the total size of new space minus the reserve. edenBytes is then divided up between eden and the two survivor spaces, where each survivor space is a scavengerDenominator (one seventh) of the total." "Transcript cr; nextPutAll: 'heapBase: '; print: baseOfHeap; nextPut: $/; nextPutAll: baseOfHeap hex; nextPutAll: ' memLimit '; print: memLimit; nextPut: $/; nextPutAll: memLimit hex; nextPutAll: ' memEnd '; print: memEnd; nextPut: $/; nextPutAll: memEnd hex; cr; flush." "This is more than a little counter-intuitive. Eden must include interpreterAllocationReserveBytes." <inline: #never> | reserve | reserve := coInterpreter interpreterAllocationReserveBytes. newSpaceStart := baseOfHeap. + oldSpaceStart := baseOfHeap + edenBytes + reserve. - newSpaceLimit := baseOfHeap + edenBytes + reserve. scavenger newSpaceStart: newSpaceStart + newSpaceBytes: oldSpaceStart - newSpaceStart + survivorBytes: oldSpaceStart - newSpaceStart - reserve // self scavengerDenominator. - newSpaceBytes: newSpaceLimit - newSpaceStart - survivorBytes: newSpaceLimit - newSpaceStart - reserve // self scavengerDenominator. freeStart := scavenger eden start. pastSpaceStart := scavenger pastSpace start. - oldSpaceStart := newSpaceLimit. freeOldSpaceStart := memEnd. endOfMemory := memLimit. ^baseOfHeap! Item was changed: ----- Method: SpurMemoryManager>>storeCheckBoundary (in category 'accessing') ----- storeCheckBoundary + "A renaming for the Cogit, which can't make sense of GIV(oldSpaceStart)" - "A renaming for the Cogit, which couldn't make sense of GIV(newSpaceLimit)" <api> + ^oldSpaceStart! - ^newSpaceLimit! Item was changed: ----- Method: SpurSegmentManager>>initializeFromFreeChunks: (in category 'simulation only') ----- initializeFromFreeChunks: freeChunks <doNotGenerate> "For testing, create a set of segments using the freeChunks as bridges." self assert: (freeChunks allSatisfy: [:f| manager hasOverflowHeader: f]). numSegments := freeChunks size. freeChunks do: [:f| manager initSegmentBridgeWithBytes: (manager bytesInBody: f) at: (manager startOfObject: f). self assert: (manager isSegmentBridge: f)]. segments := (1 to: numSegments) collect: [:i| | bridge start size | bridge := freeChunks at: i. start := i = 1 + ifTrue: [manager oldSpaceStart] - ifTrue: [manager newSpaceLimit] ifFalse: [manager addressAfter: (freeChunks at: i - 1)]. size := bridge + manager baseHeaderSize - start. SpurSegmentInfo new segStart: start; segSize: size; yourself]. manager setEndOfMemory: segments last segLimit. segments := CArrayAccessor on: segments. freeChunks with: segments object do: [:bridge :segment| self assert: (self isValidSegmentBridge: bridge). self assert: bridge = (self bridgeFor: segment)]!

1 0

VM Maker: VMMaker.oscog-eem.3060.mcz
by commits＠source.squeak.org 07 Sep '21

07 Sep '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3060.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3060 Author: eem Time: 6 September 2021, 7:40:34.416094 pm UUID: 638e8714-df7b-4450-85ee-b5093d25822d Ancestors: VMMaker.oscog-eem.3059 Fix a regression in image segment loading introduced by VMMaker.oscog-eem.2819. The old image segment array shortening code created a header ambiguous with a slimbridge if the array was in new space. In this case we also have to shorten the array's normal slot count so its header is taken as a slimbridge. =============== Diff against VMMaker.oscog-eem.3059 =============== Item was changed: ----- Method: Spur32BitMemoryManager>>objectAfterMaybeSlimBridge:limit: (in category 'object enumeration-private') ----- objectAfterMaybeSlimBridge: objOop limit: limit "Object parsing. 1. all objects have at least a word following the header, for a forwarding pointer. 2. objects with an overflow size have a preceding word with a saturated numSlots. If the word following an object doesn't have a saturated numSlots field it must be a single-header object. If the word following does have a saturated numSlots it must be the overflow size word. This variation on objectAfter:limit: allows for a single (64-bit) word bridge which may be needed to bridge from an almost full pastSpace to eden. It is only used in the flat enumerators that use startAddressForBridgedHeapEnumeration and enumerate over pastSpace, eden and oldSpace in that order. Note that the order for allObjects, and allInstances enumerates over oldSpace first. This hack is cheap. It increases the size of the objectAfter code, but saves two extra copies of the inner loop, since the inner loop now enumerates over all of pastSpace, eden and oldSpace. The test for a slim bridge is only performed if applied to an overflow header, and typically only + 1 in 400 objects have overflow headers in 32-bits, 1 in 500 in 64-bits. The complication is that - 1 in 400 objects have overflow headers in 32-bits, 1 in 500 in 64-bits. The complication is that image segment loading evaporates the word array by setting the overflow slots to 1, and this + is ambiguous with a slimbridge. The resolution is that if the segmentArray has an overflow header, + and is in new space, then it slot size can be zeroed and its overflow header changed to a slimbridge." - is ambiguous with a slimbridge. The resolution is that slimbridges are used only in new space." <inline: true> | followingWordAddress followingWord | followingWordAddress := self addressAfter: objOop. (self oop: followingWordAddress isGreaterThanOrEqualTo: limit) ifTrue: [^limit]. self flag: #endianness. followingWord := self longAt: followingWordAddress + 4. ^followingWord >> self numSlotsHalfShift = self numSlotsMask ifTrue: [((self oop: objOop isLessThan: oldSpaceStart) and: [1 = (self longAt: followingWordAddress)]) "i.e. the raw overflow slots in the overflow word" ifTrue: [followingWordAddress + self baseHeaderSize + self baseHeaderSize] "skip the one word slimbridge" ifFalse: [followingWordAddress + self baseHeaderSize]] ifFalse: [followingWordAddress]! Item was changed: ----- Method: Spur64BitMemoryManager>>objectAfterMaybeSlimBridge:limit: (in category 'object enumeration-private') ----- objectAfterMaybeSlimBridge: objOop limit: limit "Object parsing. 1. all objects have at least a word following the header, for a forwarding pointer. 2. objects with an overflow size have a preceding word with a saturated numSlots. If the word following an object doesn't have a saturated numSlots field it must be a single-header object. If the word following does have a saturated numSlots it must be the overflow size word. This variation on objectAfter:limit: allows for a single (64-bit) word bridge which may be needed to bridge from an almost full pastSpace to eden. It is only used in the flat enumerators that use startAddressForBridgedHeapEnumeration and enumerate over pastSpace, eden and oldSpace in that order. Note that the order for allObjects, and allInstances enumerates over oldSpace first. This hack is cheap. It increases the size of the objectAfter code, but saves two extra copies of the inner loop, since the inner loop now enumerates over all of pastSpace, eden and oldSpace. The test for a slim bridge is only performed if applied to an overflow header, and typically only 1 in 400 objects have overflow headers in 32-bits, 1 in 500 in 64-bits. The complication is that image segment loading evaporates the word array by setting the overflow slots to 1, and this + is ambiguous with a slimbridge. The resolution is that if the segmentArray has an overflow header, + and is in new space, then it slot size can be zeroed and its overflow header changed to a slimbridge." - is ambiguous with a slimbridge. The resolution is that slimbridges are used only in new space." <inline: true> | followingWordAddress followingWord | followingWordAddress := self addressAfter: objOop. (self oop: followingWordAddress isGreaterThanOrEqualTo: limit) ifTrue: [^limit]. self flag: #endianness. followingWord := self longAt: followingWordAddress. ^followingWord >> self numSlotsFullShift = self numSlotsMask ifTrue: [((self oop: objOop isLessThan: oldSpaceStart) and: [(followingWord bitAnd: 16rFFFFFFFFFFFFFF) = 1]) ifTrue: [followingWordAddress + self baseHeaderSize + self baseHeaderSize] "skip the one word slimbridge" ifFalse: [followingWordAddress + self baseHeaderSize]] ifFalse: [followingWordAddress]! Item was changed: ----- Method: SpurMemoryManager>>loadImageSegmentFrom:outPointers: (in category 'image segment in/out') ----- loadImageSegmentFrom: segmentWordArray outPointers: outPointerArray "This primitive is called from Smalltalk as... <imageSegment> loadSegmentFrom: aWordArray outPointers: anArray." "This primitive will load a binary image segment created by primitiveStoreImageSegment. It expects the outPointer array to be of the proper size, and the wordArray to be well formed. It will return as its value the original array of roots, and the segmentWordArray will become an array of the loaded objects. If this primitive should fail, the segmentWordArray will, sadly, have been reduced to an unrecognizable and unusable jumble. But what more could you have done with it anyway? The primitive, if it succeeds, also becomes the segmentWordArray into the array of loaded objects. This allows fixing up of loaded objects directly, without nextObject, which Spur doesn't support." <inline: #never> | segmentLimit segmentStart segVersion errorCode numLoadedObjects loadedObjectsArray | segmentLimit := self numSlotsOf: segmentWordArray. (self objectBytesForSlots: segmentLimit) < (self allocationUnit "version info" + self baseHeaderSize "one object header") ifTrue: [^PrimErrBadArgument halt]. "Verify format. If the format is wrong, word-swap (since ImageSegment data are 32-bit longs). If it is still wrong, undo the damage and fail." segVersion := self longAt: segmentWordArray + self baseHeaderSize. (coInterpreter readableFormat: (segVersion bitAnd: 16rFFFFFF "low 3 bytes")) ifFalse: [self reverseBytesIn32BitWordsIn: segmentWordArray. segVersion := self longAt: segmentWordArray + self baseHeaderSize. (coInterpreter readableFormat: (segVersion bitAnd: 16rFFFFFF "low 3 bytes")) ifFalse: [self reverseBytesIn32BitWordsIn: segmentWordArray. ^PrimErrBadArgument halt]]. segmentStart := segmentWordArray + self baseHeaderSize + self allocationUnit. segmentLimit := segmentLimit * self bytesPerOop + segmentWordArray + self baseHeaderSize. "Notionally reverse the Byte type objects if the data is from opposite endian machine. Test top byte. $d on the Mac or $s on the PC. Rest of word is equal. If Spur is ever ported to big-endian machines then the segment may have to be byte/word swapped, but so far it only runs on little-endian machines, so for now just fail if endianness is wrong." self flag: #endianness. (segVersion >> 24 bitAnd: 16rFF) ~= (self imageSegmentVersion >> 24 bitAnd: 16rFF) ifTrue: "Reverse the byte-type objects once" [true ifTrue: [^PrimErrBadArgument halt] ifFalse: [self byteSwapByteObjectsFrom: (self objectStartingAt: segmentStart) to: segmentLimit flipFloatsIf: false]]. "Avoid having to remember by arranging that there are no young outPointers if segment is in old space." (self isOldObject: segmentWordArray) ifTrue: [errorCode := self ensureNoNewObjectsIn: outPointerArray. errorCode ~= 0 ifTrue: [^errorCode]]. "scan through mapping oops and validating class references. Defer entering any class objects into the class table and/or pinning objects until a second pass." errorCode := self mapOopsAndValidateClassRefsFrom: segmentStart to: segmentLimit outPointers: outPointerArray. errorCode > 0 ifTrue: [^errorCode]. numLoadedObjects := errorCode negated. loadedObjectsArray := self allocateSlots: numLoadedObjects format: self arrayFormat classIndex: ClassArrayCompactIndex. loadedObjectsArray ifNil: [^PrimErrNoMemory halt]. "Scan for classes contained in the segment, entering them into the class table. Classes are at the front, after the root array and have the remembered bit set." errorCode := self enterClassesIntoClassTableFrom: segmentStart to: segmentLimit. errorCode ~= 0 ifTrue: [^errorCode]. "Make a final pass, assigning class indices and/or pinning pinned objects and collecting the loaded objects in loadedObjectsArray" self assignClassIndicesAndPinFrom: segmentStart to: segmentLimit outPointers: outPointerArray filling: loadedObjectsArray. "Evaporate the container, leaving the newly loaded objects in place." (self hasOverflowHeader: segmentWordArray) + ifTrue: "N.B. setting the overflow slots to 1 creates a slimbridge in eden, so we also need to delete the overflow slot count in the segment itself" + [(self oop: segmentWordArray isLessThan: oldSpaceStart) + ifTrue: + [self rawOverflowSlotsOf: segmentWordArray put: 0. + self rawNumSlotsOf: segmentWordArray put: 0] + ifFalse: + [self rawOverflowSlotsOf: segmentWordArray put: self allocationUnit / self bytesPerOop]] - ifTrue: [self rawOverflowSlotsOf: segmentWordArray put: self allocationUnit / self bytesPerOop] ifFalse: [self rawNumSlotsOf: segmentWordArray put: self allocationUnit / self bytesPerOop]. "Finally forward the segmentWordArray to the loadedObjectsArray" self forward: segmentWordArray to: loadedObjectsArray. self runLeakCheckerFor: GCCheckImageSegment. ^self objectStartingAt: segmentStart!

1 0

[OpenSmalltalk/opensmalltalk-vm] Update BitBltArmSimdSourceWord.s to latest ben avison version (#592)
by tim Rowledge 07 Sep '21

07 Sep '21

Half a dozen small bug fixes from ben Co-Authored-By: bavison <3324657+bavison(a)users.noreply.github.com> You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/592 -- Commit Summary -- * Update BitBltArmSimdSourceWord.s to latest ben avison version -- File Changes -- M platforms/Cross/plugins/BitBltPlugin/BitBltArmSimdSourceWord.s (19) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/592.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/592.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/592

2 2

VM Maker: VMMaker.oscog-eem.3059.mcz
by commits＠source.squeak.org 07 Sep '21

07 Sep '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3059.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3059 Author: eem Time: 6 September 2021, 3:42:38.06696 pm UUID: 354a3efc-f2c9-4e08-b6ba-e7a3ed35effd Ancestors: VMMaker.oscog-eem.3058 Fix a regression in simulation of external primitives introduced by VMMaker.oscog-eem.2994. When flushing the externalPrimitiveTable none of the simulation state (pluginList, mappedPluginEntries et al) need be flushed. Doing so blows away plugins with persistent state such as the FilePluginSimulator and SocketPluginSimulator (open files/sockets). Fix a speeling rorre. =============== Diff against VMMaker.oscog-eem.3058 =============== Item was changed: ----- Method: CogVMSimulator>>initializePluginEntries (in category 'plugin support') ----- initializePluginEntries mappedPluginEntries := OrderedCollection new. objectMemory hasSpurMemoryManagerAPI ifTrue: [primitiveAccessorDepthTable := Array new: primitiveTable size. pluginList := {}. self loadNewPlugin: ''] ifFalse: + [pluginList := {'' -> self }]! - [pluginList := {'' -> self }]. - cogit flushPluginEntriesFor: #tryLoadNewPlugin:pluginEntries:! Item was removed: - ----- Method: Cogit>>flushPluginEntriesFor: (in category 'simulation only') ----- - flushPluginEntriesFor: aSelector - (simulatedTrampolines keys select: - [:k| - (simulatedTrampolines at: k) isBlock - and: [(simulatedTrampolines at: k) home selector == aSelector]]) do: - [:k| simulatedTrampolines removeKey: k]! Item was removed: - ----- Method: InterpreterProxy>>ioLoadFunction:From:MetadataIntoInto: (in category 'FFI support') ----- - ioLoadFunction: functionName From: moduleName MetadataIntoInto: metadataPtr - <returnTypeC: #'void *'> - <var: #functionName type: #'char *'> - <var: #moduleName type: #'char *'> - <var: #metadataPtr type: #'sqInt *'> - "Dummy - provided by support code" - ^0! Item was changed: ----- Method: StackInterpreter>>ensureCallerContext: (in category 'frame access') ----- ensureCallerContext: theFP + "Answer the caller context for a frame. If the frame has a caller - "Answerr the caller context for a frame. If the frame has a caller frame that doesn't have a context, then marry the caller frame." | callerFP | <inline: true> <var: #theFP type: #'char *'> <var: #callerFP type: #'char *'> callerFP := self frameCallerFP: theFP. callerFP = 0 ifTrue: "base frame, context in saved ip slot (or base of stack in Cog)" [^self frameCallerContext: theFP]. ^self ensureFrameIsMarried: callerFP SP: (self frameCallerStackPointer: theFP)! Item was changed: ----- Method: StackInterpreter>>flushExternalPrimitiveTable (in category 'plugin primitive support') ----- flushExternalPrimitiveTable "Flush the external primitive table" + 0 to: MaxExternalPrimitiveTableSize-1 do:[:i| + externalPrimitiveTable at: i put: 0]. + externalPrimitiveTableFirstFreeIndex := 0! - 0 to: MaxExternalPrimitiveTableSize - 1 do: - [:i| externalPrimitiveTable at: i put: 0]. - externalPrimitiveTableFirstFreeIndex := 0. - self cCode: '' inSmalltalk: [self initializePluginEntries]!

1 0

[OpenSmalltalk/opensmalltalk-vm] f5f0e7: ARMv8 BitBLT enhancements from Ben Avison, plus in...
by tim Rowledge 07 Sep '21

07 Sep '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: f5f0e7d98effd7217dded6ed9397b2cac1f787ad https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f5f0e7d98effd7217d… Author: Tim Rowledge <tim(a)rowledge.org> Date: 2021-09-06 (Mon, 06 Sep 2021) Changed paths: M building/linux64ARMv8/squeak.cog.spur/build/mvm A platforms/Cross/plugins/BitBltPlugin/BitBltArm64.c A platforms/Cross/plugins/BitBltPlugin/BitBltArm64.h M platforms/Cross/plugins/BitBltPlugin/BitBltArmSimdAsm.hdr M platforms/Cross/plugins/BitBltPlugin/BitBltDispatch.c M platforms/Cross/plugins/BitBltPlugin/BitBltDispatch.h M platforms/Cross/plugins/BitBltPlugin/BitBltGeneric.c M platforms/Cross/plugins/BitBltPlugin/BitBltInternal.h M platforms/unix/config/configure M platforms/unix/plugins/BitBltPlugin/acinclude.m4 Log Message: ----------- ARMv8 BitBLT enhancements from Ben Avison, plus include order fixes Add in Ben's BitBLT improvements for AMRv8, plus some more generic BLT improvements for ARMv6 , re-worked a little to handle the include-order changes Co-Authored-By: bavison <3324657+bavison(a)users.noreply.github.com>

2 1

[OpenSmalltalk/opensmalltalk-vm] 70cd4b: ARMv8 BitBLT enhancements from Ben Avison, plus in...
by tim Rowledge 06 Sep '21

06 Sep '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 70cd4bd06d8eb27c66946abf13e72586399eb83a https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/70cd4bd06d8eb27c66… Author: Tim Rowledge <tim(a)rowledge.org> Date: 2021-09-06 (Mon, 06 Sep 2021) Changed paths: A build.linux64ARMv8/squeak.cog.spur/build/mvm A platforms/Cross/plugins/BitBltPlugin/BitBltArm64.c A platforms/Cross/plugins/BitBltPlugin/BitBltArm64.h M platforms/Cross/plugins/BitBltPlugin/BitBltArmSimdAsm.hdr M platforms/Cross/plugins/BitBltPlugin/BitBltArmSimdSourceWord.s M platforms/Cross/plugins/BitBltPlugin/BitBltDispatch.c M platforms/Cross/plugins/BitBltPlugin/BitBltDispatch.h M platforms/Cross/plugins/BitBltPlugin/BitBltGeneric.c M platforms/Cross/plugins/BitBltPlugin/BitBltInternal.h M platforms/unix/config/configure M platforms/unix/plugins/BitBltPlugin/acinclude.m4 Log Message: ----------- ARMv8 BitBLT enhancements from Ben Avison, plus include order fixes Add in Ben's BitBLT improvements for AMRv8, plus some more generic BLT improvements for ARMv6 , re-worked a little to handle the include-order changes Co-Authored-By: bavison <3324657+bavison(a)users.noreply.github.com>

2 1

[OpenSmalltalk/opensmalltalk-vm] f1108f: Revert "ARMv8 BitBLT enhancements from Ben Avison, ...
by tim Rowledge 06 Sep '21

06 Sep '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: f1108f586f49b5f4e78be066337891af0bfd83e8 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f1108f586f49b5f4e7… Author: Tim Rowledge <tim(a)rowledge.org> Date: 2021-09-06 (Mon, 06 Sep 2021) Changed paths: R build.linux64ARMv8/squeak.cog.spur/build/mvm R platforms/Cross/plugins/BitBltPlugin/BitBltArm64.c R platforms/Cross/plugins/BitBltPlugin/BitBltArm64.h M platforms/Cross/plugins/BitBltPlugin/BitBltArmSimdAsm.hdr M platforms/Cross/plugins/BitBltPlugin/BitBltArmSimdSourceWord.s M platforms/Cross/plugins/BitBltPlugin/BitBltDispatch.c M platforms/Cross/plugins/BitBltPlugin/BitBltDispatch.h M platforms/Cross/plugins/BitBltPlugin/BitBltGeneric.c M platforms/Cross/plugins/BitBltPlugin/BitBltInternal.h M platforms/unix/config/configure M platforms/unix/plugins/BitBltPlugin/acinclude.m4 Log Message: ----------- Revert "ARMv8 BitBLT enhancements from Ben Avison, plus include order fixes" This reverts commit 70cd4bd06d8eb27c66946abf13e72586399eb83a.

1 0

[OpenSmalltalk/opensmalltalk-vm] 015a11: CogVM source as per VMMaker.oscog-eem.3058
by Eliot Miranda 06 Sep '21

06 Sep '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 015a1114b5b9c59fe64d4306ce6a8e36a684429d https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/015a1114b5b9c59fe6… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-09-05 (Sun, 05 Sep 2021) Changed paths: M src/plugins/FFTPlugin/FFTPlugin.c M src/spur32.cog.lowcode/cogit.h M src/spur32.cog.lowcode/cogitARMv5.c M src/spur32.cog.lowcode/cogitIA32.c M src/spur32.cog.lowcode/cointerp.c M src/spur32.cog.lowcode/cointerp.h R src/spur32.cog.lowcode/examplePlugins.ext R src/spur32.cog.lowcode/examplePlugins.int M src/spur32.cog.lowcode/gcc3x-cointerp.c R src/spur32.cog.newspeak/examplePlugins.ext R src/spur32.cog.newspeak/examplePlugins.int M src/spur32.cog/cogit.h M src/spur32.cog/cogitARMv5.c M src/spur32.cog/cogitIA32.c M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/cointerpmt.c M src/spur32.cog/cointerpmt.h R src/spur32.cog/examplePlugins.ext R src/spur32.cog/examplePlugins.int M src/spur32.cog/gcc3x-cointerp.c M src/spur32.cog/gcc3x-cointerpmt.c M src/spur32.sista/cogit.h M src/spur32.sista/cogitARMv5.c M src/spur32.sista/cogitIA32.c M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h R src/spur32.sista/examplePlugins.ext R src/spur32.sista/examplePlugins.int M src/spur32.sista/gcc3x-cointerp.c R src/spur32.stack.lowcode/examplePlugins.ext R src/spur32.stack.lowcode/examplePlugins.int M src/spur32.stack.lowcode/gcc3x-interp.c M src/spur32.stack.lowcode/interp.c R src/spur32.stack.newspeak/examplePlugins.ext R src/spur32.stack.newspeak/examplePlugins.int R src/spur32.stack/examplePlugins.ext R src/spur32.stack/examplePlugins.int M src/spur32.stack/gcc3x-interp.c M src/spur32.stack/interp.c M src/spur32.stack/validImage.c M src/spur64.cog.lowcode/cogit.h M src/spur64.cog.lowcode/cogitARMv8.c M src/spur64.cog.lowcode/cogitX64SysV.c M src/spur64.cog.lowcode/cogitX64WIN64.c M src/spur64.cog.lowcode/cointerp.c M src/spur64.cog.lowcode/cointerp.h R src/spur64.cog.lowcode/examplePlugins.ext R src/spur64.cog.lowcode/examplePlugins.int M src/spur64.cog.lowcode/gcc3x-cointerp.c R src/spur64.cog.newspeak/examplePlugins.ext R src/spur64.cog.newspeak/examplePlugins.int M src/spur64.cog/cogit.h M src/spur64.cog/cogitARMv8.c M src/spur64.cog/cogitX64SysV.c M src/spur64.cog/cogitX64WIN64.c M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/cointerpmt.c M src/spur64.cog/cointerpmt.h R src/spur64.cog/examplePlugins.ext R src/spur64.cog/examplePlugins.int M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.sista/cogit.h M src/spur64.sista/cogitARMv8.c M src/spur64.sista/cogitX64SysV.c M src/spur64.sista/cogitX64WIN64.c M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h R src/spur64.sista/examplePlugins.ext R src/spur64.sista/examplePlugins.int M src/spur64.sista/gcc3x-cointerp.c R src/spur64.stack.lowcode/examplePlugins.ext R src/spur64.stack.lowcode/examplePlugins.int M src/spur64.stack.lowcode/gcc3x-interp.c M src/spur64.stack.lowcode/interp.c R src/spur64.stack.newspeak/examplePlugins.ext R src/spur64.stack.newspeak/examplePlugins.int R src/spur64.stack/examplePlugins.ext R src/spur64.stack/examplePlugins.int M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c M src/spur64.stack/validImage.c M src/v3.cog/cogit.h M src/v3.cog/cogitARMv5.c M src/v3.cog/cogitIA32.c M src/v3.cog/cointerp.c M src/v3.cog/cointerp.h R src/v3.cog/examplePlugins.ext R src/v3.cog/examplePlugins.int M src/v3.cog/gcc3x-cointerp.c R src/v3.stack/examplePlugins.ext R src/v3.stack/examplePlugins.int M src/v3.stack/gcc3x-interp.c M src/v3.stack/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3058 Leak Checking: replace all sends of cr and/or eek in the leak checking printing with a send of eekcr, implemented in StackInterpreter as a never inlined method, suitable for placing a breakpoint on. Slang: fix multiple NeverInline function attributes. Oops; VMMaker.oscog-eem.3051 regressed primitiveSetOrHasIdentityHash; remember to convert from SmallInteger to inetger and validate the hash is in range. FFTPlugin: mark primitives with FastCPrimitiveFlag & FastCPrimitiveAlignForFloatsFlag. Save a few cycles in marshalling. Nuke the duplicated examplePlugins.ext/int, leaving src/examplePlugins.ext/int

1 0

VM Maker: VMMaker.oscog-eem.3058.mcz
by commits＠source.squeak.org 06 Sep '21

06 Sep '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3058.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3058 Author: eem Time: 5 September 2021, 7:30:41.127457 pm UUID: 86a18528-b506-4c9a-a64d-041bcf5f8be4 Ancestors: VMMaker.oscog-eem.3057 Leak Checking: better idea: replace all sends of cr and/or eek in the leak checking printing with a send of eekcr, implemented in StackInterpreter as a never inlined method, suitable for placing a breakpoint on. A better solution would be replacing all these prints with printf style calls of e.g. leakCheckPrintf:. But I'm not sure how to express va_list methods through Slang. Slang: fix multiple NeverInline function attributes. =============== Diff against VMMaker.oscog-eem.3057 =============== Item was changed: ----- Method: Cogit>>checkIfValidOopRef:pc:cogMethod: (in category 'garbage collection') ----- checkIfValidOopRef: annotation pc: mcpc cogMethod: cogMethod "Check for a valid object reference, if any, at a map entry. Answer a code unique to each error for debugging." <var: #mcpc type: #'char *'> <var: #cogMethod type: #'CogMethod *'> <var: #nsSendCache type: #'NSSendCache *'> annotation = IsObjectReference ifTrue: [| literal | literal := literalsManager fetchLiteralAtAnnotatedAddress: mcpc asUnsignedInteger using: backEnd. (objectRepresentation checkValidOopReference: literal) ifFalse: + [coInterpreter print: 'object ref leak in CM '; printHex: cogMethod asInteger; print: ' @ '; printHex: mcpc asInteger; eekcr. - [coInterpreter print: 'object ref leak in CM '; printHex: cogMethod asInteger; print: ' @ '; printHex: mcpc asInteger; cr. ^1]]. NewspeakVM ifTrue: [annotation = IsNSSendCall ifTrue: [| nsSendCache enclosingObject | nsSendCache := self nsSendCacheFromReturnAddress: mcpc asInteger. [(objectRepresentation checkValidOopReference: nsSendCache selector) ifFalse: + [coInterpreter print: 'selector leak in CM '; printHex: cogMethod asInteger; print: ' @ '; printHex: mcpc asInteger; eekcr. - [coInterpreter print: 'selector leak in CM '; printHex: cogMethod asInteger; print: ' @ '; printHex: mcpc asInteger; cr. ^1]]. (enclosingObject := nsSendCache enclosingObject) ~= 0 ifTrue: [[(objectRepresentation checkValidOopReference: enclosingObject) ifFalse: + [coInterpreter print: 'enclosing object leak in CM '; printHex: cogMethod asInteger; print: ' @ '; printHex: mcpc asInteger; eekcr. - [coInterpreter print: 'enclosing object leak in CM '; printHex: cogMethod asInteger; print: ' @ '; printHex: mcpc asInteger; cr. ^1]]]]]. (self isPureSendAnnotation: annotation) ifTrue: [| entryPoint selectorOrCacheTag offset | entryPoint := backEnd callTargetFromReturnAddress: mcpc asInteger. entryPoint <= methodZoneBase ifTrue: [offset := entryPoint] ifFalse: [self offsetAndSendTableFor: entryPoint annotation: annotation into: [:off :table| offset := off]]. selectorOrCacheTag := backEnd inlineCacheTagAt: mcpc asInteger. (entryPoint > methodZoneBase and: [offset ~= cmNoCheckEntryOffset and: [(self cCoerceSimple: entryPoint - offset to: #'CogMethod *') cmType ~= CMOpenPIC]]) ifTrue: "linked non-super send, cacheTag is a cacheTag" [(objectRepresentation validInlineCacheTag: selectorOrCacheTag) ifFalse: + [coInterpreter print: 'cache tag leak in CM '; printHex: cogMethod asInteger; print: ' @ '; printHex: mcpc asInteger; eekcr. - [coInterpreter print: 'cache tag leak in CM '; printHex: cogMethod asInteger; print: ' @ '; printHex: mcpc asInteger; cr. ^1]] ifFalse: "unlinked send or super send; cacheTag is a selector unless 64-bit, in which case it is an index." [(self inlineCacheTagsAreIndexes or: [objectRepresentation checkValidOopReference: selectorOrCacheTag]) ifFalse: + [coInterpreter print: 'selector leak in CM '; printHex: cogMethod asInteger; print: ' @ '; printHex: mcpc asInteger; eekcr. - [coInterpreter print: 'selector leak in CM '; printHex: cogMethod asInteger; print: ' @ '; printHex: mcpc asInteger; cr. ^1]]]. ^0 "keep scanning"! Item was changed: ----- Method: Cogit>>checkIntegrityOfObjectReferencesInCode: (in category 'debugging') ----- checkIntegrityOfObjectReferencesInCode: gcModes <api> "Answer if all references to objects in machine-code are valid." | cogMethod ok count | <var: #cogMethod type: #'CogMethod *'> cogMethod := self cCoerceSimple: methodZoneBase to: #'CogMethod *'. ok := true. [cogMethod < methodZone limitZony] whileTrue: [cogMethod cmType ~= CMFree ifTrue: [cogMethod cmRefersToYoung ifTrue: [(count := methodZone occurrencesInYoungReferrers: cogMethod) ~= 1 ifTrue: [coInterpreter print: 'young referrer CM '; printHex: cogMethod asInteger. count = 0 + ifTrue: [coInterpreter print: ' is not in youngReferrers'; eekcr] + ifFalse: [coInterpreter print: ' is in youngReferrers '; printNum: count; print: ' times!!'; eekcr]. - ifTrue: [coInterpreter print: ' is not in youngReferrers'; cr] - ifFalse: [coInterpreter print: ' is in youngReferrers '; printNum: count; print: ' times!!'; cr]. ok := false]]. (objectRepresentation checkValidOopReference: cogMethod selector) ifFalse: + [coInterpreter print: 'object leak in CM '; printHex: cogMethod asInteger; print: ' selector'; eekcr. - [coInterpreter print: 'object leak in CM '; printHex: cogMethod asInteger; print: ' selector'; cr. ok := false]. cogMethod cmType = CMMethod ifTrue: [self assert: cogMethod objectHeader = objectMemory nullHeaderForMachineCodeMethod. (objectRepresentation checkValidObjectReference: cogMethod methodObject) ifFalse: + [coInterpreter print: 'object leak in CM '; printHex: cogMethod asInteger; print: ' methodObject'; eekcr. - [coInterpreter print: 'object leak in CM '; printHex: cogMethod asInteger; print: ' methodObject'; cr. ok := false]. (objectMemory isOopCompiledMethod: cogMethod methodObject) ifFalse: + [coInterpreter print: 'non-method in CM '; printHex: cogMethod asInteger; print: ' methodObject'; eekcr. - [coInterpreter print: 'non-method in CM '; printHex: cogMethod asInteger; print: ' methodObject'; cr. ok := false]. (self mapFor: cogMethod performUntil: #checkIfValidOopRef:pc:cogMethod: arg: cogMethod) ~= 0 ifTrue: [ok := false]. (objectRepresentation hasSpurMemoryManagerAPI or: [gcModes anyMask: GCModeNewSpace]) ifTrue: [(((objectMemory isYoungObject: cogMethod methodObject) or: [objectMemory isYoung: cogMethod selector]) and: [cogMethod cmRefersToYoung not]) ifTrue: + [coInterpreter print: 'CM '; printHex: cogMethod asInteger; print: ' refers to young but not marked as such'; eekcr. - [coInterpreter print: 'CM '; printHex: cogMethod asInteger; print: ' refers to young but not marked as such'; cr. ok := false]]] ifFalse: [cogMethod cmType = CMClosedPIC ifTrue: [(self checkValidObjectReferencesInClosedPIC: cogMethod) ifFalse: [ok := false]] ifFalse: [cogMethod cmType = CMOpenPIC ifTrue: [(self mapFor: cogMethod performUntil: #checkIfValidOopRef:pc:cogMethod: arg: cogMethod) ~= 0 ifTrue: [ok := false]]]]]. cogMethod := methodZone methodAfter: cogMethod]. ^ok! Item was removed: - ----- Method: NewCoObjectMemorySimulator>>eek (in category 'memory access') ----- - eek - self halt! Item was changed: ObjectMemory subclass: #NewObjectMemory + instanceVariableNames: 'coInterpreter freeStart reserveStart scavengeThreshold needGCFlag edenBytes checkForLeaks statGCEndUsecs heapMap' - instanceVariableNames: 'coInterpreter freeStart reserveStart scavengeThreshold needGCFlag edenBytes checkForLeaks statGCEndUsecs heapMap leakDetected' classVariableNames: '' poolDictionaries: '' category: 'VMMaker-Interpreter'! !NewObjectMemory commentStamp: '<historical>' prior: 0! I am a refinement of ObjectMemory that eliminates the need for pushRemappableOop:/popRemappableOop in the interpreter proper. Certain primitives that do major allocation may still want to provoke a garbage collection and hence may still need to remap private pointers. But the interpreter subclass of this class does not have to provided it reserves sufficient space for it to make progress to the next scavenge point (send or backward branch).! Item was changed: ----- Method: NewObjectMemory class>>mustBeGlobal: (in category 'translation') ----- mustBeGlobal: var "Answer if a variable must be global and exported. Used for inst vars that are accessed from VM support code." ^(super mustBeGlobal: var) + or: ['checkForLeaks' = var]! - or: [#('checkForLeaks' 'leakDetected') includes: var]! Item was changed: ----- Method: NewObjectMemory>>checkHeapIntegrity (in category 'memory access') ----- checkHeapIntegrity "Perform an integrity/leak check using the heapMap. Assume clearLeakMapAndMapAccessibleObjects has set a bit at each object's header. Scan all objects in the heap checking that every pointer points to a header. Scan the rootTable, remapBuffer and extraRootTable checking that every entry is a pointer to a header. Check that the number of roots is correct and that all rootTable entries have their rootBit set. Answer if all checks pass." | ok obj sz hdr fmt fi fieldOop numRootsInHeap | <inline: false> ok := true. numRootsInHeap := 0. obj := self firstObject. [self oop: obj isLessThan: self startOfFreeSpace] whileTrue: [(self isFreeObject: obj) ifTrue: [sz := self sizeOfFree: obj] ifFalse: [hdr := self baseHeader: obj. (self isYoungRootHeader: hdr) ifTrue: [numRootsInHeap := numRootsInHeap + 1]. (self compactClassIndexOfHeader: hdr) = 0 ifTrue: [fieldOop := (self classHeader: obj) bitAnd: AllButTypeMask. ((self isIntegerObject: fieldOop) or: [(heapMap heapMapAtWord: (self pointerForOop: fieldOop)) = 0]) ifTrue: + [self print: 'object leak in '; printHex: obj; print: ' class = '; printHex: fieldOop; eekcr. - [self print: 'object leak in '; printHex: obj; print: ' class = '; printHex: fieldOop; cr. - self eek. ok := false]]. fmt := self formatOfHeader: hdr. (fmt <= 4 "pointers" or: [fmt >= 12 "compiled method"]) ifTrue: [fmt >= 12 ifTrue: [fi := (self literalCountOf: obj) + LiteralStart] ifFalse: [(fmt = 3 and: [self isContextHeader: hdr]) ifTrue: [fi := CtxtTempFrameStart + (coInterpreter fetchStackPointerOf: obj)] ifFalse: [fi := self lengthOf: obj]]. [(fi := fi - 1) >= 0] whileTrue: [fieldOop := self fetchPointer: fi ofObject: obj. (self isNonIntegerObject: fieldOop) ifTrue: [(fieldOop bitAnd: self wordSize - 1) ~= 0 ifTrue: + [self print: 'misaligned oop in '; printHex: obj; print: ' @ '; printNum: fi; print: ' = '; printHex: fieldOop; eekcr. - [self print: 'misaligned oop in '; printHex: obj; print: ' @ '; printNum: fi; print: ' = '; printHex: fieldOop; cr. - self eek. ok := false] ifFalse: [(heapMap heapMapAtWord: (self pointerForOop: fieldOop)) = 0 ifTrue: + [self print: 'object leak in '; printHex: obj; print: ' @ '; printNum: fi; print: ' = '; printHex: fieldOop; eekcr. - [self print: 'object leak in '; printHex: obj; print: ' @ '; printNum: fi; print: ' = '; printHex: fieldOop; cr. - self eek. ok := false]]]]]. sz := self sizeBitsOf: obj]. obj := self oopFromChunk: obj + sz]. numRootsInHeap ~= rootTableCount ifTrue: [self print: 'root count mismatch. #heap roots '; printNum: numRootsInHeap; print: '; #roots '; printNum: rootTableCount; cr. "But the system copes with overflow..." ok := rootTableOverflowed and: [needGCFlag]]. 1 to: rootTableCount do: [:ri| obj := rootTable at: ri. (obj bitAnd: self wordSize - 1) ~= 0 ifTrue: + [self print: 'misaligned oop in rootTable @ '; printNum: ri; print: ' = '; printHex: obj; eekcr. - [self print: 'misaligned oop in rootTable @ '; printNum: ri; print: ' = '; printHex: obj; cr. - self eek. ok := false] ifFalse: [(heapMap heapMapAtWord: (self pointerForOop: obj)) = 0 ifTrue: + [self print: 'object leak in rootTable @ '; printNum: ri; print: ' = '; printHex: obj; eekcr. - [self print: 'object leak in rootTable @ '; printNum: ri; print: ' = '; printHex: obj; cr. - self eek. ok := false] ifFalse: [hdr := self baseHeader: obj. (self isYoungRootHeader: hdr) ifFalse: + [self print: 'non-root in rootTable @ '; printNum: ri; print: ' = '; printHex: obj; eekcr. - [self print: 'non-root in rootTable @ '; printNum: ri; print: ' = '; printHex: obj; cr. - self eek. ok := false]]]]. 1 to: remapBufferCount do: [:ri| obj := remapBuffer at: ri. (obj bitAnd: self wordSize - 1) ~= 0 ifTrue: + [self print: 'misaligned remapRoot @ '; printNum: ri; print: ' = '; printHex: obj; eekcr. - [self print: 'misaligned remapRoot @ '; printNum: ri; print: ' = '; printHex: obj; cr. - self eek. ok := false] ifFalse: [(heapMap heapMapAtWord: (self pointerForOop: obj)) = 0 ifTrue: + [self print: 'object leak in remapRoots @ '; printNum: ri; print: ' = '; printHex: obj; eekcr. - [self print: 'object leak in remapRoots @ '; printNum: ri; print: ' = '; printHex: obj; cr. - self eek. ok := false]]]. 1 to: extraRootCount do: [:ri| obj := (extraRoots at: ri) at: 0. (obj bitAnd: self wordSize - 1) ~= 0 ifTrue: + [self print: 'misaligned extraRoot @ '; printNum: ri; print: ' => '; printHex: obj; eekcr. - [self print: 'misaligned extraRoot @ '; printNum: ri; print: ' => '; printHex: obj; cr. - self eek. ok := false] ifFalse: [(heapMap heapMapAtWord: (self pointerForOop: obj)) = 0 ifTrue: + [self print: 'object leak in extraRoots @ '; printNum: ri; print: ' => '; printHex: obj; eekcr. - [self print: 'object leak in extraRoots @ '; printNum: ri; print: ' => '; printHex: obj; cr. - self eek. ok := false]]]. ^ok! Item was removed: - ----- Method: NewObjectMemory>>eek (in category 'memory access') ----- - eek - <inline: #never> - leakDetected := true! Item was changed: ----- Method: NewObjectMemory>>initialize (in category 'initialization') ----- initialize "Initialize NewObjectMemory when simulating the VM inside Smalltalk." super initialize. checkForLeaks := 0. + needGCFlag := false. - needGCFlag := leakDetected := false. heapMap := CogCheck32BitHeapMap new! Item was removed: - ----- Method: NewObjectMemorySimulator>>eek (in category 'memory access') ----- - eek - self halt! Item was changed: ----- Method: ObjectMemory>>checkOopIntegrity:named:index: (in category 'debug support') ----- checkOopIntegrity: obj named: name index: i <inline: false> <var: #name type: #'char *'> (self heapMapAtWord: (self pointerForOop: obj)) ~= 0 ifTrue: [^true]. + self print: name; print: ' leak @ '; printNum: i; print: ' = '; printHex: obj; eekcr. - self print: name; print: ' leak @ '; printNum: i; print: ' = '; printHex: obj; cr. ^false! Item was added: + ----- Method: Spur32BitMMLECoSimulator>>checkHeapIntegrity:classIndicesShouldBeValid: (in category 'debug support') ----- + checkHeapIntegrity: excludeUnmarkedObjs classIndicesShouldBeValid: classIndicesShouldBeValid + "Almost all of the time spent in SpurMemoryManager>>checkHeapIntegrity:classIndicesShouldBeValid: used to go into the asserts in fetchPointer:ofObject: in the simulator class overrides. + Since we know here the indices used are valid we temporarily remove them to claw back that performance." + ^self withSimulatorFetchPointerMovedAsideDo: + [super checkHeapIntegrity: excludeUnmarkedObjs classIndicesShouldBeValid: classIndicesShouldBeValid]! Item was removed: - ----- Method: Spur32BitMMLECoSimulator>>eek (in category 'debug support') ----- - eek - self halt! Item was changed: ----- Method: Spur32BitMMLESimulator>>checkHeapIntegrity:classIndicesShouldBeValid: (in category 'debug support') ----- checkHeapIntegrity: excludeUnmarkedObjs classIndicesShouldBeValid: classIndicesShouldBeValid + "Almost all of the time spent in SpurMemoryManager>>checkHeapIntegrity:classIndicesShouldBeValid: used to go into the asserts in fetchPointer:ofObject: in the simulator class overrides. - "Almost all of the time spent in SourMemoryManager>>checkHeapIntegrity:classIndicesShouldBeValid: used to go into the asserts in fetchPointer:ofObject: in the simulator class overrides. Since we know here the indices used are valid we temporarily remove them to claw back that performance." ^self withSimulatorFetchPointerMovedAsideDo: [super checkHeapIntegrity: excludeUnmarkedObjs classIndicesShouldBeValid: classIndicesShouldBeValid]! Item was removed: - ----- Method: Spur32BitMMLESimulator>>eek (in category 'debug support') ----- - eek - self halt! Item was changed: ----- Method: Spur64BitMMLECoSimulator>>checkHeapIntegrity:classIndicesShouldBeValid: (in category 'debug support') ----- checkHeapIntegrity: excludeUnmarkedObjs classIndicesShouldBeValid: classIndicesShouldBeValid + "Almost all of the time spent in SpurMemoryManager>>checkHeapIntegrity:classIndicesShouldBeValid: used to go into the asserts in fetchPointer:ofObject: in the simulator class overrides. - "Almost all of the time spent in SourMemoryManager>>checkHeapIntegrity:classIndicesShouldBeValid: used to go into the asserts in fetchPointer:ofObject: in the simulator class overrides. Since we know here the indices used are valid we temporarily remove them to claw back that performance." ^self withSimulatorFetchPointerMovedAsideDo: [super checkHeapIntegrity: excludeUnmarkedObjs classIndicesShouldBeValid: classIndicesShouldBeValid]! Item was removed: - ----- Method: Spur64BitMMLECoSimulator>>eek (in category 'debug support') ----- - eek - self halt! Item was changed: ----- Method: Spur64BitMMLESimulator>>checkHeapIntegrity:classIndicesShouldBeValid: (in category 'debug support') ----- checkHeapIntegrity: excludeUnmarkedObjs classIndicesShouldBeValid: classIndicesShouldBeValid + "Almost all of the time spent in SpurMemoryManager>>checkHeapIntegrity:classIndicesShouldBeValid: used to go into the asserts in fetchPointer:ofObject: in the simulator class overrides. - "Almost all of the time spent in SourMemoryManager>>checkHeapIntegrity:classIndicesShouldBeValid: used to go into the asserts in fetchPointer:ofObject: in the simulator class overrides. Since we know here the indices used are valid we temporarily remove them to claw back that performance." ^self withSimulatorFetchPointerMovedAsideDo: [super checkHeapIntegrity: excludeUnmarkedObjs classIndicesShouldBeValid: classIndicesShouldBeValid]! Item was removed: - ----- Method: Spur64BitMMLESimulator>>eek (in category 'debug support') ----- - eek - self halt! Item was changed: CogClass subclass: #SpurMemoryManager (excessive size, no diff calculated) Item was changed: ----- Method: SpurMemoryManager class>>mustBeGlobal: (in category 'translation') ----- mustBeGlobal: var "Answer if a variable must be global and exported. Used for inst vars that are accessed from VM support code." + ^#('checkForLeaks' 'maxOldSpaceSize') includes: var! - ^#('checkForLeaks' 'maxOldSpaceSize' 'leakDetected') includes: var! Item was changed: ----- Method: SpurMemoryManager>>checkHeapFreeSpaceIntegrity (in category 'debug support') ----- checkHeapFreeSpaceIntegrity "Perform an integrity/leak check using the heapMap. Assume clearLeakMapAndMapAccessibleFreeSpace has set a bit at each free chunk's header. Scan all objects in the heap checking that no pointer points to a free chunk and that all free chunks that refer to others refer to marked chunks. Answer if all checks pass." | ok total | <inline: false> <var: 'total' type: #usqInt> ok := true. total := 0. 0 to: self numFreeLists - 1 do: [:i| (freeLists at: i) ~= 0 ifTrue: [(heapMap heapMapAtWord: (self pointerForOop: (freeLists at: i))) = 0 ifTrue: + [coInterpreter print: 'leak in free list '; printNum: i; print: ' to non-free '; printHex: (freeLists at: i); eekcr. - [coInterpreter print: 'leak in free list '; printNum: i; print: ' to non-free '; printHex: (freeLists at: i); cr. - self eek. ok := false]]]. "Excuse the duplication but performance is at a premium and we avoid some tests by splitting the newSpace and oldSpace enumerations." self allNewSpaceEntitiesDo: [:obj| | fieldOop | (self isFreeObject: obj) ifTrue: + [coInterpreter print: 'young object '; printHex: obj; print: ' is free'; eekcr. - [coInterpreter print: 'young object '; printHex: obj; print: ' is free'; cr. - self eek. ok := false] ifFalse: [obj ~= freeSpaceCheckOopToIgnore ifTrue: [0 to: (self numPointerSlotsOf: obj) - 1 do: [:fi| fieldOop := self fetchPointer: fi ofObject: obj. (self isNonImmediate: fieldOop) ifTrue: [(heapMap heapMapAtWord: (self pointerForOop: fieldOop)) ~= 0 ifTrue: + [coInterpreter print: 'object leak in '; printHex: obj; print: ' @ '; printNum: fi; print: ' = '; printHex: fieldOop; print: ' is free'; eekcr. - [coInterpreter print: 'object leak in '; printHex: obj; print: ' @ '; printNum: fi; print: ' = '; printHex: fieldOop; print: ' is free'; cr. - self eek. ok := false]]]]]]. self allOldSpaceEntitiesDo: [:obj| | fieldOop | (self isFreeObject: obj) ifTrue: [(heapMap heapMapAtWord: (self pointerForOop: obj)) = 0 ifTrue: + [coInterpreter print: 'leak in free chunk '; printHex: obj; print: ' is unmapped?!! '; eekcr. - [coInterpreter print: 'leak in free chunk '; printHex: obj; print: ' is unmapped?!! '; cr. - self eek. ok := false]. fieldOop := self fetchPointer: self freeChunkNextIndex ofFreeChunk: obj. (fieldOop ~= 0 and: [(heapMap heapMapAtWord: (self pointerForOop: fieldOop)) = 0]) ifTrue: + [coInterpreter print: 'leak in free chunk '; printHex: obj; print: ' @ 0 = '; printHex: fieldOop; print: ' is unmapped'; eekcr. - [coInterpreter print: 'leak in free chunk '; printHex: obj; print: ' @ 0 = '; printHex: fieldOop; print: ' is unmapped'; cr. - self eek. ok := false]. (self isLilliputianSize: (self bytesInBody: obj)) ifFalse: [fieldOop := self fetchPointer: self freeChunkPrevIndex ofFreeChunk: obj. (fieldOop ~= 0 and: [(heapMap heapMapAtWord: (self pointerForOop: fieldOop)) = 0]) ifTrue: + [coInterpreter print: 'leak in free chunk '; printHex: obj; print: ' @ 0 = '; printHex: fieldOop; print: ' is unmapped'; eekcr. - [coInterpreter print: 'leak in free chunk '; printHex: obj; print: ' @ 0 = '; printHex: fieldOop; print: ' is unmapped'; cr. - self eek. ok := false]]. (self isLargeFreeObject: obj) ifTrue: [self freeChunkParentIndex to: self freeChunkLargerIndex do: [:fi| fieldOop := self fetchPointer: fi ofFreeChunk: obj. (fieldOop ~= 0 and: [(heapMap heapMapAtWord: (self pointerForOop: fieldOop)) = 0]) ifTrue: + [coInterpreter print: 'leak in free chunk '; printHex: obj; print: ' @ '; printNum: fi; print: ' = '; printHex: fieldOop; print: ' is unmapped'; eekcr. - [coInterpreter print: 'leak in free chunk '; printHex: obj; print: ' @ '; printNum: fi; print: ' = '; printHex: fieldOop; print: ' is unmapped'; cr. - self eek. ok := false]]]. total := total + (self bytesInBody: obj)] ifFalse: [obj ~= freeSpaceCheckOopToIgnore ifTrue: [0 to: (self numPointerSlotsOf: obj) - 1 do: [:fi| (self isForwarded: obj) ifTrue: [self assert: fi = 0. "I'm now trying to use forwarders in GC algorithms..." fieldOop := self fetchPointer: fi ofMaybeForwardedObject: obj] ifFalse: "We keep #fetchPointer:ofObject: API here for assertions" [fieldOop := self fetchPointer: fi ofObject: obj]. (self isNonImmediate: fieldOop) ifTrue: [(heapMap heapMapAtWord: (self pointerForOop: fieldOop)) ~= 0 ifTrue: + [coInterpreter print: 'object leak in '; printHex: obj; print: ' @ '; printNum: fi; print: ' = '; printHex: fieldOop; print: ' is free'; eekcr. - [coInterpreter print: 'object leak in '; printHex: obj; print: ' @ '; printNum: fi; print: ' = '; printHex: fieldOop; print: ' is free'; cr. - self eek. ok := false]]]]]]. total ~= totalFreeOldSpace ifTrue: + [coInterpreter print: 'incorrect totalFreeOldSpace; expected '; printNum: totalFreeOldSpace; print: ' found '; printNum: total; eekcr. - [coInterpreter print: 'incorrect totalFreeOldSpace; expected '; printNum: totalFreeOldSpace; print: ' found '; printNum: total; cr. - self eek. ok := false]. ^ok! Item was changed: ----- Method: SpurMemoryManager>>checkHeapIntegrity:classIndicesShouldBeValid: (in category 'debug support') ----- (excessive size, no diff calculated) Item was changed: ----- Method: SpurMemoryManager>>checkOopIntegrity:named: (in category 'debug support') ----- checkOopIntegrity: obj named: name <inline: false> <var: #name type: #'char *'> ((self oop: obj isLessThan: endOfMemory) and: [(heapMap heapMapAtWord: (self pointerForOop: obj)) ~= 0]) ifTrue: [^true]. + coInterpreter print: name; print: ' leak '; printHex: obj; eekcr. - coInterpreter print: name; print: ' leak '; printHex: obj; cr. ^false! Item was changed: ----- Method: SpurMemoryManager>>checkOopIntegrity:named:index: (in category 'debug support') ----- checkOopIntegrity: obj named: name index: i <inline: false> <var: #name type: #'char *'> ((self oop: obj isLessThan: endOfMemory) and: [(heapMap heapMapAtWord: (self pointerForOop: obj)) ~= 0]) ifTrue: [^true]. + coInterpreter print: name; print: ' leak @ '; printNum: i; print: ' = '; printHex: obj; eekcr. - coInterpreter print: name; print: ' leak @ '; printNum: i; print: ' = '; printHex: obj; cr. ^false! Item was removed: - ----- Method: SpurMemoryManager>>eek (in category 'debug support') ----- - eek - <inline: #never> - leakDetected := true! Item was changed: ----- Method: SpurMemoryManager>>initialize (in category 'initialization') ----- initialize "We can put all initializations that set something to 0 or to false here. In C all global variables are initialized to 0, and 0 is false." | moreThanEnough | remapBuffer := Array new: RemapBufferSize. remapBufferCount := extraRootCount := 0. "see below" freeListsMask := totalFreeOldSpace := lowSpaceThreshold := 0. checkForLeaks := 0. + needGCFlag := signalLowSpace := marking := false. - needGCFlag := signalLowSpace := marking := leakDetected := false. becomeEffectsFlags := gcPhaseInProgress := validatedIntegerClassFlags := 0. statScavenges := statIncrGCs := statFullGCs := 0. statMaxAllocSegmentTime := 0. statMarkUsecs := statSweepUsecs := statScavengeGCUsecs := statIncrGCUsecs := statFullGCUsecs := statCompactionUsecs := statGCEndUsecs := gcSweepEndUsecs := 0. statSGCDeltaUsecs := statIGCDeltaUsecs := statFGCDeltaUsecs := 0. statGrowMemory := statShrinkMemory := statRootTableCount := statAllocatedBytes := 0. statRootTableOverflows := statMarkCount := statCompactPassCount := statCoalesces := 0. "We can initialize things that are allocated but are lazily initialized." unscannedEphemerons := SpurContiguousObjStack new. "we can initialize things that are virtual in C." scavenger := SpurGenerationScavenger simulatorClass new manager: self; yourself. segmentManager := SpurSegmentManager simulatorClass new manager: self; yourself. compactor := self class compactorClass simulatorClass new manager: self; yourself. "We can also initialize here anything that is only for simulation." heapMap := CogCheck32BitHeapMap new. "N.B. We *don't* initialize extraRoots because we don't simulate it." "This is needed on 64-bits. We don't want a simulation creating a huge heap by default. By default use 512Mb on 64-bits, 256Mb on 32-bits." moreThanEnough := 1024 * 1024 * 1024 / (16 / self wordSize). "One million dollars, ha ha ha ha ha,... ha, ha ha ha ha, ..." maxOldSpaceSize := self class initializationOptions ifNotNil: [:initOpts| initOpts at: #maxOldSpaceSize ifAbsent: [moreThanEnough]] ifNil: [moreThanEnough]! Item was added: + ----- Method: StackInterpreter>>eekcr (in category 'debug printing') ----- + eekcr + "For marking the end of a leak check print message" + <api> + <inline: #never> + self printf: '\n'. + self cCode: '' inSmalltalk: [self halt]! Item was changed: ----- Method: TMethod>>addFunctionAttribute: (in category 'accessing') ----- addFunctionAttribute: aString + functionAttributes + ifNil: [functionAttributes := aString] + ifNotNil: + [(functionAttributes includesSubstring: aString) ifFalse: + [functionAttributes := functionAttributes, ' ', aString]]! - functionAttributes := functionAttributes - ifNil: [aString] - ifNotNil: [functionAttributes, ' ', aString]!

1 0

VM Maker: VMMaker.oscog-eem.3057.mcz
by commits＠source.squeak.org 06 Sep '21

06 Sep '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3057.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3057 Author: eem Time: 5 September 2021, 6:45:35.1444 pm UUID: 6b8c61a5-14be-45c1-affd-a59a0c6a668d Ancestors: VMMaker.oscog-eem.3056 Leak checking: eek is as useful (as a breakpoint) in production as in the simulator. =============== Diff against VMMaker.oscog-eem.3056 =============== Item was changed: ObjectMemory subclass: #NewObjectMemory + instanceVariableNames: 'coInterpreter freeStart reserveStart scavengeThreshold needGCFlag edenBytes checkForLeaks statGCEndUsecs heapMap leakDetected' - instanceVariableNames: 'coInterpreter freeStart reserveStart scavengeThreshold needGCFlag edenBytes checkForLeaks statGCEndUsecs heapMap' classVariableNames: '' poolDictionaries: '' category: 'VMMaker-Interpreter'! !NewObjectMemory commentStamp: '<historical>' prior: 0! I am a refinement of ObjectMemory that eliminates the need for pushRemappableOop:/popRemappableOop in the interpreter proper. Certain primitives that do major allocation may still want to provoke a garbage collection and hence may still need to remap private pointers. But the interpreter subclass of this class does not have to provided it reserves sufficient space for it to make progress to the next scavenge point (send or backward branch).! Item was changed: ----- Method: NewObjectMemory class>>mustBeGlobal: (in category 'translation') ----- mustBeGlobal: var "Answer if a variable must be global and exported. Used for inst vars that are accessed from VM support code." ^(super mustBeGlobal: var) + or: [#('checkForLeaks' 'leakDetected') includes: var]! - or: ['checkForLeaks' = var]! Item was changed: ----- Method: NewObjectMemory>>eek (in category 'memory access') ----- eek + <inline: #never> + leakDetected := true! - <inline: true>! Item was changed: ----- Method: NewObjectMemory>>initialize (in category 'initialization') ----- initialize "Initialize NewObjectMemory when simulating the VM inside Smalltalk." super initialize. checkForLeaks := 0. + needGCFlag := leakDetected := false. - needGCFlag := false. heapMap := CogCheck32BitHeapMap new! Item was changed: CogClass subclass: #SpurMemoryManager (excessive size, no diff calculated) Item was changed: ----- Method: SpurMemoryManager class>>mustBeGlobal: (in category 'translation') ----- mustBeGlobal: var "Answer if a variable must be global and exported. Used for inst vars that are accessed from VM support code." + ^#('checkForLeaks' 'maxOldSpaceSize' 'leakDetected') includes: var! - ^#('checkForLeaks' 'maxOldSpaceSize') includes: var! Item was changed: ----- Method: SpurMemoryManager>>eek (in category 'debug support') ----- eek + <inline: #never> + leakDetected := true! - <inline: true>! Item was changed: ----- Method: SpurMemoryManager>>initialize (in category 'initialization') ----- initialize "We can put all initializations that set something to 0 or to false here. In C all global variables are initialized to 0, and 0 is false." | moreThanEnough | remapBuffer := Array new: RemapBufferSize. remapBufferCount := extraRootCount := 0. "see below" freeListsMask := totalFreeOldSpace := lowSpaceThreshold := 0. checkForLeaks := 0. + needGCFlag := signalLowSpace := marking := leakDetected := false. - needGCFlag := signalLowSpace := marking := false. becomeEffectsFlags := gcPhaseInProgress := validatedIntegerClassFlags := 0. statScavenges := statIncrGCs := statFullGCs := 0. statMaxAllocSegmentTime := 0. statMarkUsecs := statSweepUsecs := statScavengeGCUsecs := statIncrGCUsecs := statFullGCUsecs := statCompactionUsecs := statGCEndUsecs := gcSweepEndUsecs := 0. statSGCDeltaUsecs := statIGCDeltaUsecs := statFGCDeltaUsecs := 0. statGrowMemory := statShrinkMemory := statRootTableCount := statAllocatedBytes := 0. statRootTableOverflows := statMarkCount := statCompactPassCount := statCoalesces := 0. "We can initialize things that are allocated but are lazily initialized." unscannedEphemerons := SpurContiguousObjStack new. "we can initialize things that are virtual in C." scavenger := SpurGenerationScavenger simulatorClass new manager: self; yourself. segmentManager := SpurSegmentManager simulatorClass new manager: self; yourself. compactor := self class compactorClass simulatorClass new manager: self; yourself. "We can also initialize here anything that is only for simulation." heapMap := CogCheck32BitHeapMap new. "N.B. We *don't* initialize extraRoots because we don't simulate it." "This is needed on 64-bits. We don't want a simulation creating a huge heap by default. By default use 512Mb on 64-bits, 256Mb on 32-bits." moreThanEnough := 1024 * 1024 * 1024 / (16 / self wordSize). "One million dollars, ha ha ha ha ha,... ha, ha ha ha ha, ..." maxOldSpaceSize := self class initializationOptions ifNotNil: [:initOpts| initOpts at: #maxOldSpaceSize ifAbsent: [moreThanEnough]] ifNil: [moreThanEnough]!

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev September 2021