Vm-dev July 2021

vm-dev@lists.squeakfoundation.org

22 participants
176 discussions

VM Maker: VMMaker.oscog-dtl.3004.mcz
by commits＠source.squeak.org 28 Jul '21

28 Jul '21

David T. Lewis uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-dtl.3004.mcz ==================== Summary ==================== Name: VMMaker.oscog-dtl.3004 Author: dtl Time: 27 July 2021, 7:04:41.67977 pm UUID: f6b6bb24-2fdf-4a09-bf4b-970eb4221ccd Ancestors: VMMaker.oscog-eem.3003 Update sizeOfIntegralCType: and related methods and tests to recognize #unsigned and #uint_32 declarations as 32 bit integer. Supports VectorEnginePlugin code generation. =============== Diff against VMMaker.oscog-eem.3003 =============== Item was changed: ----- Method: CCodeGenerator>>isIntegralCType: (in category 'inlining') ----- isIntegralCType: aCType "<String>" + ^(#('sqLong' 'usqLong' 'sqInt' 'usqInt' 'uint32_t' 'sqIntptr_t' 'usqIntptr_t' - ^(#('sqLong' 'usqLong' 'sqInt' 'usqInt' 'sqIntptr_t' 'usqIntptr_t' 'long' 'long long' 'int' 'short' 'short int' 'char' 'signed char' 'size_t' 'pid_t') includes: aCType asString) or: [(aCType beginsWith: 'unsigned') "Accept e.g. 'unsigned long' and also 'unsigned : 8'" and: [(aCType includesAnyOf: '[*]') not]]! Item was changed: ----- Method: CCodeGenerator>>sizeOfIntegralCType: (in category 'inlining') ----- sizeOfIntegralCType: anIntegralCType "<String>" "N.B. Only works for values for which isIntegralCType: answers true." | prunedCType index | prunedCType := (anIntegralCType beginsWith: 'unsigned ') ifTrue: [(anIntegralCType allButFirst: 9) withBlanksTrimmed] ifFalse: [(anIntegralCType beginsWith: 'signed ') ifTrue: [(anIntegralCType allButFirst: 7) withBlanksTrimmed] ifFalse: [anIntegralCType]]. ^prunedCType asString caseOf: { ['sqLong'] -> [8]. ['usqLong'] -> [8]. ['long long'] -> [8]. ['sqInt'] -> [BytesPerOop]. ['usqInt'] -> [BytesPerOop]. ['sqIntptr_t'] -> [BytesPerWord]. ['usqIntptr_t'] -> [BytesPerWord]. ['int'] -> [4]. + ['unsigned'] -> [4]. + ['uint32_t'] -> [4]. ['short'] -> [2]. ['short int'] -> [2]. ['char'] -> [1]. ['long'] -> [BytesPerWord]. "It's ambiguous on LLP64 and we'll later remove it" ['size_t'] -> [BytesPerWord]. ['pid_t'] -> [BytesPerWord]. } otherwise: [(anIntegralCType beginsWith: 'register ') ifTrue: [^self sizeOfIntegralCType: (anIntegralCType allButFirst: 9)]. (anIntegralCType beginsWith: 'static ') ifTrue: [^self sizeOfIntegralCType: (anIntegralCType allButFirst: 7)]. ((anIntegralCType beginsWith: 'unsigned') "e.g. 'unsigned : 8'" and: [(anIntegralCType includesAnyOf: '[*]') not and: [(index := anIntegralCType indexOf: $:) > 0]]) ifTrue: [^(Integer readFrom: (anIntegralCType copyFrom: index + 1 to: anIntegralCType size) withBlanksTrimmed readStream) + 7 // 8]. anIntegralCType first = $# ifTrue: [(anIntegralCType subStrings: '\') do: [:substring| substring first ~~ $# ifTrue: [([self sizeOfIntegralCType: substring withBlanksTrimmed] on: Error do: [:ex| nil]) ifNotNil: [:size| ^size]]]]. self error: 'unrecognized integral type']! Item was added: + ----- Method: SlangTypePromotionTest>>testUint32tAndInt (in category 'unsigned-priority') ----- + testUint32tAndInt + "representative of two types bigger than sizeOf(int) and with same size" + | firstType secondType resType | + firstType := #'uint32_t'. + secondType := #'int'. + resType := ccg promoteArithmeticTypes: firstType and: secondType. + + self assert: resType equals: #'uint32_t'. + + "check that the system is in the assumed state." + self assert: (ccg isIntegralCType: #'uint32_t'). + self assert: (ccg sizeOfIntegralCType: #'uint32_t') equals: 4. + self assert: (ccg isIntegralCType: #int). + self assert: (ccg sizeOfIntegralCType: #int) equals: 4.! Item was added: + ----- Method: SlangTypePromotionTest>>testUnsignedAndInt (in category 'unsigned-priority') ----- + testUnsignedAndInt + "representative of two types bigger than sizeOf(int) and with same size" + | firstType secondType resType | + firstType := #'unsigned'. + secondType := #'int'. + resType := ccg promoteArithmeticTypes: firstType and: secondType. + + self assert: resType equals: #'unsigned'. + + "check that the system is in the assumed state." + self assert: (ccg isIntegralCType: #'unsigned'). + self assert: (ccg sizeOfIntegralCType: #'unsigned') equals: 4. + self assert: (ccg isIntegralCType: #int). + self assert: (ccg sizeOfIntegralCType: #int) equals: 4.! Item was changed: ----- Method: VMPluginCodeGenerator>>sizeOfIntegralCType: (in category 'inlining') ----- sizeOfIntegralCType: anIntegralCType "<String>" "Hack; because the plugin sources are compiled either as 32 or 64 bit size those types which are either 32 or 64 bits in size as 48 bits. This happens to produce sane results for integer promotion." "N.B. Only works for values for which isIntegralCType: answers true." | prunedCType index | (anIntegralCType beginsWith: 'register ') ifTrue: [^self sizeOfIntegralCType: (anIntegralCType allButFirst: 9)]. prunedCType := (anIntegralCType beginsWith: 'unsigned ') ifTrue: [(anIntegralCType allButFirst: 9) withBlanksTrimmed] ifFalse: [(anIntegralCType beginsWith: 'signed ') ifTrue: [(anIntegralCType allButFirst: 7) withBlanksTrimmed] ifFalse: [anIntegralCType]]. ^prunedCType asString caseOf: { ['sqLong'] -> [8]. ['usqLong'] -> [8]. ['long long'] -> [8]. ['sqInt'] -> [6]. ['usqInt'] -> [6]. ['sqIntptr_t'] -> [6]. ['usqIntptr_t'] -> [6]. ['int'] -> [4]. + ['uint32_t'] -> [4]. + ['unsigned'] -> [4]. ['short'] -> [2]. ['short int'] -> [2]. ['char'] -> [1]. ['long'] -> [BytesPerWord]. "It's ambiguous on LLP64 and we'll later remove it" ['size_t'] -> [6]. ['pid_t'] -> [6]. } otherwise: [((anIntegralCType beginsWith: 'unsigned') "e.g. 'unsigned : 8'" and: [(anIntegralCType includesAnyOf: '[*]') not and: [(index := anIntegralCType indexOf: $:) > 0]]) ifTrue: [(Integer readFrom: (anIntegralCType copyFrom: index + 1 to: anIntegralCType size) withBlanksTrimmed readStream) + 7 // 8] ifFalse: [self error: 'unrecognized integral type']]!

3 4

VM Maker: VMMakerUI-eem.41.mcz
by commits＠source.squeak.org 28 Jul '21

28 Jul '21

Eliot Miranda uploaded a new version of VMMakerUI to project VM Maker: http://source.squeak.org/VMMaker/VMMakerUI-eem.41.mcz ==================== Summary ==================== Name: VMMakerUI-eem.41 Author: eem Time: 28 July 2021, 11:57:58.09149 am UUID: a03c912c-9b55-4c45-93f2-2159f52327fc Ancestors: VMMakerUI-eem.40 speeling rorre =============== Diff against VMMakerUI-eem.40 =============== Item was changed: ----- Method: TheWorldMainDockingBar>>updateVMMaker (in category '*VMMakerUI-updater') ----- updateVMMaker <updater: 'Update VMMaker'> | updater history message | updater := MCMcmUpdater updateMapNamed: 'update.oscog' repository: 'http://source.squeak.org/VMMaker'. updater lastUpdateMap ifEmpty: [ "If this is the first time that you use the updater, start at 5.mcm to avoid loading old code." updater lastUpdateMap at: updater repository put: 5]. history := updater dependentPackages collect: [:package | package name -> (package workingCopy ancestors ifNotEmpty: [:ancestors| ancestors first])] as: OrderedDictionary. updater doUpdate: false. "Set update history to the packages that actually changed." updater dependentPackages do: [:package | | oldVersionInfo newVersionInfo | oldVersionInfo := history at: package name ifAbsent: []. newVersionInfo := package workingCopy ancestors first. "N.B. the first version in a package's history will have empty ancestors. oldVersionInfo basicSize = 0 is true for these as well as nil." (oldVersionInfo basicSize = 0 ifTrue: [0] ifFalse: [oldVersionInfo versionNumber]) < newVersionInfo versionNumber ifTrue: [history at: package name put: {oldVersionInfo. newVersionInfo}] ifFalse: [history removeKey: package name]]. "Prepare message, including the update history and OSVM ci badges." message := String streamContents: [:s | + s nextPutAll: 'VMMaker update succesful. '. - s nextPutAll: 'VMMaker update succesfully. '. history ifEmpty: [s nextPutAll: 'All packages were already up-to-date.'] ifNotEmpty: [s nextPutAll: 'Updated packages:']. history keysAndValuesDo: [:packageName :updateInfo | s nextPutAll: ' - '. s nextPutAll: packageName; space. updateInfo isArray ifFalse: [s nextPutAll: '*removed*' translated] ifTrue: [ updateInfo first ifNil: [s nextPutAll: '*added*' translated] ifNotNil: [s print: updateInfo first versionNumber]. s nextPutAll: ' -> '. s print: updateInfo second versionNumber. s nextPutAll: '']]. s nextPutAll: (' Url: <a href="{1}">{1}</a>' format: {updater repository}). s nextPutAll: ' Map: '; print: updater updateMapName. s nextPutAll: (' TravisCI status: <a href="{1}"><img src="{2}" /> {3}</a>' format: { self osvm_TravisCI_statusPageUrl. self osvm_TravisCI_statusBadgeUrl. self osvm_TravisCI_statusTimestamp}). s nextPutAll: (' AppVeyor status: <a href="{1}"><img src="{2}" /> {3}</a>' format: { self osvm_AppVeyor_statusPageUrl. self osvm_AppVeyor_statusBadgeUrl. self osvm_AppVeyor_statusTimestamp}). s nextPutAll: (' NOTE THAT updated platform sources might be available, too: -> <a href="{1}">{1}</a>' format: {'https://github.com/OpenSmalltalk/opensmalltalk-vm'}). ]. self inform: message asTextFromHtml.!

1 0

VM Maker: VMMakerUI-eem.40.mcz
by commits＠source.squeak.org 28 Jul '21

28 Jul '21

Eliot Miranda uploaded a new version of VMMakerUI to project VM Maker: http://source.squeak.org/VMMaker/VMMakerUI-eem.40.mcz ==================== Summary ==================== Name: VMMakerUI-eem.40 Author: eem Time: 28 July 2021, 11:36:38.327535 am UUID: fab76b52-c52f-424a-89ac-7ca19df238d1 Ancestors: VMMakerUI-mt.39 Robustness for the fabulous updateVMMaker. The first version of a package will have empty ancestors. =============== Diff against VMMakerUI-mt.39 =============== Item was changed: ----- Method: TheWorldMainDockingBar>>updateVMMaker (in category '*VMMakerUI-updater') ----- updateVMMaker <updater: 'Update VMMaker'> | updater history message | updater := MCMcmUpdater updateMapNamed: 'update.oscog' repository: 'http://source.squeak.org/VMMaker'. updater lastUpdateMap ifEmpty: [ "If this is the first time that you use the updater, start at 5.mcm to avoid loading old code." updater lastUpdateMap at: updater repository put: 5]. history := updater dependentPackages + collect: [:package | package name -> (package workingCopy ancestors ifNotEmpty: [:ancestors| ancestors first])] - collect: [:package | package name -> package workingCopy ancestors first] as: OrderedDictionary. updater doUpdate: false. "Set update history to the packages that actually changed." updater dependentPackages do: [:package | | oldVersionInfo newVersionInfo | oldVersionInfo := history at: package name ifAbsent: []. newVersionInfo := package workingCopy ancestors first. + "N.B. the first version in a package's history will have empty ancestors. + oldVersionInfo basicSize = 0 is true for these as well as nil." + (oldVersionInfo basicSize = 0 ifTrue: [0] ifFalse: [oldVersionInfo versionNumber]) < newVersionInfo versionNumber - (oldVersionInfo ifNil: [0] ifNotNil: [:v | v versionNumber]) < newVersionInfo versionNumber ifTrue: [history at: package name put: {oldVersionInfo. newVersionInfo}] ifFalse: [history removeKey: package name]]. "Prepare message, including the update history and OSVM ci badges." message := String streamContents: [:s | s nextPutAll: 'VMMaker update succesfully. '. history ifEmpty: [s nextPutAll: 'All packages were already up-to-date.'] ifNotEmpty: [s nextPutAll: 'Updated packages:']. history keysAndValuesDo: [:packageName :updateInfo | s nextPutAll: ' - '. s nextPutAll: packageName; space. updateInfo isArray ifFalse: [s nextPutAll: '*removed*' translated] ifTrue: [ updateInfo first ifNil: [s nextPutAll: '*added*' translated] ifNotNil: [s print: updateInfo first versionNumber]. s nextPutAll: ' -> '. s print: updateInfo second versionNumber. s nextPutAll: '']]. s nextPutAll: (' Url: <a href="{1}">{1}</a>' format: {updater repository}). s nextPutAll: ' Map: '; print: updater updateMapName. s nextPutAll: (' TravisCI status: <a href="{1}"><img src="{2}" /> {3}</a>' format: { self osvm_TravisCI_statusPageUrl. self osvm_TravisCI_statusBadgeUrl. self osvm_TravisCI_statusTimestamp}). s nextPutAll: (' AppVeyor status: <a href="{1}"><img src="{2}" /> {3}</a>' format: { self osvm_AppVeyor_statusPageUrl. self osvm_AppVeyor_statusBadgeUrl. self osvm_AppVeyor_statusTimestamp}). s nextPutAll: (' NOTE THAT updated platform sources might be available, too: -> <a href="{1}">{1}</a>' format: {'https://github.com/OpenSmalltalk/opensmalltalk-vm'}). ]. self inform: message asTextFromHtml.!

1 0

macOS builds | Where is -Werror defined?
by Marcel Taeumel 28 Jul '21

28 Jul '21

Hi all! Only for build.macos*, there is "-Werror" defined somewhere for "-Wimplicit-function-declaration". Not for build.linux*, not for build.win*. Only macOS. ../../spursista64src/vm/cogitX64SysV.c:34300:3: error: implicit declaration of function 'storePointerofObjectwithValue' is invalid in C99 [-Werror,-Wimplicit-function-declaration] Can someone point me to the place? Or might it be configured in the environment already? Unrelated to our Makefiles? Where should I look? Best, Marcel

2 1

[OpenSmalltalk/opensmalltalk-vm] 94b23a: CogVM source as per CryptographyPlugins-eem.23
by Eliot Miranda 28 Jul '21

28 Jul '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 94b23a87dda832efcee48b7b27fc47216d9dbb38 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/94b23a87dda832efce… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-07-27 (Tue, 27 Jul 2021) Changed paths: M src/plugins/DESPlugin/DESPlugin.c M src/plugins/DSAPrims/DSAPrims.c M src/plugins/MD5Plugin/MD5Plugin.c M src/plugins/SHA2Plugin/SHA2Plugin.c Log Message: ----------- CogVM source as per CryptographyPlugins-eem.23 Mark the cryptography primitives with <export: true flags: #FastCPrimitiveFlag> It probably won't have much impact but will still save a little time.

1 0

[OpenSmalltalk/opensmalltalk-vm] 7dae2b: CogVM source as per VMMaker.oscog-eem.3006
by Eliot Miranda 28 Jul '21

28 Jul '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 7dae2be75e7e37df76f9cf0ad1d2276d47300020 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/7dae2be75e7e37df76… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-07-27 (Tue, 27 Jul 2021) Changed paths: M platforms/Cross/plugins/SqueakFFIPrims/sqFFITestFuncs.c M src/plugins/SqueakFFIPrims/ARM32FFIPlugin.c M src/plugins/SqueakFFIPrims/ARM64FFIPlugin.c M src/plugins/SqueakFFIPrims/IA32FFIPlugin.c M src/plugins/SqueakFFIPrims/X64SysVFFIPlugin.c M src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3006 ThreadedFFIPlugin: Do much more <inline: #always> inlining in the FFI plugin, as much to get rid of unused static functions as anything else. Fix my misunderstanding with the char type in ThreadedFFIPlugin. We need a range of character sizes, 8, 16 & 32 bit. But the current type descriptor scheme supports only 8 byte characters. This makes all FFI tests green (the last one was ffiTestChars).

1 0

VM Maker: VMMaker.oscog-eem.3006.mcz
by commits＠source.squeak.org 28 Jul '21

28 Jul '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3006.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3006 Author: eem Time: 27 July 2021, 8:39:41.638972 pm UUID: 52ac109b-6c67-49ce-a59a-c0e0dbb20e59 Ancestors: VMMaker.oscog-eem.3005 Fix my misunderstanding with the char type in ThreadedFFIPlugin. We need a range of character sizes, 8, 16 & 32 bit. But the current type descriptor scheme supports only 8 byte characters. This makes all FFI tests green (the last one was ffiTestChars). =============== Diff against VMMaker.oscog-eem.3005 =============== Item was changed: ----- Method: ThreadedFFIPlugin>>ffiCreateIntegralResultOop:ofAtomicType:in: (in category 'callout support') ----- ffiCreateIntegralResultOop: retVal ofAtomicType: atomicType in: calloutState <inline: #always> <var: #calloutState type: #'CalloutState *'> <var: #retVal type: #usqLong> "Callout support. Return the appropriate oop for the given atomic type" | shift value mask byteSize | <var: 'value' type: #usqLong> <var: 'mask' type: #usqLong> self assert: atomicType < FFITypeSingleFloat. atomicType = FFITypeBool ifTrue: ["Make sure bool honors the byte size requested" byteSize := calloutState ffiRetHeader bitAnd: FFIStructSizeMask. value := byteSize = (self sizeof: retVal) ifTrue:[retVal] ifFalse:[retVal bitAnd: 1 asUnsignedLongLong << (byteSize * 8) - 1]. ^value = 0 ifTrue:[interpreterProxy falseObject] ifFalse:[interpreterProxy trueObject]]. atomicType <= FFITypeSignedInt ifTrue: ["these are all generall integer returns" atomicType <= (BytesPerWord = 8 ifTrue: [FFITypeSignedInt] ifFalse: [FFITypeSignedShort]) ifTrue: ["byte/short. first extract partial word, then sign extend" shift := (BytesPerWord = 8 and: [atomicType >= FFITypeUnsignedInt]) ifTrue: [32] ifFalse: [(atomicType >> 1) * 8]. "# of significant bits" value := retVal bitAnd: (1 asUnsignedLongLong << shift - 1). (atomicType anyMask: 1) ifTrue: ["make the guy signed" mask := 1 asUnsignedLongLong << (shift-1). value := (value bitAnd: mask-1) - (value bitAnd: mask)]. ^interpreterProxy integerObjectOf: value]. "Word sized integer return" ^(atomicType anyMask: 1) ifTrue:[interpreterProxy signedMachineIntegerFor: retVal] "signed return" ifFalse:[interpreterProxy positiveMachineIntegerFor: retVal]]. "unsigned return" "longlong, char" (atomicType >> 1) = (FFITypeSignedLongLong >> 1) ifTrue: [^(atomicType anyMask: 1) ifTrue: [interpreterProxy signed64BitIntegerFor: retVal] "signed return" ifFalse: [interpreterProxy positive64BitIntegerFor: retVal]]. + self flag: 'we need a solution for wide characters; spur supports upto 30 bit characters'. + ^interpreterProxy characterObjectOf: (retVal bitAnd: 16rFF)! - self cppIf: #SPURVM - ifTrue: [^interpreterProxy characterObjectOf: (retVal bitAnd: 16r3FFFFFFF)] - ifFalse: [^interpreterProxy characterObjectOf: (retVal bitAnd: 16rFF)]!

1 0

VM Maker: VMMaker.oscog-eem.3005.mcz
by commits＠source.squeak.org 28 Jul '21

28 Jul '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3005.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3005 Author: eem Time: 27 July 2021, 8:25:12.753611 pm UUID: 7c1d4270-1771-487d-8fe6-bcef9b37c061 Ancestors: VMMaker.oscog-dtl.3004 Do much more <inline: #always> inlining in the FFI plugin, as much to get rid of unused static functions as anything else. =============== Diff against VMMaker.oscog-dtl.3004 =============== Item was changed: ----- Method: ThreadedARM32FFIPlugin>>canReturnInRegistersStructOfSize: (in category 'marshalling') ----- canReturnInRegistersStructOfSize: returnStructSize "Answer if a struct result of a given size is returned in registers or not." + <inline: #always> ^returnStructSize <= self wordSize! Item was changed: ----- Method: ThreadedARM32FFIPlugin>>encodeStructReturnTypeIn: (in category 'callout support') ----- encodeStructReturnTypeIn: calloutState "Set the return type to true if returning the struct via register" <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState structReturnType: (self canReturnInRegistersStructOfSize: calloutState structReturnSize)! Item was changed: ----- Method: ThreadedARM32FFIPlugin>>ffiPushPointer:in: (in category 'marshalling') ----- ffiPushPointer: pointer in: calloutState <var: #pointer type: #'void *'> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: pointer asInteger. calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] ifFalse: [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: pointer. calloutState currentArg: calloutState currentArg + self wordSize]. ^0! Item was changed: ----- Method: ThreadedARM32FFIPlugin>>ffiPushSignedByte:in: (in category 'marshalling') ----- ffiPushSignedByte: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'signed char'). calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] ifFalse: [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'signed char'). calloutState currentArg: calloutState currentArg + self wordSize]. ^0! Item was changed: ----- Method: ThreadedARM32FFIPlugin>>ffiPushSignedChar:in: (in category 'marshalling') ----- ffiPushSignedChar: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'signed char'). calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] ifFalse: [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'signed char'). calloutState currentArg: calloutState currentArg + self wordSize]. ^0! Item was changed: ----- Method: ThreadedARM32FFIPlugin>>ffiPushSignedInt:in: (in category 'marshalling') ----- ffiPushSignedInt: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: value. calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] ifFalse: [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: value. calloutState currentArg: calloutState currentArg + self wordSize]. + ^0! - ^0 - ! Item was changed: ----- Method: ThreadedARM32FFIPlugin>>ffiPushSignedLongLong:in: (in category 'marshalling') ----- ffiPushSignedLongLong: value in: calloutState <var: #value type: #sqLong> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < (NumIntRegArgs - 1) ifTrue: [calloutState integerRegisterIndex: (calloutState integerRegisterIndex + 1 bitClear: 1). calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #usqInt). calloutState integerRegisters at: calloutState integerRegisterIndex + 1 put: (self cCoerceSimple: value >> 32 to: #usqInt). calloutState integerRegisterIndex: calloutState integerRegisterIndex + 2] ifFalse: [calloutState currentArg + 8 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. calloutState integerRegisterIndex: NumIntRegArgs. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #usqInt); longAt: calloutState currentArg + self wordSize put: (self cCoerceSimple: value >> 32 to: #usqInt). calloutState currentArg: calloutState currentArg + 8]. ^0! Item was changed: ----- Method: ThreadedARM32FFIPlugin>>ffiPushSignedShort:in: (in category 'marshalling') ----- ffiPushSignedShort: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'signed short'). calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] ifFalse: [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'signed short'). calloutState currentArg: calloutState currentArg + self wordSize]. ^0! Item was changed: ----- Method: ThreadedARM32FFIPlugin>>ffiPushStructure:ofSize:typeSpec:ofLength:in: (in category 'marshalling') ----- ffiPushStructure: pointer ofSize: structSize typeSpec: argSpec ofLength: argSpecSize in: calloutState <var: #pointer type: #'void *'> <var: #argSpec type: #'sqInt *'> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> | availableRegisterSpace stackPartSize roundedSize | availableRegisterSpace := (NumIntRegArgs - calloutState integerRegisterIndex) * 4. stackPartSize := structSize. availableRegisterSpace > 0 ifTrue: [structSize <= availableRegisterSpace ifTrue: ["all in registers" stackPartSize := 0. self memcpy: (self cCoerceSimple: (self addressOf: (calloutState integerRegisters at: calloutState integerRegisterIndex)) to: 'void *') _: pointer _: structSize. calloutState integerRegisterIndex: calloutState integerRegisterIndex + (structSize + 3 bitShift: -2) ] ifFalse: ["If no previous co-processor candidate arg has already been pushed on the stack, then split the struct between registers and stack. Otherwise push entire struct on stack." calloutState currentArg = calloutState argVector ifTrue: [stackPartSize := structSize - availableRegisterSpace. self memcpy: (self cCoerceSimple: (self addressOf: (calloutState integerRegisters at: calloutState integerRegisterIndex)) to: 'void *') _: pointer _: availableRegisterSpace] ifFalse: [availableRegisterSpace := 0]. calloutState integerRegisterIndex: NumIntRegArgs]]. stackPartSize > 0 ifTrue: [roundedSize := stackPartSize + 3 bitClear: 3. calloutState currentArg + roundedSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. self memcpy: calloutState currentArg _: (self addressOf: ((self cCoerceSimple: pointer to: 'char *') at: availableRegisterSpace)) _: stackPartSize. calloutState currentArg: calloutState currentArg + roundedSize]. ^0! Item was changed: ----- Method: ThreadedARM32FFIPlugin>>ffiPushUnsignedByte:in: (in category 'marshalling') ----- ffiPushUnsignedByte: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'unsigned char'). calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] ifFalse: [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'unsigned char'). calloutState currentArg: calloutState currentArg + self wordSize]. + ^0! - ^0 - ! Item was changed: ----- Method: ThreadedARM32FFIPlugin>>ffiPushUnsignedChar:in: (in category 'marshalling') ----- ffiPushUnsignedChar: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'unsigned char'). calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] ifFalse: [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'unsigned char'). calloutState currentArg: calloutState currentArg + self wordSize]. ^0! Item was changed: ----- Method: ThreadedARM32FFIPlugin>>ffiPushUnsignedInt:in: (in category 'marshalling') ----- ffiPushUnsignedInt: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: value. calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] ifFalse: [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: value. calloutState currentArg: calloutState currentArg + self wordSize]. + ^0! - ^0 - - ! Item was changed: ----- Method: ThreadedARM32FFIPlugin>>ffiPushUnsignedLongLong:in: (in category 'marshalling') ----- ffiPushUnsignedLongLong: value in: calloutState <var: #value type: #usqLong> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < (NumIntRegArgs - 1) ifTrue: [calloutState integerRegisterIndex: (calloutState integerRegisterIndex + 1 bitClear: 1). calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #usqInt). calloutState integerRegisters at: calloutState integerRegisterIndex + 1 put: (self cCoerceSimple: value >> 32 to: #usqInt). calloutState integerRegisterIndex: calloutState integerRegisterIndex + 2] ifFalse: [calloutState currentArg + 8 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. calloutState integerRegisterIndex: NumIntRegArgs. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #usqInt); longAt: calloutState currentArg + self wordSize put: (self cCoerceSimple: value >> 32 to: #usqInt). calloutState currentArg: calloutState currentArg + 8]. + ^0! - ^0 - ! Item was changed: ----- Method: ThreadedARM32FFIPlugin>>ffiPushUnsignedShort:in: (in category 'marshalling') ----- ffiPushUnsignedShort: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'unsigned short'). calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] ifFalse: [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'unsigned short'). calloutState currentArg: calloutState currentArg + self wordSize]. ^0! Item was changed: ----- Method: ThreadedARM32FFIPlugin>>returnStructInRegisters: (in category 'marshalling') ----- returnStructInRegisters: calloutState + "Return through register if structReturnType is true" - "Return thrue register if structReturnType is true" <var: #calloutState type: #'CalloutState *'> + <inline: #always> ^calloutState structReturnType! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>canReturnInRegistersStructOfSize: (in category 'marshalling') ----- canReturnInRegistersStructOfSize: returnStructSize "Answer if a struct result of a given size is able to be returned in registers. NB: this is a predicate!! #canReturnInRegistersStructOfSize: does NOT return a struct in anything!!" + <inline: #always> ^returnStructSize <= (2 * self wordSize)! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>encodeStructReturnTypeIn: (in category 'callout support') ----- encodeStructReturnTypeIn: calloutState "Set the return type to true if returning the struct via register" <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState structReturnType: (self canReturnInRegistersStructOfSize: calloutState structReturnSize)! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>ffiPushSignedInt:in: (in category 'marshalling') ----- ffiPushSignedInt: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #sqLong). calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] ifFalse: [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: value. calloutState currentArg: calloutState currentArg + self wordSize]. + ^0! - ^0 - ! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>ffiPushSignedLongLong:in: (in category 'marshalling') ----- ffiPushSignedLongLong: value in: calloutState <var: #value type: #sqLong> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #sqLong). calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] ifFalse: [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: value. calloutState currentArg: calloutState currentArg + self wordSize]. ^0! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>ffiPushStructure:ofSize:typeSpec:ofLength:in: (in category 'marshalling') ----- ffiPushStructure: pointer ofSize: structSize typeSpec: argSpec ofLength: argSpecSize in: calloutState <var: #pointer type: #'void *'> <var: #argSpec type: #'unsigned int *'> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> | availableRegisterSpace stackPartSize roundedSize | "See IHI0055B_aapcs64.pdf sections 4.3.5 & 5.4.2 Stage C; we don't yet support HVA's" (self structIsHomogenousFloatArrayOfSize: structSize typeSpec: argSpec ofLength: argSpecSize) ifTrue: [availableRegisterSpace := (NumFloatRegArgs - calloutState floatRegisterIndex) * self wordSize. structSize <= availableRegisterSpace ifTrue: "Stage C, step C.2, all in floating-point registers (!!!!)" [self memcpy: (self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: calloutState floatRegisterIndex)) to: #'void *') _: pointer _: structSize. "Round structSize up and divide by 8 ( NB: _not_ 4 !!)" calloutState floatRegisterIndex: calloutState floatRegisterIndex + (structSize + 7 bitShift: -3). ^0]. "Stage C, step C.3" availableRegisterSpace := 0. calloutState floatRegisterIndex: 8] + ifFalse: [availableRegisterSpace := (NumIntRegArgs - calloutState integerRegisterIndex) * self wordSize]. stackPartSize := structSize. availableRegisterSpace > 0 ifTrue: [structSize <= availableRegisterSpace ifTrue:"all in integer registers" [self memcpy: (self cCoerceSimple: (self addressOf: (calloutState integerRegisters at: calloutState integerRegisterIndex)) to: #'void *') _: pointer _: structSize. "Round structSize up and divide by 8 ( NB: _not_ 4 !!)" calloutState integerRegisterIndex: calloutState integerRegisterIndex + (structSize + 7 bitShift: -3). ^0]. "If no previous co-processor candidate arg has already been pushed on the stack, then split the struct between registers and stack. Otherwise push entire struct on stack." calloutState currentArg = calloutState argVector ifTrue: [stackPartSize := structSize - availableRegisterSpace. self memcpy: (self cCoerceSimple: (self addressOf: (calloutState integerRegisters at: calloutState integerRegisterIndex)) to: 'void *') _: pointer _: availableRegisterSpace] ifFalse: [availableRegisterSpace := 0]. "Stage C, step C.11" calloutState integerRegisterIndex: NumIntRegArgs]. stackPartSize > 0 ifTrue: [roundedSize := stackPartSize + 3 bitClear: 3. calloutState currentArg + roundedSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. self memcpy: calloutState currentArg _: (self addressOf: ((self cCoerceSimple: pointer to: #'char *') at: availableRegisterSpace)) _: stackPartSize. calloutState currentArg: calloutState currentArg + roundedSize]. ^0! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>ffiPushUnsignedInt:in: (in category 'marshalling') ----- ffiPushUnsignedInt: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #usqLong). calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] ifFalse: [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: value. calloutState currentArg: calloutState currentArg + self wordSize]. + ^0! - ^0 - - ! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>ffiPushUnsignedLongLong:in: (in category 'marshalling') ----- ffiPushUnsignedLongLong: value in: calloutState <var: #value type: #usqLong> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put:(self cCoerceSimple: value to: #usqLong). calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] ifFalse: [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: value. calloutState currentArg: calloutState currentArg + self wordSize]. + ^0! - ^0 - ! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>mustReturnStructOnStack: (in category 'marshalling') ----- mustReturnStructOnStack: returnStructSize "Answer if a struct result of a given size is unable to be returned in registers." + <inline: #always> ^returnStructSize > (2 * self wordSize)! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>returnStructInRegisters: (in category 'marshalling') ----- returnStructInRegisters: calloutState + "Return through register if structReturnType is true" - "Return thrue register if structReturnType is true" <var: #calloutState type: #'CalloutState *'> + <inline: #always> ^calloutState structReturnType! Item was changed: ----- Method: ThreadedFFIPlugin>>encodeStructReturnTypeIn: (in category 'callout support') ----- encodeStructReturnTypeIn: calloutState "Set a variable encoding how the struct is to be returned. It is an OS dependent encoding, leaved to subclass responsibility." <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self subclassResponsibility ! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiAtomicArgByReference:Class:in: (in category 'callout support') ----- ffiAtomicArgByReference: oop Class: oopClass in: calloutState <var: #calloutState type: #'CalloutState *'> "Support for generic callout. Prepare a pointer reference to an atomic type for callout. Note: for type 'void*' we allow ByteArray/String/Symbol, wordVariableSubclass, Alien or ExternalAddress. for other types we allow ByteArray, wordVariableSubclass, Alien or ExternalAddress." | atomicType isString argIsAlien | + <inline: #always> - <inline: true> atomicType := self atomicTypeOf: calloutState ffiArgHeader. (atomicType = FFITypeBool) ifTrue: "No bools on input" [^FFIErrorCoercionFailed]. argIsAlien := (isString := interpreterProxy includesBehavior: oopClass ThatOf: interpreterProxy classString) ifTrue: [false] ifFalse: [interpreterProxy includesBehavior: oopClass ThatOf: interpreterProxy classAlien]. ((atomicType >> 1) = (FFITypeSignedChar >> 1)) ifTrue:"string value (char*)" "note: the only types allowed for passing into char* types are ByteArray, String, Symbol, Alien and *no* other byte indexed objects (e.g., CompiledMethod, LargeInteger). We only check for strings here and fall through to the byte* check otherwise." [isString ifTrue:"String/Symbol" "Strings must be allocated by the ffi support code" [^self ffiPushString: (interpreterProxy firstIndexableField: oop) OfLength: (interpreterProxy byteSizeOf: oop) in: calloutState]. "Fall through to byte* test" atomicType := FFITypeUnsignedByte]. self cppIf: COGMTVM ifTrue: ["Since all the following pass the address of the first indexable field we need to fail the call if it is threaded and the object is young, since it may move during the call." ((calloutState callFlags anyMask: FFICallFlagThreaded) and: [(argIsAlien not or: [self isDirectAlien: oop]) and: [interpreterProxy isYoung: oop]]) ifTrue: [^PrimErrObjectMayMove negated]]. (atomicType = FFITypeVoid or:[(atomicType >> 1) = (FFITypeSignedByte >> 1)]) ifTrue: "byte* -- see comment on string above" [(isString or: [oopClass = interpreterProxy classByteArray]) ifTrue: "String/Symbol/ByteArray" [^self ffiPushPointer: (interpreterProxy firstIndexableField: oop) in: calloutState]. (oopClass = interpreterProxy classExternalAddress) ifTrue: [^self ffiPushPointer: (self longAt: oop + interpreterProxy baseHeaderSize) in: calloutState]. argIsAlien ifTrue: [^self ffiPushPointer: (self pointerForOop: (self startOfData: oop)) in: calloutState]. atomicType = FFITypeVoid ifFalse: [^FFIErrorCoercionFailed]]. "note: type void falls through" "I can push pointers to any type (take for instance calls who receive int* output arguments, etc.) but I need to store them into a ByteArray, ExternalAddress or Alien" (atomicType <= FFITypeDoubleFloat) ifTrue: [((interpreterProxy isWords: oop) or: [oopClass = interpreterProxy classByteArray]) ifTrue: [^self ffiPushPointer: (interpreterProxy firstIndexableField: oop) in: calloutState]. (oopClass = interpreterProxy classExternalAddress) ifTrue: [^self ffiPushPointer: (self longAt: oop + interpreterProxy baseHeaderSize) in: calloutState]. argIsAlien ifTrue: [^self ffiPushPointer: (self pointerForOop: (self startOfData: oop)) in: calloutState]]. ^FFIErrorCoercionFailed! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiAtomicStructByReference:Class:in: (in category 'callout support') ----- ffiAtomicStructByReference: oop Class: oopClass in: calloutState <var: #calloutState type: #'CalloutState *'> "Support for generic callout. Prepare an external pointer reference to an atomic type for callout." | atomicType err valueOop | + <inline: #always> - <inline: true> "must be external data to pass pointers to atomic type" oopClass = interpreterProxy classExternalData ifFalse:[^FFIErrorCoercionFailed]. atomicType := self atomicTypeOf: calloutState ffiArgHeader. "no type checks for void pointers" atomicType ~= FFITypeVoid ifTrue:[ err := self ffiValidateExternalData: oop AtomicType: atomicType. err ~= 0 ifTrue:[^err]. ]. "and push pointer contents" valueOop := interpreterProxy fetchPointer: 0 ofObject: oop. ^self ffiPushPointerContentsOf: valueOop in: calloutState! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiContentsOfHandle:errCode: (in category 'callout support') ----- ffiContentsOfHandle: oop errCode: errCode "Make sure that the given oop is a valid external handle" + <inline: #always> - <inline: true> ((interpreterProxy isBytes: oop) and: [(interpreterProxy byteSizeOf: oop) = (self sizeof: #sqInt)]) ifFalse: [^self ffiFail: errCode]. ^interpreterProxy fetchPointer: 0 ofObject: oop! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiCreateIntegralResultOop:ofAtomicType:in: (in category 'callout support') ----- ffiCreateIntegralResultOop: retVal ofAtomicType: atomicType in: calloutState + <inline: #always> - <inline: true> <var: #calloutState type: #'CalloutState *'> <var: #retVal type: #usqLong> "Callout support. Return the appropriate oop for the given atomic type" | shift value mask byteSize | <var: 'value' type: #usqLong> <var: 'mask' type: #usqLong> self assert: atomicType < FFITypeSingleFloat. atomicType = FFITypeBool ifTrue: ["Make sure bool honors the byte size requested" byteSize := calloutState ffiRetHeader bitAnd: FFIStructSizeMask. value := byteSize = (self sizeof: retVal) ifTrue:[retVal] ifFalse:[retVal bitAnd: 1 asUnsignedLongLong << (byteSize * 8) - 1]. ^value = 0 ifTrue:[interpreterProxy falseObject] ifFalse:[interpreterProxy trueObject]]. atomicType <= FFITypeSignedInt ifTrue: ["these are all generall integer returns" atomicType <= (BytesPerWord = 8 ifTrue: [FFITypeSignedInt] ifFalse: [FFITypeSignedShort]) ifTrue: ["byte/short. first extract partial word, then sign extend" shift := (BytesPerWord = 8 and: [atomicType >= FFITypeUnsignedInt]) ifTrue: [32] ifFalse: [(atomicType >> 1) * 8]. "# of significant bits" value := retVal bitAnd: (1 asUnsignedLongLong << shift - 1). (atomicType anyMask: 1) ifTrue: ["make the guy signed" mask := 1 asUnsignedLongLong << (shift-1). value := (value bitAnd: mask-1) - (value bitAnd: mask)]. ^interpreterProxy integerObjectOf: value]. "Word sized integer return" ^(atomicType anyMask: 1) ifTrue:[interpreterProxy signedMachineIntegerFor: retVal] "signed return" ifFalse:[interpreterProxy positiveMachineIntegerFor: retVal]]. "unsigned return" "longlong, char" (atomicType >> 1) = (FFITypeSignedLongLong >> 1) ifTrue: [^(atomicType anyMask: 1) ifTrue: [interpreterProxy signed64BitIntegerFor: retVal] "signed return" ifFalse: [interpreterProxy positive64BitIntegerFor: retVal]]. self cppIf: #SPURVM ifTrue: [^interpreterProxy characterObjectOf: (retVal bitAnd: 16r3FFFFFFF)] ifFalse: [^interpreterProxy characterObjectOf: (retVal bitAnd: 16rFF)]! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiFloatValueOf: (in category 'callout support') ----- ffiFloatValueOf: oop "Support for generic callout. Return a float value that is coerced as C would do." <returnTypeC: #double> + <inline: #always> (interpreterProxy isFloatObject: oop) ifTrue: [^interpreterProxy floatValueOf: oop]. "otherwise try the integer coercions and return its float value" ^(self ffiIntegerValueOf: oop) asFloat! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiLoadCalloutAddress: (in category 'symbol loading') ----- ffiLoadCalloutAddress: lit "Load the address of the foreign function from the given object" + <inline: #always> | addressPtr address ptr | <var: #ptr type: #'sqIntptr_t *'> "Lookup the address" addressPtr := interpreterProxy fetchPointer: 0 ofObject: lit. "Make sure it's an external handle" address := self ffiContentsOfHandle: addressPtr errCode: FFIErrorBadAddress. interpreterProxy failed ifTrue: [^0]. address = 0 ifTrue:"Go look it up in the module" [self externalFunctionHasStackSizeSlot ifTrue: [interpreterProxy storeInteger: ExternalFunctionStackSizeIndex ofObject: lit withValue: -1]. (interpreterProxy slotSizeOf: lit) < 5 ifTrue: [^self ffiFail: FFIErrorNoModule]. address := self ffiLoadCalloutAddressFrom: lit. interpreterProxy failed ifTrue: [^0]. "Store back the address" ptr := interpreterProxy firstIndexableField: addressPtr. ptr at: 0 put: address]. ^address! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiPushDoubleFloat:in: (in category 'marshalling') ----- ffiPushDoubleFloat: value in: calloutState <var: #calloutState type: #double> <var: #calloutState type: #'CalloutState *'> + <inline: #always> ^self subclassResponsibility! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiPushPointer:in: (in category 'marshalling') ----- ffiPushPointer: pointer in: calloutState <var: #pointer type: #'void *'> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self subclassResponsibility! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiPushSignedByte:in: (in category 'marshalling') ----- ffiPushSignedByte: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self subclassResponsibility! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiPushSignedChar:in: (in category 'marshalling') ----- ffiPushSignedChar: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self subclassResponsibility! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiPushSignedInt:in: (in category 'marshalling') ----- ffiPushSignedInt: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self subclassResponsibility! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiPushSignedLongLong:in: (in category 'marshalling') ----- ffiPushSignedLongLong: value in: calloutState <var: #value type: #sqLong> <var: #calloutState type: #'CalloutState *'> + <inline: #always> ^self subclassResponsibility! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiPushSignedLongLongOop:in: (in category 'marshalling') ----- ffiPushSignedLongLongOop: oop in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> "Push a longlong type (e.g., a 64bit integer). Note: Coercions from float are *not* supported." | value | <var: #value type: #sqLong> (oop = interpreterProxy nilObject or: [oop = interpreterProxy falseObject]) ifTrue:[value := 0] ifFalse: [oop = interpreterProxy trueObject ifTrue:[value := 1] ifFalse: [value := interpreterProxy signed64BitValueOf: oop. interpreterProxy failed ifTrue: [^FFIErrorCoercionFailed]]]. ^self ffiPushSignedLongLong: value in: calloutState! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiPushSignedShort:in: (in category 'marshalling') ----- ffiPushSignedShort: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self subclassResponsibility! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiPushSingleFloat:in: (in category 'marshalling') ----- ffiPushSingleFloat: value in: calloutState <var: #value type: #float> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self subclassResponsibility! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiPushString:OfLength:in: (in category 'marshalling') ----- ffiPushString: pointer OfLength: length in: calloutState <var: #pointer type: #'char *'> <var: #calloutState type: #'CalloutState *'> | copy | <var: #copy type: #'char *'> + <inline: #always> - <inline: true> calloutState stringArgIndex >= MaxNumArgs ifTrue: [^PrimErrBadNumArgs negated]. copy := self malloc: length + 1. copy isNil ifTrue: [^PrimErrNoCMemory negated]. self memcpy: copy _: pointer _: length. copy at: length put: 0. calloutState stringArgs at: calloutState stringArgIndex put: copy. calloutState stringArgIndex: calloutState stringArgIndex + 1. ^self ffiPushPointer: copy in: calloutState! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiPushUnsignedByte:in: (in category 'marshalling') ----- ffiPushUnsignedByte: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self subclassResponsibility! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiPushUnsignedChar:in: (in category 'marshalling') ----- ffiPushUnsignedChar: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self subclassResponsibility! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiPushUnsignedInt:in: (in category 'marshalling') ----- ffiPushUnsignedInt: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self subclassResponsibility! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiPushUnsignedLongLongOop:in: (in category 'marshalling') ----- ffiPushUnsignedLongLongOop: oop in: calloutState <var: #calloutState type: #'CalloutState *'> "Push an unsigned longlong type (e.g., a 64bit integer). Note: Coercions from float are *not* supported." + <inline: #always> | value | <var: #value type: #usqLong> (oop = interpreterProxy nilObject or: [oop = interpreterProxy falseObject]) ifTrue:[value := 0] ifFalse: [oop = interpreterProxy trueObject ifTrue:[value := 1] ifFalse: [value := interpreterProxy positive64BitValueOf: oop. interpreterProxy failed ifTrue: [^FFIErrorCoercionFailed]]]. ^self ffiPushUnsignedLongLong: value in: calloutState! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiPushUnsignedShort:in: (in category 'marshalling') ----- ffiPushUnsignedShort: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self subclassResponsibility! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiPushVoid:in: (in category 'marshalling') ----- ffiPushVoid: ignored in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> "This is a fallback in case somebody tries to pass a 'void' value. We could simply ignore the argument but I think it's better to let the caller know what he did" ^FFIErrorAttemptToPassVoid! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>encodeStructReturnTypeIn: (in category 'callout support') ----- encodeStructReturnTypeIn: calloutState "Set the return type to true if returning the struct via register" <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState structReturnType: (self canReturnInRegistersStructOfSize: calloutState structReturnSize)! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushPointer:in: (in category 'marshalling') ----- ffiPushPointer: pointer in: calloutState <var: #pointer type: #'void *'> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState currentArg + 4 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: pointer. calloutState currentArg: calloutState currentArg + 4. ^0! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushSignedByte:in: (in category 'marshalling') ----- ffiPushSignedByte: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState currentArg + 4 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'signed char'). calloutState currentArg: calloutState currentArg + 4. ^0! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushSignedChar:in: (in category 'marshalling') ----- ffiPushSignedChar: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState currentArg + 4 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'signed char'). calloutState currentArg: calloutState currentArg + 4. ^0! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushSignedInt:in: (in category 'marshalling') ----- ffiPushSignedInt: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState currentArg + 4 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: value. calloutState currentArg: calloutState currentArg + 4. ^0! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushSignedLongLong:in: (in category 'marshalling') ----- ffiPushSignedLongLong: value in: calloutState <var: #value type: #usqLong> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState currentArg + 8 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #usqInt); longAt: calloutState currentArg + 4 put: (self cCoerceSimple: value >> 32 to: #usqInt). calloutState currentArg: calloutState currentArg + 8. ^0! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushSignedShort:in: (in category 'marshalling') ----- ffiPushSignedShort: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState currentArg + 4 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'signed short'). calloutState currentArg: calloutState currentArg + 4. ^0! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushStructure:ofSize:typeSpec:ofLength:in: (in category 'marshalling') ----- ffiPushStructure: pointer ofSize: structSize typeSpec: argSpec ofLength: argSpecSize in: calloutState <var: #pointer type: #'void *'> <var: #argSpec type: #'sqInt *'> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> | roundedSize | roundedSize := structSize + 3 bitClear: 3. calloutState currentArg + roundedSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. self memcpy: calloutState currentArg _: pointer _: structSize. calloutState currentArg: calloutState currentArg + roundedSize. ^0! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushUnsignedByte:in: (in category 'marshalling') ----- ffiPushUnsignedByte: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState currentArg + 4 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'unsigned char'). calloutState currentArg: calloutState currentArg + 4. ^0! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushUnsignedChar:in: (in category 'marshalling') ----- ffiPushUnsignedChar: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState currentArg + 4 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'unsigned char'). calloutState currentArg: calloutState currentArg + 4. ^0! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushUnsignedInt:in: (in category 'marshalling') ----- ffiPushUnsignedInt: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState currentArg + 4 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: value. calloutState currentArg: calloutState currentArg + 4. ^0! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushUnsignedLongLong:in: (in category 'marshalling') ----- ffiPushUnsignedLongLong: value in: calloutState <var: #value type: #usqLong> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState currentArg + 8 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #usqInt); longAt: calloutState currentArg + 4 put: (self cCoerceSimple: value >> 32 to: #usqInt). calloutState currentArg: calloutState currentArg + 8. ^0! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushUnsignedShort:in: (in category 'marshalling') ----- ffiPushUnsignedShort: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState currentArg + 4 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'unsigned short'). calloutState currentArg: calloutState currentArg + 4. ^0! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>returnStructInRegisters: (in category 'marshalling') ----- returnStructInRegisters: calloutState + "Return through register if structReturnType is true" - "Return thrue register if structReturnType is true" <var: #calloutState type: #'CalloutState *'> + <inline: #always> ^calloutState structReturnType! Item was changed: ----- Method: ThreadedPPCBEFFIPlugin>>canReturnInRegistersStructOfSize: (in category 'marshalling') ----- canReturnInRegistersStructOfSize: returnStructSize "Answer if a struct result of a given size is returned in registers or not. The ABI spec defines return in registers, but some linux gcc versions implemented an erroneous draft which does not return any struct in memory. Implement the SysV ABI." + <inline: #always> ^returnStructSize <= 8! Item was changed: ----- Method: ThreadedPPCBEFFIPlugin>>encodeStructReturnTypeIn: (in category 'callout support') ----- encodeStructReturnTypeIn: calloutState "Set the return type to true if returning the struct via register" <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState structReturnType: (self canReturnInRegistersStructOfSize: calloutState structReturnSize)! Item was changed: ----- Method: ThreadedPPCBEFFIPlugin>>ffiPushDoubleFloat:in: (in category 'marshalling') ----- ffiPushDoubleFloat: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self shouldBeImplemented. ^0! Item was changed: ----- Method: ThreadedPPCBEFFIPlugin>>ffiPushPointer:in: (in category 'marshalling') ----- ffiPushPointer: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self shouldBeImplemented. ^0! Item was changed: ----- Method: ThreadedPPCBEFFIPlugin>>ffiPushSignedByte:in: (in category 'marshalling') ----- ffiPushSignedByte: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self shouldBeImplemented. ^0! Item was changed: ----- Method: ThreadedPPCBEFFIPlugin>>ffiPushSignedChar:in: (in category 'marshalling') ----- ffiPushSignedChar: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self shouldBeImplemented. ^0! Item was changed: ----- Method: ThreadedPPCBEFFIPlugin>>ffiPushSignedInt:in: (in category 'marshalling') ----- ffiPushSignedInt: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self shouldBeImplemented. ^0! Item was changed: ----- Method: ThreadedPPCBEFFIPlugin>>ffiPushSignedLongLong:in: (in category 'marshalling') ----- ffiPushSignedLongLong: value in: calloutState <var: #value type: #sqLong> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self shouldBeImplemented. ^0! Item was changed: ----- Method: ThreadedPPCBEFFIPlugin>>ffiPushSignedShort:in: (in category 'marshalling') ----- ffiPushSignedShort: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self shouldBeImplemented. ^0! Item was changed: ----- Method: ThreadedPPCBEFFIPlugin>>ffiPushSingleFloat:in: (in category 'marshalling') ----- ffiPushSingleFloat: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self shouldBeImplemented. ^0! Item was changed: ----- Method: ThreadedPPCBEFFIPlugin>>ffiPushUnsignedByte:in: (in category 'marshalling') ----- ffiPushUnsignedByte: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self shouldBeImplemented. ^0! Item was changed: ----- Method: ThreadedPPCBEFFIPlugin>>ffiPushUnsignedChar:in: (in category 'marshalling') ----- ffiPushUnsignedChar: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self shouldBeImplemented. ^0! Item was changed: ----- Method: ThreadedPPCBEFFIPlugin>>ffiPushUnsignedInt:in: (in category 'marshalling') ----- ffiPushUnsignedInt: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self shouldBeImplemented. ^0! Item was changed: ----- Method: ThreadedPPCBEFFIPlugin>>ffiPushUnsignedLongLong:in: (in category 'marshalling') ----- ffiPushUnsignedLongLong: value in: calloutState <var: #value type: #usqLong> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self shouldBeImplemented. ^0! Item was changed: ----- Method: ThreadedPPCBEFFIPlugin>>ffiPushUnsignedShort:in: (in category 'marshalling') ----- ffiPushUnsignedShort: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> self shouldBeImplemented. ^0! Item was changed: ----- Method: ThreadedPPCBEFFIPlugin>>returnStructInRegisters: (in category 'marshalling') ----- returnStructInRegisters: calloutState + "Return through register if structReturnType is true" - "Return thrue register if structReturnType is true" <var: #calloutState type: #'CalloutState *'> + <inline: #always> ^calloutState structReturnType! Item was changed: ----- Method: ThreadedX64FFIPlugin>>ffiPushPointer:in: (in category 'marshalling') ----- ffiPushPointer: pointer in: calloutState <var: #pointer type: #'void *'> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: pointer asInteger. calloutState incrementIntegerRegisterIndex] ifFalse: [calloutState currentArg + WordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: pointer. calloutState currentArg: calloutState currentArg + WordSize]. ^0! Item was changed: ----- Method: ThreadedX64FFIPlugin>>ffiPushSignedByte:in: (in category 'marshalling') ----- ffiPushSignedByte: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'signed char'). calloutState incrementIntegerRegisterIndex] ifFalse: [calloutState currentArg + WordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'signed char'). calloutState currentArg: calloutState currentArg + WordSize]. ^0! Item was changed: ----- Method: ThreadedX64FFIPlugin>>ffiPushSignedChar:in: (in category 'marshalling') ----- ffiPushSignedChar: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'signed char'). calloutState incrementIntegerRegisterIndex] ifFalse: [calloutState currentArg + WordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'signed char'). calloutState currentArg: calloutState currentArg + WordSize]. ^0! Item was changed: ----- Method: ThreadedX64FFIPlugin>>ffiPushSignedInt:in: (in category 'marshalling') ----- ffiPushSignedInt: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: value. calloutState incrementIntegerRegisterIndex] ifFalse: [calloutState currentArg + WordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: value. calloutState currentArg: calloutState currentArg + WordSize]. + ^0! - ^0 - ! Item was changed: ----- Method: ThreadedX64FFIPlugin>>ffiPushSignedLongLong:in: (in category 'marshalling') ----- ffiPushSignedLongLong: value in: calloutState <var: #value type: #sqLong> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #usqInt). calloutState incrementIntegerRegisterIndex] ifFalse: [calloutState currentArg + WordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: value. calloutState currentArg: calloutState currentArg + WordSize]. ^0! Item was changed: ----- Method: ThreadedX64FFIPlugin>>ffiPushSignedShort:in: (in category 'marshalling') ----- ffiPushSignedShort: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'signed short'). calloutState incrementIntegerRegisterIndex] ifFalse: [calloutState currentArg + WordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'signed short'). calloutState currentArg: calloutState currentArg + WordSize]. ^0! Item was changed: ----- Method: ThreadedX64FFIPlugin>>ffiPushUnsignedByte:in: (in category 'marshalling') ----- ffiPushUnsignedByte: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'unsigned char'). calloutState incrementIntegerRegisterIndex] ifFalse: [calloutState currentArg + WordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'unsigned char'). calloutState currentArg: calloutState currentArg + WordSize]. + ^0! - ^0 - ! Item was changed: ----- Method: ThreadedX64FFIPlugin>>ffiPushUnsignedChar:in: (in category 'marshalling') ----- ffiPushUnsignedChar: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'unsigned char'). calloutState incrementIntegerRegisterIndex] ifFalse: [calloutState currentArg + WordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'unsigned char'). calloutState currentArg: calloutState currentArg + WordSize]. ^0! Item was changed: ----- Method: ThreadedX64FFIPlugin>>ffiPushUnsignedInt:in: (in category 'marshalling') ----- ffiPushUnsignedInt: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: value. calloutState incrementIntegerRegisterIndex] ifFalse: [calloutState currentArg + WordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: value. calloutState currentArg: calloutState currentArg + WordSize]. + ^0! - ^0 - - ! Item was changed: ----- Method: ThreadedX64FFIPlugin>>ffiPushUnsignedLongLong:in: (in category 'marshalling') ----- ffiPushUnsignedLongLong: value in: calloutState <var: #value type: #usqLong> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: value. calloutState incrementIntegerRegisterIndex] ifFalse: [calloutState currentArg + WordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: value. calloutState currentArg: calloutState currentArg + WordSize]. ^0! Item was changed: ----- Method: ThreadedX64FFIPlugin>>ffiPushUnsignedShort:in: (in category 'marshalling') ----- ffiPushUnsignedShort: value in: calloutState <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState integerRegisterIndex < NumIntRegArgs ifTrue: [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'unsigned short'). calloutState incrementIntegerRegisterIndex] ifFalse: [calloutState currentArg + WordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'unsigned short'). calloutState currentArg: calloutState currentArg + WordSize]. ^0! Item was changed: ----- Method: ThreadedX64SysVFFIPlugin>>canReturnInRegistersStructOfSize: (in category 'marshalling') ----- canReturnInRegistersStructOfSize: returnStructSize "Answer if a struct result of a given size is returned in registers or not." + <inline: #always> ^returnStructSize <= (WordSize * 2)! Item was changed: ----- Method: ThreadedX64SysVFFIPlugin>>encodeStructReturnTypeIn: (in category 'callout support') ----- encodeStructReturnTypeIn: calloutState "Set the return type to an integer encoding the type of registers used to return the struct * 2r00 for float float (XMM0 XMM1) * 2r01 for int float (RAX XMM0) * 2r10 for float int (XMM0 RAX) * 2r11 for int int (RAX RDX) * 2r100 for float (XMM0) * 2r101 for int (RAX) * 2r110 For return thru memory (struct field not aligned or struct too big)" <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> | registerType | registerType := (self canReturnInRegistersStructOfSize: calloutState structReturnSize) ifTrue: [ self registerTypeForStructSpecs: (interpreterProxy firstIndexableField: calloutState ffiRetSpec) OfLength: (interpreterProxy slotSizeOf: calloutState ffiRetSpec)] ifFalse: [ "We cannot return via register, struct is too big" 2r110 ]. calloutState structReturnType: registerType! Item was changed: ----- Method: ThreadedX64SysVFFIPlugin>>ffiPushStructure:ofSize:typeSpec:ofLength:in: (in category 'marshalling') ----- ffiPushStructure: pointer ofSize: structSize typeSpec: argSpec ofLength: argSpecSize in: calloutState <var: #pointer type: #'void *'> <var: #argSpec type: #'sqInt *'> <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> | roundedSize registerType numDoubleRegisters numIntegerRegisters passField0InXmmReg passField1InXmmReg | structSize <= 16 ifTrue: ["See sec 3.2.3 of http://people.freebsd.org/~obrien/amd64-elf-abi.pdf. (dravft version 0.90). All of the folowing are passed in registers: typedef struct { long a; } s0; typedef struct { double a; } s1; typedef struct { long a; double b; } s2; typedef struct { int a; int b; double c; } s2a; typedef struct { short a; short b; short c; short d; double e; } s2b; typedef struct { long a; float b; } s2f; typedef struct { long a; float b; float c; } s2g; typedef struct { int a; float b; int c; float d; } s2h;" registerType := self registerTypeForStructSpecs: (self cCoerce: argSpec to: #'unsigned int *') OfLength: argSpecSize. registerType = 2r110 "check case of invalid alignment => pass by memory" ifFalse: [passField0InXmmReg := (registerType bitAnd: 1) = 0. structSize <= 8 ifTrue: [numIntegerRegisters := registerType bitAnd: 1. numDoubleRegisters := 1 - numIntegerRegisters] ifFalse: [passField1InXmmReg := (registerType bitAnd: 2) = 0. numIntegerRegisters := (registerType bitAnd: 2) >> 1 + (registerType bitAnd: 1). numDoubleRegisters := 2 - numIntegerRegisters]. (calloutState floatRegisterIndex + numDoubleRegisters <= NumFloatRegArgs and: [calloutState integerRegisterIndex + numIntegerRegisters <= NumIntRegArgs]) ifTrue: [passField0InXmmReg ifTrue: [self ffiPushDoubleFloat: ((self cCoerceSimple: pointer to: #'double *') at: 0) in: calloutState] ifFalse: [self ffiPushSignedLongLong: ((self cCoerceSimple: pointer to: #'long long *') at: 0) in: calloutState]. structSize > 8 ifTrue: [passField1InXmmReg ifTrue: [self ffiPushDoubleFloat: ((self cCoerceSimple: pointer to: #'double *') at: 1) in: calloutState] ifFalse: [self ffiPushSignedLongLong: ((self cCoerceSimple: pointer to: #'long long *') at: 1) in: calloutState]]. ^0]]]. roundedSize := structSize + 7 bitClear: 7. calloutState currentArg + roundedSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. self memcpy: calloutState currentArg _: (self cCoerceSimple: pointer to: 'char *') _: structSize. calloutState currentArg: calloutState currentArg + roundedSize. ^0! Item was changed: ----- Method: ThreadedX64SysVFFIPlugin>>returnStructInRegisters: (in category 'marshalling') ----- returnStructInRegisters: calloutState "Use the register type encoding stored in structReturnType 2r110 means impossible, pass thru memory. Anything smaller encodes the type of register used, thus means true." <var: #calloutState type: #'CalloutState *'> + <inline: #always> ^calloutState structReturnType < 2r110! Item was changed: ----- Method: ThreadedX64Win64FFIPlugin>>canReturnInRegistersStructOfSize: (in category 'marshalling') ----- canReturnInRegistersStructOfSize: returnStructSize "Answer if a struct result of a given size is returned in registers or not." + <inline: #always> ^returnStructSize <= WordSize and: ["returnStructSize isPowerOfTwo" (returnStructSize bitAnd: returnStructSize-1) = 0]! Item was changed: ----- Method: ThreadedX64Win64FFIPlugin>>encodeStructReturnTypeIn: (in category 'callout support') ----- encodeStructReturnTypeIn: calloutState "Set the return type to true if returning the struct via register" <var: #calloutState type: #'CalloutState *'> + <inline: #always> - <inline: true> calloutState structReturnType: (self canReturnInRegistersStructOfSize: calloutState structReturnSize)! Item was changed: ----- Method: ThreadedX64Win64FFIPlugin>>ffiPushStructure:ofSize:typeSpec:ofLength:in: (in category 'marshalling') ----- ffiPushStructure: pointer ofSize: structSize typeSpec: argSpec ofLength: argSpecSize in: calloutState <var: #pointer type: #'void *'> <var: #argSpec type: #'sqInt *'> <var: #calloutState type: #'CalloutState *'> <var: #arg type: #usqLong> + <inline: #always> - <inline: true> structSize <= 0 ifTrue: [^FFIErrorStructSize]. + "See https://docs.microsoft.com/en-us/cpp/build/x64-calling-convention?view=vs-2…" (structSize <= WordSize and: [(structSize bitAnd: structSize - 1) = 0 "a.k.a. structSize isPowerOfTwo"]) ifTrue: [| arg | self memcpy: (self addressOf: arg) _: pointer _: structSize. ^self ffiPushUnsignedLongLong: arg in: calloutState]. + "BUG!!!! This memory should be 16-byte aligned; Spur guarantees only 8-byte alignment." self flag: #bug. ^self ffiPushPointer: pointer in: calloutState! Item was changed: ----- Method: ThreadedX64Win64FFIPlugin>>returnStructInRegisters: (in category 'marshalling') ----- returnStructInRegisters: calloutState + "Return through register if structReturnType is true" - "Return thrue register if structReturnType is true" <var: #calloutState type: #'CalloutState *'> + <inline: #always> ^calloutState structReturnType!

1 0

[OpenSmalltalk/opensmalltalk-vm] 137e96: CogVM source as per VMMaker.oscog-eem.3003
by Eliot Miranda 27 Jul '21

27 Jul '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 137e96ddee9873467726ef6a7c3f6670102b4d08 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/137e96ddee98734677… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-07-27 (Tue, 27 Jul 2021) Changed paths: M spur64src/vm/cogit.h M spur64src/vm/cogitARMv8.c M spur64src/vm/cogitX64SysV.c M spur64src/vm/cogitX64WIN64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/cointerpmt.c M spur64src/vm/cointerpmt.h M spur64src/vm/gcc3x-cointerp.c M spur64src/vm/gcc3x-cointerpmt.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cogitARMv8.c M spurlowcode64src/vm/cogitX64SysV.c M spurlowcode64src/vm/cogitX64WIN64.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cogitARMv5.c M spurlowcodesrc/vm/cogitIA32.c M spurlowcodesrc/vm/cogitMIPSEL.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitARMv8.c M spursista64src/vm/cogitX64SysV.c M spursista64src/vm/cogitX64WIN64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/cointerpmt.c M spursrc/vm/cointerpmt.h M spursrc/vm/gcc3x-cointerp.c M spursrc/vm/gcc3x-cointerpmt.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstack64src/vm/validImage.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M spurstacksrc/vm/validImage.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/gcc3x-cointerp.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3003 Cogit: fix what is hopefully the last bug with the new FastCPrimitive scheme. ReceiverResultReg must be reloaded if it is in the ABI's caller saved registers since it may have been smashed and the prologue sequence assumes ReceiverResultReg is live.

1 0

VM Maker: VMMaker.oscog-eem.3003.mcz
by commits＠source.squeak.org 27 Jul '21

27 Jul '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3003.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3003 Author: eem Time: 27 July 2021, 1:49:36.504414 pm UUID: dd2cf315-8c10-45ac-9ad5-336ddc486b87 Ancestors: VMMaker.oscog-eem.3002 Cogit: fix what is hopefully the last bug with the new FastCPrimitive scheme. ReceiverResultReg must be reloaded if it is in the ABI's caller saved registers sicne it may have been smashed and the prologue sequence assumes ReceiverResultReg is live. Simulation: get the ThreadedFFIPlugin to load and simulate. Cope with checkForAndFollowForwardedPrimitiveState returning a boolean in handleCallOrJumpSimulationTrap:. =============== Diff against VMMaker.oscog-eem.3002 =============== Item was changed: ----- Method: Cogit>>checkIfValidOopRefAndTarget:pc:cogMethod: (in category 'garbage collection') ----- checkIfValidOopRefAndTarget: annotation pc: mcpc cogMethod: cogMethod "Check for a valid object reference, if any, at a map entry. Answer a code unique to each error for debugging." <var: #mcpc type: #'char *'> + <var: #cogMethod type: #'CogMethod *'> + <var: #nsSendCache type: #'NSSendCache *'> | literal entryPoint | annotation = IsObjectReference ifTrue: [literal := literalsManager fetchLiteralAtAnnotatedAddress: mcpc asUnsignedInteger using: backEnd. (self asserta: (objectRepresentation checkValidOopReference: literal)) ifFalse: [^1]. ((objectRepresentation couldBeObject: literal) and: [objectMemory isReallyYoungObject: literal]) ifTrue: [(self asserta: (self cCoerceSimple: cogMethod to: #'CogMethod *') cmRefersToYoung) ifFalse: [^2]]]. NewspeakVM ifTrue: [annotation = IsNSSendCall ifTrue: [| nsSendCache classTag enclosingObject nsTargetMethod | nsSendCache := self nsSendCacheFromReturnAddress: mcpc asInteger. (self asserta: (objectRepresentation checkValidOopReference: nsSendCache selector)) ifFalse: [^9]. classTag := nsSendCache classTag. (self asserta: (classTag = 0 or: [objectRepresentation validInlineCacheTag: classTag])) ifFalse: [^10]. enclosingObject := nsSendCache enclosingObject. (self asserta: (enclosingObject = 0 or: [objectRepresentation checkValidOopReference: enclosingObject])) ifFalse: [^11]. entryPoint := nsSendCache target. entryPoint ~= 0 ifTrue: [ nsTargetMethod := self cCoerceSimple: entryPoint - cmNoCheckEntryOffset to: #'CogMethod *'. (self asserta: (nsTargetMethod cmType = CMMethod)) ifFalse: [^12]]]]. (self isPureSendAnnotation: annotation) ifTrue: [(self asserta: (self cCoerceSimple: cogMethod to: #'CogMethod *') cmType = CMMethod) ifFalse: [^3]. self entryCacheTagAndCouldBeObjectAt: mcpc annotation: annotation into: [:entryPt :cacheTag :tagCouldBeObject| entryPoint := entryPt. tagCouldBeObject ifTrue: [(objectRepresentation couldBeObject: cacheTag) ifTrue: [(self asserta: (objectRepresentation checkValidOopReference: cacheTag)) ifFalse: [^4]] ifFalse: [(self asserta: (objectRepresentation validInlineCacheTag: cacheTag)) ifFalse: [^5]]. ((objectRepresentation couldBeObject: cacheTag) and: [objectMemory isReallyYoungObject: cacheTag]) ifTrue: [(self asserta: (self cCoerceSimple: cogMethod to: #'CogMethod *') cmRefersToYoung) ifFalse: [^6]]] ifFalse: [(self inlineCacheTagsAreIndexes and: [self entryPointTagIsSelector: entryPoint]) ifTrue: [cacheTag signedIntFromLong < 0 ifTrue: [cacheTag signedIntFromLong negated > NumSpecialSelectors ifTrue: [^7]] ifFalse: [cacheTag >= (objectMemory literalCountOf: enumeratingCogMethod methodObject) ifTrue: [^8]]] ifFalse: [(self asserta: (objectRepresentation validInlineCacheTag: cacheTag)) ifFalse: [^9]]]]. entryPoint > methodZoneBase ifTrue: ["It's a linked send; find which kind." self targetMethodAndSendTableFor: entryPoint annotation: annotation into: [:targetMethod :sendTable| (self asserta: (targetMethod cmType = CMMethod or: [targetMethod cmType = CMClosedPIC or: [targetMethod cmType = CMOpenPIC]])) ifFalse: [^10]]]]. ^0 "keep scanning"! Item was changed: ----- Method: Cogit>>handleCallOrJumpSimulationTrap: (in category 'simulation only') ----- handleCallOrJumpSimulationTrap: aProcessorSimulationTrap <doNotGenerate> + | evaluable function memory result savedFramePointer savedStackPointer savedArgumentCount retpc invalidStackPointersExpected index | - | evaluable function memory result savedFramePointer savedStackPointer savedArgumentCount retpc invalidStackPointersExpected | "Execution of a single instruction must be within the processorLock critical section to ensure simulation traps are executed atomically. However, at this point control is leaving machine code and entering the run-time and hence the lock must be released." processorLock primitiveExitCriticalSection. "This is a hack fix before we revise the simulators. When a jump call is made, the next pc is effectively the return address on the stack, not the instruction following the jump." aProcessorSimulationTrap type == #jump ifTrue: [processor hackFixNextPCOfJumpFor: aProcessorSimulationTrap using: objectMemory]. evaluable := simulatedTrampolines at: aProcessorSimulationTrap address ifAbsent: [self errorProcessingSimulationTrap: aProcessorSimulationTrap in: simulatedTrampolines]. function := evaluable isBlock ifTrue: ['aBlock; probably some plugin primitive'] ifFalse: [evaluable receiver == backEnd ifTrue: "this is for invoking ARMv5 floating-point intrinsics, and for the short-cut tracing trampolines" [^self handleABICallOrJumpSimulationTrap: aProcessorSimulationTrap evaluable: evaluable]. evaluable selector]. memory := coInterpreter memory. function == #interpret ifTrue: "i.e. we're here via ceInvokeInterpret/ceReturnToInterpreterTrampoline and should discard all state back to enterSmalltalkExecutiveImplementation" [self recordInstruction: {'(simulated jump call of '. aProcessorSimulationTrap address. '/'. function. ')'}. "self halt: evaluable selector." clickConfirm ifTrue: [(self confirm: 'skip jump to interpret?') ifFalse: [clickConfirm := false. self halt]]. processor simulateJumpCallOf: aProcessorSimulationTrap address memory: memory. coInterpreter reenterInterpreter. "NOTREACHED" self halt]. invalidStackPointersExpected := false. function ~~ #ceBaseFrameReturn: ifTrue: [evaluable isBlock ifTrue: "external primitives..." ["The only acceptable exception to the rule are fast C primitive calls..." (methodZone cogMethodContaining: (self mostLikelyPrimInvocationPC: processor pc or: (processor leafRetpcIn: memory))) ifNil: [self assertf: 'call to block evaluable from non-external method'] ifNotNil: [:cogMethod| self assert: (self cogMethodHasExternalPrim: cogMethod). (coInterpreter hasFastCLinkage: cogMethod methodObject) ifTrue: [invalidStackPointersExpected := true. coInterpreter nilLocalFP] ifFalse: [coInterpreter assertValidExternalStackPointers]]] ifFalse: [coInterpreter assertValidExternalStackPointers]]. processor simulateCallOf: aProcessorSimulationTrap address nextpc: aProcessorSimulationTrap nextpc memory: memory. retpc := processor retpcIn: memory. self recordInstruction: {'(simulated call of '. aProcessorSimulationTrap address. '/'. function. ')'}. savedFramePointer := coInterpreter framePointer. savedStackPointer := coInterpreter stackPointer. savedArgumentCount := coInterpreter argumentCount. result := ["self halt: evaluable selector." clickConfirm ifTrue: [(self confirm: 'skip run-time call?') ifFalse: [clickConfirm := false. self halt]]. evaluable valueWithArguments: (processor postCallArgumentsNumArgs: evaluable numArgs in: memory)] on: ReenterMachineCode do: [:ex| ex return: #continueNoReturn]. invalidStackPointersExpected ifFalse: [coInterpreter assertValidExternalStackPointers]. "Verify the stack layout assumption compileInterpreterPrimitive: makes, provided we've not called something that has built a frame, such as closure value or evaluate method, or switched frames, such as primitiveSignal, primitiveWait, primitiveResume, primitiveSuspend et al." (function beginsWith: 'primitive') ifTrue: [coInterpreter primFailCode = 0 ifTrue: [(CogVMSimulator stackAlteringPrimitives includes: function) ifFalse: ["This is a rare case (e.g. in Scorch where a married context's sender is set to nil on trapTrpped and hence the stack layout is altered." (function == #primitiveSlotAtPut and: [objectMemory isContext: (coInterpreter frameReceiver: coInterpreter framePointer)]) ifFalse: [self assert: savedFramePointer = coInterpreter framePointer. self assert: savedStackPointer + (savedArgumentCount * objectMemory wordSize) = coInterpreter stackPointer]]] ifFalse: [self assert: savedFramePointer = coInterpreter framePointer. self assert: savedStackPointer = coInterpreter stackPointer]]. result ~~ #continueNoReturn ifTrue: [self recordInstruction: {'(simulated return to '. processor retpcIn: memory. ')'}. processor simulateReturnIn: memory. self assert: processor pc = retpc. processor smashCallerSavedRegistersWithValuesFrom: 16r80000000 by: objectMemory wordSize]. self assert: (result isInteger "an oop result" or: [result == coInterpreter or: [result == objectMemory + or: [(index := #(nil true false continueNoReturn) indexOf: result) > 0 + and: [result := #(0 1 0 16rF00BA4) at: index. true]]]]). - or: [#(nil true false continueNoReturn) includes: result]]]). processor cResultRegister: (result ifNil: [0] ifNotNil: [result isInteger ifTrue: [result] ifFalse: [16rF00BA222]])! Item was changed: ----- Method: InterpreterPrimitives>>primitiveCalloutToFFI (in category 'plugin primitives') ----- primitiveCalloutToFFI "Perform a function call to a foreign function. Only invoked from method containing explicit external call spec. Due to this we use the pluggable prim mechanism explicitly here (the first literal of any FFI spec'ed method is an ExternalFunction and not an array as used in the pluggable primitive mechanism)." <accessorDepth: 2> "Manually copied from primitiveCalloutAccessorDepth in the ThreadedFFIPlugins..." <var: #primitiveCallout declareC: 'void (*primitiveCallout)(void)'> self functionForPrimitiveCallout ifNil: [self primitiveFail] + ifNotNil: [:primitiveCallout| self dispatchFunctionPointer: primitiveCallout]! - ifNotNil: [:primitiveCallout| self perform: primitiveCallout]! Item was changed: ----- Method: SimpleStackBasedCogit>>compileOnStackExternalPrimitive: (in category 'primitive generators') ----- compileOnStackExternalPrimitive: primitiveRoutine "Compile a fast call of a C primitive using the current stack page, avoiding the stack switch except on failure. This convention still uses stackPointer and argumentCount to access operands. Push all operands to the stack, assign stackPointer, argumentCount, and zero primFailCode. Make the call (saving a LinkReg if required). Test for failure and return. On failure on Spur, if there is an accessor depth, assign framePointer and newMethod, do the stack switch, call checkForAndFollowForwardedPrimitiveState, and loop back if forwarders are found. Fall through to frame build." <var: #primitiveRoutine declareC: 'void (*primitiveRoutine)(void)'> | jmp retry calleeSavedReg | "Clear the primFailCode and set argumentCount" self MoveCq: 0 R: TempReg. self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. methodOrBlockNumArgs ~= 0 ifTrue: [self MoveCq: methodOrBlockNumArgs R: TempReg]. self MoveR: TempReg Aw: coInterpreter argumentCountAddress. self genExternalizeStackPointerForFastPrimitiveCall. backEnd hasLinkRegister ifTrue: [self PushR: LinkReg]. retry := self Label. calleeSavedReg := NoReg. (SPReg ~= NativeSPReg and: [(self isCalleeSavedReg: SPReg) not]) ifTrue: [calleeSavedReg := self availableRegisterOrNoneIn: ABICalleeSavedRegisterMask. self deny: calleeSavedReg = NoReg. self MoveR: SPReg R: calleeSavedReg]. self CallFullRT: primitiveRoutine. self MoveAw: coInterpreter primFailCodeAddress R: TempReg. calleeSavedReg ~= NoReg ifTrue: [self MoveR: calleeSavedReg R: SPReg]. self CmpCq: 0 R: TempReg. jmp := self JumpNonZero: 0. backEnd hasLinkRegister ifTrue: [self PopR: LinkReg] ifFalse: [self PopR: TempReg]. "i.e. save retpc" self MoveAw: coInterpreter stackPointerAddress R: SPReg. self PopR: ReceiverResultReg. backEnd hasLinkRegister ifFalse: [self PushR: TempReg]. "i.e. restore retpc" self RetN: 0. jmp jmpTarget: self Label. (objectRepresentation hasSpurMemoryManagerAPI and: [(coInterpreter accessorDepthForExternalPrimitiveMethod: methodObj) >= 0]) ifTrue: [| skip | "Given that following primitive state to the accessor depth is recursive, we're asking for trouble if we run the fixup on the Smalltalk stack page. Run it on the full C stack instead. This won't be a performance issue since primitive failure should be very rare." self MoveR: FPReg Aw: coInterpreter framePointerAddress. self MoveCw: primitiveRoutine asInteger R: TempReg. self MoveR: TempReg Aw: coInterpreter primitiveFunctionPointerAddress. self genLoadCStackPointersForPrimCall. methodLabel addDependent: (self annotateAbsolutePCRef: (self MoveCw: methodLabel asInteger R: ClassReg)). self MoveMw: (self offset: CogMethod of: #methodObject) r: ClassReg R: TempReg. self MoveR: TempReg Aw: coInterpreter newMethodAddress. self CallFullRT: (self cCode: [#checkForAndFollowForwardedPrimitiveState asUnsignedIntegerPtr] inSmalltalk: [self simulatedTrampolineFor: #checkForAndFollowForwardedPrimitiveState]). backEnd genLoadStackPointersForFastPrimCall: ClassReg. self CmpCq: 0 R: ABIResultReg. skip := self JumpZero: 0. self MoveCq: 0 R: TempReg. self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. self Jump: retry. skip jmpTarget: self Label]. + "Finally remember to reload ReceiverResultReg if required. Even if + arguments have been pushed, the prolog sequence assumes it is live." + (self register: ReceiverResultReg isInMask: ABICallerSavedRegisterMask) ifTrue: + [self MoveMw: (backEnd hasLinkRegister ifTrue: [methodOrBlockNumArgs] ifFalse: [methodOrBlockNumArgs + 1]) * objectMemory wordSize + r: SPReg + R: ReceiverResultReg]. ^0! Item was added: + ----- Method: ThreadedFFIPluginPartialSimulator class>>shouldBeTranslated (in category 'translation') ----- + shouldBeTranslated + ^false!

1 0

← Newer
1
2
3
4
5
6
7
8
...
18
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev July 2021