Vm-dev November 2021

vm-dev@lists.squeakfoundation.org

11 participants
54 discussions

[OpenSmalltalk/opensmalltalk-vm] UnixProcess forkSqueak broken since October (#548)
by David T Lewis 21 Dec '21

21 Dec '21

UnixProcess class>>forkSqueak is no longer working. The forked child process VM crashes with segmentation fault. Testing with VMs from bintray shows that version 5.0-202009300634 works, and any version 5.0-202010192227 or later fails. Stack dump sometimes (but not always) shows failure in aioPoll() for example: */usr/local/bin/../lib/squeak/5.0-202101160259/squeak(aioPoll+0x12e)[0x4bc0fe] I am not able to catch the failure in gdb because it happens in the child process. My initial guess is that it may be related to the epoll enhancements added in this time frame, because forking the VM requires initializing things like this in the new child VM process. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/548

4 9

[OpenSmalltalk/opensmalltalk-vm] "Failed to write image file" if stdin is closed at snapshot-and-quit time on Unix (Issue #607)
by Tony Garnock-Jones 01 Dec '21

01 Dec '21

## To reproduce 1. Open a fresh Squeak trunk image 2. doIt: ```smalltalk FileStream stdin close. Smalltalk snapshot: true andQuit: true. ``` ## Expected Image saves and quits. ## Actual Image fails to save, opens an error window with message `Failed to write image file (disk full?)`. ## Analysis - `writeImageFileIO` calls `sqImageFileOpen`. - `sqImageFileOpen` in `platforms/unix/vm/sqImageFileAccess.h` never observably fails to its caller - it calls `exit` if `open(2)` fails - `sqImageFileOpen` can perfectly reasonably hand back file descriptor zero for the new image file! If `FileStream stdin` has been closed, it will in fact do so. - If it does this, `writeImageFileIO` gets confused, because if the result of `sqImageFileOpen` is equal to `null`, it considers this a failure. This looks annoyingly Unix-specific, a result of punning raw fds as `sqImageFile` values. Other platforms use e.g. a `FILE*` instead of a raw fd, in which case even if fd 0 were to be opened under the covers, the corresponding `FILE*` would not be `null`. ## Appendix (not very useful): Full bug report from debugger 29 November 2021 4:32:57.802885 pm VM: unix - Smalltalk Image: Squeak6.0alpha [latest update: #20751] SecurityManager state: Restricted: false FileAccess: true SocketAccess: true Working Dir /tmp/squeaker-run-g38g7lcb Trusted Dir /tmp/squeaker-run-g38g7lcb/secure Untrusted Dir /tmp/squeaker-run-g38g7lcb/My Squeak SmalltalkImage(Object)>>error: Receiver: Smalltalk Arguments and temporary variables: aString: 'Failed to write image file (disk full?)' Receiver's instance variables: globals: Smalltalk SmalltalkImage>>snapshot:andQuit:withExitCode:embedded: Receiver: Smalltalk Arguments and temporary variables: save: true quit: true exitCode: nil embeddedFlag: false resuming: nil msg: '----QUIT----{29 November 2021 . 4:32:05 pm} squeak.image priorSource: 20637916...etc... Receiver's instance variables: globals: Smalltalk SmalltalkImage>>snapshot:andQuit:embedded: Receiver: Smalltalk Arguments and temporary variables: save: true quit: true embeddedFlag: false Receiver's instance variables: globals: Smalltalk SmalltalkImage>>snapshot:andQuit: Receiver: Smalltalk Arguments and temporary variables: save: true quit: true Receiver's instance variables: globals: Smalltalk UndefinedObject>>DoIt Receiver: nil Arguments and temporary variables: Receiver's instance variables: nil Compiler>>evaluateCue:ifFail: Receiver: a Compiler Arguments and temporary variables: aCue: a CompilationCue failBlock: [closure] in Compiler>>evaluateCue:ifFail:logged: methodNode: DoIt ^ Smalltalk snapshot: true andQuit: true method: (UndefinedObject>>#DoIt "a CompiledMethod(1015626)") value: nil Receiver's instance variables: parser: a Parser cue: a CompilationCue Compiler>>evaluateCue:ifFail:logged: Receiver: a Compiler Arguments and temporary variables: aCue: a CompilationCue failBlock: [closure] in [] in SmalltalkEditor(TextEditor)>>evaluateSelectionAndDo:...etc... logFlag: true value: nil Receiver's instance variables: parser: a Parser cue: a CompilationCue Compiler>>evaluate:in:to:environment:notifying:ifFail:logged: Receiver: a Compiler Arguments and temporary variables: textOrStream: a ReadStream aContext: nil receiver: nil anEnvironment: Smalltalk aRequestor: a SmalltalkEditor failBlock: [closure] in [] in SmalltalkEditor(TextEditor)>>evaluateSelectionAndDo:...etc... logFlag: true Receiver's instance variables: parser: a Parser cue: a CompilationCue [] in SmalltalkEditor(TextEditor)>>evaluateSelectionAndDo: Receiver: a SmalltalkEditor Arguments and temporary variables: aBlock: [closure] in SmalltalkEditor(TextEditor)>>evaluateSelection result: nil rcvr: nil ctxt: nil Receiver's instance variables: morph: a TextMorphForEditView(2236073) model: a Workspace paragraph: a NewParagraph markBlock: a CharacterBlock with index 1 and character $F and rectangle 3@0 cor...etc... pointBlock: a CharacterBlock with index 62 and rectangle 235@16 corner: 235@32 ...etc... beginTypeInIndex: nil emphasisHere: #() lastParenLocation: nil otherInterval: (49 to: 56) oldInterval: nil typeAhead: a WriteStream history: a TextEditorCommandHistory FullBlockClosure(BlockClosure)>>on:do: Receiver: [closure] in SmalltalkEditor(TextEditor)>>evaluateSelectionAndDo: Arguments and temporary variables: exceptionOrExceptionSet: OutOfScopeNotification handlerAction: [closure] in SmalltalkEditor(TextEditor)>>evaluateSelectionAndDo:...etc... handlerActive: true handlerRearmed: false Receiver's instance variables: outerContext: SmalltalkEditor(TextEditor)>>evaluateSelectionAndDo: startpcOrMethod: ([] in TextEditor>>#evaluateSelectionAndDo: "a CompiledBlock(1...etc... numArgs: 0 receiver: a SmalltalkEditor SmalltalkEditor(TextEditor)>>evaluateSelectionAndDo: Receiver: a SmalltalkEditor Arguments and temporary variables: aBlock: [closure] in SmalltalkEditor(TextEditor)>>evaluateSelection result: nil rcvr: nil ctxt: nil Receiver's instance variables: morph: a TextMorphForEditView(2236073) model: a Workspace paragraph: a NewParagraph markBlock: a CharacterBlock with index 1 and character $F and rectangle 3@0 cor...etc... pointBlock: a CharacterBlock with index 62 and rectangle 235@16 corner: 235@32 ...etc... beginTypeInIndex: nil emphasisHere: #() lastParenLocation: nil otherInterval: (49 to: 56) oldInterval: nil typeAhead: a WriteStream history: a TextEditorCommandHistory SmalltalkEditor(TextEditor)>>evaluateSelection Receiver: a SmalltalkEditor Arguments and temporary variables: Receiver's instance variables: morph: a TextMorphForEditView(2236073) model: a Workspace paragraph: a NewParagraph markBlock: a CharacterBlock with index 1 and character $F and rectangle 3@0 cor...etc... pointBlock: a CharacterBlock with index 62 and rectangle 235@16 corner: 235@32 ...etc... beginTypeInIndex: nil emphasisHere: #() lastParenLocation: nil otherInterval: (49 to: 56) oldInterval: nil typeAhead: a WriteStream history: a TextEditorCommandHistory SmalltalkEditor(TextEditor)>>doIt Receiver: a SmalltalkEditor Arguments and temporary variables: Receiver's instance variables: morph: a TextMorphForEditView(2236073) model: a Workspace paragraph: a NewParagraph markBlock: a CharacterBlock with index 1 and character $F and rectangle 3@0 cor...etc... pointBlock: a CharacterBlock with index 62 and rectangle 235@16 corner: 235@32 ...etc... beginTypeInIndex: nil emphasisHere: #() lastParenLocation: nil otherInterval: (49 to: 56) oldInterval: nil typeAhead: a WriteStream history: a TextEditorCommandHistory SmalltalkEditor(TextEditor)>>doIt: Receiver: a SmalltalkEditor Arguments and temporary variables: aKeyboardEvent: [140@92 keystroke '<Opt-Cmd-d>' (100) 12807] Receiver's instance variables: morph: a TextMorphForEditView(2236073) model: a Workspace paragraph: a NewParagraph markBlock: a CharacterBlock with index 1 and character $F and rectangle 3@0 cor...etc... pointBlock: a CharacterBlock with index 62 and rectangle 235@16 corner: 235@32 ...etc... beginTypeInIndex: nil emphasisHere: #() lastParenLocation: nil otherInterval: (49 to: 56) oldInterval: nil typeAhead: a WriteStream history: a TextEditorCommandHistory SmalltalkEditor(TextEditor)>>dispatchOnKeyboardEvent: Receiver: a SmalltalkEditor Arguments and temporary variables: aKeyboardEvent: [140@92 keystroke '<Opt-Cmd-d>' (100) 12807] honorCommandKeys: true typedChar: $d Receiver's instance variables: morph: a TextMorphForEditView(2236073) model: a Workspace paragraph: a NewParagraph markBlock: a CharacterBlock with index 1 and character $F and rectangle 3@0 cor...etc... pointBlock: a CharacterBlock with index 62 and rectangle 235@16 corner: 235@32 ...etc... beginTypeInIndex: nil emphasisHere: #() lastParenLocation: nil otherInterval: (49 to: 56) oldInterval: nil typeAhead: a WriteStream history: a TextEditorCommandHistory SmalltalkEditor(TextEditor)>>keyStroke: Receiver: a SmalltalkEditor Arguments and temporary variables: anEvent: [140@92 keystroke '<Opt-Cmd-d>' (100) 12807] Receiver's instance variables: morph: a TextMorphForEditView(2236073) model: a Workspace paragraph: a NewParagraph markBlock: a CharacterBlock with index 1 and character $F and rectangle 3@0 cor...etc... pointBlock: a CharacterBlock with index 62 and rectangle 235@16 corner: 235@32 ...etc... beginTypeInIndex: nil emphasisHere: #() lastParenLocation: nil otherInterval: (49 to: 56) oldInterval: nil typeAhead: a WriteStream history: a TextEditorCommandHistory [] in [] in TextMorphForEditView(TextMorph)>>keyStroke: Receiver: a TextMorphForEditView(2236073) Arguments and temporary variables: evt: [140@92 keystroke '<Opt-Cmd-d>' (100) 12807] action: nil Receiver's instance variables: bounds: 0@0 corner: 435@32 owner: a TransformMorph(3867971) submorphs: #() fullBounds: 0@0 corner: 435@32 color: Color black extension: a MorphExtension (3908410) [other: (unfocusedSelectionColor -> (Col...etc... borderWidth: 0 borderColor: Color black textStyle: a TextStyle Bitmap DejaVu Sans 9 text: a Text for 'FileStream stdin close Smalltalk snapshot: true andQuit: true...etc... wrapFlag: true paragraph: a NewParagraph editor: a SmalltalkEditor container: nil predecessor: nil successor: nil backgroundColor: nil margins: 3@0 corner: 0@0 readOnly: false autoFit: true editView: a PluggableTextMorphPlus(2181400) acceptOnCR: false TextMorphForEditView(TextMorph)>>handleInteraction:fromEvent: Receiver: a TextMorphForEditView(2236073) Arguments and temporary variables: interactionBlock: [closure] in [] in TextMorphForEditView(TextMorph)>>keyStroke:...etc... evt: [140@92 keystroke '<Opt-Cmd-d>' (100) 12807] oldEditor: a SmalltalkEditor oldParagraph: a NewParagraph oldText: a Text for 'FileStream stdin close Smalltalk save: true andQuit: true'...etc... oldSelection: {205@16 corner: 210@32} Receiver's instance variables: bounds: 0@0 corner: 435@32 owner: a TransformMorph(3867971) submorphs: #() fullBounds: 0@0 corner: 435@32 color: Color black extension: a MorphExtension (3908410) [other: (unfocusedSelectionColor -> (Col...etc... borderWidth: 0 borderColor: Color black textStyle: a TextStyle Bitmap DejaVu Sans 9 text: a Text for 'FileStream stdin close Smalltalk snapshot: true andQuit: true...etc... wrapFlag: true paragraph: a NewParagraph editor: a SmalltalkEditor container: nil predecessor: nil successor: nil backgroundColor: nil margins: 3@0 corner: 0@0 readOnly: false autoFit: true editView: a PluggableTextMorphPlus(2181400) acceptOnCR: false TextMorphForEditView>>handleInteraction:fromEvent: Receiver: a TextMorphForEditView(2236073) Arguments and temporary variables: interActionBlock: [closure] in [] in TextMorphForEditView(TextMorph)>>keyStroke:...etc... evt: [140@92 keystroke '<Opt-Cmd-d>' (100) 12807] Receiver's instance variables: bounds: 0@0 corner: 435@32 owner: a TransformMorph(3867971) submorphs: #() fullBounds: 0@0 corner: 435@32 color: Color black extension: a MorphExtension (3908410) [other: (unfocusedSelectionColor -> (Col...etc... borderWidth: 0 borderColor: Color black textStyle: a TextStyle Bitmap DejaVu Sans 9 text: a Text for 'FileStream stdin close Smalltalk snapshot: true andQuit: true...etc... wrapFlag: true paragraph: a NewParagraph editor: a SmalltalkEditor container: nil predecessor: nil successor: nil backgroundColor: nil margins: 3@0 corner: 0@0 readOnly: false autoFit: true editView: a PluggableTextMorphPlus(2181400) acceptOnCR: false --- The full stack --- SmalltalkImage(Object)>>error: SmalltalkImage>>snapshot:andQuit:withExitCode:embedded: SmalltalkImage>>snapshot:andQuit:embedded: SmalltalkImage>>snapshot:andQuit: UndefinedObject>>DoIt Compiler>>evaluateCue:ifFail: Compiler>>evaluateCue:ifFail:logged: Compiler>>evaluate:in:to:environment:notifying:ifFail:logged: [] in SmalltalkEditor(TextEditor)>>evaluateSelectionAndDo: FullBlockClosure(BlockClosure)>>on:do: SmalltalkEditor(TextEditor)>>evaluateSelectionAndDo: SmalltalkEditor(TextEditor)>>evaluateSelection SmalltalkEditor(TextEditor)>>doIt SmalltalkEditor(TextEditor)>>doIt: SmalltalkEditor(TextEditor)>>dispatchOnKeyboardEvent: SmalltalkEditor(TextEditor)>>keyStroke: [] in [] in TextMorphForEditView(TextMorph)>>keyStroke: TextMorphForEditView(TextMorph)>>handleInteraction:fromEvent: TextMorphForEditView>>handleInteraction:fromEvent: - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - [] in TextMorphForEditView(TextMorph)>>keyStroke: StandardToolSet class>>codeCompletionAround:textMorph:keyStroke: ToolSet class>>codeCompletionAround:textMorph:keyStroke: TextMorphForEditView(TextMorph)>>keyStroke: TextMorphForEditView>>keyStroke: TextMorphForEditView(Morph)>>handleKeystroke: TextMorphForEditView(TextMorph)>>handleKeystroke: KeyboardEvent>>sentTo: TextMorphForEditView(Morph)>>handleEvent: TextMorphForEditView(Morph)>>handleFocusEvent: MorphicEventDispatcher>>doHandlingForFocusEvent:with: MorphicEventDispatcher>>dispatchFocusEvent:with: TextMorphForEditView(Morph)>>processFocusEvent:using: TextMorphForEditView(Morph)>>processFocusEvent: [] in [] in [] in HandMorph>>sendFocusEvent:to:clear: [] in ActiveEventVariable class(DynamicVariable class)>>value:during: FullBlockClosure(BlockClosure)>>ensure: ActiveEventVariable class(DynamicVariable class)>>value:during: [] in ActiveEventVariable class>>value:during: FullBlockClosure(BlockClosure)>>ensure: ActiveEventVariable class>>value:during: KeyboardEvent(MorphicEvent)>>becomeActiveDuring: [] in [] in HandMorph>>sendFocusEvent:to:clear: [] in ActiveHandVariable class(DynamicVariable class)>>value:during: FullBlockClosure(BlockClosure)>>ensure: ActiveHandVariable class(DynamicVariable class)>>value:during: [] in ActiveHandVariable class>>value:during: FullBlockClosure(BlockClosure)>>ensure: ActiveHandVariable class>>value:during: HandMorph>>becomeActiveDuring: [] in HandMorph>>sendFocusEvent:to:clear: [] in ActiveWorldVariable class(DynamicVariable class)>>value:during: FullBlockClosure(BlockClosure)>>ensure: ActiveWorldVariable class(DynamicVariable class)>>value:during: [] in ActiveWorldVariable class>>value:during: FullBlockClosure(BlockClosure)>>ensure: ActiveWorldVariable class>>value:during: PasteUpMorph>>becomeActiveDuring: HandMorph>>sendFocusEvent:to:clear: HandMorph>>sendEvent:focus:clear: HandMorph>>sendKeyboardEvent: HandMorph>>handleEvent: -- and more not shown -- -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/607

2 4

[OpenSmalltalk/opensmalltalk-vm] vm-display-fbdev fixes to integrate (PR #606)
by Ken Dickey 01 Dec '21

01 Dec '21

ReMerged with current. Test OK on: - Raspberry Pi 4 / Alpine Linux (musl) - ami-s905x-cc (LePotato) / Armbian (libc) I submitted these fixes in a pull request some time ago when folks were busy. Perhaps integrate now? Thanks much! -KenD You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/606 -- Commit Summary -- * better framebuffer hookup * better help doc -- File Changes -- M platforms/unix/vm-display-fbdev/sqUnixEvdevKeyMouse.c (7) M platforms/unix/vm-display-fbdev/sqUnixFBDev.c (47) M platforms/unix/vm-display-fbdev/sqUnixFBDevFramebuffer.c (2) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/606.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/606.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/606

2 3

[OpenSmalltalk/opensmalltalk-vm] c3fd39: CogVM source as per VMMaker.oscog-eem.3114
by Eliot Miranda 01 Dec '21

01 Dec '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: c3fd39dab5a4a04a58e764a5390488ef935018bb https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c3fd39dab5a4a04a58… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-11-30 (Tue, 30 Nov 2021) Changed paths: M src/spur32.cog/cogit.h M src/spur32.cog/cogitARMv5.c M src/spur32.cog/cogitIA32.c M src/spur32.sista/cogit.h M src/spur32.sista/cogitARMv5.c M src/spur32.sista/cogitIA32.c M src/spur64.cog/cogit.h M src/spur64.cog/cogitARMv8.c M src/spur64.cog/cogitX64SysV.c M src/spur64.cog/cogitX64WIN64.c M src/spur64.sista/cogit.h M src/spur64.sista/cogitARMv8.c M src/spur64.sista/cogitX64SysV.c M src/spur64.sista/cogitX64WIN64.c M src/v3.cog/cogit.h M src/v3.cog/cogitARMv5.c M src/v3.cog/cogitIA32.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3114 Cogit: eliminate some C compiler warnings in the 64-bit cogits.

1 0

VM Maker: VMMaker.oscog-eem.3114.mcz
by commits＠source.squeak.org 30 Nov '21

30 Nov '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3114.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3114 Author: eem Time: 30 November 2021, 2:35:32.159341 pm UUID: 0522972d-531d-4f3a-9559-5c9bdbbf5427 Ancestors: VMMaker.oscog-eem.3113 Cogit: eliminate some C compiler warnings in the 64-bit cogits. =============== Diff against VMMaker.oscog-eem.3113 =============== Item was changed: ----- Method: CCodeGenerator>>returnTypeForSend:in:ifNil: (in category 'type inference') ----- returnTypeForSend: sendNode in: aTMethod ifNil: typeIfNil "Answer the return type for a send. Unbound sends default to typeIfNil. Methods with types as yet unknown have a type determined either by the kernelReturnTypes or the table below, or, if they are in neither set, then nil. The inferred type should match as closely as possible the C type of generated expessions so that inlining would not change the expression. If there is a method for sel but its return type is as yet unknown it mustn't be defaulted, since on a subsequent pass its type may be computable." | sel methodOrNil | methodOrNil := self anyMethodNamed: (sel := sendNode selector). (methodOrNil notNil and: [methodOrNil returnType notNil]) ifTrue: [^self baseTypeForType: methodOrNil returnType]. ^kernelReturnTypes at: sel ifAbsent: [sel caseOf: { [#integerValueOf:] -> [#sqInt]. [#isIntegerObject:] -> [#int]. [#negated] -> [self promoteArithmeticTypes: (sendNode receiver typeFrom: self in: aTMethod) and: #int]. [#+] -> [self typeForArithmetic: sendNode in: aTMethod]. [#-] -> [self typeForArithmetic: sendNode in: aTMethod]. [#*] -> [self typeForArithmetic: sendNode in: aTMethod]. [#/] -> [self typeForArithmetic: sendNode in: aTMethod]. [#//] -> [self typeForArithmetic: sendNode in: aTMethod]. [#\\] -> [self typeForArithmetic: sendNode in: aTMethod]. [#rem:] -> [self typeForArithmetic: sendNode in: aTMethod]. [#quo:] -> [self typeForArithmetic: sendNode in: aTMethod]. "C99 Sec Bitwise shift operators ... 3 Semantics ... The integer promotions are performed on each of the operands. The type of the result is that of the promoted left operand..." [#>>] -> [sendNode receiver typeFrom: self in: aTMethod]. [#<<] -> [(self isSignedIntegralCType: (sendNode receiver typeFrom: self in: aTMethod)) ifTrue: [#sqInt] ifFalse: [#usqInt]]. [#addressOf:] -> [(sendNode args first typeFrom: self in: aTMethod) ifNil: [#sqInt] ifNotNil: [:type| type, (type last isSeparator ifTrue: ['*'] ifFalse: [' *'])]]. [#addressOf:put:] -> [(sendNode args first typeFrom: self in: aTMethod) ifNil: [#sqInt] ifNotNil: [:type| type, (type last isSeparator ifTrue: ['*'] ifFalse: [' *'])]]. [#at:] -> [self typeForDereference: sendNode in: aTMethod]. [#bitAnd:] -> [self typeForArithmetic: sendNode in: aTMethod]. [#bitOr:] -> [self typeForArithmetic: sendNode in: aTMethod]. [#bitXor:] -> [self typeForArithmetic: sendNode in: aTMethod]. [#bitClear:] -> [self typeForArithmetic: sendNode in: aTMethod]. [#bitInvert32] -> [#'unsigned int']. [#bitInvert64] -> [self promoteArithmeticTypes: (sendNode receiver typeFrom: self in: aTMethod) and: #int]. [#byteSwap32] -> [#'unsigned int']. [#byteSwap64] -> [#'unsigned long long']. [#byteSwapped32IfBigEndian:] -> [#'unsigned int']. [#byteSwapped64IfBigEndian:] -> [#'unsigned long long']. [#=] -> [#int]. [#~=] -> [#int]. [#==] -> [#int]. [#~~] -> [#int]. [#<] -> [#int]. [#<=] -> [#int]. [#>] -> [#int]. [#>=] -> [#int]. [#between:and:] -> [#int]. [#anyMask:] -> [#int]. [#allMask:] -> [#int]. [#noMask:] -> [#int]. [#isNil] -> [#int]. [#notNil] -> [#int]. [#&] -> [#int]. [#|] -> [#int]. [#not] -> [#int]. [#asFloat] -> [#double]. [#atan] -> [#double]. [#exp] -> [#double]. [#log] -> [#double]. [#sin] -> [#double]. [#sqrt] -> [#double]. [#asLong] -> [#long]. [#asInteger] -> [#sqInt]. [#asIntegerPtr] -> [#'sqIntptr_t']. [#asUnsignedInteger] -> [#usqInt]. [#asUnsignedIntegerPtr]-> [#'usqIntptr_t']. [#asUnsignedLong] -> [#'unsigned long']. [#asUnsignedLongLong] -> [#'unsigned long long']. [#asVoidPointer] -> [#'void *']. + [#signedIntFromLong] -> [#int]. "c.f. generateSignedIntFromLong:on:indent:" + [#signedIntFromLong64] -> [#sqInt]. "c.f. generateSignedIntFromLong64:on:indent: N.B. not written to answer sqLong because only used in 64-bit realm" + [#signedIntToLong] -> [#usqInt]. "c.f. generateSignedIntToLong:on:indent:" + [#signedIntToLong64] -> [#usqInt]. "c.f. generateSignedIntToLong64:on:indent:" - [#signedIntToLong] -> [#usqInt]. "c.f. generateSignedIntToLong:on:indent:" [#signedIntToShort] -> [#usqInt]. "c.f. generateSignedIntToShort:on:indent:" [#cCoerce:to:] -> [self conventionalTypeForType: sendNode args last value]. [#cCoerceSimple:to:] -> [self conventionalTypeForType: sendNode args last value]. [#sizeof:] -> [#'usqIntptr_t']. "Technically it's a size_t but it matches on target architectures so far..." [#ifTrue:ifFalse:] -> [self typeForConditional: sendNode in: aTMethod]. [#ifFalse:ifTrue:] -> [self typeForConditional: sendNode in: aTMethod]. [#ifTrue:] -> [self typeForConditional: sendNode in: aTMethod]. [#ifFalse:] -> [self typeForConditional: sendNode in: aTMethod]. [#and:] -> [#sqInt]. [#or:] -> [#sqInt]. [#caseOf:] -> [self typeFor: sendNode args first in: aTMethod] } otherwise: "If there /is/ a method for sel but its return type is as yet unknown it /mustn't/ be defaulted, since on a subsequent pass its type may be computable. Only default unbound selectors." [methodOrNil ifNotNil: [nil] ifNil: [typeIfNil]]]! Item was changed: ----- Method: Cogit>>markLiteralsAndUnlinkIfUnmarkedSend:pc:method: (in category 'garbage collection') ----- markLiteralsAndUnlinkIfUnmarkedSend: annotation pc: mcpc method: cogMethod "Mark and trace literals. Unlink sends that have unmarked cache tags or targets." <var: #mcpc type: #'char *'> + <var: #cogMethod type: #'CogMethod *'> - <var: #nsSendCache type: #'NSSendCache *'> | literal | + <var: #nsSendCache type: #'NSSendCache *'> annotation = IsObjectReference ifTrue: [literal := literalsManager fetchLiteralAtAnnotatedAddress: mcpc asUnsignedInteger using: backEnd. (objectRepresentation markAndTraceLiteral: literal in: (self cCoerceSimple: cogMethod to: #'CogMethod *') atpc: mcpc asUnsignedInteger) ifTrue: [codeModified := true]]. NewspeakVM ifTrue: [annotation = IsNSSendCall ifTrue: [| nsSendCache entryPoint targetMethod sel eo | nsSendCache := self nsSendCacheFromReturnAddress: mcpc asInteger. entryPoint := nsSendCache target. entryPoint ~= 0 ifTrue: "Send is linked" [targetMethod := self cCoerceSimple: entryPoint - cmNoCheckEntryOffset to: #'CogMethod *'. (self markAndTraceOrFreeCogMethod: targetMethod firstVisit: targetMethod asUnsignedInteger > mcpc asUnsignedInteger) ifTrue: [self voidNSSendCache: nsSendCache]]. sel := nsSendCache selector. (objectMemory isForwarded: sel) ifFalse: [objectMemory markAndTrace: sel] ifTrue: [sel := objectMemory followForwarded: literal. nsSendCache selector: sel. self markAndTraceUpdatedLiteral: sel in: (self cCoerceSimple: cogMethod to: #'CogMethod *')]. eo := nsSendCache enclosingObject. eo ~= 0 ifTrue: [(objectMemory isForwarded: eo) ifFalse: [objectMemory markAndTrace: eo] ifTrue: [eo := objectMemory followForwarded: literal. nsSendCache enclosingObject: eo. self markAndTraceUpdatedLiteral: eo in: (self cCoerceSimple: cogMethod to: #'CogMethod *')]]]]. (self isPureSendAnnotation: annotation) ifTrue: [self entryCacheTagAndCouldBeObjectAt: mcpc annotation: annotation into: [:entryPoint :cacheTag :tagCouldBeObj | | cacheTagMarked | cacheTagMarked := tagCouldBeObj and: [objectRepresentation cacheTagIsMarked: cacheTag]. entryPoint > methodZoneBase ifTrue: "It's a linked send." [self targetMethodAndSendTableFor: entryPoint annotation: annotation into: [:targetMethod :sendTable| (cacheTagMarked not or: [self markAndTraceOrFreeCogMethod: targetMethod firstVisit: targetMethod asUnsignedInteger > mcpc asUnsignedInteger]) ifTrue: ["Either the cacheTag is unmarked (e.g. new class) or the target has been freed (because it is unmarked), so unlink the send." self unlinkSendAt: mcpc targetMethod: targetMethod sendTable: sendTable. objectRepresentation markAndTraceLiteral: targetMethod selector in: targetMethod at: (self addressOf: targetMethod selector put: [:val| targetMethod selector: val])]]] ifFalse: "cacheTag is selector" [(objectRepresentation markAndTraceCacheTagLiteral: cacheTag in: (self cCoerceSimple: cogMethod to: #'CogMethod *') atpc: mcpc asUnsignedInteger) ifTrue: [codeModified := true]]]]. ^0 "keep scanning"! Item was changed: ----- Method: Cogit>>unlinkIfLinkedSend:pc:to: (in category 'in-line cacheing') ----- unlinkIfLinkedSend: annotation pc: mcpc to: theCogMethod <var: #mcpc type: #'char *'> + <var: #theCogMethod type: #'CogMethod *'> - <var: #nsSendCache type: #'NSSendCache *'> | entryPoint | + <var: #nsSendCache type: #'NSSendCache *'> NewspeakVM ifTrue: [| nsSendCache | annotation = IsNSSendCall ifTrue: + [nsSendCache := self nsSendCacheFromReturnAddress: mcpc. - [nsSendCache := self nsSendCacheFromReturnAddress: mcpc asInteger. (entryPoint := nsSendCache target) ~= 0 ifTrue: [ | targetMethod | targetMethod := entryPoint - cmNoCheckEntryOffset. + targetMethod = theCogMethod asInteger ifTrue: - targetMethod = theCogMethod ifTrue: [self voidNSSendCache: nsSendCache]]. ^0 "keep scanning"]]. (self isPureSendAnnotation: annotation) ifTrue: [entryPoint := backEnd callTargetFromReturnAddress: mcpc asInteger. entryPoint > methodZoneBase ifTrue: "It's a linked send." [self targetMethodAndSendTableFor: entryPoint annotation: annotation into: [:targetMethod :sendTable| + targetMethod = theCogMethod ifTrue: - targetMethod asInteger = theCogMethod ifTrue: [self unlinkSendAt: mcpc targetMethod: targetMethod sendTable: sendTable]]]]. ^0 "keep scanning"!

1 0

[OpenSmalltalk/opensmalltalk-vm] 9777fb: CogVM source as per VMMaker.oscog-eem.3113
by Eliot Miranda 30 Nov '21

30 Nov '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 9777fbfe0a822d63798d114e5bab8c9f76d94eaf https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9777fbfe0a822d6379… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-11-30 (Tue, 30 Nov 2021) Changed paths: M platforms/Cross/vm/sqImageFileAccessViaStdio.h M platforms/Mac OS/vm/sqPlatformSpecific.h M platforms/minheadless/common/sqImageFileAccessViaStdio.h M platforms/minheadless/unix/sqImageFileAccess.h M platforms/minheadless/windows/sqImageFileAccess.h M platforms/unix/vm/sqImageFileAccess.h M platforms/win32/vm/sqImageFileAccess.h M src/spur32.cog.lowcode/cointerp.c M src/spur32.cog.lowcode/cointerp.h M src/spur32.cog.lowcode/gcc3x-cointerp.c M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/cointerpmt.c M src/spur32.cog/cointerpmt.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.cog/gcc3x-cointerpmt.c M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur32.stack.lowcode/gcc3x-interp.c M src/spur32.stack.lowcode/interp.c M src/spur32.stack/gcc3x-interp.c M src/spur32.stack/interp.c M src/spur32.stack/validImage.c M src/spur64.cog.lowcode/cointerp.c M src/spur64.cog.lowcode/cointerp.h M src/spur64.cog.lowcode/gcc3x-cointerp.c M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/cointerpmt.c M src/spur64.cog/cointerpmt.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c M src/spur64.stack.lowcode/gcc3x-interp.c M src/spur64.stack.lowcode/interp.c M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c M src/spur64.stack/validImage.c M src/v3.cog/cointerp.c M src/v3.cog/cointerp.h M src/v3.cog/gcc3x-cointerp.c M src/v3.stack/gcc3x-interp.c M src/v3.stack/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3113 Image file i/o. Check result of sqImageFile:Open: with invalidSqImageFile:, instead of assming nill is the invalid value. This should address opensmalltalk-vm Issue #607. StackInterpreter: Implement printing suspended processes in printAllStacks by searching the heap for all processes (including subinstances) waiting on other than a linked list. Hence nuke ClassMutex which specifies a slot in the specialObjectsArray which has never been used in production. CoInterpreterMT: Override to printAllStacks also print the awol processes

1 0

VM Maker: VMMaker.oscog-eem.3113.mcz
by commits＠source.squeak.org 30 Nov '21

30 Nov '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3113.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3113 Author: eem Time: 30 November 2021, 10:36:54.041773 am UUID: 1c9b844a-96a5-4864-a115-b66fe2de890b Ancestors: VMMaker.oscog-eem.3112 CoInterpreterMT: add missing doNotGenerate to a simulation method. =============== Diff against VMMaker.oscog-eem.3112 =============== Item was changed: ----- Method: CogThreadManager>>vmThreadForCurrentProcess (in category 'simulation') ----- vmThreadForCurrentProcess + <doNotGenerate> | thisProcess | thisProcess := Processor activeProcess. ^threads detect: [:t| t osThread = thisProcess] !

1 0

VM Maker: VMMaker.oscog-eem.3112.mcz
by commits＠source.squeak.org 30 Nov '21

30 Nov '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3112.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3112 Author: eem Time: 30 November 2021, 10:14:30.520037 am UUID: 3e7ff69c-fd43-4366-836f-2349427152f0 Ancestors: VMMaker.oscog-eem.3111 Image file i/o. Check result of sqImageFile:Open: with invalidSqImageFile:, instead of assming nill is the invalid value. This allows unix to write images to stdout. =============== Diff against VMMaker.oscog-eem.3111 =============== Item was changed: ----- Method: StackInterpreter>>dumpImage: (in category 'image save/restore') ----- dumpImage: fileName "Dump the entire image out to the given file. Intended for debugging only. Doesn't work for Spur." <notOption: #SpurObjectMemory> <export: true> + | f result | + <var: 'f' type: #sqImageFile> - <var: #f type: #sqImageFile> + f := self sqImageFile: (self pointerForOop: fileName) Open: 'wb'. + (self invalidSqImageFile: f) + ifTrue: [^-1] + ifFalse: + [result := self sq: (self pointerForOop: objectMemory startOfMemory) - (self sqImageFile: (self pointerForOop: fileName) Open: 'wb') - ifNil: [^-1] - ifNotNil: - [:f| | result | - result := self sq: (self pointerForOop: objectMemory startOfMemory) Image: (self sizeof: #'unsigned char') File: objectMemory endOfMemory - objectMemory startOfMemory Write: f. self sqImageFileClose: f. ^result]! Item was changed: ----- Method: StackInterpreter>>writeImageFileIO (in category 'image save/restore') ----- writeImageFileIO "Write the image header and heap contents to imageFile for snapshot. c.f. writeImageFileIOSimulation. The game below is to maintain 64-bit alignment for all putLong:toFile: occurrences." <inline: #never> | imageName headerStart headerSize f imageBytes bytesWritten sCWIfn okToWrite | + <var: 'f' type: #sqImageFile> + <var: 'headerStart' type: #squeakFileOffsetType> + <var: 'sCWIfn' type: #'void *'> + <var: 'imageName' declareC: 'extern char imageName[]'> - <var: #f type: #sqImageFile> - <var: #headerStart type: #squeakFileOffsetType> - <var: #sCWIfn type: #'void *'> - <var: #imageName declareC: 'extern char imageName[]'> self cCode: [] inSmalltalk: [imageName := 'sooth compiler'. ^self writeImageFileIOSimulation]. "If the security plugin can be loaded, use it to check for write permission. If not, assume it's ok" sCWIfn := self ioLoadFunction: 'secCanWriteImage' From: 'SecurityPlugin'. sCWIfn ~= 0 ifTrue: [okToWrite := self cCode: '((sqInt (*)(void))sCWIfn)()'. okToWrite ifFalse:[^self primitiveFail]]. + - "local constants" headerStart := 0. + headerSize := objectMemory wordSize * 16. "64 or 128; header size in bytes; do not change!!" - headerSize := objectMemory wordSize = 4 ifTrue: [64] ifFalse: [128]. "header size in bytes; do not change!!" f := self sqImageFile: imageName Open: 'wb'. + (self invalidSqImageFile: f) ifTrue: "could not open the image file for writing" + [^self primitiveFailFor: PrimErrOperationFailed]. - f = nil ifTrue: "could not open the image file for writing" - [^self primitiveFail]. imageBytes := objectMemory imageSizeToWrite. headerStart := self sqImage: f File: imageName StartLocation: headerSize + imageBytes. self cCode: '/* Note: on Unix systems one could put an exec command here, padded to 512 bytes */'. "position file to start of header" self sqImageFile: f Seek: headerStart. self putWord32: self imageFormatVersion toFile: f. self putWord32: headerSize toFile: f. self putLong: imageBytes toFile: f. self putLong: objectMemory baseAddressOfImage toFile: f. self putLong: objectMemory specialObjectsOop toFile: f. self putLong: objectMemory newObjectHash toFile: f. self putLong: self getSnapshotScreenSize toFile: f. self putLong: self getImageHeaderFlags toFile: f. self putWord32: extraVMMemory toFile: f. self putShort: desiredNumStackPages toFile: f. self putShort: self unknownShortOrCodeSizeInKs toFile: f. self putWord32: desiredEdenBytes toFile: f. self putShort: (maxExtSemTabSizeSet ifTrue: [self ioGetMaxExtSemTableSize] ifFalse: [0]) toFile: f. self putShort: the2ndUnknownShort toFile: f. objectMemory hasSpurMemoryManagerAPI ifTrue: [self putLong: objectMemory firstSegmentBytes toFile: f. self putLong: objectMemory bytesLeftInOldSpace toFile: f. 2 timesRepeat: [self putLong: 0 toFile: f] "Pad the rest of the header."] ifFalse: [4 timesRepeat: [self putLong: 0 toFile: f]]. "Pad the rest of the header." objectMemory wordSize = 8 ifTrue: [3 timesRepeat: [self putLong: 0 toFile: f]]. "Pad the rest of the header." self assert: headerStart + headerSize = (self sqImageFilePosition: f). "position file after the header" self sqImageFile: f Seek: headerStart + headerSize. self successful ifFalse: "file write or seek failure" [self sqImageFileClose: f. ^nil]. "write the image data" objectMemory hasSpurMemoryManagerAPI ifTrue: [bytesWritten := objectMemory writeImageSegmentsToFile: f] ifFalse: [bytesWritten := self sq: (self pointerForOop: objectMemory baseAddressOfImage) Image: (self sizeof: #char) File: imageBytes Write: f]. self success: bytesWritten = imageBytes. self sqImageFileClose: f! Item was changed: ----- Method: StackInterpreter>>writeImageFileIOSimulation (in category 'image save/restore') ----- writeImageFileIOSimulation "Write the image header and heap contents to imageFile for snapshot. c.f. writeImageFileIO. The game below is to maintain 64-bit alignment for all putLong:toFile: occurrences." <doNotGenerate> | headerSize file | + headerSize := objectMemory wordSize * 16. - headerSize := objectMemory wordSize = 4 ifTrue: [64] ifFalse: [128]. (file := FileStream fileNamed: self imageName) ifNil: [self primitiveFail. ^nil]. [file binary. self putWord32: self imageFormatVersion toFile: file. self putWord32: headerSize toFile: file. { objectMemory imageSizeToWrite. objectMemory baseAddressOfImage. objectMemory specialObjectsOop. objectMemory lastHash. self ioScreenSize. self getImageHeaderFlags } do: [:long | self putLong: long toFile: file]. self putWord32: (extraVMMemory ifNil: [0]) toFile: file. { desiredNumStackPages. self unknownShortOrCodeSizeInKs } do: [:short| self putShort: short toFile: file]. self putWord32: desiredEdenBytes toFile: file. { maxExtSemTabSizeSet ifTrue: [self ioGetMaxExtSemTableSize] ifFalse: [0]. 0 } do: [:short| self putShort: short toFile: file]. objectMemory hasSpurMemoryManagerAPI ifTrue: [| bytesWritten | self putLong: objectMemory firstSegmentBytes toFile: file. self putLong: objectMemory bytesLeftInOldSpace toFile: file. 2 timesRepeat: [self putLong: 0 toFile: file] "Pad the rest of the header.". objectMemory wordSize = 8 ifTrue: [3 timesRepeat: [self putLong: 0 toFile: file]]. self assert: file position = headerSize. + - "Position the file after the header." - file position: headerSize. bytesWritten := objectMemory writeImageSegmentsToFile: file. self assert: bytesWritten = objectMemory imageSizeToWrite] ifFalse: ["Pad the rest of the header." 4 timesRepeat: [self putLong: 0 toFile: file]. objectMemory wordSize = 8 ifTrue: [3 timesRepeat: [self putLong: 0 toFile: file]]. self assert: file position = headerSize. - "Position the file after the header." - file position: headerSize. "Write the object memory." + file + next: objectMemory imageSizeToWrite // objectMemory memory bytesPerElement + putAll: objectMemory memory + startingAt: objectMemory baseAddressOfImage // objectMemory memory bytesPerElement]. - objectMemory baseAddressOfImage // 4 + 1 - to: objectMemory baseAddressOfImage + objectMemory imageSizeToWrite // 4 - do: [:index | - self - putLong: (objectMemory memory at: index) - toFile: file]]. file truncate: file position. self success: true] ensure: [file ifNotNil: [file close]]!

1 0

[OpenSmalltalk/opensmalltalk-vm] 822d5d: Add (autoconf/configure) check for libevdev. Insta...
by Marcel Taeumel 30 Nov '21

30 Nov '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 822d5db0e620a80a14ce3a6d97bf015c96399e8d https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/822d5db0e620a80a14… Author: Marcel Taeumel <marcel.taeumel(a)hpi.de> Date: 2021-11-30 (Tue, 30 Nov 2021) Changed paths: M platforms/unix/config/config.h.in M platforms/unix/config/configure M platforms/unix/vm-display-fbdev/acinclude.m4 M scripts/ci/actions_prepare_linux_x86.sh Log Message: ----------- Add (autoconf/configure) check for libevdev. Install libevdev for Linux(x86) on CI.

1 0

Re: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] better help doc (3154c7f)
by Marcel Taeumel 30 Nov '21

30 Nov '21

Why did you toggle the default here? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3154c7f473ab017ede…

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev November 2021