Vm-dev May 2020

vm-dev@lists.squeakfoundation.org

39 participants
130 discussions

[OpenSmalltalk/opensmalltalk-vm] Fix checkSCCSversion invocation in mvm scripts of linux build subdirectories (#405)
by Tim Johnson 20 Oct '20

20 Oct '20

Currently the `mvm` scripts within Linux build directories are failing to properly invoke `checkSCCSversion` because their those directories are nested three levels deep rather than two (as in other platforms). To fix, update all `mvm` scripts within three-level nested linux build directories to invoke `../../../scripts/checkSCCSversion` rather than `../../scripts/checkSCCSversion` I believe this can be accomplished by executing the following one-liner from the repo root: ``` for f in $(find . -name mvm -exec grep -q checkSCCS {} \; -print | awk -F/ 'NF == 5 { print $0 }') ; do printf "g/checkSCCSversion/s/\.\.\//&\.\.\//\nw\nq" | ed ${f} ; done ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/405

2 1

[OpenSmalltalk/opensmalltalk-vm] primitiveFileSize fails on Stdio handles (#430)
by Fabio Niephaus 20 Oct '20

20 Oct '20

`FileStream stdout closed` returns `true` in a currently Squeak trunk image. The reason for this is that the `primitiveFileSize` fails. To be fair, it makes sense as `stdout` does not really have a size. Nonetheless, it does not make sense that Squeak thinks `stdout` is closed, especially when it really isn't. On SqueakJS, for example, the primitive returns `0` which lets `FileStream stdout closed` return `false`. I'm not sure where to fix this, probably in the `FilePlugin` code of VMMaker? Could someone please take a look? Thanks! See also: http://forum.world.st/FileStream-stdout-closed-td5105395.html -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/430

2 2

[OpenSmalltalk/opensmalltalk-vm] Metal crash on Mac (#467)
by Aliaksei Syrel 20 Oct '20

20 Oct '20

Once the image is saved with an external screen attached it can not be opened again with that external screen disconnected: ``` Segmentation fault Mon Jan 6 14:45:41 2020 VM: 201911282316 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Thu Nov 28 15:16:31 2019 CommitHash: 4710c5a Plugins: 201911282316 https://github.com/OpenSmalltalk/opensmalltalk-vm.git C stack backtrace & registers: rax 0x0000000000000000 rbx 0x0000000000000000 rcx 0x0000000000002800 rdx 0x00007fff2b4adb00 rdi 0x0000004110a2b400 rsi 0x00000002238ea538 rbp 0x00007ffee80666b0 rsp 0x00007ffee8066698 r8 0x0000000000000008 r9 0x0000000000000571 r10 0x0000000000000a00 r11 0x0000000000000000 r12 0x0000000000000000 r13 0x0000000000000000 r14 0x0000000000000008 r15 0x0000000000000000 rip 0x00007fff2b401f95 0 AMDMTLBronzeDriver 0x00007fff2b401f95 _ZL30amdMtlBronzeWritePixelByPixel2PvS_PA8_Khjjjj + 44 1 Pharo 0x0000000107bf5ee1 reportStackState + 818 2 Pharo 0x0000000107bf6235 sigsegv + 195 3 libsystem_platform.dylib 0x00007fff6e22db1d _sigtramp + 29 4 ??? 0x0000000000000000 0x0 + 0 5 AMDMTLBronzeDriver 0x00007fff2b400aec _ZL25bronzePartialTileCallbackyjjjPv + 180 6 AMDMTLBronzeDriver 0x00007fff2b3feb6d _Z34BronzeGenerateMicroTileAddresses2DPK24BronzeCpuTexInterfaceRecPK21ATIMipmapBufferHeaderjjjjjjjPFvyjjjPvES5_ + 1210 7 AMDMTLBronzeDriver 0x00007fff2b3ff695 _ZL35amdMtlBronzeTextureStdReplacePixelsPK24BronzeCpuTexInterfaceRecPK21ATIMipmapBufferHeaderPK18ati_si_format_infomjmmjjjjj + 288 8 AMDMTLBronzeDriver 0x00007fff2b3ff095 _ZL34amdMtlBronzeTextureStdAccessRegionPK24BronzeCpuTexInterfaceRecPFvS1_PK21ATIMipmapBufferHeaderPK18ati_si_format_infomjmmjjjjjES9_S4_S7_mjmmjjjjj + 645 9 AMDMTLBronzeDriver 0x00007fff2b3ff3f9 _Z35amdMtlBronzeTextureStdReplaceRegionPK24BronzeCpuTexInterfaceRecPK21ATIMipmapBufferHeaderPK18ati_si_format_infoPvjmmjjjjj + 286 10 AMDMTLBronzeDriver 0x00007fff2b42af52 -[BronzeMtlTexture replaceRegion:mipmapLevel:withBytes:bytesPerRow:] + 578 11 Pharo 0x0000000107bec0b0 -[sqSqueakOSXMetalView loadTexturesFrom:subRectangle:] + 437 12 Pharo 0x0000000107bebc81 -[sqSqueakOSXMetalView drawRect:] + 159 13 MetalKit 0x00007fff3c01b86b -[MTKView draw] + 159 14 Pharo 0x0000000107beb5a2 -[sqSqueakOSXMetalView drawThelayers] + 67 15 Pharo 0x0000000107bf7e9d -[sqSqueakScreenAndWindow ioForceDisplayUpdate] + 188 16 Pharo 0x0000000107bf7b92 ioForceDisplayUpdate + 61 17 Pharo 0x0000000107ba021a primitiveShowDisplayRect + 206 18 Pharo 0x0000000107b6a23c interpret + 17024 19 Pharo 0x0000000107b72aa6 enterSmalltalkExecutiveImplementation + 149 20 Pharo 0x0000000107b66232 interpret + 630 21 Pharo 0x0000000107bf7648 -[sqSqueakMainApplication runSqueak] + 393 22 Foundation 0x00007fff392f01cb __NSFirePerformWithOrder + 360 23 CoreFoundation 0x00007fff36ba566e __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23 24 CoreFoundation 0x00007fff36ba5594 __CFRunLoopDoObservers + 457 25 CoreFoundation 0x00007fff36b4872b __CFRunLoopRun + 1219 26 CoreFoundation 0x00007fff36b47fe3 CFRunLoopRunSpecific + 499 27 HIToolbox 0x00007fff356cf67d RunCurrentEventLoopInMode + 292 28 HIToolbox 0x00007fff356cf2c9 ReceiveNextEventCommon + 356 29 HIToolbox 0x00007fff356cf147 _BlockUntilNextEventMatchingListInModeWithFilter + 64 30 AppKit 0x00007fff33d54864 _DPSNextEvent + 990 31 AppKit 0x00007fff33d535d4 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1352 32 AppKit 0x00007fff33d4dd76 -[NSApplication run] + 658 33 AppKit 0x00007fff33d3f95d NSApplicationMain + 777 34 libdyld.dylib 0x00007fff6e02c2e5 start + 1 35 ??? 0x0000000000000002 0x0 + 2 Smalltalk stack dump: 0x7ffee806bb20 I DisplayScreen>forceToScreen: 0x11580f4c0: a(n) DisplayScreen 0x7ffee806bb58 M [] in DisplayScreen>forceDamageToScreen: 0x11580f4c0: a(n) DisplayScreen 0x7ffee806bba0 M OrderedCollection>do: 0x114de0080: a(n) OrderedCollection 0x7ffee806bbf8 I DisplayScreen>forceDamageToScreen: 0x11580f4c0: a(n) DisplayScreen 0x7ffee806bc40 I VMWorldRenderer>forceDamageToScreen: 0x114a28f18: a(n) VMWorldRenderer 0x7ffee806bc90 M VMWorldRenderer>displayWorldState:ofWorld:submorphs: 0x114a28f18: a(n) VMWorldRenderer 0x7ffee806bce8 I WorldState>displayWorld:submorphs: 0x1158d6a60: a(n) WorldState 0x7ffee806bd38 I WorldMorph>displayWorld 0x1158cab48: a(n) WorldMorph 0x7ffee806bd90 I TaskbarMorph(Morph)>snapToEdgeIfAppropriate 0x115e9a7f0: a(n) TaskbarMorph 0x7ffee806bdd0 I TaskbarMorph>updateBounds 0x115e9a7f0: a(n) TaskbarMorph 0x7ffee8068928 I TaskbarMorph>displayExtentChanged 0x115e9a7f0: a(n) TaskbarMorph 0x7ffee8068958 M [] in VMWorldRenderer(AbstractWorldRenderer)>restoreMorphicDisplay 0x114a28f18: a(n) VMWorldRenderer 0x7ffee80689a0 M Array(SequenceableCollection)>do: 0x122cff900: a(n) Array 0x7ffee80689e8 I WorldMorph(Morph)>submorphsDo: 0x1158cab48: a(n) WorldMorph 0x7ffee8068a38 I VMWorldRenderer(AbstractWorldRenderer)>restoreMorphicDisplay 0x114a28f18: a(n) VMWorldRenderer 0x7ffee8068a78 I WorldMorph>restoreMorphicDisplay 0x1158cab48: a(n) WorldMorph 0x7ffee8068ac0 I MorphicUIManager>activate 0x114a28f08: a(n) MorphicUIManager 0x7ffee8068b08 I UIManager class>default: 0x1151cc508: a(n) UIManager class 0x7ffee8068b40 M UIManagerSessionHandler>startup: 0x1155b2618: a(n) UIManagerSessionHandler 0x7ffee8068b80 M [] in WorkingSession>runStartup: 0x114a28000: a(n) WorkingSession 0x7ffee8068bc8 M [] in WorkingSession>runList:do: 0x114a28000: a(n) WorkingSession 0x7ffee8068bf8 M BlockClosure>on:do: 0x114a3d618: a(n) BlockClosure 0x7ffee8068c40 M [] in WorkingSession>runList:do: 0x114a28000: a(n) WorkingSession 0x7ffee8068c88 M Array(SequenceableCollection)>do: 0x114a3d748: a(n) Array 0x7ffee8068cd0 I WorkingSession>runList:do: 0x114a28000: a(n) WorkingSession 0x7ffee8068d20 I WorkingSession>runStartup: 0x114a28000: a(n) WorkingSession 0x7ffee8068d68 I WorkingSession>start: 0x114a28000: a(n) WorkingSession 0x7ffee8068dc0 I SessionManager>launchSnapshot:andQuit: 0x11523de78: a(n) SessionManager 0x123935448 s [] in SessionManager>snapshot:andQuit: 0x123936578 s [] in BlockClosure>newProcess ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/467

2 2

[OpenSmalltalk/opensmalltalk-vm] Unable to build OSVM on macOS Catalina (#470)
by Fabio Niephaus 20 Oct '20

20 Oct '20

#### Steps to reproduce: ```bash cd build.macos64x64/squeak.cog.spur make debug ``` #### Errors ``` /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSArray.h:109:12: error: attributes may not be specified on a category @interface NSArray<ObjectType> (NSArrayDiffing) ^ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSArray.h:196:12: error: attributes may not be specified on a category @interface NSMutableArray<ObjectType> (NSMutableArrayDiffing) ^ In file included from <built-in>:1: In file included from ./../../platforms/iOS/vm/SqueakPureObjc_Prefix.pch:12: In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:12: In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:48: In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSKeyValueCoding.h:8: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSOrderedSet.h:112:12: error: attributes may not be specified on a category @interface NSOrderedSet<ObjectType> (NSOrderedSetDiffing) ^ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSOrderedSet.h:187:12: error: attributes may not be specified on a category @interface NSMutableOrderedSet<ObjectType> (NSMutableOrderedSetDiffing) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/470

3 2

[OpenSmalltalk/opensmalltalk-vm] ArmV6 crash on start. (#487)
by KrzysztofJeszke 20 Oct '20

20 Oct '20

I downloaded squeak 5.3 image fresh from the site (32-bit) and tried to run it in this vm on a Rpi Zero W. Crash.dmp outputs``` Segmentation fault Mon Apr 20 21:39:41 2020 /home/pi/squeak/lib/squeak/5.0-202003021730/squeak Squeak VM version: 5.0-202003021730 Tue Mar 3 09:42:45 UTC 2020 gcc 4.9.2 [Production Spur VM] Built from: CoInterpreter VMMaker.oscog-nice.2712 uuid: da64ef0b-fb0a-4770-ac16-f9b448234615 Mar 3 2020 With: StackToRegisterMappingCogit VMMaker.oscog-eem.2719 uuid: e40f3e94-3a54-411b-9613-5d19114ea131 Mar 3 2020 Revision: VM: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Mon Mar 2 18:30:55 2020 CommitHash: 6a0bc96 Plugins: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Build host: Linux travis-job-97835d24-79f4-41d1-b7e9-c81bd8bf7149 4.4.0-104-generic #127~14.04.1-Ubuntu SMP Mon Dec 11 12:44:15 UTC 2017 armv7l GNU/Linux plugin path: ./../lib/squeak/5.0-202003021730 [default: /home/pi/squeak/lib/squeak/5.0-202003021730/] C stack backtrace & registers: r0 0x021b79d8 r1 0x00000002 r2 0x01000d34 r3 0x00000000 r4 0x00216288 r5 0x00000000 r6 0xbeec682c r7 0x0379170b r8 0x001e7414 r9 0x0021e268 r10 0x00000000 fp 0xbeec489c ip 0x00224250 sp 0xbeec4810 lr 0x000748b4 pc 0x0007055c *[0x0] /lib/arm-linux-gnueabihf/libc.so.6(vsprintf+0x80)[0xb6cee228] Smalltalk stack dump: 0xbeec6860 I SmalltalkImage>setGCParameters 0x233a9d0: a(n) SmalltalkImage 0xbeec6888 I SmalltalkImage>snapshot:andQuit:withExitCode:embedded: 0x233a9d0: a(n) SmalltalkImage 0x47d16d0 s SmalltalkImage>snapshot:andQuit:embedded: 0x47d26f8 s SmalltalkImage>snapshot:andQuit: 0x47d27b8 s [] in ReleaseBuilder class>saveAndQuit 0x47d2890 s WorldState>runStepMethodsIn: 0x47d2920 s PasteUpMorph>runStepMethods 0x47d29f0 s WorldState>doOneCycleNowFor: 0x47d2a50 s WorldState>doOneCycleFor: 0x47d2ac0 s PasteUpMorph>doOneCycle 0x47d2b20 s [] in MorphicProject>spawnNewProcess 0x47d2b80 s [] in BlockClosure>newProcess Most recent primitives basicNew size at: basicNew: decompress:fromByteArray:at: beCursorWithMask: vmParameterAt: fractionPart truncated stack page bytes 4096 available headroom 2788 minimum unused headroom 3740 (Segmentation fault) Segmentation fault Mon Apr 20 21:41:26 2020 /home/pi/squeak/lib/squeak/5.0-202003021730/squeak Squeak VM version: 5.0-202003021730 Tue Mar 3 09:42:45 UTC 2020 gcc 4.9.2 [Production Spur VM] Built from: CoInterpreter VMMaker.oscog-nice.2712 uuid: da64ef0b-fb0a-4770-ac16-f9b448234615 Mar 3 2020 With: StackToRegisterMappingCogit VMMaker.oscog-eem.2719 uuid: e40f3e94-3a54-411b-9613-5d19114ea131 Mar 3 2020 Revision: VM: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Mon Mar 2 18:30:55 2020 CommitHash: 6a0bc96 Plugins: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Build host: Linux travis-job-97835d24-79f4-41d1-b7e9-c81bd8bf7149 4.4.0-104-generic #127~14.04.1-Ubuntu SMP Mon Dec 11 12:44:15 UTC 2017 armv7l GNU/Linux plugin path: ./../lib/squeak/5.0-202003021730 [default: /home/pi/squeak/lib/squeak/5.0-202003021730/] C stack backtrace & registers: r0 0x00000000 r1 0x00000dcd r2 0x00216288 r3 0x00b04c70 r4 0x00216288 r5 0x00000000 r6 0xbeaf382c r7 0x00224250 r8 0x001e7414 r9 0x00000000 r10 0x00216288 fp 0xbeaf189c ip 0x00224250 sp 0xbeaf17e0 lr 0x0006ae84 pc 0x0004c4bc *[0x0] /lib/arm-linux-gnueabihf/libc.so.6(vsprintf+0x80)[0xb6c6e228] Smalltalk stack dump: 0xbeaf3860 I SmalltalkImage>setGCParameters 0xe3a9d0: a(n) SmalltalkImage 0xbeaf3888 I SmalltalkImage>snapshot:andQuit:withExitCode:embedded: 0xe3a9d0: a(n) SmalltalkImage 0x32d16d0 s SmalltalkImage>snapshot:andQuit:embedded: 0x32d26f8 s SmalltalkImage>snapshot:andQuit: 0x32d27b8 s [] in ReleaseBuilder class>saveAndQuit 0x32d2890 s WorldState>runStepMethodsIn: 0x32d2920 s PasteUpMorph>runStepMethods 0x32d29f0 s WorldState>doOneCycleNowFor: 0x32d2a50 s WorldState>doOneCycleFor: 0x32d2ac0 s PasteUpMorph>doOneCycle 0x32d2b20 s [] in MorphicProject>spawnNewProcess 0x32d2b80 s [] in BlockClosure>newProcess Most recent primitives basicNew size at: basicNew: decompress:fromByteArray:at: beCursorWithMask: vmParameterAt: fractionPart truncated stack page bytes 4096 available headroom 2788 minimum unused headroom 3740 (Segmentation fault) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/487

3 3

[OpenSmalltalk/opensmalltalk-vm] Latest commit segfaults win64x64.squeak.cog.spur (#498)
by Marcel Taeumel 20 Oct '20

20 Oct '20

ee89a4dad04442463252b6a368a8ba373288a774 Trying to load a 64-bit image, the VM segfaults in gcc3x-cointerp.c line 2809 `memset(theStackMemory, 0, stackPagesBytes);` Other win64x64 targets might be affected. I tested both a custom build and bintray version: https://bintray.com/opensmalltalk/vm/download_file?file_path=squeak.cog.spu… -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/498

3 4

[OpenSmalltalk/opensmalltalk-vm] Bump minimal supported Windows version to Windows 8 (0x0602). (#499)
by Marcel Taeumel 19 Oct '20

19 Oct '20

Also fixes a minor issue in MSVC Makefile for 64x64, which tried 0x0801 for Windows 8 and 0x1001 for Windows 10. The latter would actually be 0x0A00. See https://docs.microsoft.com/de-de/cpp/porting/modifying-winver-and-win32-win… Also in the Makefile for 64x64, define both _WIN32 and _WIN64. See https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros Also in the Makefile for 64x64, define both WIN32 and WIN64 because those can be used to identify the Windows platform in application code such as in processors/IA32/bochs. I am not aware of any #ifdef WIN64 at the moment. Most code uses #ifdef _WIN64 to check for that. Note that, having defined both _WIN32 and _WIN64, code for 32-bit and 64-bit must always begin with #ifdef _WIN64 and only then #elif _WIN32. I think that the MSVC compiler defines _WIN32 and _WIN64 automatically. Yet, now it is documented in the Makefile. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499 -- Commit Summary -- * Bump minimal supported Windows version to Windows 8 (0x0602). -- File Changes -- M build.win32x86/common/Makefile.msvc.tools (7) M build.win32x86/common/Makefile.tools (9) M build.win64x64/common/Makefile.msvc.tools (8) M build.win64x64/common/Makefile.tools (7) M platforms/win32/vm/sqWin32.h (41) M platforms/win32/vm/sqWin32Main.c (77) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499

4 8

[OpenSmalltalk/opensmalltalk-vm] unix: use dlopen's lookup mechanism when not specifying a path (#497)
by Tom Beckmann 19 Oct '20

19 Oct '20

This allows FFI modules to be specified in the same manner as you would when linking to them (-lGL --> GL, instead of /usr/lib/x86_64-linux-gnu/libGL.so as was required before this change, unless you manually placed /usr/lib/x86_64-linux-gnu in your LD_LIBRARY_PATH). I don't know whether this will have unintended consequences for some use cases, since a lot of different systems end up calling this function. I tested the change for a while on Ubuntu 20.04 with no odd behavior occurring (but instead finally being able to load FFI modules without providing an absolute path or changing my LD_LIBRARY_PATH manually). Some more insights on why this was necessary: We have a long list of different ways of resolving a module. Among those is looking through the directories in the LD_LIBRARY_PATH envvar, which however only contains those directories I manually added, not all that ldconfig would consider. In our list of directories, we were already passing an empty string once, which would do nothing unless an absolute path was given, since we only proceed to look up a library if the given path is a valid directory. Providing `dlopen` with just a library name, without any path information, however, allows it to look through all directories as configured in ldconfig. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/497 -- Commit Summary -- * unix: use dlopen's lookup mechanism when not specifying a path -- File Changes -- M platforms/unix/vm/sqUnixExternalPrims.c (17) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/497.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/497.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/497

3 9

[OpenSmalltalk/opensmalltalk-vm] Customization for Pharo & About Dialog (#388)
by Pablo Tesone 19 Oct '20

19 Oct '20

- We added customization for Pharo to allow a different menu to be used. - We modified the default action of help menu to open an URL (only for Pharo) - We added a Info.plist property with the string value of the URL (only for Pharo) - And also the about dialog was not receiving the close event, we have fixed that. It was related with the filtering of events for SDL. @demarey You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388 -- Commit Summary -- * Adding a custom Menu for Pharo VMs * Adding a optional URL for the help, only fr Pharo * Handling correctly the events of the about window * Making the about window property as weak. -- File Changes -- M build.macos32x86/common/Makefile.app (8) M build.macos32x86/pharo.cog.spur.lowcode/Makefile (3) M build.macos32x86/pharo.cog.spur.minheadless/Makefile (2) M build.macos32x86/pharo.cog.spur/Makefile (1) M build.macos32x86/pharo.cog.spur/plugins.ext (2) M build.macos32x86/pharo.cog.v3/Makefile (2) M build.macos32x86/pharo.sista.spur/Makefile (2) M build.macos32x86/pharo.stack.spur.lowcode/Makefile (2) M build.macos32x86/pharo.stack.spur/Makefile (2) M build.macos64x64/common/Makefile.app (8) M build.macos64x64/pharo.cog.spur.lowcode/Makefile (1) M build.macos64x64/pharo.cog.spur/Makefile (1) M build.macos64x64/pharo.sista.spur/Makefile (1) M build.macos64x64/pharo.stack.spur.lowcode/Makefile (1) M build.macos64x64/pharo.stack.spur/Makefile (1) A platforms/iOS/vm/English.lproj/Pharo-MainMenu-opengl.xib (1261) A platforms/iOS/vm/English.lproj/Pharo-MainMenu.xib (1261) M platforms/iOS/vm/OSX/Pharo-Info.plist (2) M platforms/iOS/vm/OSX/SqueakOSXApplication.m (30) M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (16) M platforms/iOS/vm/OSX/sqSqueakOSXApplication.h (5) M platforms/iOS/vm/OSX/sqSqueakOSXApplication.m (1) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388

7 12

[OpenSmalltalk/opensmalltalk-vm] Removes support for NO_VIRTUAL_MEMORY on win32 platform (#504)
by Marcel Taeumel 19 Oct '20

19 Oct '20

You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/504 -- Commit Summary -- * Removes support for NO_VIRTUAL_MEMORY on win32 platform -- File Changes -- M platforms/win32/vm/sqWin32.h (1) M platforms/win32/vm/sqWin32Alloc.c (4) M platforms/win32/vm/sqWin32Alloc.h (3) M platforms/win32/vm/sqWin32Main.c (15) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/504.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/504.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/504

3 2

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev May 2020