Vm-dev February 2020

vm-dev@lists.squeakfoundation.org

25 participants
189 discussions

A new ready-to-crash image is available
by Stéphane Rollandin 09 Feb '20

09 Feb '20

Hello, I made up a fairly repeatable way to crash the Squeak3D plugin again. Just evaluate the doIt proposed in the image at: http://www.zogotounga.net/swap/crashlab4.zip Things go wrong about every other time on my system, sometimes with a crash dump (one is featured in the archive), sometimes silently. You will have to way about 20 seconds for the animation to reach the critical point (when it stops, but sometimes before). BTW this animation also features a number of glitches - it would be nice to fix that too, but this is another topic. Stef

2 8

Build failed: opensmalltalk-vm 1.0.54
by AppVeyor 09 Feb '20

09 Feb '20

1 0

[OpenSmalltalk/opensmalltalk-vm] 811c32: Try and restore the lowcode capability to return i...
by Nicolas Cellier 09 Feb '20

09 Feb '20

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 811c326986a1e933ac4b9998dd7532c650eb0128 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/811c326986a1e933ac… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2020-02-09 (Sun, 09 Feb 2020) Changed paths: M spurlowcodesrc/vm/cogitARMv5.c M spurlowcodesrc/vm/cogitIA32.c M spurlowcodesrc/vm/cogitMIPSEL.c Log Message: ----------- Try and restore the lowcode capability to return int64 result on various 32bits ABI. The ABIResultRegHigh needs to be defined. *** Hack *** Do not entirely take the regenerated lowcode source from VMMaker.oscog-nice.2709. As there are other changes pending, this may break something else. Instead, just cherry pick the minimal change from the generated code with the goal to let CI pass. We could obtain the exact same result by patching VMMaker.oscog-eem.2705, but this is overkill for a temporary.

1 0

VM Maker: VMMaker.oscog-nice.2709.mcz
by commits＠source.squeak.org 09 Feb '20

09 Feb '20

Nicolas Cellier uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-nice.2709.mcz ==================== Summary ==================== Name: VMMaker.oscog-nice.2709 Author: nice Time: 9 February 2020, 5:50:24.025123 pm UUID: 32c7be71-4aa0-4cda-8ca7-d1a604236b6e Ancestors: VMMaker.oscog-eem.2708 Try and restore the lowcode capability to return int64 result on various 32bits ABI. The ABIResultRegHigh needs to be defined. =============== Diff against VMMaker.oscog-eem.2708 =============== Item was changed: ----- Method: CogARMCompiler class>>initializeAbstractRegisters (in category 'class initialization') ----- initializeAbstractRegisters "Assign the abstract registers with the identities/indices of the relevant concrete registers." TempReg := R0. ClassReg := R2. ReceiverResultReg := R5. SendNumArgsReg := R6. SPReg := SP. "a.k.a. R13" self assert: SP = 13. FPReg := R11. Arg0Reg := R3. "overlaps with last C arg reg" Arg1Reg := R4. Extra0Reg := R7. Extra1Reg := R8. Extra2Reg := R9. VarBaseReg := R10. "Must be callee saved" self assert: ConcreteVarBaseReg = R10. RISCTempReg := R12. "a.k.a. IP" self assert: ConcreteIPReg = R12. LinkReg := LR. "R14" PCReg := PC. "R15" "According to IHI0042E ARM Architecture Procedure Calling Standard, in section 5.1.1: A subroutine must preserve the contents of the registers r4-r8, r10, r11 and SP (and r9 in PCS variants that designate r9 as v6). SP = r13, so the callee-saved regs are r4-r8 & r10-r12. The caller-saved registers are those that are not callee-saved and not reserved for hardware/abi uses, i..e r0-r3, r9 & r12. We exclude registers 0 & 1 (TempReg/CArg0Reg & CArg1Reg) from the CallerSavedRegisterMask because we only use them for argument passing and so never want to save and restore them. In fact restoring TempReg/CArg0Reg would overwrite function results, so it shouldn't be included under any circumstances." ABICalleeSavedRegisterMask := self registerMaskFor: 4 and: 5 and: 6 and: 7 and: 10 and: 11. ABICallerSavedRegisterMask := self registerMaskFor: 0 and: 1 and: 2 and: 3 and: 9 and: 12. CallerSavedRegisterMask := ABICallerSavedRegisterMask bitAnd: (self registerMaskFor: ClassReg and: ReceiverResultReg and: SendNumArgsReg and: Arg0Reg and: Arg1Reg). + ABIResultRegHigh := R1. NumRegisters := 16. DPFPReg0 := D0. DPFPReg1 := D1. DPFPReg2 := D2. DPFPReg3 := D3. DPFPReg4 := D4. DPFPReg5 := D5. DPFPReg6 := D6. DPFPReg7 := D7. NumFloatRegisters := 8! Item was changed: ----- Method: CogIA32Compiler class>>initializeAbstractRegisters (in category 'class initialization') ----- initializeAbstractRegisters "Assign the abstract registers with the identities/indices of the relevant concrete registers." "N.B. EAX ECX & EDX are caller-save (scratch) registers. Hence we use ECX for class and EDX for receiver/result since these are written in all normal sends. EBX ESI & EDI are callee-save." TempReg := EAX. ClassReg := ECX. ReceiverResultReg := EDX. SendNumArgsReg := EBX. SPReg := ESP. FPReg := EBP. Arg0Reg := ESI. Arg1Reg := EDI. ABICalleeSavedRegisterMask := self registerMaskFor: EBX and: ESI and: EDI. ABICallerSavedRegisterMask := self registerMaskFor: EAX and: ECX and: EDX. CallerSavedRegisterMask := ABICallerSavedRegisterMask bitAnd: (self registerMaskFor: ClassReg and: ReceiverResultReg and: SendNumArgsReg and: Arg0Reg and: Arg1Reg). + ABIResultRegHigh := EDX. NumRegisters := 8. DPFPReg0 := XMM0L. DPFPReg1 := XMM1L. DPFPReg2 := XMM2L. DPFPReg3 := XMM3L. DPFPReg4 := XMM4L. DPFPReg5 := XMM5L. DPFPReg6 := XMM6L. DPFPReg7 := XMM7L. NumFloatRegisters := 8! Item was changed: ----- Method: CogMIPSELCompiler class>>initializeAbstractRegisters (in category 'class initialization') ----- initializeAbstractRegisters "Assign the abstract registers with the identities/indices of the relevant concrete registers." "See MIPSConstants>>initializeRegisters for a description of the C ABI." "Note we can fit all of the abstract registers in C preserved registers, and not need to save or restore them at runtime calls." ReceiverResultReg := S0. Arg0Reg := S1. Arg1Reg := S2. ClassReg := S3. SendNumArgsReg := S4. TempReg := S5. VarBaseReg := S6. "Must be callee saved" SPReg := SP. FPReg := FP. RISCTempReg := AT. LinkReg := RA. self flag: #OABI. "see e.g. http://refspecs.linuxbase.org/elf/mipsabi.pdf" ABICalleeSavedRegisterMask := self registerMaskFor: S0 and: S1 and: S2 and: S3 and: S4 and: S5 and: S6 and: S7. ABICallerSavedRegisterMask := self registerMaskFor: T0 and: T1 and: T2 and: T3 and: T4 and: T5 and: T6 and: T7 and: T8 and: T9. CallerSavedRegisterMask := ABICallerSavedRegisterMask bitAnd: (self registerMaskFor: ClassReg and: ReceiverResultReg and: SendNumArgsReg and: Arg0Reg and: Arg1Reg). ABIResultReg := V0. + ABIResultRegHigh := V1. NumRegisters := 32. self flag: #todo. "Extra0Reg := ??. Extra1Reg := ??. Extra2Reg := ??. Extra3Reg := ??. Extra4Reg := ??. Extra5Reg := ??. Extra6Reg := ??. Extra7Reg := ??." self flag: #todo. "DPFPReg0 := ??. DPFPReg1 := ??. DPFPReg2 := ??. DPFPReg3 := ??. DPFPReg4 := ??. DPFPReg5 := ??. DPFPReg6 := ??. DPFPReg7 := ??. DPFPReg8 := ??. DPFPReg9 := ??. DPFPReg10 := ??. DPFPReg11 := ??. DPFPReg12 := ??. DPFPReg13 := ??. DPFPReg14 := ??. DPFPReg15 := ??"!

1 0

Errored: OpenSmalltalk/opensmalltalk-vm#1943 (Cog - 36a1f1e)
by Travis CI 09 Feb '20

09 Feb '20

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1943 Status: Errored Duration: 56 mins and 25 secs Commit: 36a1f1e (Cog) Author: Nicolas Cellier Message: Workaround a Squeak3D crash After proper instrumentation, it appears that a reproducible crash case provided by Stephane Rollandin is due to attempt of removing a face which is not in the fillList. This happens in the special case when `leftEdge == lastIntersection`, and the code attempts to remove `leftEdge->rightFace` which seem to not always be on the fillList. It's not obvious to understand if this is really an invariant of the loop, or a wrong expectation. Thus, as a workaround, protect the removal by a preliminary inclusion test. Note that removing or adding a face should change its `B3D_FACE_ACTIVE` flags. Normally, we remove then add, so do not have to toggle the flag. But if we do not remove, then we must toggle, otherwise another invariant will break and cause crash in `b3dToggleTopFills`. View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/015d381da7b5...36… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/648005026?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

Build failed: opensmalltalk-vm 1.0.53
by AppVeyor 09 Feb '20

09 Feb '20

1 0

[OpenSmalltalk/opensmalltalk-vm] 81d30f: Respect the tab indentation style rather than spac...
by Nicolas Cellier 09 Feb '20

09 Feb '20

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 81d30f5033605022b493d7fc8725dee30f97b46c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/81d30f5033605022b4… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2020-02-09 (Sun, 09 Feb 2020) Changed paths: M platforms/Cross/plugins/Squeak3D/b3dMain.c Log Message: ----------- Respect the tab indentation style rather than space indent Commit: 2ec508a718ca5a00e205c5e0356499ef27d6a87e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2ec508a718ca5a00e2… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2020-02-09 (Sun, 09 Feb 2020) Changed paths: M platforms/Cross/plugins/Squeak3D/b3dMain.c Log Message: ----------- Instrument the Squeak3D fill list operations with additional consistency checks Removing a face which is absent from the fill list will break the fill list. Indeed, fill list is a doubly linked list, and remove function is reconnecting prevFace and nextFace of removed face. But if this face has already been removed, we reuse dangling prevFace/nextFace and break the linked list... Same for adding: if the face was already on the list, we ignore the prevFace/nextFace links and thus break the fill list too. Note that this change just instrument, not fix. Commit: 3a0e796dd122fb8f7eb16a11bc1f83d6ab78a10c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3a0e796dd122fb8f7e… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2020-02-09 (Sun, 09 Feb 2020) Changed paths: M platforms/Cross/plugins/Squeak3D/b3dMain.c Log Message: ----------- Squeak3D fillList: nullify the prevFace/nextFace chain of removed face This is not a proper fix, just fool-proofing. Commit: 36a1f1e2ef637347ed3b81a2f4cf8df347e4d803 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/36a1f1e2ef637347ed… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2020-02-09 (Sun, 09 Feb 2020) Changed paths: M platforms/Cross/plugins/Squeak3D/b3dMain.c Log Message: ----------- Workaround a Squeak3D crash After proper instrumentation, it appears that a reproducible crash case provided by Stephane Rollandin is due to attempt of removing a face which is not in the fillList. This happens in the special case when `leftEdge == lastIntersection`, and the code attempts to remove `leftEdge->rightFace` which seem to not always be on the fillList. It's not obvious to understand if this is really an invariant of the loop, or a wrong expectation. Thus, as a workaround, protect the removal by a preliminary inclusion test. Note that removing or adding a face should change its `B3D_FACE_ACTIVE` flags. Normally, we remove then add, so do not have to toggle the flag. But if we do not remove, then we must toggle, otherwise another invariant will break and cause crash in `b3dToggleTopFills`. Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/015d381da7b5...36…

1 0

Errored: OpenSmalltalk/opensmalltalk-vm#1942 (Cog - 015d381)
by Travis CI 09 Feb '20

09 Feb '20

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1942 Status: Errored Duration: 1 hr, 55 mins, and 26 secs Commit: 015d381 (Cog) Author: Nicolas Cellier Message: Fix some Squeak3D UB: shifting left some negative int A reproducible case of crash provided by Stephane Rollandin gives the following warning with clang `-fsanitize=undefined`: >../../platforms/Cross/plugins/Squeak3D/b3dMain.c:1252:29: runtime error: left shift of negative value -760 >../../platforms/Cross/plugins/Squeak3D/b3dMain.c:1254:25: runtime error: left shift of negative value -751 >../../platforms/Cross/plugins/Squeak3D/b3dDraw.c:317:33: runtime error: left shift of negative value -802 >../../platforms/Cross/plugins/Squeak3D/b3dDraw.c:318:33: runtime error: left shift of negative value -802 >../../platforms/Cross/plugins/Squeak3D/b3dDraw.c:316:33: runtime error: left shift of negative value -114 >../../platforms/Cross/plugins/Squeak3D/b3dMain.c:829:61: runtime error: left shift of negative value -2 On OSX optimized VM, a crash happens in b3dMain.c, in function b3dAddBackFill at line 994 soon after those warnings By protecting the shift with (unsigned) cast, this particular crash disappear. There is still other crash happening related to bad fill list, but one thing at a time... View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/0f974af6a09c...01… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/647839209?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

Build failed: opensmalltalk-vm 1.0.52
by AppVeyor 08 Feb '20

08 Feb '20

1 0

[OpenSmalltalk/opensmalltalk-vm] 015d38: Fix some Squeak3D UB: shifting left some negative int
by Nicolas Cellier 08 Feb '20

08 Feb '20

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 015d381da7b553f0add8aa53b3f72014b16f5c82 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/015d381da7b553f0ad… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2020-02-08 (Sat, 08 Feb 2020) Changed paths: M platforms/Cross/plugins/Squeak3D/b3dDraw.c M platforms/Cross/plugins/Squeak3D/b3dMain.c Log Message: ----------- Fix some Squeak3D UB: shifting left some negative int A reproducible case of crash provided by Stephane Rollandin gives the following warning with clang `-fsanitize=undefined`: >../../platforms/Cross/plugins/Squeak3D/b3dMain.c:1252:29: runtime error: left shift of negative value -760 >../../platforms/Cross/plugins/Squeak3D/b3dMain.c:1254:25: runtime error: left shift of negative value -751 >../../platforms/Cross/plugins/Squeak3D/b3dDraw.c:317:33: runtime error: left shift of negative value -802 >../../platforms/Cross/plugins/Squeak3D/b3dDraw.c:318:33: runtime error: left shift of negative value -802 >../../platforms/Cross/plugins/Squeak3D/b3dDraw.c:316:33: runtime error: left shift of negative value -114 >../../platforms/Cross/plugins/Squeak3D/b3dMain.c:829:61: runtime error: left shift of negative value -2 On OSX optimized VM, a crash happens in b3dMain.c, in function b3dAddBackFill at line 994 soon after those warnings By protecting the shift with (unsigned) cast, this particular crash disappear. There is still other crash happening related to bad fill list, but one thing at a time...

1 0

← Newer
1
...
11
12
13
14
15
16
17
18
19
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev February 2020