Vm-dev January 2020

vm-dev@lists.squeakfoundation.org

35 participants
236 discussions

VM Maker: VMMaker.oscog-eem.2651.mcz
by commits＠source.squeak.org 09 Jan '20

09 Jan '20

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2651.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2651 Author: eem Time: 8 January 2020, 7:52:21.345726 pm UUID: ffd7613e-36d3-4c9c-bf23-524af81cd1e9 Ancestors: VMMaker.oscog-eem.2650 Cogit: Fix old bug in ARM32 LoadEffectiveAddressMwrR Improve the ARM32 trampoline marshalling code fractionally. =============== Diff against VMMaker.oscog-eem.2650 =============== Item was changed: ----- Method: CogARMCompiler>>concretizeLoadEffectiveAddressMwrR (in category 'generate machine code - concretize') ----- concretizeLoadEffectiveAddressMwrR "Will get inlined into concretizeAt: switch." + "destReg = srcReg + offset, but does not need to set condition codes, etc" - "destReg = srcReg (which contains an address) + offset" <inline: true> | srcReg offset destReg instrOffset | offset := operands at: 0. srcReg := operands at: 1. destReg := operands at: 2. ^self rotateable8bitImmediate: offset ifTrue: [ :rot :immediate | self machineCodeAt: 0 "add destReg, srcReg, #immediate ROR rot" + put: (self add: destReg rn: srcReg imm: immediate ror: rot). - put: (self add: destReg rn: srcReg imm: immediate ror: rot<<1). 4] ifFalse: [instrOffset := self moveCw: offset intoR: ConcreteIPReg. "add destReg, srcReg, ConcreteIPReg" self machineCodeAt: 16 put: (self add: destReg rn: srcReg rm: ConcreteIPReg). + instrOffset + 4] + + "cogit processor disassembleInstructionAt: 0 In: machineCode object"! - instrOffset + 4]! Item was changed: ----- Method: CogARMCompiler>>genMarshallNArgs:arg:arg:arg:arg: (in category 'abi') ----- genMarshallNArgs: numArgs arg: regOrConst0 arg: regOrConst1 arg: regOrConst2 arg: regOrConst3 "Generate the code to pass up to four arguments in a C run-time call. Hack: each argument is either a negative number, which encodes a constant, or a non-negative number, that of a register. Run-time calls have no more than four arguments, so chosen so that on ARM, where in its C ABI the first four integer arguments are passed in registers, all arguments can be passed in registers. We defer to the back end to generate this code not so much that the back end knows whether it uses the stack or registers to pass arguments (it does, but...). In fact we defer for an extremely evil reason. Doing so allows the x64 (where up to 6 args are passed) to assign the register arguments in an order that allows some of the argument registers to be used for specific abstract registers, specifically ReceiverResultReg and ClassReg. This is evil, evil, evil, but also it's really nice to keep using the old register assignments the original author has grown accustomed to." <inline: true> numArgs = 0 ifTrue: [^self]. "Avoid arg regs being overwritten before they are read." numArgs > 1 ifTrue: [((cogit isTrampolineArgConstant: regOrConst1) not and: [regOrConst1 = CArg0Reg]) ifTrue: [cogit MoveR: regOrConst1 R: Extra0Reg. ^self genMarshallNArgs: numArgs arg: regOrConst0 arg: Extra0Reg arg: regOrConst2 arg: regOrConst3]. numArgs > 2 ifTrue: [((cogit isTrampolineArgConstant: regOrConst2) not and: [regOrConst2 = CArg0Reg or: [regOrConst2 = CArg1Reg]]) ifTrue: [cogit MoveR: regOrConst2 R: Extra1Reg. ^self genMarshallNArgs: numArgs arg: regOrConst0 arg: regOrConst1 arg: Extra1Reg arg: regOrConst3]. numArgs > 3 ifTrue: [((cogit isTrampolineArgConstant: regOrConst3) not and: [regOrConst3 = CArg0Reg or: [regOrConst3 = CArg1Reg or: [regOrConst3 = CArg2Reg]]]) ifTrue: [cogit MoveR: regOrConst3 R: Extra2Reg. ^self genMarshallNArgs: numArgs arg: regOrConst0 arg: regOrConst1 arg: regOrConst2 arg: Extra2Reg]]]]. (cogit isTrampolineArgConstant: regOrConst0) ifTrue: [cogit MoveCq: (cogit trampolineArgValue: regOrConst0) R: CArg0Reg] + ifFalse: [regOrConst0 ~= CArg0Reg ifTrue: [cogit MoveR: regOrConst0 R: CArg0Reg]]. - ifFalse: [cogit MoveR: regOrConst0 R: CArg0Reg]. numArgs = 1 ifTrue: [^self]. (cogit isTrampolineArgConstant: regOrConst1) ifTrue: [cogit MoveCq: (cogit trampolineArgValue: regOrConst1) R: CArg1Reg] + ifFalse: [regOrConst1 ~= CArg1Reg ifTrue: [cogit MoveR: regOrConst1 R: CArg1Reg]]. - ifFalse: [cogit MoveR: regOrConst1 R: CArg1Reg]. numArgs = 2 ifTrue: [^self]. (cogit isTrampolineArgConstant: regOrConst2) ifTrue: [cogit MoveCq: (cogit trampolineArgValue: regOrConst2) R: CArg2Reg] + ifFalse: [regOrConst2 ~= CArg2Reg ifTrue: [cogit MoveR: regOrConst2 R: CArg2Reg]]. - ifFalse: [cogit MoveR: regOrConst2 R: CArg2Reg]. numArgs = 3 ifTrue: [^self]. (cogit isTrampolineArgConstant: regOrConst3) ifTrue: [cogit MoveCq: (cogit trampolineArgValue: regOrConst3) R: CArg3Reg] + ifFalse: [regOrConst3 ~= CArg3Reg ifTrue: [cogit MoveR: regOrConst3 R: CArg3Reg]]! - ifFalse: [cogit MoveR: regOrConst3 R: CArg3Reg]!

1 0

VM Maker: VMMakerUI-eem.16.mcz
by commits＠source.squeak.org 09 Jan '20

09 Jan '20

Eliot Miranda uploaded a new version of VMMakerUI to project VM Maker: http://source.squeak.org/VMMaker/VMMakerUI-eem.16.mcz ==================== Summary ==================== Name: VMMakerUI-eem.16 Author: eem Time: 8 January 2020, 6:52:00.804348 pm UUID: 98d9af6d-64ed-40df-89f0-962a7f3c31d0 Ancestors: VMMakerUI-eem.15 Add a primitive memory inspector (has no oop highlighting/subsequent isnpection abilities yet) =============== Diff against VMMakerUI-eem.15 =============== Item was removed: - ----- Method: CogVMObjectInspector>>stepIn: (in category 'stepping') ----- - stepIn: window - self changed: #text! Item was removed: - ----- Method: CogVMObjectInspector>>stepTimeIn: (in category 'stepping') ----- - stepTimeIn: window - "The minimum update time in milliseconds." - ^500! Item was removed: - ----- Method: CogVMObjectInspector>>wantsStepsIn: (in category 'stepping') ----- - wantsStepsIn: window - ^true! Item was added: + VMObjectInspector subclass: #VMMemoryInspector + instanceVariableNames: 'start limit currentValues' + classVariableNames: '' + poolDictionaries: '' + category: 'VMMakerUI-SqueakInspectors'! Item was added: + ----- Method: VMMemoryInspector class>>on:from:to: (in category 'instance creation') ----- + on: aCoInterpreter from: start to: end + ^self new + coInterpreter: aCoInterpreter; + start: start - (start \\ 8); + limit: (end + 8 roundTo: 8); + yourself! Item was added: + ----- Method: VMMemoryInspector class>>openFor:from:to: (in category 'instance creation') ----- + openFor: aCoInterpreter from: start to: end + ^ToolBuilder open: (self on: aCoInterpreter from: start to: end)! Item was added: + ----- Method: VMMemoryInspector>>limit (in category 'accessing') ----- + limit + + ^ limit! Item was added: + ----- Method: VMMemoryInspector>>limit: (in category 'accessing') ----- + limit: anObject + + limit := anObject.! Item was added: + ----- Method: VMMemoryInspector>>start (in category 'accessing') ----- + start + + ^ start! Item was added: + ----- Method: VMMemoryInspector>>start: (in category 'accessing') ----- + start: anObject + + start := anObject.! Item was added: + ----- Method: VMMemoryInspector>>text (in category 'accessing - ui') ----- + text + | index | + currentValues ifNil: [currentValues := Array new: limit - start // 8 + 1 withAll: 0]. + ^Text streamContents: + [:s| | addressLength value | + addressLength := limit digitLength * 2. + start to: limit - 1 by: 8 do: + [:address| + address printOn: s base: 16 length: addressLength padded: true. + s tab. + value := objectMemory long64At: address. + index := address - start // 8 + 1. + value ~= (currentValues at: index) + ifTrue: [currentValues at: index put: value. + s nextPutAll: ((value printStringBase: 16 length: 16 padded: true) + asText addAllAttributes: {TextEmphasis bold. TextColor color: Color red darker darker})] + ifFalse: [value printOn: s base: 16 length: 16 padded: true]. + s cr]]! Item was added: + ----- Method: VMObjectInspector>>stepIn: (in category 'stepping') ----- + stepIn: window + self changed: #text! Item was added: + ----- Method: VMObjectInspector>>stepTimeIn: (in category 'stepping') ----- + stepTimeIn: window + "The minimum update time in milliseconds." + ^500! Item was added: + ----- Method: VMObjectInspector>>wantsStepsIn: (in category 'stepping') ----- + wantsStepsIn: window + ^true!

1 0

Build failed: opensmalltalk-vm 1.0.18
by AppVeyor 08 Jan '20

08 Jan '20

1 0

Failed: OpenSmalltalk/opensmalltalk-vm#1909 (Cog - f5ec3f4)
by Travis CI 08 Jan '20

08 Jan '20

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1909 Status: Failed Duration: 12 mins and 5 secs Commit: f5ec3f4 (Cog) Author: smalltalking Message: Fix type inconsistencies (int vs sqInt) (#464) * Fix type inconsistencies (int vs sqInt) Found by trying to compile with LTO enabled. The VM compiles with the updated types on linux with or without LTO enabled (the LTO VM is not functional). Didn't test with the OSes but changed the declarations in their files. Affected functions: - primInIOProcessEventsFlagAddress - ioGatherEntropy - GetAttributeString - primitivePluginBrowserReady - primitivePluginDestroyRequest - primitivePluginRequestFileHandle - primitivePluginRequestState - primitivePluginRequestURL - primitivePluginRequestURLStream - primitivePluginPostURL * Include sqMemoryAccess.h to have sqInt defined View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/0b4551db2e5c...f5… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/634182598?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

[OpenSmalltalk/opensmalltalk-vm] Fix type inconsistencies (int vs sqInt) (#464)
by smalltalking 08 Jan '20

08 Jan '20

It's about be96d84, the other 3 commits are just noise. There may be things left to do on Windows and Mac. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464 -- Commit Summary -- * Merge branch 'Cog' of https://github.com/OpenSmalltalk/opensmalltalk-vm into Cog * Merge branch 'Cog' of https://github.com/OpenSmalltalk/opensmalltalk-vm into Cog * Fix type inconsistencies (int vs sqInt) * Merge branch 'fix-type-inconsistencies-int-sqInt' into Cog -- File Changes -- M platforms/Cross/plugins/CroquetPlugin/CroquetPlugin.h (2) M platforms/Mac OS/vm/Developer/sqMacMinimal.c (4) M platforms/Mac OS/vm/osExports.c (16) M platforms/Mac OS/vm/sqMacMain.c (2) M platforms/Mac OS/vm/sqMacMain.h (2) M platforms/unix/vm-display-Quartz/zzz/sqUnixQuartz.m (14) M platforms/unix/vm-display-X11/sqUnixMozilla.c (10) M platforms/unix/vm/osExports.c (18) M platforms/win32/plugins/CroquetPlugin/sqWin32CroquetPlugin.c (2) M platforms/win32/vm/sqWin32Exports.c (18) M platforms/win32/vm/sqWin32Main.c (2) M platforms/win32/vm/sqWin32PluginSupport.c (14) M src/plugins/IA32ABI/IA32ABI.c (2) M src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c (2) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464

2 5

VM Maker: VMMakerUI-eem.15.mcz
by commits＠source.squeak.org 07 Jan '20

07 Jan '20

Eliot Miranda uploaded a new version of VMMakerUI to project VM Maker: http://source.squeak.org/VMMaker/VMMakerUI-eem.15.mcz ==================== Summary ==================== Name: VMMakerUI-eem.15 Author: eem Time: 6 January 2020, 5:07:46.823147 pm UUID: 9ef7629b-19ef-4086-bd2e-313ace30edc3 Ancestors: VMMakerUI-eem.14 Deal with some dangling refs to VMMaker objectsx in texts (heree, in editor histories). =============== Diff against VMMakerUI-eem.14 =============== Item was added: + ----- Method: TextEditor class>>nukeVMMakerPluggableTextAttributes (in category '*VMMakerUI-cleanup') ----- + nukeVMMakerPluggableTextAttributes + self allSubInstancesDo: + [:editor| + (editor history detect: + [:command| + (self textReferencesVMMakerObjects: command contentsBefore) + or: [self textReferencesVMMakerObjects: command contentsAfter]]) notNil ifTrue: + [editor history: TextEditorCommandHistory new]]! Item was added: + ----- Method: TextEditor class>>textReferencesVMMakerObjects: (in category '*VMMakerUI-cleanup') ----- + textReferencesVMMakerObjects: text + ^text runs values anySatisfy: + [:emphasis| + emphasis isArray + and: [emphasis anySatisfy: + [:attribute| + attribute class == PluggableTextAttribute + and: [(attribute instVarNamed: 'evalBlock') receiver class category beginsWith: 'VMMaker']]]]!

1 0

VM Maker: VMMaker.oscog-eem.2650.mcz
by commits＠source.squeak.org 07 Jan '20

07 Jan '20

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2650.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2650 Author: eem Time: 6 January 2020, 4:10:39.496587 pm UUID: ee83002f-875b-4b5f-bfe7-83c57d677666 Ancestors: VMMaker.oscog-eem.2649 Cogit: Fix a slip in Lowcode FFI trampoline generation. Nuke leak checking in run-time calls (getting the stack offset for on-stack pcs right is tricky and so the feature isn't useful without a lot more work, and the current bug wasn't caught by it anyway). Add robustness to printing ARMv8 embedded 32-bit constants. Better Halt message when stopping at an opcode breakpoint. Plugins: Survive double closes in the FilePluginSimulator. =============== Diff against VMMaker.oscog-eem.2649 =============== Item was changed: ----- Method: Cogit>>abstractInstructionAt: (in category 'compile abstract instructions') ----- abstractInstructionAt: index <cmacro: '(index) (&abstractOpcodes[index])'> <returnTypeC: #'AbstractInstruction *'> ((debugOpcodeIndices includes: index) and: [breakMethod isNil or: [methodObj = breakMethod]]) ifTrue: + [self halt: 'Accessing opcode index ', index printString]. - [self halt]. ^abstractOpcodes at: index! Item was changed: ----- Method: Cogit>>genFFICalloutTrampoline (in category 'initialization') ----- genFFICalloutTrampoline <option: #LowcodeVM> | startAddress | + self zeroOpcodeIndexForNewOpcodes. - opcodeIndex := 0. backEnd hasLinkRegister ifTrue: [ self MoveR: LinkReg Aw: coInterpreter instructionPointerAddress ] ifFalse: [ self PopR: backEnd registerToSaveIP. self MoveR: backEnd registerToSaveIP Aw: coInterpreter instructionPointerAddress ]. self CallR: TempReg. backEnd hasLinkRegister ifTrue: [ self MoveAw: coInterpreter instructionPointerAddress R: LinkReg ] ifFalse: [ self MoveAw: coInterpreter instructionPointerAddress R: backEnd registerToSaveIP. self PushR: backEnd registerToSaveIP. ]. self RetN: 0. startAddress := methodZoneBase. self outputInstructionsForGeneratedRuntimeAt: startAddress. self recordGeneratedRunTime: 'ceFFICalloutTrampoline' address: startAddress. self recordRunTimeObjectReferences. ^ startAddress ! Item was changed: ----- Method: Cogit>>handleCallOrJumpSimulationTrap: (in category 'simulation only') ----- handleCallOrJumpSimulationTrap: aProcessorSimulationTrap <doNotGenerate> | evaluable function memory result savedFramePointer savedStackPointer savedArgumentCount leaf retpc | - objectMemory maybeLeakCheckForRuntimeCall. evaluable := simulatedTrampolines at: aProcessorSimulationTrap address ifAbsent: [self errorProcessingSimulationTrap: aProcessorSimulationTrap in: simulatedTrampolines]. function := evaluable isBlock ifTrue: ['aBlock; probably some plugin primitive'] ifFalse: [evaluable receiver == backEnd ifTrue: [^self handleABICallOrJumpSimulationTrap: aProcessorSimulationTrap evaluable: evaluable]. evaluable selector]. function ~~ #ceBaseFrameReturn: ifTrue: [coInterpreter assertValidExternalStackPointers]. (backEnd wantsNearAddressFor: function) ifTrue: [^self perform: function with: aProcessorSimulationTrap]. memory := coInterpreter memory. aProcessorSimulationTrap type == #call ifTrue: [(leaf := coInterpreter mcprims includes: function) ifTrue: [processor simulateLeafCallOf: aProcessorSimulationTrap address nextpc: aProcessorSimulationTrap nextpc memory: memory. retpc := processor leafRetpcIn: memory] ifFalse: [processor simulateCallOf: aProcessorSimulationTrap address nextpc: aProcessorSimulationTrap nextpc memory: memory. retpc := processor retpcIn: memory]. self recordInstruction: {'(simulated call of '. aProcessorSimulationTrap address. '/'. function. ')'}] ifFalse: [leaf := false. processor simulateJumpCallOf: aProcessorSimulationTrap address memory: memory. retpc := processor retpcIn: memory. "sideways call; the primitive has pushed a return address." self recordInstruction: {'(simulated jump to '. aProcessorSimulationTrap address. '/'. function. ')'}]. savedFramePointer := coInterpreter framePointer. savedStackPointer := coInterpreter stackPointer. savedArgumentCount := coInterpreter argumentCount. result := ["self halt: evaluable selector." clickConfirm ifTrue: [(self confirm: 'skip run-time call?') ifFalse: [clickConfirm := false. self halt]]. evaluable valueWithArguments: (processor postCallArgumentsNumArgs: evaluable numArgs in: memory)] on: ReenterMachineCode do: [:ex| ex return: ex returnValue]. coInterpreter assertValidExternalStackPointers. - objectMemory maybeLeakCheckForRuntimeCall. "Verify the stack layout assumption compileInterpreterPrimitive: makes, provided we've not called something that has built a frame, such as closure value or evaluate method, or switched frames, such as primitiveSignal, primitiveWait, primitiveResume, primitiveSuspend et al." (function beginsWith: 'primitive') ifTrue: [coInterpreter checkForLastObjectOverwrite. coInterpreter primFailCode = 0 ifTrue: [(#( primitiveClosureValue primitiveClosureValueWithArgs primitiveClosureValueNoContextSwitch primitiveFullClosureValue primitiveFullClosureValueWithArgs primitiveFullClosureValueNoContextSwitch primitiveSignal primitiveWait primitiveResume primitiveSuspend primitiveYield primitiveExecuteMethodArgsArray primitiveExecuteMethod primitivePerform primitivePerformWithArgs primitivePerformInSuperclass primitiveTerminateTo primitiveStoreStackp primitiveDoPrimitiveWithArgs) includes: function) ifFalse: ["This is a rare case (e.g. in Scorch where a married context's sender is set to nil on trapTrpped and hence the stack layout is altered." (function == #primitiveSlotAtPut and: [objectMemory isContext: (coInterpreter frameReceiver: coInterpreter framePointer)]) ifFalse: [self assert: savedFramePointer = coInterpreter framePointer. self assert: savedStackPointer + (savedArgumentCount * objectMemory wordSize) = coInterpreter stackPointer]]] ifFalse: [self assert: savedFramePointer = coInterpreter framePointer. self assert: savedStackPointer = coInterpreter stackPointer]]. result ~~ #continueNoReturn ifTrue: [self recordInstruction: {'(simulated return to '. processor retpcIn: memory. ')'}. leaf ifTrue: [processor simulateLeafReturnIn: memory] ifFalse: [processor simulateReturnIn: memory]. self assert: processor pc = retpc. processor smashCallerSavedRegistersWithValuesFrom: 16r80000000 by: objectMemory wordSize in: memory]. self assert: (result isInteger "an oop result" or: [result == coInterpreter or: [result == objectMemory or: [#(nil continue continueNoReturn) includes: result]]]). processor cResultRegister: (result ifNil: [0] ifNotNil: [result isInteger ifTrue: [result] ifFalse: [16rF00BA222]]) "coInterpreter cr. processor sp + 32 to: processor sp - 32 by: -4 do: [:sp| sp = processor sp ifTrue: [coInterpreter print: 'sp->'; tab] ifFalse: [coInterpreter printHex: sp]. coInterpreter tab; printHex: (coInterpreter longAt: sp); cr]"! Item was changed: ----- Method: FilePluginSimulator>>close (in category 'initialize-release') ----- + close + "close any files that ST may have opened" + openFiles do: + [:f | + [f close] + on: Error + do: [:ex| + ex messageText ~= 'primClose: failed' ifTrue: + [ex pass]]]! - close "close any files that ST may have opened" - openFiles do: [:f | f close]! Item was removed: - ----- Method: NewObjectMemory>>maybeLeakCheckForRuntimeCall (in category 'debug support') ----- - maybeLeakCheckForRuntimeCall - <doNotGenerate> - (checkForLeaks bitAnd: 32) ~= 0 ifTrue: - [coInterpreter runLeakChecker]! Item was changed: ----- Method: SpurMemoryManager>>lookup32BitWordConstant: (in category 'simulation only') ----- lookup32BitWordConstant: word "If word appears to be a class index answer the class name, otherwise answer nil. For code disassembly" <doNotGenerate> | class classSize classNameIndex thisClassIndex | + (hiddenRootsObj notNil + and: [word between: 1 and: self classIndexMask]) ifFalse: - (word between: 1 and: self classIndexMask) ifFalse: [^nil]. class := self noCheckClassAtIndex: word. (class isNil or: [class = nilObj]) ifTrue: [^nil]. "address is either a class or a metaclass, or an instance of a class or invalid. determine which." classNameIndex := coInterpreter classNameIndex. thisClassIndex := coInterpreter thisClassIndex. ((classSize := self numSlotsOf: class) <= (classNameIndex max: thisClassIndex) or: [classSize > 255]) ifTrue: [^nil]. "Address could be a class or a metaclass" (self lookupAddress: (self fetchPointer: classNameIndex ofObject: class)) ifNotNil: [:maybeClassName| ^maybeClassName allButFirst]. (self lookupAddress: (self fetchPointer: thisClassIndex ofObject: class)) ifNotNil: [:maybeClassName| ^maybeClassName allButFirst, ' class'].! Item was removed: - ----- Method: SpurMemoryManager>>maybeLeakCheckForRuntimeCall (in category 'debug support') ----- - maybeLeakCheckForRuntimeCall - <doNotGenerate> - (checkForLeaks bitAnd: 32) ~= 0 ifTrue: - [coInterpreter runLeakChecker]!

1 0

VM Maker: VMMakerUI-eem.14.mcz
by commits＠source.squeak.org 07 Jan '20

07 Jan '20

Eliot Miranda uploaded a new version of VMMakerUI to project VM Maker: http://source.squeak.org/VMMaker/VMMakerUI-eem.14.mcz ==================== Summary ==================== Name: VMMakerUI-eem.14 Author: eem Time: 6 January 2020, 4:04:25.519543 pm UUID: 2ac224f3-7e13-422e-8449-bf67ce431ed2 Ancestors: VMMakerUI-eem.13 Emphasize the btarget oop in a forwarder. Put the occasional new line in the print of a bytte array/large integer. Also use promptClickStep in the interpreter's click step. =============== Diff against VMMakerUI-eem.13 =============== Item was changed: ----- Method: CogVMSimulator>>printStringOf:on: (in category '*VMMakerUI-debug printing') ----- printStringOf: oop on: aStream <doNotGenerate> | fmt len cnt max i | (objectMemory isImmediate: oop) ifTrue: [^self]. (objectMemory addressCouldBeObj: oop) ifFalse: [^self]. fmt := objectMemory formatOf: oop. fmt < objectMemory firstByteFormat ifTrue: [^self]. cnt := (max := 128) min: (len := objectMemory lengthOf: oop). i := 0. ((objectMemory is: oop instanceOf: (objectMemory splObj: ClassByteArray) compactClassIndex: classByteArrayCompactIndex) or: [(objectMemory isLargeIntegerInstance: oop)]) ifTrue: [[i < cnt] whileTrue: [self printHex: (objectMemory fetchByte: i ofObject: oop) on: aStream. + (i := i + 1) \\ 16 = 0 ifTrue: [aStream cr]]] - i := i + 1]] ifFalse: [[i < cnt] whileTrue: [aStream nextPut: (objectMemory fetchByte: i ofObject: oop) asCharacter. i := i + 1]]. len > max ifTrue: [aStream nextPutAll: '...']! Item was changed: ----- Method: Cogit>>setClickStepBreakBlock (in category '*VMMakerUI-user interface') ----- setClickStepBreakBlock "Set the break block to present a confirmer, breaking if true, and restoring the previous break block. If an open debugger on the receiver can be found, proceed it." <doNotGenerate> | previousBreakBlock previousAtEachStepBlock previousBreakPC previousSingleStep previousClickConfirm result | (breakBlock isNil or: [breakBlock method ~~ thisContext method]) ifTrue: [previousBreakBlock := breakBlock. previousAtEachStepBlock := coInterpreter atEachStepBlock. previousBreakPC := breakPC. previousSingleStep := singleStep. previousClickConfirm := clickConfirm. breakBlock := [:ign| (processor pc ~= previousBreakPC and: [(result := self promptClickStep) == true]) ifTrue: [false] ifFalse: [breakBlock := previousBreakBlock. coInterpreter atEachStepBlock: previousAtEachStepBlock. breakPC := previousBreakPC. singleStep := previousSingleStep. clickConfirm := previousClickConfirm. true]]. coInterpreter atEachStepBlock: [previousAtEachStepBlock value. (coInterpreter localIP ~= previousBreakPC + and: [(result := self promptClickStep) == true]) ifFalse: - and: [UIManager confirm: 'step?']) ifFalse: [breakBlock := previousBreakBlock. coInterpreter atEachStepBlock: previousAtEachStepBlock. breakPC := previousBreakPC. singleStep := previousSingleStep. clickConfirm := previousClickConfirm. self halt]]. singleStep := breakPC := clickConfirm := result ~~ #proceed]. (World submorphs detect: [:m| m model isDebugger and: [(m model interruptedProcess suspendedContext findContextSuchThat: [:ctxt| (ctxt receiver == self and: [ctxt selector == #simulateCogCodeAt:]) or: [ctxt receiver == coInterpreter and: [ctxt selector == #interpret]]]) notNil]] ifNone: []) ifNotNil: [:debuggerWindow| WorldState addDeferredUIMessage: [debuggerWindow model proceed]]! Item was removed: - ----- Method: StackInterpreter>>printForwarder:on: (in category '*VMMakerUI-debug printing') ----- - printForwarder: oop on: aStream - <doNotGenerate> - aStream nextPutAll: ' is a forwarded object to '. - self printHex: (objectMemory followForwarded: oop) on: aStream. - aStream nextPutAll: ' of slot size '; print: (objectMemory numSlotsOfAny: oop). - objectMemory printHeaderTypeOf: oop on: aStream. - aStream cr! Item was added: + ----- Method: StackInterpreter>>printForwarder:on:oopAttribute: (in category '*VMMakerUI-debug printing') ----- + printForwarder: oop on: aStream oopAttribute: oopTextAttribute + <doNotGenerate> + aStream + nextPutAll: ' is a forwarded object to '; + nextPutAll: (self hex: (objectMemory followForwarded: oop) withAttribute: oopTextAttribute); + nextPutAll: ' of slot size '; + print: (objectMemory numSlotsOfAny: oop). + objectMemory printHeaderTypeOf: oop on: aStream. + aStream cr! Item was changed: ----- Method: StackInterpreter>>printOop:on:oopAttribute: (in category '*VMMakerUI-debug printing') ----- printOop: oop on: aStream oopAttribute: oopTextAttribute <doNotGenerate> | cls fmt lastIndex startIP bytecodesPerLine column | <inline: false> (objectMemory isImmediate: oop) ifTrue: [^self shortPrintOop: oop on: aStream]. self printHex: oop on: aStream. (objectMemory addressCouldBeObj: oop) ifFalse: [(oop bitAnd: objectMemory allocationUnit - 1) ~= 0 ifTrue: [^aStream nextPutAll: ' is misaligned'; cr]. ((objectMemory isInNewSpace: oop) and: [objectMemory isForwarded: oop]) ifTrue: + [self printForwarder: oop on: aStream oopAttribute: oopTextAttribute]. - [self printForwarder: oop on: aStream]. ^aStream nextPutAll: (self whereIs: oop); cr]. (objectMemory isFreeObject: oop) ifTrue: [aStream nextPutAll: ' is a free chunk of size '; print: (objectMemory sizeOfFree: oop). objectMemory hasSpurMemoryManagerAPI ifTrue: [aStream nextPutAll: ' 0th: '. self printHex: (objectMemory fetchPointer: 0 ofFreeChunk: oop) on: aStream. objectMemory printHeaderTypeOf: oop on: aStream]. ^aStream cr]. (objectMemory isForwarded: oop) ifTrue: + [self printForwarder: oop on: aStream oopAttribute: oopTextAttribute]. - [self printForwarder: oop on: aStream]. aStream nextPutAll: ': a(n) '. self printNameOfClass: (cls := objectMemory fetchClassOfNonImm: oop) count: 5 on: aStream. cls = (objectMemory splObj: ClassFloat) ifTrue: [^aStream cr; print: (objectMemory dbgFloatValueOf: oop); cr]. fmt := objectMemory formatOf: oop. fmt > objectMemory lastPointerFormat ifTrue: [aStream nextPutAll: ' nbytes '; print: (objectMemory numBytesOf: oop)]. aStream cr. (fmt between: objectMemory firstLongFormat and: objectMemory firstCompiledMethodFormat - 1) ifTrue: ["This will answer false if splObj: ClassAlien is nilObject" (self is: oop KindOfClass: (objectMemory splObj: ClassAlien)) ifTrue: [aStream nextPutAll: ' datasize '; print: (self sizeOfAlienData: oop). aStream nextPutAll: ((self isIndirectAlien: oop) ifTrue: [' indirect @ '] ifFalse: [(self isPointerAlien: oop) ifTrue: [' pointer @ '] ifFalse: [' direct @ ']]). self printHex: (self startOfAlienData: oop) on: aStream. ^aStream cr]. (objectMemory isWordsNonImm: oop) ifTrue: [lastIndex := 64 min: ((objectMemory numBytesOf: oop) / objectMemory wordSize). lastIndex > 0 ifTrue: [1 to: lastIndex do: [:index| self printHex: (objectMemory fetchLong32: index - 1 ofObject: oop) on: aStream. index \\ self elementsPerPrintOopLine = 0 ifTrue: [aStream cr]]. lastIndex \\ self elementsPerPrintOopLine = 0 ifFalse: [aStream cr]]. ^self]. self printStringOf: oop on: aStream. ^aStream cr]. "this is nonsense. apologies." startIP := (objectMemory safeLastPointerOf: oop) + objectMemory bytesPerOop - objectMemory baseHeaderSize / objectMemory bytesPerOop. lastIndex := 256 min: startIP. lastIndex > 0 ifTrue: [1 to: lastIndex do: [:index| aStream space; nextPutAll: (self hex: (objectMemory fetchPointer: index - 1 ofObject: oop) withAttribute: oopTextAttribute); space. aStream nextPutAll: (self shortPrint: (objectMemory fetchPointer: index - 1 ofObject: oop)). index \\ self elementsPerPrintOopLine = 0 ifTrue: [aStream cr]]. lastIndex \\ self elementsPerPrintOopLine = 0 ifFalse: [aStream cr]]. (objectMemory isCompiledMethod: oop) ifFalse: [startIP > 64 ifTrue: [aStream nextPutAll: '...'; cr]] ifTrue: [startIP := startIP * objectMemory wordSize + 1. lastIndex := objectMemory lengthOf: oop. lastIndex - startIP > 100 ifTrue: [lastIndex := startIP + 100]. bytecodesPerLine := 8. column := 1. startIP to: lastIndex do: [:index| | byte | column = 1 ifTrue: [aStream nextPutAll: (oop+objectMemory baseHeaderSize+index-1) hex; nextPutAll: ': ']. byte := objectMemory fetchByte: index - 1 ofObject: oop. aStream space. byte printOn: aStream base: 16. aStream nextPut: $/. byte printOn: aStream. column := column + 1. column > bytecodesPerLine ifTrue: [column := 1. aStream cr]]. column = 1 ifFalse: [aStream cr]]!

1 0

[OpenSmalltalk/opensmalltalk-vm] Mac OS X: Fullscreen not as expected (#407)
by Tom Braun 07 Jan '20

07 Jan '20

Currently it is only possible to maximize Squeak by using the button in the MainDockingBar (it is not possible by using the green button on the window what is slightly unexpected but ok). The fullscreen I get is a Squeak that looks like a typical Mac fullscreen but has several drawbacks: * it is not a new desktop with only the app, but consumes the current desktop * if you change desktop you get strange behaviour with the dock appearing * if you use a second monitor and have a Squeak in fullscreen on your first you get a black background stretched over the whole second monitor The expected behaviour for fullscreen would be a native Mac OS fullscreen. (@ronsaldo someone mentioned to me that is due to the new metalshaders) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/407

2 1

Passed: OpenSmalltalk/opensmalltalk-vm#1907 (201912311458 - f219b72)
by Travis CI 06 Jan '20

06 Jan '20

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1907 Status: Passed Duration: 2 hrs, 49 mins, and 48 secs Commit: f219b72 (201912311458) Author: Nicolas Cellier Message: Fix the sign of x wheel events in OSX to be inline with "natural scrolling" preference. - The VM should generate positive deltaX for Left to Right trackpad motion - The VM should generate positive deltaY for Bottom to Up trackpad motion For historical reasons, if VM does not send mouse wheel events, but fake keyboard arrow events, then: - The VM should generate a left arrow key for Left to Right trackpad motion - The VM should generate a bottom arrow key for Bottom to Up trackpad motion Not that the preferred direction preference of OSX is taken into account by the VM See https://developer.apple.com/documentation/appkit/nsevent/1525151-isdirectio… Above description is for "natural scrolling" preference (the trackpad does drag the screen contents). It will be inverted if the preference is unset (the trackpad does drag the scroll bar). Note that the `isFlipped` method of the Cocoa/Quartz view presumably ha an impact on sign of vertical motions See https://developer.apple.com/documentation/appkit/nsview/1483532-isflipped OpenSmalltalk VM does use isFlipped YES. View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/201912311458 View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/633351751?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev January 2020