Vm-dev January 2019

vm-dev@lists.squeakfoundation.org

29 participants
374 discussions

VM Maker Inbox: VMMaker.oscog-KenD.2513.mcz
by commits＠source.squeak.org 23 Jan '19

23 Jan '19

A new version of VMMaker was added to project VM Maker Inbox: http://source.squeak.org/VMMakerInbox/VMMaker.oscog-KenD.2513.mcz ==================== Summary ==================== Name: VMMaker.oscog-KenD.2513 Author: KenD Time: 23 January 2019, 8:30:03.772198 am UUID: 5ca2e0fe-bdad-4047-a9d8-8fc9f9c9cd3c Ancestors: VMMaker.oscog-KenD.2512 Reversed the way single and double floats were handled in callOutState floatRegisters to simplify the logic a bit. =============== Diff against VMMaker.oscog-KenD.2512 =============== Item was changed: ----- Method: ThreadedARM64FFIPlugin class>>initialize (in category 'class initialization') ----- initialize super initialize. + NumIntRegArgs := 8. + NumFloatRegArgs := 8! - NumIntRegArgs := 8. - NumFloatRegArgs := 16! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>ffiCalloutTo:SpecOnStack:in: (in category 'callout support') ----- ffiCalloutTo: procAddr SpecOnStack: specOnStack in: calloutState <var: #procAddr type: #'void *'> <var: #calloutState type: #'CalloutState *'> <var: #loadFloatRegs declareC: 'extern void loadFloatRegs(double, double, double, double, double, double, double, double)'> "Go out, call this guy and create the return value. This *must* be inlined because of the alloca of the outgoing stack frame in ffiCall:WithFlags:NumArgs:Args:AndTypes:" | myThreadIndex atomicType floatRet intRet | <var: #floatRet type: #double> <var: #intRet type: #usqLong> <inline: true> myThreadIndex := interpreterProxy disownVM: (self disownFlagsFor: calloutState). calloutState floatRegisterIndex > 0 ifTrue: [self loadFloatRegs: + (calloutState floatRegisters at: 0) + _: (calloutState floatRegisters at: 1) + _: (calloutState floatRegisters at: 2) + _: (calloutState floatRegisters at: 3) + _: (calloutState floatRegisters at: 4) + _: (calloutState floatRegisters at: 5) + _: (calloutState floatRegisters at: 6) + _: (calloutState floatRegisters at: 7)]. - ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 0)) to: #'double *') at: 0) - _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 2)) to: #'double *') at: 0) - _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 4)) to: #'double *') at: 0) - _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 6)) to: #'double *') at: 0) - _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 8)) to: #'double *') at: 0) - _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 10)) to: #'double *') at: 0) - _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 12)) to: #'double *') at: 0) - _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 14)) to: #'double *') at: 0)]. (self allocaLiesSoSetSpBeforeCall or: [self mustAlignStack]) ifTrue: [self setsp: calloutState argVector]. atomicType := self atomicTypeOf: calloutState ffiRetHeader. (atomicType >> 1) = (FFITypeSingleFloat >> 1) ifTrue: [atomicType = FFITypeSingleFloat ifTrue: [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'float (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7)] ifFalse: "atomicType = FFITypeDoubleFloat" [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'double (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7)]. "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. ^interpreterProxy floatObjectOf: floatRet]. intRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'usqIntptr_t (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7). "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. (calloutState ffiRetHeader anyMask: FFIFlagPointer+FFIFlagStructure) ifTrue: ["Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent 'typedef void* VoidPointer' and VoidPointer must be returned as pointer *not* as struct." (calloutState ffiRetHeader anyMask: FFIFlagPointer) ifTrue: [^self ffiReturnPointer: intRet ofType: (self ffiReturnType: specOnStack) in: calloutState]. ^self ffiReturnStruct: intRet ofType: (self ffiReturnType: specOnStack) in: calloutState]. ^self ffiCreateIntegralResultOop: intRet ofAtomicType: atomicType in: calloutState! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>ffiPushDoubleFloat:in: (in category 'marshalling') ----- ffiPushDoubleFloat: value in: calloutState <var: #value type: #double> <var: #calloutState type: #'CalloutState *'> <inline: #always> + calloutState floatRegisterIndex < NumFloatRegArgs - calloutState floatRegisterIndex < (NumFloatRegArgs - 1) ifTrue: + [calloutState floatRegisters + at: calloutState floatRegisterIndex - [(self cCoerceSimple: - (self addressOf: (calloutState floatRegisters at: calloutState floatRegisterIndex)) - to: 'double*') - at: 0 put: value. + calloutState floatRegisterIndex: calloutState floatRegisterIndex + 1] - calloutState floatRegisterIndex: calloutState floatRegisterIndex + 2] ifFalse: [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. calloutState floatRegisterIndex: NumFloatRegArgs. interpreterProxy storeFloatAtPointer: calloutState currentArg from: value. calloutState currentArg: calloutState currentArg + self wordSize]. ^0! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>ffiPushSingleFloat:in: (in category 'marshalling') ----- ffiPushSingleFloat: value in: calloutState <var: #value type: #float> <var: #calloutState type: #'CalloutState *'> <inline: #always> calloutState floatRegisterIndex < NumFloatRegArgs + ifTrue: "Note: this is a 'memcopy', so size is preserved. Casting to #double changes the size" + [(self cCoerceSimple: + (self addressOf: (calloutState floatRegisters at: calloutState floatRegisterIndex)) + to: 'float*') + at: 0 + put: value. + calloutState floatRegisterIndex: calloutState floatRegisterIndex + 1] - ifTrue: - [calloutState floatRegisters - at: calloutState floatRegisterIndex - put: (self cCoerceSimple: value to: #double). - calloutState floatRegisterIndex: calloutState floatRegisterIndex + 2] ifFalse: [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy storeSingleFloatAtPointer: calloutState currentArg from: value. calloutState currentArg: calloutState currentArg + self wordSize]. ^0! Item was changed: ----- Method: ThreadedFFICalloutStateForARM64 class>>instVarNamesAndTypesForTranslationDo: (in category 'translation') ----- instVarNamesAndTypesForTranslationDo: aBinaryBlock "enumerate aBinaryBlock with the names and C type strings for the inst vars to include in a ThreadedFFICalloutState struct." superclass instVarNamesAndTypesForTranslationDo: aBinaryBlock. self instVarNames do: [:ivn| aBinaryBlock value: ivn value: (ivn caseOf: { + ['integerRegisters'] -> [{#sqInt. '[NumIntRegArgs]' }]. + ['floatRegisters'] -> [{#double. '[NumFloatRegArgs]'}] } - ['integerRegisters'] -> [{#sqInt. '[NumIntRegArgs]'}]. - ['floatRegisters'] -> [{#float. '[NumFloatRegArgs]'}] } otherwise: [#sqInt])]!

1 0

[OpenSmalltalk/opensmalltalk-vm] c5516f: UnixOSProcessPlugin source as per VMConstruction-P...
by GitHub 23 Jan '19

23 Jan '19

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: c5516f4c885d21fbb4fce75ff58f9bb0739f366e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c5516f4c885d21fbb4… Author: David T. Lewis <lewis(a)mail.msen.com> Date: 2019-01-23 (Wed, 23 Jan 2019) Changed paths: M src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c Log Message: ----------- UnixOSProcessPlugin source as per VMConstruction-Plugins-OSProcessPlugin.oscog-dtl.65 Commit: a4b2dfa67b731f731324daccbe2567f63490fbca https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a4b2dfa67b731f7313… Author: David T. Lewis <lewis(a)mail.msen.com> Date: 2019-01-23 (Wed, 23 Jan 2019) Changed paths: M src/plugins/Win32OSProcessPlugin/Win32OSProcessPlugin.c Log Message: ----------- Win32OSProcessPlugin plugin source as per VMConstruction-Plugins-OSProcessPlugin.oscog-dtl.65 Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/68441ad4dbeb...a4… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

2 1

Passed: OpenSmalltalk/opensmalltalk-vm#1670 (Cog - 68441ad)
by Travis CI 23 Jan '19

23 Jan '19

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1670 Status: Passed Duration: 4 hrs, 36 mins, and 51 secs Commit: 68441ad (Cog) Author: Eliot Miranda Message: Make the disablement of optimizatiomn in x86's thunkProtect specific to gcc 7.4.x. Guille, Pablo, All, please take note of this style. The point being we want correctness, but we shouldn't penalise unnecessarily other platfoms or build configurations that do function correctly. View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/426dbc0dd789...68… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/483137644?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

Build completed: opensmalltalk-vm 1.0.1667
by AppVeyor 23 Jan '19

23 Jan '19

1 0

Passed: OpenSmalltalk/opensmalltalk-vm#1669 (Cog - 426dbc0)
by Travis CI 23 Jan '19

23 Jan '19

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1669 Status: Passed Duration: 3 hrs, 18 mins, and 22 secs Commit: 426dbc0 (Cog) Author: Eliot Miranda Message: Merge pull request #353 from guillep/patch/callback-win32 Patch callback thunkEntry to not optimize View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/eedd22e8beba...42… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/483129403?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

Build failed: opensmalltalk-vm 1.0.1666
by AppVeyor 23 Jan '19

23 Jan '19

1 0

Build completed: opensmalltalk-vm 1.0.1665
by AppVeyor 23 Jan '19

23 Jan '19

1 0

Passed: OpenSmalltalk/opensmalltalk-vm#1667 (Cog - f472104)
by Travis CI 23 Jan '19

23 Jan '19

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1667 Status: Passed Duration: 2 hrs, 7 mins, and 57 secs Commit: f472104 (Cog) Author: Eliot Miranda Message: Merge pull request #357 from KenDickey/Cog lost? View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/234f27281b46...f4… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/483127953?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

[OpenSmalltalk/opensmalltalk-vm] 68441a: Make the disablement of optimizatiomn in x86's thu...
by GitHub 22 Jan '19

22 Jan '19

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 68441ad4dbebd96c4b92c0c72ed166b3037160e5 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/68441ad4dbebd96c4b… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2019-01-22 (Tue, 22 Jan 2019) Changed paths: M platforms/Cross/plugins/IA32ABI/ia32abicc.c Log Message: ----------- Make the disablement of optimizatiomn in x86's thunkProtect specific to gcc 7.4.x. Guille, Pablo, All, please take note of this style. The point being we want correctness, but we shouldn't penalise unnecessarily other platfoms or build configurations that do function correctly. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

Build failed: opensmalltalk-vm 1.0.1664
by AppVeyor 22 Jan '19

22 Jan '19

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
38
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev January 2019