Vm-dev May 2018

vm-dev@lists.squeakfoundation.org

30 participants
115 discussions

Start a nNew thread

Build failed: opensmalltalk-vm 1.0.1310
by AppVeyor 13 May '18

13 May '18

1 0

Errored: OpenSmalltalk/opensmalltalk-vm#1338 (Cog - 6bac0c6)
by Travis CI 13 May '18

13 May '18

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1338 Status: Errored Duration: 11 mins and 54 secs Commit: 6bac0c6 (Cog) Author: Tobias Pape Message: Add missing header for general unix compat S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP|S_IROTH|S_IWOTH are defined in <sys/stat.h> as per POSIX View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/334be9734047...6b… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/378430865?utm_s… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications This email was sent to vm-dev(a)lists.squeakfoundation.org (mailto:vm-dev@lists.squeakfoundation.org) unsubscribe from this list (http://clicks.travis-ci.com/track/unsub.php?u=14313403&id=d03fd5c64c7e47838…)

1 0

[OpenSmalltalk/opensmalltalk-vm] 6bac0c: Add missing header for general unix compat
by GitHub 13 May '18

13 May '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 6bac0c67bbd9bc23dc70344bfda72f4a9f86a099 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/6bac0c67bbd9bc23dc… Author: Tobias Pape <tobias(a)netshed.de> Date: 2018-05-13 (Sun, 13 May 2018) Changed paths: M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c Log Message: ----------- Add missing header for general unix compat S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP|S_IROTH|S_IWOTH are defined in <sys/stat.h> as per POSIX **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[OpenSmalltalk/opensmalltalk-vm] 20180403 fails to access source repo (#259)
by Gilad Bracha 13 May '18

13 May '18

Running Newspeak images with 20180403 VM, I find that attempting to access the Newspeak source repository fails in the image. This occurs even in old images that work correctly under older VMs (20170628). Not sure what the issue is: OS/FFI access or something else. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/259

1 1

[OpenSmalltalk/opensmalltalk-vm] Boot images produced by 201801252341 VM don't bring up a window on launch (#196)
by Ryan Macnak 13 May '18

13 May '18

If I produce Newspeak [boot images](https://bitbucket.org/newspeaklanguage/nsboot) from the [201801252341 Mac VMs](https://github.com/OpenSmalltalk/opensmalltalk-vm/releases/tag/2018012…, these images do not bring up the UI when subsequently opened, either by the new VMs or old VMs. The new VMs are able to properly bring up images produced by old VMs. (Maybe there's some new headlessness property in the image header?) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/196

3 6

VM Maker: VMMaker.oscog-VB.2382.mcz
by commits＠source.squeak.org 12 May '18

12 May '18

VincentBlondeau uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-VB.2382.mcz ==================== Summary ==================== Name: VMMaker.oscog-VB.2382 Author: VB Time: 10 May 2018, 3:58:47.518905 pm UUID: da8a5d36-0cd4-b641-865f-a139b3914245 Ancestors: VMMaker.oscog-eem.2381 change the primitive to return the file descriptor type instead of just 0 or 1 =============== Diff against VMMaker.oscog-eem.2381 =============== Item was added: + ----- Method: FilePlugin>>primitiveFileDescriptorType (in category 'file primitives') ----- + primitiveFileDescriptorType + | fileType fd fdPointer | + "Allow to test if the standard input/output files are from a console or not + Return values: + * -1 - Error + * 0 - no console (windows only) + * 1 - normal terminal (unix terminal / windows console) + * 2 - pipe + * 3 - file + * 4 - cygwin terminal (windows only)" + <var: 'fd' type: #int> + <export: true> + fdPointer := interpreterProxy stackValue: 0. + (interpreterProxy isIntegerObject: fdPointer) + ifFalse: [^ interpreterProxy primitiveFailFor: PrimErrBadArgument]. + fd := interpreterProxy integerValueOf: fdPointer. + interpreterProxy failed ifTrue: [ + "Ensure that the appropriate failure code has been set" + ^interpreterProxy primitiveFailFor: PrimErrBadArgument]. + fileType := self + cCode: 'sqFileDescriptorType(fd)' + inSmalltalk: [1]. + interpreterProxy pop: 2. + interpreterProxy pushInteger: fileType! Item was removed: - ----- Method: FilePlugin>>primitiveIsFileDescriptorATTY (in category 'file primitives') ----- - primitiveIsFileDescriptorATTY - | isStdoutRedirected fd fdPointer | - <var: 'fd' type: #int> - <export: true> - fdPointer := interpreterProxy stackValue: 0. - (interpreterProxy isIntegerObject: fdPointer) - ifFalse: [^ interpreterProxy primitiveFailFor: PrimErrBadArgument]. - fd := interpreterProxy integerValueOf: fdPointer. - interpreterProxy failed ifTrue: [ - "Ensure that the appropriate failure code has been set" - ^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - isStdoutRedirected := self - cCode: 'sqIsFileDescriptorATTY(fd) ' - inSmalltalk: [true]. - interpreterProxy pop: 2. - interpreterProxy pushBool: isStdoutRedirected!

3 2

VM Maker: VMMaker.oscog-VB.2383.mcz
by commits＠source.squeak.org 12 May '18

12 May '18

VincentBlondeau uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-VB.2383.mcz ==================== Summary ==================== Name: VMMaker.oscog-VB.2383 Author: VB Time: 12 May 2018, 10:21:38.92358 am UUID: a0681b83-7110-3d47-9214-f4bcf9d4982a Ancestors: VMMaker.oscog-VB.2382 Use methodReturn***: instead of pop: + push***: in FilePlugin =============== Diff against VMMaker.oscog-VB.2382 =============== Item was changed: ----- Method: FilePlugin>>primitiveConnectToFile (in category 'file primitives') ----- primitiveConnectToFile "Connect to the file with the supplied FILE* and writeFlag. FILE* must be supplied in a byte object (ByteArray) with the platform address size. writeFlag must be a boolean and compatible with the existing file access." | writeFlag cfileOop cfile filePointer | <var: 'cfile' type: #'void *'> <export: true> writeFlag := interpreterProxy booleanValueOf: (interpreterProxy stackValue: 0). cfileOop := interpreterProxy stackValue: 1. cfile := self pointerFrom: cfileOop. interpreterProxy failed ifTrue: [ "Ensure that the appropriate failure code has been set" ^interpreterProxy primitiveFailFor: PrimErrBadArgument]. filePointer := self connectToFile: cfile write: writeFlag. interpreterProxy failed ifFalse: + [interpreterProxy methodReturnValue: filePointer]! - [interpreterProxy pop: 3 "rcvr, name, writeFlag" - thenPush: filePointer]! Item was changed: ----- Method: FilePlugin>>primitiveConnectToFileDescriptor (in category 'file primitives') ----- primitiveConnectToFileDescriptor "Connect to the existing file identified by fileDescriptor. fileDescriptor must be an integer. writeFlag is aboolean indicating whether to open in read or write mode and must be compatible with the existing file access." | writeFlag fdPointer fd filePointer | <var: 'fd' type: #int> <export: true> writeFlag := interpreterProxy booleanValueOf: (interpreterProxy stackValue: 0). fdPointer := interpreterProxy stackValue: 1. (interpreterProxy isIntegerObject: fdPointer) ifFalse: [^ interpreterProxy primitiveFailFor: PrimErrBadArgument]. fd := interpreterProxy integerValueOf: fdPointer. interpreterProxy failed ifTrue: [ "Ensure that the appropriate failure code has been set" ^interpreterProxy primitiveFailFor: PrimErrBadArgument]. filePointer := self connectToFd: fd write: writeFlag. interpreterProxy failed ifFalse: + [interpreterProxy methodReturnValue: filePointer]! - [interpreterProxy pop: 3 "rcvr, name, writeFlag" - thenPush: filePointer]! Item was changed: ----- Method: FilePlugin>>primitiveFileAtEnd (in category 'file primitives') ----- primitiveFileAtEnd | file atEnd | <export: true> <var: 'file' type: 'SQFile *'> file := self fileValueOf: (interpreterProxy stackValue: 0). interpreterProxy failed ifFalse: [atEnd := self sqFileAtEnd: file]. interpreterProxy failed + ifFalse: [interpreterProxy methodReturnBool: atEnd]! - ifFalse: [interpreterProxy pop: 2. "rcvr, file" - interpreterProxy pushBool: atEnd]! Item was changed: ----- Method: FilePlugin>>primitiveFileDescriptorType (in category 'file primitives') ----- primitiveFileDescriptorType | fileType fd fdPointer | "Allow to test if the standard input/output files are from a console or not Return values: * -1 - Error * 0 - no console (windows only) * 1 - normal terminal (unix terminal / windows console) * 2 - pipe * 3 - file * 4 - cygwin terminal (windows only)" <var: 'fd' type: #int> <export: true> fdPointer := interpreterProxy stackValue: 0. (interpreterProxy isIntegerObject: fdPointer) ifFalse: [^ interpreterProxy primitiveFailFor: PrimErrBadArgument]. fd := interpreterProxy integerValueOf: fdPointer. interpreterProxy failed ifTrue: [ "Ensure that the appropriate failure code has been set" ^interpreterProxy primitiveFailFor: PrimErrBadArgument]. fileType := self cCode: 'sqFileDescriptorType(fd)' inSmalltalk: [1]. + interpreterProxy methodReturnInteger: fileType! - interpreterProxy pop: 2. - interpreterProxy pushInteger: fileType! Item was changed: ----- Method: FilePlugin>>primitiveFileGetPosition (in category 'file primitives') ----- primitiveFileGetPosition | file position | <var: 'file' type: 'SQFile *'> <var: 'position' type: 'squeakFileOffsetType'> <export: true> file := self fileValueOf: (interpreterProxy stackValue: 0). interpreterProxy failed ifFalse: [position := self sqFileGetPosition: file]. interpreterProxy failed ifFalse: [ + interpreterProxy methodReturnValue: (interpreterProxy positive64BitIntegerFor: position)].! - interpreterProxy pop: 2 thenPush: (interpreterProxy positive64BitIntegerFor: position)].! Item was changed: ----- Method: FilePlugin>>primitiveFileOpen (in category 'file primitives') ----- primitiveFileOpen | writeFlag namePointer filePointer nameIndex nameSize | <var: 'nameIndex' type: 'char *'> <export: true> writeFlag := interpreterProxy booleanValueOf: (interpreterProxy stackValue: 0). namePointer := interpreterProxy stackValue: 1. (interpreterProxy isBytes: namePointer) ifFalse: [^ interpreterProxy primitiveFail]. nameIndex := interpreterProxy firstIndexableField: namePointer. nameSize := interpreterProxy byteSizeOf: namePointer. filePointer := self fileOpenName: nameIndex size: nameSize write: writeFlag secure: true. interpreterProxy failed + ifFalse: [interpreterProxy methodReturnValue: filePointer] - ifFalse: [interpreterProxy pop: 3 "rcvr, name, writeFlag" - thenPush: filePointer] ! Item was changed: ----- Method: FilePlugin>>primitiveFileOpenNew (in category 'file primitives') ----- primitiveFileOpenNew | namePointer filePointer nameIndex nameSize | <var: 'nameIndex' type: 'char *'> <export: true> namePointer := interpreterProxy stackValue: 0. (interpreterProxy isBytes: namePointer) ifFalse: [^ interpreterProxy primitiveFail]. nameIndex := interpreterProxy firstIndexableField: namePointer. nameSize := interpreterProxy byteSizeOf: namePointer. filePointer := self fileOpenNewName: nameIndex size: nameSize secure: true. interpreterProxy failed ifFalse: [ + interpreterProxy methodReturnValue: filePointer] - interpreterProxy - pop: 2 "rcvr, name" - thenPush: filePointer] ! Item was changed: ----- Method: FilePlugin>>primitiveFileReadWithPinning (in category 'file primitives') ----- primitiveFileReadWithPinning "This version of primitiveFileRead is for garbage collectors that support pinning." | count startIndex array file slotSize elementSize bytesRead | <inline: true> <var: 'file' type: #'SQFile *'> <var: 'count' type: #'size_t'> <var: 'startIndex' type: #'size_t'> <var: 'slotSize' type: #'size_t'> <var: 'elementSize' type: #'size_t'> count := interpreterProxy positiveMachineIntegerValueOf: (interpreterProxy stackValue: 0). startIndex := interpreterProxy positiveMachineIntegerValueOf: (interpreterProxy stackValue: 1). array := interpreterProxy stackValue: 2. file := self fileValueOf: (interpreterProxy stackValue: 3). (interpreterProxy failed "buffer can be any indexable words or bytes object except CompiledMethod" or: [(interpreterProxy isWordsOrBytes: array) not]) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. slotSize := interpreterProxy slotSizeOf: array. (startIndex >= 1 and: [startIndex + count - 1 <= slotSize]) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. "Note: adjust startIndex for zero-origin byte indexing" elementSize := slotSize = 0 ifTrue: [1] ifFalse: [(interpreterProxy byteSizeOf: array) // slotSize]. bytesRead := self sqFile: file Read: count * elementSize Into: (interpreterProxy cCoerce: (interpreterProxy firstIndexableField: array) to: #'char *') At: startIndex - 1 * elementSize. interpreterProxy failed ifFalse: [interpreterProxy + methodReturnValue: (interpreterProxy integerObjectOf: bytesRead // elementSize) "push # of elements read"]! - pop: 5 "pop rcvr, file, array, startIndex, count" - thenPush:(interpreterProxy integerObjectOf: bytesRead // elementSize) "push # of elements read"]! Item was changed: ----- Method: FilePlugin>>primitiveFileReadWithoutPinning (in category 'file primitives') ----- primitiveFileReadWithoutPinning "This version of primitiveFileRead is for garbage collectors without support for pinning." | retryCount count startIndex array file elementSize bytesRead | <inline: true> <var: 'file' type: #'SQFile *'> <var: 'count' type: #'size_t'> <var: 'startIndex' type: #'size_t'> <var: 'elementSize' type: #'size_t'> retryCount := 0. count := interpreterProxy positive32BitValueOf: (interpreterProxy stackValue: 0). startIndex := interpreterProxy positive32BitValueOf: (interpreterProxy stackValue: 1). [array := interpreterProxy stackValue: 2. file := self fileValueOf: (interpreterProxy stackValue: 3). (interpreterProxy failed "buffer can be any indexable words or bytes object except CompiledMethod" or: [(interpreterProxy isWordsOrBytes: array) not]) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. elementSize := (interpreterProxy isWords: array) ifTrue: [4] ifFalse: [1]. (startIndex >= 1 and: [(startIndex + count - 1) <= (interpreterProxy slotSizeOf: array)]) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. "Note: adjust startIndex for zero-origin indexing" bytesRead := self sqFile: file Read: count * elementSize Into: (interpreterProxy cCoerce: (interpreterProxy firstIndexableField: array) to: #'char *') At: (startIndex - 1) * elementSize. interpreterProxy primitiveFailureCode = PrimErrObjectMayMove and: [(retryCount := retryCount + 1) <= 2] "Two objects, the file and the array can move"] whileTrue: [interpreterProxy tenuringIncrementalGC; primitiveFailFor: PrimNoErr]. interpreterProxy failed ifFalse: [interpreterProxy + methodReturnValue: (interpreterProxy integerObjectOf: bytesRead // elementSize) "push # of elements read"]! - pop: 5 "pop rcvr, file, array, startIndex, count" - thenPush:(interpreterProxy integerObjectOf: bytesRead // elementSize) "push # of elements read"]! Item was changed: ----- Method: FilePlugin>>primitiveFileSize (in category 'file primitives') ----- primitiveFileSize | file size | <var: 'file' type: 'SQFile *'> <var: 'size' type: 'squeakFileOffsetType'> <export: true> file := self fileValueOf: (interpreterProxy stackValue: 0). interpreterProxy failed ifFalse:[size := self sqFileSize: file]. interpreterProxy failed ifFalse: [ + interpreterProxy methodReturnValue: (interpreterProxy positive64BitIntegerFor: size)].! - interpreterProxy pop: 2 thenPush: (interpreterProxy positive64BitIntegerFor: size)].! Item was changed: ----- Method: FilePlugin>>primitiveFileStdioHandles (in category 'file primitives') ----- primitiveFileStdioHandles "Answer an Array of file handles for standard in, standard out and standard error, with nil in entries that are unvailable, e.g. because the platform does not provide standard error, etc. Fail if there are no standard i/o facilities on the platform or if the security plugin denies access or if memory runs out." | fileRecords result validMask | <export: true> <var: 'fileRecords' declareC: 'SQFile fileRecords[3]'> sHFAfn ~= 0 ifTrue: [(self cCode: ' ((sqInt (*)(void))sHFAfn)()' inSmalltalk: [true]) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrUnsupported]]. self cCode: '' inSmalltalk: [fileRecords := Array new: 3]. validMask := self sqFileStdioHandlesInto: fileRecords. validMask = 0 ifTrue: [^interpreterProxy primitiveFailFor: PrimErrUnsupported]. result := interpreterProxy instantiateClass: interpreterProxy classArray indexableSize: 3. result = nil ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoMemory]. interpreterProxy pushRemappableOop: result. 0 to: 2 do: [:index| (validMask bitAnd: (1 << index)) ~= 0 ifTrue: [result := interpreterProxy instantiateClass: interpreterProxy classByteArray indexableSize: self fileRecordSize. result = nil ifTrue: [interpreterProxy popRemappableOop. ^interpreterProxy primitiveFailFor: PrimErrNoMemory]. interpreterProxy storePointer: index ofObject: interpreterProxy topRemappableOop withValue: result. self cCode: [self mem: (interpreterProxy firstIndexableField: result) cp: (self addressOf: (fileRecords at: index)) y: self fileRecordSize] inSmalltalk: [(interpreterProxy firstIndexableField: result) unitSize: interpreterProxy wordSize; at: 0 put: (fileRecords at: index + 1)]]]. "In the non-Spur threaded VM ensure the handles are old, so that sqFileReadIntoAt is unaffected by incremental GCs. See platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c. The Spur VM uses pinning, so it doesn't need the GC." self cppIf: COGMTVM ifTrue: [self cppIf: SPURVM ifTrue: [] ifFalse: [interpreterProxy fullGC]]. result := interpreterProxy popRemappableOop. + interpreterProxy methodReturnValue: result! - interpreterProxy pop: 1 thenPush: result! Item was changed: ----- Method: FilePlugin>>primitiveFileWrite (in category 'file primitives') ----- primitiveFileWrite | count startIndex array file slotSize elementSize bytesWritten | <var: 'file' type: 'SQFile *'> <var: 'count' type: 'size_t'> <var: 'startIndex' type: 'size_t'> <var: 'slotSize' type: #'size_t'> <var: 'elementSize' type: #'size_t'> <export: true> count := interpreterProxy positiveMachineIntegerValueOf: (interpreterProxy stackValue: 0). startIndex := interpreterProxy positiveMachineIntegerValueOf: (interpreterProxy stackValue: 1). array := interpreterProxy stackValue: 2. file := self fileValueOf: (interpreterProxy stackValue: 3). (interpreterProxy failed "buffer can be any indexable words or bytes object except CompiledMethod" or: [(interpreterProxy isWordsOrBytes: array) not]) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. slotSize := interpreterProxy slotSizeOf: array. (startIndex >= 1 and: [startIndex + count - 1 <= slotSize]) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. "Note: adjust startIndex for zero-origin byte indexing" elementSize := slotSize = 0 ifTrue: [1] ifFalse: [(interpreterProxy byteSizeOf: array) // slotSize]. bytesWritten := self sqFile: file Write: count * elementSize From: (interpreterProxy cCoerce: (interpreterProxy firstIndexableField: array) to: #'char *') At: startIndex - 1 * elementSize. interpreterProxy failed ifFalse: + [interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: bytesWritten // elementSize)]! - [interpreterProxy pop: 5 thenPush: (interpreterProxy integerObjectOf: bytesWritten // elementSize)]! Item was changed: ----- Method: FilePlugin>>primitiveHasFileAccess (in category 'security primitives') ----- primitiveHasFileAccess | hasAccess | <export: true> "If the security plugin can be loaded, use it to check . If not, assume it's ok" sHFAfn ~= 0 ifTrue: [hasAccess := self cCode: ' ((sqInt (*)(void))sHFAfn)()' inSmalltalk: [true]] ifFalse: [hasAccess := true]. + interpreterProxy methodReturnBool: hasAccess! - interpreterProxy pop: 1. - interpreterProxy pushBool: hasAccess!

1 0

Build completed: opensmalltalk-vm 1.0.1308
by AppVeyor 11 May '18

11 May '18

1 0

Build failed: opensmalltalk-vm 1.0.1307
by AppVeyor 11 May '18

11 May '18

1 0

Build failed: opensmalltalk-vm 1.0.1306
by AppVeyor 11 May '18

11 May '18

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev May 2018