Vm-dev November 2018

vm-dev@lists.squeakfoundation.org

23 participants
82 discussions

[OpenSmalltalk/opensmalltalk-vm] 5d0e0b: CogVM source as per VMMaker.oscog-eem.2482
by GitHub 08 Nov '18

08 Nov '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 5d0e0bcec2cda9438c8ced76d42336383970740c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/5d0e0bcec2cda9438c… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64SysV.c M nsspur64src/vm/cogitX64WIN64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cogit.h M spur64src/vm/cogitX64SysV.c M spur64src/vm/cogitX64WIN64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/cointerpmt.c M spur64src/vm/cointerpmt.h M spur64src/vm/gcc3x-cointerp.c M spur64src/vm/gcc3x-cointerpmt.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cogitX64SysV.c M spurlowcode64src/vm/cogitX64WIN64.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cogitARMv5.c M spurlowcodesrc/vm/cogitIA32.c M spurlowcodesrc/vm/cogitMIPSEL.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitX64SysV.c M spursista64src/vm/cogitX64WIN64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/cointerpmt.c M spursrc/vm/cointerpmt.h M spursrc/vm/gcc3x-cointerp.c M spursrc/vm/gcc3x-cointerpmt.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/plugins/BitBltPlugin/BitBltPlugin.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2482 Slang Fix mis-handling of trailing boolean on inlining in conditionals when trailing boolean would cause the conditional to be taken. e.g. in self tryCopyingBitsQuickly ifTrue: [^nil]. tryCopyingBitsQuickly ends with ^true but the in lining code handled the trailing ^true by taking the fall-through path past the ^nil. Consequently fix a regression in the BitBlt primitive caused by cleanups in VMMaker.oscog-eem.2461. Regenerate VM files to bring source up to date after minor changes for Slang pointer type normalization in VMMaker.oscog-eem.2476. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

VM Maker: VMMaker.oscog-eem.2482.mcz
by commits＠source.squeak.org 08 Nov '18

08 Nov '18

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2482.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2482 Author: eem Time: 8 November 2018, 12:50:24.101736 pm UUID: 7df020b4-6565-4768-9e4a-75bc5464ed95 Ancestors: VMMaker.oscog-eem.2481 Slang Fix mis-handling of trailing boolean on inlining in conditionals when trailing boolean would cause the conditional to be taken. e.g. in self tryCopyingBitsQuickly ifTrue: [^nil]. tryCopyingBitsQuickly ends with ^true but the in lining code handled the trailing ^true by taking the fall-through path past the ^nil. Comnsequently fix a regression in the BitBlt primitive caused by cleanups in VMMaker.oscog-eem.2461. =============== Diff against VMMaker.oscog-eem.2481 =============== Item was changed: ----- Method: TMethod>>inlineReturningConditional:in: (in category 'inlining') ----- inlineReturningConditional: aSendNode in: aCodeGen "Inline aSend ifTrue:/ifFalse: [^expr] where aSend is inlineable and always answers booleans. We inline ^expr into aSend." | returnIfTrue returnNode replacementTree map lastNode label method | self assert: self == aCodeGen currentMethod. self assert: (self isInlineableConditional: aSendNode in: aCodeGen). aCodeGen maybeBreakForInlineOf: aSendNode receiver in: self. returnIfTrue := aSendNode selector = #ifTrue:. returnNode := aSendNode args first. method := (aCodeGen methodNamed: aSendNode receiver selector) copy. replacementTree := method inlineFunctionCall: aSendNode receiver in: aCodeGen. map := Dictionary new. + "The last node is either a return or a boolean constant." + lastNode := replacementTree statements last. + replacementTree statements last isReturn + ifTrue: + [replacementTree statements last expression value == returnIfTrue ifTrue: + [lastNode := nil "i.e. take the fall-through path and /don't/ return"]] + ifFalse: + [self assert: (lastNode isConstant and: [#(true false) includes: lastNode value]). + lastNode value == returnIfTrue ifTrue: "i.e. /do/ return" + [map at: lastNode put: returnNode]]. - (replacementTree statements last isReturn - and: [replacementTree statements last expression value = returnIfTrue not]) ifTrue: - [lastNode := replacementTree statements last]. replacementTree nodesDo: [:node| | expr | node isReturn ifTrue: [expr := node expression. self assert: (expr isConstant and: [#(true false) includes: expr value]). map at: node put: (expr value == returnIfTrue ifTrue: [returnNode] ifFalse: [node == lastNode ifTrue: [TLabeledCommentNode new setComment: 'end ', aSendNode receiver selector, '; fall through'] ifFalse: [label ifNil: [label := TLabeledCommentNode new setLabel: (self unusedLabelForInlining: method)]. TGoToNode new setLabel: label label]])]]. replacementTree replaceNodesIn: map. self addVarsDeclarationsAndLabelsOf: method except: method args. replacementTree comment: {'inline ', aSendNode receiver selector}. ^label ifNil: [replacementTree] ifNotNil: [TStmtListNode new setArguments: #() statements: {replacementTree. label}]!

1 0

On community development of the VM's platform code...
by Eliot Miranda 08 Nov '18

08 Nov '18

Hi All, this morning I've looked at some platform even t code to address an issue with scrolling that Chris Muller was bitten by. In reading the code I've tried to make the code comprehensible to others who may come to read it. In particular I changed this code in platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m evt.charCode = keyCode; evt.utf32Code = 0; evt.reserved1 = 0; evt.modifiers = (CtrlKeyBit | OptionKeyBit | CommandKeyBit | ShiftKeyBit); evt.windowIndex = windowIndex; [self pushEventToQueue:(sqInputEvent *) &evt]; to read evt.charCode = keyCode; evt.utf32Code = 0; evt.reserved1 = 0; /* Set every meta bit to distinguish the fake event from a real right/left * arrow. */ evt.modifiers = (CtrlKeyBit | OptionKeyBit | CommandKeyBit | ShiftKeyBit); evt.windowIndex = windowIndex; [self pushEventToQueue:(sqInputEvent *) &evt]; After all, what the code does is obvious, but /why/ the code does what it does is not at all obvious. In reading similar code on the other platforms I see things like this, an example from platforms/win32/vm/sqWin32Window.c: evt->modifiers = CtrlKeyBit; #ifdef PharoVM evt->utf32Code = evt->charCode; #else evt->utf32Code = 0; #endif evt->reserved1 = 0; Again, *why* the code sets utf32Code but not on Squeak, Newspeak, etc, is not at all obvious and it would be really helpful if it were commented so that the decision as to whether the ifdef might be eliminated and the code always set6 (surely preferable) would be made easier. The lack of such comments makes managing this code very hard for those of us that are not platform experts but must maintain the code across all platforms because that's our lot in life. The absence of such comments, when one is struggling to figure out what the hell is going on, feels like passive aggression ;-) So if you've made some m modification to the platform code in the past few years and you haven't commented it to explain the *why*, please feel free to comment the code and commit or submit a pull request; it will be warmly appreciated. Thank you! _,,,^..^,,,_ best, Eliot

4 4

Build completed: opensmalltalk-vm 1.0.1455
by AppVeyor 07 Nov '18

07 Nov '18

1 0

Broken: OpenSmalltalk/opensmalltalk-vm#1476 (Cog - d964e74)
by Travis CI 07 Nov '18

07 Nov '18

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1476 Status: Broken Duration: 4 mins and 51 secs Commit: d964e74 (Cog) Author: Eliot Miranda Message: On X11, set all meta bits for arrow key events synthesized from mouse wheel events to distingusih them from real arrow key events. This is an attempt at compatibility with the Mac. The same approach might also be appropriate on Windows. Minor clean ups and added commentary. View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/fe517ee146c2...d9… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/451953485?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

Broken: OpenSmalltalk/opensmalltalk-vm#1476 (Cog - d964e74)
by Travis CI 07 Nov '18

07 Nov '18

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1476 Status: Broken Duration: 9 mins and 44 secs Commit: d964e74 (Cog) Author: Eliot Miranda Message: On X11, set all meta bits for arrow key events synthesized from mouse wheel events to distingusih them from real arrow key events. This is an attempt at compatibility with the Mac. The same approach might also be appropriate on Windows. Minor clean ups and added commentary. View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/fe517ee146c2...d9… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/451953485?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

Re: [Vm-dev] [squeak-dev] VM sending keystrokes on mouse-wheel?
by Eliot Miranda 07 Nov '18

07 Nov '18

Hi Tom, Hi Chris, see commit d964e7 which has the X11 code do the same as the iOS code. I'd love it if someone who knows Windows would test the same thing there-on. Also, are the "#ifndef NO_WHEEL_MOUSE" defines necessary (eg perhaps required for WINCE) ? It would be lovely just to include the code unadorned by the noise, or to use something less tacky such as "#if defined(WM_MOUSEWHEEL)". Chris, can you see if this fixes your issue? On Tue, Nov 6, 2018 at 7:16 PM Beckmann, Tom < Tom.Beckmann(a)student.hpi.uni-potsdam.de> wrote: > Hi, > > I'm also on Linux-x64, experiencing the same issue. If I'm not missing > something, it should boil down to this PR > https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/155/files and the > fact that HandMorph>>filterEvent:for: only translate Ctrl+up/down, while > passing on Ctrl+left/right as normal key events. > > So the VM now generates Ctrl+left/right whenever you (accidentally) scroll > horizontally, this moves the cursor by a word, which in turn instructs the > text view to scroll back to the area where the cursor currently is. > > Best, > Tom > > > ------------------------------ > *From:* Squeak-dev <squeak-dev-bounces(a)lists.squeakfoundation.org> on > behalf of Eliot Miranda <eliot.miranda(a)gmail.com> > *Sent:* Wednesday, November 7, 2018 3:50 AM > *To:* Chris Muller; The general-purpose Squeak developers list > *Subject:* Re: [squeak-dev] VM sending keystrokes on mouse-wheel? > > Hi Chris, > > On Tue, Nov 6, 2018 at 4:44 PM Chris Muller <asqueaker(a)gmail.com> wrote: > >> > > Surefire way to reproduce: >> > >> > Weird. Tried that and simply can't replicate it. What platform are you >> using? >> >> Linux x64. >> >> Give how little time there has been since the 20180726 VM, I hoped >> Eliot would have a good suspect for the cause based on his knowledge >> of the changes that went in since then, and my account of the symptom. >> >> I've gone back to the 20180726 VM on my machines but, IMO, this seems >> significant enough to be worth fixing in the 5.2 release. We could >> simply revert to the VM we tested, 20180726. >> > > I'm n to Aware off any changes to event handling in X11 between those two > VMs. Since the bug seems to be timing related it is not inconceivable that > the issue iOS that the newer VM is faster and that hence the bug manifests > because the newer VM is faster, not that it processes mouse wheel events > any different. SO before we condemn the current VM can we please look for > candidate changes and do some more careful analysis of the bug. So far > we're identifying symptoms not causes, and until the bug is explained > simply reverting the VM is not being objective. > > >> >> >> >> > >> > >> > tim >> > -- >> > tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim >> > Breakthrough: It finally booted on the first try. >> > >> > >> > >> >> > > -- > _,,,^..^,,,_ > best, Eliot > > -- _,,,^..^,,,_ best, Eliot

1 0

[OpenSmalltalk/opensmalltalk-vm] d964e7: On X11, set all meta bits for arrow key events syn...
by GitHub 07 Nov '18

07 Nov '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: d964e7448494bffdb07a16c4caaa97f861745e70 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/d964e7448494bffdb0… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2018-11-07 (Wed, 07 Nov 2018) Changed paths: M platforms/iOS/vm/OSX/SqueakOSXAppDelegate.m M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m M platforms/unix/vm-display-X11/sqUnixX11.c M platforms/win32/vm/sqWin32Window.c Log Message: ----------- On X11, set all meta bits for arrow key events synthesized from mouse wheel events to distingusih them from real arrow key events. This is an attempt at compatibility with the Mac. The same approach might also be appropriate on Windows. Minor clean ups and added commentary. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

Re: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Added X11 support for horizontal scroll wheel. (#155)
by Eliot Miranda 07 Nov '18

07 Nov '18

and on iOS (the Cocoa Mac OS/iPhone platforms) the same approach is taken in fakeMouseWheelKeyboardEventsKeyCode:windowIndex: evt.modifiers = (CtrlKeyBit | OptionKeyBit | CommandKeyBit | ShiftKeyBit); So I shall modify the X11 code to do the same. And I shall comment the code. These things NEED TO BE COMMENTED :-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/155#issuecomment-436…

1 0

Passed: OpenSmalltalk/opensmalltalk-vm#1475 (Cog - fe517ee)
by Travis CI 07 Nov '18

07 Nov '18

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1475 Status: Passed Duration: 57 mins and 31 secs Commit: fe517ee (Cog) Author: Eliot Miranda Message: Add Squeak3D to linux and Windows Squeak VM builds. Can people test on those platforms, especially 64-bits? View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/d6237f777d89...fe… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/451328993?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

3 2

← Newer
1
2
3
4
5
6
7
8
9
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev November 2018