Vm-dev October 2018

vm-dev@lists.squeakfoundation.org

36 participants
189 discussions

[OpenSmalltalk/opensmalltalk-vm] 8c4b25: replace valloc() with mmap() when allocating execu...
by GitHub 31 Oct '18

31 Oct '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 8c4b25a5532c12089576b5bc234607e3d14d14af https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/8c4b25a5532c120895… Author: Bob Westergaard <bwestergaard(a)gmail.com> Date: 2018-10-30 (Tue, 30 Oct 2018) Changed paths: M platforms/Cross/plugins/IA32ABI/ia32abicc.c M platforms/Cross/plugins/IA32ABI/x64sysvabicc.c Log Message: ----------- replace valloc() with mmap() when allocating executable pages for callbacks Under linux, if SELinux is enabled (i.e. not permisive or disabled), then the heap memory allocated with vmalloc() and marked as executable with mprotect() will fail. In order to have this work with SELinux enabled (and not providing a module policy file to allow execheap) mmap() should be used. Note, it might be possible to remove the stdlib.h and sys/mman.h header file references. Commit: c7a9b1f28b01743dd86fc83c59e10f17c2fd2dbe https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c7a9b1f28b01743dd8… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2018-10-31 (Wed, 31 Oct 2018) Changed paths: M platforms/Cross/plugins/IA32ABI/ia32abicc.c M platforms/Cross/plugins/IA32ABI/x64sysvabicc.c Log Message: ----------- Merge pull request #299 from bwestergaard/ditch-valloc replace valloc() with mmap() when allocating executable pages for cal… Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/3354ee22a58e...c7… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[OpenSmalltalk/opensmalltalk-vm] 3354ee: CogVM source as per VMMaker.oscog-eem.2480
by GitHub 31 Oct '18

31 Oct '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 3354ee22a58e8d22c3c06883d44f672b196738e7 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3354ee22a58e8d22c3… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2018-10-31 (Wed, 31 Oct 2018) Changed paths: M src/plugins/ADPCMCodecPlugin/ADPCMCodecPlugin.c M src/plugins/AioPlugin/AioPlugin.c M src/plugins/AsynchFilePlugin/AsynchFilePlugin.c M src/plugins/B2DPlugin/B2DPlugin.c M src/plugins/B3DAcceleratorPlugin/B3DAcceleratorPlugin.c M src/plugins/BMPReadWriterPlugin/BMPReadWriterPlugin.c M src/plugins/BitBltPlugin/BitBltPlugin.c M src/plugins/BochsIA32Plugin/BochsIA32Plugin.c M src/plugins/BochsX64Plugin/BochsX64Plugin.c M src/plugins/CameraPlugin/CameraPlugin.c M src/plugins/CroquetPlugin/CroquetPlugin.c M src/plugins/DESPlugin/DESPlugin.c M src/plugins/DSAPrims/DSAPrims.c M src/plugins/DropPlugin/DropPlugin.c M src/plugins/FFTPlugin/FFTPlugin.c M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c M src/plugins/FileCopyPlugin/FileCopyPlugin.c M src/plugins/FilePlugin/FilePlugin.c M src/plugins/FloatArrayPlugin/FloatArrayPlugin.c M src/plugins/FloatMathPlugin/FloatMathPlugin.c M src/plugins/GdbARMPlugin/GdbARMPlugin.c M src/plugins/GeniePlugin/GeniePlugin.c M src/plugins/HostWindowPlugin/HostWindowPlugin.c M src/plugins/IA32ABI/IA32ABI.c M src/plugins/ImmX11Plugin/ImmX11Plugin.c M src/plugins/InternetConfigPlugin/InternetConfigPlugin.c M src/plugins/JPEGReadWriter2Plugin/JPEGReadWriter2Plugin.c M src/plugins/JPEGReaderPlugin/JPEGReaderPlugin.c M src/plugins/JoystickTabletPlugin/JoystickTabletPlugin.c M src/plugins/Klatt/Klatt.c M src/plugins/LargeIntegers/LargeIntegers.c M src/plugins/LocalePlugin/LocalePlugin.c M src/plugins/MD5Plugin/MD5Plugin.c M src/plugins/MIDIPlugin/MIDIPlugin.c M src/plugins/MacMenubarPlugin/MacMenubarPlugin.c M src/plugins/Matrix2x3Plugin/Matrix2x3Plugin.c M src/plugins/MiscPrimitivePlugin/MiscPrimitivePlugin.c M src/plugins/Mpeg3Plugin/Mpeg3Plugin.c M src/plugins/QuicktimePlugin/QuicktimePlugin.c M src/plugins/RePlugin/RePlugin.c M src/plugins/SHA256Plugin/SHA256Plugin.c M src/plugins/ScratchPlugin/ScratchPlugin.c M src/plugins/SecurityPlugin/SecurityPlugin.c M src/plugins/SerialPlugin/SerialPlugin.c M src/plugins/SocketPlugin/SocketPlugin.c M src/plugins/SoundCodecPrims/SoundCodecPrims.c M src/plugins/SoundGenerationPlugin/SoundGenerationPlugin.c M src/plugins/SoundPlugin/SoundPlugin.c M src/plugins/Squeak3D/Squeak3D.c M src/plugins/SqueakFFIPrims/ARM32FFIPlugin.c M src/plugins/SqueakFFIPrims/IA32FFIPlugin.c M src/plugins/SqueakFFIPrims/X64SysVFFIPlugin.c M src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c M src/plugins/SqueakSSL/SqueakSSL.c M src/plugins/StarSqueakPlugin/StarSqueakPlugin.c M src/plugins/UUIDPlugin/UUIDPlugin.c M src/plugins/UnicodePlugin/UnicodePlugin.c M src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c M src/plugins/VMProfileLinuxSupportPlugin/VMProfileLinuxSupportPlugin.c M src/plugins/VMProfileMacSupportPlugin/VMProfileMacSupportPlugin.c M src/plugins/WeDoPlugin/WeDoPlugin.c M src/plugins/Win32OSProcessPlugin/Win32OSProcessPlugin.c M src/plugins/XDisplayControlPlugin/XDisplayControlPlugin.c M src/plugins/ZipPlugin/ZipPlugin.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2480 Slang: Provide some clean up of pointer types in TMethods and type extraction, ensuring there's a space before any trailing *'s. Plugins: Fix primDigitCompare for SmallIntegers. The old code compared the values of the receiver and argument, not their magnitudes, if both were SmallIntegers. Simplify FilePlugin. removing an unnecessary indirection around dir_Delimitor. Remove null implementations of initialiseModule and/or shutdownModule. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[OpenSmalltalk/opensmalltalk-vm] Consume all events in the event queue to avoid application lockups (#300)
by Guille Polito 31 Oct '18

31 Oct '18

It seems that "peeking" from the event queue does not yield events in case of changing resolutions: ``` NSApp nextEventMatchingMask:NSEventMaskAny untilDate:nil inMode:NSEventTrackingRunLoopMode dequeue: ***NO*** ``` And then it never enters the loop... Of course, apple's doc says nothing about this: https://developer.apple.com/documentation/appkit/nsapplication/1428485-next… So all this is speculation ^^. This new version consumes all pending events in the NSApp, and it does not show any lockups when e.g., switching resolutions. If the event does not correspond to this window, we take it from the event queue anyways and re-post it afterwards, to give other windows the opportunity to consume their events. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/300 -- Commit Summary -- * Consume all events in the event queue to avoid application lockups -- File Changes -- M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (50) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/300.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/300.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/300

2 1

[OpenSmalltalk/opensmalltalk-vm] b6cb19: Consume all events in the event queue to avoid app...
by GitHub 31 Oct '18

31 Oct '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: b6cb1927f39786de37d829a8677fe9cac2693a94 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b6cb1927f39786de37… Author: Guille Polito <guillermopolito(a)gmail.com> Date: 2018-10-31 (Wed, 31 Oct 2018) Changed paths: M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m Log Message: ----------- Consume all events in the event queue to avoid application lockups Commit: 6fee3a7eb14686249385bf7b457c635cc6d5b921 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/6fee3a7eb146862493… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2018-10-31 (Wed, 31 Oct 2018) Changed paths: M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m Log Message: ----------- Merge pull request #300 from guillep/fix/osx/events Consume all events in the event queue to avoid application lockups Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/df9064a91430...6f… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

VM Maker: VMMaker.oscog-eem.2479.mcz
by commits＠source.squeak.org 30 Oct '18

30 Oct '18

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2479.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2479 Author: eem Time: 29 October 2018, 6:00:57.748695 pm UUID: b191888c-6777-483b-82b4-121103743ebf Ancestors: VMMaker.oscog-eem.2478 Plugins: Fix slip in primitiveDirectoryDelimitor. Eliminate cCode:inSmalltalk:'s from the B3DAcceleratorPlugin =============== Diff against VMMaker.oscog-eem.2478 =============== Item was changed: ----- Method: B3DAcceleratorPlugin>>loadClientState:vertices:colors:normals:texCoords: (in category 'primitives-qwaq') ----- loadClientState: handle vertices: vertices colors: colors normals: normals texCoords: texCoords "Common method to set up client state for some render ops" | nilOop vtxSize sz colorPtr normalPtr txPtr vertexPtr ok | <var: #colorPtr type: 'void *'> <var: #normalPtr type: 'void *'> <var: #txPtr type: 'void *'> <var: #vertexPtr type: 'void *'> colorPtr := normalPtr := txPtr := vertexPtr := nil. sz := 0. "Verify vertex data" (interpreterProxy isWords: vertices) ifFalse: [^interpreterProxy primitiveFail]. vtxSize := (interpreterProxy slotSizeOf: vertices) / 3. "Verify assumptions of color, normal, texCoords data" nilOop := interpreterProxy nilObject. (colors = nilOop or: [(interpreterProxy isWords: colors) and: [(interpreterProxy slotSizeOf: colors) = (vtxSize * 4)]]) ifFalse: [^interpreterProxy primitiveFail]. (normals = nilOop or: [(interpreterProxy isWords: normals) and: [(interpreterProxy slotSizeOf: normals) = (vtxSize * 3)]]) ifFalse: [^interpreterProxy primitiveFail]. "Don't check size for texCoords since they can be 2,3,4 elements" (texCoords = nilOop or: [(interpreterProxy isWords: texCoords)]) ifFalse: [^interpreterProxy primitiveFail]. "Finally submit the data to OpenGL" colors = nilOop ifFalse: [colorPtr := interpreterProxy firstIndexableField: colors]. normals = nilOop ifFalse: [normalPtr := interpreterProxy firstIndexableField: normals]. texCoords = nilOop ifFalse: [sz := (interpreterProxy slotSizeOf: texCoords) / vtxSize. txPtr := interpreterProxy firstIndexableField: texCoords]. vertexPtr := interpreterProxy firstIndexableField: vertices. interpreterProxy failed ifFalse: + [ok := self b3dLoadClientState: handle _: vertexPtr _: 3 _: colorPtr _: 4 _: normalPtr _: 3 _: txPtr _: sz. - [ok := self - cCode:'b3dLoadClientState(handle, vertexPtr, 3, colorPtr, 4, normalPtr, 3, txPtr, sz)' - inSmalltalk: [vertexPtr. colorPtr. normalPtr. txPtr. sz touch]. ok ifFalse: [interpreterProxy primitiveFail]]. ^nil "keep compiler quiet" ! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveAllocateTexture (in category 'primitives-textures') ----- primitiveAllocateTexture | h w d result renderer | <export: true> interpreterProxy methodArgumentCount = 4 ifFalse:[^interpreterProxy primitiveFail]. h := interpreterProxy stackIntegerValue: 0. w := interpreterProxy stackIntegerValue: 1. d := interpreterProxy stackIntegerValue: 2. renderer := interpreterProxy stackIntegerValue: 3. interpreterProxy failed ifTrue:[^nil]. + result := self b3dxAllocateTexture: renderer _: w _: h _: d. - result := self cCode:'b3dxAllocateTexture(renderer, w, h, d)' inSmalltalk:[-1]. result = -1 ifTrue:[^interpreterProxy primitiveFail]. interpreterProxy pop: 5. "args+rcvr" ^interpreterProxy pushInteger: result.! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveCompositeTexture (in category 'primitives-textures') ----- primitiveCompositeTexture | result translucent y x w h texHandle rendererHandle | <export: true> interpreterProxy methodArgumentCount = 7 ifFalse:[^interpreterProxy primitiveFail]. translucent := interpreterProxy booleanValueOf: (interpreterProxy stackValue: 0). h := interpreterProxy stackIntegerValue: 1. w := interpreterProxy stackIntegerValue: 2. y := interpreterProxy stackIntegerValue: 3. x := interpreterProxy stackIntegerValue: 4. texHandle := interpreterProxy stackIntegerValue: 5. rendererHandle := interpreterProxy stackIntegerValue: 6. interpreterProxy failed ifTrue:[^nil]. + result := self b3dxCompositeTexture: rendererHandle _: texHandle _: x _: y _: w _: h _: translucent. - result := self cCode:'b3dxCompositeTexture(rendererHandle, texHandle, x, y, w, h, translucent)' inSmalltalk:[false]. result ifFalse:[^interpreterProxy primitiveFail]. ^interpreterProxy pop: 7. "args" ! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveDestroyRenderer (in category 'primitives-renderer') ----- primitiveDestroyRenderer | handle result | <export: true> interpreterProxy methodArgumentCount = 1 ifFalse:[^interpreterProxy primitiveFail]. handle := interpreterProxy stackIntegerValue: 0. interpreterProxy failed ifTrue:[^nil]. + result := self b3dxDestroyRenderer: handle. - result := self cCode:'b3dxDestroyRenderer(handle)' inSmalltalk:[false]. result ifFalse:[^interpreterProxy primitiveFail]. ^interpreterProxy pop: 1. "pop arg; return rcvr"! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveDestroyTexture (in category 'primitives-textures') ----- primitiveDestroyTexture | handle result renderer | <export: true> interpreterProxy methodArgumentCount = 2 ifFalse:[^interpreterProxy primitiveFail]. handle := interpreterProxy stackIntegerValue: 0. renderer := interpreterProxy stackIntegerValue: 1. interpreterProxy failed ifTrue:[^nil]. + result := self b3dxDestroyTexture: renderer _: handle. - result := self cCode:'b3dxDestroyTexture(renderer, handle)' inSmalltalk:[false]. result ifFalse:[^interpreterProxy primitiveFail]. ^interpreterProxy pop: 2. "pop arg; return rcvr"! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveDrawArrays (in category 'primitives-qwaq') ----- primitiveDrawArrays "Primitive. Setup non-VBO client state and call drawRangeElements in one go to avoid garbage collection to move the buffers underneith." | maxIdx minIdx mode texCoords normals colors vertices handle vtxSize ok | <export: true> interpreterProxy methodArgumentCount = 8 ifFalse: [^interpreterProxy primitiveFail]. maxIdx := interpreterProxy stackIntegerValue: 0. minIdx := interpreterProxy stackIntegerValue: 1. mode := interpreterProxy stackIntegerValue: 2. texCoords := interpreterProxy stackValue: 3. normals := interpreterProxy stackValue: 4. colors := interpreterProxy stackValue: 5. vertices := interpreterProxy stackValue: 6. handle := interpreterProxy stackIntegerValue: 7. self loadClientState: handle vertices: vertices colors: colors normals: normals texCoords: texCoords. interpreterProxy failed ifTrue:[^nil]. doRangeChecks ifTrue: ["Verify the vertex data itself" self checkVertexData: vertices. "Verify min-max range in bounds for given vertex array" vtxSize := (interpreterProxy slotSizeOf: vertices) / 3. (minIdx < 0 or:[minIdx > maxIdx or:[maxIdx > vtxSize]]) ifTrue: [interpreterProxy primitiveFail]]. interpreterProxy failed ifFalse: + [ok := self b3dDrawArrays: handle _: mode _: minIdx _: maxIdx. - [ok := self cCode: 'b3dDrawArrays(handle, mode, minIdx, maxIdx)' - inSmalltalk:[mode. false]. ok ifTrue: [interpreterProxy pop: interpreterProxy methodArgumentCount]]. ^nil "keep compiler quiet" ! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveDrawElements (in category 'primitives-qwaq') ----- primitiveDrawElements "Primitive. Setup non-VBO client state and call drawElements in one go to avoid garbage collection to move the buffers underneith." | faces mode texCoords normals colors vertices handle ok facePtr faceSize | <export: true> <var: #facePtr type: 'unsigned int *'> interpreterProxy methodArgumentCount = 7 ifFalse: [^interpreterProxy primitiveFail]. faces := interpreterProxy stackValue: 0. (interpreterProxy isWords: faces) ifFalse: [^interpreterProxy primitiveFail]. faceSize := interpreterProxy slotSizeOf: faces. facePtr := interpreterProxy firstIndexableField: faces. mode := interpreterProxy stackIntegerValue: 1. texCoords := interpreterProxy stackValue: 2. normals := interpreterProxy stackValue: 3. colors := interpreterProxy stackValue: 4. vertices := interpreterProxy stackValue: 5. handle := interpreterProxy stackIntegerValue: 6. self loadClientState: handle vertices: vertices colors: colors normals: normals texCoords: texCoords. interpreterProxy failed ifTrue:[^nil]. doRangeChecks ifTrue: ["Verify the vertex data itself" self checkVertexData: vertices. "Change bounds range to make sure the data is valid" self checkBoundsRange: vertices faces: facePtr count: faceSize]. interpreterProxy failed ifFalse: + [ok := self b3dDrawElements: handle _: mode _: faceSize _: facePtr. - [ok := self cCode: 'b3dDrawElements(handle, mode, faceSize, facePtr)' - inSmalltalk:[mode. facePtr. false]. ok ifTrue: [interpreterProxy pop: interpreterProxy methodArgumentCount]]. ^nil "keep compiler quiet" ! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveDrawRangeElements (in category 'primitives-qwaq') ----- primitiveDrawRangeElements "Primitive. Setup non-VBO client state and call drawRangeElements in one go to avoid garbage collection to move the buffers underneith." | faces maxIdx minIdx mode texCoords normals colors vertices handle vtxSize ok facePtr faceSize | <export: true> <var: #facePtr type: 'unsigned int *'> interpreterProxy methodArgumentCount = 9 ifFalse: [^interpreterProxy primitiveFail]. faces := interpreterProxy stackValue: 0. (interpreterProxy isWords: faces) ifFalse: [^interpreterProxy primitiveFail]. faceSize := interpreterProxy slotSizeOf: faces. facePtr := interpreterProxy firstIndexableField: faces. maxIdx := interpreterProxy stackIntegerValue: 1. minIdx := interpreterProxy stackIntegerValue: 2. mode := interpreterProxy stackIntegerValue: 3. texCoords := interpreterProxy stackValue: 4. normals := interpreterProxy stackValue: 5. colors := interpreterProxy stackValue: 6. vertices := interpreterProxy stackValue: 7. handle := interpreterProxy stackIntegerValue: 8. self loadClientState: handle vertices: vertices colors: colors normals: normals texCoords: texCoords. interpreterProxy failed ifTrue:[^nil]. doRangeChecks ifTrue: ["Verify the vertex data itself" self checkVertexData: vertices. "Change bounds range to make sure the data is valid" self checkBoundsRange: vertices faces: facePtr count: faceSize. "Verify min-max range in bounds for given vertex array" vtxSize := (interpreterProxy slotSizeOf: vertices) / 3. (minIdx < 0 or:[minIdx > maxIdx or:[maxIdx > vtxSize]]) ifTrue: [interpreterProxy primitiveFail]]. interpreterProxy failed ifFalse: + [ok := self b3dDrawRangeElements: handle _: mode _: minIdx _: maxIdx _: faceSize _: facePtr. - [ok := self cCode: 'b3dDrawRangeElements(handle, mode, minIdx, maxIdx, faceSize, facePtr)' - inSmalltalk:[mode. facePtr. false]. ok ifTrue: [interpreterProxy pop: interpreterProxy methodArgumentCount]]. ^nil "keep compiler quiet" ! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveFinishRenderer (in category 'primitives-renderer') ----- primitiveFinishRenderer | handle result | <export: true> interpreterProxy methodArgumentCount = 1 ifFalse:[^interpreterProxy primitiveFail]. handle := interpreterProxy stackIntegerValue: 0. interpreterProxy failed ifTrue:[^nil]. + result := self b3dxFinishRenderer: handle. - result := self cCode:'b3dxFinishRenderer(handle)' inSmalltalk:[false]. result ifFalse:[^interpreterProxy primitiveFail]. ^interpreterProxy pop: 1. "pop arg; return rcvr"! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveFlushRenderer (in category 'primitives-renderer') ----- primitiveFlushRenderer | handle result | <export: true> interpreterProxy methodArgumentCount = 1 ifFalse:[^interpreterProxy primitiveFail]. handle := interpreterProxy stackIntegerValue: 0. interpreterProxy failed ifTrue:[^nil]. + result := self b3dxFlushRenderer: handle. - result := self cCode:'b3dxFlushRenderer(handle)' inSmalltalk:[false]. result ifFalse:[^interpreterProxy primitiveFail]. ^interpreterProxy pop: 1. "pop arg; return rcvr"! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveGetRendererColorMasks (in category 'primitives-renderer') ----- primitiveGetRendererColorMasks | handle masks array | <export: true> <var: #masks declareC:'unsigned int masks[4]'> interpreterProxy methodArgumentCount = 2 ifFalse:[^interpreterProxy primitiveFail]. array := interpreterProxy stackObjectValue: 0. handle := interpreterProxy stackIntegerValue: 1. interpreterProxy failed ifTrue:[^nil]. ((interpreterProxy isArray: array) and: [(interpreterProxy slotSizeOf: array) = 4 + and: [self b3dxGetRendererColorMasks: handle _: masks]]) - and: [self cCode:'b3dxGetRendererColorMasks(handle, masks)' inSmalltalk:[false]]]) ifFalse:[^interpreterProxy primitiveFail]. interpreterProxy pushRemappableOop: array. 0 to: 3 do: [:i| interpreterProxy storePointer: i ofObject: interpreterProxy topRemappableOop withValue: (interpreterProxy positive32BitIntegerFor: (masks at: i))]. interpreterProxy popRemappableOop. ^interpreterProxy pop: 2 "pop args return receiver"! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveGetRendererSurfaceDepth (in category 'primitives-renderer') ----- primitiveGetRendererSurfaceDepth | handle result | <export: true> interpreterProxy methodArgumentCount = 1 ifFalse:[^interpreterProxy primitiveFail]. handle := interpreterProxy stackIntegerValue: 0. interpreterProxy failed ifTrue:[^nil]. + result := self b3dxGetRendererSurfaceDepth: handle. - result := self cCode:'b3dxGetRendererSurfaceDepth(handle)' inSmalltalk:[-1]. result < 0 ifTrue:[^interpreterProxy primitiveFail]. interpreterProxy pop: 2. "args+rcvr" ^interpreterProxy pushInteger: result! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveGetRendererSurfaceHandle (in category 'primitives-renderer') ----- primitiveGetRendererSurfaceHandle | handle result | <export: true> interpreterProxy methodArgumentCount = 1 ifFalse:[^interpreterProxy primitiveFail]. handle := interpreterProxy stackIntegerValue: 0. interpreterProxy failed ifTrue:[^nil]. + result := self b3dxGetRendererSurfaceHandle: handle. - result := self cCode:'b3dxGetRendererSurfaceHandle(handle)' inSmalltalk:[-1]. result < 0 ifTrue:[^interpreterProxy primitiveFail]. interpreterProxy pop: 2. "args+rcvr" ^interpreterProxy pushInteger: result! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveGetRendererSurfaceHeight (in category 'primitives-renderer') ----- primitiveGetRendererSurfaceHeight | handle result | <export: true> interpreterProxy methodArgumentCount = 1 ifFalse:[^interpreterProxy primitiveFail]. handle := interpreterProxy stackIntegerValue: 0. interpreterProxy failed ifTrue:[^nil]. + result := self b3dxGetRendererSurfaceHeight: handle. - result := self cCode:'b3dxGetRendererSurfaceHeight(handle)' inSmalltalk:[-1]. result < 0 ifTrue:[^interpreterProxy primitiveFail]. interpreterProxy pop: 2. "args+rcvr" ^interpreterProxy pushInteger: result! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveGetRendererSurfaceWidth (in category 'primitives-renderer') ----- primitiveGetRendererSurfaceWidth | handle result | <export: true> interpreterProxy methodArgumentCount = 1 ifFalse:[^interpreterProxy primitiveFail]. handle := interpreterProxy stackIntegerValue: 0. interpreterProxy failed ifTrue:[^nil]. + result := self b3dxGetRendererSurfaceWidth: handle. - result := self cCode:'b3dxGetRendererSurfaceWidth(handle)' inSmalltalk:[-1]. result < 0 ifTrue:[^interpreterProxy primitiveFail]. interpreterProxy pop: 2. "args+rcvr" ^interpreterProxy pushInteger: result! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveIsOverlayRenderer (in category 'primitives-renderer') ----- primitiveIsOverlayRenderer | handle result | <export: true> interpreterProxy methodArgumentCount = 1 ifFalse:[^interpreterProxy primitiveFail]. handle := interpreterProxy stackIntegerValue: 0. interpreterProxy failed ifTrue:[^nil]. + result := self b3dxIsOverlayRenderer: handle. - result := self cCode:'b3dxIsOverlayRenderer(handle)' inSmalltalk:[false]. interpreterProxy pop: 2. "args+rcvr" ^interpreterProxy pushBool: result.! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveRenderVertexBuffer (in category 'primitives-renderer') ----- primitiveRenderVertexBuffer | idxCount vtxCount vtxArray idxArray texHandle primType result flags handle | <export: true> <var: #idxArray type: 'int *'> <var: #vtxArray type: 'float *'> interpreterProxy methodArgumentCount = 8 ifFalse:[^interpreterProxy primitiveFail]. idxCount := interpreterProxy stackIntegerValue: 0. vtxCount := interpreterProxy stackIntegerValue: 2. texHandle := interpreterProxy stackIntegerValue: 4. flags := interpreterProxy stackIntegerValue: 5. primType := interpreterProxy stackIntegerValue: 6. handle := interpreterProxy stackIntegerValue: 7. interpreterProxy failed ifTrue:[^nil]. vtxArray := self stackPrimitiveVertexArray: 3 ofSize: vtxCount. idxArray := self stackPrimitiveIndexArray: 1 ofSize: idxCount validate: true forVertexSize: vtxCount. (vtxArray == nil or:[idxArray == nil or:[primType < 1 or:[primType > 6 or:[interpreterProxy failed]]]]) ifTrue:[^interpreterProxy primitiveFail]. + result := self b3dxRenderVertexBuffer: handle _: primType _: flags _: texHandle _: vtxArray _: vtxCount _: idxArray _: idxCount. - result := self cCode:'b3dxRenderVertexBuffer(handle, primType, flags, texHandle, vtxArray, vtxCount, idxArray, idxCount)' inSmalltalk:[false]. result ifFalse:[^interpreterProxy primitiveFail]. ^interpreterProxy pop: 8. "pop args; return rcvr"! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveSetLights (in category 'primitives-renderer') ----- primitiveSetLights | lightArray lightCount light handle | <export: true> + <var: #light type: #'void *'> - <inline: false> - <var: #light type: 'void*'> interpreterProxy methodArgumentCount = 2 ifFalse:[^interpreterProxy primitiveFail]. lightArray := self stackLightArrayValue: 0. handle := interpreterProxy stackIntegerValue: 1. interpreterProxy failed ifTrue:[^nil]. (self b3dxDisableLights: handle) ifFalse:[^interpreterProxy primitiveFail]. + lightArray ifNil: [^nil]. - lightArray == nil ifTrue:[^nil]. lightCount := interpreterProxy slotSizeOf: lightArray. "For each enabled light source" 0 to: lightCount-1 do:[:i| light := self fetchLightSource: i ofObject: lightArray. + (self b3dxLoadLight: handle _: i _: light) ifFalse: + [^interpreterProxy primitiveFail]. - (self cCode:'b3dxLoadLight(handle, i, light)' inSmalltalk:[false]) - ifFalse:[^interpreterProxy primitiveFail]. ]. ^interpreterProxy pop: 2. "args; return rcvr"! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveSetMaterial (in category 'primitives-renderer') ----- primitiveSetMaterial | material handle | <export: true> <inline: false> <var: #material type: 'void*'> interpreterProxy methodArgumentCount = 2 ifFalse:[^interpreterProxy primitiveFail]. material := self stackMaterialValue: 0. handle := interpreterProxy stackIntegerValue: 1. + (self b3dxLoadMaterial: handle _: material) - (self cCode:'b3dxLoadMaterial(handle, material)' inSmalltalk:[false]) ifFalse:[^interpreterProxy primitiveFail]. ^interpreterProxy pop: 2. "args; return rcvr"! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveSwapRendererBuffers (in category 'primitives-renderer') ----- primitiveSwapRendererBuffers | handle result | <export: true> interpreterProxy methodArgumentCount = 1 ifFalse:[^interpreterProxy primitiveFail]. handle := interpreterProxy stackIntegerValue: 0. interpreterProxy failed ifTrue:[^nil]. + result := self b3dxSwapRendererBuffers: handle. - result := self cCode:'b3dxSwapRendererBuffers(handle)' inSmalltalk:[false]. result ifFalse:[^interpreterProxy primitiveFail]. ^interpreterProxy pop: 1. "pop arg; return rcvr"! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveTextureByteSex (in category 'primitives-textures') ----- primitiveTextureByteSex | handle result renderer | <export: true> interpreterProxy methodArgumentCount = 2 ifFalse:[^interpreterProxy primitiveFail]. handle := interpreterProxy stackIntegerValue: 0. renderer := interpreterProxy stackIntegerValue: 1. interpreterProxy failed ifTrue:[^nil]. + result := self b3dxTextureByteSex: renderer _: handle. - result := self cCode:'b3dxTextureByteSex(renderer, handle)' inSmalltalk:[-1]. result < 0 ifTrue:[^interpreterProxy primitiveFail]. interpreterProxy pop: 3. ^interpreterProxy pushBool: result.! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveTextureDepth (in category 'primitives-textures') ----- primitiveTextureDepth | handle result renderer | <export: true> interpreterProxy methodArgumentCount = 2 ifFalse:[^interpreterProxy primitiveFail]. handle := interpreterProxy stackIntegerValue: 0. renderer := interpreterProxy stackIntegerValue: 1. interpreterProxy failed ifTrue:[^nil]. + result := self b3dxActualTextureDepth: renderer _: handle. - result := self cCode:'b3dxActualTextureDepth(renderer, handle)' inSmalltalk:[-1]. result < 0 ifTrue:[^interpreterProxy primitiveFail]. interpreterProxy pop: 3. ^interpreterProxy pushInteger: result.! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveTextureGetColorMasks (in category 'primitives-textures') ----- primitiveTextureGetColorMasks | handle masks array renderer | <export: true> <var: #masks declareC:'unsigned int masks[4]'> interpreterProxy methodArgumentCount = 3 ifFalse:[^interpreterProxy primitiveFail]. array := interpreterProxy stackObjectValue: 0. handle := interpreterProxy stackIntegerValue: 1. renderer := interpreterProxy stackIntegerValue: 2. interpreterProxy failed ifTrue:[^nil]. ((interpreterProxy isArray: array) and: [(interpreterProxy slotSizeOf: array) = 4 + and: [self b3dxTextureColorMasks: renderer _: handle _: masks]]) - and: [self cCode:'b3dxTextureColorMasks(renderer, handle, masks)' inSmalltalk:[false]]]) ifFalse:[^interpreterProxy primitiveFail]. interpreterProxy pushRemappableOop: array. 0 to: 3 do: [:i| interpreterProxy storePointer: i ofObject: interpreterProxy topRemappableOop withValue: (interpreterProxy positive32BitIntegerFor: (masks at: i))]. interpreterProxy popRemappableOop. ^interpreterProxy pop: 3 "pop args return receiver"! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveTextureSurfaceHandle (in category 'primitives-textures') ----- primitiveTextureSurfaceHandle | handle result renderer | <export: true> interpreterProxy methodArgumentCount = 2 ifFalse:[^interpreterProxy primitiveFail]. handle := interpreterProxy stackIntegerValue: 0. renderer := interpreterProxy stackIntegerValue: 1. interpreterProxy failed ifTrue:[^nil]. + result := self b3dxTextureSurfaceHandle: renderer _: handle. - result := self cCode:'b3dxTextureSurfaceHandle(renderer, handle)' inSmalltalk:[-1]. result < 0 ifTrue:[^interpreterProxy primitiveFail]. interpreterProxy pop: 3. ^interpreterProxy pushInteger: result! Item was changed: ----- Method: B3DAcceleratorPlugin>>primitiveTextureUpload (in category 'primitives-textures') ----- primitiveTextureUpload | h w d result form bits ppw bitsPtr handle renderer | <export: true> <var: #bitsPtr type: 'void*'> interpreterProxy methodArgumentCount = 3 ifFalse:[^interpreterProxy primitiveFail]. form := interpreterProxy stackValue: 0. ((interpreterProxy isPointers: form) and:[(interpreterProxy slotSizeOf: form) >= 4]) ifFalse:[^interpreterProxy primitiveFail]. bits := interpreterProxy fetchPointer: 0 ofObject: form. w := interpreterProxy fetchInteger: 1 ofObject: form. h := interpreterProxy fetchInteger: 2 ofObject: form. d := interpreterProxy fetchInteger: 3 ofObject: form. ppw := 32 // d. (interpreterProxy isWords: bits) ifFalse:[^interpreterProxy primitiveFail]. (interpreterProxy slotSizeOf: bits) = (w + ppw - 1 // ppw * h) ifFalse:[^interpreterProxy primitiveFail]. bitsPtr := interpreterProxy firstIndexableField: bits. handle := interpreterProxy stackIntegerValue: 1. renderer := interpreterProxy stackIntegerValue: 2. interpreterProxy failed ifTrue:[^nil]. + result := self b3dxUploadTexture: renderer _: handle _: w _: h _: d _: bitsPtr. - result := self cCode:'b3dxUploadTexture(renderer, handle, w, h, d, bitsPtr)' inSmalltalk:[false]. result ifFalse:[^interpreterProxy primitiveFail]. ^interpreterProxy pop: 3. "args; return rcvr"! Item was changed: ----- Method: B3DAcceleratorPlugin>>stackLightArrayValue: (in category 'primitive support') ----- stackLightArrayValue: stackIndex "Load an Array of B3DPrimitiveLights from the given stack index" | oop array arraySize | <inline: false> + array := interpreterProxy stackValue: stackIndex. - array := interpreterProxy stackObjectValue: stackIndex. - array = nil ifTrue:[^nil]. "really??" array = interpreterProxy nilObject ifTrue:[^nil]. + (interpreterProxy isArray: array) ifFalse: + [^interpreterProxy primitiveFail]. - (interpreterProxy isArray: array) - ifFalse:[^interpreterProxy primitiveFail]. arraySize := interpreterProxy slotSizeOf: array. 0 to: arraySize-1 do:[:i| oop := interpreterProxy fetchPointer: i ofObject: array. ((interpreterProxy isWords: oop) and:[(interpreterProxy slotSizeOf: oop) = 32]) ifFalse:[^interpreterProxy primitiveFail]. ]. ^array! Item was changed: ----- Method: FilePlugin>>primitiveDirectoryDelimitor (in category 'directory primitives') ----- primitiveDirectoryDelimitor <export: true> interpreterProxy minorVersion >= 13 ifTrue: [interpreterProxy pop: 1 thenPush: (interpreterProxy characterObjectOf: self dir_Delimitor)] ifFalse: [| ascii | + ascii := self dir_Delimitor. - ascii := self asciiDirectoryDelimiter. (ascii >= 0 and: [ascii <= 255]) ifTrue: [interpreterProxy pop: 1 thenPush: (interpreterProxy fetchPointer: ascii ofObject: interpreterProxy characterTable)] ifFalse: [interpreterProxy primitiveFail]]!

4 7

Build completed: opensmalltalk-vm 1.0.1445
by AppVeyor 30 Oct '18

30 Oct '18

1 0

Alien Callbacks with SELinux enforcing on
by Bob Westergaard 30 Oct '18

30 Oct '18

Hi Everybody, I'm wondering if anyone has encountered problems with having SELinux enabled and executing C callbacks with the VMs (Alien class>>#exampleCqsort should demonstrate this). From what I have seen, this will fail when the thunk is being set with execute permissions in allocateExecutablePage() (here is the relevant line in the 32-bit VM callback source, the same applies to the 64-bit code): https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/a8a1dc1e33267e0fa2da… One workaround is to set SELinux to be permissive or disabled (edit /etc/selinux/config and reboot). Another solution is to look at one of the system or audit log messages which should provide some instructions with what you can do (it should suggest to set execheap to true or create a policy file from audit2allow from the denial and install it with semodule). However, it seems to me that this should work without having to do any of that. In order to have reached this point where the callback thunk was being created the VM has already allocated and marked memory as executable for the JIT, so the process has permissions to at least set execute permissions on memory allocated with mmap(). In allocateExecutablePage() if I change vmalloc() to be mmap() like the following: if (!(mem = mmap(0, pagesize, PROT_READ | PROT_WRITE, MAP_ANON | MAP_PRIVATE, -1, 0))) The callbacks appear to work again with selinux enabled (it might make sense to set the execute bits at allocation time and ditch mprotect() but I was lazy and opted for a cut and paste from where mmap() is used elsewhere). My testing of this has been very minimal, so I'm reluctant to make a pull request. Plus, I am fairly certain that I can get away with making SELinux disabled/permissive or use a policy for the process so that is how I'll likely deal with it. Nonetheless, it seemed like it was worth an email to the list. Is there any reason to still use valloc() used here instead of mmap()? Or is there something obvious I am missing here? Regards, -- Bob

3 2

Re: [Vm-dev] [squeak-dev] What should Integer>>digitCompare: return?
by Eliot Miranda 30 Oct '18

30 Oct '18

Hi Chris, > On Oct 28, 2018, at 3:41 PM, Chris Cunningham <cunningham.cb(a)gmail.com> wrote: > > Looking at LargeIntegers (I'm 64 bit, so these are big): > { > 1152921504606846977 digitCompare: -1152921504606846977. > 1152921504606846977 digitCompare: -1152921504606846978. > 1152921504606846978 digitCompare: -1152921504606846977. > } "#(0 -1 1)" > > { > 1249 digitCompare: -1249. > 1249 digitCompare: -1250. > 1250 digitCompare: -1249. > } #(1 1 1) this is correct. The primitive is supposed to answer -1, 0 or 1 depending on whether the (receiver digitAt: n) is <, =, or > the (argument digitAt: n) where n is either the first digit at which the receiver and argument differ or the last digit. Since digitAt: does not answer the 2’s complement bit-anded SmallIntegers are not actually inconsistent -1 digitAt: 1 => 1 -1 digitAt: 2 => 0 1 digitAt: 1 => 1 1 digitAt: 2 => 0 SmallInteger minVal - 1 digitAt: Smalltalk wordSize => 16 (64-bits) 64 (32-bits) SmallInteger maxVal + 1 digitAt: Smalltalk wordSize => 16 (64-bits) 64 (32-bits) So the method needs a) a really good comment and b) a warning that this is private to the Integer hierarchy implementation and not for general use. It looks to me like the use in DateAndTime is a hack that works because LastClockValue is always +ve. _,,,^..^,,,_ (phone)

2 2

VM Maker: VMMaker.oscog-eem.2478.mcz
by commits＠source.squeak.org 30 Oct '18

30 Oct '18

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2478.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2478 Author: eem Time: 29 October 2018, 4:59:10.970463 pm UUID: 47ae35e3-969f-4af7-aa45-57121962de22 Ancestors: VMMaker.oscog-eem.2477 Fix a couple of tests =============== Diff against VMMaker.oscog-eem.2477 =============== Item was changed: ----- Method: MiscPrimitivePluginTest>>testCompressToByteArray (in category 'testing') ----- testCompressToByteArray + | bitmap byteArray n | - | bitmap byteArray | bitmap := Bitmap with: 16rFFFFFFFF. + byteArray := ByteArray new: 12. "Primitive makes an estimate; hence output must have at least 11 bytes" + n := self compress: bitmap toByteArray: byteArray. + self assert: n = 3. + self assert: #[1 5 255] equals: (byteArray copyFrom: 1 to: n)! - byteArray := ByteArray new: 4. - self compress: bitmap toByteArray: byteArray. - self should: byteArray = #[1 5 255 0]! Item was changed: ----- Method: MiscPrimitivePluginTest>>testDecompressFromByteArrayAt (in category 'testing') ----- testDecompressFromByteArrayAt | bitmap byteArray s size | + byteArray := #[1 5 255]. - byteArray := #(1 5 255 0) asByteArray. s := ReadStream on: byteArray. size := Bitmap decodeIntFrom: s. bitmap := Bitmap new: size. self decompress: bitmap fromByteArray: byteArray at: s position + 1. + self assert: (Bitmap with: 16rFFFFFFFF) equals: bitmap! - self should: bitmap = ((Bitmap new: 1) at: 1 put: 4294967295; yourself)!

1 0

VM Maker: VMMaker.oscog-eem.2477.mcz
by commits＠source.squeak.org 29 Oct '18

29 Oct '18

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2477.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2477 Author: eem Time: 29 October 2018, 3:43:53.470679 pm UUID: d3baf73f-464f-4d2a-a17e-d57c5a7e595d Ancestors: VMMaker.oscog-eem.2476 Plugins: Fix primDigitCompare for SmallIntegers. The old code compared the values of the receiver and argument, not their magnitudes, if both were SmallIntegers. Simplify the FilePlugin. removing an unnecessary indirection around dir_Delimitor, and eliminating an unnecessary cCode:inSmalltalk:. Simulator: Fix a regression with FilePlugin loading due to the simplifications to simulated plugin loading introduced in VMMaker.oscog-eem.2476. mappedPluginEntries must be extended, not assigned to. Disable simulation for ClipboardExtendedPlugin. This would be a good exercise for someone who wanted to try writing a plugin simulation themselves, hint, hint. =============== Diff against VMMaker.oscog-eem.2476 =============== Item was added: + ----- Method: ClipboardExtendedPlugin class>>simulatorClass (in category 'simulation') ----- + simulatorClass + "This should be easy to simulate, but I'm short of time. Feel free to have a go, following e.g. the pattern in JPEGReadWriter2Plugin." + ^nil! Item was changed: ----- Method: CogVMSimulator>>ioLoadFunction:From: (in category 'plugin support') ----- ioLoadFunction: functionString From: pluginString "Load and return the requested function from a module" | firstTime plugin fnSymbol | firstTime := false. fnSymbol := functionString asSymbol. transcript cr; show: '(', byteCount printString, ') Looking for ', functionString, ' in ', + (pluginString isEmpty ifTrue: ['vm'] ifFalse: [pluginString]). - (pluginString isEmpty ifTrue:['vm'] ifFalse:[pluginString]). (breakSelector notNil and: [(pluginString size = breakSelector size and: [(self strncmp: pluginString _: breakSelector _: pluginString size) = 0]) or: [functionString size = breakSelector size and: [(self strncmp: functionString _: breakSelector _: functionString size) = 0]]]) ifTrue: [self halt: pluginString, '>>', functionString]. plugin := pluginList + detect: [:any| any key = pluginString asString] - detect:[:any| any key = pluginString asString] ifNone: [firstTime := true. + self loadNewPlugin: pluginString]. - self loadNewPlugin: pluginString]. plugin ifNil: + [firstTime ifTrue: [transcript cr; show: '... FAILED; no plugin found']. - [firstTime ifTrue: [transcript cr; show: 'Failed ... primitive not in plugin']. ^0]. plugin := plugin value. + mappedPluginEntries withIndexDo: - mappedPluginEntries doWithIndex: [:pluginAndName :index| ((pluginAndName at: 1) == plugin and:[(pluginAndName at: 2) == fnSymbol]) ifTrue: [^index]]. (plugin respondsTo: fnSymbol) ifFalse: + [firstTime ifTrue: [transcript cr; show: '... FAILED; primitive not in plugin']. - [firstTime ifTrue: [transcript cr; show: 'Failed ... primitive not in plugin']. ^0]. + mappedPluginEntries addLast: { plugin. fnSymbol. [plugin perform: fnSymbol. self]}. - mappedPluginEntries addLast: (Array - with: plugin - with: fnSymbol - with: [plugin perform: fnSymbol. self]). transcript show: ' ... okay'. + ^mappedPluginEntries size! - ^ mappedPluginEntries size! Item was changed: ----- Method: CogVMSimulator>>ioLoadFunction:From:AccessorDepthInto: (in category 'plugin support') ----- ioLoadFunction: functionString From: pluginString AccessorDepthInto: accessorDepthPtr "Load and return the requested function from a module. Assign the accessor depth through accessorDepthPtr. N.B. The actual code lives in platforms/Cross/vm/sqNamedPrims.h" | firstTime plugin fnSymbol | firstTime := false. fnSymbol := functionString asSymbol. transcript cr; show: '(', byteCount printString, ') Looking for ', functionString, ' in ', + (pluginString isEmpty ifTrue: ['vm'] ifFalse: [pluginString]). - (pluginString isEmpty ifTrue:['vm'] ifFalse:[pluginString]). (breakSelector notNil and: [(pluginString size = breakSelector size and: [(self strncmp: pluginString _: breakSelector _: pluginString size) = 0]) or: [functionString size = breakSelector size and: [(self strncmp: functionString _: breakSelector _: functionString size) = 0]]]) ifTrue: [self halt: pluginString, '>>', functionString]. plugin := pluginList detect: [:any| any key = pluginString asString] ifNone: [firstTime := true. self loadNewPlugin: pluginString]. plugin ifNil: + [firstTime ifTrue: [transcript cr; show: '... FAILED; primitive not in plugin']. - [firstTime ifTrue: [transcript cr; show: 'Failed ... primitive not in plugin']. ^0]. plugin := plugin value. + mappedPluginEntries withIndexDo: - mappedPluginEntries doWithIndex: [:pluginAndName :index| ((pluginAndName at: 1) == plugin and:[(pluginAndName at: 2) == fnSymbol]) ifTrue: [firstTime ifTrue: [transcript show: ' ... okay']. accessorDepthPtr at: 0 put: (pluginAndName at: 4). ^index]]. + firstTime ifTrue: [transcript cr; show: '... FAILED; primitive not in plugin']. - firstTime ifTrue: [transcript cr; show: 'Failed ... primitive not in plugin']. ^0! Item was removed: - ----- Method: FilePlugin>>asciiDirectoryDelimiter (in category 'directory primitives') ----- - asciiDirectoryDelimiter - ^ self - cCode: 'dir_Delimitor()' - inSmalltalk: - [(Smalltalk classNamed: #FileSystem) - ifNotNil: [:fileSystem| fileSystem disk delimiter asciiValue] - ifNil: [FileDirectory pathNameDelimiter asciiValue]]! Item was added: + ----- Method: FilePlugin>>dir_Delimitor (in category 'directory primitives') ----- + dir_Delimitor + <doNotGenerate> + ^(Smalltalk classNamed: #FileSystem) + ifNotNil: [:fileSystem| fileSystem disk delimiter asInteger] + ifNil: [FileDirectory pathNameDelimiter asInteger]! Item was changed: ----- Method: FilePlugin>>initialiseModule (in category 'initialize-release') ----- initialiseModule <export: true> sCCPfn := interpreterProxy ioLoadFunction: 'secCanCreatePathOfSize' From: 'SecurityPlugin'. sCDPfn := interpreterProxy ioLoadFunction: 'secCanDeletePathOfSize' From: 'SecurityPlugin'. sCGFTfn := interpreterProxy ioLoadFunction: 'secCanGetFileTypeOfSize' From: 'SecurityPlugin'. sCLPfn := interpreterProxy ioLoadFunction: 'secCanListPathOfSize' From: 'SecurityPlugin'. sCSFTfn := interpreterProxy ioLoadFunction: 'secCanSetFileTypeOfSize' From: 'SecurityPlugin'. sDFAfn := interpreterProxy ioLoadFunction: 'secDisableFileAccess' From: 'SecurityPlugin'. sCDFfn := interpreterProxy ioLoadFunction: 'secCanDeleteFileOfSize' From: 'SecurityPlugin'. sCOFfn := interpreterProxy ioLoadFunction: 'secCanOpenFileOfSizeWritable' From: 'SecurityPlugin'. sCRFfn := interpreterProxy ioLoadFunction: 'secCanRenameFileOfSize' From: 'SecurityPlugin'. sHFAfn := interpreterProxy ioLoadFunction: 'secHasFileAccess' From: 'SecurityPlugin'. + ^self sqFileInit! - ^self cCode: [self sqFileInit] inSmalltalk: [true]! Item was changed: ----- Method: FilePlugin>>primitiveDirectoryDelimitor (in category 'directory primitives') ----- primitiveDirectoryDelimitor - | ascii | <export: true> - ascii := self asciiDirectoryDelimiter. interpreterProxy minorVersion >= 13 ifTrue: [interpreterProxy pop: 1 + thenPush: (interpreterProxy characterObjectOf: self dir_Delimitor)] - thenPush: (interpreterProxy characterObjectOf: ascii)] ifFalse: + [| ascii | + ascii := self asciiDirectoryDelimiter. + (ascii >= 0 and: [ascii <= 255]) - [(ascii >= 0 and: [ascii <= 255]) ifTrue: [interpreterProxy pop: 1 thenPush: (interpreterProxy fetchPointer: ascii ofObject: interpreterProxy characterTable)] ifFalse: [interpreterProxy primitiveFail]]! Item was removed: - ----- Method: FilePluginSimulator>>initialiseModule (in category 'initialize-release') ----- - initialiseModule - "See FilePluginSimulator>>sqFileStdioHandlesInto:" - (openFiles := Dictionary new) - at: 0 put: (FakeStdinStream for: interpreterProxy interpreter); "stdin" - at: 1 put: interpreterProxy interpreter transcript; "stdout" - at: 2 put: interpreterProxy interpreter transcript. "stderr" - states := IdentityDictionary new. - maxOpenFiles := VMClass initializationOptions at: #MaxFileDescriptors ifAbsent: [1024]. - ^super initialiseModule! Item was added: + ----- Method: FilePluginSimulator>>sqFileInit (in category 'initialize-release') ----- + sqFileInit + "See FilePluginSimulator>>sqFileStdioHandlesInto:" + (openFiles := Dictionary new) + at: 0 put: (FakeStdinStream for: interpreterProxy interpreter); "stdin" + at: 1 put: interpreterProxy interpreter transcript; "stdout" + at: 2 put: interpreterProxy interpreter transcript. "stderr" + states := IdentityDictionary new. + maxOpenFiles := VMClass initializationOptions at: #MaxFileDescriptors ifAbsent: [1024]. + ^true! Item was changed: ----- Method: LargeIntegersPlugin>>primDigitCompare: (in category 'Integer primitives') ----- primDigitCompare: secondInteger + "Compare the magnitude of self with that of arg. + Answer a code of 1, 0, -1 for self >, = , < arg" | firstVal secondVal firstInteger | - | firstVal secondVal firstInteger | self debugCode: [self msg: 'primDigitCompare: secondInteger']. firstInteger := self + primitive: 'primDigitCompare' + parameters: #(#Integer ) + receiver: #Integer. + "shortcut: aSmallInteger has to be smaller in Magnitude than aLargeInteger" + (interpreterProxy isIntegerObject: firstInteger) ifTrue: + [(interpreterProxy isIntegerObject: secondInteger) ifTrue: + [firstVal := interpreterProxy integerValueOf: firstInteger. + secondVal := interpreterProxy integerValueOf: secondInteger. + "Compute their magnitudes. Since SmallIntegers are tagged they have + fewer bits than an integer on the platform; therefore in computing their + magnitude they cannot overflow." + firstVal < 0 ifTrue: [firstVal := 0 - firstVal]. + secondVal < 0 ifTrue: [secondVal := 0 - secondVal]. + ^firstVal = secondVal + ifTrue: [0 asOop: SmallInteger] + ifFalse: + [firstVal < secondVal + ifTrue: [-1 asOop: SmallInteger] + ifFalse: [1 asOop: SmallInteger]]]. + ^-1 asOop: SmallInteger]. "first < second" + (interpreterProxy isIntegerObject: secondInteger) ifTrue: + [^1 asOop: SmallInteger]. "first > second" + ^ self digitCompareLarge: firstInteger with: secondInteger! - primitive: 'primDigitCompare' - parameters: #(#Integer ) - receiver: #Integer. - "shortcut: aSmallInteger has to be smaller in Magnitude as aLargeInteger" - (interpreterProxy isIntegerObject: firstInteger) - ifTrue: ["first" - (interpreterProxy isIntegerObject: secondInteger) - ifTrue: ["second" - (firstVal := interpreterProxy integerValueOf: firstInteger) > (secondVal := interpreterProxy integerValueOf: secondInteger) - ifTrue: [^ 1 asOop: SmallInteger"first > second"] - ifFalse: [firstVal < secondVal - ifTrue: [^ -1 asOop: SmallInteger"first < second"] - ifFalse: [^ 0 asOop: SmallInteger"first = second"]]] - ifFalse: ["SECOND" - ^ -1 asOop: SmallInteger"first < SECOND"]] - ifFalse: ["FIRST" - (interpreterProxy isIntegerObject: secondInteger) - ifTrue: ["second" - ^ 1 asOop: SmallInteger"FIRST > second"] - ifFalse: ["SECOND" - ^ self digitCompareLarge: firstInteger with: secondInteger]]! Item was changed: ----- Method: StackInterpreter>>tryLoadNewPlugin:pluginEntries: (in category 'primitive support') ----- tryLoadNewPlugin: pluginString pluginEntries: pluginEntries "Load the plugin and if on Spur, populate pluginEntries with the prmitives in the plugin." <doNotGenerate> | plugin realPluginClass plugins | self transcript cr; show: 'Looking for module ', pluginString. pluginString isEmpty ifTrue: [plugin := self] ifFalse: [plugins := InterpreterPlugin allSubclasses select: [:psc| psc moduleName asString = pluginString asString and: [psc shouldBeTranslated]]. plugins isEmpty ifTrue: [self transcript show: ' ... not found'. ^nil]. plugins size > 1 ifTrue: [^self error: 'This won''t work...']. "plugins size > 1 ifTrue: [self transcript show: '...multiple plugin classes; choosing ', plugins last name]." realPluginClass := plugins anyOne. "hopefully lowest in the hierarchy..." plugin := realPluginClass simulatorForInterpreterInterface: objectMemory. + plugin ifNil: [self transcript show: ' ... no simulator class; cannot simulate'. ^nil]. (plugin respondsTo: #initialiseModule) ifTrue: [plugin initialiseModule ifFalse: [self transcript show: ' ... initialiser failed'. ^nil]]]. "module initialiser failed" self transcript show: ' ... loaded'. objectMemory hasSpurMemoryManagerAPI ifTrue: [| realPlugin cg | self transcript show: '...computing accessor depths'. plugin class isPluginClass ifTrue: [realPlugin := (plugin isSmartSyntaxPluginSimulator ifTrue: [realPluginClass] ifFalse: [plugin class]) withAllSuperclasses detect: [:class| class shouldBeTranslated]. cg := realPlugin buildCodeGenerator] ifFalse: [cg := self codeGeneratorToComputeAccessorDepth. primitiveTable withIndexDo: [:prim :index| | depth | prim isSymbol ifTrue: [depth := cg accessorDepthForSelector: prim. self assert: (depth isInteger or: [depth isNil and: [(plugin class whichClassIncludesSelector: prim) isNil]]). primitiveAccessorDepthTable at: index - 1 put: depth]]]. cg exportedPrimitiveNames do: [:primName| | fnSymbol | fnSymbol := primName asSymbol. pluginEntries addLast: {plugin. fnSymbol. [plugin perform: fnSymbol. self]. cg accessorDepthForSelector: fnSymbol}]. self transcript show: '...done']. ^pluginString asString -> plugin! Item was changed: ----- Method: StackInterpreterSimulator>>ioLoadFunction:From: (in category 'plugin support') ----- ioLoadFunction: functionString From: pluginString "Load and return the requested function from a module" | firstTime plugin fnSymbol | firstTime := false. fnSymbol := functionString asSymbol. transcript cr; show: '(', byteCount printString, ') Looking for ', functionString, ' in ', + (pluginString isEmpty ifTrue: ['vm'] ifFalse: [pluginString]). - (pluginString isEmpty ifTrue:['vm'] ifFalse:[pluginString]). (breakSelector notNil and: [(pluginString size = breakSelector size and: [(self strncmp: pluginString _: breakSelector _: pluginString size) = 0]) or: [functionString size = breakSelector size and: [(self strncmp: functionString _: breakSelector _: functionString size) = 0]]]) ifTrue: [self halt: pluginString, '>>', functionString]. plugin := pluginList + detect: [:any| any key = pluginString asString] + ifNone: + [firstTime := true. + self loadNewPlugin: pluginString]. + plugin ifNil: + [firstTime ifTrue: [transcript cr; show: '... FAILED; no plugin found']. + ^0]. - detect:[:any| any key = pluginString asString] - ifNone:[firstTime := true. - self loadNewPlugin: pluginString]. - plugin ifNil:[transcript show: 'Failed ... no plugin found'. ^ 0]. plugin := plugin value. + mappedPluginEntries withIndexDo: + [:pluginAndName :index| - mappedPluginEntries doWithIndex:[:pluginAndName :index| ((pluginAndName at: 1) == plugin + and:[(pluginAndName at: 2) == fnSymbol]) ifTrue: + [^index]]. - and:[(pluginAndName at: 2) == fnSymbol]) ifTrue: - [firstTime ifTrue: [transcript show:' ... okay'. ^ index]]]. (plugin respondsTo: fnSymbol) ifFalse: + [firstTime ifTrue: [transcript cr; show: '... FAILED; primitive not in plugin']. + ^0]. + mappedPluginEntries addLast: { plugin. fnSymbol }. - [transcript show:'Failed ... primitive not in plugin'. ^ 0]. - mappedPluginEntries := mappedPluginEntries copyWith: (Array with: plugin with: fnSymbol). transcript show: ' ... okay'. + ^mappedPluginEntries size! - ^ mappedPluginEntries size! Item was changed: ----- Method: StackInterpreterSimulator>>ioLoadFunction:From:AccessorDepthInto: (in category 'plugin support') ----- ioLoadFunction: functionString From: pluginString AccessorDepthInto: accessorDepthPtr "Load and return the requested function from a module. Assign the accessor depth through accessorDepthPtr. N.B. The actual code lives in platforms/Cross/vm/sqNamedPrims.h" | firstTime plugin fnSymbol | firstTime := false. fnSymbol := functionString asSymbol. transcript cr; show: '(', byteCount printString, ') Looking for ', functionString, ' in ', + (pluginString isEmpty ifTrue: ['vm'] ifFalse: [pluginString]). - (pluginString isEmpty ifTrue:['vm'] ifFalse:[pluginString]). (breakSelector notNil and: [(pluginString size = breakSelector size and: [(self strncmp: pluginString _: breakSelector _: pluginString size) = 0]) or: [functionString size = breakSelector size and: [(self strncmp: functionString _: breakSelector _: functionString size) = 0]]]) ifTrue: [self halt: pluginString, '>>', functionString]. plugin := pluginList detect: [:any| any key = pluginString asString] ifNone: [firstTime := true. self loadNewPlugin: pluginString]. plugin ifNil: + [firstTime ifTrue: [transcript show: '... FAILED; no plugin found']. - [firstTime ifTrue: [transcript show: 'Failed ... primitive not in plugin']. ^0]. plugin := plugin value. + mappedPluginEntries withIndexDo: - mappedPluginEntries doWithIndex: [:pluginAndName :index| ((pluginAndName at: 1) == plugin and:[(pluginAndName at: 2) == fnSymbol]) ifTrue: [firstTime ifTrue: [transcript show: ' ... okay']. accessorDepthPtr at: 0 put: (pluginAndName at: 4). ^index]]. + firstTime ifTrue: [transcript show: '... FAILED; primitive not in plugin']. - firstTime ifTrue: [transcript show: 'Failed ... primitive not in plugin']. ^0!

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev October 2018