1. The following primitives weren't updated as part of the support file
restructure:
- primitiveChangeMode
- primitiveChangeOwner
- primitiveSymlinkChangeOwner
- primitiveRewinddir
Get these working again in the new framework (fapath).
2. Rewinding the directory on Windows returns the first entry.
Modify the primitive to behave this way on all platforms.
3. Path conversion primitives shouldn't include the Long Path Prefix on
Windows as part of the path.
You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287
-- Commit Summary --
* FileAttributesPlugin: Update remaining primitives
* FileAttributesPlugin: redefine primitiveRewinddir the Windows way
* FileAttributesPlugin: Fix path conversion primitives
* FileAttributesPlugin v2.0.1
-- File Changes --
M platforms/unix/plugins/FileAttributesPlugin/faSupport.c (27)
M platforms/unix/plugins/FileAttributesPlugin/faSupport.h (1)
M platforms/win32/plugins/FileAttributesPlugin/faSupport.c (132)
M platforms/win32/plugins/FileAttributesPlugin/faSupport.h (15)
M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c (127)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287.patchhttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287
Branch: refs/heads/Cog
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: bd88cc65cce0fd122714048bf3b9d96ebaaaf9be
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/bd88cc65cce0fd1227…
Author: AlistairGrant <akgrant0710(a)gmail.com>
Date: 2018-10-03 (Wed, 03 Oct 2018)
Changed paths:
M platforms/unix/plugins/FileAttributesPlugin/faSupport.c
M platforms/unix/plugins/FileAttributesPlugin/faSupport.h
M platforms/win32/plugins/FileAttributesPlugin/faSupport.c
M platforms/win32/plugins/FileAttributesPlugin/faSupport.h
M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c
Log Message:
-----------
FileAttributesPlugin: Update remaining primitives
The following primitives weren't updated as part of the support file
restructure:
- primitiveChangeMode
- primitiveChangeOwner
- primitiveSymlinkChangeOwner
- primitiveRewinddir
Get these working again in the new framework (fapath).
Commit: b6b67f48f69b16bc19e9f3587c597592cc10b355
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b6b67f48f69b16bc19…
Author: AlistairGrant <akgrant0710(a)gmail.com>
Date: 2018-10-03 (Wed, 03 Oct 2018)
Changed paths:
M platforms/unix/plugins/FileAttributesPlugin/faSupport.c
M platforms/win32/plugins/FileAttributesPlugin/faSupport.c
M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c
Log Message:
-----------
FileAttributesPlugin: redefine primitiveRewinddir the Windows way
Rewinding the directory on Windows returns the first entry. Modify the
primitive to behave this way on all platforms.
Commit: 8c44f9bce5afd7b6cfa1f11a9ad82dcd10afb731
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/8c44f9bce5afd7b6cf…
Author: AlistairGrant <akgrant0710(a)gmail.com>
Date: 2018-10-03 (Wed, 03 Oct 2018)
Changed paths:
M platforms/win32/plugins/FileAttributesPlugin/faSupport.c
M platforms/win32/plugins/FileAttributesPlugin/faSupport.h
M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c
Log Message:
-----------
FileAttributesPlugin: Fix path conversion primitives
The primitive shouldn't include the Long Path Prefix on Windows as part
of the path.
Commit: 91e578755ba436fc2ab5782da3a460d160c866c9
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/91e578755ba436fc2a…
Author: AlistairGrant <akgrant0710(a)gmail.com>
Date: 2018-10-03 (Wed, 03 Oct 2018)
Changed paths:
M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c
Log Message:
-----------
FileAttributesPlugin v2.0.1
1. The following primitives weren't updated as part of the support file
restructure:
- primitiveChangeMode
- primitiveChangeOwner
- primitiveSymlinkChangeOwner
- primitiveRewinddir
Get these working again in the new framework (fapath).
2. Rewinding the directory on Windows returns the first entry.
Modify the primitive to behave this way on all platforms.
3. Path conversion primitives shouldn't include the Long Path Prefix on
Windows as part of the path.
Commit: 8cca3320bce951962c0609d09a24f4608e2e410b
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/8cca3320bce951962c…
Author: akgrant43 <akgrant(a)gmail.com>
Date: 2018-10-03 (Wed, 03 Oct 2018)
Changed paths:
M platforms/unix/plugins/FileAttributesPlugin/faSupport.c
M platforms/unix/plugins/FileAttributesPlugin/faSupport.h
M platforms/win32/plugins/FileAttributesPlugin/faSupport.c
M platforms/win32/plugins/FileAttributesPlugin/faSupport.h
M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c
Log Message:
-----------
Merge pull request #287 from akgrant43/FileAttributesPlugin200
FileAttributesPlugin v2.0.1
Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/cfa0cc643ca6...8c…
**NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
Restructure FileAttributesPlugin to move platform specific functionality out to separate files. This is required as Windows requires the "wide" versions of posix functions to be used, e.g. access() vs. _waccess(), while other seem to require the Windows native functions, e.g. iterating over directories, and interleaving #ifdef _WIN32 was becoming unwieldy.
You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285
-- Commit Summary --
* faSupport: initial commit for windows testing
* FileAttributesPlugin: restructure platform support files
* FileAttributesPlugin: Manual FileAttributesPlugin.c fixes
* FileAttributesPlugin: OSX and Windows fixes
* FileAttributesPlugin 2.0.0: Fixes UTF8 on Windows
* Merge remote-tracking branch 'upstream/Cog' into FileAttributesPlugin200
-- File Changes --
A platforms/Cross/plugins/FileAttributesPlugin/faCommon.c (67)
A platforms/Cross/plugins/FileAttributesPlugin/faCommon.h (14)
A platforms/Cross/plugins/FileAttributesPlugin/faConstants.h (32)
M platforms/iOS/plugins/FileAttributesPlugin/Makefile (6)
A platforms/unix/plugins/FileAttributesPlugin/faSupport.c (515)
A platforms/unix/plugins/FileAttributesPlugin/faSupport.h (71)
A platforms/win32/plugins/FileAttributesPlugin/faSupport.c (657)
A platforms/win32/plugins/FileAttributesPlugin/faSupport.h (72)
M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c (1092)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285.patchhttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285
Branch: refs/heads/Cog
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: a229a9535cefe3f7ea719c31f57d745c1a503ed4
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a229a9535cefe3f7ea…
Author: AlistairGrant <akgrant0710(a)gmail.com>
Date: 2018-09-15 (Sat, 15 Sep 2018)
Changed paths:
A platforms/Cross/plugins/FileAttributesPlugin/faConstants.h
A platforms/unix/plugins/FileAttributesPlugin/faSupport.c
A platforms/unix/plugins/FileAttributesPlugin/faSupport.h
A platforms/win32/plugins/FileAttributesPlugin/faSupport.c
A platforms/win32/plugins/FileAttributesPlugin/faSupport.h
M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c
Log Message:
-----------
faSupport: initial commit for windows testing
Commit: 71e9b7e35835613e95a5894ff4ad7949c0e716a8
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/71e9b7e35835613e95…
Author: AlistairGrant <akgrant0710(a)gmail.com>
Date: 2018-09-30 (Sun, 30 Sep 2018)
Changed paths:
A platforms/Cross/plugins/FileAttributesPlugin/faCommon.c
A platforms/Cross/plugins/FileAttributesPlugin/faPlugin.h
M platforms/unix/plugins/FileAttributesPlugin/faSupport.c
M platforms/unix/plugins/FileAttributesPlugin/faSupport.h
M platforms/win32/plugins/FileAttributesPlugin/faSupport.c
M platforms/win32/plugins/FileAttributesPlugin/faSupport.h
M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c
Log Message:
-----------
FileAttributesPlugin: restructure platform support files
Restructure FileAttributesPlugin to move platform specific functionality
out to separate files. This is required as Windows requires the "wide"
versions of posix functions to be used, e.g. access() vs. _waccess(),
while other seem to require the Windows native functions, e.g. iterating
over directories, and interleaving #ifdef _WIN32 was becoming unwieldy.
Commit: 2a0edb0b7f9990ba63118cae05bd7d96556c48c7
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a0edb0b7f9990ba63…
Author: AlistairGrant <akgrant0710(a)gmail.com>
Date: 2018-09-30 (Sun, 30 Sep 2018)
Changed paths:
M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c
Log Message:
-----------
FileAttributesPlugin: Manual FileAttributesPlugin.c fixes
Fix superseeded type definitions and remove two unused methods.
This is for OSX testing and should be changed (over-ridden) in slang.
Commit: 3cf447467ef18c6c87ac20b85e657bdab8a1a6cd
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3cf447467ef18c6c87…
Author: AlistairGrant <akgrant0710(a)gmail.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M platforms/Cross/plugins/FileAttributesPlugin/faCommon.c
A platforms/Cross/plugins/FileAttributesPlugin/faCommon.h
R platforms/Cross/plugins/FileAttributesPlugin/faPlugin.h
M platforms/iOS/plugins/FileAttributesPlugin/Makefile
M platforms/unix/plugins/FileAttributesPlugin/faSupport.c
M platforms/unix/plugins/FileAttributesPlugin/faSupport.h
M platforms/win32/plugins/FileAttributesPlugin/faSupport.c
M platforms/win32/plugins/FileAttributesPlugin/faSupport.h
M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c
Log Message:
-----------
FileAttributesPlugin: OSX and Windows fixes
- typedef faStatStruct so that struct stat can be used on unix and
struct _stat on Windows
- Remove reference from the support files to FileAttributesPlugin.c.
This doesn't work as internal plugins have their symbols static,
preventing external access.
Commit: 0c08668ad7f9c32362ba15143d0276cdbedb8896
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0c08668ad7f9c32362…
Author: AlistairGrant <akgrant0710(a)gmail.com>
Date: 2018-10-02 (Tue, 02 Oct 2018)
Changed paths:
M platforms/unix/plugins/FileAttributesPlugin/faSupport.c
M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c
Log Message:
-----------
FileAttributesPlugin 2.0.0: Fixes UTF8 on Windows
Restructure FileAttributesPlugin to move platform specific functionality
out to separate files. This is required as Windows requires the "wide"
versions of posix functions to be used, e.g. access() vs. _waccess(),
while other seem to require the Windows native functions, e.g. iterating
over directories, and interleaving #ifdef _WIN32 was becoming unwieldy.
Commit: 5aa42b7bd6ca48129cd7017fdccbb603235fe53a
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/5aa42b7bd6ca48129c…
Author: AlistairGrant <akgrant0710(a)gmail.com>
Date: 2018-10-02 (Tue, 02 Oct 2018)
Changed paths:
M platforms/Cross/plugins/FilePlugin/FilePlugin.h
M platforms/iOS/vm/Common/Classes/sqSqueakFileDirectoryAPI.m
M platforms/unix/plugins/FilePlugin/sqUnixFile.c
M platforms/win32/vm/sqWin32Directory.c
M src/plugins/BitBltPlugin/BitBltPlugin.c
M src/plugins/FilePlugin/FilePlugin.c
Log Message:
-----------
Merge remote-tracking branch 'upstream/Cog' into FileAttributesPlugin200
Commit: 627f4d685405965c9cb13cf85821e165c7d8eddf
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/627f4d685405965c9c…
Author: AlistairGrant <akgrant0710(a)gmail.com>
Date: 2018-10-02 (Tue, 02 Oct 2018)
Changed paths:
M platforms/win32/vm/sqWin32Directory.c
M src/plugins/BitBltPlugin/BitBltPlugin.c
Log Message:
-----------
Merge remote-tracking branch 'upstream/Cog' into FileAttributesPlugin200
Commit: 7c87a681efe133c901454d491bdfeb1d5681da41
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/7c87a681efe133c901…
Author: AlistairGrant <akgrant0710(a)gmail.com>
Date: 2018-10-02 (Tue, 02 Oct 2018)
Changed paths:
M platforms/Cross/plugins/FileAttributesPlugin/faCommon.c
M platforms/Cross/plugins/FileAttributesPlugin/faConstants.h
M platforms/unix/plugins/FileAttributesPlugin/faSupport.c
M platforms/unix/plugins/FileAttributesPlugin/faSupport.h
M platforms/win32/plugins/FileAttributesPlugin/faSupport.c
M platforms/win32/plugins/FileAttributesPlugin/faSupport.h
Log Message:
-----------
FileAttributesPlugin: updated comments
Commit: cfa0cc643ca6a5e04bf87856b2f32185bd7883eb
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/cfa0cc643ca6a5e04b…
Author: akgrant43 <akgrant(a)gmail.com>
Date: 2018-10-02 (Tue, 02 Oct 2018)
Changed paths:
A platforms/Cross/plugins/FileAttributesPlugin/faCommon.c
A platforms/Cross/plugins/FileAttributesPlugin/faCommon.h
A platforms/Cross/plugins/FileAttributesPlugin/faConstants.h
M platforms/iOS/plugins/FileAttributesPlugin/Makefile
A platforms/unix/plugins/FileAttributesPlugin/faSupport.c
A platforms/unix/plugins/FileAttributesPlugin/faSupport.h
A platforms/win32/plugins/FileAttributesPlugin/faSupport.c
A platforms/win32/plugins/FileAttributesPlugin/faSupport.h
M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c
Log Message:
-----------
Merge pull request #285 from akgrant43/FileAttributesPlugin200
FileAttributesPlugin 2.0.0: Fixes UTF8 on Windows
Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/8194e6edac12...cf…
**NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.