Vm-dev August 2017

vm-dev@lists.squeakfoundation.org

31 participants
61 discussions

[OpenSmalltalk/opensmalltalk-vm] 4bbcf2: CogVM source as per VMMaker.oscog-eem.2265
by GitHub 23 Aug '17

23 Aug '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 4bbcf27fb7aab94beb77e4d517ca414d6766e34d https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/4bbcf27fb7aab94beb… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-08-22 (Tue, 22 Aug 2017) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M platforms/iOS/plugins/HostWindowPlugin/sqMacHostWindow.m M spur64src/vm/cogit.h M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/vm/cogit.h M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2265 Oops! Writing the function does nothing unless it is called. So once again, if ioScreenSize answers a zero screen extent (as is the case for headless images) then on snapshot write the sawvedWindowSize rather thna the zero extent. This should fix the experience people have with Pharo of saving headless images that then come up with a zero sized window when started headful. Fix slip in iOS sqMacHostWindow.m.

1 0

VM Maker: VMMaker.oscog-eem.2265.mcz
by commits＠source.squeak.org 23 Aug '17

23 Aug '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2265.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2265 Author: eem Time: 22 August 2017, 6:39:04.920256 pm UUID: 76b62109-629a-4c39-9641-67b53321df9a Ancestors: VMMaker.oscog-eem.2264 Oops! Writing the function does nothing unless it is called. So once again, if ioScreenSize answers a zero screen extent (as is the case for headless images) then on snapshot write the sawvedWindowSize rather thna the zero extent. This should fix the experience people have with Pharo of saving headless images that then come up with a zero sized window when started headful. =============== Diff against VMMaker.oscog-eem.2264 =============== Item was changed: ----- Method: StackInterpreter>>writeImageFileIO (in category 'image save/restore') ----- writeImageFileIO "Write the image header and heap contents to imageFile for snapshot. c.f. writeImageFileIOSimulation. The game below is to maintain 64-bit alignment for all putLong:toFile: occurrences." <inline: #never> | imageName headerStart headerSize f imageBytes bytesWritten sCWIfn okToWrite | <var: #f type: #sqImageFile> <var: #headerStart type: #squeakFileOffsetType> <var: #sCWIfn type: #'void *'> <var: #imageName declareC: 'extern char imageName[]'> self cCode: [] inSmalltalk: [imageName := 'sooth compiler'. ^self writeImageFileIOSimulation]. "If the security plugin can be loaded, use it to check for write permission. If not, assume it's ok" sCWIfn := self ioLoadFunction: 'secCanWriteImage' From: 'SecurityPlugin'. sCWIfn ~= 0 ifTrue: [okToWrite := self cCode: '((sqInt (*)(void))sCWIfn)()'. okToWrite ifFalse:[^self primitiveFail]]. "local constants" headerStart := 0. headerSize := objectMemory wordSize = 4 ifTrue: [64] ifFalse: [128]. "header size in bytes; do not change!!" f := self sqImageFile: imageName Open: 'wb'. f = nil ifTrue: "could not open the image file for writing" [^self primitiveFail]. imageBytes := objectMemory imageSizeToWrite. headerStart := self sqImage: f File: imageName StartLocation: headerSize + imageBytes. self cCode: '/* Note: on Unix systems one could put an exec command here, padded to 512 bytes */'. "position file to start of header" self sqImageFile: f Seek: headerStart. self putWord32: self imageFormatVersion toFile: f. self putWord32: headerSize toFile: f. self putLong: imageBytes toFile: f. self putLong: objectMemory baseAddressOfImage toFile: f. self putLong: objectMemory specialObjectsOop toFile: f. self putLong: objectMemory newObjectHash toFile: f. + self putLong: self getSnapshotScreenSize toFile: f. - self putLong: self ioScreenSize toFile: f. self putLong: self getImageHeaderFlags toFile: f. self putWord32: extraVMMemory toFile: f. self putShort: desiredNumStackPages toFile: f. self putShort: self unknownShortOrCodeSizeInKs toFile: f. self putWord32: desiredEdenBytes toFile: f. self putShort: (maxExtSemTabSizeSet ifTrue: [self ioGetMaxExtSemTableSize] ifFalse: [0]) toFile: f. self putShort: the2ndUnknownShort toFile: f. objectMemory hasSpurMemoryManagerAPI ifTrue: [self putLong: objectMemory firstSegmentBytes toFile: f. self putLong: objectMemory bytesLeftInOldSpace toFile: f. 2 timesRepeat: [self putLong: 0 toFile: f] "Pad the rest of the header."] ifFalse: [4 timesRepeat: [self putLong: 0 toFile: f]]. "Pad the rest of the header." objectMemory wordSize = 8 ifTrue: [3 timesRepeat: [self putLong: 0 toFile: f]]. "Pad the rest of the header." self assert: headerStart + headerSize = (self sqImageFilePosition: f). "position file after the header" self sqImageFile: f Seek: headerStart + headerSize. self successful ifFalse: "file write or seek failure" [self sqImageFileClose: f. ^nil]. "write the image data" objectMemory hasSpurMemoryManagerAPI ifTrue: [bytesWritten := objectMemory writeImageSegmentsToFile: f] ifFalse: [bytesWritten := self sq: (self pointerForOop: objectMemory baseAddressOfImage) Image: (self sizeof: #char) File: imageBytes Write: f]. self success: bytesWritten = imageBytes. self sqImageFileClose: f!

1 0

[OpenSmalltalk/opensmalltalk-vm] 362c1e: CogVM source as per VMMaker.oscog-eem.2264
by GitHub 23 Aug '17

23 Aug '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 362c1e223dff8a41a41f097608588ffcecaf5546 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/362c1e223dff8a41a4… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-08-22 (Tue, 22 Aug 2017) Changed paths: M image/BuildSqueakSpurTrunkVMMakerImage.st M nsspur64src/vm/cogit.h M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cogit.h M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/vm/cogit.h M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2264 Spur: The InterpreterProxy/sqVirtualMachine.h API (e.g. in the ThreadedFFIPlugin) expects instantiateClass:indexableSize: to work with 0 indexable size for fixed classes. So remove the cppIf:... from the Spur implementation. ObjectMemory: Eliminate the header2 variable in a few routines. It is always the same as classPointer. General: If ioScreenSize answers a zero screen extent (as is the case for headless images) then on snapshot write the sawvedWindowSize rather thna the zero extent. This should fix the experience people have with Pharo of saving headless images that then come up with a zero sized window when started headful. Image: Fix a repository name in the image build script,

1 0

VM Maker: VMMaker.oscog-eem.2264.mcz
by commits＠source.squeak.org 23 Aug '17

23 Aug '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2264.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2264 Author: eem Time: 22 August 2017, 5:52:20.489903 pm UUID: 9708118d-160d-4940-8282-8801b300c3bf Ancestors: VMMaker.oscog-eem.2263 Spur: The OmterpreterProxy/sqVirtualMachine.h API (e.g. in the ThreadedFFIPlugin) expects instantiateClass:indexableSize: to work with 0 indexable size for fixed classes. So remove the cppIf:... from the Spur implementation. ObjectMemory: Eliminate the header2 variable in a few routines. It is always the same as classPointer. General: If ioScreenSize answers a zero screen extent (as is the case for headless images) then on snapshot write the sawvedWindowSize rather thna the zero extent. This should fix the experience people have with Pharo of saving headless images that then come up with a zero sized window when started headful. =============== Diff against VMMaker.oscog-eem.2263 =============== Item was changed: ----- Method: ObjectMemory>>instantiateClass:indexableSize: (in category 'interpreter access') ----- instantiateClass: classPointer indexableSize: size "NOTE: This method supports the backward-compatible split instSize field of the class format word. The sizeHiBits will go away and other shifts change by 2 when the split fields get merged in an (incompatible) image change." <api> + | hash header1 cClass byteSize format binc header3 hdrSize sizeHiBits bm1 classFormat | - | hash header1 header2 cClass byteSize format binc header3 hdrSize sizeHiBits bm1 classFormat | <inline: false> self assert: size >= 0. "'cannot have a negative indexable field count" hash := self newObjectHash. classFormat := self formatOfClass: classPointer. "Low 2 bits are 0" header1 := (classFormat bitAnd: 16r1FF00) bitOr: (hash bitAnd: HashMaskUnshifted) << HashBitsOffset. - header2 := classPointer. sizeHiBits := (classFormat bitAnd: 16r60000) >> 9. cClass := header1 bitAnd: CompactClassMask. "compact class field from format word" byteSize := (classFormat bitAnd: SizeMask + Size4Bit) + sizeHiBits. "size in bytes -- low 2 bits are 0" "Note this byteSize comes from the format word of the class which is pre-shifted to 4 bytes per field. Need another shift for 8 bytes per word..." byteSize := byteSize << (self shiftForWord-2). format := self formatOfHeader: classFormat. self flag: #sizeLowBits. format < self firstByteFormat ifTrue: [format = self firstLongFormat ifTrue: "long32 bitmaps" [bm1 := self wordSize-1. byteSize := byteSize + (size * 4) + bm1 bitAnd: LongSizeMask. "round up" binc := bm1 - ((size * 4) + bm1 bitAnd: bm1). "odd bytes" "extra low bit (4) for 64-bit VM goes in 4-bit (betw hdr bits and sizeBits)" header1 := header1 bitOr: (binc bitAnd: 4)] ifFalse: "Arrays and 64-bit bitmaps" [byteSize := byteSize + (size * self wordSize)]] ifFalse: ["Strings and Methods" bm1 := self wordSize-1. byteSize := byteSize + size + bm1 bitAnd: LongSizeMask. "round up" binc := bm1 - (size + bm1 bitAnd: bm1). "odd bytes" "low bits of byte size go in format field" header1 := header1 bitOr: (binc bitAnd: 3) << self instFormatFieldLSB. "extra low bit (4) for 64-bit VM goes in 4-bit (betw hdr bits and sizeBits)" header1 := header1 bitOr: (binc bitAnd: 4)]. byteSize > 255 "requires size header word/full header" ifTrue: [header3 := byteSize. hdrSize := 3] ifFalse: [header1 := header1 bitOr: byteSize. hdrSize := cClass = 0 ifTrue: [2] ifFalse: [1]]. + ^self allocate: byteSize headerSize: hdrSize h1: header1 h2: classPointer h3: header3 doFill: true format: format! - ^self allocate: byteSize headerSize: hdrSize h1: header1 h2: header2 h3: header3 doFill: true format: format! Item was changed: ----- Method: ObjectMemory>>instantiateContext:sizeInBytes: (in category 'interpreter access') ----- instantiateContext: classPointer sizeInBytes: sizeInBytes "This version of instantiateClass assumes that the total object size is under 256 bytes, the limit for objects with only one or two header words. Note that the size is specified in bytes and should include four bytes for the base header word." + | hash header1 hdrSize | - | hash header1 header2 hdrSize | hash := self newObjectHash. header1 := (hash bitAnd: HashMaskUnshifted) << HashBitsOffset bitOr: (self formatOfClass: classPointer). - header2 := classPointer. (header1 bitAnd: CompactClassMask) > 0 "are contexts compact?" ifTrue: [hdrSize := 1] ifFalse: [hdrSize := 2]. sizeInBytes <= SizeMask ifTrue: ["OR size into header1. Must not do this if size > SizeMask" header1 := header1 + (sizeInBytes - (header1 bitAnd: SizeMask))] ifFalse: [hdrSize := 3. "Zero the size field of header1 if large" header1 := header1 - (header1 bitAnd: SizeMask)]. + ^self allocate: sizeInBytes headerSize: hdrSize h1: header1 h2: classPointer h3: LargeContextSize doFill: false format: 0 "ignored cuz doFill: is false"! - self flag: #Dan. "Check details of context sizes" - ^ self allocate: sizeInBytes headerSize: hdrSize h1: header1 h2: header2 h3: LargeContextSize doFill: false format: 0! Item was changed: ----- Method: ObjectMemory>>instantiateSmallClass:sizeInBytes: (in category 'interpreter access') ----- instantiateSmallClass: classPointer sizeInBytes: sizeInBytes "This version of instantiateClass assumes that the total object size is under 256 bytes, the limit for objects with only one or two header words. Note that the size is specified in bytes and should include 4 or 8 bytes for the base header word. NOTE this code will only work for sizes that are an integral number of words (like not a 32-bit LargeInteger in a 64-bit system). May cause a GC. + Note that the created small object IS NOT FILLED and must be completed before + returning it to Squeak. Since this call is used in routines that do just that we are safe. + Break this rule and die." - Note that the created small object IS NOT FILLED and must be completed before returning it to Squeak. Since this call is used in routines that do jsut that we are safe. Break this rule and die." + | hash header1 hdrSize | - | hash header1 header2 hdrSize | (sizeInBytes bitAnd: (self wordSize-1)) = 0 ifFalse: [self error: 'size must be integral number of words']. hash := self newObjectHash. header1 := (hash bitAnd: HashMaskUnshifted) << HashBitsOffset bitOr: (self formatOfClass: classPointer). - header2 := classPointer. hdrSize := (header1 bitAnd: CompactClassMask) > 0 "is this a compact class" ifTrue: [1] ifFalse: [2]. header1 := header1 + (sizeInBytes - (header1 bitAnd: SizeMask+Size4Bit)). + ^self allocate: sizeInBytes headerSize: hdrSize h1: header1 h2: classPointer h3: 0 doFill: false format: 0 "ignored cuz doFill: is false"! - ^ self allocate: sizeInBytes headerSize: hdrSize h1: header1 h2: header2 h3: 0 doFill: false format: 0! Item was changed: ----- Method: Spur32BitMemoryManager>>instantiateClass:indexableSize: (in category 'instantiation') ----- instantiateClass: classObj indexableSize: nElements <api> <var: #nElements type: #usqInt> "Allocate an instance of a variable class, excepting CompiledMethod." | instSpec classFormat numSlots classIndex newObj fillValue | classFormat := self formatOfClass: classObj. instSpec := self instSpecOfClassFormat: classFormat. classIndex := self rawHashBitsOf: classObj. fillValue := 0. instSpec caseOf: { [self arrayFormat] -> [numSlots := nElements. fillValue := nilObj]. [self indexablePointersFormat] -> [numSlots := (self fixedFieldsOfClassFormat: classFormat) + nElements. fillValue := nilObj]. [self weakArrayFormat] -> [numSlots := (self fixedFieldsOfClassFormat: classFormat) + nElements. fillValue := nilObj]. [self sixtyFourBitIndexableFormat] -> [nElements > (self maxSlotsForAlloc / 2) ifTrue: [coInterpreter primitiveFailFor: PrimErrUnsupported. ^nil]. numSlots := nElements * 2]. [self firstLongFormat] -> [(classIndex = ClassFloatCompactIndex and: [nElements ~= 2]) ifTrue: [coInterpreter primitiveFailFor: PrimErrBadReceiver. ^nil]. numSlots := nElements]. [self firstShortFormat] -> [numSlots := nElements + 1 // 2. instSpec := instSpec + (nElements bitAnd: 1)]. [self firstByteFormat] -> [numSlots := nElements + 3 // 4. instSpec := instSpec + (4 - nElements bitAnd: 3)] } otherwise: "non-indexable" + ["Some Squeak images include funky fixed subclasses of abstract variable + superclasses. e.g. DirectoryEntry as a subclass of ArrayedCollection. + The (Threaded)FFIPlugin expects to be able to instantiate ExternalData via + this method. + Hence allow fixed classes to be instantiated here iff nElements = 0." + (nElements ~= 0 or: [instSpec > self lastPointerFormat]) ifTrue: + [^nil]. + numSlots := self fixedFieldsOfClassFormat: classFormat. + fillValue := nilObj]. - [self cppIf: (PharoVM or: [true]) "Leave the old code but ignore it completely unless someone complains." - ifTrue: - [^nil] - ifFalse: - ["some Squeak images include funky fixed subclasses of abstract variable - superclasses. e.g. DirectoryEntry as a subclass of ArrayedCollection. - Allow fixed classes to be instantiated here iff nElements = 0." - (nElements ~= 0 or: [instSpec > self lastPointerFormat]) ifTrue: - [^nil]. - numSlots := self fixedFieldsOfClassFormat: classFormat. - fillValue := nilObj]]. classIndex = 0 ifTrue: [classIndex := self ensureBehaviorHash: classObj. classIndex < 0 ifTrue: [coInterpreter primitiveFailFor: classIndex negated. ^nil]]. numSlots > self maxSlotsForNewSpaceAlloc ifTrue: [numSlots > self maxSlotsForAlloc ifTrue: [coInterpreter primitiveFailFor: PrimErrUnsupported. ^nil]. newObj := self allocateSlotsInOldSpace: numSlots format: instSpec classIndex: classIndex] ifFalse: [newObj := self allocateSlots: numSlots format: instSpec classIndex: classIndex]. newObj ifNotNil: [self fillObj: newObj numSlots: numSlots with: fillValue]. ^newObj! Item was changed: ----- Method: Spur64BitMemoryManager>>instantiateClass:indexableSize: (in category 'instantiation') ----- instantiateClass: classObj indexableSize: nElements <api> <var: #nElements type: #usqInt> "Allocate an instance of a variable class, excepting CompiledMethod." | instSpec classFormat numSlots classIndex newObj fillValue | classFormat := self formatOfClass: classObj. instSpec := self instSpecOfClassFormat: classFormat. classIndex := self rawHashBitsOf: classObj. fillValue := 0. instSpec caseOf: { [self arrayFormat] -> [numSlots := nElements. fillValue := nilObj]. [self indexablePointersFormat] -> [numSlots := (self fixedFieldsOfClassFormat: classFormat) + nElements. fillValue := nilObj]. [self weakArrayFormat] -> [numSlots := (self fixedFieldsOfClassFormat: classFormat) + nElements. fillValue := nilObj]. [self sixtyFourBitIndexableFormat] -> [numSlots := nElements]. [self firstLongFormat] -> [(classIndex = ClassFloatCompactIndex and: [nElements ~= 2]) ifTrue: [coInterpreter primitiveFailFor: PrimErrBadReceiver. ^nil]. numSlots := nElements + 1 // 2. instSpec := instSpec + (nElements bitAnd: 1)]. [self firstShortFormat] -> [numSlots := nElements + 3 // 4. instSpec := instSpec + (4 - nElements bitAnd: 3)]. [self firstByteFormat] -> [numSlots := nElements + 7 // 8. instSpec := instSpec + (8 - nElements bitAnd: 7)] } otherwise: "non-indexable" + ["Some Squeak images include funky fixed subclasses of abstract variable + superclasses. e.g. DirectoryEntry as a subclass of ArrayedCollection. + The (Threaded)FFIPlugin expects to be able to instantiate ExternalData via + this method. + Hence allow fixed classes to be instantiated here iff nElements = 0." + (nElements ~= 0 or: [instSpec > self lastPointerFormat]) ifTrue: + [^nil]. + numSlots := self fixedFieldsOfClassFormat: classFormat. + fillValue := nilObj]. - [self cppIf: (PharoVM or: [true]) "Leave the old code but ignore it completely unless someone complains." - ifTrue: - [^nil] - ifFalse: - ["some Squeak images include funky fixed subclasses of abstract variable - superclasses. e.g. DirectoryEntry as a subclass of ArrayedCollection. - Allow fixed classes to be instantiated here iff nElements = 0." - (nElements ~= 0 or: [instSpec > self lastPointerFormat]) ifTrue: - [^nil]. - numSlots := self fixedFieldsOfClassFormat: classFormat. - fillValue := nilObj]]. classIndex = 0 ifTrue: [classIndex := self ensureBehaviorHash: classObj. classIndex < 0 ifTrue: [coInterpreter primitiveFailFor: classIndex negated. ^nil]]. numSlots > self maxSlotsForNewSpaceAlloc ifTrue: [numSlots > self maxSlotsForAlloc ifTrue: [coInterpreter primitiveFailFor: PrimErrUnsupported. ^nil]. newObj := self allocateSlotsInOldSpace: numSlots format: instSpec classIndex: classIndex] ifFalse: [newObj := self allocateSlots: numSlots format: instSpec classIndex: classIndex]. newObj ifNotNil: [self fillObj: newObj numSlots: numSlots with: fillValue]. ^newObj! Item was added: + ----- Method: StackInterpreter>>getSnapshotScreenSize (in category 'internal interpreter access') ----- + getSnapshotScreenSize + "Answer the screen size to write to the snapshot. + If the actual screen size is zero then write the savedWindowSize instead." + | screenSize | + screenSize := self ioScreenSize. + ((screenSize bitAnd: 16rFFFF) = 0 + or: [screenSize >> 16 = 0]) ifTrue: + [screenSize := savedWindowSize]. + ^screenSize!

1 0

Re: [Vm-dev] [Pharo-dev] eventual crashes pharo vm
by Eliot Miranda 18 Aug '17

18 Aug '17

Hi Henry, On Wed, Aug 16, 2017 at 6:33 PM, henry <henry(a)callistohouse.club> wrote: > That is good news, that it is due to this code doing funniness than a VM > issue. This code trying to bring asynchrony within a synchronous > environment brings new issues. > > What do you think that right solution is to the issue of a call > expected to be immediate, change out to go eventual until the arguments > resolve? > I'm not informed enough to know. One could implement mustBeBoolean in the ERef hierarchy and resolve the promise before going on. One could rely on the mustBeBooleanMagic: if one wanted a fully lazy system. I don't know the trade-offs between the two. I do know that while the miustBeBooleanMagic: solution is cool and fun it is extremely slow. So if performance is an issue use the first approach. > How can it be structured correctly on the stack without generic functions? > I think with the double dispatch of an eventual but I have not spend much > time in this particular area. > Yes that's an issue There is already a problem with #==. It needs to be symmetric for correctness. > Preventing the vm from crashing would be a good interim step but even here > I am not sure how to go about crafting a solution. > Well, the issue is simply that the wrong pc is chosen for the continuation after the mustBeBoolean. I'm sure the right answer is straight-forward to obtain. > Thank you for investigating this. > You're welcome. > > - HH > > > On Wed, Aug 16, 2017 at 20:46, Eliot Miranda <eliot.miranda(a)gmail.com> > wrote: > > Hi Henry, Hi Marcus, > > On Sun, Aug 13, 2017 at 5:08 AM, henry <henry(a)callistohouse.club> wrote: > >> Hi all. I was testing with this eventual_test package and it blows up the >> pharo 6.1 vm. I'd welcome pointers >> >> http://www.squeaksource.com/TurquoiseTesting.html >> >> - HH >> > > I took a look at this and I think you've found a bug in the > mustBeBooleanMagic: code. What's happening is a mustBeBoolean in > Integer>>* due to evaluating > 10 * 42 eventual > in RefsTest>>testFailureArithmeticPrimitivesWithPromiseArgument > > Since 42 eventual is a NearERef the SmallInteger>>* primitive fails and > does ^super * anInteger (where anInteger is the NearERef). So that > evaluates Integer>>* > > Integer>>* aNumber > "Refer to the comment in Number * " > aNumber isInteger ifTrue: > [^ self digitMultiply: aNumber > neg: self negative ~~ aNumber negative]. > ^ aNumber adaptToInteger: self andSend: #* > > aNumber, being a NearERef, answers a PromiseERef for the isInteger send, > and this provokes a mustBeBoolean for the isInteger ifTrue: [... > > After the mustBeBooleanMagic: the stack looks wrong. The activation of > Integer>>*, which is about to do > ^ aNumber adaptToInteger: self andSend: #* > does not have enough items on the stack. Instead of containing > a NearERef (for 42) > 10 > #* > it contains > a PromiseERef (for 42 eventual isInteger) > > and the send of #adaptToInteger:andSend: ends up taking more form the > stack than the VM can handle and it crashes. The bug appears to be with > the use of sendNode irInstruction nextBytecodeOffsetAfterJump in > Object>>mustBeBooleanMagic: since execution should resume at bytecode 55 > below, but does so at bytecode 57 > > 41 <10> pushTemp: 0 > 42 <D0> send: isInteger > 43 <AC 09> jumpFalse: 54 > 45 <70> self > 46 <10> pushTemp: 0 > 47 <70> self > 48 <D1> send: negative > 49 <10> pushTemp: 0 > 50 <D1> send: negative > 51 <E2> send: ~~ > 52 <F3> send: digitMultiply:neg: > 53 <7C> returnTop > 54 <10> pushTemp: 0 > 55 <70> self > 56 <24> pushConstant: #* > 57 <F5> send: adaptToInteger:andSend: > 58 <7C> returnTop > > So the positioning of the context's pc must be before any argument > marshaling for the next send, not simply the send itself. > > Put a breakpoint at the end of Object>>mustBeBooleanMagic: and add > initlaPC and resumePC temporaries at the beginning and capture them via > initialPC := context pc. > at the beginning and then > context pc: (resumePC := sendNode irInstruction > nextBytecodeOffsetAfterJump) > to see what I'm seeing. > > > Phew. Glad it's not a VM bug :-) > > HTH > _,,,^..^,,,_ > best, Eliot > > -- _,,,^..^,,,_ best, Eliot

3 5

File & Socket Handle Access
by Eliot Miranda 17 Aug '17

17 Aug '17

Hi All, recently Denis Kudriashov wanted to access the OS handle of a Socket from the image to pass through the FFI. David Lewis pointed out that the AioPlugin provides a primitive to do this. I asked David why he didn't add it to the SocketPlugin in the first place and he discussed Andreas Rabb's security concerns. It strikes me a) that accessing the OS handle of a file or a socket is extremely useful in some circumstances and invalid in others b) having handle access in a secondary plugin is inconvenient to say the least c) having access only to Socket handles and not to file handles is also inconvenient. So I propose adding a SecurityPlugin facility to control handle access, which would be granted by default, and to add primitives to both the SocketPlugin and FilePlugin to answer the native OS handle when the SecurityPlugin grants permission. I also propose adding a compilation flag to the Windows VM to allow compiling out Andreas' handle management, which consists merely of maintaining a table of the file handles (not the socket handles) that have been created by the VM. It strikes me that a much better solution is merely to encrypt the handle via xoring with a value created at random. I don't see how Andreas' solution adds value, especially since it is not implemented on other platforms, and merely adds overhead. Thoughts? Objections? _,,,^..^,,,_ best, Eliot

8 9

Mac and iOS VMs - how to debug?
by Todd Blanchard 17 Aug '17

17 Aug '17

Hi, I'm interested in 1) learning more about how the VM interfaces with the Mac OS. Usually to get a feel for this sort of thing I'd build the thing in Xcode, run it in the debugger, set some breakpoints, and observe the stack traces. Since the VM is built using command line tools, what's a good way to get the VM under a debugger so I can observe it running? I'm more interested in the platform specific bits rather than the portable parts. 2) Is there an iOS VM? I cloned the git repo and see build directories for a number of platforms. I don't see anything other than desktops. No raspberry pi, no iOS etc... I do find some references to these in the platforms directory but I don't quite understand how it all fits together. Thanks for any pointers. -Todd Blanchard

3 2

VM Maker: VMMaker.oscog-eem.2263.mcz
by commits＠source.squeak.org 17 Aug '17

17 Aug '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2263.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2263 Author: eem Time: 16 August 2017, 5:51:47.526756 pm UUID: d95f8ff7-d4f0-4d22-911e-45174146c4ab Ancestors: VMMaker.oscog-eem.2262 Fix simulation of Pharo primitiveDirectoryLookup above Squeak. =============== Diff against VMMaker.oscog-eem.2262 =============== Item was changed: ----- Method: CogVMSimulator>>primitiveDirectoryLookup (in category 'file primitives') ----- primitiveDirectoryLookup | index pathName array result | index := self stackIntegerValue: 0. + pathName := self stringOf: (self stackValue: 1). - pathName := (self stringOf: (self stackValue: 1)). self successful ifFalse: [^self primitiveFail]. array := FileDirectory default primLookupEntryIn: pathName index: index. + array ifNil: - array == nil ifTrue: [self pop: 3 thenPush: objectMemory nilObject. + ^array]. - ^array]. array == #badDirectoryPath ifTrue: + [^self "halt" primitiveFail]. - ["self halt." - ^self primitiveFail]. + result := PharoVM + ifTrue: [self makeDirEntryName: (array at: 1) size: (array at: 1) size - PharoVM - ifTrue: [ - result := self makeDirEntryName: (array at: 1) size: (array at: 1) size createDate: (array at: 2) modDate: (array at: 3) isDir: (array at: 4) fileSize: (array at: 5) + posixPermissions: (array at: 6 ifAbsent: 8r664) isSymlink: (array at: 7 ifAbsent: [false]) ] + ifFalse: [self makeDirEntryName: (array at: 1) size: (array at: 1) size - posixPermissions: (array at: 6) isSymlink: (array at: 7) ] - ifFalse: [ - result := self makeDirEntryName: (array at: 1) size: (array at: 1) size createDate: (array at: 2) modDate: (array at: 3) + isDir: (array at: 4) fileSize: (array at: 5)]. - isDir: (array at: 4) fileSize: (array at: 5) ]. self pop: 3 thenPush: result! Item was changed: ----- Method: StackInterpreterSimulator>>primitiveDirectoryLookup (in category 'file primitives') ----- primitiveDirectoryLookup | index pathName array result | index := self stackIntegerValue: 0. + pathName := self stringOf: (self stackValue: 1). - pathName := (self stringOf: (self stackValue: 1)). self successful ifFalse: [^self primitiveFail]. array := FileDirectory default primLookupEntryIn: pathName index: index. + array ifNil: - array == nil ifTrue: [self pop: 3 thenPush: objectMemory nilObject. + ^array]. - ^array]. array == #badDirectoryPath ifTrue: + [^self "halt" primitiveFail]. - ["self halt." - ^self primitiveFail]. + result := PharoVM + ifTrue: [self makeDirEntryName: (array at: 1) size: (array at: 1) size - PharoVM - ifTrue: [ - result := self makeDirEntryName: (array at: 1) size: (array at: 1) size createDate: (array at: 2) modDate: (array at: 3) isDir: (array at: 4) fileSize: (array at: 5) + posixPermissions: (array at: 6 ifAbsent: 8r664) isSymlink: (array at: 7 ifAbsent: [false]) ] + ifFalse: [self makeDirEntryName: (array at: 1) size: (array at: 1) size - posixPermissions: (array at: 6) isSymlink: (array at: 7) ] - ifFalse: [ - result := self makeDirEntryName: (array at: 1) size: (array at: 1) size createDate: (array at: 2) modDate: (array at: 3) + isDir: (array at: 4) fileSize: (array at: 5)]. + - isDir: (array at: 4) fileSize: (array at: 5) ]. self pop: 3 thenPush: result!

1 0

Re: [Vm-dev] [Pharo-dev] eventual crashes pharo vm
by Eliot Miranda 17 Aug '17

17 Aug '17

Hi Henry, Hi Marcus, On Sun, Aug 13, 2017 at 5:08 AM, henry <henry(a)callistohouse.club> wrote: > Hi all. I was testing with this eventual_test package and it blows up the > pharo 6.1 vm. I'd welcome pointers > > http://www.squeaksource.com/TurquoiseTesting.html > > - HH > I took a look at this and I think you've found a bug in the mustBeBooleanMagic: code. What's happening is a mustBeBoolean in Integer>>* due to evaluating 10 * 42 eventual in RefsTest>>testFailureArithmeticPrimitivesWithPromiseArgument Since 42 eventual is a NearERef the SmallInteger>>* primitive fails and does ^super * anInteger (where anInteger is the NearERef). So that evaluates Integer>>* Integer>>* aNumber "Refer to the comment in Number * " aNumber isInteger ifTrue: [^ self digitMultiply: aNumber neg: self negative ~~ aNumber negative]. ^ aNumber adaptToInteger: self andSend: #* aNumber, being a NearERef, answers a PromiseERef for the isInteger send, and this provokes a mustBeBoolean for the isInteger ifTrue: [... After the mustBeBooleanMagic: the stack looks wrong. The activation of Integer>>*, which is about to do ^ aNumber adaptToInteger: self andSend: #* does not have enough items on the stack. Instead of containing a NearERef (for 42) 10 #* it contains a PromiseERef (for 42 eventual isInteger) and the send of #adaptToInteger:andSend: ends up taking more form the stack than the VM can handle and it crashes. The bug appears to be with the use of sendNode irInstruction nextBytecodeOffsetAfterJump in Object>>mustBeBooleanMagic: since execution should resume at bytecode 55 below, but does so at bytecode 57 41 <10> pushTemp: 0 42 <D0> send: isInteger 43 <AC 09> jumpFalse: 54 45 <70> self 46 <10> pushTemp: 0 47 <70> self 48 <D1> send: negative 49 <10> pushTemp: 0 50 <D1> send: negative 51 <E2> send: ~~ 52 <F3> send: digitMultiply:neg: 53 <7C> returnTop 54 <10> pushTemp: 0 55 <70> self 56 <24> pushConstant: #* 57 <F5> send: adaptToInteger:andSend: 58 <7C> returnTop So the positioning of the context's pc must be before any argument marshaling for the next send, not simply the send itself. Put a breakpoint at the end of Object>>mustBeBooleanMagic: and add initlaPC and resumePC temporaries at the beginning and capture them via initialPC := context pc. at the beginning and then context pc: (resumePC := sendNode irInstruction nextBytecodeOffsetAfterJump) to see what I'm seeing. Phew. Glad it's not a VM bug :-) HTH _,,,^..^,,,_ best, Eliot

1 0

[OpenSmalltalk/opensmalltalk-vm] 414fab: Update Mac HowToBuilds with info on debugging with...
by GitHub 16 Aug '17

16 Aug '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 414fab12d3226dd23587c99cf982f2b406818726 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/414fab12d3226dd235… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-08-16 (Wed, 16 Aug 2017) Changed paths: M build.macos32x86/HowToBuild M build.macos64x64/HowToBuild M platforms/win32/vm/sqWin32HandleTable.h Log Message: ----------- Update Mac HowToBuilds with info on debugging with lldb. Add a NO_HANDLE_TABLE define to the Windows VMs to disable the handle table currently used only for file handles.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev August 2017