Vm-dev June 2017

vm-dev@lists.squeakfoundation.org

32 participants
76 discussions

halp.
by Tobias Pape 14 Jun '17

14 Jun '17

Dear all I'm calling from the ssl-basement, and lo and behold, it's all a mess. First, the "fun" parts: - OSX SSL does not support ALPN (necessary for good HTTP/2, go figure) - while we are at picking, OSX SSL, when using via secure transport, does not give you more hints than * trustworthy (+ trustworthy cause you said me so via keychain) * _maybe_ trustworthy * not trustworthy. Here's the gem from their code: /* ... */ status = errSSLXCertChainInvalid; } /* Do we really need to return things like: errSSLNoRootCert errSSLUnknownRootCert errSSLCertExpired errSSLCertNotYetValid errSSLHostNameMismatch for our client to see what went wrong, or should we just always return errSSLXCertChainInvalid when something is wrong? */ break; /* ... */ Really, that's the current code. Color me surprised (to put it politely) Now the really un-fun part: peer-name validation. ------------------------------------------------- It's half-way ok for osx, quite ok for windows but not right and absent for openssl/unix/linux. Levente set out to make that better two years ago but I stopped him (sorry for blocking this, btw :( ) Just now I had to close his PR (https://github.com/squeak-smalltalk/squeakssl/pull/3), and I think I'm stuck. Just HOW can we achieve the following without _massive_ engineering effort, essentially duplicating large parts of libcurl? **What do we want?** -------------------- Check that we connected to the right peer with the right certificate. Up to now the idea _was_ to extract the "peer name" from the `CommonName` of whom we contacted. However, this is completely insufficient because it need things (a) beyond checking the commonName (serverAlternativeName) and (b) sAN has some priorities as per RFT 2818, 3.1 Server Idenitity et al. Also: What if a cert has multiple names in the CN (yes that is possible) or the sAN (yes, that is even common)? OK, we hence _must_ ditch the idea to have the "peer name" handed to the image, because we cannot know _which_ one of multiple the image wants… except when we were given a `serverName` previously. But even then, this is _really_ complex: 1. If a certificaet has sAN of dNSName type it MUST be used (even if cn is present). 2. Certificates not having sAN (and cn only) is DEPRECATED. 3. If a certificate has multiple sAN/dNSName, any of them is a potential match. 4. Wildcards (*) SHALL only appear as whole name parts, and have other restrictions. * Example: - `*.example.com` is valid, but - `*x.example.com` is technically valid but practically invalid - `*example.com` is technically valid but practically invalid - `test.*.example.com` is invalid (as per RFC 6125) - `*.*.example.com` is invalid - `*`, `*.`, `*.*`, etc. is invalid * Other matching examples: - `*.example.com` matches `a.example.com` BUT does NOT match `a.b.example.com` - `example.com` (in the certificate) matches `example.com.` (hostname) (note trailing period) BUT - `example.com.` (in the certificate) does NOT match `example.com.` (hostname) (note trailing period) - `example.com` (in the certificate) matches `EXAMPLE.com` (hostname) 5. IP Addresses MUT be of type sAN/iPAddress, NOT sAN/dNSName, they MUST match exactly. Due to 4., name checking is CANNOT as simple as ```Smalltalk certificateName match: peerName ``` on the image side. Systems ------- - On openssl/linux/unix, we have to care for _all_ of the above manually. - On osx, we have the funny trust thing from above and hence would have to do the checking on our own (which we would get for free if we wouldn't break the connection right before the internal trust evaluation and do that manually) - On win32, the trust evaluation is very good, verifying for us the hostname, too, but extracting it for image side hasn't been done. =============================================================== To all poor souls still reading, What Shall We Do? -Tobias

2 3

The byte order fallacy
by Ben Coman 13 Jun '17

13 Jun '17

I bumped into an interesting article [1] by Rob Pike that... i = *((int*)data); #ifdef BIG_ENDIAN /* swap the bytes */ i = ((i&0xFF)<<24) | (((i>>8)&0xFF)<<16) | (((i>>16)&0xFF)<<8) | (((i>>24)&0xFF)<<0); #endif is the wrong way to handle endianness since... "It assumes integers are addressable at any byte offset; on some machines that's not true." "It depends on integers being 32 bits long, or requires more #ifdefs to pick a 32-bit integer type." I guess some people here have byte-ordering war wounds so I'd value your opinion on whether I should file that as good advice. I notice we have a couple of instances of this... $ find platforms -name "*.c" -exec grep -Hi "<<" {} \; | grep ">>" | grep 24 | grep 8 ./win32/plugins/FontPlugin/sqWin32FontPlugin.c: #define BYTE_SWAP(w) ((w << 24) | ((w & 0xFF00) << 8) | ((w >> 8) & 0xFF00) | (w >> 24)) ./win32/vm/sqWin32Window.c: #define BYTE_SWAP(w) w = (w<<24) | ((w&0xFF00)<<8) | ((w>>8)&0xFF00) | (w>>24) cheers -ben [1] https://commandcenter.blogspot.com.au/2012/04/byte-order-fallacy.html

4 4

Validation builds failing
by K K Subbu 13 Jun '17

13 Jun '17

Hi, I tried revalidating my pull request https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/136 But validation checks are failing in Appveyor and Travis. Appveyor ld suffers a seg fault in win32x86/squeak.cog.v3 since 3 days: https://ci.appveyor.com/project/OpenSmalltalk/vm/history Travis has been failing for past 4 months (since build 603) https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds What should I do with my pull request? Close it now? or Wait for a green build and resubmit a new PR against this commit? Appreciate your help in resolving this bottleneck. TIA .. Subbu

4 5

[OpenSmalltalk/opensmalltalk-vm] b0a3f7: Generate correct name also for squeak.sista.spur
by GitHub 13 Jun '17

13 Jun '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: b0a3f7c368f31315187fb54f503c78aa4b30979e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b0a3f7c368f3131518… Author: Tobias Pape <tobias(a)netshed.de> Date: 2017-06-13 (Tue, 13 Jun 2017) Changed paths: M build.macos32x86/squeak.sista.spur/Makefile Log Message: ----------- Generate correct name also for squeak.sista.spur

4 3

[OpenSmalltalk/opensmalltalk-vm] b0a3f7: Generate correct name also for squeak.sista.spur
by GitHub 13 Jun '17

13 Jun '17

Branch: refs/heads/krono/highdpi-v2 Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: b0a3f7c368f31315187fb54f503c78aa4b30979e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b0a3f7c368f3131518… Author: Tobias Pape <tobias(a)netshed.de> Date: 2017-06-13 (Tue, 13 Jun 2017) Changed paths: M build.macos32x86/squeak.sista.spur/Makefile Log Message: ----------- Generate correct name also for squeak.sista.spur Commit: 32f200b6d35d25787e53dd0448246438a4d543a4 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/32f200b6d35d25787e… Author: Tobias Pape <tobias(a)netshed.de> Date: 2017-06-13 (Tue, 13 Jun 2017) Changed paths: M build.macos32x86/squeak.sista.spur/Makefile Log Message: ----------- Merge remote-tracking branch 'origin/Cog' into krono/highdpi-v2 * origin/Cog: Generate correct name also for squeak.sista.spur [ci skip] Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/8044775ccbb1...32…

1 0

[OpenSmalltalk/opensmalltalk-vm] b1bb2e: CogVM source as per VMMaker.oscog-eem.2242
by GitHub 13 Jun '17

13 Jun '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: b1bb2e26d0efe204b742681ba5674d9af57a4304 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b1bb2e26d0efe204b7… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-06-12 (Mon, 12 Jun 2017) Changed paths: M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2242 The self assert: (stackPages isFree: thePage) not in findSPOf:on:startingFrom: is misplaced. Relocate it to avoid a bogus assert fail running the Cadence debugger tests.

1 0

VM Maker: VMMaker.oscog-eem.2242.mcz
by commits＠source.squeak.org 12 Jun '17

12 Jun '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2242.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2242 Author: eem Time: 12 June 2017, 2:11:49.884748 pm UUID: 962fc704-64b1-41a9-9080-3eb3eb75c494 Ancestors: VMMaker.oscog-eem.2241 The self assert: (stackPages isFree: thePage) not in findSPOf:on:startingFrom: is misplaced. Relocate it to avoid a bogus assert ail running the Cadence debugger tests. =============== Diff against VMMaker.oscog-eem.2241 =============== Item was changed: ----- Method: StackInterpreter>>checkStackPointerIndexForFrame: (in category 'frame access') ----- checkStackPointerIndexForFrame: theFP "Version of stackPointerIndexForFrame: that does not depend on writing back head frame pointers. Used for assertion checking. Safe only in external primitives (framePointer valid). Answer the 0-based index rel to the given frame. (This is what stackPointer used to be before conversion to pointer)" "In the StackInterpreter stacks grow down." | thePage theSP | <inline: false> <var: #theFP type: #'char *'> <var: #thePage type: #'StackPage *'> <var: #theSP type: #'char *'> theFP = framePointer ifTrue: [^self stackPointerIndexForFrame: theFP WithSP: stackPointer]. thePage := stackPages stackPageFor: theFP. theSP := self findSPOrNilOf: theFP on: thePage startingFrom: (thePage = stackPage ifTrue: [framePointer] ifFalse: [thePage headFP]). + theSP ifNil: [^-1]. ^self stackPointerIndexForFrame: theFP WithSP: theSP! Item was changed: ----- Method: StackInterpreter>>findSPOf:on: (in category 'frame access') ----- findSPOf: theFP on: thePage "Search for the stack pointer for theFP. This points to the hottest item on the frame's stack. DO NOT CALL THIS WITH theFP == localFP OR theFP == framePointer!!" <var: #theFP type: #'char *'> <var: #thePage type: #'StackPage *'> <returnTypeC: #'char *'> | theSP | <inline: false> <var: #theSP type: #'char *'> + self deny: (stackPages isFree: thePage). theSP := self findSPOrNilOf: theFP on: thePage startingFrom: thePage headFP. + theSP ifNotNil: - theSP notNil ifTrue: [^theSP]. self error: 'did not find theFP in stack page'. ^0! Item was changed: ----- Method: StackInterpreter>>findSPOrNilOf:on:startingFrom: (in category 'frame access') ----- findSPOrNilOf: theFP on: thePage startingFrom: startFrame "Search for the stack pointer for theFP. This points to the hottest item on the frame's stack. DO NOT CALL THIS WITH theFP == localFP OR theFP == framePointer!!" <var: #theFP type: #'char *'> <var: #thePage type: #'StackPage *'> <var: #startFrame type: #'char *'> <returnTypeC: #'char *'> | aFrame prevFrame | <inline: true> <var: #aFrame type: #'char *'> <var: #prevFrame type: #'char *'> - self assert: (stackPages isFree: thePage) not. startFrame = theFP ifTrue: [thePage headSP >= startFrame ifTrue: ["If the SP is invalid return the pointer to the receiver field." ^self frameReceiverLocation: theFP]. "Skip the instruction pointer on top of stack of inactive pages." ^thePage = stackPage ifTrue: [thePage headSP] ifFalse: [thePage headSP + objectMemory wordSize]]. aFrame := startFrame. [prevFrame := aFrame. aFrame := self frameCallerFP: aFrame. aFrame ~= 0] whileTrue: [theFP = aFrame ifTrue: [^self frameCallerSP: prevFrame]]. ^nil!

1 0

High-Resolution Monitors
by Colin Putney 12 Jun '17

12 Jun '17

Hi folks, Does anybody know how to make Squeak look good on high resolution monitors? Using the latest VM and trunk image, it renders at half the resolution of the monitor and looks terrible as a result. Is there a setting somewhere that I need to tweak? I've attached a screenshot - you need to view it at full size to see the effect. Colin [image: Inline image 1]

1 0

Measuring allocations
by Jan Vrany 12 Jun '17

12 Jun '17

Hi folks, Having a Spur VM, I wonder how to measure heap allocations made by a process executing a particular block, from within the image. For example, let's have following block: [ | a | 100 timesRepeat: [ a := Array new: 100 ] ]. When run, this block allocates - if I'm correct - some 100 * (<object header size> + 4*100) bytes. Note that: * Ideally, I'd like to exclude allocations made by other threads but having allocations made by all threads would be OK too. * Block can span multiple scavenges even oldspace collects. * As shown in the example above, I need to take garbage into an account. How to best measure this? Thanks, Jan

3 6

[OpenSmalltalk/opensmalltalk-vm] 9a98be: CogVm source as per VMMaker.oscog-eem.2241
by GitHub 10 Jun '17

10 Jun '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 9a98be0c6d5968627db24a3e4d97d0be28fba27c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9a98be0c6d5968627d… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-06-09 (Fri, 09 Jun 2017) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64SysV.c M nsspur64src/vm/cogitX64WIN64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cogit.h M spur64src/vm/cogitX64SysV.c M spur64src/vm/cogitX64WIN64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spursista64src/vm/cogit.h M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c Log Message: ----------- CogVm source as per VMMaker.oscog-eem.2241 Spur: Fix sign extension bug with new allocated bytes count.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev June 2017