Vm-dev May 2017

vm-dev@lists.squeakfoundation.org

39 participants
158 discussions

[OpenSmalltalk/opensmalltalk-vm] 5dd766: Implement the PREREQUISITES plugin exclusion mecha...
by GitHub 28 May '17

28 May '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 5dd7668b8d91f0bf789537cfc435a15c8935acc1 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/5dd7668b8d91f0bf78… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-05-28 (Sun, 28 May 2017) Changed paths: M build.macos32x86/common/Makefile.plugin M build.macos64x64/common/Makefile.plugin M build.win32x86/common/Makefile M build.win32x86/common/Makefile.plugin M build.win64x64/common/Makefile M build.win64x64/common/Makefile.plugin M platforms/win32/plugins/BochsIA32Plugin/Makefile.plugin M platforms/win32/plugins/BochsX64Plugin/Makefile.plugin Log Message: ----------- Implement the PREREQUISITES plugin exclusion mechanism for win32/64. Provide the same mechanism for Pharo dylib plugins on Mac OS X. Restore the dependency on the plugin makefile for win32. If the plugin makefile changes in any way we *should* rebuild the plugin; flags may have been changed, etc.

1 0

[OpenSmalltalk/opensmalltalk-vm] dd5609: Fix error C2466: impossible d'allouer un tableau d...
by GitHub 28 May '17

28 May '17

Branch: refs/heads/MSVCCodeGenerationBug Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: dd5609c1b82c41348df3a2d070def1241ad75292 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/dd5609c1b82c41348d… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-05-28 (Sun, 28 May 2017) Changed paths: M spur64src/vm/cogitX64WIN64.c Log Message: ----------- Fix error C2466: impossible d'allouer un tableau de taille constante 0 Commit: e9020ec82ffd6156371c03a0c16e7a785481b605 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/e9020ec82ffd615637… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-05-28 (Sun, 28 May 2017) Changed paths: M platforms/Cross/plugins/FilePlugin/FilePlugin.h M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c Log Message: ----------- Make recent FilePlugin changes MSVC compatible mode_t is not defined, it's int, and authorization flags will be different than unix Commit: 627c53527859a3d9e6ca8dddabb3d9c431eb2d9c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/627c53527859a3d9e6… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-05-28 (Sun, 28 May 2017) Changed paths: M spur64src/vm/cointerp.c Log Message: ----------- Provide a MSVC compatible setjmp in WIN64 Note: this change should be in VMMaker source Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/28c247870337...62…

1 0

[OpenSmalltalk/opensmalltalk-vm] 28c247: Add MSVC project demonstrating MSVC2017 code gener...
by GitHub 28 May '17

28 May '17

Branch: refs/heads/MSVCCodeGenerationBug Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 28c247870337656f0bdb0e8566480400b3a2159c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/28c247870337656f0b… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-05-28 (Sun, 28 May 2017) Changed paths: A build.msvc/Croquet.ico A build.msvc/GreenCogSqueak.ico A build.msvc/MSVCCodeGenerationBug/MSVCCodeGenerationBug.c A build.msvc/MSVCCodeGenerationBug/MSVCCodeGenerationBug.sln A build.msvc/MSVCCodeGenerationBug/MSVCCodeGenerationBug/MSVCCodeGenerationBug.vcxproj A build.msvc/MSVCCodeGenerationBug/MSVCCodeGenerationBug/MSVCCodeGenerationBug.vcxproj.filters A build.msvc/SqueakCogSpur.sln A build.msvc/SqueakCogSpur32.vcxproj A build.msvc/SqueakCogSpur32.vcxproj.filters A build.msvc/SqueakCogSpur64.vcxproj A build.msvc/SqueakCogSpur64.vcxproj.filters A build.msvc/SqueakStackSpur32.vcxproj A build.msvc/SqueakStackSpur32.vcxproj.filters A build.msvc/SqueakStackSpur64.vcxproj A build.msvc/SqueakStackSpur64.vcxproj.filters A build.msvc/sqNamedPrims.h A build.msvc/squeak.ico A build.msvc/squeak2.ico A build.msvc/squeak3.ico Log Message: ----------- Add MSVC project demonstrating MSVC2017 code generation bug

1 0

[OpenSmalltalk/opensmalltalk-vm] 7367a9: Define getsp and getfp for WIN64 MSVC
by GitHub 28 May '17

28 May '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 7367a97ea5901b20b4b0b6f2023f09b752aa1a60 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/7367a97ea5901b20b4… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-05-28 (Sun, 28 May 2017) Changed paths: M platforms/Cross/vm/sqCogStackAlignment.h Log Message: ----------- Define getsp and getfp for WIN64 MSVC Use the default COG engine generated functions ceGetSP ceGetFP

1 0

VM Maker: VMMaker.oscog-nice.2224.mcz
by commits＠source.squeak.org 28 May '17

28 May '17

Nicolas Cellier uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-nice.2224.mcz ==================== Summary ==================== Name: VMMaker.oscog-nice.2224 Author: nice Time: 28 May 2017, 9:32:26.516807 am UUID: fe6e83f5-ab7e-4c20-af1f-b784e4ef14f0 Ancestors: VMMaker.oscog-eem.2223 Revert leafCallStackPointerDelta change which was a bad guess for WIN64. Incorporate Monty's file plugin changes: add a new primitiveFileOpenNew to open an unexisting file atomically without race condition. =============== Diff against VMMaker.oscog-eem.2223 =============== Item was changed: ----- Method: CogX64Compiler>>leafCallStackPointerDelta (in category 'abi') ----- leafCallStackPointerDelta "Answer the delta from the stack pointer after a call to the stack pointer immediately prior to the call. This is used to compute the stack pointer immediately prior to call from within a leaf routine, which in turn is used + to capture the c stack pointer to use in trampolines back into the C run-time." + ^8! - to capture the c stack pointer to use in trampolines back into the C run-time. - In Win64 ABI, also count the stack reserved for saving 4 register arguments." - ^SysV - ifTrue: [8] - ifFalse: [8 + 32]! Item was added: + ----- Method: FilePlugin>>fileOpenNewName:size:secure: (in category 'file primitives') ----- + fileOpenNewName: nameIndex size: nameSize secure: secureFlag + "Open the new named file, possibly checking security. Answer the file oop." + | file fileOop okToOpen | + <var: #file type: 'SQFile *'> + <var: 'nameIndex' type: 'char *'> + <export: true> + fileOop := interpreterProxy instantiateClass: interpreterProxy classByteArray indexableSize: self fileRecordSize. + file := self fileValueOf: fileOop. + interpreterProxy failed + ifFalse: [ secureFlag ifTrue: [ + "If the security plugin can be loaded, use it to check for permission. + If not, assume it's ok" + sCOFfn ~= 0 + ifTrue: [okToOpen := self cCode: '((sqInt (*) (char *, sqInt, sqInt)) sCOFfn)(nameIndex, nameSize, true)' inSmalltalk:[true]. + okToOpen + ifFalse: [interpreterProxy primitiveFail]]]]. + interpreterProxy failed + ifFalse: [self cCode: 'sqFileOpenNew(file, nameIndex, nameSize)' inSmalltalk: [file]]. + ^ fileOop! Item was added: + ----- Method: FilePlugin>>primitiveFileOpenNew (in category 'file primitives') ----- + primitiveFileOpenNew + | namePointer filePointer nameIndex nameSize | + <var: 'nameIndex' type: 'char *'> + <export: true> + namePointer := interpreterProxy stackValue: 0. + (interpreterProxy isBytes: namePointer) + ifFalse: [^ interpreterProxy primitiveFail]. + nameIndex := interpreterProxy firstIndexableField: namePointer. + nameSize := interpreterProxy byteSizeOf: namePointer. + filePointer := self fileOpenNewName: nameIndex size: nameSize secure: true. + interpreterProxy failed + ifFalse: [ + interpreterProxy + pop: 2 "rcvr, name" + thenPush: filePointer] + ! Item was added: + ----- Method: FilePluginSimulator>>fileOpenNewName:size:secure: (in category 'file primitives') ----- + fileOpenNewName: nameIndex size: nameSize secure: secureFlag + "Open the new named file, possibly checking security. Answer the file oop." + | path f index | + openFiles size >= maxOpenFiles ifTrue: + [^interpreterProxy primitiveFailFor: PrimErrLimitExceeded]. + path := interpreterProxy interpreter asString: nameIndex size: nameSize. + "the #defaultAction for FileExistsException creates a dialog, + so it is caught and resignaled as a generic Error" + [f := FileStream newFileNamed: nameIndex] + on: FileExistsException + do: [:error | Error signal: 'File already exists: ', nameIndex]. + f ifNil: [^interpreterProxy primitiveFail]. + f binary. + index := openFiles size + 1. + openFiles at: index put: f. + ^interpreterProxy integerObjectOf: index!

1 0

VM Maker: Cog-eem.341.mcz
by commits＠source.squeak.org 27 May '17

27 May '17

Eliot Miranda uploaded a new version of Cog to project VM Maker: http://source.squeak.org/VMMaker/Cog-eem.341.mcz ==================== Summary ==================== Name: Cog-eem.341 Author: eem Time: 27 May 2017, 9:04:01.560953 am UUID: 836fa317-d240-4e50-aa33-c8d7c87e4ba8 Ancestors: Cog-eem.340 Provide support for smashing the shadow parameter space by refactoring smashCallerSavedRegistersWithValuesFrom:by: to smashCallerSavedRegistersWithValuesFrom:by:in:. For VMMaker.oscog-eem.2223 and subsequent. Have BochsX64Alien save the argument registers to the shadow parameter space when smashing registers. Breaks simulation in a similar place to the real system (earlier, probably because this always saves all four regsiters, whereas real code probably only saves as many registers as there are parameters, and doesn't always save them). =============== Diff against Cog-eem.340 =============== Item was removed: - ----- Method: BochsIA32Alien>>smashCallerSavedRegistersWithValuesFrom:by: (in category 'accessing-abstract') ----- - smashCallerSavedRegistersWithValuesFrom: base by: step - #(eax: ecx: edx:) - withIndexDo: - [:accessor :index| - self perform: accessor with: index - 1 * step + base]! Item was added: + ----- Method: BochsIA32Alien>>smashCallerSavedRegistersWithValuesFrom:by:in: (in category 'accessing-abstract') ----- + smashCallerSavedRegistersWithValuesFrom: base by: step in: aMemory + #(eax: ecx: edx:) + withIndexDo: + [:accessor :index| + self perform: accessor with: index - 1 * step + base]! Item was removed: - ----- Method: BochsX64Alien>>smashCallerSavedRegistersWithValuesFrom:by: (in category 'accessing-abstract') ----- - smashCallerSavedRegistersWithValuesFrom: base by: step - (CogX64Compiler isSysV - ifTrue: [#(rax: rcx: rdx: rsi: rdi: r8: r9: r10: r11:)] - ifFalse: [#(rax: rcx: rdx: r8: r9: r10: r11:)]) - withIndexDo: - [:accessor :index| - self perform: accessor with: index - 1 * step + base]! Item was added: + ----- Method: BochsX64Alien>>smashCallerSavedRegistersWithValuesFrom:by:in: (in category 'accessing-abstract') ----- + smashCallerSavedRegistersWithValuesFrom: base by: step in: aMemory + | volatileRegisters | + CogX64Compiler isSysV + ifTrue: + [volatileRegisters := #(rax: rcx: rdx: rsi: rdi: r8: r9: r10: r11:)] + ifFalse: "We should also save the registers to the shadow parameter space." + [volatileRegisters := #(rax: rcx: rdx: r8: r9: r10: r11:). + #(rcx rdx r8 r9) withIndexDo: + [:getter :index| + aMemory + unsignedLong64At: self rbp + 8 + (index * 8) "skip saved fp and retpc" + put: (self perform: getter)]]. + volatileRegisters withIndexDo: + [:setter :index| + self perform: setter with: index - 1 * step + base]! Item was removed: - ----- Method: GdbARMAlien>>smashCallerSavedRegistersWithValuesFrom:by: (in category 'accessing-abstract') ----- - smashCallerSavedRegistersWithValuesFrom: base by: step - #(r0: r1: r2: r3: r9: r12: lr:) withIndexDo: - [:accessor :index| - self perform: accessor with: index - 1 * step + base]! Item was added: + ----- Method: GdbARMAlien>>smashCallerSavedRegistersWithValuesFrom:by:in: (in category 'accessing-abstract') ----- + smashCallerSavedRegistersWithValuesFrom: base by: step in: aMemory + #(r0: r1: r2: r3: r9: r12: lr:) withIndexDo: + [:accessor :index| + self perform: accessor with: index - 1 * step + base]! Item was removed: - ----- Method: MIPSSimulator>>smashCallerSavedRegistersWithValuesFrom:by: (in category 'processor api') ----- - smashCallerSavedRegistersWithValuesFrom: base by: step - "i.e., smashVolatileRegisters" - self flag: #OABI. - self unsignedRegister: AT put: 0 * step + base. - self unsignedRegister: V0 put: 0 * step + base. - self unsignedRegister: V1 put: 0 * step + base. - self unsignedRegister: A0 put: 0 * step + base. - self unsignedRegister: A1 put: 0 * step + base. - self unsignedRegister: A2 put: 0 * step + base. - self unsignedRegister: A3 put: 0 * step + base. - self unsignedRegister: T0 put: 0 * step + base. - self unsignedRegister: T1 put: 0 * step + base. - self unsignedRegister: T2 put: 0 * step + base. - self unsignedRegister: T3 put: 0 * step + base. - self unsignedRegister: T4 put: 0 * step + base. - self unsignedRegister: T5 put: 0 * step + base. - self unsignedRegister: T6 put: 0 * step + base. - self unsignedRegister: T7 put: 0 * step + base. - self unsignedRegister: T8 put: 0 * step + base. - self unsignedRegister: T9 put: 0 * step + base. - self unsignedRegister: GP put: 0 * step + base. - self unsignedRegister: RA put: 0 * step + base.! Item was added: + ----- Method: MIPSSimulator>>smashCallerSavedRegistersWithValuesFrom:by:in: (in category 'processor api') ----- + smashCallerSavedRegistersWithValuesFrom: base by: step in: aMemory + "i.e., smashVolatileRegisters" + self flag: #OABI. + self unsignedRegister: AT put: 0 * step + base. + self unsignedRegister: V0 put: 1 * step + base. + self unsignedRegister: V1 put: 2 * step + base. + self unsignedRegister: A0 put: 3 * step + base. + self unsignedRegister: A1 put: 4 * step + base. + self unsignedRegister: A2 put: 5 * step + base. + self unsignedRegister: A3 put: 6 * step + base. + self unsignedRegister: T0 put: 7 * step + base. + self unsignedRegister: T1 put: 8 * step + base. + self unsignedRegister: T2 put: 9 * step + base. + self unsignedRegister: T3 put: 10 * step + base. + self unsignedRegister: T4 put: 11 * step + base. + self unsignedRegister: T5 put: 12 * step + base. + self unsignedRegister: T6 put: 13 * step + base. + self unsignedRegister: T7 put: 14 * step + base. + self unsignedRegister: T8 put: 15 * step + base. + self unsignedRegister: T9 put: 16 * step + base. + self unsignedRegister: GP put: 17 * step + base. + self unsignedRegister: RA put: 18 * step + base!

1 0

VM Maker: VMMaker.oscog-eem.2223.mcz
by commits＠source.squeak.org 27 May '17

27 May '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2223.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2223 Author: eem Time: 27 May 2017, 8:56:50.429078 am UUID: 9eb5defa-0b35-4377-a2d5-6456742d0719 Ancestors: VMMaker.oscog-eem.2222 Cogit simulation: Provide support for smashing the shadow parameter space by refactoring smashCallerSavedRegistersWithValuesFrom:by: to smashCallerSavedRegistersWithValuesFrom:by:in:. Needs Cog-eem.341 Remove a couple of unused and dubious methods in the CogAbstractInstruction hierarchy. Reduce the result of fromIEEE64BitWord: to a SmallFloat64 when possible. =============== Diff against VMMaker.oscog-eem.2222 =============== Item was removed: - ----- Method: CogARMCompiler>>genRestoreRegsExcept: (in category 'abi') ----- - genRestoreRegsExcept: abstractReg - "Restore the general purpose registers except for abstractReg for a trampoline call." - "Restore none, because the ARM ABI only defines callee saved registers, no caller-saved regs." - ! Item was removed: - ----- Method: CogARMCompiler>>numberOfSaveableRegisters (in category 'abi') ----- - numberOfSaveableRegisters - "Answer the number of registers to be saved in a trampoline call that saves registers. - None, See genSaveRegisters." - <cmacro: '(self) 0'> - ^0! Item was removed: - ----- Method: CogAbstractInstruction>>numberOfSaveableRegisters (in category 'abi') ----- - numberOfSaveableRegisters - "Answer the number of registers to be saved in a trampoline call that saves registers. - See genSaveRegisters" - self subclassResponsibility! Item was removed: - ----- Method: CogIA32Compiler>>genRestoreRegsExcept: (in category 'abi') ----- - genRestoreRegsExcept: preservedReg - self assert: (EDI > EAX and: [EDI - EAX + 1 = 6]). - EAX to: EDI do: - [:reg| - (reg between: ESP and: EBP) ifFalse: - [preservedReg = reg - ifTrue: [cogit AddCq: 4 R: ESP] - ifFalse: [cogit PopR: reg]]]. - ^0! Item was removed: - ----- Method: CogIA32Compiler>>numberOfSaveableRegisters (in category 'abi') ----- - numberOfSaveableRegisters - "Answer the number of registers to be saved in a trampoline call that saves registers. - See genSaveRegisters" - <cmacro: '(self) 6'> - ^6! Item was removed: - ----- Method: CogMIPSELCompiler>>genRestoreRegsExcept: (in category 'abi') ----- - genRestoreRegsExcept: abstractReg - "Restore the general purpose registers except for abstractReg for a trampoline call." - self flag: #bogus.! Item was removed: - ----- Method: CogMIPSELCompiler>>numberOfSaveableRegisters (in category 'abi') ----- - numberOfSaveableRegisters - "Answer the number of registers to be saved in a trampoline call that saves registers. - None, See genSaveRegisters." - <cmacro: '(self) 0'> - ^0! Item was removed: - ----- Method: CogX64Compiler>>genRestoreRegsExcept: (in category 'abi') ----- - genRestoreRegsExcept: preservedReg - self assert: (R15 > RAX and: [R15 - RAX + 1 = 16]). - RAX to: R15 do: - [:reg| - (reg between: RSP and: RBP) ifFalse: - [preservedReg = reg - ifTrue: [cogit AddCq: 8 R: RSP] - ifFalse: [cogit PopR: reg]]]. - ^0! Item was removed: - ----- Method: CogX64Compiler>>numberOfSaveableRegisters (in category 'abi') ----- - numberOfSaveableRegisters - "Answer the number of registers to be saved in a trampoline call that saves registers. - See genSaveRegisters" - <cmacro: '(self) 14'> - ^14! Item was changed: ----- Method: Cogit>>handleCallOrJumpSimulationTrap: (in category 'simulation only') ----- handleCallOrJumpSimulationTrap: aProcessorSimulationTrap <doNotGenerate> + | evaluable function memory result savedFramePointer savedStackPointer savedArgumentCount rpc | - | evaluable function result savedFramePointer savedStackPointer savedArgumentCount rpc | evaluable := simulatedTrampolines at: aProcessorSimulationTrap address. function := evaluable isBlock ifTrue: ['aBlock; probably some plugin primitive'] ifFalse: [evaluable receiver == backEnd ifTrue: [^self handleABICallOrJumpSimulationTrap: aProcessorSimulationTrap evaluable: evaluable]. evaluable selector]. function ~~ #ceBaseFrameReturn: ifTrue: [coInterpreter assertValidExternalStackPointers]. (function beginsWith: 'ceShort') ifTrue: [^self perform: function with: aProcessorSimulationTrap]. + aProcessorSimulationTrap type == #call - aProcessorSimulationTrap type = #call ifTrue: [processor simulateCallOf: aProcessorSimulationTrap address nextpc: aProcessorSimulationTrap nextpc + memory: (memory := coInterpreter memory). + self recordInstruction: {'(simulated call of '. aProcessorSimulationTrap address. '/'. function. ')'}] - memory: coInterpreter memory. - self recordInstruction: {'(simulated call of '. aProcessorSimulationTrap address. '/'. function. ')'}] ifFalse: [processor simulateJumpCallOf: aProcessorSimulationTrap address + memory: (memory := coInterpreter memory). - memory: coInterpreter memory. self recordInstruction: {'(simulated jump to '. aProcessorSimulationTrap address. '/'. function. ')'}]. savedFramePointer := coInterpreter framePointer. savedStackPointer := coInterpreter stackPointer. savedArgumentCount := coInterpreter argumentCount. result := ["self halt: evaluable selector." ((printRegisters or: [printInstructions]) and: [clickConfirm]) ifTrue: [(self confirm: 'skip run-time call?') ifFalse: [clickConfirm := false. self halt]]. evaluable valueWithArguments: (processor postCallArgumentsNumArgs: evaluable numArgs + in: memory)] - in: coInterpreter memory)] on: ReenterMachineCode do: [:ex| ex return: ex returnValue]. coInterpreter assertValidExternalStackPointers. "Verify the stack layout assumption compileInterpreterPrimitive: makes, provided we've not called something that has built a frame, such as closure value or evaluate method, or switched frames, such as primitiveSignal, primitiveWait, primitiveResume, primitiveSuspend et al." (function beginsWith: 'primitive') ifTrue: [coInterpreter checkForLastObjectOverwrite. coInterpreter primFailCode = 0 ifTrue: [(#( primitiveClosureValue primitiveClosureValueWithArgs primitiveClosureValueNoContextSwitch primitiveFullClosureValue primitiveFullClosureValueWithArgs primitiveFullClosureValueNoContextSwitch primitiveSignal primitiveWait primitiveResume primitiveSuspend primitiveYield primitiveExecuteMethodArgsArray primitiveExecuteMethod primitivePerform primitivePerformWithArgs primitivePerformInSuperclass primitiveTerminateTo primitiveStoreStackp primitiveDoPrimitiveWithArgs) includes: function) ifFalse: ["This is a rare case (e.g. in Scorch where a married context's sender is set to nil on trapTrpped and hence the stack layout is altered." (function == #primitiveSlotAtPut and: [objectMemory isContext: (coInterpreter frameReceiver: coInterpreter framePointer)]) ifFalse: [self assert: savedFramePointer = coInterpreter framePointer. self assert: savedStackPointer + (savedArgumentCount * objectMemory wordSize) = coInterpreter stackPointer]]] ifFalse: [self assert: savedFramePointer = coInterpreter framePointer. self assert: savedStackPointer = coInterpreter stackPointer]]. result ~~ #continueNoReturn ifTrue: + [self recordInstruction: {'(simulated return to '. processor retpcIn: memory. ')'}. + rpc := processor retpcIn: memory. - [self recordInstruction: {'(simulated return to '. processor retpcIn: coInterpreter memory. ')'}. - rpc := processor retpcIn: coInterpreter memory. self assert: (rpc >= codeBase and: [rpc < methodZone freeStart]). processor + smashCallerSavedRegistersWithValuesFrom: 16r80000000 by: objectMemory wordSize in: memory; + simulateReturnIn: memory]. - smashCallerSavedRegistersWithValuesFrom: 16r80000000 by: objectMemory wordSize; - simulateReturnIn: coInterpreter memory]. self assert: (result isInteger "an oop result" or: [result == coInterpreter or: [result == objectMemory or: [#(nil continue continueNoReturn) includes: result]]]). processor cResultRegister: (result ifNil: [0] ifNotNil: [result isInteger ifTrue: [result] ifFalse: [16rF00BA222]]) "coInterpreter cr. processor sp + 32 to: processor sp - 32 by: -4 do: [:sp| sp = processor sp ifTrue: [coInterpreter print: 'sp->'; tab] ifFalse: [coInterpreter printHex: sp]. coInterpreter tab; printHex: (coInterpreter longAt: sp); cr]"! Item was changed: ----- Method: Float class>>fromIEEE64BitWord: (in category '*VMMaker-instance creation') ----- fromIEEE64BitWord: anInteger + | value | + value := self basicNew: 2. + value - ^(self basicNew: 2) basicAt: 1 put: (anInteger bitShift: -32); + basicAt: 2 put: (anInteger bitAnd: 16rFFFFFFFF). + ^value isFinite + ifTrue: [value * 1.0] "reduce to SmallFloat64 if possible" + ifFalse: [value] + + "[| r | + r := Random new. + 100000 timesRepeat: + [| h l f | + h := (r next * 16r100000000) rounded bitAnd: 16rFFFFFFFF. + l := (r next * 16r100000000) rounded bitAnd: 16rFFFFFFFF. + f := Float fromIEEE64BitWord: (h bitShift: 32) + l. + self assert: h = (f basicAt: 1). + self assert: l = (f basicAt: 2)]] timeToRun"! - basicAt: 2 put: (anInteger bitAnd: 16rFFFFFFFF); - yourself!

1 0

[OpenSmalltalk/opensmalltalk-vm] 4d3f02: CogVM source as per VMMaker.oscog-eem.2222
by GitHub 27 May '17

27 May '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 4d3f02655d68964e1fe4ed2b533658fe38168936 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/4d3f02655d68964e1f… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-05-26 (Fri, 26 May 2017) Changed paths: M build.win64x64/common/Makefile.plugin M build.win64x64/common/Makefile.tools M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64SysV.c M nsspur64src/vm/cogitX64WIN64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M platforms/unix/vm/aio.c M platforms/win32/vm/sqConfig.h M platforms/win32/vm/sqWin32DnsInfo.c M spur64src/vm/cogit.h M spur64src/vm/cogitX64SysV.c M spur64src/vm/cogitX64WIN64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cogitX64SysV.c M spurlowcode64src/vm/cogitX64WIN64.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cogitARMv5.c M spurlowcodesrc/vm/cogitIA32.c M spurlowcodesrc/vm/cogitMIPSEL.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitX64SysV.c M spursista64src/vm/cogitX64WIN64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2222 StackInterpreter: Add time primitives to answer the UTC and local microsecond clocks as updated by the heartbeat (as the Cog VM was originally before David changed the primitives to access the time now). This access is much faster (of the order of 20 nsecs per invocartion vs 450 nsecs per invocatuon on a 2.3 GHz Mac Mini). Terf demands very fast clock times but is not concerned with fine granularity. The primitive numbers are 245 for UTC and 246 for local. primitiveMakePoint should fail if its /argument/ is not a SmallInteger or Float. Since the primitive is on Number we know the receiver is valid, and there is no point checking it. Fix warnings for addIdleUsecs: on WIN32/64 (must not be marked exporrt to avoid declspec being added). Fix display pixel reversal (for debug). Modern implementation of displayBits is (void *). We can't calculate an offset (dispalyBits + n) because we don't know the size of void! At least it fails on MSVC compiler. So it's necessary to convert it to char *, int *, or just sqInt. While at it, as calculated, the range is a pixel range (assumed on the first display line) not a word range, but this range will be rounded to a whole word boundary. Cogit: Modified with Sophie K the collectCogConstituents primitive to take a boolean parameter "withDetails". If false or no parameter, the primitive does the same thing as before. If true, the primitive maps each CogMethod that is frameful to an array starting with the cogMethod address followed by a mapping between the mcpc and the bcpc instead of just the cogMethod address. Fix the method for getting the stack pointer in Win64 ABI. The generated ceCaptureCStackPointers must account for the 32 bytes reserved for saving the 4 register parameters which are allocated whatever the real number of parameters. Minor fix in register in branchIfInstanceOf: in SistaCogit for Characters. Plugins: Fix slips in the SoundPlugin code. Win64 build. Do not define WIN32. Fix the win32 sqConfig.h file to work around the clang preprocessor's failure to default undefined identifiers to 0L.

1 0

[OpenSmalltalk/opensmalltalk-vm] 009ff8: Fix missing ;
by GitHub 27 May '17

27 May '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 009ff81ab09e08c134be3c8706639c4857fdb656 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/009ff81ab09e08c134… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-05-27 (Sat, 27 May 2017) Changed paths: M platforms/unix/plugins/FilePlugin/sqUnixFile.c Log Message: ----------- Fix missing ;

1 0

[OpenSmalltalk/opensmalltalk-vm] 27a9c7: Fix potential buffer overrun in UNIX file plugin
by GitHub 26 May '17

26 May '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 27a9c75c56e0cb9547721eb39f33cd754f92ccbd https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/27a9c75c56e0cb9547… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-05-26 (Fri, 26 May 2017) Changed paths: M platforms/unix/plugins/FilePlugin/sqUnixFile.c Log Message: ----------- Fix potential buffer overrun in UNIX file plugin Note: this is a minimal fix for the bug reported by Monty http://forum.world.st/Please-review-and-merge-A-commit-to-fix-race-conditio… The patch provided by Monty was much more aggressive - see PR #82 https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/82 Nobody had enough energy to review all implications, thus the minimalist replacement.

1 0

← Newer
1
2
3
4
5
6
7
...
16
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev May 2017