Vm-dev March 2017

vm-dev@lists.squeakfoundation.org

39 participants
154 discussions

Re: [Vm-dev] git and branch JMM/SleepTime
by Jakob Reschke 22 Mar '17

22 Mar '17

2017-03-22 22:10 GMT+01:00 Stefan Marr <smalltalk(a)stefan-marr.de>: > > `git log` should then also be a better way to check whether you’re on the branch you expect. > Also note the --decorate flag of git log, which adds labels for branches and tags, like graphical tools such as gitk or SourceTree do. For that matter, there is also --graph. 2017-03-22 21:47 GMT+01:00 Eliot Miranda <eliot.miranda(a)gmail.com>: > McStalker.oscogvm.clean$ git pull -a I think -a might not do what you want, either. For pull, it is short for --append and related to the FETCH_HEAD file. If you just want to download branches and not merge anything into your current branch, you should use git fetch instead of pull (pull = fetch&&merge). In case you thought that -a means "--all": git pull --all does fetch from all remote repositories, but would still attempt to merge the upstream of your current branch. Kind regards, Jakob

1 0

[OpenSmalltalk/opensmalltalk-vm] de1683: Revert "unix config fix: there should be no space ...
by GitHub 22 Mar '17

22 Mar '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: de168361884e7eab6714e8559048396faba5f2f4 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/de168361884e7eab67… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M platforms/unix/plugins/XDisplayControlPlugin/Makefile.inc Log Message: ----------- Revert "unix config fix: there should be no space after -L option" This reverts commit 720c75b3ef79d89630b17737fc9bb384b4f9b7f9. Commit: ce673d0a6a7c3ae15f1eebeba4063fa4768b3b08 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/ce673d0a6a7c3ae15f… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M platforms/unix/plugins/XDisplayControlPlugin/Makefile.inc M platforms/unix/vm/sqUnixHeartbeat.c Log Message: ----------- Revert "Linux (& unix/Mac OS X):" This reverts commit 54bab0a7a2901d70719715625150a95ef2ab7784. Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/720c75b3ef79...ce…

1 0

[OpenSmalltalk/opensmalltalk-vm] 720c75: unix config fix: there should be no space after -L...
by GitHub 22 Mar '17

22 Mar '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 720c75b3ef79d89630b17737fc9bb384b4f9b7f9 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/720c75b3ef79d89630… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M platforms/unix/plugins/XDisplayControlPlugin/Makefile.inc Log Message: ----------- unix config fix: there should be no space after -L option

1 0

VM Maker: BytecodeSets.spur-cb.72.mcz
by commits＠source.squeak.org 22 Mar '17

22 Mar '17

ClementBera uploaded a new version of BytecodeSets to project VM Maker: http://source.squeak.org/VMMaker/BytecodeSets.spur-cb.72.mcz ==================== Summary ==================== Name: BytecodeSets.spur-cb.72 Author: cb Time: 22 March 2017, 10:13:34.02929 am UUID: c0b2213b-a4e1-4905-8f23-18072ee3fbfb Ancestors: BytecodeSets.spur-cb.71 Added documentation for new unsafe operations =============== Diff against BytecodeSets.spur-cb.71 =============== Item was changed: BytecodeEncoder subclass: #EncoderForSistaV1 (excessive size, no diff calculated)

1 0

VM Maker: BytecodeSets.spur-cb.71.mcz
by commits＠source.squeak.org 22 Mar '17

22 Mar '17

ClementBera uploaded a new version of BytecodeSets to project VM Maker: http://source.squeak.org/VMMaker/BytecodeSets.spur-cb.71.mcz ==================== Summary ==================== Name: BytecodeSets.spur-cb.71 Author: cb Time: 22 March 2017, 9:36:28.391599 am UUID: 72679479-f487-4016-9b43-62e88a088f9e Ancestors: BytecodeSets.spur-eem.70 Added sizing selector for branchIfInstanceOf and trap =============== Diff against BytecodeSets.spur-eem.70 =============== Item was added: + ----- Method: EncoderForSistaV1>>sizeBranchIfInstanceOf:distance:orNot: (in category 'special literal encodings') ----- + sizeBranchIfInstanceOf: literalIndex distance: distance orNot: boolean + ^self sizeOpcodeSelector: #genBranchIfInstanceOf:distance:orNot: withArguments: {literalIndex.distance.boolean}! Item was added: + ----- Method: EncoderForSistaV1>>sizeTrap (in category 'special literal encodings') ----- + sizeTrap + ^self sizeOpcodeSelector: #genTrap withArguments: #()!

1 0

Re: [Vm-dev] [Pharo-dev] More Windows VM Crashing -_-
by Eliot Miranda 22 Mar '17

22 Mar '17

Hi Peter, > On Mar 22, 2017, at 2:31 AM, Peter Uhnak <i.uhnak(a)gmail.com> wrote: > > Hi, > > Originally I thought my VM is crashing because of FT, so I applied some fix from FogBugz (that is now part of Pharo 6), but that didn't help. > > So I disabled FT in settings and changed fonts to non-FT ones; didn't help. > So I completely removed FT2Plugin.dll (now settings just states that FT fonts are not available), but that didn't help either. > > And obviously there is no crash.dmp whatsoever (this is latest Windows VM). > > This crash is extremely frustrating because the crash happens _during saving_, which means I am losing code all the time and have to constantly recover them, which really makes my blood boil. > > Without crash dump I don't even know where and how to start investigating. Windows kindly opens Visual Studio when Pharo crashes, but all it shows to me is assembly, which is not very useful to me. I can somewhat orient myself in the C code of the VM (as I've alredy fixed some other issues in the VM), but here I am lost. > > <SNIP> > 00407D7F ret > 00407D80 mov eax,dword ptr ds:[00596E44h] > 00407D85 test al,3 > 00407D87 jne 00407DB2 > 00407D89 mov ecx,dword ptr ds:[596E08h] > 00407D8F lea edx,[ecx-1] > 00407D92 cmp eax,edx > 00407D94 jb 00407DB2 > 00407D96 cmp dword ptr ds:[596E10h],eax > 00407D9C jb 00407DB2 > 00407D9E mov ecx,dword ptr ds:[5B89D0h] > 00407DA4 cmp dword ptr [eax-4],ecx > 00407DA7 jb 00407DB2 > 00407DA9 mov eax,dword ptr ds:[00596E28h] > ---> 00407DAE movzx eax,byte ptr [eax] > 00407DB1 ret > > eax = 00000000 > ecx = 04700000 > </SNIP> Can you post a link to the exact VM you're using? I may be able to make sense of this. First, I'm very sorry you're experiencing these crashes. They're likely a bug in the new compactor. It makes multiple compaction passes when there are lots of objects, only on snapshot. In a normal GC it only ever makes one pass. Therefore, one thing that may allow you to work around the bug is to modify the snapshot:andQuit: method to explicitly do a Smalltalk garbageCollect before invoking the snapshot primitive. If the bug is only on subsequent passes then the explicit GC should not crash and will make it much less likely that the GC done as part of the snapshot will require a second pass, and hence less likely to crash. > So my question I guess is: > How can we fix this? How can I help fix this? Because I've lost countless days of time and energy on this f***ing problem... Helping me match the code above with the VM will be really helpful. I want to know the values in registers, and the value of nilObj too. > Peter _,,,^..^,,,_ (phone)

1 0

Re: [Vm-dev] [Pharo-dev] [ANN] PharoNOS
by Eliot Miranda 22 Mar '17

22 Mar '17

Hi Jan, On Sun, Mar 19, 2017 at 1:46 PM, jan.struz <public+pharo(a)struz.cz> wrote: > Hi Stef, > what I want, is NativeBoost for Pharo 5+. Because we could do this: > > primInPortByte: portNumber > <primitive: 'primitiveNativeCall' module: 'NativeBoostPlugin' error: errorCode> > > ^ self nbCallout function: #(uint8 ( uint16 portNumber )) emit: [:gen | > | asm result proxy | > asm := gen asm. > proxy := gen proxy. > result := gen reserveTemp. > asm > pop: asm EDX; "EDX = portNumber" > push: asm EDI; "save EDI" > mov: result to: asm EDI; "EDI = temp address for result" > db: 16rEC; "IN AL, DX" > pop: asm EDI. "restore EDI" > gen releaseTemps: 1. > ]. > > > This is a rewrite of one method from C source(calling asm) in internal > SqueakNOSPlugin into NativeBoost Smalltalk code. It calls privileged > (kernel mode only) instruction to directly access HW I/O - disk access. > I have tried to run it, and it worked fine. However there is one little > problem. NativeBoost needs method source, which is stored where? On the > disk it wants to access... Solution - the source code can be embedded into > compiled method trailer - this is only way to make it work. The first run > will generate native code, and replaces the embedded source, so you can't > touch the method anymore (at runtime)... so it is not perfect. > This is how SqueakNOSPlugin can be removed entirelly. But I'm afraid > nobody can play with it in Pharo7 images... > Can you not use the new UnifiedFFI which uses the ThreadedFFIPlugin at the bottom level? > Save The World! > > ------------------------------ > View this message in context: Re: [ANN] PharoNOS > <http://forum.world.st/ANN-PharoNOS-tp4939247p4939313.html> > > Sent from the Pharo Smalltalk Developers mailing list archive > <http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html> at > Nabble.com. > -- _,,,^..^,,,_ best, Eliot

6 9

[OpenSmalltalk/opensmalltalk-vm] f829fb: Add logic to test the ability to get the sleep/wak...
by GitHub 22 Mar '17

22 Mar '17

Branch: refs/heads/JMM/SleepTime Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: f829fb66db403a05fe0360b17a81ea5095504fbd https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f829fb66db403a05fe… Author: johnmci <johnmci(a)smalltalkconsulting.com> Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M platforms/iOS/vm/OSX/SqueakOSXAppDelegate.m Log Message: ----------- Add logic to test the ability to get the sleep/wake time notifications so we can adjust idle time for the VM

1 0

[OpenSmalltalk/opensmalltalk-vm] 3bfd04: CogVM source as per VMMaker.oscog-eem.2175
by GitHub 21 Mar '17

21 Mar '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 3bfd04a18ba299b00089c5e8455752f4f65d76e5 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3bfd04a18ba299b000… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M scripts/gitrevert M spur64src/vm/cogit.h M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/vm/cogit.h M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2175 CoInterpreter: If a context's method is assigned to, any machine code pcs must be mapped to bytecode ones *before* the method is changed because otherwise subsequent reads of the context's pc will attempt to map using the wrong method, causing a crash.

1 0

VM Maker: VMMaker.oscog-eem.2175.mcz
by commits＠source.squeak.org 21 Mar '17

21 Mar '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2175.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2175 Author: eem Time: 21 March 2017, 3:08:53.878597 pm UUID: eb79e804-a80b-4ad3-bd19-9c60a24a14f1 Ancestors: VMMaker.oscog-eem.2174 CoInterpreter: If a context's method is assigned to, any machine code pcs must be mapped to bytecode ones *before* the method is changed because otherwise subsequent reads of the context's pc will attempt to map using the wrong method, causing a crash. In-image compilation: Insulate the CurrentImageCoInterpreterFacade from the recent changes to specialSelectors which filters out the argument counts. =============== Diff against VMMaker.oscog-eem.2174 =============== Item was added: + ----- Method: CoInterpreter>>is:methodAssignmentToContextWithMachineCodePC: (in category 'internal interpreter access') ----- + is: fieldIndex methodAssignmentToContextWithMachineCodePC: anOop + "If the method is assigned, any machine code pc must be mapped to a bytecode one + before the method is changed." + <inline: true> + | thePC | + ^fieldIndex = MethodIndex + and: [(thePC := objectMemory fetchPointer: InstructionPointerIndex ofObject: anOop) signedIntFromLong < 0 + and: [objectMemory isIntegerObject: thePC]]! Item was changed: ----- Method: CurrentImageCoInterpreterFacade>>specialSelector: (in category 'accessing') ----- specialSelector: index + ^self oopForObject: (self specialSelectors at: index * 2 + 1)! - ^self oopForObject: (Smalltalk specialSelectors at: index * 2 + 1)! Item was changed: ----- Method: CurrentImageCoInterpreterFacade>>specialSelectorNumArgs: (in category 'accessing') ----- specialSelectorNumArgs: index + ^self specialSelectors at: index * 2 + 2! - ^Smalltalk specialSelectors at: index * 2 + 2! Item was added: + ----- Method: CurrentImageCoInterpreterFacade>>specialSelectors (in category 'private') ----- + specialSelectors + ^Smalltalk specialObjectsArray at: 24! Item was changed: ----- Method: StackInterpreter>>externalInstVar:ofContext:put: (in category 'frame access') ----- externalInstVar: index ofContext: maybeMarriedContext put: anOop | theFP thePage onCurrentPage | <var: #theFP type: #'char *'> <var: #thePage type: #'StackPage *'> self assert: (objectMemory isContext: maybeMarriedContext). self externalWriteBackHeadFramePointers. "Assign the field of a married context." self deny: (objectMemory isObjImmutable: maybeMarriedContext). (self isStillMarriedContext: maybeMarriedContext) ifFalse: [objectMemory storePointer: index ofObject: maybeMarriedContext withValue: anOop. index = StackPointerIndex ifTrue: [self ensureContextIsExecutionSafeAfterAssignToStackPointer: maybeMarriedContext]. ^nil]. theFP := self frameOfMarriedContext: maybeMarriedContext. thePage := stackPages stackPageFor: theFP. self assert: stackPage = stackPages mostRecentlyUsedPage. onCurrentPage := thePage = stackPage. + index = SenderIndex - index == SenderIndex ifTrue: [self storeSenderOfFrame: theFP withValue: anOop] ifFalse: [self externalDivorceFrame: theFP andContext: maybeMarriedContext. + (self is: index methodAssignmentToContextWithMachineCodePC: maybeMarriedContext) ifTrue: + [self ensureContextHasBytecodePC: maybeMarriedContext]. objectMemory storePointer: index ofObject: maybeMarriedContext withValue: anOop. index = StackPointerIndex ifTrue: [self ensureContextIsExecutionSafeAfterAssignToStackPointer: maybeMarriedContext]]. onCurrentPage ifTrue: [self setStackPointersFromPage: stackPage] ifFalse: [stackPages markStackPageMostRecentlyUsed: stackPage]. stackPages assert: stackPage = stackPages mostRecentlyUsedPage. stackPages assert: stackPages pageListIsWellFormed. stackPages assert: self validStackPageBaseFrames! Item was changed: ----- Method: StackInterpreter>>instVar:ofContext:put: (in category 'frame access') ----- instVar: index ofContext: aMarriedContext put: anOop | theFP | "Assign the field of a married context. The important case to optimize is assigning the sender. We could also consider optimizing assigning the IP but typically that is followed by an assignment to the stack pointer and we can't efficiently assign the stack pointer because it involves moving frames around." <inline: true> self assert: (self isMarriedOrWidowedContext: aMarriedContext). self deny: (objectMemory isObjImmutable: aMarriedContext). self writeBackHeadFramePointers. (self isStillMarriedContext: aMarriedContext) ifFalse: [objectMemory storePointer: index ofObject: aMarriedContext withValue: anOop. index = StackPointerIndex ifTrue: [self ensureContextIsExecutionSafeAfterAssignToStackPointer: aMarriedContext]. ^nil]. theFP := self frameOfMarriedContext: aMarriedContext. + index = SenderIndex ifTrue: - index == SenderIndex ifTrue: [| thePage onCurrentPage | thePage := stackPages stackPageFor: theFP. self assert: stackPage = stackPages mostRecentlyUsedPage. onCurrentPage := thePage = stackPage. self storeSenderOfFrame: theFP withValue: anOop. onCurrentPage ifTrue: [localFP := stackPage headFP. localSP := stackPage headSP] ifFalse: [stackPages markStackPageMostRecentlyUsed: stackPage]. ^nil]. self externalizeIPandSP. self externalDivorceFrame: theFP andContext: aMarriedContext. + (self is: index methodAssignmentToContextWithMachineCodePC: aMarriedContext) ifTrue: + [self ensureContextHasBytecodePC: aMarriedContext]. objectMemory storePointer: index ofObject: aMarriedContext withValue: anOop. index = StackPointerIndex ifTrue: [self ensureContextIsExecutionSafeAfterAssignToStackPointer: aMarriedContext]. self internalizeIPandSP. "Assigning various fields can force a divorce which can change the stackPage." stackPages markStackPageMostRecentlyUsed: stackPage. self assertValidExecutionPointe: localIP asUnsignedInteger r: localFP s: localSP imbar: true line: #'__LINE__'! Item was added: + ----- Method: StackInterpreter>>is:methodAssignmentToContextWithMachineCodePC: (in category 'internal interpreter access') ----- + is: fieldIndex methodAssignmentToContextWithMachineCodePC: anOop + "This is a hook for the CoInterpreter. It is a noop in the StackInterpreter." + <inline: true> + ^false! Item was changed: ----- Method: StackInterpreter>>storeMaybeContext:receiverVariable:withValue: (in category 'stack bytecodes') ----- storeMaybeContext: obj receiverVariable: fieldIndex withValue: anOop "Must trap accesses to married and widowed contexts. But don't want to check on all inst var accesses. This method is only used by the long-form bytecodes, evading the cost." <inline: true> ((self isWriteMediatedContextInstVarIndex: fieldIndex) and: [(objectMemory isContextNonImm: obj) + and: [(self isMarriedOrWidowedContext: obj) + or: [self is: fieldIndex methodAssignmentToContextWithMachineCodePC: anOop]]]) - and: [self isMarriedOrWidowedContext: obj]]) ifTrue: [self instVar: fieldIndex ofContext: obj put: anOop] ifFalse: [objectMemory storePointerImmutabilityCheck: fieldIndex ofObject: obj withValue: anOop]!

1 0

← Newer
1
2
3
4
5
6
7
8
...
16
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev March 2017