Vm-dev January 2017

vm-dev@lists.squeakfoundation.org

30 participants
136 discussions

[OpenSmalltalk/opensmalltalk-vm] 62e611: Update linux x86 & x64 HowToBuild in the light of ...
by GitHub 19 Jan '17

19 Jan '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 62e6114a900842c88b2b083a4ba293d7e37b839f https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/62e6114a900842c88b… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-01-19 (Thu, 19 Jan 2017) Changed paths: M build.linux32x86/HowToBuild M build.linux64x64/HowToBuild Log Message: ----------- Update linux x86 & x64 HowToBuild in the light of successfuly building a 32-bit VM on 64-bit CentOS 6.5.

1 0

VM Maker: BytecodeSets.spur-eem.69.mcz
by commits＠source.squeak.org 19 Jan '17

19 Jan '17

Eliot Miranda uploaded a new version of BytecodeSets to project VM Maker: http://source.squeak.org/VMMaker/BytecodeSets.spur-eem.69.mcz ==================== Summary ==================== Name: BytecodeSets.spur-eem.69 Author: eem Time: 19 January 2017, 10:54:11.143861 am UUID: fafd1edb-03a6-444a-a8e1-82079af95fc2 Ancestors: BytecodeSets.spur-eem.68 Decode, but do not define, callLowcodeInlinePrimitive:extA:extB:. Add description of branch If Instance Of alongside branch If Not Instance Of. =============== Diff against BytecodeSets.spur-eem.68 =============== Item was changed: BytecodeEncoder subclass: #EncoderForSistaV1 (excessive size, no diff calculated) Item was changed: ----- Method: InstructionStream>>interpretNext3ByteSistaV1Instruction:for:extA:extB:startPC: (in category '*BytecodeSets-SistaV1-decoding') ----- interpretNext3ByteSistaV1Instruction: bytecode for: client extA: extA extB: extB startPC: startPC "Send to the argument, client, a message that specifies the next instruction. This method handles the three-byte codes. For a table of the bytecode set, see EncoderForSistaV1's class comment." | method byte2 byte3 literal | method := self method. byte2 := method at: pc. byte3 := method at: pc + 1. pc := pc + 2. + + "** 248 (2) 11111000 iiiiiiii mssjjjjj Call Primitive #iiiiiiii + (jjjjj * 256) + m=1 means inlined primitive, no hard return after execution. + ss defines the unsafe operation set used to encode the operations. + (ss = 0 means sista unsafe operations, ss = 01 means lowcode operations, other numbers are not used) + Lowcode inlined primitives may have extensions." - "we search the bytecodes by what we expect to be the static frequency." bytecode = 248 ifTrue: + [| primitiveSetSelector primitiveNumber | + byte3 < 128 ifTrue: + [ "Maybe this should be restricted to the 13 bit primitiveNumber too..." + ^client callPrimitive: byte2 + (byte3 bitShift: 8)]. + primitiveSetSelector := (byte3 bitShift: -5) bitAnd: 3. + primitiveNumber := byte2 + ((byte3 bitAnd: 31) bitShift: 8). + primitiveSetSelector = 0 ifTrue: "Sista inline primitives" - [byte3 >= 128 ifTrue: [^client callInlinePrimitive: byte2 + (byte3 - 128 bitShift: 8)]. + primitiveSetSelector = 1 ifTrue: "Lowcode inline primitives" + [^client callLowcodeInlinePrimitive: byte2 + (byte3 - 128 bitShift: 8) extA: extA extB: extB]. + "fall through to ^self unusedBytecode: client at: startPC below"]. + - ^client callPrimitive: byte2 + (byte3 bitShift: 8)]. "* 249 11111001 xxxxxxxx siyyyyyy push Closure Compiled block literal index xxxxxxxx (+ Extend A * 256) numCopied yyyyyy receiverOnStack: s = 1 ignoreOuterContext: i = 1" bytecode = 249 ifTrue: [literal := method literalAt: (extA bitShift: 8) + byte2 + 1. ^client pushFullClosure: literal numCopied: (byte3 bitAnd: 16r3F)]. bytecode = 250 ifTrue: ["** 250 11111010 eeiiikkk jjjjjjjj Push Closure Num Copied iii (+ExtA//16*8) Num Args kkk (+ ExtA\\16*8) BlockSize jjjjjjjj (+ExtB*256). ee = num extensions" ^client pushClosureCopyNumCopiedValues: ((byte2 bitShift: -3) bitAnd: 7) + (extA // 16 bitShift: 3) numArgs: (byte2 bitAnd: 7) + (extA \\ 16 bitShift: 3) blockSize: byte3 + (extB bitShift: 8)]. bytecode = 251 ifTrue: [^client pushRemoteTemp: byte2 inVectorAt: byte3]. bytecode = 252 ifTrue: [^client storeIntoRemoteTemp: byte2 inVectorAt: byte3]. bytecode = 253 ifTrue: [^client popIntoRemoteTemp: byte2 inVectorAt: byte3]. "** 254 11111110 kkkkkkkk jjjjjjjj branch If Not Instance Of Behavior/Array Of Behavior kkkkkkkk (+ Extend A * 256, where Extend A >= 0) distance jjjjjjjj (+ Extend B * 256, where Extend B >= 0)" bytecode = 254 ifTrue: "The sign bit of extB inverts the operation. Would like to have extB < -128, but this is good enough for now." [extB < 0 ifTrue: [^client branchIfInstanceOf: literal distance: (extB + 128 bitShift: 8) + byte3]. ^client branchIfNotInstanceOf: literal distance: (extB bitShift: 8) + byte3]. ^self unusedBytecode: client at: startPC!

1 0

VM Maker: BytecodeSets.spur-eem.68.mcz
by commits＠source.squeak.org 19 Jan '17

19 Jan '17

Eliot Miranda uploaded a new version of BytecodeSets to project VM Maker: http://source.squeak.org/VMMaker/BytecodeSets.spur-eem.68.mcz ==================== Summary ==================== Name: BytecodeSets.spur-eem.68 Author: eem Time: 19 January 2017, 10:27:52.847893 am UUID: 9e0cc882-b0bb-468f-b9a6-325c805d5897 Ancestors: BytecodeSets.spur-cb.66 Fix a slip in branchIfNotInstanceOf:distance: decoding. (Ignore the fix in BytecodeSets.spur-eem.67; it is wrong) =============== Diff against BytecodeSets.spur-cb.66 =============== Item was changed: ----- Method: InstructionStream>>interpretNext3ByteSistaV1Instruction:for:extA:extB:startPC: (in category '*BytecodeSets-SistaV1-decoding') ----- interpretNext3ByteSistaV1Instruction: bytecode for: client extA: extA extB: extB startPC: startPC "Send to the argument, client, a message that specifies the next instruction. This method handles the three-byte codes. For a table of the bytecode set, see EncoderForSistaV1's class comment." | method byte2 byte3 literal | method := self method. byte2 := method at: pc. byte3 := method at: pc + 1. pc := pc + 2. "we search the bytecodes by what we expect to be the static frequency." bytecode = 248 ifTrue: [byte3 >= 128 ifTrue: [^client callInlinePrimitive: byte2 + (byte3 - 128 bitShift: 8)]. ^client callPrimitive: byte2 + (byte3 bitShift: 8)]. "* 249 11111001 xxxxxxxx siyyyyyy push Closure Compiled block literal index xxxxxxxx (+ Extend A * 256) numCopied yyyyyy receiverOnStack: s = 1 ignoreOuterContext: i = 1" bytecode = 249 ifTrue: [literal := method literalAt: (extA bitShift: 8) + byte2 + 1. ^client pushFullClosure: literal numCopied: (byte3 bitAnd: 16r3F)]. bytecode = 250 ifTrue: ["** 250 11111010 eeiiikkk jjjjjjjj Push Closure Num Copied iii (+ExtA//16*8) Num Args kkk (+ ExtA\\16*8) BlockSize jjjjjjjj (+ExtB*256). ee = num extensions" ^client pushClosureCopyNumCopiedValues: ((byte2 bitShift: -3) bitAnd: 7) + (extA // 16 bitShift: 3) numArgs: (byte2 bitAnd: 7) + (extA \\ 16 bitShift: 3) blockSize: byte3 + (extB bitShift: 8)]. bytecode = 251 ifTrue: [^client pushRemoteTemp: byte2 inVectorAt: byte3]. bytecode = 252 ifTrue: [^client storeIntoRemoteTemp: byte2 inVectorAt: byte3]. bytecode = 253 ifTrue: [^client popIntoRemoteTemp: byte2 inVectorAt: byte3]. "** 254 11111110 kkkkkkkk jjjjjjjj branch If Not Instance Of Behavior/Array Of Behavior kkkkkkkk (+ Extend A * 256, where Extend A >= 0) distance jjjjjjjj (+ Extend B * 256, where Extend B >= 0)" + bytecode = 254 ifTrue: "The sign bit of extB inverts the operation. Would like to have extB < -128, but this is good enough for now." + [extB < 0 ifTrue: [^client branchIfInstanceOf: literal distance: (extB + 128 bitShift: 8) + byte3]. + ^client branchIfNotInstanceOf: literal distance: (extB bitShift: 8) + byte3]. - bytecode = 254 ifTrue: - [extB < 0 ifTrue: [client branchIfInstanceOf: literal distance: (extB + 128 bitShift: 8) + byte3]. - ^ client branchIfNotInstanceOf: literal distance: (extB bitShift: 8) + byte3 ]. ^self unusedBytecode: client at: startPC!

1 0

VM Maker: BytecodeSets.spur-eem.67.mcz
by commits＠source.squeak.org 19 Jan '17

19 Jan '17

Eliot Miranda uploaded a new version of BytecodeSets to project VM Maker: http://source.squeak.org/VMMaker/BytecodeSets.spur-eem.67.mcz ==================== Summary ==================== Name: BytecodeSets.spur-eem.67 Author: eem Time: 19 January 2017, 10:03:27.4281 am UUID: fbd8dc41-db8d-4d49-9af8-5a61426e4fb1 Ancestors: BytecodeSets.spur-cb.66 Fix a slip in branchIfNotInstanceOf:distance: decoding. =============== Diff against BytecodeSets.spur-cb.66 =============== Item was changed: ----- Method: InstructionStream>>interpretNext3ByteSistaV1Instruction:for:extA:extB:startPC: (in category '*BytecodeSets-SistaV1-decoding') ----- interpretNext3ByteSistaV1Instruction: bytecode for: client extA: extA extB: extB startPC: startPC "Send to the argument, client, a message that specifies the next instruction. This method handles the three-byte codes. For a table of the bytecode set, see EncoderForSistaV1's class comment." | method byte2 byte3 literal | method := self method. byte2 := method at: pc. byte3 := method at: pc + 1. pc := pc + 2. "we search the bytecodes by what we expect to be the static frequency." bytecode = 248 ifTrue: [byte3 >= 128 ifTrue: [^client callInlinePrimitive: byte2 + (byte3 - 128 bitShift: 8)]. ^client callPrimitive: byte2 + (byte3 bitShift: 8)]. "* 249 11111001 xxxxxxxx siyyyyyy push Closure Compiled block literal index xxxxxxxx (+ Extend A * 256) numCopied yyyyyy receiverOnStack: s = 1 ignoreOuterContext: i = 1" bytecode = 249 ifTrue: [literal := method literalAt: (extA bitShift: 8) + byte2 + 1. ^client pushFullClosure: literal numCopied: (byte3 bitAnd: 16r3F)]. bytecode = 250 ifTrue: ["** 250 11111010 eeiiikkk jjjjjjjj Push Closure Num Copied iii (+ExtA//16*8) Num Args kkk (+ ExtA\\16*8) BlockSize jjjjjjjj (+ExtB*256). ee = num extensions" ^client pushClosureCopyNumCopiedValues: ((byte2 bitShift: -3) bitAnd: 7) + (extA // 16 bitShift: 3) numArgs: (byte2 bitAnd: 7) + (extA \\ 16 bitShift: 3) blockSize: byte3 + (extB bitShift: 8)]. bytecode = 251 ifTrue: [^client pushRemoteTemp: byte2 inVectorAt: byte3]. bytecode = 252 ifTrue: [^client storeIntoRemoteTemp: byte2 inVectorAt: byte3]. bytecode = 253 ifTrue: [^client popIntoRemoteTemp: byte2 inVectorAt: byte3]. "** 254 11111110 kkkkkkkk jjjjjjjj branch If Not Instance Of Behavior/Array Of Behavior kkkkkkkk (+ Extend A * 256, where Extend A >= 0) distance jjjjjjjj (+ Extend B * 256, where Extend B >= 0)" bytecode = 254 ifTrue: + [^client branchIfNotInstanceOf: literal distance: ((extB < 0 ifTrue: [extB + 128] ifFalse: [extB]) bitShift: 8) + byte3]. - [extB < 0 ifTrue: [client branchIfInstanceOf: literal distance: (extB + 128 bitShift: 8) + byte3]. - ^ client branchIfNotInstanceOf: literal distance: (extB bitShift: 8) + byte3 ]. ^self unusedBytecode: client at: startPC!

1 0

VM Maker: VMMaker.oscogSPC-cb.2105.mcz
by commits＠source.squeak.org 19 Jan '17

19 Jan '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscogSPC-cb.2105.mcz ==================== Summary ==================== Name: VMMaker.oscogSPC-cb.2105 Author: eem Time: 19 January 2017, 8:59:20.328004 am UUID: 1917b0eb-51a0-442f-abae-5c3b09d7b82d Ancestors: VMMaker.oscogSPC-eem.2102, VMMaker.oscog-cb.2105 Temporary branch for SpurPlanningCompactor as default compactor. Otherwise the same as VMMaker.oscog-cb.2105. Set deadCode to true in trap bytecode to avoid generating merge machne code that is never reached. Fixed a bug in eventualTargetOf: where nExts was misscomputed, leading jumps targeting jumps with extensions to be incorrectly computed. Fixed a bug where branchIfNotInstanceOf: span function misscomputed the distance when ExtB is negated to inverse the branch. Fixed CharacterAsInteger inlined primitive. =============== Diff against VMMaker.oscogSPC-eem.2102 =============== Item was changed: ----- Method: SimpleStackBasedCogit>>v4:Long:BranchIfNotInstanceOf:Distance: (in category 'span functions') ----- v4: descriptor Long: pc BranchIfNotInstanceOf: nExts Distance: aMethodObj "** 254 11111110 kkkkkkkk jjjjjjjj branch If Not Instance Of Behavior/Array Of Behavior kkkkkkkk (+ Extend A * 256, where Extend A >= 0) distance jjjjjjjj (+ Extend B * 256, where Extend B >= 0)" <var: #descriptor type: #'BytecodeDescriptor *'> | extBValue | self assert: nExts >= 0. self parseV4Exts: nExts priorTo: pc in: aMethodObj into: [:ea :eb| extBValue := eb]. + extBValue < 0 ifTrue: [extBValue := extBValue + 128]. ^(objectMemory fetchByte: pc + 2 ofObject: aMethodObj) + (extBValue << 8)! Item was changed: ----- Method: SistaCogit>>genUnaryInlinePrimitive: (in category 'inline primitive generators') ----- genUnaryInlinePrimitive: prim "Unary inline primitives." "SistaV1: 248 11111000 iiiiiiii mjjjjjjj Call Primitive #iiiiiiii + (jjjjjjj * 256) m=1 means inlined primitive, no hard return after execution. See EncoderForSistaV1's class comment and StackInterpreter>>#unaryInlinePrimitive:" | rcvrReg resultReg | rcvrReg := self allocateRegForStackEntryAt: 0. resultReg := self allocateRegNotConflictingWith: (self registerMaskFor: rcvrReg). prim caseOf: { "00 unchecked class" [1] -> "01 unchecked pointer numSlots" [self ssTop popToReg: rcvrReg. self ssPop: 1. objectRepresentation genGetNumSlotsOf: rcvrReg into: resultReg; genConvertIntegerToSmallIntegerInReg: resultReg]. "02 unchecked pointer basicSize" [3] -> "03 unchecked byte numBytes" [self ssTop popToReg: rcvrReg. self ssPop: 1. objectRepresentation genGetNumBytesOf: rcvrReg into: resultReg; genConvertIntegerToSmallIntegerInReg: resultReg]. "04 unchecked short16Type format numShorts" "05 unchecked word32Type format numWords" "06 unchecked doubleWord64Type format numDoubleWords" [11] -> "11 unchecked fixed pointer basicNew" [self ssTop type ~= SSConstant ifTrue: [^EncounteredUnknownBytecode]. (objectRepresentation genGetInstanceOf: self ssTop constant into: resultReg initializingIf: self extBSpecifiesInitializeInstance) ~= 0 ifTrue: [^ShouldNotJIT]. "e.g. bad class" self ssPop: 1] . [20] -> "20 identityHash" [self ssTop popToReg: rcvrReg. objectRepresentation genGetHashFieldNonImmOf: rcvrReg asSmallIntegerInto: resultReg. self ssPop: 1] . "21 identityHash (SmallInteger)" "22 identityHash (Character)" "23 identityHash (SmallFloat64)" "24 identityHash (Behavior)" "30 immediateAsInteger (Character) 31 immediateAsInteger (SmallFloat64)" [30] -> + [self ssTop popToReg: resultReg. + objectRepresentation genConvertCharacterToSmallIntegerInReg: resultReg. - [self ssTop popToReg: rcvrReg. - objectRepresentation genConvertCharacterToSmallIntegerInReg: rcvrReg. self ssPop: 1] } otherwise: [^EncounteredUnknownBytecode]. extB := 0. numExtB := 0. self ssPushRegister: resultReg. ^0! Item was changed: ----- Method: SistaCogit>>genUnconditionalTrapBytecode (in category 'bytecode generators') ----- genUnconditionalTrapBytecode "SistaV1: * 217 Trap" self ssFlushTo: simStackPtr. self CallRT: ceTrapTrampoline. self annotateBytecode: self Label. + deadCode := true. ^0! Item was changed: ----- Method: StackToRegisterMappingCogit>>eventualTargetOf: (in category 'peephole optimizations') ----- eventualTargetOf: targetBytecodePC "Attempt to follow a branch to a pc. Handle branches to unconditional jumps and branches to push: aBoolean; conditional branch pairs. If the branch cannot be followed answer targetBytecodePC." | currentTarget nextPC nExts descriptor span cond | <var: #descriptor type: #'BytecodeDescriptor *'> nextPC := currentTarget := targetBytecodePC. + [ nExts := 0. + [descriptor := self generatorAt: bytecodeSetOffset - [[nExts := 0. - descriptor := self generatorAt: bytecodeSetOffset + (objectMemory fetchByte: nextPC ofObject: methodObj). descriptor isReturn ifTrue: [^currentTarget]. "avoid stepping off the end of methods" descriptor isExtension] whileTrue: [nExts := nExts + 1. nextPC := nextPC + descriptor numBytes]. descriptor isUnconditionalBranch ifTrue: [span := self spanFor: descriptor at: nextPC exts: nExts in: methodObj. span < 0 ifTrue: "Do *not* follow backward branches; these are interrupt points and should not be elided." [^currentTarget]. nextPC := nextPC + descriptor numBytes + span] ifFalse: [descriptor generator == #genPushConstantTrueBytecode ifTrue: [ cond := true ] ifFalse: [ descriptor generator == #genPushConstantFalseBytecode ifTrue: [ cond := false ] ifFalse: [ ^currentTarget ] ]. "Don't step into loops across a pushTrue; jump:if: boundary, so as not to confuse stack depth fixup." (fixups at: nextPC - initialPC) isBackwardBranchFixup ifTrue: [^currentTarget]. nextPC := self eventualTargetOf: nextPC + descriptor numBytes. nExts := 0. [descriptor := self generatorAt: bytecodeSetOffset + (objectMemory fetchByte: nextPC ofObject: methodObj). descriptor isReturn ifTrue: [^currentTarget]. "avoid stepping off the end of methods" descriptor isExtension] whileTrue: [nExts := nExts + 1. nextPC := nextPC + descriptor numBytes]. descriptor isBranch ifFalse: [^currentTarget]. descriptor isUnconditionalBranch ifTrue: [^currentTarget]. nextPC := cond == descriptor isBranchTrue ifTrue: [nextPC + descriptor numBytes + (self spanFor: descriptor at: nextPC exts: nExts in: methodObj)] ifFalse: [nextPC + descriptor numBytes]]. currentTarget := nextPC] repeat!

1 0

VM Maker: BytecodeSets.spur-cb.66.mcz
by commits＠source.squeak.org 19 Jan '17

19 Jan '17

ClementBera uploaded a new version of BytecodeSets to project VM Maker: http://source.squeak.org/VMMaker/BytecodeSets.spur-cb.66.mcz ==================== Summary ==================== Name: BytecodeSets.spur-cb.66 Author: cb Time: 19 January 2017, 5:52:17.032116 pm UUID: adcb4362-6dd8-49a5-9ca0-156b185b00ea Ancestors: BytecodeSets.spur-eem.65 Added support for branchIfInstanceOf: decoding =============== Diff against BytecodeSets.spur-eem.65 =============== Item was added: + ----- Method: InstructionClient>>branchIfInstanceOf:distance: (in category '*BytecodeSets-instruction decoding') ----- + branchIfInstanceOf: literal distance: distance + "If the object on top of stack has the type -or one of the type- present in the literal (the literal is a behavior or an array of behavior), then pop it. Else jumps by the distance." + ! Item was added: + ----- Method: InstructionPrinter>>branchIfInstanceOf:distance: (in category '*BytecodeSets-SistaV1-decoding') ----- + branchIfInstanceOf: behaviorOrArrayOfBehavior distance: distance + "If the object on top of stack has the type -or one of the type- present in the literal + (the literal is a behavior or an array of behavior), then pop it. Else jumps by the distance." + self print: 'branchIfInstanceOf: ', behaviorOrArrayOfBehavior printString, ' distance: ', distance printString! Item was changed: ----- Method: InstructionStream>>interpretNext3ByteSistaV1Instruction:for:extA:extB:startPC: (in category '*BytecodeSets-SistaV1-decoding') ----- interpretNext3ByteSistaV1Instruction: bytecode for: client extA: extA extB: extB startPC: startPC "Send to the argument, client, a message that specifies the next instruction. This method handles the three-byte codes. For a table of the bytecode set, see EncoderForSistaV1's class comment." | method byte2 byte3 literal | method := self method. byte2 := method at: pc. byte3 := method at: pc + 1. pc := pc + 2. "we search the bytecodes by what we expect to be the static frequency." bytecode = 248 ifTrue: [byte3 >= 128 ifTrue: [^client callInlinePrimitive: byte2 + (byte3 - 128 bitShift: 8)]. ^client callPrimitive: byte2 + (byte3 bitShift: 8)]. "* 249 11111001 xxxxxxxx siyyyyyy push Closure Compiled block literal index xxxxxxxx (+ Extend A * 256) numCopied yyyyyy receiverOnStack: s = 1 ignoreOuterContext: i = 1" bytecode = 249 ifTrue: [literal := method literalAt: (extA bitShift: 8) + byte2 + 1. ^client pushFullClosure: literal numCopied: (byte3 bitAnd: 16r3F)]. bytecode = 250 ifTrue: ["** 250 11111010 eeiiikkk jjjjjjjj Push Closure Num Copied iii (+ExtA//16*8) Num Args kkk (+ ExtA\\16*8) BlockSize jjjjjjjj (+ExtB*256). ee = num extensions" ^client pushClosureCopyNumCopiedValues: ((byte2 bitShift: -3) bitAnd: 7) + (extA // 16 bitShift: 3) numArgs: (byte2 bitAnd: 7) + (extA \\ 16 bitShift: 3) blockSize: byte3 + (extB bitShift: 8)]. bytecode = 251 ifTrue: [^client pushRemoteTemp: byte2 inVectorAt: byte3]. bytecode = 252 ifTrue: [^client storeIntoRemoteTemp: byte2 inVectorAt: byte3]. bytecode = 253 ifTrue: [^client popIntoRemoteTemp: byte2 inVectorAt: byte3]. "** 254 11111110 kkkkkkkk jjjjjjjj branch If Not Instance Of Behavior/Array Of Behavior kkkkkkkk (+ Extend A * 256, where Extend A >= 0) distance jjjjjjjj (+ Extend B * 256, where Extend B >= 0)" bytecode = 254 ifTrue: + [extB < 0 ifTrue: [client branchIfInstanceOf: literal distance: (extB + 128 bitShift: 8) + byte3]. + ^ client branchIfNotInstanceOf: literal distance: (extB bitShift: 8) + byte3 ]. - [^ client branchIfNotInstanceOf: literal distance: (extB bitShift: 8) + byte3 ]. ^self unusedBytecode: client at: startPC! Item was changed: ----- Method: StackDepthFinder>>branchIfNotInstanceOf:distance: (in category '*BytecodeSets-SistaV1-decoding') ----- + branchIfNotInstanceOf: behaviorOrArrayOfBehavior distance: delta + self drop. + self doJump: delta! - branchIfNotInstanceOf: behaviorOrArrayOfBehavior distance: anInteger - self drop!

1 0

VM Maker: VMMaker.oscog-cb.2105.mcz
by commits＠source.squeak.org 19 Jan '17

19 Jan '17

ClementBera uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-cb.2105.mcz ==================== Summary ==================== Name: VMMaker.oscog-cb.2105 Author: cb Time: 19 January 2017, 12:19:42.246677 pm UUID: 1f5ef635-cb7b-48c2-be74-4345d39c620f Ancestors: VMMaker.oscog-cb.2104 Set deadCode to true in trap bytecode to avoid generating merge machne code that is never reached. Something is fishy in debugStackPointers in the SistaVM. It fails multiple assertion. I believe it's related tobranchIfInstanceOf bytecodes =============== Diff against VMMaker.oscog-cb.2104 =============== Item was changed: ----- Method: SistaCogit>>genUnconditionalTrapBytecode (in category 'bytecode generators') ----- genUnconditionalTrapBytecode "SistaV1: * 217 Trap" self ssFlushTo: simStackPtr. self CallRT: ceTrapTrampoline. self annotateBytecode: self Label. + deadCode := true. ^0!

3 2

VM Maker: VMMaker.oscog-cb.2104.mcz
by commits＠source.squeak.org 19 Jan '17

19 Jan '17

ClementBera uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-cb.2104.mcz ==================== Summary ==================== Name: VMMaker.oscog-cb.2104 Author: cb Time: 19 January 2017, 11:58:35.234079 am UUID: 90bbfa32-c00f-4e99-a486-2febcdc203da Ancestors: VMMaker.oscog-cb.2103 Fixed a bug in eventualTargetOf: where nExts was misscomputed, leading jumps targeting jumps with extensions to be incorrectly computed. Fixed a bug where branchIfNotInstanceOf: span function misscomputed the distance when ExtB is negated to inverse the branch. =============== Diff against VMMaker.oscog-cb.2103 =============== Item was changed: ----- Method: SimpleStackBasedCogit>>v4:Long:BranchIfNotInstanceOf:Distance: (in category 'span functions') ----- v4: descriptor Long: pc BranchIfNotInstanceOf: nExts Distance: aMethodObj "** 254 11111110 kkkkkkkk jjjjjjjj branch If Not Instance Of Behavior/Array Of Behavior kkkkkkkk (+ Extend A * 256, where Extend A >= 0) distance jjjjjjjj (+ Extend B * 256, where Extend B >= 0)" <var: #descriptor type: #'BytecodeDescriptor *'> | extBValue | self assert: nExts >= 0. self parseV4Exts: nExts priorTo: pc in: aMethodObj into: [:ea :eb| extBValue := eb]. + extBValue < 0 ifTrue: [extBValue := extBValue + 128]. ^(objectMemory fetchByte: pc + 2 ofObject: aMethodObj) + (extBValue << 8)! Item was changed: ----- Method: StackToRegisterMappingCogit>>eventualTargetOf: (in category 'peephole optimizations') ----- eventualTargetOf: targetBytecodePC "Attempt to follow a branch to a pc. Handle branches to unconditional jumps and branches to push: aBoolean; conditional branch pairs. If the branch cannot be followed answer targetBytecodePC." | currentTarget nextPC nExts descriptor span cond | <var: #descriptor type: #'BytecodeDescriptor *'> nextPC := currentTarget := targetBytecodePC. + [ nExts := 0. + [descriptor := self generatorAt: bytecodeSetOffset - [[nExts := 0. - descriptor := self generatorAt: bytecodeSetOffset + (objectMemory fetchByte: nextPC ofObject: methodObj). descriptor isReturn ifTrue: [^currentTarget]. "avoid stepping off the end of methods" descriptor isExtension] whileTrue: [nExts := nExts + 1. nextPC := nextPC + descriptor numBytes]. descriptor isUnconditionalBranch ifTrue: [span := self spanFor: descriptor at: nextPC exts: nExts in: methodObj. span < 0 ifTrue: "Do *not* follow backward branches; these are interrupt points and should not be elided." [^currentTarget]. nextPC := nextPC + descriptor numBytes + span] ifFalse: [descriptor generator == #genPushConstantTrueBytecode ifTrue: [ cond := true ] ifFalse: [ descriptor generator == #genPushConstantFalseBytecode ifTrue: [ cond := false ] ifFalse: [ ^currentTarget ] ]. "Don't step into loops across a pushTrue; jump:if: boundary, so as not to confuse stack depth fixup." (fixups at: nextPC - initialPC) isBackwardBranchFixup ifTrue: [^currentTarget]. nextPC := self eventualTargetOf: nextPC + descriptor numBytes. nExts := 0. [descriptor := self generatorAt: bytecodeSetOffset + (objectMemory fetchByte: nextPC ofObject: methodObj). descriptor isReturn ifTrue: [^currentTarget]. "avoid stepping off the end of methods" descriptor isExtension] whileTrue: [nExts := nExts + 1. nextPC := nextPC + descriptor numBytes]. descriptor isBranch ifFalse: [^currentTarget]. descriptor isUnconditionalBranch ifTrue: [^currentTarget]. nextPC := cond == descriptor isBranchTrue ifTrue: [nextPC + descriptor numBytes + (self spanFor: descriptor at: nextPC exts: nExts in: methodObj)] ifFalse: [nextPC + descriptor numBytes]]. currentTarget := nextPC] repeat!

1 0

VM Maker: VMMaker.oscog-cb.2103.mcz
by commits＠source.squeak.org 19 Jan '17

19 Jan '17

ClementBera uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-cb.2103.mcz ==================== Summary ==================== Name: VMMaker.oscog-cb.2103 Author: cb Time: 19 January 2017, 10:05:24.518362 am UUID: d4b300a5-637f-49dd-ae17-64d457247b7c Ancestors: VMMaker.oscog-eem.2102 Fixed CharacterAsInteger inlined primitive. =============== Diff against VMMaker.oscog-eem.2102 =============== Item was changed: ----- Method: SistaCogit>>genUnaryInlinePrimitive: (in category 'inline primitive generators') ----- genUnaryInlinePrimitive: prim "Unary inline primitives." "SistaV1: 248 11111000 iiiiiiii mjjjjjjj Call Primitive #iiiiiiii + (jjjjjjj * 256) m=1 means inlined primitive, no hard return after execution. See EncoderForSistaV1's class comment and StackInterpreter>>#unaryInlinePrimitive:" | rcvrReg resultReg | rcvrReg := self allocateRegForStackEntryAt: 0. resultReg := self allocateRegNotConflictingWith: (self registerMaskFor: rcvrReg). prim caseOf: { "00 unchecked class" [1] -> "01 unchecked pointer numSlots" [self ssTop popToReg: rcvrReg. self ssPop: 1. objectRepresentation genGetNumSlotsOf: rcvrReg into: resultReg; genConvertIntegerToSmallIntegerInReg: resultReg]. "02 unchecked pointer basicSize" [3] -> "03 unchecked byte numBytes" [self ssTop popToReg: rcvrReg. self ssPop: 1. objectRepresentation genGetNumBytesOf: rcvrReg into: resultReg; genConvertIntegerToSmallIntegerInReg: resultReg]. "04 unchecked short16Type format numShorts" "05 unchecked word32Type format numWords" "06 unchecked doubleWord64Type format numDoubleWords" [11] -> "11 unchecked fixed pointer basicNew" [self ssTop type ~= SSConstant ifTrue: [^EncounteredUnknownBytecode]. (objectRepresentation genGetInstanceOf: self ssTop constant into: resultReg initializingIf: self extBSpecifiesInitializeInstance) ~= 0 ifTrue: [^ShouldNotJIT]. "e.g. bad class" self ssPop: 1] . [20] -> "20 identityHash" [self ssTop popToReg: rcvrReg. objectRepresentation genGetHashFieldNonImmOf: rcvrReg asSmallIntegerInto: resultReg. self ssPop: 1] . "21 identityHash (SmallInteger)" "22 identityHash (Character)" "23 identityHash (SmallFloat64)" "24 identityHash (Behavior)" "30 immediateAsInteger (Character) 31 immediateAsInteger (SmallFloat64)" [30] -> + [self ssTop popToReg: resultReg. + objectRepresentation genConvertCharacterToSmallIntegerInReg: resultReg. - [self ssTop popToReg: rcvrReg. - objectRepresentation genConvertCharacterToSmallIntegerInReg: rcvrReg. self ssPop: 1] } otherwise: [^EncounteredUnknownBytecode]. extB := 0. numExtB := 0. self ssPushRegister: resultReg. ^0!

1 0

Re: [Vm-dev] [Pharo-dev] FFICallback crashes windows spur i386 vm
by Nicolas Cellier 19 Jan '17

19 Jan '17

I've reproduced the crash in squeak.stack.spur Win32 with latest vm sources (SHA aa11221d9ebb5d60b0b88a2f1f8e27f19909d718) This crashing VM is compiled with gcc via ./mvm -f The Win64 version passes correctly. But it is compiled with clang by default. The Win32 compiled with clang also passes correctly for me. The test is translated in pure Alien for purpose of testing on Squeak 5.0 (see instructions below). -------------------------------------------------------------- from cygwin (or cygwin64) shell: $ i686-w64-mingw32-gcc --version i686-w64-mingw32-gcc (GCC) 5.4.0 Copyright (C) 2015 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. $ i686-w64-mingw32-clang --version clang version 3.8.1 (tags/RELEASE_381/final) Target: i686-w64-windows-gnu Thread model: posix InstalledDir: /usr/bin $ x86_64-w64-mingw32-clang --version clang version 3.8.1 (tags/RELEASE_381/final) Target: x86_64-w64-windows-gnu Thread model: posix InstalledDir: /usr/bin -------------------------------------------------------------- $ cd build.win32x86/squeak.stack.spur $ ./mvm -f -- CC=i686-w64-mingw32-clang or for 64 bits: $ cd build.win64x64/squeak.stack.spur $ ./mvm -f -------------------------------------------------------------- $ cat >test.c << END #include "stdint.h" int8_t test(int8_t(*function)(int8_t), int8_t value) { return function(value); } END $ i686-w64-mingw32-clang -c test.c $ i686-w64-mingw32-clang -shared -o build/vm/test.dll test.o $ build/vm/Squeak.exe -------------------------------------------------------------- then from Smalltalk image with Alien properly loaded (Alien-eem.39): Callback>>int8RetInt8: callbackContext regs: regsAlien <signature: #(int8 (*)(int8))> ^callbackContext wordResult: (block value: (regsAlien signedCharAt: 1) asInteger) (for now, above method must be compiled in each Callback subclass since we do not ask Pragma to scan superclass for signatures) TestCase subclass: #AlienCallbackSunit instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'Alien-CoreTest' AlienCallbackSunit>>createCallback ^Callback signature: #(int8 (*)(int8)) block: [ :value | value ] AlienCallbackSunit>>primCall: aCallback int8: aNumber | r | (Alien lookup: 'test' inLibrary: 'test.dll') primFFICallResult: (r := Alien new: 1) with: aCallback thunk with: aNumber. ^(r signedCharAt: 1) asInteger AlienCallbackSunit>>test self assert: (self primCall: self createCallback int8: 0) equals: 0 AlienCallbackSunit new test. 2017-01-14 2:53 GMT+01:00 Eliot Miranda <eliot.miranda(a)gmail.com>: > Hi Aliaksei, > > On Jan 13, 2017, at 10:27 AM, Aliaksei Syrel <alex.syrel(a)gmail.com> wrote: > > Hi > > The following code crashes windows spur32 VM without crash.dmp: > (crashes not only in case of int8, but ulong, int16/32 and so on...) > > Callback instantiation: > > createCallback >> ^ FFICallback >> signature: #(int8 (int8)) >> block: [ :value | value ] > > > C function: > > int8_t test(int8_t(*function)(int8_t), int8_t value) { >> return function(value); >> } > > > FFI call: > > primCall: aCallback int8: aNumber >> ^ self ffiCall: #(int8 test(FFICallback aCallback, int8 aNumber)) > > > Test case: > > test >> self >> assert: (self primCall: self createCallback int8: 0) >> equals: 0 > > > > Windows 10. > VM from today: > http://files.pharo.org/vm/pharo-spur32/win/pharo-win- > i386-201701130756-83c0ef1.zip > Image 60343: > http://files.pharo.org/image/60/60343.zip > > P.S. what is the best place to report FFI / Alien issues? > > > vm-dev > > P.P.S Iceberg works > > Cheers, > Alex > >

3 5

← Newer
1
2
3
4
5
6
7
8
9
...
14
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev January 2017