Vm-dev January 2017

vm-dev@lists.squeakfoundation.org

30 participants
136 discussions

Re: [Vm-dev] [squeak-dev] how to see primitive source these days?
by Eliot Miranda 11 Jan '17

11 Jan '17

Hi Fabio, On Wed, Jan 11, 2017 at 7:53 AM, Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > Hi Fabio, > > this looks like the build system isn't cool figured to use an older > SDK. The makefiles are written to use the oldest suitable SDK > automatically. The build slave should use 10.9 (Mavericks) but that > implies installing the 10.9 SDK, and IIRC Apple doesn't make that easy. > Both of my machines have the 10.9 SDK. Given that I have the bits, how > can we install the bits on the build slave? > Actually for 64-bit one must use the 10.10 SDK or later, and for 32-bit the 10.9 or later. And of course the oldest available is a more useful policy than the most up-to-date. But the same question applies, how to we install the 10.9 SDK on the 32-bit slave and the 10.10 SDK on the 64-bit slave? > > _,,,^..^,,,_ (phone) > > On Jan 11, 2017, at 2:54 AM, Bob Arning <arning315(a)comcast.net> wrote: > > I don't get as far as an image. The app icon indicates it is broken and > when I double-click the app, I get a MacOS message saying 10.11 is > required. Both > > cog_macos32x86_squeak.cog.spur_201701110136.tar.gz > > and > > cog_macos64x64_squeak.cog.spur_201701110136.tar.gz > > had the same problem > > > > On 1/11/17 5:44 AM, Fabio Niephaus wrote: > > On Wed, Jan 11, 2017 at 11:35 AM Bob Arning <arning315(a)comcast.net> wrote: > >> Seems like MacOS 10.10 is no longer supported? :-( >> > Did you try to open a 64bit or a 32bit image? > > >> >> >> On 1/10/17 7:58 PM, Eliot Miranda wrote: >> >> thanks for the prod. I'm committing the fix now. New VMs should be >> built by the bots within an hour after I generate and commit C sources. >> >> > _,,,^..^,,,_ best, Eliot

1 1

Primitive 105 issues (was: Re: [squeak-dev] how to see primitive source these days?)
by Levente Uzonyi 11 Jan '17

11 Jan '17

The same issue is present on 64-bit Linux. When the target is smaller than the source, the primitive will just fail for 4-byte collections. Here's an example with WordArray: source := #(1 2 3) asWordArray. target := WordArray new: 2. "change to 3 to make it use the primitive" target replaceFrom: 1 to: target size with: source startingAt: 1 The same problem is present for 2-byte (DoubleByteArray) and 8-byte (DoubleWordArray) collections, but, to my surprise, it works for ByteArray. (Haven't checked the C code yet.) Levente On Tue, 10 Jan 2017, Bob Arning wrote: > > I got the 64-bit macos vm and the problem is still there. > > > /Users/bob/squeak/Squeak5.1-16548-64bit-All-in-One/Squeak5.1-16548-64bit-All-in-One.app/Contents/Resources/CocoaFast.app/Contents/MacOS/Squeak > Croquet Closure Cog[Spur] VM [CoInterpreterPrimitives VMMaker.oscog-cb.1919] > Mac OS X built on Sep 25 2016 16:07:11 UTC Compiler: 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.54) > platform sources revision VM: 201608171728 https://github.com/OpenSmalltalk/opensmalltalk-vm.git $ Date: Wed Aug 17 10:28:01 2016 -0700 $ Plugins: 201608171728 > https://github.com/OpenSmalltalk/opensmalltalk-vm.git $ > CoInterpreter VMMaker.oscog-cb.1919 uuid: 00a8dd2a-bc8d-4552-b400-be781c8aabec Sep 25 2016 > StackToRegisterMappingCogit VMMaker.oscog-cb.1919 uuid: 00a8dd2a-bc8d-4552-b400-be781c8aabec Sep 25 2016 > > > On 1/10/17 1:00 PM, David T. Lewis wrote: > > It sounds like a VM bug. I am away and cannot check anything further right > now, but one thing I would mention is that there has been a good deal of > recent VM development that may be related to this, so if you don't mind > experimenting you may want to try one of the latest VMs here: > > https://github.com/OpenSmalltalk/opensmalltalk-vm/releases/tag/201608171728 > > That will at least let you see if it is a bug that someone has already > fixed (which I think is quite likely). > > Dave > > > Thanks, Dave, > > There are a number of errors possible in that primitive and I don't know > if one can see the particular code after a failure. I was able to narrow > it down, though. Adding this to FloatArray: > > testreplaceFrom: start to: stop with: replacement startingAt: repStart > " > (FloatArray new: 8) testreplaceFrom: 1 to: 3 with: (FloatArray new: 3) > startingAt: 1 > " > <primitive: 105> > self halt. > > Runs fine in 32-bit squeak and halts in 64-bit. > > -----------succeeds on----------- > > Virtual Machine > --------------- > /Users/bob/squeak/old squeak5.1/ast 5.1.app/Contents/MacOS/Squeak > Croquet Closure Cog[Spur] VM [CoInterpreterPrimitives > VMMaker.oscog-cb.1919] 32 bit > Mac OS X built on Aug 17 2016 18:59:49 UTC Compiler: 4.2.1 Compatible > Apple LLVM 6.0 (clang-600.0.54) > platform sources revision VM: 201608171728 > https://github.com/OpenSmalltalk/opensmalltalk-vm.git $ Date: Wed Aug 17 > 10:28:01 2016 -0700 $ Plugins: 201608171728 > https://github.com/OpenSmalltalk/opensmalltalk-vm.git $ > CoInterpreter VMMaker.oscog-cb.1919 uuid: > 00a8dd2a-bc8d-4552-b400-be781c8aabec Aug 17 2016 > StackToRegisterMappingCogit VMMaker.oscog-cb.1919 uuid: > 00a8dd2a-bc8d-4552-b400-be781c8aabec Aug 17 2016 > > --------fails on-------- > > Virtual Machine > --------------- > /Users/bob/squeak/Squeak5.1-16548-64bit-All-in-One/Squeak5.1-16548-64bit-All-in-One.app/Contents/MacOS/Squeak > Croquet Closure Cog[Spur] VM [CoInterpreterPrimitives > VMMaker.oscog-cb.1919] 64 bit > Mac OS X built on Aug 17 2016 18:51:56 UTC Compiler: 4.2.1 Compatible > Apple LLVM 6.0 (clang-600.0.54) > platform sources revision VM: 201608171728 > https://github.com/OpenSmalltalk/opensmalltalk-vm.git $ Date: Wed Aug 17 > 10:28:01 2016 -0700 $ Plugins: 201608171728 > https://github.com/OpenSmalltalk/opensmalltalk-vm.git $ > CoInterpreter VMMaker.oscog-cb.1919 uuid: > 00a8dd2a-bc8d-4552-b400-be781c8aabec Aug 17 2016 > StackToRegisterMappingCogit VMMaker.oscog-cb.1919 uuid: > 00a8dd2a-bc8d-4552-b400-be781c8aabec Aug 17 2016 > > > > > On 1/10/17 9:06 AM, David T. Lewis wrote: > > How to see primitive source these days: > > The code is in the VMMaker repository > 'http://source.squeak.org/VMMaker'. > > For the Spur VM, the package is 'VMMaker.oscog'. For purposes of just > taking a quick look at the code, you can load the latest version > VMMaker.oscog-eem.2079 (this will not exactly corresponding to the > version > you are running but here I assume you just want a quick look at what > primitive 105 is doing). > > To find the numbered primitive, see CoInterpreter > class>>initializePrimitiveTable, > which calls StackInterpreter class>>initializePrimitiveTable, which > shows > primitive 105 as #primitiveStringReplace. > > The Smalltalk code for this primitive is > InterpreterPrimitives>>primitiveStringReplace. > The generated C code for this can be found in the GitHub repository > https://github.com/OpenSmalltalk/opensmalltalk-vm, look for the > primitiveStringReplace function in > opensmalltalk-vm/src/vm/gcc3x-cointerpmt.c. > > Dave > > > > On Tue, Jan 10, 2017 at 07:57:31AM -0500, Bob Arning wrote: > > I'm was copying a FloatArray and it seems not to be using the primitive > to move the data over to the copy. > Float>>replaceFrom:to:with:startingAt: says it uses a primitive, but it > seem to fallback to the code in SequenceableCollection. How can I see > the priitive code to see what the issue may be? This is what it says it > does: > > replaceFrom: start to: stop with: replacement startingAt: repStart > "Primitive. This destructively replaces elements from start to stop in > the receiver starting at index, repStart, in the collection, > replacement. Answer the receiver. Range checks are performed in the > primitive only. Optional. See Object documentation whatIsAPrimitive." > <primitive: 105> super replaceFrom: start to: stop with: > replacement startingAt: repStart > > This is what I did to see if the prim failed: > > replaceFrom: start to: stop with: replacement startingAt: repStart > "Primitive. This destructively replaces elements from start to stop in > the receiver starting at index, repStart, in the collection, > replacement. Answer the receiver. Range checks are performed in the > primitive only. Optional. See Object documentation whatIsAPrimitive." > <primitive: 105> WOOPS ifNil: [ WOOPS _ #WOOPS. > self halt ]. super replaceFrom: start to: stop with: > replacement > startingAt: repStart > > And it did fail and I'm puzzled as to why: > > Halt: > 10 January 2017 7:46:09.382669 am > > VM: Mac OS - Smalltalk > Image: Squeak5.1 [latest update: #16548] > > SecurityManager state: > Restricted: false > FileAccess: true > SocketAccess: true > Working Dir > /Users/bob/squeak/Squeak5.1-16548-64bit-All-in-One/Squeak5.1-16548-64bit-All-in-One.app/Contents/Resources > Trusted Dir /Users/bob/Library/Application Support/Squeak/ > Untrusted Dir /Users/bob/Documents/Squeak/ > > FloatArray(Object)>>halt > Receiver: a FloatArray(0.0 0.0 0.0) > Arguments and temporary variables: > > Receiver's instance variables: > a FloatArray(0.0 0.0 0.0) > FloatArray>>replaceFrom:to:with:startingAt: > Receiver: a FloatArray(0.0 0.0 0.0) > Arguments and temporary variables: > start: 1 > stop: 3 > replacement: a FloatArray(1.0 1.0 1.0 1.0 1.0 1.0 1.0 1.0 > 1.0 1.0 1.0 1.0 1.0 1...etc... > repStart: 1 > Receiver's instance variables: > a FloatArray(0.0 0.0 0.0) > FloatArray(SequenceableCollection)>>copyFrom:to: > Receiver: a FloatArray(1.0 1.0 1.0 1.0 1.0 1.0 1.0 1.0 1.0 1.0 1.0 > 1.0 1.0 1.0 1.0 1.0 1.0 1.0 1.0 1...etc... > Arguments and temporary variables: > start: 1 > stop: 3 > newSize: 3 > Receiver's instance variables: > a FloatArray(1.0 1.0 1.0 1.0 1.0 1.0 1.0 1.0 1.0 1.0 1.0 1.0 1.0 1.0 > 1.0 > 1.0 1.0 1.0 1.0 1...etc... > ConvolutionalLayer>>forward:isTraining: > > > > > > > >

3 3

[OpenSmalltalk/opensmalltalk-vm] faf790: CogVM source as per VMMaker.oscog-eem.2082
by GitHub 11 Jan '17

11 Jan '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: faf790a7263bcefea8e1118f3ee95a2e50dd4b0b https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/faf790a7263bcefea8… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-01-10 (Tue, 10 Jan 2017) Changed paths: M build.macos32x86/makeall M build.macos64x64/makeall M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M platforms/Cross/vm/sqAssert.h M spur64src/vm/cogit.h M spur64src/vm/cogitX64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitX64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/vm/cogit.h M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2082 Split primitive 105 into a Spur and a V3 version. Spur: Fix primitive 105 to work for 64- and 16-bit arrays, and fix the bug there-in that failed for different length mod 4 32-bit arrays on 64-bits. Extract the store check in primitiveSpurStringReplace.

1 0

VM Maker: VMMaker.oscog-eem.2082.mcz
by commits＠source.squeak.org 11 Jan '17

11 Jan '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2082.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2082 Author: eem Time: 10 January 2017, 5:24:49.762499 pm UUID: f987e1db-f4c0-40ed-86ec-7a478cb89067 Ancestors: VMMaker.oscog-eem.2081 Spur: Go the extra few inches and extract the store check in primitiveSpurStringReplace. =============== Diff against VMMaker.oscog-eem.2081 =============== Item was changed: ----- Method: InterpreterPrimitives>>primitiveSpurStringReplace (in category 'indexing primitives') ----- primitiveSpurStringReplace "<array> primReplaceFrom: start to: stop with: replacement startingAt: repStart <primitive: 105>" <inline: true> | array start stop repl replStart arrayFmt arrayLength arrayInstSize replFmt replLength replInstSize srcDelta | array := self stackValue: 4. start := self stackValue: 3. stop := self stackValue: 2. repl := self stackValue: 1. replStart := self stackValue: 0. ((objectMemory isNonIntegerObject: start) or: [(objectMemory isNonIntegerObject: stop) or: [(objectMemory isNonIntegerObject: replStart) or: [objectMemory isImmediate: repl]]]) ifTrue: "can happen in LgInt copy" [^self primitiveFailFor: PrimErrBadArgument]. start := objectMemory integerValueOf: start. stop := objectMemory integerValueOf: stop. replStart := objectMemory integerValueOf: replStart. (stop >= start and: [objectMemory isObjImmutable: array]) ifTrue: [^self primitiveFailFor: PrimErrNoModification]. arrayFmt := objectMemory formatOf: array. arrayLength := objectMemory lengthOf: array format: arrayFmt. arrayFmt := objectMemory classFormatFromInstFormat: arrayFmt. replFmt := objectMemory formatOf: repl. replLength := objectMemory lengthOf: repl format: replFmt. replFmt := objectMemory classFormatFromInstFormat: replFmt. "Array formats (without oddFields bits) must be the same" (arrayFmt = replFmt and: [arrayFmt < objectMemory firstCompiledMethodFormat]) ifFalse: [^self primitiveFailFor: PrimErrInappropriate]. + "N.B. In the below start - 1 to: stop - 1 do:, Slang is intelligent enough to use < instead of <= so avoiding the stop - 1." arrayFmt <= objectMemory lastPointerFormat ifTrue: [arrayInstSize := objectMemory fixedFieldsOf: array format: arrayFmt length: arrayLength. replInstSize := objectMemory fixedFieldsOf: repl format: replFmt length: replLength. (start >= 1 and: [start - 1 <= stop and: [stop + arrayInstSize <= arrayLength and: [replStart >= 1 and: [stop - start + replStart + replInstSize <= replLength]]]]) ifFalse: [^self primitiveFailFor: PrimErrBadIndex]. + start := start + arrayInstSize. + stop := stop + arrayInstSize. + srcDelta := (replStart + replInstSize) - start. + (objectMemory isOldObject: array) + ifTrue: + [| mustRemember oop | + mustRemember := false. + start - 1 to: stop - 1 do: + [:i | + oop := objectMemory fetchPointer: srcDelta + i ofObject: repl. + (objectMemory isYoung: oop) ifTrue: + [mustRemember := true]. + objectMemory storePointerUnchecked: i ofObject: array withValue: oop]. + mustRemember ifTrue: + [objectMemory possibleRootStoreInto: array]] + ifFalse: + [start - 1 to: stop - 1 do: + [:i | objectMemory storePointerUnchecked: i ofObject: array withValue: (objectMemory fetchPointer: srcDelta + i ofObject: repl)]]] - srcDelta := (replStart + replInstSize) - (start + arrayInstSize). - start + arrayInstSize - 1 to: stop + arrayInstSize - 1 do: - [:i | - objectMemory storePointer: i ofObject: array withValue: (objectMemory fetchPointer: srcDelta + i ofObject: repl)]] ifFalse: [(start >= 1 and: [start - 1 <= stop and: [stop <= arrayLength and: [replStart >= 1 and: [stop - start + replStart <= replLength]]]]) ifFalse: [^self primitiveFailFor: PrimErrBadIndex]. srcDelta := replStart - start. arrayFmt >= objectMemory firstShortFormat ifTrue: "8 & 16-bit word type objects" [arrayFmt >= objectMemory firstByteFormat ifTrue: "byte-type objects" [start - 1 to: stop - 1 do: [:i | objectMemory storeByte: i ofObject: array withValue: (objectMemory fetchByte: srcDelta + i ofObject: repl)]] ifFalse: "short type objects" [start - 1 to: stop - 1 do: [:i | objectMemory storeShort16: i ofObject: array withValue: (objectMemory fetchShort16: srcDelta + i ofObject: repl)]]] ifFalse: "32 & 64-bit word type objects" [arrayFmt >= objectMemory firstLongFormat ifTrue: "word-type objects" [start - 1 to: stop - 1 do: [:i | objectMemory storeLong32: i ofObject: array withValue: (objectMemory fetchLong32: srcDelta + i ofObject: repl)]] ifFalse: "long type objects" [start - 1 to: stop - 1 do: [:i | objectMemory storeLong64: i ofObject: array withValue: (objectMemory fetchLong64: srcDelta + i ofObject: repl)]]]]. "We might consider comparing stop - start to some value here and using forceInterruptCheck" self pop: argumentCount "leave rcvr on stack"!

1 0

VM Maker: VMMaker.oscog-eem.2081.mcz
by commits＠source.squeak.org 11 Jan '17

11 Jan '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2081.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2081 Author: eem Time: 10 January 2017, 5:02:06.508527 pm UUID: 191ab786-20f3-4cab-9b9c-e0c0f21743fb Ancestors: VMMaker.oscog-eem.2080 Spur: Fix primitive 105 to work for 64- and 16-bit arrays, and fix the bug there-in that failed for different length mod 4 32-bit arrays on 64-bits. Split primitive 105 into a Spur and a V3 version. Fix all the comments that were unsure about the reality of 64-bit word arrays. =============== Diff against VMMaker.oscog-eem.2080 =============== Item was changed: ----- Method: CogObjectRepresentationFor32BitSpur>>genGetSizeOf:into:formatReg:scratchReg:abortJumpsInto: (in category 'primitive generators') ----- genGetSizeOf: sourceReg into: destReg formatReg: formatReg scratchReg: scratchReg abortJumpsInto: aBinaryBlock "Get the size of the non-immediate object in sourceReg into destReg using formatReg and scratchReg as temps. None of these registers can overlap. Supply the jumps taken if the object in sourceReg is not indexable, or if the object in sourceReg is a context.. Hack: If the object has a pointer format other than 2 leave the number of fixed fields in formatReg. Used by primitiveSize, primitiveAt, and primitiveAtPut" <returnTypeC: #'AbstractInstruction *'> | jumpNotIndexable jumpBytesDone jumpShortsDone jumpArrayDone jump32BitLongsDone jumpIsBytes jumpHasFixedFields jumpIsShorts jumpIsContext | <inline: true> "c.f. StackInterpreter>>stSizeOf: SpurMemoryManager>>lengthOf:format: fixedFieldsOf:format:length:" <var: #jumpIsBytes type: #'AbstractInstruction *'> <var: #jumpIsShorts type: #'AbstractInstruction *'> <var: #jumpIsContext type: #'AbstractInstruction *'> <var: #jumpArrayDone type: #'AbstractInstruction *'> <var: #jumpNotIndexable type: #'AbstractInstruction *'> <var: #jumpHasFixedFields type: #'AbstractInstruction *'> <var: #jump32BitLongsDone type: #'AbstractInstruction *'> "formatReg := self formatOf: sourceReg" self genGetFormatOf: sourceReg into: formatReg leastSignificantHalfOfBaseHeaderIntoScratch: scratchReg. self genGetNumSlotsOf: sourceReg into: destReg. "dispatch on format in a combination of highest dynamic frequency order first and convenience. 0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" cogit CmpCq: objectMemory firstByteFormat R: formatReg. jumpIsBytes := cogit JumpGreaterOrEqual: 0. cogit CmpCq: objectMemory arrayFormat R: formatReg. jumpArrayDone := cogit JumpZero: 0. jumpNotIndexable := cogit JumpLess: 0. cogit CmpCq: objectMemory weakArrayFormat R: formatReg. jumpHasFixedFields := cogit JumpLessOrEqual: 0. cogit CmpCq: objectMemory firstShortFormat R: formatReg. jumpIsShorts := cogit JumpGreaterOrEqual: 0. cogit CmpCq: objectMemory firstLongFormat R: formatReg. jump32BitLongsDone := cogit JumpGreaterOrEqual: 0. "For now ignore 64-bit indexability." jumpNotIndexable jmpTarget: cogit Label. jumpNotIndexable := cogit Jump: 0. jumpIsBytes jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord R: destReg). cogit AndCq: objectMemory wordSize - 1 R: formatReg. cogit SubR: formatReg R: destReg. jumpBytesDone := cogit Jump: 0. jumpIsShorts jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord - 1 R: destReg). cogit AndCq: 1 R: formatReg. cogit SubR: formatReg R: destReg. jumpShortsDone := cogit Jump: 0. "formatReg contains fmt, now up for grabs. destReg contains numSlots, precious. sourceReg must be preserved" jumpHasFixedFields jmpTarget: (cogit AndCq: objectMemory classIndexMask R: scratchReg). cogit MoveR: scratchReg R: formatReg. cogit CmpCq: ClassMethodContextCompactIndex R: scratchReg. jumpIsContext := cogit JumpZero: 0. cogit PushR: destReg. self genGetClassObjectOfClassIndex: formatReg into: destReg scratchReg: scratchReg. self genLoadSlot: InstanceSpecificationIndex sourceReg: destReg destReg: formatReg. self genConvertSmallIntegerToIntegerInReg: formatReg. cogit PopR: destReg; AndCq: objectMemory fixedFieldsOfClassFormatMask R: formatReg; SubR: formatReg R: destReg. jumpArrayDone jmpTarget: (jump32BitLongsDone jmpTarget: (jumpShortsDone jmpTarget: (jumpBytesDone jmpTarget: cogit Label))). aBinaryBlock value: jumpNotIndexable value: jumpIsContext! Item was changed: ----- Method: CogObjectRepresentationFor32BitSpur>>genPrimitiveAt (in category 'primitive generators') ----- genPrimitiveAt | formatReg nSlotsOrBytesReg convertToIntAndReturn methodInBounds jumpNotIndexable jumpImmediate jumpBadIndex jumpIsBytes jumpIsShorts jumpIsWords jumpIsMethod jumpWordTooBig jumpIsArray jumpHasFixedFields jumpIsContext jumpBytesOutOfBounds jumpShortsOutOfBounds jumpWordsOutOfBounds jumpMethodOutOfBounds jumpArrayOutOfBounds jumpFixedFieldsOutOfBounds | "c.f. StackInterpreter>>stSizeOf: SpurMemoryManager>>lengthOf:format: fixedFieldsOf:format:length:" <var: #jumpIsBytes type: #'AbstractInstruction *'> <var: #jumpIsShorts type: #'AbstractInstruction *'> <var: #jumpIsMethod type: #'AbstractInstruction *'> <var: #jumpBadIndex type: #'AbstractInstruction *'> <var: #jumpIsContext type: #'AbstractInstruction *'> <var: #jumpImmediate type: #'AbstractInstruction *'> <var: #methodInBounds type: #'AbstractInstruction *'> <var: #jumpWordTooBig type: #'AbstractInstruction *'> <var: #jumpNotIndexable type: #'AbstractInstruction *'> <var: #jumpHasFixedFields type: #'AbstractInstruction *'> <var: #convertToIntAndReturn type: #'AbstractInstruction *'> <var: #jumpArrayOutOfBounds type: #'AbstractInstruction *'> <var: #jumpBytesOutOfBounds type: #'AbstractInstruction *'> <var: #jumpShortsOutOfBounds type: #'AbstractInstruction *'> <var: #jumpWordsOutOfBounds type: #'AbstractInstruction *'> <var: #jumpMethodOutOfBounds type: #'AbstractInstruction *'> <var: #jumpFixedFieldsOutOfBounds type: #'AbstractInstruction *'> nSlotsOrBytesReg := ClassReg. cogit genLoadArgAtDepth: 0 into: Arg0Reg. jumpImmediate := self genJumpImmediate: ReceiverResultReg. cogit MoveR: Arg0Reg R: Arg1Reg. jumpBadIndex := self genJumpNotSmallInteger: Arg0Reg scratchReg: TempReg. self genConvertSmallIntegerToIntegerInReg: Arg1Reg. cogit SubCq: 1 R: Arg1Reg. "1-rel => 0-rel" "formatReg := self formatOf: ReceiverResultReg" self genGetFormatOf: ReceiverResultReg into: (formatReg := SendNumArgsReg) leastSignificantHalfOfBaseHeaderIntoScratch: TempReg. self genGetNumSlotsOf: ReceiverResultReg into: nSlotsOrBytesReg. "dispatch on format in a combination of highest dynamic frequency order first and convenience. 0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" cogit CmpCq: objectMemory firstByteFormat R: formatReg. jumpIsBytes := cogit JumpAboveOrEqual: 0. cogit CmpCq: objectMemory arrayFormat R: formatReg. jumpIsArray := cogit JumpZero: 0. jumpNotIndexable := cogit JumpBelow: 0. cogit CmpCq: objectMemory weakArrayFormat R: formatReg. jumpHasFixedFields := cogit JumpBelowOrEqual: 0. cogit CmpCq: objectMemory firstShortFormat R: formatReg. jumpIsShorts := cogit JumpAboveOrEqual: 0. cogit CmpCq: objectMemory firstLongFormat R: formatReg. jumpIsWords := cogit JumpAboveOrEqual: 0. "For now ignore 64-bit indexability." jumpNotIndexable jmpTarget: cogit Label. jumpNotIndexable := cogit Jump: 0. jumpIsArray jmpTarget: (cogit CmpR: Arg1Reg R: nSlotsOrBytesReg). jumpArrayOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddCq: objectMemory baseHeaderSize >> objectMemory shiftForWord R: Arg1Reg. cogit MoveXwr: Arg1Reg R: ReceiverResultReg R: ReceiverResultReg. cogit genPrimReturn. jumpIsBytes jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord R: nSlotsOrBytesReg). cogit AndCq: objectMemory wordSize - 1 R: formatReg R: TempReg. cogit SubR: TempReg R: nSlotsOrBytesReg; CmpR: Arg1Reg R: nSlotsOrBytesReg. jumpBytesOutOfBounds := cogit JumpBelowOrEqual: 0. cogit CmpCq: objectMemory firstCompiledMethodFormat R: formatReg. jumpIsMethod := cogit JumpAboveOrEqual: 0. methodInBounds := (cogit AddCq: objectMemory baseHeaderSize R: Arg1Reg). cogit backEnd byteReadsZeroExtend ifTrue: [cogit MoveXbr: Arg1Reg R: ReceiverResultReg R: ReceiverResultReg] ifFalse: [cogit "formatReg already contains a value <= 16r1f, so no need to zero it" MoveXbr: Arg1Reg R: ReceiverResultReg R: formatReg; MoveR: formatReg R: ReceiverResultReg]. convertToIntAndReturn := cogit Label. self genConvertIntegerToSmallIntegerInReg: ReceiverResultReg. cogit genPrimReturn. jumpIsShorts jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord - 1 R: nSlotsOrBytesReg). cogit AndCq: 1 R: formatReg. cogit SubR: formatReg R: nSlotsOrBytesReg; CmpR: Arg1Reg R: nSlotsOrBytesReg. jumpShortsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddR: Arg1Reg R: ReceiverResultReg. cogit AddR: Arg1Reg R: ReceiverResultReg. cogit MoveM16: objectMemory baseHeaderSize r: ReceiverResultReg R: ReceiverResultReg. cogit Jump: convertToIntAndReturn. jumpIsWords jmpTarget: (cogit CmpR: Arg1Reg R: nSlotsOrBytesReg). jumpWordsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddCq: objectMemory baseHeaderSize >> objectMemory shiftForWord R: Arg1Reg. cogit MoveXwr: Arg1Reg R: ReceiverResultReg R: TempReg. jumpWordTooBig := self jumpNotSmallIntegerUnsignedValueInRegister: TempReg. cogit MoveR: TempReg R: ReceiverResultReg. cogit Jump: convertToIntAndReturn. jumpHasFixedFields jmpTarget: (cogit AndCq: objectMemory classIndexMask R: TempReg). cogit MoveR: TempReg R: formatReg. cogit CmpCq: ClassMethodContextCompactIndex R: TempReg. jumpIsContext := cogit JumpZero: 0. cogit PushR: nSlotsOrBytesReg. self genGetClassObjectOfClassIndex: formatReg into: nSlotsOrBytesReg scratchReg: TempReg. self genLoadSlot: InstanceSpecificationIndex sourceReg: nSlotsOrBytesReg destReg: formatReg. cogit PopR: nSlotsOrBytesReg. self genConvertSmallIntegerToIntegerInReg: formatReg. cogit AndCq: objectMemory fixedFieldsOfClassFormatMask R: formatReg; SubR: formatReg R: nSlotsOrBytesReg; CmpR: Arg1Reg R: nSlotsOrBytesReg. jumpFixedFieldsOutOfBounds := cogit JumpBelowOrEqual: 0. "index is (formatReg (fixed fields) + Arg1Reg (0-rel index)) * wordSize + baseHeaderSize" cogit AddR: formatReg R: Arg1Reg. cogit AddCq: objectMemory baseHeaderSize >> objectMemory shiftForWord R: Arg1Reg. cogit MoveXwr: Arg1Reg R: ReceiverResultReg R: ReceiverResultReg. cogit genPrimReturn. jumpIsMethod jmpTarget: cogit Label. "Now check that the index is beyond the method's literals..." self getLiteralCountOf: ReceiverResultReg plusOne: true inBytes: true into: nSlotsOrBytesReg scratch: TempReg. cogit CmpR: Arg1Reg R: nSlotsOrBytesReg. cogit JumpBelow: methodInBounds. jumpMethodOutOfBounds := cogit Jump: 0. jumpWordTooBig jmpTarget: (jumpFixedFieldsOutOfBounds jmpTarget: (jumpArrayOutOfBounds jmpTarget: (jumpBytesOutOfBounds jmpTarget: (jumpMethodOutOfBounds jmpTarget: (jumpShortsOutOfBounds jmpTarget: (jumpWordsOutOfBounds jmpTarget: (jumpNotIndexable jmpTarget: (jumpIsContext jmpTarget: (jumpBadIndex jmpTarget: (jumpImmediate jmpTarget: cogit Label)))))))))). ^0 "Can't be complete because of contexts."! Item was changed: ----- Method: CogObjectRepresentationFor32BitSpur>>genPrimitiveAtPut (in category 'primitive generators') ----- genPrimitiveAtPut | formatReg nSlotsOrBytesReg methodInBounds jumpImmediate jumpBadIndex jumpImmutable jumpNotIndexablePointers jumpNotIndexableBits jumpIsContext jumpIsCompiledMethod jumpIsBytes jumpIsShorts jumpHasFixedFields jumpArrayOutOfBounds jumpFixedFieldsOutOfBounds jumpWordsOutOfBounds jumpShortsOutOfBounds jumpBytesOutOfBounds jumpShortsOutOfRange jumpWordsOutOfRange jumpBytesOutOfRange jumpNonSmallIntegerValue jumpNotPointers | "c.f. StackInterpreter>>stSizeOf: SpurMemoryManager>>lengthOf:format: fixedFieldsOf:format:length:" <var: #jumpIsBytes type: #'AbstractInstruction *'> <var: #jumpIsShorts type: #'AbstractInstruction *'> <var: #jumpBadIndex type: #'AbstractInstruction *'> <var: #jumpIsContext type: #'AbstractInstruction *'> <var: #jumpImmediate type: #'AbstractInstruction *'> <var: #methodInBounds type: #'AbstractInstruction *'> <var: #jumpHasFixedFields type: #'AbstractInstruction *'> <var: #jumpNotIndexableBits type: #'AbstractInstruction *'> <var: #jumpBytesOutOfRange type: #'AbstractInstruction *'> <var: #jumpWordsOutOfRange type: #'AbstractInstruction *'> <var: #jumpShortsOutOfRange type: #'AbstractInstruction *'> <var: #jumpArrayOutOfBounds type: #'AbstractInstruction *'> <var: #jumpBytesOutOfBounds type: #'AbstractInstruction *'> <var: #jumpWordsOutOfBounds type: #'AbstractInstruction *'> <var: #jumpShortsOutOfBounds type: #'AbstractInstruction *'> <var: #jumpNotIndexablePointers type: #'AbstractInstruction *'> nSlotsOrBytesReg := ClassReg. cogit genLoadArgAtDepth: 1 into: Arg0Reg. cogit genLoadArgAtDepth: 0 into: Arg1Reg. jumpImmediate := self genJumpImmediate: ReceiverResultReg. jumpBadIndex := self genJumpNotSmallInteger: Arg0Reg scratchReg: TempReg. self genConvertSmallIntegerToIntegerInReg: Arg0Reg. cogit SubCq: 1 R: Arg0Reg. "1-rel => 0-rel" "formatReg := self formatOf: ReceiverResultReg" self cppIf: IMMUTABILITY ifTrue: [ self genGetFormatOf: ReceiverResultReg into: (formatReg := SendNumArgsReg) leastSignificantHalfOfBaseHeaderIntoScratch: TempReg. jumpImmutable := self genJumpBaseHeaderImmutable: TempReg ] ifFalse: [ self genGetFormatOf: ReceiverResultReg into: (formatReg := SendNumArgsReg) leastSignificantHalfOfBaseHeaderIntoScratch: NoReg ]. self genGetNumSlotsOf: ReceiverResultReg into: nSlotsOrBytesReg. "dispatch on format in a combination of highest dynamic frequency order first and convenience. 0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" cogit CmpCq: objectMemory weakArrayFormat R: formatReg. jumpNotPointers := cogit JumpAbove: 0. "optimistic store check; assume index in range (almost always is)." self genStoreCheckReceiverReg: ReceiverResultReg valueReg: Arg1Reg scratchReg: TempReg inFrame: false. cogit CmpCq: objectMemory arrayFormat R: formatReg. jumpNotIndexablePointers := cogit JumpBelow: 0. jumpHasFixedFields := cogit JumpNonZero: 0. cogit CmpR: Arg0Reg R: nSlotsOrBytesReg. jumpArrayOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddCq: objectMemory baseHeaderSize >> objectMemory shiftForWord R: Arg0Reg. cogit MoveR: Arg1Reg Xwr: Arg0Reg R: ReceiverResultReg. cogit MoveR: Arg1Reg R: ReceiverResultReg. cogit genPrimReturn. jumpHasFixedFields jmpTarget: cogit Label. self genGetClassIndexOfNonImm: ReceiverResultReg into: formatReg. cogit CmpCq: ClassMethodContextCompactIndex R: formatReg. jumpIsContext := cogit JumpZero: 0. "get # fixed fields in formatReg" cogit PushR: nSlotsOrBytesReg. self genGetClassObjectOfClassIndex: formatReg into: nSlotsOrBytesReg scratchReg: TempReg. self genLoadSlot: InstanceSpecificationIndex sourceReg: nSlotsOrBytesReg destReg: formatReg. cogit PopR: nSlotsOrBytesReg. self genConvertSmallIntegerToIntegerInReg: formatReg. cogit AndCq: objectMemory fixedFieldsOfClassFormatMask R: formatReg. cogit SubR: formatReg R: nSlotsOrBytesReg. cogit AddCq: objectMemory baseHeaderSize >> objectMemory shiftForWord R: formatReg. cogit CmpR: Arg0Reg R: nSlotsOrBytesReg. jumpFixedFieldsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddR: formatReg R: Arg0Reg. cogit MoveR: Arg1Reg Xwr: Arg0Reg R: ReceiverResultReg. cogit MoveR: Arg1Reg R: ReceiverResultReg. cogit genPrimReturn. jumpNotPointers jmpTarget: cogit Label. jumpNonSmallIntegerValue := self genJumpNotSmallInteger: Arg1Reg scratchReg: TempReg. cogit CmpCq: objectMemory firstByteFormat R: formatReg. jumpIsBytes := cogit JumpAboveOrEqual: 0. cogit CmpCq: objectMemory firstShortFormat R: formatReg. jumpIsShorts := cogit JumpAboveOrEqual: 0. cogit CmpCq: objectMemory firstLongFormat R: formatReg. "For now ignore 64-bit indexability." jumpNotIndexableBits := cogit JumpBelow: 0. "fall through to double words" cogit CmpR: Arg0Reg R: nSlotsOrBytesReg. jumpWordsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit MoveR: Arg1Reg R: TempReg. self genConvertSmallIntegerToIntegerInReg: TempReg. (cogit lastOpcode setsConditionCodesFor: JumpLess) ifFalse: [cogit CmpCq: 0 R: TempReg]. "N.B. FLAGS := TempReg - 0" jumpWordsOutOfRange := cogit JumpLess: 0. cogit AddCq: objectMemory baseHeaderSize >> objectMemory shiftForWord R: Arg0Reg. cogit MoveR: TempReg Xwr: Arg0Reg R: ReceiverResultReg. cogit MoveR: Arg1Reg R: ReceiverResultReg. cogit genPrimReturn. jumpIsBytes jmpTarget: (cogit CmpCq: (objectMemory integerObjectOf: 255) R: Arg1Reg). jumpBytesOutOfRange := cogit JumpAbove: 0. cogit LogicalShiftLeftCq: objectMemory shiftForWord R: nSlotsOrBytesReg. cogit AndCq: objectMemory wordSize - 1 R: formatReg R: TempReg. cogit SubR: TempReg R: nSlotsOrBytesReg. cogit CmpR: Arg0Reg R: nSlotsOrBytesReg. jumpBytesOutOfBounds := cogit JumpBelowOrEqual: 0. cogit CmpCq: objectMemory firstCompiledMethodFormat R: formatReg. jumpIsCompiledMethod := cogit JumpAboveOrEqual: 0. methodInBounds := cogit MoveR: Arg1Reg R: TempReg. self genConvertSmallIntegerToIntegerInReg: TempReg. cogit AddCq: objectMemory baseHeaderSize R: Arg0Reg. cogit MoveR: TempReg Xbr: Arg0Reg R: ReceiverResultReg. cogit MoveR: Arg1Reg R: ReceiverResultReg. cogit genPrimReturn. jumpIsShorts jmpTarget: (cogit CmpCq: (objectMemory integerObjectOf: 65535) R: Arg1Reg). jumpShortsOutOfRange := cogit JumpAbove: 0. cogit LogicalShiftLeftCq: objectMemory shiftForWord - 1 R: nSlotsOrBytesReg. cogit AndCq: objectMemory wordSize / 2 - 1 R: formatReg. cogit SubR: formatReg R: nSlotsOrBytesReg. cogit CmpR: Arg0Reg R: nSlotsOrBytesReg. jumpShortsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit MoveR: Arg1Reg R: TempReg. self genConvertSmallIntegerToIntegerInReg: TempReg. cogit AddR: Arg0Reg R: ReceiverResultReg. cogit AddR: Arg0Reg R: ReceiverResultReg. cogit MoveR: TempReg M16: objectMemory baseHeaderSize r: ReceiverResultReg. cogit MoveR: Arg1Reg R: ReceiverResultReg. cogit genPrimReturn. "Now check that the index is beyond the method's literals..." jumpIsCompiledMethod jmpTarget: cogit Label. self getLiteralCountOf: ReceiverResultReg plusOne: true inBytes: true into: nSlotsOrBytesReg scratch: TempReg. cogit CmpR: Arg0Reg R: nSlotsOrBytesReg. cogit JumpBelow: methodInBounds. jumpIsContext jmpTarget: (jumpNotIndexableBits jmpTarget: (jumpBytesOutOfRange jmpTarget: (jumpWordsOutOfRange jmpTarget: (jumpShortsOutOfRange jmpTarget: (jumpIsCompiledMethod jmpTarget: (jumpArrayOutOfBounds jmpTarget: (jumpBytesOutOfBounds jmpTarget: (jumpShortsOutOfBounds jmpTarget: (jumpWordsOutOfBounds jmpTarget: (jumpNotIndexablePointers jmpTarget: (jumpNonSmallIntegerValue jmpTarget: (jumpFixedFieldsOutOfBounds jmpTarget: cogit Label)))))))))))). self cppIf: IMMUTABILITY ifTrue: [jumpImmutable jmpTarget: jumpIsContext getJmpTarget]. cogit AddCq: 1 R: Arg0Reg. "0-rel => 1-rel" self genConvertIntegerToSmallIntegerInReg: Arg0Reg. jumpBadIndex jmpTarget: (jumpImmediate jmpTarget: cogit Label). ^0 "Can't be complete because of contexts."! Item was changed: ----- Method: CogObjectRepresentationFor32BitSpur>>genPrimitiveStringAt (in category 'primitive generators') ----- genPrimitiveStringAt | formatReg jumpNotIndexable jumpBadIndex done jumpIsBytes jumpIsShorts jumpWordTooBig jumpWordsDone jumpBytesOutOfBounds jumpShortsOutOfBounds jumpWordsOutOfBounds | "c.f. StackInterpreter>>stSizeOf: SpurMemoryManager>>lengthOf:format: fixedFieldsOf:format:length:" <var: #done type: #'AbstractInstruction *'> <var: #jumpIsBytes type: #'AbstractInstruction *'> <var: #jumpIsShorts type: #'AbstractInstruction *'> <var: #jumpBadIndex type: #'AbstractInstruction *'> <var: #jumpWordsDone type: #'AbstractInstruction *'> <var: #jumpWordTooBig type: #'AbstractInstruction *'> <var: #jumpNotIndexable type: #'AbstractInstruction *'> <var: #jumpBytesOutOfBounds type: #'AbstractInstruction *'> <var: #jumpShortsOutOfBounds type: #'AbstractInstruction *'> <var: #jumpWordsOutOfBounds type: #'AbstractInstruction *'> cogit genLoadArgAtDepth: 0 into: Arg0Reg. cogit MoveR: Arg0Reg R: Arg1Reg. jumpBadIndex := self genJumpNotSmallInteger: Arg0Reg scratchReg: TempReg. self genConvertSmallIntegerToIntegerInReg: Arg1Reg. cogit SubCq: 1 R: Arg1Reg. "1-rel => 0-rel" self genGetFormatOf: ReceiverResultReg into: (formatReg := SendNumArgsReg) leastSignificantHalfOfBaseHeaderIntoScratch: NoReg. self genGetNumSlotsOf: ReceiverResultReg into: ClassReg. "dispatch on format in a combination of highest dynamic frequency order first and convenience. 0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" cogit CmpCq: objectMemory firstByteFormat R: formatReg. jumpIsBytes := cogit JumpGreaterOrEqual: 0. cogit CmpCq: objectMemory firstShortFormat R: formatReg. jumpIsShorts := cogit JumpGreaterOrEqual: 0. cogit CmpCq: objectMemory firstLongFormat R: formatReg. jumpNotIndexable := cogit JumpLess: 0. "fall through to double words" cogit CmpR: Arg1Reg R: ClassReg. jumpWordsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddCq: objectMemory baseHeaderSize >> objectMemory shiftForWord R: Arg1Reg. cogit MoveXwr: Arg1Reg R: ReceiverResultReg R: TempReg. jumpWordTooBig := self jumpNotCharacterUnsignedValueInRegister: TempReg. cogit MoveR: TempReg R: ReceiverResultReg. jumpWordsDone := cogit Jump: 0. jumpIsBytes jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord R: ClassReg). cogit AndCq: objectMemory wordSize - 1 R: formatReg. cogit SubR: formatReg R: ClassReg. cogit CmpR: Arg1Reg R: ClassReg. jumpBytesOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddCq: objectMemory baseHeaderSize R: Arg1Reg. cogit MoveXbr: Arg1Reg R: ReceiverResultReg R: ReceiverResultReg. cogit backEnd byteReadsZeroExtend ifFalse: [cogit AndCq: 255 R: ReceiverResultReg]. jumpWordsDone jmpTarget: (done := cogit Label). self genConvertIntegerToCharacterInReg: ReceiverResultReg. cogit genPrimReturn. jumpIsShorts jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord - 1 R: ClassReg). cogit AndCq: objectMemory wordSize / 1 - 1 R: formatReg. cogit SubR: formatReg R: ClassReg. cogit CmpR: Arg1Reg R: ClassReg. jumpShortsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddR: Arg1Reg R: ReceiverResultReg. cogit MoveM16: objectMemory baseHeaderSize r: ReceiverResultReg R: ReceiverResultReg. cogit Jump: done. jumpWordTooBig jmpTarget: (jumpBytesOutOfBounds jmpTarget: (jumpShortsOutOfBounds jmpTarget: (jumpWordsOutOfBounds jmpTarget: (jumpNotIndexable jmpTarget: (jumpBadIndex jmpTarget: cogit Label))))). ^CompletePrimitive! Item was changed: ----- Method: CogObjectRepresentationFor32BitSpur>>genPrimitiveStringAtPut (in category 'primitive generators') ----- genPrimitiveStringAtPut | formatReg jumpBadIndex jumpBadArg jumpImmutable jumpIsBytes jumpIsShorts jumpNotString jumpIsCompiledMethod jumpBytesOutOfRange jumpShortsOutOfRange jumpWordsOutOfRange jumpBytesOutOfBounds jumpWordsOutOfBounds jumpShortsOutOfBounds | "c.f. StackInterpreter>>stSizeOf: SpurMemoryManager>>lengthOf:format: fixedFieldsOf:format:length:" <var: #jumpBadArg type: #'AbstractInstruction *'> <var: #jumpIsBytes type: #'AbstractInstruction *'> <var: #jumpIsShorts type: #'AbstractInstruction *'> <var: #jumpBadIndex type: #'AbstractInstruction *'> <var: #jumpBytesOutOfRange type: #'AbstractInstruction *'> <var: #jumpShortsOutOfRange type: #'AbstractInstruction *'> <var: #jumpWordsOutOfRange type: #'AbstractInstruction *'> <var: #jumpBytesOutOfBounds type: #'AbstractInstruction *'> <var: #jumpShortsOutOfBounds type: #'AbstractInstruction *'> <var: #jumpWordsOutOfBounds type: #'AbstractInstruction *'> cogit genLoadArgAtDepth: 1 into: Arg0Reg. cogit genLoadArgAtDepth: 0 into: Arg1Reg. jumpBadIndex := self genJumpNotSmallInteger: Arg0Reg. cogit MoveR: Arg1Reg R: TempReg. jumpBadArg := self genJumpNotCharacterInScratchReg: TempReg. self genConvertSmallIntegerToIntegerInReg: Arg0Reg. cogit SubCq: 1 R: Arg0Reg. "1-rel => 0-rel" "formatReg := self formatOf: ReceiverResultReg" self cppIf: IMMUTABILITY ifTrue: [ self genGetFormatOf: ReceiverResultReg into: (formatReg := SendNumArgsReg) leastSignificantHalfOfBaseHeaderIntoScratch: TempReg. jumpImmutable := self genJumpBaseHeaderImmutable: TempReg ] ifFalse: [ self genGetFormatOf: ReceiverResultReg into: (formatReg := SendNumArgsReg) leastSignificantHalfOfBaseHeaderIntoScratch: NoReg ]. self genGetNumSlotsOf: ReceiverResultReg into: ClassReg. "dispatch on format; words and/or bytes. 0 to 8 = pointer objects, forwarders, reserved. + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" cogit CmpCq: objectMemory firstLongFormat R: formatReg. jumpNotString := cogit JumpBelow: 0. cogit CmpCq: objectMemory firstCompiledMethodFormat R: formatReg. jumpIsCompiledMethod := cogit JumpAboveOrEqual: 0. cogit CmpCq: objectMemory firstByteFormat R: formatReg. jumpIsBytes := cogit JumpAboveOrEqual: 0. cogit CmpCq: objectMemory firstShortFormat R: formatReg. jumpIsShorts := cogit JumpAboveOrEqual: 0. "fall through to double words" cogit CmpCq: 0 R: Arg1Reg. jumpWordsOutOfRange := cogit JumpLess: 0. cogit CmpR: Arg0Reg R: ClassReg. jumpWordsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit MoveR: Arg1Reg R: TempReg. self genConvertCharacterToCodeInReg: TempReg. cogit AddCq: objectMemory baseHeaderSize >> objectMemory shiftForWord R: Arg0Reg. cogit MoveR: TempReg Xwr: Arg0Reg R: ReceiverResultReg. cogit MoveR: Arg1Reg R: ReceiverResultReg. cogit genPrimReturn. jumpIsShorts jmpTarget: (cogit CmpCq: (objectMemory characterObjectOf: 65535) R: Arg1Reg). jumpShortsOutOfRange := cogit JumpAbove: 0. cogit LogicalShiftLeftCq: objectMemory shiftForWord - 1 R: ClassReg. cogit AndCq: objectMemory wordSize / 2 - 1 R: formatReg. cogit SubR: formatReg R: ClassReg. cogit CmpR: Arg0Reg R: ClassReg. jumpShortsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit MoveR: Arg1Reg R: TempReg. self genConvertCharacterToCodeInReg: TempReg. cogit AddR: Arg0Reg R: ReceiverResultReg. cogit MoveR: TempReg M16: objectMemory baseHeaderSize r: ReceiverResultReg. cogit MoveR: Arg1Reg R: ReceiverResultReg. cogit genPrimReturn. jumpIsBytes jmpTarget: (cogit CmpCq: (objectMemory characterObjectOf: 255) R: Arg1Reg). jumpBytesOutOfRange := cogit JumpAbove: 0. cogit LogicalShiftLeftCq: objectMemory shiftForWord R: ClassReg. cogit AndCq: objectMemory wordSize - 1 R: formatReg. cogit SubR: formatReg R: ClassReg. cogit CmpR: Arg0Reg R: ClassReg. jumpBytesOutOfBounds := cogit JumpBelowOrEqual: 0. cogit MoveR: Arg1Reg R: TempReg. self genConvertCharacterToCodeInReg: TempReg. cogit AddCq: objectMemory baseHeaderSize R: Arg0Reg. cogit MoveR: TempReg Xbr: Arg0Reg R: ReceiverResultReg. cogit MoveR: Arg1Reg R: ReceiverResultReg. cogit genPrimReturn. jumpNotString jmpTarget: (jumpBytesOutOfRange jmpTarget: (jumpShortsOutOfRange jmpTarget: (jumpWordsOutOfRange jmpTarget: (jumpIsCompiledMethod jmpTarget: (jumpBytesOutOfBounds jmpTarget: (jumpShortsOutOfBounds jmpTarget: (jumpWordsOutOfBounds jmpTarget: cogit Label))))))). self cppIf: IMMUTABILITY ifTrue: [jumpImmutable jmpTarget: jumpNotString getJmpTarget]. cogit AddCq: 1 R: Arg0Reg. "0-rel => 1-rel" self genConvertIntegerToSmallIntegerInReg: Arg0Reg. jumpBadArg jmpTarget: (jumpBadIndex jmpTarget: cogit Label). ^CompletePrimitive! Item was changed: ----- Method: CogObjectRepresentationFor64BitSpur>>genPrimitiveAt (in category 'primitive generators') ----- genPrimitiveAt | formatReg nSlotsOrBytesReg convertToIntAndReturn methodInBounds jumpNotIndexable jumpImmediate jumpBadIndex jumpIsBytes jumpIsShorts jumpIsWords jumpIsMethod jumpIsArray jumpIsContext jumpHasFixedFields jumpArrayOutOfBounds jumpFixedFieldsOutOfBounds jumpBytesOutOfBounds jumpShortsOutOfBounds jumpWordsOutOfBounds | "c.f. StackInterpreter>>stSizeOf: SpurMemoryManager>>lengthOf:format: fixedFieldsOf:format:length:" <var: #jumpIsBytes type: #'AbstractInstruction *'> <var: #jumpIsShorts type: #'AbstractInstruction *'> <var: #jumpBadIndex type: #'AbstractInstruction *'> <var: #jumpIsMethod type: #'AbstractInstruction *'> <var: #jumpIsContext type: #'AbstractInstruction *'> <var: #jumpImmediate type: #'AbstractInstruction *'> <var: #methodInBounds type: #'AbstractInstruction *'> <var: #jumpNotIndexable type: #'AbstractInstruction *'> <var: #jumpHasFixedFields type: #'AbstractInstruction *'> <var: #convertToIntAndReturn type: #'AbstractInstruction *'> <var: #jumpArrayOutOfBounds type: #'AbstractInstruction *'> <var: #jumpBytesOutOfBounds type: #'AbstractInstruction *'> <var: #jumpShortsOutOfBounds type: #'AbstractInstruction *'> <var: #jumpWordsOutOfBounds type: #'AbstractInstruction *'> <var: #jumpFixedFieldsOutOfBounds type: #'AbstractInstruction *'> nSlotsOrBytesReg := ClassReg. cogit genLoadArgAtDepth: 0 into: Arg0Reg. jumpImmediate := self genJumpImmediate: ReceiverResultReg. cogit MoveR: Arg0Reg R: Arg1Reg. jumpBadIndex := self genJumpNotSmallInteger: Arg0Reg scratchReg: TempReg. self genConvertSmallIntegerToIntegerInReg: Arg1Reg. cogit SubCq: 1 R: Arg1Reg. "1-rel => 0-rel" "formatReg := self formatOf: ReceiverResultReg" self genGetFormatOf: ReceiverResultReg into: (formatReg := SendNumArgsReg) leastSignificantHalfOfBaseHeaderIntoScratch: TempReg. self genGetNumSlotsOf: ReceiverResultReg into: nSlotsOrBytesReg. "dispatch on format in a combination of highest dynamic frequency order first and convenience. 0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" cogit CmpCq: objectMemory firstByteFormat R: formatReg. jumpIsBytes := cogit JumpAboveOrEqual: 0. cogit CmpCq: objectMemory arrayFormat R: formatReg. jumpIsArray := cogit JumpZero: 0. jumpNotIndexable := cogit JumpBelow: 0. cogit CmpCq: objectMemory weakArrayFormat R: formatReg. jumpHasFixedFields := cogit JumpBelowOrEqual: 0. cogit CmpCq: objectMemory firstShortFormat R: formatReg. jumpIsShorts := cogit JumpAboveOrEqual: 0. cogit CmpCq: objectMemory firstLongFormat R: formatReg. jumpIsWords := cogit JumpAboveOrEqual: 0. "For now ignore 64-bit indexability." jumpNotIndexable jmpTarget: cogit Label. jumpNotIndexable := cogit Jump: 0. jumpIsArray jmpTarget: (cogit CmpR: Arg1Reg R: nSlotsOrBytesReg). jumpArrayOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddCq: objectMemory baseHeaderSize >> objectMemory shiftForWord R: Arg1Reg. cogit MoveXwr: Arg1Reg R: ReceiverResultReg R: ReceiverResultReg. cogit genPrimReturn. jumpIsBytes jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord R: nSlotsOrBytesReg). cogit AndCq: objectMemory wordSize - 1 R: formatReg R: TempReg. cogit SubR: TempReg R: nSlotsOrBytesReg; CmpR: Arg1Reg R: nSlotsOrBytesReg. jumpBytesOutOfBounds := cogit JumpBelowOrEqual: 0. cogit CmpCq: objectMemory firstCompiledMethodFormat R: formatReg. jumpIsMethod := cogit JumpAboveOrEqual: 0. methodInBounds := (cogit AddCq: objectMemory baseHeaderSize R: Arg1Reg). cogit backEnd byteReadsZeroExtend ifTrue: [cogit MoveXbr: Arg1Reg R: ReceiverResultReg R: ReceiverResultReg] ifFalse: [cogit "formatReg already contains a value <= 16r1f, so no need to zero it" MoveXbr: Arg1Reg R: ReceiverResultReg R: formatReg; MoveR: formatReg R: ReceiverResultReg]. convertToIntAndReturn := cogit Label. self genConvertIntegerToSmallIntegerInReg: ReceiverResultReg. cogit genPrimReturn. jumpIsShorts jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord - 1 R: nSlotsOrBytesReg). cogit AndCq: 1 R: formatReg. cogit SubR: formatReg R: nSlotsOrBytesReg; CmpR: Arg1Reg R: nSlotsOrBytesReg. jumpShortsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddR: Arg1Reg R: ReceiverResultReg. cogit AddR: Arg1Reg R: ReceiverResultReg. cogit MoveM16: objectMemory baseHeaderSize r: ReceiverResultReg R: ReceiverResultReg. cogit Jump: convertToIntAndReturn. jumpIsWords jmpTarget: (cogit CmpR: Arg1Reg R: nSlotsOrBytesReg). jumpWordsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddCq: objectMemory baseHeaderSize >> (objectMemory shiftForWord - 1) R: Arg1Reg. cogit MoveX32r: Arg1Reg R: ReceiverResultReg R: TempReg. cogit MoveR: TempReg R: ReceiverResultReg. cogit Jump: convertToIntAndReturn. jumpHasFixedFields jmpTarget: (cogit AndCq: objectMemory classIndexMask R: TempReg). cogit MoveR: TempReg R: formatReg. cogit CmpCq: ClassMethodContextCompactIndex R: TempReg. jumpIsContext := cogit JumpZero: 0. self genGetClassObjectOfClassIndex: formatReg into: Extra0Reg scratchReg: TempReg. self genLoadSlot: InstanceSpecificationIndex sourceReg: Extra0Reg destReg: formatReg. self genConvertSmallIntegerToIntegerInReg: formatReg. cogit AndCq: objectMemory fixedFieldsOfClassFormatMask R: formatReg; SubR: formatReg R: nSlotsOrBytesReg; CmpR: Arg1Reg R: nSlotsOrBytesReg. jumpFixedFieldsOutOfBounds := cogit JumpBelowOrEqual: 0. "index is (formatReg (fixed fields) + Arg1Reg (0-rel index)) * wordSize + baseHeaderSize" cogit AddR: formatReg R: Arg1Reg. cogit AddCq: objectMemory baseHeaderSize >> objectMemory shiftForWord R: Arg1Reg. cogit MoveXwr: Arg1Reg R: ReceiverResultReg R: ReceiverResultReg. cogit genPrimReturn. jumpIsMethod jmpTarget: cogit Label. "Now check that the index is beyond the method's literals..." self getLiteralCountOf: ReceiverResultReg plusOne: true inBytes: true into: nSlotsOrBytesReg scratch: TempReg. cogit CmpR: Arg1Reg R: nSlotsOrBytesReg. cogit JumpBelow: methodInBounds. jumpFixedFieldsOutOfBounds jmpTarget: (jumpArrayOutOfBounds jmpTarget: (jumpBytesOutOfBounds jmpTarget: (jumpShortsOutOfBounds jmpTarget: (jumpWordsOutOfBounds jmpTarget: (jumpNotIndexable jmpTarget: (jumpIsContext jmpTarget: (jumpBadIndex jmpTarget: (jumpImmediate jmpTarget: cogit Label)))))))). ^0! Item was changed: ----- Method: CogObjectRepresentationFor64BitSpur>>genPrimitiveAtPut (in category 'primitive generators') ----- genPrimitiveAtPut | formatReg nSlotsOrBytesReg methodInBounds jumpImmediate jumpBadIndex jumpImmutable jumpNotIndexablePointers jumpNotIndexableBits jumpIsContext jumpIsCompiledMethod jumpIsBytes jumpIsShorts jumpHasFixedFields jumpArrayOutOfBounds jumpFixedFieldsOutOfBounds jumpWordsOutOfBounds jumpShortsOutOfBounds jumpBytesOutOfBounds jumpShortsOutOfRange jumpWordsOutOfRange jumpBytesOutOfRange jumpNonSmallIntegerValue jumpNotPointers | "c.f. StackInterpreter>>stSizeOf: SpurMemoryManager>>lengthOf:format: fixedFieldsOf:format:length:" <var: #jumpIsBytes type: #'AbstractInstruction *'> <var: #jumpIsShorts type: #'AbstractInstruction *'> <var: #jumpBadIndex type: #'AbstractInstruction *'> <var: #jumpIsContext type: #'AbstractInstruction *'> <var: #jumpImmediate type: #'AbstractInstruction *'> <var: #methodInBounds type: #'AbstractInstruction *'> <var: #jumpHasFixedFields type: #'AbstractInstruction *'> <var: #jumpNotIndexableBits type: #'AbstractInstruction *'> <var: #jumpBytesOutOfRange type: #'AbstractInstruction *'> <var: #jumpWordsOutOfRange type: #'AbstractInstruction *'> <var: #jumpShortsOutOfRange type: #'AbstractInstruction *'> <var: #jumpArrayOutOfBounds type: #'AbstractInstruction *'> <var: #jumpBytesOutOfBounds type: #'AbstractInstruction *'> <var: #jumpWordsOutOfBounds type: #'AbstractInstruction *'> <var: #jumpShortsOutOfBounds type: #'AbstractInstruction *'> <var: #jumpNotIndexablePointers type: #'AbstractInstruction *'> nSlotsOrBytesReg := ClassReg. cogit genLoadArgAtDepth: 1 into: Arg0Reg. cogit genLoadArgAtDepth: 0 into: Arg1Reg. jumpImmediate := self genJumpImmediate: ReceiverResultReg. jumpBadIndex := self genJumpNotSmallInteger: Arg0Reg scratchReg: TempReg. self genConvertSmallIntegerToIntegerInReg: Arg0Reg. cogit SubCq: 1 R: Arg0Reg. "1-rel => 0-rel" "formatReg := self formatOf: ReceiverResultReg" self cppIf: IMMUTABILITY ifTrue: [ self genGetFormatOf: ReceiverResultReg into: (formatReg := SendNumArgsReg) leastSignificantHalfOfBaseHeaderIntoScratch: TempReg. jumpImmutable := self genJumpBaseHeaderImmutable: TempReg ] ifFalse: [ self genGetFormatOf: ReceiverResultReg into: (formatReg := SendNumArgsReg) leastSignificantHalfOfBaseHeaderIntoScratch: NoReg ]. self genGetNumSlotsOf: ReceiverResultReg into: nSlotsOrBytesReg. "dispatch on format in a combination of highest dynamic frequency order first and convenience. 0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" cogit CmpCq: objectMemory weakArrayFormat R: formatReg. jumpNotPointers := cogit JumpAbove: 0. "optimistic store check; assume index in range (almost always is)." self genStoreCheckReceiverReg: ReceiverResultReg valueReg: Arg1Reg scratchReg: TempReg inFrame: false. cogit CmpCq: objectMemory arrayFormat R: formatReg. jumpNotIndexablePointers := cogit JumpBelow: 0. jumpHasFixedFields := cogit JumpNonZero: 0. cogit CmpR: Arg0Reg R: nSlotsOrBytesReg. jumpArrayOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddCq: objectMemory baseHeaderSize >> objectMemory shiftForWord R: Arg0Reg. cogit MoveR: Arg1Reg Xwr: Arg0Reg R: ReceiverResultReg. cogit MoveR: Arg1Reg R: ReceiverResultReg. cogit genPrimReturn. jumpHasFixedFields jmpTarget: cogit Label. self genGetClassIndexOfNonImm: ReceiverResultReg into: formatReg. cogit CmpCq: ClassMethodContextCompactIndex R: formatReg. jumpIsContext := cogit JumpZero: 0. "get # fixed fields in formatReg" self genGetClassObjectOfClassIndex: formatReg into: Extra0Reg scratchReg: TempReg. self genLoadSlot: InstanceSpecificationIndex sourceReg: Extra0Reg destReg: formatReg. self genConvertSmallIntegerToIntegerInReg: formatReg. cogit AndCq: objectMemory fixedFieldsOfClassFormatMask R: formatReg. cogit SubR: formatReg R: nSlotsOrBytesReg. cogit AddCq: objectMemory baseHeaderSize >> objectMemory shiftForWord R: formatReg. cogit CmpR: Arg0Reg R: nSlotsOrBytesReg. jumpFixedFieldsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddR: formatReg R: Arg0Reg. cogit MoveR: Arg1Reg Xwr: Arg0Reg R: ReceiverResultReg. cogit MoveR: Arg1Reg R: ReceiverResultReg. cogit genPrimReturn. jumpNotPointers jmpTarget: cogit Label. jumpNonSmallIntegerValue := self genJumpNotSmallInteger: Arg1Reg scratchReg: TempReg. cogit CmpCq: objectMemory firstByteFormat R: formatReg. jumpIsBytes := cogit JumpAboveOrEqual: 0. cogit CmpCq: objectMemory firstShortFormat R: formatReg. jumpIsShorts := cogit JumpAboveOrEqual: 0. cogit CmpCq: objectMemory firstLongFormat R: formatReg. "For now ignore 64-bit indexability." jumpNotIndexableBits := cogit JumpBelow: 0. "fall through to words" cogit CmpCq: (objectMemory integerObjectOf: 16rFFFFFFFF) R: Arg1Reg. jumpWordsOutOfRange := cogit JumpAbove: 0. cogit LogicalShiftLeftCq: objectMemory shiftForWord - 2 R: nSlotsOrBytesReg. cogit AndCq: objectMemory wordSize / 4 - 1 R: formatReg. cogit SubR: formatReg R: nSlotsOrBytesReg. cogit CmpR: Arg0Reg R: nSlotsOrBytesReg. jumpWordsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit MoveR: Arg1Reg R: TempReg. self genConvertSmallIntegerToIntegerInReg: TempReg. cogit AddCq: objectMemory baseHeaderSize >> (objectMemory shiftForWord - 1) R: Arg0Reg. cogit MoveR: TempReg X32r: Arg0Reg R: ReceiverResultReg. cogit MoveR: Arg1Reg R: ReceiverResultReg. cogit genPrimReturn. jumpIsBytes jmpTarget: (cogit CmpCq: (objectMemory integerObjectOf: 255) R: Arg1Reg). jumpBytesOutOfRange := cogit JumpAbove: 0. cogit LogicalShiftLeftCq: objectMemory shiftForWord R: nSlotsOrBytesReg. cogit AndCq: objectMemory wordSize - 1 R: formatReg R: TempReg. cogit SubR: TempReg R: nSlotsOrBytesReg. cogit CmpR: Arg0Reg R: nSlotsOrBytesReg. jumpBytesOutOfBounds := cogit JumpBelowOrEqual: 0. cogit CmpCq: objectMemory firstCompiledMethodFormat R: formatReg. jumpIsCompiledMethod := cogit JumpAboveOrEqual: 0. methodInBounds := cogit MoveR: Arg1Reg R: TempReg. self genConvertSmallIntegerToIntegerInReg: TempReg. cogit AddCq: objectMemory baseHeaderSize R: Arg0Reg. cogit MoveR: TempReg Xbr: Arg0Reg R: ReceiverResultReg. cogit MoveR: Arg1Reg R: ReceiverResultReg. cogit genPrimReturn. jumpIsShorts jmpTarget: (cogit CmpCq: (objectMemory integerObjectOf: 65535) R: Arg1Reg). jumpShortsOutOfRange := cogit JumpAbove: 0. cogit LogicalShiftLeftCq: objectMemory shiftForWord - 1 R: nSlotsOrBytesReg. cogit AndCq: objectMemory wordSize / 2 - 1 R: formatReg. cogit SubR: formatReg R: nSlotsOrBytesReg. cogit CmpR: Arg0Reg R: nSlotsOrBytesReg. jumpShortsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit MoveR: Arg1Reg R: TempReg. self genConvertSmallIntegerToIntegerInReg: TempReg. cogit AddR: Arg0Reg R: ReceiverResultReg. cogit AddR: Arg0Reg R: ReceiverResultReg. cogit MoveR: TempReg M16: objectMemory baseHeaderSize r: ReceiverResultReg. cogit MoveR: Arg1Reg R: ReceiverResultReg. cogit genPrimReturn. "Now check that the index is beyond the method's literals..." jumpIsCompiledMethod jmpTarget: cogit Label. self getLiteralCountOf: ReceiverResultReg plusOne: true inBytes: true into: nSlotsOrBytesReg scratch: TempReg. cogit CmpR: Arg0Reg R: nSlotsOrBytesReg. cogit JumpBelow: methodInBounds. jumpIsContext jmpTarget: (jumpNotIndexableBits jmpTarget: (jumpBytesOutOfRange jmpTarget: (jumpShortsOutOfRange jmpTarget: (jumpWordsOutOfRange jmpTarget: (jumpIsCompiledMethod jmpTarget: (jumpArrayOutOfBounds jmpTarget: (jumpBytesOutOfBounds jmpTarget: (jumpShortsOutOfBounds jmpTarget: (jumpWordsOutOfBounds jmpTarget: (jumpNotIndexablePointers jmpTarget: (jumpNonSmallIntegerValue jmpTarget: (jumpFixedFieldsOutOfBounds jmpTarget: cogit Label)))))))))))). self cppIf: IMMUTABILITY ifTrue: [jumpImmutable jmpTarget: jumpIsContext getJmpTarget]. cogit AddCq: 1 R: Arg0Reg. "0-rel => 1-rel" self genConvertIntegerToSmallIntegerInReg: Arg0Reg. jumpBadIndex jmpTarget: (jumpImmediate jmpTarget: cogit Label). ^0 "Can't be complete because of contexts."! Item was changed: ----- Method: CogObjectRepresentationFor64BitSpur>>genPrimitiveStringAt (in category 'primitive generators') ----- genPrimitiveStringAt | formatReg jumpNotIndexable jumpBadIndex done jumpIsBytes jumpIsShorts jumpWordTooBig jumpWordsDone jumpBytesOutOfBounds jumpShortsOutOfBounds jumpWordsOutOfBounds | "c.f. StackInterpreter>>stSizeOf: SpurMemoryManager>>lengthOf:format: fixedFieldsOf:format:length:" <var: #done type: #'AbstractInstruction *'> <var: #jumpIsBytes type: #'AbstractInstruction *'> <var: #jumpIsShorts type: #'AbstractInstruction *'> <var: #jumpBadIndex type: #'AbstractInstruction *'> <var: #jumpWordsDone type: #'AbstractInstruction *'> <var: #jumpWordTooBig type: #'AbstractInstruction *'> <var: #jumpNotIndexable type: #'AbstractInstruction *'> <var: #jumpBytesOutOfBounds type: #'AbstractInstruction *'> <var: #jumpShortsOutOfBounds type: #'AbstractInstruction *'> <var: #jumpWordsOutOfBounds type: #'AbstractInstruction *'> cogit genLoadArgAtDepth: 0 into: Arg0Reg. cogit MoveR: Arg0Reg R: Arg1Reg. jumpBadIndex := self genJumpNotSmallInteger: Arg0Reg scratchReg: TempReg. self genConvertSmallIntegerToIntegerInReg: Arg1Reg. cogit SubCq: 1 R: Arg1Reg. "1-rel => 0-rel" self genGetFormatOf: ReceiverResultReg into: (formatReg := SendNumArgsReg) leastSignificantHalfOfBaseHeaderIntoScratch: NoReg. self genGetNumSlotsOf: ReceiverResultReg into: ClassReg. "dispatch on format in a combination of highest dynamic frequency order first and convenience. 0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" cogit CmpCq: objectMemory firstByteFormat R: formatReg. jumpIsBytes := cogit JumpGreaterOrEqual: 0. cogit CmpCq: objectMemory firstShortFormat R: formatReg. jumpIsShorts := cogit JumpGreaterOrEqual: 0. cogit CmpCq: objectMemory firstLongFormat R: formatReg. jumpNotIndexable := cogit JumpLess: 0. "fall through to double words" cogit LogicalShiftLeftCq: objectMemory shiftForWord - 2 R: ClassReg. cogit AndCq: objectMemory wordSize / 4 - 1 R: formatReg. cogit SubR: formatReg R: ClassReg. cogit CmpR: Arg1Reg R: ClassReg. jumpWordsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddCq: objectMemory baseHeaderSize >> (objectMemory shiftForWord - 1) R: Arg1Reg. cogit MoveX32r: Arg1Reg R: ReceiverResultReg R: TempReg. jumpWordTooBig := self jumpNotCharacterUnsignedValueInRegister: TempReg. cogit MoveR: TempReg R: ReceiverResultReg. jumpWordsDone := cogit Jump: 0. jumpIsBytes jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord R: ClassReg). cogit AndCq: objectMemory wordSize - 1 R: formatReg. cogit SubR: formatReg R: ClassReg. cogit CmpR: Arg1Reg R: ClassReg. jumpBytesOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddCq: objectMemory baseHeaderSize R: Arg1Reg. cogit MoveXbr: Arg1Reg R: ReceiverResultReg R: ReceiverResultReg. cogit backEnd byteReadsZeroExtend ifFalse: [cogit AndCq: 255 R: ReceiverResultReg]. jumpWordsDone jmpTarget: (done := cogit Label). self genConvertIntegerToCharacterInReg: ReceiverResultReg. cogit genPrimReturn. jumpIsShorts jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord - 1 R: ClassReg). cogit AndCq: objectMemory wordSize / 2 - 1 R: formatReg. cogit SubR: formatReg R: ClassReg. cogit CmpR: Arg1Reg R: ClassReg. jumpShortsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddR: Arg1Reg R: ReceiverResultReg. cogit MoveM16: objectMemory baseHeaderSize r: ReceiverResultReg R: ReceiverResultReg. cogit Jump: done. jumpWordTooBig jmpTarget: (jumpBytesOutOfBounds jmpTarget: (jumpShortsOutOfBounds jmpTarget: (jumpWordsOutOfBounds jmpTarget: (jumpNotIndexable jmpTarget: (jumpBadIndex jmpTarget: cogit Label))))). ^CompletePrimitive! Item was changed: ----- Method: CogObjectRepresentationFor64BitSpur>>genPrimitiveStringAtPut (in category 'primitive generators') ----- genPrimitiveStringAtPut | formatReg jumpBadIndex jumpBadArg jumpImmutable jumpIsBytes jumpIsShorts jumpNotString jumpIsCompiledMethod jumpBytesOutOfRange jumpShortsOutOfRange jumpWordsOutOfRange jumpBytesOutOfBounds jumpWordsOutOfBounds jumpShortsOutOfBounds | "c.f. StackInterpreter>>stSizeOf: SpurMemoryManager>>lengthOf:format: fixedFieldsOf:format:length:" <var: #jumpBadArg type: #'AbstractInstruction *'> <var: #jumpIsBytes type: #'AbstractInstruction *'> <var: #jumpIsShorts type: #'AbstractInstruction *'> <var: #jumpBadIndex type: #'AbstractInstruction *'> <var: #jumpBytesOutOfRange type: #'AbstractInstruction *'> <var: #jumpShortsOutOfRange type: #'AbstractInstruction *'> <var: #jumpWordsOutOfRange type: #'AbstractInstruction *'> <var: #jumpBytesOutOfBounds type: #'AbstractInstruction *'> <var: #jumpShortsOutOfBounds type: #'AbstractInstruction *'> <var: #jumpWordsOutOfBounds type: #'AbstractInstruction *'> cogit genLoadArgAtDepth: 1 into: Arg0Reg. cogit genLoadArgAtDepth: 0 into: Arg1Reg. jumpBadIndex := self genJumpNotSmallInteger: Arg0Reg. jumpBadArg := self genJumpNotCharacter: Arg1Reg. self genConvertSmallIntegerToIntegerInReg: Arg0Reg. cogit SubCq: 1 R: Arg0Reg. "1-rel => 0-rel" "formatReg := self formatOf: ReceiverResultReg" self cppIf: IMMUTABILITY ifTrue: [ self genGetFormatOf: ReceiverResultReg into: (formatReg := SendNumArgsReg) leastSignificantHalfOfBaseHeaderIntoScratch: TempReg. jumpImmutable := self genJumpBaseHeaderImmutable: TempReg ] ifFalse: [ self genGetFormatOf: ReceiverResultReg into: (formatReg := SendNumArgsReg) leastSignificantHalfOfBaseHeaderIntoScratch: NoReg ]. self genGetNumSlotsOf: ReceiverResultReg into: ClassReg. "dispatch on format; words and/or bytes. 0 to 8 = pointer objects, forwarders, reserved. + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" cogit CmpCq: objectMemory firstLongFormat R: formatReg. jumpNotString := cogit JumpBelow: 0. cogit CmpCq: objectMemory firstCompiledMethodFormat R: formatReg. jumpIsCompiledMethod := cogit JumpAboveOrEqual: 0. cogit CmpCq: objectMemory firstByteFormat R: formatReg. jumpIsBytes := cogit JumpAboveOrEqual: 0. cogit CmpCq: objectMemory firstShortFormat R: formatReg. jumpIsShorts := cogit JumpAboveOrEqual: 0. "fall through to double words" cogit CmpCq: (objectMemory characterObjectOf: 1 << self numCharacterBits - 1) R: Arg1Reg. jumpWordsOutOfRange := cogit JumpAbove: 0. cogit LogicalShiftLeftCq: objectMemory shiftForWord - 2 R: ClassReg. cogit AndCq: objectMemory wordSize / 4 - 1 R: formatReg. cogit SubR: formatReg R: ClassReg. cogit CmpR: Arg0Reg R: ClassReg. jumpWordsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit MoveR: Arg1Reg R: TempReg. self genConvertCharacterToCodeInReg: TempReg. cogit AddCq: objectMemory baseHeaderSize >> (objectMemory shiftForWord - 1) R: Arg0Reg. cogit MoveR: TempReg X32r: Arg0Reg R: ReceiverResultReg. cogit MoveR: Arg1Reg R: ReceiverResultReg. cogit genPrimReturn. jumpIsShorts jmpTarget: (cogit CmpCq: (objectMemory characterObjectOf: 65535) R: Arg1Reg). jumpShortsOutOfRange := cogit JumpAbove: 0. cogit LogicalShiftLeftCq: objectMemory shiftForWord - 1 R: ClassReg. cogit AndCq: objectMemory wordSize / 2 - 1 R: formatReg. cogit SubR: formatReg R: ClassReg. cogit CmpR: Arg0Reg R: ClassReg. jumpShortsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit MoveR: Arg1Reg R: TempReg. self genConvertCharacterToCodeInReg: TempReg. cogit AddR: Arg0Reg R: ReceiverResultReg. cogit MoveR: TempReg M16: objectMemory baseHeaderSize r: ReceiverResultReg. cogit MoveR: Arg1Reg R: ReceiverResultReg. cogit genPrimReturn. jumpIsBytes jmpTarget: (cogit CmpCq: (objectMemory characterObjectOf: 255) R: Arg1Reg). jumpBytesOutOfRange := cogit JumpAbove: 0. cogit LogicalShiftLeftCq: objectMemory shiftForWord R: ClassReg. cogit AndCq: objectMemory wordSize - 1 R: formatReg. cogit SubR: formatReg R: ClassReg. cogit CmpR: Arg0Reg R: ClassReg. jumpBytesOutOfBounds := cogit JumpBelowOrEqual: 0. cogit MoveR: Arg1Reg R: TempReg. self genConvertCharacterToCodeInReg: TempReg. cogit AddCq: objectMemory baseHeaderSize R: Arg0Reg. cogit MoveR: TempReg Xbr: Arg0Reg R: ReceiverResultReg. cogit MoveR: Arg1Reg R: ReceiverResultReg. cogit genPrimReturn. jumpNotString jmpTarget: (jumpBytesOutOfRange jmpTarget: (jumpShortsOutOfRange jmpTarget: (jumpWordsOutOfRange jmpTarget: (jumpIsCompiledMethod jmpTarget: (jumpBytesOutOfBounds jmpTarget: (jumpShortsOutOfBounds jmpTarget: (jumpWordsOutOfBounds jmpTarget: cogit Label))))))). self cppIf: IMMUTABILITY ifTrue: [jumpImmutable jmpTarget: jumpNotString getJmpTarget]. cogit AddCq: 1 R: Arg0Reg. "0-rel => 1-rel" self genConvertIntegerToSmallIntegerInReg: Arg0Reg. jumpBadArg jmpTarget: (jumpBadIndex jmpTarget: cogit Label). ^CompletePrimitive! Item was added: + ----- Method: InterpreterPrimitives>>primitiveSpurStringReplace (in category 'indexing primitives') ----- + primitiveSpurStringReplace + "<array> primReplaceFrom: start to: stop with: replacement startingAt: repStart + <primitive: 105>" + <inline: true> + | array start stop repl replStart arrayFmt arrayLength arrayInstSize replFmt replLength replInstSize srcDelta | + array := self stackValue: 4. + start := self stackValue: 3. + stop := self stackValue: 2. + repl := self stackValue: 1. + replStart := self stackValue: 0. + + ((objectMemory isNonIntegerObject: start) + or: [(objectMemory isNonIntegerObject: stop) + or: [(objectMemory isNonIntegerObject: replStart) + or: [objectMemory isImmediate: repl]]]) ifTrue: "can happen in LgInt copy" + [^self primitiveFailFor: PrimErrBadArgument]. + + start := objectMemory integerValueOf: start. + stop := objectMemory integerValueOf: stop. + replStart := objectMemory integerValueOf: replStart. + + (stop >= start and: [objectMemory isObjImmutable: array]) ifTrue: + [^self primitiveFailFor: PrimErrNoModification]. + + arrayFmt := objectMemory formatOf: array. + arrayLength := objectMemory lengthOf: array format: arrayFmt. + arrayFmt := objectMemory classFormatFromInstFormat: arrayFmt. + replFmt := objectMemory formatOf: repl. + replLength := objectMemory lengthOf: repl format: replFmt. + replFmt := objectMemory classFormatFromInstFormat: replFmt. + + "Array formats (without oddFields bits) must be the same" + (arrayFmt = replFmt + and: [arrayFmt < objectMemory firstCompiledMethodFormat]) ifFalse: + [^self primitiveFailFor: PrimErrInappropriate]. + + arrayFmt <= objectMemory lastPointerFormat + ifTrue: + [arrayInstSize := objectMemory fixedFieldsOf: array format: arrayFmt length: arrayLength. + replInstSize := objectMemory fixedFieldsOf: repl format: replFmt length: replLength. + (start >= 1 and: [start - 1 <= stop and: [stop + arrayInstSize <= arrayLength + and: [replStart >= 1 and: [stop - start + replStart + replInstSize <= replLength]]]]) ifFalse: + [^self primitiveFailFor: PrimErrBadIndex]. + srcDelta := (replStart + replInstSize) - (start + arrayInstSize). + start + arrayInstSize - 1 to: stop + arrayInstSize - 1 do: + [:i | + objectMemory storePointer: i ofObject: array withValue: (objectMemory fetchPointer: srcDelta + i ofObject: repl)]] + ifFalse: + [(start >= 1 and: [start - 1 <= stop and: [stop <= arrayLength + and: [replStart >= 1 and: [stop - start + replStart <= replLength]]]]) ifFalse: + [^self primitiveFailFor: PrimErrBadIndex]. + srcDelta := replStart - start. + arrayFmt >= objectMemory firstShortFormat + ifTrue: "8 & 16-bit word type objects" + [arrayFmt >= objectMemory firstByteFormat + ifTrue: "byte-type objects" + [start - 1 to: stop - 1 do: + [:i | objectMemory storeByte: i ofObject: array withValue: (objectMemory fetchByte: srcDelta + i ofObject: repl)]] + ifFalse: "short type objects" + [start - 1 to: stop - 1 do: + [:i | objectMemory storeShort16: i ofObject: array withValue: (objectMemory fetchShort16: srcDelta + i ofObject: repl)]]] + ifFalse: "32 & 64-bit word type objects" + [arrayFmt >= objectMemory firstLongFormat + ifTrue: "word-type objects" + [start - 1 to: stop - 1 do: + [:i | objectMemory storeLong32: i ofObject: array withValue: (objectMemory fetchLong32: srcDelta + i ofObject: repl)]] + ifFalse: "long type objects" + [start - 1 to: stop - 1 do: + [:i | objectMemory storeLong64: i ofObject: array withValue: (objectMemory fetchLong64: srcDelta + i ofObject: repl)]]]]. + "We might consider comparing stop - start to some value here and using forceInterruptCheck" + + self pop: argumentCount "leave rcvr on stack"! Item was changed: ----- Method: InterpreterPrimitives>>primitiveStringReplace (in category 'indexing primitives') ----- primitiveStringReplace + "<array> primReplaceFrom: start to: stop with: replacement startingAt: repStart + <primitive: 105>" + objectMemory hasSpurMemoryManagerAPI + ifTrue: [self primitiveSpurStringReplace] + ifFalse: [self primitiveV3StringReplace]! - " - <array> primReplaceFrom: start to: stop with: replacement - startingAt: repStart - <primitive: 105> - " - | array start stop repl replStart hdr arrayFmt totalLength arrayInstSize replFmt replInstSize srcIndex | - array := self stackValue: 4. - start := self stackIntegerValue: 3. - stop := self stackIntegerValue: 2. - repl := self stackValue: 1. - replStart := self stackIntegerValue: 0. - - self successful ifFalse: - [^self primitiveFailFor: PrimErrBadArgument]. - (objectMemory isImmediate: repl) ifTrue: "can happen in LgInt copy" - [^self primitiveFailFor: PrimErrBadArgument]. - (stop >= start and: [objectMemory isObjImmutable: array]) ifTrue: - [^self primitiveFailFor: PrimErrNoModification]. - - hdr := objectMemory baseHeader: array. - arrayFmt := objectMemory formatOfHeader: hdr. - totalLength := objectMemory lengthOf: array baseHeader: hdr format: arrayFmt. - arrayInstSize := objectMemory fixedFieldsOf: array format: arrayFmt length: totalLength. - (start >= 1 and: [start - 1 <= stop and: [stop + arrayInstSize <= totalLength]]) ifFalse: - [^self primitiveFailFor: PrimErrBadIndex]. - - hdr := objectMemory baseHeader: repl. - replFmt := objectMemory formatOfHeader: hdr. - totalLength := objectMemory lengthOf: repl baseHeader: hdr format: replFmt. - replInstSize := objectMemory fixedFieldsOf: repl format: replFmt length: totalLength. - (replStart >= 1 and: [stop - start + replStart + replInstSize <= totalLength]) ifFalse: - [^self primitiveFailFor: PrimErrBadIndex]. - - "Still to do: rewrite the below to accomodate short & long access" - (objectMemory hasSpurMemoryManagerAPI - and: [(arrayFmt between: objectMemory firstShortFormat and: objectMemory firstLongFormat - 1) - or: [arrayFmt = objectMemory sixtyFourBitIndexableFormat]]) ifTrue: - [^self primitiveFailFor: PrimErrUnsupported]. - - "Array formats (without byteSize bits, if bytes array) must be the same" - arrayFmt < objectMemory firstByteFormat - ifTrue: [arrayFmt = replFmt ifFalse: - [^self primitiveFailFor: PrimErrInappropriate]] - ifFalse: [(arrayFmt bitAnd: objectMemory byteFormatMask) = (replFmt bitAnd: objectMemory byteFormatMask) ifFalse: - [^self primitiveFailFor: PrimErrInappropriate]]. - - srcIndex := replStart + replInstSize - 1. - "- 1 for 0-based access" - - arrayFmt <= objectMemory lastPointerFormat - ifTrue: - [start + arrayInstSize - 1 to: stop + arrayInstSize - 1 do: - [:i | - objectMemory storePointer: i ofObject: array withValue: (objectMemory fetchPointer: srcIndex ofObject: repl). - srcIndex := srcIndex + 1]] - ifFalse: - [arrayFmt < objectMemory firstByteFormat - ifTrue: "32-bit-word type objects" - [start + arrayInstSize - 1 to: stop + arrayInstSize - 1 do: - [:i | - objectMemory storeLong32: i ofObject: array withValue: (objectMemory fetchLong32: srcIndex ofObject: repl). - srcIndex := srcIndex + 1]] - ifFalse: "byte-type objects" - [start + arrayInstSize - 1 to: stop + arrayInstSize - 1 do: - [:i | - objectMemory storeByte: i ofObject: array withValue: (objectMemory fetchByte: srcIndex ofObject: repl). - srcIndex := srcIndex + 1]]]. - "We might consider comparing stop - start to some value here and using forceInterruptCheck" - - self pop: argumentCount "leave rcvr on stack"! Item was added: + ----- Method: InterpreterPrimitives>>primitiveV3StringReplace (in category 'indexing primitives') ----- + primitiveV3StringReplace + "<array> primReplaceFrom: start to: stop with: replacement startingAt: repStart + <primitive: 105>" + <inline: true> + | array start stop repl replStart hdr arrayFmt totalLength arrayInstSize replFmt replInstSize srcIndex | + array := self stackValue: 4. + start := self stackIntegerValue: 3. + stop := self stackIntegerValue: 2. + repl := self stackValue: 1. + replStart := self stackIntegerValue: 0. + + self successful ifFalse: + [^self primitiveFailFor: PrimErrBadArgument]. + (objectMemory isImmediate: repl) ifTrue: "can happen in LgInt copy" + [^self primitiveFailFor: PrimErrBadArgument]. + (stop >= start and: [objectMemory isObjImmutable: array]) ifTrue: + [^self primitiveFailFor: PrimErrNoModification]. + + hdr := objectMemory baseHeader: array. + arrayFmt := objectMemory formatOfHeader: hdr. + totalLength := objectMemory lengthOf: array baseHeader: hdr format: arrayFmt. + arrayInstSize := objectMemory fixedFieldsOf: array format: arrayFmt length: totalLength. + (start >= 1 and: [start - 1 <= stop and: [stop + arrayInstSize <= totalLength]]) ifFalse: + [^self primitiveFailFor: PrimErrBadIndex]. + + hdr := objectMemory baseHeader: repl. + replFmt := objectMemory formatOfHeader: hdr. + totalLength := objectMemory lengthOf: repl baseHeader: hdr format: replFmt. + replInstSize := objectMemory fixedFieldsOf: repl format: replFmt length: totalLength. + (replStart >= 1 and: [stop - start + replStart + replInstSize <= totalLength]) ifFalse: + [^self primitiveFailFor: PrimErrBadIndex]. + + "Array formats (without byteSize bits, if bytes array) must be the same" + arrayFmt < objectMemory firstByteFormat + ifTrue: [arrayFmt = replFmt ifFalse: + [^self primitiveFailFor: PrimErrInappropriate]] + ifFalse: [(arrayFmt bitAnd: objectMemory byteFormatMask) = (replFmt bitAnd: objectMemory byteFormatMask) ifFalse: + [^self primitiveFailFor: PrimErrInappropriate]]. + + srcIndex := replStart + replInstSize - 1. + "- 1 for 0-based access" + + arrayFmt <= objectMemory lastPointerFormat + ifTrue: + [start + arrayInstSize - 1 to: stop + arrayInstSize - 1 do: + [:i | + objectMemory storePointer: i ofObject: array withValue: (objectMemory fetchPointer: srcIndex ofObject: repl). + srcIndex := srcIndex + 1]] + ifFalse: + [arrayFmt < objectMemory firstByteFormat + ifTrue: "32-bit-word type objects" + [start + arrayInstSize - 1 to: stop + arrayInstSize - 1 do: + [:i | + objectMemory storeLong32: i ofObject: array withValue: (objectMemory fetchLong32: srcIndex ofObject: repl). + srcIndex := srcIndex + 1]] + ifFalse: "byte-type objects" + [start + arrayInstSize - 1 to: stop + arrayInstSize - 1 do: + [:i | + objectMemory storeByte: i ofObject: array withValue: (objectMemory fetchByte: srcIndex ofObject: repl). + srcIndex := srcIndex + 1]]]. + "We might consider comparing stop - start to some value here and using forceInterruptCheck" + + self pop: argumentCount "leave rcvr on stack"! Item was changed: ----- Method: Spur32BitMemoryManager>>set:classIndexTo:formatTo: (in category 'header access') ----- set: objOop classIndexTo: classIndex formatTo: format "0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" <inline: true> self assert: (classIndex between: 0 and: self classIndexMask). self assert: (format between: 0 and: self formatMask). self flag: #endianness. self longAt: objOop put: ((self longAt: objOop) bitAnd: (self formatMask << self formatShift + self classIndexMask) bitInvert32) + (classIndex + (format << self formatShift))! Item was changed: ----- Method: Spur32BitMemoryManager>>setFormatOf:to: (in category 'header access') ----- setFormatOf: objOop to: format "0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" self assert: (format between: 0 and: self formatMask). self flag: #endianness. self longAt: objOop put: ((self longAt: objOop) bitAnd: (self formatMask << self formatShift) bitInvert32) + (format << self formatShift)! Item was changed: ----- Method: Spur64BitMemoryManager>>set:classIndexTo:formatTo: (in category 'header access') ----- set: objOop classIndexTo: classIndex formatTo: format "0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" <inline: true> self assert: (classIndex between: 0 and: self classIndexMask). self assert: (format between: 0 and: self formatMask). self longAt: objOop put: ((self longAt: objOop) bitAnd: (self formatMask << self formatShift + self classIndexMask) bitInvert64) + (classIndex + (format << self formatShift))! Item was changed: ----- Method: Spur64BitMemoryManager>>setFormatOf:to: (in category 'header access') ----- setFormatOf: objOop to: format "0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" self assert: (format between: 0 and: self formatMask). self longAt: objOop put: ((self longAt: objOop) bitAnd: (self formatMask << self formatShift) bitInvert64) + (format << self formatShift)! Item was added: + ----- Method: SpurMemoryManager>>classFormatFromInstFormat: (in category 'object access') ----- + classFormatFromInstFormat: instFormat + "0 = 0 sized objects (UndefinedObject True False et al) + 1 = non-indexable objects with inst vars (Point et al) + 2 = indexable objects with no inst vars (Array et al) + 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) + 4 = weak indexable objects with inst vars (WeakArray et al) + 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) + 6 unused, reserved for exotic pointer objects? + 7 Forwarded Object, 1st field is pointer, rest of fields are ignored + 8 unused, reserved for exotic non-pointer objects? + 9 64-bit indexable + 10 - 11 32-bit indexable + 12 - 15 16-bit indexable + 16 - 23 byte indexable + 24 - 31 compiled method" + <inline: true> + instFormat >= self firstByteFormat ifTrue: "this is likely the common case" + [^instFormat bitAnd: -8]. + instFormat <= self sixtyFourBitIndexableFormat ifTrue: + [^instFormat]. + instFormat < self firstShortFormat ifTrue: + [^instFormat bitAnd: -2]. + ^instFormat bitAnd: -4! Item was changed: ----- Method: SpurMemoryManager>>formatMask (in category 'header format') ----- formatMask <api> <cmacro> "0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6,7,8 unused + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" ^16r1f! Item was changed: ----- Method: SpurMemoryManager>>formatOf: (in category 'object access') ----- formatOf: objOop "0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable (11 unused in 32 bits) 12 - 15 16-bit indexable (14 & 15 unused in 32-bits) 16 - 23 byte indexable (20-23 unused in 32-bits) 24 - 31 compiled method (28-31 unused in 32-bits)" "A note on performance. Since the format field is, by design, aligned on a byte boundary in the fourth byte of the header we could access it via ^(self byteAt: objOop + 3) bitAnd: self formatMask but al least on e.g. Core i7 x86-64 using the clang 6 compiler, this makes no difference, or at least any change is in the noise." ^(self longAt: objOop) >> self formatShift bitAnd: self formatMask! Item was changed: ----- Method: SpurMemoryManager>>formatOfHeader: (in category 'object access') ----- formatOfHeader: header "0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" <var: 'header' type: #usqLong> ^header >> self formatShift bitAnd: self formatMask! Item was changed: ----- Method: SpurMemoryManager>>set:classIndexTo:formatTo: (in category 'header access') ----- set: objOop classIndexTo: classIndex formatTo: format "0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" self subclassResponsibility! Item was changed: ----- Method: SpurMemoryManager>>setFormatOf:to: (in category 'header access') ----- setFormatOf: objOop to: format "0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? + 9 64-bit indexable - 9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" self subclassResponsibility!

1 0

VM Maker: VMMaker.oscog-eem.2080.mcz
by commits＠source.squeak.org 10 Jan '17

10 Jan '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2080.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2080 Author: eem Time: 10 January 2017, 1:09:38.430454 pm UUID: de2bea31-7530-47e7-b308-598c8e29a740 Ancestors: VMMaker.oscog-eem.2079 SpurPlanningCompactor: Add a test framework for the compactor based around loading a Pharo bootstrap image and extending it. For now include one test that shortens the heap to the minimum and checks that the heap is found to be incompressible. Add a test class that tests that the cloneSimulation and image (re)loading functions work (upon which the SpurPlanningCompactorTests relies). Don't use a macro for setDesiredCogCodeSize: (not needed) and implement it in the StackInterpreter for the convenience of these tests as well as potential image-build Smalltalk code running on the StackInterpreter. Requires Cog-eem.335 =============== Diff against VMMaker.oscog-eem.2079 =============== Item was changed: ----- Method: CoInterpreter>>setDesiredCogCodeSize: (in category 'internal interpreter access') ----- setDesiredCogCodeSize: dccs + <inline: true> - <cmacro: '(dccs) (desiredCogCodeSize = (dccs))'> desiredCogCodeSize := dccs! Item was added: + ----- Method: SpurMemoryManager>>abandonEmptySegmentForTests (in category 'simulation tests support') ----- + abandonEmptySegmentForTests + "Assume a freshly-loaded image. Eliminate the last segment." + <doNotGenerate> + | freeChunk emptySeg | + freeChunk := self findLargestFreeChunk. + self assert: totalFreeOldSpace = (self bytesInObject: freeChunk). + self assert: endOfMemory = (self addressAfter: freeChunk). + self unlinkSolitaryFreeTreeNode: freeChunk. + segmentManager numSegments > 1 + ifTrue: + [emptySeg := segmentManager findEmptySegNearestInSizeTo: (self bytesInObject: freeChunk). + segmentManager removeSegment: emptySeg] + ifFalse: + [(segmentManager segments at: 0) + segSize: (segmentManager segments at: 0) segSize - (self bytesInObject: freeChunk). + self setLastSegment: (segmentManager segments at: 0); + initSegmentBridgeWithBytes: self bridgeSize at: (self startOfObject: freeChunk)]! Item was added: + TestCase subclass: #SpurPlanningCompactorTests + instanceVariableNames: 'emptyVM' + classVariableNames: '' + poolDictionaries: '' + category: 'VMMaker-Tests'! Item was added: + ----- Method: SpurPlanningCompactorTests class>>imageNameForTests (in category 'accessing') ----- + imageNameForTests + "self imageNameForTests" + | baseImageName | + baseImageName := 'core32-preen.image'. + #('.' 'oscogvm/image' '../oscogvm/image') do: + [:dirName| + ((FileDirectory default directoryExists: dirName) + and: [(FileDirectory on: dirName) fileExists: baseImageName]) ifTrue: + [^dirName, '/', baseImageName]]. + self error: 'cannot find ', baseImageName! Item was added: + ----- Method: SpurPlanningCompactorTests class>>preenImage (in category 'utilities') ----- + preenImage + "Assume there's a Pharo bootstrap core32.image in ../oscogvm/image/core32.image. + We should find out where the image directory is and write a download script to get it. + But for now assume it's there." + "[SpurPlanningCompactorTests preenImage] timeToRun" + Spur32BitPreen new + writeDefaultHeader: true; + savedWindowSize: 640@480; + preenImage: '../oscogvm/image/core32'! Item was added: + ----- Method: SpurPlanningCompactorTests>>initialize (in category 'initialize-release') ----- + initialize + emptyVM := StackInterpreterSimulator newWithOptions: #(ObjectMemory Spur32BitMemoryManager + compactorClass SpurPlanningCompactor)! Item was added: + ----- Method: SpurPlanningCompactorTests>>initializedVM (in category 'private') ----- + initializedVM + ^emptyVM cloneSimulation + openOn: self class imageNameForTests extraMemory: 0; + initStackPages; + yourself! Item was added: + ----- Method: SpurPlanningCompactorTests>>testIncompactibleHeap (in category 'tests') ----- + testIncompactibleHeap + | errored | + errored := false. + [self initializedVM objectMemory + initializeMarkStack; "The Pharo bootstrap has no mark or weakling stacks :-)" + initializeWeaklingStack; + abandonEmptySegmentForTests; + fullGC] + on: Error + do: [:ex| + errored := true. + self assert: ex messageText = 'uncompactable heap; no unmarked objects found']. + self assert: errored! Item was changed: ----- Method: StackInterpreter>>setDesiredCogCodeSize: (in category 'internal interpreter access') ----- + setDesiredCogCodeSize: dccs + <inline: true> + "This should perhaps be a no-op in the StackVM, but we implement it for the convenience of bootstrap scripts etc." + theUnknownShort := dccs! - setDesiredCogCodeSize: iCouldCareLess - "This is a no-op in the StackVM"! Item was added: + TestCase subclass: #StackInterpreterSimulatorTests + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'VMMaker-Tests'! Item was added: + ----- Method: StackInterpreterSimulatorTests class>>imageNameForTests (in category 'accessing') ----- + imageNameForTests + "self imageNameForTests" + | baseImageName | + baseImageName := 'core32-preen.image'. + #('.' 'oscogvm/image' '../oscogvm/image') do: + [:dirName| + ((FileDirectory default directoryExists: dirName) + and: [(FileDirectory on: dirName) fileExists: baseImageName]) ifTrue: + [^dirName, '/', baseImageName]]. + self error: 'cannot find ', baseImageName! Item was added: + ----- Method: StackInterpreterSimulatorTests>>testEmptySimulatorCanCloneSimulation (in category 'tests') ----- + testEmptySimulatorCanCloneSimulation + self shouldnt: + [(StackInterpreterSimulator newWithOptions: #(ObjectMemory Spur32BitMemoryManager)) + cloneSimulation cloneSimulation] + raise: Error! Item was added: + ----- Method: StackInterpreterSimulatorTests>>testEmptySimulatorCloneCanLoadImage (in category 'tests') ----- + testEmptySimulatorCloneCanLoadImage + self shouldnt: + [(StackInterpreterSimulator newWithOptions: #(ObjectMemory Spur32BitMemoryManager)) + cloneSimulation + openOn: self class imageNameForTests extraMemory: 0] + raise: Error! Item was added: + ----- Method: StackInterpreterSimulatorTests>>testSimulatorCanReloadImage (in category 'tests') ----- + testSimulatorCanReloadImage + self shouldnt: + [(StackInterpreterSimulator newWithOptions: #(ObjectMemory Spur32BitMemoryManager)) + openOn: self class imageNameForTests extraMemory: 0; + openOn: self class imageNameForTests extraMemory: 0] + raise: Error!

1 0

VM Maker: Cog-eem.335.mcz
by commits＠source.squeak.org 10 Jan '17

10 Jan '17

Eliot Miranda uploaded a new version of Cog to project VM Maker: http://source.squeak.org/VMMaker/Cog-eem.335.mcz ==================== Summary ==================== Name: Cog-eem.335 Author: eem Time: 10 January 2017, 1:05:39.016065 pm UUID: b001d418-6353-4851-8ea9-cb6184e13b54 Ancestors: Cog-nice.334 Extend Spur32BitPreen to allow resetting header values to their defaults, and to not raise an error if there is no changes file (for the Pharo bootstrap). =============== Diff against Cog-nice.334 =============== Item was changed: SimulatorHarness subclass: #Spur32BitPreen + instanceVariableNames: 'oldHeap newHeap map reverseMap oldInterpreter newInterpreter imageHeaderFlags savedWindowSize writeDefaultHeader' - instanceVariableNames: 'oldHeap newHeap map reverseMap oldInterpreter newInterpreter imageHeaderFlags savedWindowSize' classVariableNames: '' poolDictionaries: 'VMObjectIndices' category: 'Cog-Bootstrapping'! !Spur32BitPreen commentStamp: 'eem 8/15/2016 19:49' prior: 0! A Spur32BitPreen is a simple image rewriter for 32-bit Spru images that eliminates free space and hence shrinks the preened image. Use via Spur32BitPreen new preenImage: 'spur' which will produce spur-preen.image and spur-preen.changes from spur.image and spur.changes. Instance Variables imageHeaderFlags: <Integer> map: <Dictionary> newHeap: <Spur32BitMMLESimulator> newInterpreter: <StackInterpreterSimulatorLSB> oldHeap: <Spur32BitMMLESimulator> oldInterpreter: <StackInterpreterSimulatorLSB> reverseMap: <Dictionary> savedWindowSize: <Integer> imageHeaderFlags - flags word in image header map - map from oops in old image to oops in new image newHeap - the preened heap newInterpreter - the interpreter wrapping the preened heap oldHeap - the heap to be preened oldInterpreter - the interpreter wrapping the heap to be preened reverseMap - map from oops in new image to oops in old image savedWindowSize - screen size word in mage header ! Item was changed: ----- Method: Spur32BitPreen>>on: (in category 'public access') ----- on: imageName (oldInterpreter := StackInterpreterSimulator newWithOptions: #(ObjectMemory Spur32BitMemoryManager)) openOn: imageName extraMemory: 0. oldHeap := oldInterpreter objectMemory. imageHeaderFlags := oldInterpreter getImageHeaderFlags. + savedWindowSize ifNil: [savedWindowSize := oldInterpreter savedWindowSize]. - savedWindowSize := oldInterpreter savedWindowSize. newInterpreter := StackInterpreterSimulator newWithOptions: #(ObjectMemory Spur32BitMemoryManager). newHeap := newInterpreter objectMemory. newHeap allocateMemoryOfSize: oldHeap oldSpaceSize newSpaceSize: 8 * 1024 * 1024 stackSize: 16 * 1024 codeSize: 0. newHeap bootstrapping: true. self initMaps! Item was changed: ----- Method: Spur32BitPreen>>preenImageUsingFileDirectory: (in category 'public access') ----- preenImageUsingFileDirectory: imageName | dirName baseName dir | dirName := FileDirectory dirPathFor: imageName. baseName := (imageName endsWith: '.image') ifTrue: [FileDirectory baseNameFor: imageName] ifFalse: [FileDirectory localNameFor: imageName]. dir := dirName isEmpty ifTrue: [FileDirectory default] ifFalse: [FileDirectory default on: dirName]. self on: (dir fullNameFor: baseName, '.image'). [self preenImage] on: Halt do: [:ex| "suppress halts from the usual suspects (development time halts)" (#(fullGC compactImage) includes: ex signalerContext sender selector) ifTrue: [ex resume] ifFalse: [ex pass]]. self writeSnapshot: (dir fullNameFor: baseName, '-preen.image') headerFlags: imageHeaderFlags screenSize: savedWindowSize. + (dir fileExists: baseName, '.changes') + ifTrue: + [dir deleteFileNamed: baseName, '-preen.changes'; + copyFileNamed: baseName, '.changes' toFileNamed: baseName, '-preen.changes'] + ifFalse: + [Transcript cr; show: 'could not find ', baseName, '.changes']! - dir deleteFileNamed: baseName, '-preen.changes'; - copyFileNamed: baseName, '.changes' toFileNamed: baseName, '-preen.changes'! Item was added: + ----- Method: Spur32BitPreen>>savedWindowSize: (in category 'public access') ----- + savedWindowSize: aPointOrInteger + savedWindowSize := aPointOrInteger isInteger + ifTrue: [aPointOrInteger] + ifFalse: [(aPointOrInteger x min: 65535) << 16 + (aPointOrInteger y min: 65535)]! Item was added: + ----- Method: Spur32BitPreen>>writeDefaultHeader: (in category 'public access') ----- + writeDefaultHeader: aBoolean + writeDefaultHeader := aBoolean! Item was changed: ----- Method: Spur32BitPreen>>writeSnapshot:headerFlags:screenSize: (in category 'snapshot') ----- writeSnapshot: imageFileName headerFlags: headerFlags screenSize: screenSizeInteger newHeap checkFreeSpace; runLeakCheckerForFullGC. + writeDefaultHeader == true ifTrue: + [newInterpreter + desiredEdenBytes: 0; + desiredNumStackPages: 0; + setDesiredCogCodeSize: 0; + setMaxExtSemSizeTo: 0]. newInterpreter setImageHeaderFlagsFrom: headerFlags; setDisplayForm: nil; setSavedWindowSize: savedWindowSize; imageName: imageFileName; writeImageFileIO. Transcript cr; show: 'Done!!'!

1 0

[OpenSmalltalk/opensmalltalk-vm] 5df7f5: CogVM source as per VMMaker.oscog-eem.2079
by GitHub 09 Jan '17

09 Jan '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 5df7f5af3bbea09bd56817795ac15d050ae2337e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/5df7f5af3bbea09bd5… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-01-09 (Mon, 09 Jan 2017) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cogit.h M spur64src/vm/cogitX64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitX64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/plugins/ADPCMCodecPlugin/ADPCMCodecPlugin.c M src/plugins/B2DPlugin/B2DPlugin.c M src/plugins/B3DAcceleratorPlugin/B3DAcceleratorPlugin.c M src/plugins/BitBltPlugin/BitBltPlugin.c M src/plugins/CroquetPlugin/CroquetPlugin.c M src/plugins/DSAPrims/DSAPrims.c M src/plugins/FilePlugin/FilePlugin.c M src/plugins/GeniePlugin/GeniePlugin.c M src/plugins/IA32ABI/IA32ABI.c M src/plugins/JPEGReaderPlugin/JPEGReaderPlugin.c M src/plugins/LargeIntegers/LargeIntegers.c M src/plugins/ScratchPlugin/ScratchPlugin.c M src/plugins/SoundGenerationPlugin/SoundGenerationPlugin.c M src/plugins/Squeak3D/Squeak3D.c M src/plugins/SqueakFFIPrims/ARM32FFIPlugin.c M src/plugins/SqueakFFIPrims/IA32FFIPlugin.c M src/plugins/SqueakFFIPrims/X64SysVFFIPlugin.c M src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c M src/plugins/StarSqueakPlugin/StarSqueakPlugin.c M src/plugins/UnicodePlugin/UnicodePlugin.c M src/plugins/VMProfileLinuxSupportPlugin/VMProfileLinuxSupportPlugin.c M src/plugins/VMProfileMacSupportPlugin/VMProfileMacSupportPlugin.c M src/plugins/Win32OSProcessPlugin/Win32OSProcessPlugin.c M src/plugins/ZipPlugin/ZipPlugin.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2079 Slang: Add support for constant reduction of const ifTrue: [bool] ifFalse: [statements] => bool to reduce isVanillaBlockClosure: to true if not using SistaV1BytecodeSet, and hence rescue C compilation of the non-Sista sources (ensureMethodIsCoggeds: needs this). Fix code generation for bitInvert64, fixing recently generated 64-bit sources. Fix indenting for not. To make code more readable when implementing SpurPlanningCompactor, markedBitShift was made a macro. That caused Slang to generate a bogus version of nullHeaderForMachineCodeMethod because it could no longer infer the type of the shift operand for the marked bit, and so generated 1UL << 55 instead of 1ULL << 55. Consequently nullHeaderForMachineCodeMethod answered 0 (!!). Add TParseNode>>constantNumbericValueIfAtAllPossibleOrNilIn: that provides a value for defines and methods answerinf constants as well as explicit constants and use it in generateShiftLeft:on:indent:, hence fixing nullHeaderForMachineCodeMethod. Fix inlining bugs due to an overcomplex and inaccurate completion check. Specifically: - inlineableFunctionCall:in: & inlineableSend:in: must see if a method wants to be inlined, so that completeness can be computed properly. - fix slips in tryToInlineMethodsIn: exiting too soon and always setting complete in a macro. - refactor checkForCompleteness:in: to checkForCompletenessIn: and simplify, setting complete if no incomplete send is found, rather than assuming completeness and then looking for inlineability, which is wrong. Have collectInlineList: set inline to false (rather than nil) if using asSpecified or asSpecifiedOrQuick. Fix pruneUnreachableMethods: to not delete <api> methods. Add cppIf:ifTrue: to statementsListsForInliningIn:'s filtering out. SmartSyntaxPlugin Slang: Avoid generating unreachable code when failing. Avoid an unnecessary test for failed if returning an expression which can't fail. And don't generate the return guard if there's nothing to guard. Clean up primitiveHasSocketAccess to be smart syntax. CoInterpreter: Fixed a bug where Cog would compiled compiledBlock like a compiledMethod, leading to very strange crashes. Refactor ensureMethodIsCogged: & ensureBlockIsCogged: numCopied: into ensureMethodIsCogged:maybeClosure: to reduce duplication. At the same time streamline ensureMethodIsCogged:maybeClosure: to avoid multiple calls on the Cogit. Cogit: Correct generateCogMethod/FullBlock which might write one byte too far. Indeed, (padIfPossibleWithStopsFrom: startAddress to: endAddress) is inclusive (it will write a byte into endAddress). So it must be called with (self padIfPossibleWithStopsFrom: startAddress to: startAddress + size - 1). Sista: Added identityHash in-line primitive Bytecode Set/Lowcode ExtB 00000000 1xxxxxxx constant decoding bug fix. Add some missing entries in the IA32 concretize instruction the dispatch table. IMMUTABILITY: Fix the NumTrampolines issue with the IMMUTABLE command line define. Spur: Move the attemptToShrink from fullGC to globalGarbageCollect so that it is included in lemming debugging. Make checkHeapFreeSpaceIntegrity check totalFreeOldSpace and hence catch SpurPlannngCompactor not freeing a free object at the end of an already compacted heap. Fix the free space leak checker invocations for the allocateSlots*InOldSpace:... One cannot invoke the leak checker until the allocated object's header has been filled in. Refactor scavengeInProgress into gcPhaseInProgress so that SpurPlanningCompactor can identify sliding compaction. Refactor shouldRemapObj:/remapObj: to double-dispatch through the compactor so that SpurPlanningCompactor can use its implicit forwarding test isMobile: to decide if a forwasrding pointer should be followed. Move globalGarbageCollect's segmentManager prepareForGlobalSweep send to immediately before compactor compact. Rename excludeUnmarkedNewSpaceObjs to excludeUnmarkedObjs throughout the leak checker; indeed any unmarked obj should be excluded immediately after the mark phase. General: Add printMethodImplementorsOf: for debugging. Extract the printing in printOopsFrom:to: into printEntity:, which is useful on its own for debugging. Plugins: FFIPlugin: Fix access to 64 bits int from 32 bit VM in primitiveFFIIntegerAtPut

1 0

VM Maker: VMMaker.oscog-eem.2079.mcz
by commits＠source.squeak.org 09 Jan '17

09 Jan '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2079.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2079 Author: eem Time: 9 January 2017, 12:23:31.735273 pm UUID: 00ef0ca2-fca0-4dc0-baa9-e65e98fda15a Ancestors: VMMaker.oscog-eem.2078 Slang: Fix code generation for bitInvert64, fixing recently generated 64-bit sources. Fix indenting for not. Fix cogitClass for StackInterpreter[Primitives] to avoid unnecessary CCodeGenerator initialization. =============== Diff against VMMaker.oscog-eem.2078 =============== Item was changed: ----- Method: CCodeGenerator>>generateBitInvert:on:indent: (in category 'C translation') ----- generateBitInvert: msgNode on: aStream indent: level "Generate the C code for this message onto the given stream. If the selector is bitInvert32 then cast to unsigned int to ensure a 32-bit value on 64-bit platforms." + | castToUnsignedInt castToUnsignedLong castToUnsignedLongLong | + (castToUnsignedInt := msgNode selector = #bitInvert32) ifTrue: - | castToUnsignedInt | - castToUnsignedInt := msgNode selector = #bitInvert32. - castToUnsignedInt ifTrue: [aStream nextPutAll: '(unsigned int)']. aStream nextPut: $~. + (castToUnsignedLong := msgNode selector = #bitInvert64 and: [vmClass notNil and: [vmClass objectMemoryClass wordSize = 8]]) ifTrue: + [aStream nextPutAll: '(usqIntptr_t)']. + (castToUnsignedLongLong := msgNode selector = #bitInvert64 and: [vmClass isNil or: [vmClass objectMemoryClass wordSize = 4]]) ifTrue: + [aStream nextPutAll: '(unsigned long long)']. + self assert: castToUnsignedInt asBit + castToUnsignedLong asBit + castToUnsignedLongLong asBit <= 1. "We should only do a single cast" self emitCExpression: msgNode receiver on: aStream! Item was changed: ----- Method: CCodeGenerator>>generateNot:on:indent: (in category 'C translation') ----- generateNot: msgNode on: aStream indent: level "Generate the C code for this message onto the given stream." aStream nextPutAll: '!!'. + self emitCExpression: msgNode receiver on: aStream indent: level! - self emitCExpression: msgNode receiver on: aStream.! Item was changed: ----- Method: VMClass class>>cogitClass (in category 'accessing class hierarchy') ----- cogitClass + "Answer the cogitClass in effect. Ensure that StackInterpreter has a nil cogitClass." + (self isInterpreterClass and: [self hasCogit not]) ifTrue: + [^nil]. ^initializationOptions ifNotNil: [Smalltalk classNamed: (initializationOptions at: #Cogit ifAbsent: [#SimpleStackBasedCogit])]!

1 0

latest vm 64bits crashes my image
by Esteban Lorenzano 09 Jan '17

09 Jan '17

(sent again with dump zipped) Hello, I just built a new VM for 64bits with latest sources and is crashing in mac :( Latest version I tested (and it was working) was based on VMMaker.oscog-nice.1991 and is from november 2016. I’m adding the dump… any idea? Esteban

3 12

← Newer
1
...
8
9
10
11
12
13
14
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev January 2017