Vm-dev December 2009

vm-dev@lists.squeakfoundation.org

20 participants
32 discussions

oopForPointer in external plugins
by John M McIntosh 21 Dec '09

21 Dec '09

Ok I closed http://bugs.squeak.org/view.php?id=7431 because it seemed my ft2plugin image was data and didn't have the latest interpreter changes. However now I have byteSize = interpreterProxy->byteSizeOf((oopForPointer( aByteArray ) - 4)); but since # define oopForPointer(ptr) ((sqInt)(((char *)(ptr)) - (sqMemoryBase))) then sqMemoryBase becomes an issue because the external plugin is not linkable due to the missing reference. So do we need to add something to the VM interpreter api or will I see if we can weak-link this var in? -- =========================================================================== John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: squeaker68882 Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com ===========================================================================

2 1

[commit] r2147 - snd_pcm updates info before reading; fix typo in squeak.sh
by commits＠squeakvm.org 17 Dec '09

17 Dec '09

Author: piumarta Date: 2009-12-17 10:29:39 -0800 (Thu, 17 Dec 2009) New Revision: 2147 Modified: trunk/platforms/unix/ChangeLog trunk/platforms/unix/cmake/squeak.sh.in trunk/platforms/unix/vm-sound-ALSA/sqUnixSoundALSA.c Log: snd_pcm updates info before reading; fix typo in squeak.sh Modified: trunk/platforms/unix/ChangeLog =================================================================== --- trunk/platforms/unix/ChangeLog 2009-10-26 19:32:39 UTC (rev 2146) +++ trunk/platforms/unix/ChangeLog 2009-12-17 18:29:39 UTC (rev 2147) @@ -1,3 +1,10 @@ +2009-12-17 Ian Piumarta <com -dot- gmail -at- piumarta (backwards)> + + * vm-sound-ALSA/sqUnixSoundALSA.c (sound_AvailableSpace): Update + available space info before reading state. + + * cmake/squeak.sh.in (vm): Fix typo: xkdialog -> kdialog. + 2009-10-26 Ian Piumarta <com -dot- gmail -at- piumarta (backwards)> * vm/build.cmake: gnu-interp.c depends on generated interp.c. Modified: trunk/platforms/unix/cmake/squeak.sh.in =================================================================== --- trunk/platforms/unix/cmake/squeak.sh.in 2009-10-26 19:32:39 UTC (rev 2146) +++ trunk/platforms/unix/cmake/squeak.sh.in 2009-12-17 18:29:39 UTC (rev 2147) @@ -2,7 +2,7 @@ # # Launch squeak from a menu, prompting for and/or installing an image # -# Last edited: 2009-08-27 02:06:21 by piumarta on ubuntu.piumarta.com +# Last edited: 2009-12-17 10:21:38 by piumarta on ubuntu PATH=/usr/bin:/bin @@ -15,7 +15,7 @@ # find a way to display dialogues -if test -n "$DISPLAY" -a -x "`which xkdialog 2>/dev/null`"; then +if test -n "$DISPLAY" -a -x "`which kdialog 2>/dev/null`"; then error () { kdialog --error "${me}: $*"; exit 1; } confirm () { if kdialog --yesno "${1} ${2}?"; then result="${2}"; else result=""; fi; } chooseItem () { title="$1"; shift; result=`kdialog --combobox "${title}" $*`; } Modified: trunk/platforms/unix/vm-sound-ALSA/sqUnixSoundALSA.c =================================================================== --- trunk/platforms/unix/vm-sound-ALSA/sqUnixSoundALSA.c 2009-10-26 19:32:39 UTC (rev 2146) +++ trunk/platforms/unix/vm-sound-ALSA/sqUnixSoundALSA.c 2009-12-17 18:29:39 UTC (rev 2147) @@ -2,7 +2,7 @@ * * Author: Ian.Piumarta(a)squeakland.org * - * Last edited: 2008-04-21 14:48:26 by piumarta on emilia + * Last edited: 2009-12-17 10:26:20 by piumarta on ubuntu * * Copyright (C) 2006 by Ian Piumarta * All rights reserved. @@ -168,7 +168,8 @@ if (!output_handle) return 0; snd_pcm_delay(output_handle, &delay); - state= snd_pcm_state (output_handle); + snd_pcm_avail_update(output_handle); + state= snd_pcm_state(output_handle); /* if underrun causes, max delay is loosened */ if (state == SND_PCM_STATE_XRUN)

1 0

snd_pcm_avail_update() needs to be called in vm-sound-ALSA
by Bert Freudenberg 17 Dec '09

17 Dec '09

Ian, can you add that line? Patch is attached to http://tracker.squeakland.org/browse/SQ-638 - Bert - Begin forwarded message: > > From: "Sayamindu Dasgupta (JIRA)" <tracker(a)squeakland.org> > Date: 16. Dezember 2009 22:37:40 MEZ > To: bert(a)freudenbergs.de > Subject: [JIRA] Created: (SQ-638) snd_pcm_avail_update() needs to be called in vm-sound-ALSA > > snd_pcm_avail_update() needs to be called in vm-sound-ALSA > ---------------------------------------------------------- > > Key: SQ-638 > URL: http://tracker.squeakland.org/browse/SQ-638 > Project: squeakland > Issue Type: Bug > Components: etoys-sugar > Reporter: Sayamindu Dasgupta > Attachments: dlo_9375.patch > > In XO 1.5, the the sounds produced in Etoys and Scratch are jumpy (http://dev.laptop.org/ticket/9375). It turns out that the issue is solved by calling snd_pcm_avail_update() after calling snd_pcm_delay() in squeak/platforms/unix/vm-sound-ALSA/sqUnixSoundALSA.c > > This seems to be consistent with the ALSA documentation (http://www.alsa-project.org/alsa-doc/alsa-lib/group___p_c_m.html#g41ca53465…) which says about snd_pcm_avail_update(): > > "Also this function might be called after snd_pcm_delay() or snd_pcm_hwsync() functions to move private ring buffer pointers in alsa-lib (the internal plugin chain)."

1 0

Re: squeak VM 5.0
by Bert Freudenberg 17 Dec '09

17 Dec '09

On 17.12.2009, at 07:44, Laval Jannik wrote: > Hi, > > I modify the variable in the method "clonePreStartup". > So, it works fine. > Given that this won't change on any further startup I'd think this is a better solution than putting it in the snapshot code. Since there won't be a sender of #wordSize: in the resulting image, I'd add a comment explaining why. Also, I'd take out the lazy init code in #wordSize, no need to be lazy here ;) - Bert - > ===== > !SystemTracer2 methodsFor: 'clone startup' stamp: 'ajh 8/22/2002 11:15'! > clonePreStartup > "This will be executed right away when the new clone starts up, before processStartup. Subclasses may want to rehash all objects or something" > SystemDictionary wordSize: self wordSize.! ! > ===== > > Now, there are some tests which does not pass. > So, I will publish the code and the pharoImage64, and with the community, we can check this. > > Cheers, > Jannik > > > On Dec 17, 2009, at 02:32 , John M McIntosh wrote: > >> Ok, well I created Mantis >> http://bugs.squeak.org/view.php?id=7430 >> to document. >> >> Personally I would do >> Smalltalk wordSize >> versus >> SystemDictionary wordSize >> >> Also the issue is when to change the WordSize variable. >> >> I think in >> SmalltalkImage>>snapshot: andQuit: embedded: >> right at the >> ifTrue: [self quitPrimitive]. >> Cursor normal show. >> you want to set things so that wordSize is reset. >> >> At quit time you could do the reset before the >> "self quitPrimitive" >> then you know the value is reset and needs to be recalculated at startup time. >> or you can reset it before the >> Cursor normal show. >> which runs after startup time >> >> Somehow I think there is more risk resetting it after startup since I'm not sure >> when something could leap in wanting a valid value. >

1 0

Re: [squeak-dev] Access forbidden to download the latest .deb VM
by Göran Krampe 17 Dec '09

17 Dec '09

Hi Ian! Ian Piumarta wrote: > I was asked to remove it. Ok (?) but you forgot to remove the links to it on the site... regards, Göran

1 0

Re: [Vm-dev] Re: [Pharo-project] squeak VM 5.0
by John M McIntosh 17 Dec '09

17 Dec '09

Ok, well I created Mantis http://bugs.squeak.org/view.php?id=7430 to document. Personally I would do Smalltalk wordSize versus SystemDictionary wordSize Also the issue is when to change the WordSize variable. I think in SmalltalkImage>>snapshot: andQuit: embedded: right at the ifTrue: [self quitPrimitive]. Cursor normal show. you want to set things so that wordSize is reset. At quit time you could do the reset before the "self quitPrimitive" then you know the value is reset and needs to be recalculated at startup time. or you can reset it before the Cursor normal show. which runs after startup time Somehow I think there is more risk resetting it after startup since I'm not sure when something could leap in wanting a valid value. On 2009-12-16, at 2:44 PM, Laval Jannik wrote: > Hi Eliot, hi John, > > This is what I do: > - create a class var in SystemDictionary > - accessors (wordSize and wordSize:), the first one can initialize the variable if nil, the second is to modify the value in case of 64bits image. > Maybe the second one could be integrated in System-Tracing file. > - in CompiledMethod, initialPC use it. > > Maybe we could integrate it in pharoCore. > -- =========================================================================== John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: squeaker68882 Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com ===========================================================================

2 1

Re: [squeak-dev] Re: Unix updates
by Levente Uzonyi 17 Dec '09

17 Dec '09

On Thu, 17 Dec 2009, José Luis Redrejo Rodríguez wrote: > 2009/12/16 K. K. Subramaniam <subbukk(a)gmail.com> > >> On Wednesday 16 December 2009 11:47:50 pm José Luis Redrejo wrote: >> >>> b) has caused the current delay in Debian, because I've been waiting for >> 6 >>> months, just in case anybody wants to help. I've already given up, so I >>> will upload the latest version before the end of this month. Before the >>> setting up of the collaborative project I kept the squeak-vm very >> updated >>> in Debian. In fact I used to compile it from svn, to get the latest >>> patches, trying to make the images work with the newest plugins. >> José, >> >> What do you think of the new launcher scripts - squeak and squeak.sh? Do >> they >> have enough flexibility for a distro packager? >> >> > squeak.sh has the same problem I've discussed once again in this list for > the last four years: they are developer focused. I don't have anything > against a developer view, but I want the squeak packages being end-user > friendly. I'm very focused/biased on the educational uses of Squeak, and I > don't think a console script is a good idea these days. > I will integrate the changes these scripts have, so the one I use in the > package can be called from a terminal, but I want to keep the gnome/kde and > mime integration I added to the squeak-vm package. Quoted from http://lists.squeakfoundation.org/pipermail/vm-dev/2009-August/003092.html "Another script, squeak.sh, is intended to launch Squeak from a menu. It's begging for improvement." Levente > > > > >> Building plugins is currently painful, I agree. Perhaps there should be two >> packages - squeakvm (runtime) and squeakvm-dev (plugin development). >> >> > > The problem comes when new etoys images do need those plugins to work > properly, and they are just experimental works somebody does and nobody > maintains later. > > > >> (branching this discussion to vm-dev) >> >> > > I'm subscribed to vm-dev, so no cc'ed is needed. > > Regards > José L. > > >> Subbu >> >

1 0

Re: [squeak-dev] Re: Unix updates
by K. K. Subramaniam 16 Dec '09

16 Dec '09

On Wednesday 16 December 2009 11:47:50 pm José Luis Redrejo wrote: > b) has caused the current delay in Debian, because I've been waiting for 6 > months, just in case anybody wants to help. I've already given up, so I > will upload the latest version before the end of this month. Before the > setting up of the collaborative project I kept the squeak-vm very updated > in Debian. In fact I used to compile it from svn, to get the latest > patches, trying to make the images work with the newest plugins. José, What do you think of the new launcher scripts - squeak and squeak.sh? Do they have enough flexibility for a distro packager? Building plugins is currently painful, I agree. Perhaps there should be two packages - squeakvm (runtime) and squeakvm-dev (plugin development). (branching this discussion to vm-dev) Subbu

1 0

Re: [Pharo-project] squeak VM 5.0
by John M McIntosh 16 Dec '09

16 Dec '09

RIght and it's 12:30 am again, So the MAGIC fixes for the tracer to let you build a 64bit Pharo image are below. No doubt they apply to closure based squeak trunk images. Could someone can be kind enough to integrate them into the current System-Tracing.2forPharo.cs ? Then some people in Europe? can grab the current Pharo/Trunk image and convert it, and run some smoke tests. BTW you need to use the Squeak.5.0.0.b9.64*64.app.zip to run a 64bit image Don't forget to convert you have to use a powerpc, or a squeak VM that is running as powerpc (via get info settings) on your macintel machine. Still need someone to *fix* the systemtracer so it will run on intel machines. (Hint watch how it writes out integer data). ... Changes below: "This is the magic change, it's not the conversion of the image that is bad. It's the Smalltalk code assumption of is that 4 or 8 bytes? " "There likely should be a Pharo/Squeak bug for this since it should be using wordSize not a magic number of 4" Eliot notes "Bravo! But Smalltalk wordSize has to be implemented in some way that caches the value in e.g. a class variable (or class inst var for max speed) that is reevaluated on startup." So I'll let someone propose/write a clever solution since the Smalltalk wordSize is computational heavy. CompiledMethod>>initialPC "Answer the program counter for the receiver's first bytecode." ^ (self numLiterals + 1) * (Smalltalk wordSize) + 1 "This next method isn't used much, should be. But the System-Tracing.2forPharo.cs trashes it with a ancient version. This is the correct version" SystemDictionary>>wordSize "Answer the size (in bytes) of an object pointer." "Smalltalk wordSize" ^[SmalltalkImage current vmParameterAt: 40] on: Error do: [4] "Changes to properly fix up BlockClosure in the SystemTracer2" SystemTracer2>>object: object allFieldsWithIndex: block collect: sequenceableCollectionClass "Evaluate block against each of the pointer fields with index, and collect the results in an instance of sequenceableCollectionClass" | fixedSize results varSize nilResults blockvalue | object isCompiledMethod ifTrue: [results := sequenceableCollectionClass new: 1 + object numLiterals. 1 to: 1 + object numLiterals do: [:j | results at: j put: (block value: (object objectAt: j) value: j)]. ^ results]. fixedSize := object class instSize. varSize := object basicSize. results := sequenceableCollectionClass new: fixedSize + varSize. 1 to: fixedSize do: [:j | results at: j put: (block value: (object instVarAt: j) value: j)]. 1 to: varSize do: [:j | results at: fixedSize + j put: (block value: (object basicAt: j) value: fixedSize + j)]. object isContextPart ifTrue: [(object instVarAt: 2) ifNotNil: ["May need to adjust PC and startPC if changing wordSize..." blockvalue := (object instVarAt: 2)+(self pcDeltaForMethod: object method). results at: 2 put: (block value: blockvalue value: 2)]. ((object isMemberOf: BlockContext) and: [object home notNil]) ifTrue: [results at: 5 put: (block value: (object instVarAt: 5)+(self pcDeltaForMethod: object method) value: 5)]. "Need to fill out the nils beyond the knowable end of stack" nilResults := sequenceableCollectionClass new: object frameSize - object basicSize. 1 to: nilResults size do: [:j | nilResults at: j put: (block value: nil value: j)]. ^ results , nilResults]. object class = BlockClosure ifTrue: ["May need to adjust PC and startPC if changing wordSize..." blockvalue := (object instVarAt: 2)+(self pcDeltaForMethod: object method). results at: 2 put: (block value: blockvalue value: 2)]. ^ results >> Eliot and I spent 30 minutes chatting about what is wrong. The conclusion is we *think* we are doing the right thing, >> yet the Virtual Machine says the image is busted. So a quick fix is not apparent, and we'll dig more. -- =========================================================================== John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: squeaker68882 Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com ===========================================================================

2 2

Fwd: Mirror primitives [Was The better debugger support by extending an Object protocol]
by Eliot Miranda 16 Dec '09

16 Dec '09

---------- Forwarded message ---------- From: Eliot Miranda <eliot.miranda(a)gmail.com> Date: Mon, Sep 7, 2009 at 11:56 AM Subject: Mirror primitives [Was The better debugger support by extending an Object protocol] To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org> Hi Igor, On Mon, Sep 7, 2009 at 10:29 AM, Igor Stasenko <siguctua(a)gmail.com> wrote: > > 2009/9/7 Bert Freudenberg <bert(a)freudenbergs.de>: > > > > On 07.09.2009, at 18:40, Randal L. Schwartz wrote: > > > >>>>>>> "Igor" == Igor Stasenko <siguctua(a)gmail.com> writes: > >> > >> Igor> Here is the default implementation of > >> > >> Object> debugPrintOn: aStream > >> Igor> ^ self printOn: aStream > >> > >> I like it, but I don't like the name. It conjurs up the idea of debugging > >> the #printOn: method itself. > >> > >> maybe #printForDebuggerOn: ? > > > > > > It matches the other methods like #longPrintOn: though. > > > > Also that would imply only the debugger invokes it, when it's clearly > > appropriate for any purpose. > > > > However, apart from this bike shedding ;) do others think it's a good idea > > in general? IMHO #printOn: is primarily used for debugging anyway so I > > wouldn't really expect a separate debug print method to be needed. Debugging > > transparent proxies isn't for the faint-of-heart anyway, so these developers > > can adapt their tools and proxies I would guess. OTOH there is precedence in > > e.g. #asExplorerString, which exists solely to get rid of the quotes > > enclosing strings for aesthetic reasons ... > > > > I agree with you Bert, that we should consider if its really necessary. > While #printOn: is used by most code for debugging, some of the code > using it to serialize object to textual stream, so the #printOn: usage > is much more generic than just debugging. > > As for debugging the transparent proxies - yes you can make own > tools.. but this means reimplementing/hacking > other tools , like debugger, inspector and so on, which will probably > end up with similar solution to what i proposing. > > For example, there was a point of discrepancy with debugging the code > which uses Magma. > The magma forwarding proxy reifying the object once the first real > message is sent to it. > And the problem with such a proxy, that you can't use them in certain > situations, like: > > self perform: aSelectorProxied with: #foo > > because #perform doesn't sends the messages to aSelectorProxied and > primitive fails. But then, when you entering the debugger and trying > to figure out why its not working - a proxy becomes a real object when > it printed out.. and so you can't debug the error using debugger. > Which leaves you to wonder, why code works in debugger, but not > working at run time :) I have fixes for this integrated in Qwaq. This is work I did for VisualWorks a while back. The idea is to add a set of mirror primitives, so called because they do reflection, to ContextPart. These primitives implement the basic operations of the object model needed for execution simulation, fetching an object's class, accessing its named and indexed instance variables, and the number of indexed instance variables, sending a message, but they take the object operated on as a parameter and so do function without sending messages to that object. These primitives are then used by the execution simulation machinery to correctly simulate the execution of the virtual machine irrespective of the class and/or messages implemented by the receiver. For example, (eschewing HTML for Bert's contentment) ContextPart methods for mirror primitives object: anObject instVarAt: anIndex "Primitive. Answer a fixed variable in an object. The numbering of the variables corresponds to the named instance variables. Fail if the index is not an Integer or is not the index of a fixed variable. Essential for the debugger. See Object documentation whatIsAPrimitive." <primitive: 73> "Access beyond fixed variables." ^self object: anObject basicAt: anIndex - (self objectClass: anObject) instSize object: anObject instVarAt: anIndex put: aValue "Primitive. Store a value into a fixed variable in the argument anObject. The numbering of the variables corresponds to the named instance variables. Fail if the index is not an Integer or is not the index of a fixed variable. Answer the value stored as the result. Using this message violates the principle that each object has sovereign control over the storing of values into its instance variables. Essential for the debugger. See Object documentation whatIsAPrimitive." <primitive: 74> "Access beyond fixed fields" ^self object: anObject basicAt: anIndex - (self objectClass: anObject) instSize put: aValue ContextPart methods for instruction decoding pushReceiverVariable: offset "Simulate the action of bytecode that pushes the contents of the receiver's instance variable whose index is the argument, index, on the top of the stack." self push: (self object: self receiver instVarAt: offset + 1) popIntoReceiverVariable: offset "Simulate the action of bytecode that removes the top of the stack and stores it into an instance variable of my receiver." self object: self receiver instVarAt: offset + 1 put: self pop storeIntoReceiverVariable: offset "Simulate the action of bytecode that stores the top of the stack into an instance variable of my receiver." self object: self receiver instVarAt: offset + 1 put: self top The attached change set for the image level code is also conflated with changes that allow the debugger to set the primitive error code correctly. The VM also needs to implement the primitives. If the order of the arguments are the same as those of the corresponding non-reflective primitive (e.g. aContext object: theReceiver instVarAt: index put: value has the same order as theReceiver instVarAt: index put: value) and the primitive pops back the stack using self pop: argumentCount + 1, one can use the same VM primitive implementations as the non-reflective ones and so avoid needing extra primitives. However, not all primitives are correctly implemented; e.g. at: and at:put: are, but size is not. So before we can use this there is some work to do in the standard VMs. I'm attaching here the implementation in the Stack VM which will require some back porting to the standard VM. None of these changes has performance implications because the special selector impelmentations of at: at:put: size and #== are not affected. With the above changes one can safely step through code that uses proxies that do not inherit from Object, or even ProtoObject. I still need to implement a PrimitiveObjectInspector, or use the mirror primitives in implementing the Inspector. However, there is one more important thing needed in the debugger which these changes do not address and that is the value of Processor activeProcess within the debugger. e.g. "print it" the following: | thisProcessOutsideTheDebugger thisProcessInsideTheDebugger | thisProcessOutsideTheDebugger := Processor activeProcess. self halt. thisProcessInsideTheDebugger := Processor activeProcess. 'Send to here (Into) then proceed'. thisProcessOutsideTheDebugger == thisProcessInsideTheDebugger This will potentially break debugging of servers that maintain process pools. Andreas has proposed a very simple fix for this. Add an instance variable to Process called, e.g. effectiveProcess, which is nil in normal processes. When the debugger runs it sets effectiveProcess to that of the process which it is debugging and Processor activeProcess is implemented as something like ProcessorScheduler methods for accessing activeProcess ^activeProcess effectiveProcess ifNil: [activeProcess] I'll try and get round to this soon. I'm posting this rather than integrating because a) the VMs need to get updated before we can use the image level code and, b) the VM folks need code to test their VMs with. I'm happy to integrate the image-level changes once the VMs have been upgraded. best Eliot > > > > > - Bert - > > > > > -- > Best regards, > Igor Stasenko AKA sig. >

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev December 2009