Squeak-dev January 2024

squeak-dev@lists.squeakfoundation.org

22 participants
89 discussions

The Inbox: Morphic-ct.2145.mcz
by commits＠source.squeak.org 19 Jan '24

19 Jan '24

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.2145.mcz ==================== Summary ==================== Name: Morphic-ct.2145 Author: ct Time: 1 December 2023, 9:00:59.264752 pm UUID: 2cb1f9a9-0aad-eb44-bde5-90138c603659 Ancestors: Morphic-ct.2144 Proposal: Makes the code point and Unicode category of characters explorable in explorers, analogously to different representations of numbers. =============== Diff against Morphic-ct.2144 =============== Item was added: + ----- Method: Character>>explorerContents (in category '*Morphic-Explorer') ----- + explorerContents + + ^ {ObjectExplorerWrapper + with: self codePoint + name: 'code point' + model: self. + ObjectExplorerWrapper + with: (Unicode generalCategoryLabelOf: self codePoint) + name: 'category' + model: self}! Item was added: + ----- Method: Character>>hasContentsInExplorer (in category '*Morphic-Explorer') ----- + hasContentsInExplorer + + ^ true!

3 4

The Inbox: Morphic-ct.2148.mcz
by commits＠source.squeak.org 19 Jan '24

19 Jan '24

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.2148.mcz ==================== Summary ==================== Name: Morphic-ct.2148 Author: ct Time: 7 December 2023, 7:31:26.443108 pm UUID: b74139ee-af71-b64d-9b8d-0950fd862bbd Ancestors: Morphic-mt.2147 Fixes a remarkable slip that (1) prevented collapsed windows from applying a new UI theme and (2) introduced a possibly significant memory leak*. Note that #userInterfaceTheme answer a UserInterfaceThemeRequest which forwards all one-argument selectors as setters to the actual theme. *To reproduce this in an older image, open a workspace, evaluate o := Array new: 100000000, collapse the window, change the UI theme, expand the window, close it, purge all undos and run GC, and the workspace with its large binding will still be referenced in the UI theme. =============== Diff against Morphic-mt.2147 =============== Item was changed: ----- Method: SystemWindow>>collapseOrExpand (in category 'resize/collapse') ----- collapseOrExpand "Collapse or expand the window, depending on existing state" | cf | isCollapsed ifTrue: ["Expand -- restore panes to morphics structure" isCollapsed := false. self beKeyWindow. "Bring to frint first" Preferences collapseWindowsInPlace ifTrue: [fullFrame := fullFrame align: fullFrame topLeft with: self getBoundsWithFlex topLeft] ifFalse: [collapsedFrame := self getBoundsWithFlex]. collapseBox ifNotNil: [collapseBox setBalloonText: 'collapse this window' translated]. self setBoundsWithFlex: fullFrame. paneMorphs reverseDo: [:m | self addMorph: m unlock. self world startSteppingSubmorphsOf: m]. self addPaneSplitters. (self hasProperty: #applyTheme) ifTrue: [ self removeProperty: #applyTheme. + UserInterfaceTheme current applyTo: self allMorphs]] - self userInterfaceTheme applyTo: self allMorphs]] ifFalse: ["Collapse -- remove panes from morphics structure" isCollapsed := true. fullFrame := self getBoundsWithFlex. "First save latest fullFrame" paneMorphs do: [:m | m delete; releaseCachedState]. self removePaneSplitters. self removeCornerGrips. model modelSleep. cf := self getCollapsedFrame. (collapsedFrame isNil and: [Preferences collapseWindowsInPlace not]) ifTrue: [collapsedFrame := cf]. self setBoundsWithFlex: cf. collapseBox ifNotNil: [collapseBox setBalloonText: 'expand this window' translated ]. expandBox ifNotNil: [expandBox setBalloonText: 'expand this window' translated ]. self isInWorld ifTrue: [self sendToBack]]. self layoutChanged.!

3 2

The Inbox: PreferenceBrowser-ct.160.mcz
by commits＠source.squeak.org 19 Jan '24

19 Jan '24

Christoph Thiede uploaded a new version of PreferenceBrowser to project The Inbox: http://source.squeak.org/inbox/PreferenceBrowser-ct.160.mcz ==================== Summary ==================== Name: PreferenceBrowser-ct.160 Author: ct Time: 21 December 2023, 7:37:19.742632 pm UUID: e1f740cd-fd42-7540-9189-9c34140810cf Ancestors: PreferenceBrowser-codefrau.159 Makes non-pragma preferences findable through its readable name (i.e., "higher perf" instead of "higherperf"). =============== Diff against PreferenceBrowser-codefrau.159 =============== Item was changed: ----- Method: PreferenceBrowser>>searchPreferencesFor: (in category 'preferences search') ----- searchPreferencesFor: pattern | result | result := pattern asString asLowercase withBlanksTrimmed. result ifEmpty: [^self]. searchResults := self allPreferences select: [:aPreference | ((aPreference name includesSubstring: result caseSensitive: false) or: [aPreference helpString includesSubstring: result caseSensitive: false]) + or: [aPreference codeString includesSubstring: result caseSensitive: false] + "for non-pragma preferences, #readableName is different from #name" + or: [aPreference readableName includesSubstring: result caseSensitive: false] ]. - or: [aPreference codeString includesSubstring: result caseSensitive: false] ]. self updateSearchResultsLabel. self selectSearchResultsCategory. self lastExecutedSearch: pattern. !

2 1

The Inbox: Morphic-ct.2152.mcz
by commits＠source.squeak.org 19 Jan '24

19 Jan '24

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.2152.mcz ==================== Summary ==================== Name: Morphic-ct.2152 Author: ct Time: 26 December 2023, 6:55:20.675309 pm UUID: 6ac2adc4-972f-5746-b337-3e0c6279fc48 Ancestors: Morphic-ct.2150 Proposal: In docking bar window menus, displays specific expand/collapse/contract operation based on current window status. Possible disadvantages: Labels might be harder to find without icon, labels might be out of date in the rare scenario that windows open or change themselves while a windows menu is opened. =============== Diff against Morphic-ct.2150 =============== Item was added: + ----- Method: SystemWindow>>isExpanded (in category 'resize/collapse') ----- + isExpanded + ^ self unexpandedFrame notNil! Item was changed: ----- Method: TheWorldMainDockingBar>>windowMenuFor:on: (in category 'submenu - windows') ----- windowMenuFor: window on: menu | closeBox closeBoxWidth | closeBox := SystemWindow closeBoxImage. closeBoxWidth := closeBox width. menu addItem: [ :item | item contents: 'Close' translated ; icon: closeBox; target: window; selector: #closeBoxHit ]; + addItem: [ :item | - addItem: [ :item | item + contents: (window isExpanded ifFalse: ['Expand' translated] ifTrue: ['Contract' translated]) ; - contents: 'Expand (or contract)' translated ; icon: (MenuIcons blankIconOfWidth: closeBoxWidth); target: window; selector: #expandBoxHit ]; addItem: [ :item | item + contents: (window isCollapsed ifFalse: ['Collapse' translated] ifTrue: ['Expand' translated]) ; - contents: 'Collapse (or expand)' translated ; icon: (MenuIcons blankIconOfWidth: closeBoxWidth); target: window; selector: #collapseOrExpand ]; addLine; addItem: [ :item | item contents: 'Close all like this' translated ; icon: closeBox; target: self; selector: #closeAllWindowsLike:; arguments: { window } ]; addItem: [ :item | item contents: 'Close all but this' translated ; icon: (MenuIcons blankIconOfWidth: closeBoxWidth); target: self; selector: #closeAllWindowsBut:; arguments: { window } ]; addLine; addItem: [ :item | item contents: 'Collapse all like this' translated ; icon: (MenuIcons blankIconOfWidth: closeBoxWidth); target: self; selector: #collapseAllWindowsLike:; arguments: { window } ]; addItem: [ :item | item contents: 'Collapse all but this' translated ; icon: (MenuIcons blankIconOfWidth: closeBoxWidth); target: self; selector: #collapseAllWindowsBut:; arguments: { window } ]!

2 1

The Inbox: Collections-ct.1060.mcz
by commits＠source.squeak.org 19 Jan '24

19 Jan '24

Christoph Thiede uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-ct.1060.mcz ==================== Summary ==================== Name: Collections-ct.1060 Author: ct Time: 27 December 2023, 11:59:34.927399 pm UUID: 97958301-3160-e74c-9b2f-46c22493a381 Ancestors: Collections-mt.1058 Speeds up printing of large sets. Analogously to dictionaries, do not sort and enumerate all their items beyond a threshold. =============== Diff against Collections-mt.1058 =============== Item was changed: ----- Method: Set>>printElementsOn: (in category 'printing') ----- printElementsOn: aStream "Like dictionaries, indicate some human-readable sort order." + self size > 100 ifTrue: + [aStream + nextPutAll: '(size '; + print: self size; + nextPut: $). + ^ self]. + self sortedSafely printElementsOn: aStream.!

2 1

The Inbox: OcompletionSqueakCompatibility-ct.4.mcz
by commits＠source.squeak.org 19 Jan '24

19 Jan '24

Christoph Thiede uploaded a new version of OcompletionSqueakCompatibility to project The Inbox: http://source.squeak.org/inbox/OcompletionSqueakCompatibility-ct.4.mcz ==================== Summary ==================== Name: OcompletionSqueakCompatibility-ct.4 Author: ct Time: 2 January 2024, 4:40:36.322236 pm UUID: e60e2311-1c14-4448-bc06-8966a8da2c36 Ancestors: OcompletionSqueakCompatibility-JohnMcKeon.3 Fixes unloading of OCompletion. ==================== Snapshot ==================== SystemOrganization addCategory: #OcompletionSqueakCompatibility! StandardToolSet subclass: #ECToolSet instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'OcompletionSqueakCompatibility'! ----- Method: ECToolSet class>>codeCompletionAround:textMorph:keyStroke: (in category 'completion') ----- codeCompletionAround: aBlock textMorph: aTextMorph keyStroke: evt | completionAllowed editor stringHolder | editor := aTextMorph editor. stringHolder := editor ifNotNil: [editor model]. completionAllowed := ECPreferences enabled and:[ ECController allowModel: stringHolder ]. completionAllowed ifTrue: [(stringHolder completionController handleKeystrokeBefore: evt editor: editor) ifTrue: [^ self]]. aBlock value. "sends to keyStroke event handler, if any" "Narrow the completion with any of the keys" completionAllowed ifTrue: [stringHolder completionController handleKeystrokeAfter: evt editor: editor]! ----- Method: ECToolSet class>>register (in category 'initialize-release') ----- register "Asks the system to use me when launching completion" ToolSet register: self! ----- Method: ECToolSet class>>unload (in category 'initialize-release') ----- unload self unregister.! ----- Method: ECToolSet class>>unregister (in category 'initialize-release') ----- unregister ToolSet unregister: self! ----- Method: SmalltalkEditor>>isCaretBehindChar (in category '*OcompletionSqueakCompatibility') ----- isCaretBehindChar "Return true if the cursor position is after an alphanumeric character, otherwise false." | cursorPosition | ^(cursorPosition := self startIndex) >= 2 and: [ (self text at: cursorPosition - 1) isAlphaNumeric ]! ----- Method: SmalltalkEditor>>selectionPosition: (in category '*OcompletionSqueakCompatibility') ----- selectionPosition: aString | startIndex | startIndex := self startIndex. ^[ | bottomLeft topLeft index | index := startIndex - aString size. self selectInvisiblyFrom: index to: index - 1. bottomLeft := paragraph selectionRects first bottomLeft. topLeft := self morph owner submorphBounds topLeft. topLeft + bottomLeft ] ensure: [ self selectInvisiblyFrom: startIndex to: startIndex - 1 ]! ----- Method: SmalltalkEditor>>wordAtCaret (in category '*OcompletionSqueakCompatibility') ----- wordAtCaret ^paragraph text asString wordBefore: self startIndex - 1 ! ----- Method: ParagraphEditor>>isCaretBehindChar (in category '*OcompletionSqueakCompatibility') ----- isCaretBehindChar "Return true if the cursor position is after an alphanumeric character, otherwise false." | cursorPosition | ^(cursorPosition := self startIndex) >= 2 and: [ (self text at: cursorPosition - 1) isAlphaNumeric ]! ----- Method: ParagraphEditor>>selectionPosition: (in category '*OcompletionSqueakCompatibility') ----- selectionPosition: aString | startIndex | startIndex := self startIndex. ^[ | bottomLeft topLeft index | index := startIndex - aString size. self selectInvisiblyFrom: index to: index - 1. bottomLeft := paragraph selectionRects first bottomLeft. topLeft := self morph owner submorphBounds topLeft. topLeft + bottomLeft ] ensure: [ self selectInvisiblyFrom: startIndex to: startIndex - 1 ]! ----- Method: ParagraphEditor>>wordAtCaret (in category '*OcompletionSqueakCompatibility') ----- wordAtCaret ^paragraph text asString wordBefore: self startIndex - 1 !

2 1

The Inbox: Collections-ct.1061.mcz
by commits＠source.squeak.org 19 Jan '24

19 Jan '24

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.1061.mcz ==================== Summary ==================== Name: Collections-ct.1061 Author: ct Time: 2 January 2024, 5:18:37.636112 pm UUID: 93dafbe2-e958-8f4b-b1ce-70cf12d7c4e2 Ancestors: Collections-mt.1058 Implements #sameAs: on Text. This fixes a bug in IndentingListItemMorph>>#openPath: when some nodes in the tree have formatted text labels. Not sure whether there should be more string casts around PluggableTreeItemNodes instead, though. See: https://lists.squeakfoundation.org/archives/list/squeak-dev@lists.squeakfou… Thanks to Jaromir (jar) for the bug report! =============== Diff against Collections-mt.1058 =============== Item was added: + ----- Method: Text>>sameAs: (in category 'comparing') ----- + sameAs: aStringOrText + "Answer whether the receiver sorts equal to aString. The collation sequence is ascii with case differences ignored." + + ^ self string sameAs: aStringOrText asString!

2 1

The Inbox: Graphics-ct.550.mcz
by commits＠source.squeak.org 19 Jan '24

19 Jan '24

Christoph Thiede uploaded a new version of Graphics to project The Inbox: http://source.squeak.org/inbox/Graphics-ct.550.mcz ==================== Summary ==================== Name: Graphics-ct.550 Author: ct Time: 2 January 2024, 10:01:10.078985 pm UUID: 07e886e9-269a-ed43-b18b-673d84020d97 Ancestors: Graphics-mt.549 Speeds up Form>>#magnifyBy: for scale = 1. #copy is faster by >75% using primitiveWarpBits and faster by >250% using the fallback code. In absolute numbers, this saves me 18ms for "magnifying" a screenshot of my world in full HD. =============== Diff against Graphics-mt.549 =============== Item was changed: ----- Method: Form>>magnifyBy: (in category 'scaling, rotation') ----- magnifyBy: scale "Answer a Form created as a scaling of the receiver. Scale may be a Float or even a Point, and may be greater or less than 1.0." | effectiveScale | effectiveScale := scale isPoint ifTrue: [scale r] ifFalse: [scale]. + effectiveScale = 1 ifTrue: [^ self copy]. ^ self magnify: self boundingBox by: scale smoothing: (effectiveScale < 1 ifTrue: [2] ifFalse: [1])!

2 1

The Inbox: HelpSystem-Core-ct.148.mcz
by commits＠source.squeak.org 19 Jan '24

19 Jan '24

Christoph Thiede uploaded a new version of HelpSystem-Core to project The Inbox: http://source.squeak.org/inbox/HelpSystem-Core-ct.148.mcz ==================== Summary ==================== Name: HelpSystem-Core-ct.148 Author: ct Time: 15 January 2024, 4:21:10.923083 pm UUID: 726d0b07-7f4e-3a4c-9c62-200777c8c542 Ancestors: HelpSystem-Core-ct.145 Proposal: Speeds up help search by caching sources. =============== Diff against HelpSystem-Core-ct.145 =============== Item was added: + ----- Method: SearchTopic>>cacheSourcesDuring: (in category 'private') ----- + cacheSourcesDuring: aBlock + "Some help topics, e.g., ClassAPIHelpTopic, frequently access the source files." + + ^ CurrentReadOnlySourceFiles cacheDuring: aBlock! Item was changed: ----- Method: SearchTopic>>doSearch (in category 'searching') ----- doSearch "Extension point. Subclasses may override this, e.g., to implement different search strategies." + self cacheSourcesDuring: [ + (self topicsToSearch + sorted: [:topic | topic priorityForSearch] ascending) + do: [:topic | + | nestedResults | + nestedResults := OrderedCollection new. + self mutex critical: [results add: topic -> nestedResults]. + self find: self term in: {topic} results: nestedResults]]. - (self topicsToSearch - sorted: [:t1 :t2 | t1 priorityForSearch <= t2 priorityForSearch]) - do: [:topic | - | nestedResults | - nestedResults := OrderedCollection new. - self mutex critical: [results add: topic -> nestedResults]. - self find: self term in: {topic} results: nestedResults]. results add: 'Search finished.' translated.!

3 2

The Trunk: Sound-mt.97.mcz
by commits＠source.squeak.org 19 Jan '24

19 Jan '24

Marcel Taeumel uploaded a new version of Sound to project The Trunk: http://source.squeak.org/trunk/Sound-mt.97.mcz ==================== Summary ==================== Name: Sound-mt.97 Author: mt Time: 15 January 2024, 6:41:20.905928 pm UUID: 122e8e23-da9c-9b48-b787-b6478bd54df7 Ancestors: Sound-ct.96 Fixes regression from Sound-tpr.93, which truncated too much during a sound's file-out. =============== Diff against Sound-ct.96 =============== Item was changed: ----- Method: AbstractSound>>storeSampleCount:bigEndian:on: (in category 'file i/o') ----- storeSampleCount: samplesToStore bigEndian: bigEndianFlag on: aBinaryStream "Store my samples on the given stream at the current SoundPlayer sampling rate. If bigFlag is true, then each 16-bit sample is stored most-significant byte first (AIFF files), otherwise it is stored least-significant byte first (WAV files). If self isStereo is true, both channels are stored, creating a stereo file. Otherwise, only the left channel is stored, creating a mono file." | bufSize stereoBuffer reverseBytes streamDirect | self reset. bufSize := (2 * self samplingRate rounded) min: samplesToStore. "two second buffer" stereoBuffer := SoundBuffer newStereoSampleCount: bufSize. streamDirect := aBinaryStream isKindOf: StandardFileStream. reverseBytes := (bigEndianFlag xor: Smalltalk isBigEndian) xor: streamDirect not. 'Storing audio...' displayProgressFrom: 0 to: samplesToStore during: [:bar | | remaining out | remaining := samplesToStore. [remaining > 0] whileTrue: [ bar value: samplesToStore - remaining. stereoBuffer primFill: 0. "clear the buffer" self playSampleCount: (bufSize min: remaining) into: stereoBuffer startingAt: 1. out := self isStereo ifTrue: [stereoBuffer] ifFalse: [stereoBuffer extractLeftChannel]. reverseBytes ifTrue: [out reverseEndianness]. streamDirect ifTrue: "optimization for files: write sound buffer directly to file" + [aBinaryStream next: (out size // 2 min: remaining) putAll: out startingAt: 1] "size in words" - [aBinaryStream next: (out size // 2 min: remaining// 2) putAll: out startingAt: 1] "size in words" ifFalse: "for non-file streams:" + [1 to: (out monoSampleCount min: remaining * 2) do: [:i | aBinaryStream int16: (out at: i)]]. - [1 to: (out monoSampleCount min: remaining) do: [:i | aBinaryStream int16: (out at: i)]]. remaining := remaining - bufSize]].!

3 2

← Newer
1
2
3
4
5
6
7
8
9
Older →