Squeak-dev January 2024

squeak-dev@lists.squeakfoundation.org

22 participants
89 discussions

The Inbox: System-jar.1446.mcz
by commits＠source.squeak.org 29 Jan '24

29 Jan '24

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-jar.1446.mcz ==================== Summary ==================== Name: System-jar.1446 Author: jar Time: 29 January 2024, 1:41:28.399781 pm UUID: fafea975-15ff-a94d-8bfc-a3c9feb44c78 Ancestors: System-dtl.1445 For discussion: A small modification of System-dtl.1445 to address the possibilty of two low space watcher processes running simultaneously if you run this example: [LowSpaceWatcher install] fork. [LowSpaceWatcher install] fork It's a contrived example but a real situation of this kind happened to me during my work on #terminate and confused me a great deal. In the current image the situation most likely can't happen by itself. If the low space watches is supposed to be a singleton then, for the sake of consistency, I'd vote for making sure the low space watcher can't start two processes concurrently. =============== Diff against System-dtl.1445 =============== Item was changed: Object subclass: #LowSpaceWatcher + instanceVariableNames: 'lowSpaceProcess lowSpaceSemaphore lowSpaceAccessProtect' - instanceVariableNames: 'lowSpaceProcess lowSpaceSemaphore' classVariableNames: 'Default MemoryHogs' poolDictionaries: '' category: 'System-Support'! !LowSpaceWatcher commentStamp: 'dtl 1/28/2024 17:56' prior: 0! LowSpaceWatcher is responsible for responding to a notification from the virtual machine that memory is low and that it (the VM) may soon be unable to support additional object memory allocations. A single default instance for the image manages both the low space semaphore and the process that waits on the semaphore to handle low space conditions. When the low space watcher is notified that memory is low, it attempts to identify the process likely associated with the low space condition and to provide a notifier to allow the problem condition to be corrected. If a low space condition is detected in the virtual machine, the low space semaphore is signalled either directly by the VM or indirectly through an OutOfMemory error following a failed primitive invocation. The VM is responsible for identifying low space conditions, and its behavior will vary depending on both the VM implementation and the memory system of the underlying platform operating system. In particular, on a virtual machine operating system the VM may continue to receive memory allocations from the operating system while the operating system attempts to support the memory requests by increased swapping to disk. Under these conditions, the low space semaphore may not be signalled because system memory still appears to be available, even though performance is severely degraded due to swapping. The VM may provide control of its memory usage, typically through command line parameters or VM parameters that can be set from the image. These parameters will affect when and if the low space watcher is signalled by the VM. A registry is maintained in class variable MemoryHogs to identify objects (classes) know how to release unneeded memory when sent the message #freeSomeSpace. The low space watcher process will send this message when a low spaced condition is encountered. To signal the low space watcher and simulate a low space condition, evaluate "LowSpaceWatcher default signalLowSpace".! Item was changed: ----- Method: LowSpaceWatcher class>>install (in category 'instance creation') ----- install "Start a process to watch for low-space conditions." "Smalltalk installLowSpaceWatcher" + self default lowSpaceAccessProtect critical: [self default stop; start] ifLocked: [] - self default stop; start - ! Item was added: + ----- Method: LowSpaceWatcher>>lowSpaceAccessProtect (in category 'process') ----- + lowSpaceAccessProtect + + ^lowSpaceAccessProtect ifNil: [lowSpaceAccessProtect := Mutex new]!

1 0

The Inbox: System-dtl.1445.mcz
by commits＠source.squeak.org 29 Jan '24

29 Jan '24

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-dtl.1445.mcz ==================== Summary ==================== Name: System-dtl.1445 Author: dtl Time: 28 January 2024, 8:13:53.851653 pm UUID: 8b191722-da0b-442e-ae5d-3e23a344e720 Ancestors: System-ct.1444 Add class LowSpaceWatcher and move the low space watcher from SmalltalkImage to LowSpaceWatcher. Let the low space watcher be a singleton with responsibility for the low space semaphore and low space watcher process. Add class and method comments to document intended behavior. Improve documentation of the low space watcher mechanism: HelpBrowser openOn: LowSpaceWatcher Also add #registerCleaner for adding savvy memory hogs to the memory hog registry. =============== Diff against System-ct.1444 =============== Item was added: + Object subclass: #LowSpaceWatcher + instanceVariableNames: 'lowSpaceProcess lowSpaceSemaphore' + classVariableNames: 'Default MemoryHogs' + poolDictionaries: '' + category: 'System-Support'! + + !LowSpaceWatcher commentStamp: 'dtl 1/28/2024 17:56' prior: 0! + LowSpaceWatcher is responsible for responding to a notification from the virtual machine that memory is low and that it (the VM) may soon be unable to support additional object memory allocations. A single default instance for the image manages both the low space semaphore and the process that waits on the semaphore to handle low space conditions. When the low space watcher is notified that memory is low, it attempts to identify the process likely associated with the low space condition and to provide a notifier to allow the problem condition to be corrected. + + If a low space condition is detected in the virtual machine, the low space semaphore is signalled either directly by the VM or indirectly through an OutOfMemory error following a failed primitive invocation. The VM is responsible for identifying low space conditions, and its behavior will vary depending on both the VM implementation and the memory system of the underlying platform operating system. In particular, on a virtual machine operating system the VM may continue to receive memory allocations from the operating system while the operating system attempts to support the memory requests by increased swapping to disk. Under these conditions, the low space semaphore may not be signalled because system memory still appears to be available, even though performance is severely degraded due to swapping. + + The VM may provide control of its memory usage, typically through command line parameters or VM parameters that can be set from the image. These parameters will affect when and if the low space watcher is signalled by the VM. + + A registry is maintained in class variable MemoryHogs to identify objects (classes) know how to release unneeded memory when sent the message #freeSomeSpace. The low space watcher process will send this message when a low spaced condition is encountered. + + To signal the low space watcher and simulate a low space condition, evaluate "LowSpaceWatcher default signalLowSpace".! Item was added: + ----- Method: LowSpaceWatcher class>>default (in category 'instance creation') ----- + default + "The singleton low space watcher." + + ^ Default ifNil: [ Default := self new start ] + ! Item was added: + ----- Method: LowSpaceWatcher class>>install (in category 'instance creation') ----- + install + "Start a process to watch for low-space conditions." + "Smalltalk installLowSpaceWatcher" + + self default stop; start + + ! Item was added: + ----- Method: LowSpaceWatcher class>>registerCleaner: (in category 'memory hog registry') ----- + registerCleaner: memoryCleaner + "Add memoryCleaner to the MemoryHog list where memoryCleaner is an object or class that responds to #freeSomeSpace." + + (memoryCleaner respondsTo: #freeSomeSpace) + ifFalse: [ ^ self error: memoryCleaner asString, ' does not understand #freeSomeSpace' ]. + (self default memoryHogs includes: memoryCleaner) + ifFalse: [ MemoryHogs add: memoryCleaner ].! Item was added: + ----- Method: LowSpaceWatcher class>>signalLowSpace (in category 'signal low space') ----- + signalLowSpace + "Signal the low-space semaphore to alert the user that space is running low." + + ^ self default signalLowSpace.! Item was added: + ----- Method: LowSpaceWatcher>>lowSpaceChoices (in category 'memory space') ----- + lowSpaceChoices + "Return a notifier message string to be presented when space is running low." + + ^ 'Warning!! Squeak is almost out of memory!! + + Low space detection is now disabled. It will be restored when you close or proceed from this error notifier. Don''t panic, but do proceed with caution. + + Here are some suggestions: + + If you suspect an infinite recursion (the same methods calling each other again and again), then close this debugger, and fix the problem. + + If you want this computation to finish, then make more space available (read on) and choose "proceed" in this debugger. Here are some ways to make more space available... + > Close any windows that are not needed. + > Get rid of some large objects (e.g., images). + > Leave this window on the screen, choose "save as..." from the screen menu, quit, restart the Squeak VM with a larger memory allocation, then restart the image you just saved, and choose "proceed" in this window. + + If you want to investigate further, choose "debug" in this window. Do not use the debugger "fullStack" command unless you are certain that the stack is not very deep. (Trying to show the full stack will definitely use up all remaining memory if the low-space problem is caused by an infinite recursion!!). + + ' + ! Item was added: + ----- Method: LowSpaceWatcher>>lowSpaceWatcher (in category 'process') ----- + lowSpaceWatcher + "Wait until the low space semaphore is signalled, then take appropriate actions." + + | free preemptedProcess | + Smalltalk garbageCollectMost <= Smalltalk lowSpaceThreshold + ifTrue: [self garbageCollect <= Smalltalk lowSpaceThreshold + ifTrue: ["free space must be above threshold before + starting low space watcher" + ^ Beeper beep]]. + + Smalltalk specialObjectsArray at: 23 put: nil. "process causing low space will be saved here" + lowSpaceSemaphore := Semaphore new. + self primLowSpaceSemaphore: lowSpaceSemaphore. + self primSignalAtBytesLeft: Smalltalk lowSpaceThreshold. "enable low space interrupts" + + lowSpaceSemaphore wait. "wait for a low space condition..." + + self primSignalAtBytesLeft: 0. "disable low space interrupts" + self primLowSpaceSemaphore: nil. + lowSpaceProcess := nil. + + "The process that was active at the time of the low space interrupt." + preemptedProcess := (Smalltalk specialObjectsArray at: 23) + ifNil: [Processor preemptedProcess "if in-image signal of OutOfMemory"]. + Smalltalk specialObjectsArray at: 23 put: nil. + + "Note: user now unprotected until the low space watcher is re-installed" + + self memoryHogs isEmpty + ifFalse: [free := Smalltalk bytesLeft. + self memoryHogs + do: [ :hog | hog freeSomeSpace ]. + self bytesLeft > free + ifTrue: [ ^ LowSpaceWatcher installLowSpaceWatcher ]]. + + Preferences logDebuggerStackToFile ifTrue: [ + self + logError: 'Space is low' + inContext: preemptedProcess suspendedContext + to: 'LowSpaceDebug.log']. + + Project current + interruptName: 'Space is low' + message: self lowSpaceChoices + preemptedProcess: preemptedProcess + ! Item was added: + ----- Method: LowSpaceWatcher>>lowSpaceWatcherProcess (in category 'process') ----- + lowSpaceWatcherProcess + "Answer the process in which lowSpaceWatcher is running. A process browser + can use this to identify and label the system wide low space watcher process." + ^lowSpaceProcess! Item was added: + ----- Method: LowSpaceWatcher>>memoryHogs (in category 'memory space') ----- + memoryHogs + "Answer the list of objects to notify with #freeSomeSpace if memory gets full." + + ^ MemoryHogs ifNil: [MemoryHogs := OrderedCollection new]! Item was added: + ----- Method: LowSpaceWatcher>>primLowSpaceSemaphore: (in category 'primitive access') ----- + primLowSpaceSemaphore: aSemaphore + "Primitive. Register the given Semaphore to be signalled when the + number of free bytes drops below some threshold. Disable low-space + interrupts if the argument is nil." + + <primitive: 124> + self primitiveFailed! Item was added: + ----- Method: LowSpaceWatcher>>primSignalAtBytesLeft: (in category 'primitive access') ----- + primSignalAtBytesLeft: numBytes + "Tell the interpreter the low-space threshold in bytes. When the free + space falls below this threshold, the interpreter will signal the low-space + semaphore, if one has been registered. Disable low-space interrupts if the + argument is zero. Fail if numBytes is not an Integer." + + <primitive: 125> + self primitiveFailed! Item was added: + ----- Method: LowSpaceWatcher>>signalLowSpace (in category 'memory space') ----- + signalLowSpace + "Signal the low-space semaphore to alert the user that space is running low." + + lowSpaceSemaphore signal.! Item was added: + ----- Method: LowSpaceWatcher>>start (in category 'initialize-release') ----- + start + "Start a new low space watcher process that will register a semaphore with the + virtual machine and wait for the semaphore to be signalled if a low space condition + is detected." + + lowSpaceProcess := [self lowSpaceWatcher] newProcess. + lowSpaceProcess priority: Processor lowIOPriority. + lowSpaceProcess resume. + ! Item was added: + ----- Method: LowSpaceWatcher>>stop (in category 'initialize-release') ----- + stop. + "Ask the virtual machine to disable low space interrupts, then terminate the watcher process." + + self primSignalAtBytesLeft: 0. "disable low-space interrupts" + lowSpaceProcess == nil ifFalse: [lowSpaceProcess terminate]. + lowSpaceProcess := lowSpaceSemaphore := nil. + ! Item was changed: Object subclass: #SmalltalkImage instanceVariableNames: 'globals' + classVariableNames: 'EndianCache LastImageName LastQuitLogPosition LastStats PlatformNameCache ShutDownList SourceFileVersionString StartUpList StartupStamp VMMakerVersion WordSize' - classVariableNames: 'EndianCache LastImageName LastQuitLogPosition LastStats LowSpaceProcess LowSpaceSemaphore MemoryHogs PlatformNameCache ShutDownList SourceFileVersionString StartUpList StartupStamp VMMakerVersion WordSize' poolDictionaries: '' category: 'System-Support'! !SmalltalkImage commentStamp: 'dtl 3/6/2010 14:00' prior: 0! I represent the current image and runtime environment, including system organization, the virtual machine, object memory, plugins and source files. My instance variable #globals is a reference to the system dictionary of global variables and class names. My singleton instance is called Smalltalk.! Item was changed: ----- Method: SmalltalkImage>>installLowSpaceWatcher (in category 'memory space') ----- installLowSpaceWatcher "Start a process to watch for low-space conditions." "Smalltalk installLowSpaceWatcher" + LowSpaceWatcher install - self primSignalAtBytesLeft: 0. "disable low-space interrupts" - LowSpaceProcess == nil ifFalse: [LowSpaceProcess terminate]. - LowSpaceProcess := [self lowSpaceWatcher] newProcess. - LowSpaceProcess priority: Processor lowIOPriority. - LowSpaceProcess resume. ! Item was removed: - ----- Method: SmalltalkImage>>lowSpaceChoices (in category 'memory space') ----- - lowSpaceChoices - "Return a notifier message string to be presented when space is running low." - - ^ 'Warning!! Squeak is almost out of memory!! - - Low space detection is now disabled. It will be restored when you close or proceed from this error notifier. Don''t panic, but do proceed with caution. - - Here are some suggestions: - - If you suspect an infinite recursion (the same methods calling each other again and again), then close this debugger, and fix the problem. - - If you want this computation to finish, then make more space available (read on) and choose "proceed" in this debugger. Here are some ways to make more space available... - > Close any windows that are not needed. - > Get rid of some large objects (e.g., images). - > Leave this window on the screen, choose "save as..." from the screen menu, quit, restart the Squeak VM with a larger memory allocation, then restart the image you just saved, and choose "proceed" in this window. - - If you want to investigate further, choose "debug" in this window. Do not use the debugger "fullStack" command unless you are certain that the stack is not very deep. (Trying to show the full stack will definitely use up all remaining memory if the low-space problem is caused by an infinite recursion!!). - - ' - ! Item was removed: - ----- Method: SmalltalkImage>>lowSpaceWatcher (in category 'memory space') ----- - lowSpaceWatcher - "Wait until the low space semaphore is signalled, then take appropriate actions." - - | free preemptedProcess | - self garbageCollectMost <= self lowSpaceThreshold - ifTrue: [self garbageCollect <= self lowSpaceThreshold - ifTrue: ["free space must be above threshold before - starting low space watcher" - ^ Beeper beep]]. - - Smalltalk specialObjectsArray at: 23 put: nil. "process causing low space will be saved here" - LowSpaceSemaphore := Semaphore new. - self primLowSpaceSemaphore: LowSpaceSemaphore. - self primSignalAtBytesLeft: self lowSpaceThreshold. "enable low space interrupts" - - LowSpaceSemaphore wait. "wait for a low space condition..." - - self primSignalAtBytesLeft: 0. "disable low space interrupts" - self primLowSpaceSemaphore: nil. - LowSpaceProcess := nil. - - "The process that was active at the time of the low space interrupt." - preemptedProcess := (Smalltalk specialObjectsArray at: 23) - ifNil: [Processor preemptedProcess "if in-image signal of OutOfMemory"]. - Smalltalk specialObjectsArray at: 23 put: nil. - - "Note: user now unprotected until the low space watcher is re-installed" - - self memoryHogs isEmpty - ifFalse: [free := self bytesLeft. - self memoryHogs - do: [ :hog | hog freeSomeSpace ]. - self bytesLeft > free - ifTrue: [ ^ self installLowSpaceWatcher ]]. - - Preferences logDebuggerStackToFile ifTrue: [ - self - logError: 'Space is low' - inContext: preemptedProcess suspendedContext - to: 'LowSpaceDebug.log']. - - Project current - interruptName: 'Space is low' - message: self lowSpaceChoices - preemptedProcess: preemptedProcess - ! Item was changed: ----- Method: SmalltalkImage>>lowSpaceWatcherProcess (in category 'memory space') ----- lowSpaceWatcherProcess + ^LowSpaceWatcher default ifNotNil: [ :watcher | watcher lowSpaceWatcherProcess ]! - ^LowSpaceProcess! Item was removed: - ----- Method: SmalltalkImage>>memoryHogs (in category 'memory space') ----- - memoryHogs - "Answer the list of objects to notify with #freeSomeSpace if memory gets full." - - ^ MemoryHogs ifNil: [MemoryHogs := OrderedCollection new]! Item was removed: - ----- Method: SmalltalkImage>>primLowSpaceSemaphore: (in category 'memory space') ----- - primLowSpaceSemaphore: aSemaphore - "Primitive. Register the given Semaphore to be signalled when the - number of free bytes drops below some threshold. Disable low-space - interrupts if the argument is nil." - - <primitive: 124> - self primitiveFailed! Item was removed: - ----- Method: SmalltalkImage>>primSignalAtBytesLeft: (in category 'memory space') ----- - primSignalAtBytesLeft: numBytes - "Tell the interpreter the low-space threshold in bytes. When the free - space falls below this threshold, the interpreter will signal the low-space - semaphore, if one has been registered. Disable low-space interrupts if the - argument is zero. Fail if numBytes is not an Integer." - - <primitive: 125> - self primitiveFailed! Item was removed: - ----- Method: SmalltalkImage>>signalLowSpace (in category 'memory space') ----- - signalLowSpace - "Signal the low-space semaphore to alert the user that space is running low." - - LowSpaceSemaphore signal.!

1 0

UKSTUG Meeting - Pierre Misse-Chanabier: Polyphemus Take 2 - 31 January 2024
by Giovanni Corriga 26 Jan '24

26 Jan '24

Pierre Misse-Chanabier will talk to us about Polyphemus ( https://github.com/hogoww/Polyphemus ) for the Pharo Virtual Machine. The presentation will focus on how to create Tooling on the Pharo Virtual Machine. (This does not require Virtual machine level knowledge). We will start by taking a look at a few existing tools. We will create one or two small tools, and see how they differ from tooling on the image side. Pierre Misse Chanabier is a recently graduated PhD with a focused interest on Virtual Machines, Code Generation, and Meta Programming. He worked on and contributed to many different levels and parts of the Pharo ecosystem. He is now working on how to leverage images for more than what they do now. He's currently working at Microdoc ( https://www.microdoc.com ) on the Graal VM. Born in south of France, he currently lives in Lille. This will be an online meeting from home. This is a repeat of last November's presentation that could not go ahead due to issues with our Zoom account. If you'd like to join us, please sign up in advance on the meeting's Meetup page ( https://www.meetup.com/ukstug/events/298169915/ ) to receive the meeting details. Don’t forget to bring your laptop and drinks!

1 0

The Trunk: EToys-dtl.514.mcz
by commits＠source.squeak.org 26 Jan '24

26 Jan '24

David T. Lewis uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-dtl.514.mcz ==================== Summary ==================== Name: EToys-dtl.514 Author: dtl Time: 25 January 2024, 8:39:46.674876 pm UUID: d24c10b7-ab08-4976-8072-02f4cd8791c6 Ancestors: EToys-dtl.513 Morph>>wantsConnectorVocabulary is implemented also in Connectors but sent only from Etoys. Move it to package Etoys. =============== Diff against EToys-dtl.513 =============== Item was added: + ----- Method: Morph>>wantsConnectorVocabulary (in category '*Etoys-connectors-scripting') ----- + wantsConnectorVocabulary + "Answer true if I want to show a 'connector' vocabulary" + ^false!

1 0

The Trunk: Morphic-dtl.2151.mcz
by commits＠source.squeak.org 26 Jan '24

26 Jan '24

David T. Lewis uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-dtl.2151.mcz ==================== Summary ==================== Name: Morphic-dtl.2151 Author: dtl Time: 25 January 2024, 8:38:25.233159 pm UUID: af941037-f099-46a2-8af2-8ce1ce5b9a17 Ancestors: Morphic-ct.2150 Morph>>wantsConnectorVocabulary is implemented also in Connectors but sent only from Etoys. Move it to package Etoys. =============== Diff against Morphic-ct.2150 =============== Item was removed: - ----- Method: Morph>>wantsConnectorVocabulary (in category 'connectors-scripting') ----- - wantsConnectorVocabulary - "Answer true if I want to show a 'connector' vocabulary" - ^false!

1 0

Raspberry Pi lib camera plugin
by Tim Rowledge 24 Jan '24

24 Jan '24

A while back the Pi camera support changed to use the libcamera system, which is apparently 'the new thing for linux'. This means that that the current CameraPlugin doesn't, as it were. Before I spend too much time trying to wrap my ageing brain around the new library I thought I'd ask if anyone has already done any work on this. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Useful random insult:- Proof that evolution CAN go in reverse.

2 1

The Inbox: Kernel-jar.1554.mcz
by commits＠source.squeak.org 23 Jan '24

23 Jan '24

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-jar.1554.mcz ==================== Summary ==================== Name: Kernel-jar.1554 Author: jar Time: 23 January 2024, 3:43:30.880479 pm UUID: 7ceb0fd5-d407-b747-a8fd-7549b90acaff Ancestors: Kernel-mt.1551 fix a deficiency in the unwind procedure; the bug manifested in Christoph's heavily multithreded environment in the Simulation Studio. the exact mechanism of the bug: when a process is in the middle of an unwind (during e.g. exception resume etc) and is terminated, i.e. another unwind invoked, at a certain instruction the termination fails to unwind correctly. Currently, the unwind block is mark as completed before the execution of the block starts (see #ensure: or #unwindTo:safely: - the complete variable is set to true). The fix is to add another mark to indicate the unwind block execution has really completed (for simplicity this is achieved by setting the complete variable to false and this mark is used at #unwindTo:safely: to distinguish not yet completed unwind blocks and the really completed ones). If this proves a good fix the name of the `complete` variable defined in #ensure: may be changed to better correspond to this extended "semantics" of the variable :) =============== Diff against Kernel-mt.1551 =============== Item was changed: ----- Method: Context>>unwindTo:safely: (in category 'private-exceptions') ----- unwindTo: aContext safely: aBoolean "Unwind self to aContext to execute pending #ensure:/#ifCurtailed: argument blocks between self and aContext. If aBoolean is false, unwind only blocks that have not run yet, otherwise complete all pending unwind blocks including those currently in the middle of their execution; these blocks will just finish their execution. Run all unwinds on their original stack using #runUntilReturnFrom:." | top ctx | ctx := top := self. aBoolean ifTrue: [ "If self is the top context of a stack already halfways through an unwind block, complete the outer-most unfinished unwind block first; all nested pending unwind blocks will be completed in the process; see testTerminationDuringUnwind and tests in ProcessTest/UnwindTest. Note: Halfway-through blocks have already set the complete variable (ctxt tempAt: 2) in their defining #ensure:/#ifCurtailed contexts from nil to true; we'll search for the bottom-most one." | outerMost | ctx isUnwindContext ifFalse: [ctx := ctx findNextUnwindContextUpTo: aContext]. [ctx isNil] whileFalse: [ + (ctx tempAt: 2) ifNotNil: [:notYetComplete | + notYetComplete ifTrue: [outerMost := ctx]]. - (ctx tempAt: 2) ifNotNil: [ - outerMost := ctx]. ctx := ctx findNextUnwindContextUpTo: aContext]. outerMost ifNotNil: [top := top runUntilReturnFrom: outerMost]]. "By now no halfway-through unwind blocks are on the stack. Note: top points to the former outerMost sender now, i.e. to the next context to be explored." ctx := top ifNil: [^self]. "#findNextUnwindContextUpTo: starts searching from the receiver's sender so we must check the receiver explicitly whether it is an unwind context; see testTerminateEnsureAsStackTop. Create a new top context (i.e. a new branch off the original stack) for each pending unwind block (ctxt tempAt: 1) and execute it on the unwind block's stack to evaluate non-local returns correctly." ctx isUnwindContext ifFalse: [ctx := ctx findNextUnwindContextUpTo: aContext]. [ctx isNil] whileFalse: [ (ctx tempAt: 2) ifNil: [ ctx tempAt: 2 put: true. (ctx tempAt: 1) ifNotNil: [:unwindBlock | top := unwindBlock asContextWithSender: ctx. top runUntilReturnFrom: top]]. + ctx tempAt: 2 put: false. "mark the unwind block as completed; cf. notYetComplete temp above" ctx := ctx findNextUnwindContextUpTo: aContext] "Note: Cf. the unwind pattern in the previous versions of unwindTo: (1999-2021). Using #value instead of #runUntilReturnFrom: lead to a failure to evaluate some non-local returns correctly; a non-local return must be evaluated in the evaluation context (sender chain) in which it was defined."!

1 0

The Inbox: WebClient-Core-ct.136.mcz
by commits＠source.squeak.org 23 Jan '24

23 Jan '24

Christoph Thiede uploaded a new version of WebClient-Core to project The Inbox: http://source.squeak.org/inbox/WebClient-Core-ct.136.mcz ==================== Summary ==================== Name: WebClient-Core-ct.136 Author: ct Time: 23 January 2024, 10:25:18.473015 am UUID: ca5bdcb6-155a-8a43-8c3f-6c6f79b704c5 Ancestors: WebClient-Core-tpr.135 Allows web server to handle OPTIONS requests manually. For instance, this is required to handle CORS preflight stuff properly. =============== Diff against WebClient-Core-tpr.135 =============== Item was changed: ----- Method: WebServer>>dispatchRequest:url: (in category 'handling') ----- dispatchRequest: request url: dispatchUrl "Look up the handler for a given url and dispatch to it" | entryUrl action | "Handle TRACE requests right away" request method = 'TRACE' ifTrue:[ ^request send200Response: request asString contentType: 'message/http'. ]. "Look up the entry point for the request" action := nil. entryUrl := dispatchUrl asLowercase. (entryUrl beginsWith: '/') ifFalse:[entryUrl := '/', entryUrl]. mutex critical:[ [entryUrl notEmpty and:[action == nil]] whileTrue: [ action := entryPoints at: entryUrl ifAbsent:[nil]. entryUrl := entryUrl copyUpToLast: $/. ]. action ifNil:[action := entryPoints at: '/' ifAbsent:[nil]]. ]. "Handle OPTIONS requests" + (request method = 'OPTIONS' + and: [((action at: 1) includes: request method) not] "action handles the request manually, (e.g.., to provide CORS headers)") ifTrue:[ - request method = 'OPTIONS' ifTrue:[ "HEAD, TRACE, and OPTIONS are always supported" request sendOptionsResponse: self builtinHttpMethods, (action ifNil:[self defaultHttpMethods] ifNotNil:[action first]) ]. "Handle 404 not found" action ifNil:[^request send404Response]. "Handle 405 method not allowed" (request method = 'HEAD' "builtin" or:[(action at: 1) includes: request method]) ifFalse:[ ^request send405Response: self builtinHttpMethods, action first. ]. ^[self invokeAction: (action at: 2) request: request] on: Error do:[:ex| errorHandler ifNil:[self handleError: ex request: request] ifNotNil:[errorHandler value: ex value: request] ]. !

1 0

Review Request: whenEvaluateEnoughArguments.1.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 19 Jan '24

19 Jan '24

=============== Summary =============== Change Set: whenEvaluateEnoughArguments Date: 15 August 2023 Author: Christoph Thiede Proposal: Tolerates superfluous arguments/missing parameters in Object Events block for #when:evaluate:. As required, implements valueWithEnoughArguments:[otherwise:|startingFrom:] on action sequences, message sends, etc. See Object>>#triggerEvent:withArguments:. Example: Object new when: #plonk evaluate: [Transcript showln: 'griffle']; triggerEvent: #plonk with: 42. Reasoning: Provide optional arguments with object events without forcing all observers to receive them. =============== Diff =============== ActionSequence>>valueWithEnoughArguments: {evaluating} · ct 8/15/2023 09:57 + valueWithEnoughArguments: anArray + "Evaluate the elements of the receiver with enough arguments and answer the result of last evaluation." + + ^self inject: nil into: + [:previousAnswer :each | each valueWithEnoughArguments: anArray] BlockClosure>>valueWithEnoughArguments:otherwise: {evaluating} · ct 8/15/2023 09:59 + valueWithEnoughArguments: anArray otherwise: aBlock + + ^ self valueWithEnoughArguments: anArray MessageSend>>valueWithEnoughArguments:otherwise: {evaluating} · ct 8/15/2023 09:59 + valueWithEnoughArguments: anArray otherwise: aBlock + + ^ self valueWithEnoughArguments: anArray Object>>triggerEvent:withArguments: {*System-Object Events-accessing-triggering} · ct 8/15/2023 09:59 (changed) triggerEvent: anEventSelector withArguments: anArgumentList ^(self actionForEvent: anEventSelector) - valueWithArguments: anArgumentList + valueWithEnoughArguments: anArgumentList Object>>valueWithEnoughArguments: {evaluating} · ct 8/15/2023 10:00 + valueWithEnoughArguments: aSequenceOfArguments + + ^ self WeakActionSequence>>valueWithEnoughArguments: {evaluating} · ct 8/15/2023 09:58 + valueWithEnoughArguments: anArray + "Return the last result" + + ^self inject: nil into: [ :previousAnswer :each | + each valueWithEnoughArguments: anArray otherwise: [ previousAnswer ]] WeakActionSequenceTrappingErrors>>valueWithEnoughArguments: {evaluating} · ct 8/15/2023 09:59 + valueWithEnoughArguments: anArray + "Do the same as my parent, but make sure that all actions that do not + give errors are evaluated before resignaling the ones that gave errors + (giving the chance to clients to handle them)." + + ^self valueWithEnoughArguments: anArray startingFrom: 1 WeakActionSequenceTrappingErrors>>valueWithEnoughArguments:startingFrom: {evaluating} · ct 8/15/2023 09:59 + valueWithEnoughArguments: anArray startingFrom: startIndex + "Do the same as my parent, but make sure that all actions that do not + give errors are evaluated before resignaling the ones that gave errors + (giving the chance to clients to handle them)." + + "Note: I currently trap Halt,Error so that I am sure to get a Halt event in case of a Halt. This is being fixed in the exception system - when the fix is done it will be enough to capture only Error." + + | each answer | + answer := nil. + startIndex to: self size do: [:index | + each := self at: index. + [ + answer := each valueWithEnoughArguments: anArray otherwise: [ answer ]. + ] + on: Halt , Error + do: [:exc | + self valueWithEnoughArguments: anArray startingFrom: index + 1. + exc pass]]. + ^ answer WeakMessageSend>>valueWithEnoughArguments:otherwise: {evaluating} · ct 8/15/2023 09:58 + valueWithEnoughArguments: anArray otherwise: aBlock + | argsToUse | + + "Safe to use, because they are built before ensureing receiver and args..." + argsToUse := self collectArguments: anArray. + ^ self + withEnsuredReceiverAndArgumentsDo: [ :r :a | + r + perform: selector + withEnoughArguments: argsToUse ] + otherwise: aBlock --- Sent from Squeak Inbox Talk ["whenEvaluateEnoughArguments.1.cs"]

2 1

Review Request: browseCorePackageOfExtensionMethod.1.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 19 Jan '24

19 Jan '24

=============== Summary =============== Change Set: browseCorePackageOfExtensionMethod Date: 15 August 2023 Author: Christoph Thiede Proposal: In browsers, adds item 'browse core package' to context menu of extension category (stubs). Hides irrelevant menu items when no category is selected. Adds interface on Categorizer and PackageOrganizer for finding case-insensitive names. =============== Diff =============== Browser>>browsePackageOfExtensionMethod {message category functions} · ct 8/15/2023 12:06 + browsePackageOfExtensionMethod + + | category sepIndex | + category := self selectedMessageCategoryName ifNil: [^ self changed: #flash]. + (category beginsWith: '*') ifFalse: [^ self changed: #flash]. + category := category allButFirst. + [(self systemOrganizer findCategoryName: category caseSensitive: false) ifNotNil: [:actualCategory | + ^ ToolSet browseCategory: actualCategory]. + (self environment packageOrganizer findPackageNamed: category caseSensitive: false) ifNotNil: [:package | + ^ (SystemBrowser default includesBehavior: TreeBrowser) + ifTrue: [ToolSet browseCategory: package name] + ifFalse: [ToolSet browsePackage: package]]. + sepIndex := category lastIndexOf: $- ifAbsent: [^ self changed: #flash]. + category := category first: sepIndex - 1] repeat. + + "examples: + '*JSON' -> package JSON + '*system-support' -> syscat System-Support + '*Morphic-Events-Filtering' -> syscat Morphic-Events" Browser>>mainMessageCategoryMenu: {message category functions} · ct 8/15/2023 11:48 (changed) mainMessageCategoryMenu: aMenu <messageCategoryMenu> - ^ aMenu addList: #( + self selectedMessageCategoryName ifNotNil: [:cat | + aMenu addTranslatedList: #( ('browse' buildMessageCategoryBrowser) ('browse all' browseAllMethodsInCategory) - ('browse all related' browseAllMethodsInCategoryToken) + ('browse all related' browseAllMethodsInCategoryToken)). + (cat beginsWith: '*') ifTrue: [ + aMenu addTranslatedList: #( + ('browse core package' browsePackageOfExtensionMethod))]]. + aMenu addTranslatedList: #( - ('print out' printOutMessageCategories) ('file out' fileOutMessageCategories) - ('reorganize' editMessageCategories) ('alphabetize' alphabetizeMessageCategories) ('remove empty categories' removeEmptyCategories) ('categorize all uncategorized' categorizeAllUncategorizedMethods) - ('new category...' addCategory) + ('new category...' addCategory)). + self selectedMessageCategoryName ifNotNil: [ + aMenu addTranslatedList: #( - ('rename...' renameCategory) - ('remove (x)' removeMessageCategory)); - yourself + ('remove (x)' removeMessageCategory))]. + ^ aMenu Categorizer>>findCategoryName:caseSensitive: {accessing} · ct 8/15/2023 11:44 + findCategoryName: categoryName caseSensitive: caseSensitive + + ^ categoryArray + detect: [:category | + (categoryName compare: category caseSensitive: caseSensitive) = 2] + ifNone: [nil] PackageOrganizer>>findPackageName:caseSensitive: {searching} · ct 8/15/2023 11:44 + findPackageName: aString caseSensitive: caseSensitive + ^ packages keys + detect: [:name | + (name compare: aString caseSensitive: caseSensitive) = 2] + ifNone: [nil] PackageOrganizer>>findPackageNamed:caseSensitive: {searching} · ct 8/15/2023 11:46 + findPackageNamed: aString caseSensitive: caseSensitive + | name | + name := self findPackageName: aString caseSensitive: caseSensitive. + ^ self packageNamed: name ifAbsent: [nil] PackageOrganizer>>hasPackageNamed: {searching} · ct 8/15/2023 11:33 + hasPackageNamed: aString + ^ packages includesKey: aString PackageOrganizer>>hasPackageNamed:caseSensitive: {searching} · ct 8/15/2023 11:35 + hasPackageNamed: aString caseSensitive: caseSensitive + caseSensitive ifTrue: [^ self hasPackageNamed: aString]. + ^ packages keys anySatisfy: [:name | aString sameAs: name] --- Sent from Squeak Inbox Talk ["browseCorePackageOfExtensionMethod.1.cs"]

2 1

← Newer
1
2
3
4
5
6
7
8
9
Older →