Squeak-dev January 2024

squeak-dev@lists.squeakfoundation.org

22 participants
89 discussions

The Inbox: KernelTests-ct.387.mcz
by commits＠source.squeak.org 24 Feb '24

24 Feb '24

A new version of KernelTests was added to project The Inbox: http://source.squeak.org/inbox/KernelTests-ct.387.mcz ==================== Summary ==================== Name: KernelTests-ct.387 Author: ct Time: 24 October 2020, 12:40:40.526058 am UUID: aa73c56f-88e1-3b4d-9d59-fb29df3363a7 Ancestors: KernelTests-ul.386 Adds regression test for Kernel-ct.1355 (source logging after SyntaxError). Should I invest further complexity into this test for the purpose of keeping the production source logs clean? =============== Diff against KernelTests-ul.386 =============== Item was added: + ----- Method: ClassDescriptionTest>>testLogSourceAfterReparseSyntaxError (in category 'testing') ----- + testLogSourceAfterReparseSyntaxError + + | class source | + SystemChangeNotifier uniqueInstance doSilently: [[ + class := Object newSubclass. + source := 'foo [x'. + [class compile: source] + on: SyntaxErrorNotification do: [:error | + error resume: (source := source , ']')]. + self assert: source equals: (class sourceCodeAt: #foo) asString. + ] ensure: [class removeFromSystem]].! Item was changed: + ----- Method: ClassDescriptionTest>>testOrganization (in category 'testing') ----- - ----- Method: ClassDescriptionTest>>testOrganization (in category 'tests') ----- testOrganization | aClassOrganizer | aClassOrganizer := ClassDescription organization. self assert: (aClassOrganizer isKindOf: ClassOrganizer).!

3 2

The Inbox: Kernel-ct.1292.mcz
by commits＠source.squeak.org 24 Feb '24

24 Feb '24

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-ct.1292.mcz ==================== Summary ==================== Name: Kernel-ct.1292 Author: ct Time: 3 January 2020, 2:21:26.297116 am UUID: 95936a10-85a4-734e-a10b-0f87290b70f9 Ancestors: Kernel-nice.1291 Proposal: Implement conditional exception handling on blocks. The nomenclature is inspired from usual practice in .NET languages. For an impression of possible users, have a look at: self systemNavigation browseMessageList: ((self systemNavigation allCallsOn: #on:do: and: #pass) intersection: (#(ifTrue: ifFalse: ifTrue:ifFalse: ifFalse:ifTrue:) gather: [:sel | self systemNavigation allCallsOn: sel])) name: 'Potential users of #on:when:do:' =============== Diff against Kernel-nice.1291 =============== Item was added: + ----- Method: BlockClosure>>on:when:do: (in category 'exceptions') ----- + on: exceptionOrExceptionSet when: aPredicate do: handlerAction + + ^ self + on: exceptionOrExceptionSet + do: [:exception | + (aPredicate value: exception) + ifTrue: [handlerAction cull: exception] + ifFalse: [exception pass]]! Item was added: + ----- Method: BlockClosure>>on:when:ensure: (in category 'exceptions') ----- + on: exceptionOrExceptionSet when: aPredicate ensure: aBlock + + ^ self + on: exceptionOrExceptionSet + do: [:exception | + (aPredicate value: exception) + ifTrue: [aBlock value]. + exception pass]!

9 17

The Inbox: Kernel-nice.1294.mcz
by commits＠source.squeak.org 24 Feb '24

24 Feb '24

Nicolas Cellier uploaded a new version of Kernel to project The Inbox: http://source.squeak.org/inbox/Kernel-nice.1294.mcz ==================== Summary ==================== Name: Kernel-nice.1294 Author: nice Time: 6 February 2020, 10:00:19.603883 pm UUID: c78e67da-95e5-42ad-af82-089c149f165d Ancestors: Kernel-tonyg.1293 Complex log function was missing (base 10 logarithm) Complex already provides ln and log:, so why not log? =============== Diff against Kernel-tonyg.1293 =============== Item was added: + ----- Method: Complex>>log (in category 'mathematical functions') ----- + log + "Answer the base 10 logarithm of the receiver." + + ^self ln / 10 ln!

2 1

#asByteArray needed for more classes, maybe
by Tim Rowledge 18 Feb '24

18 Feb '24

Whilst testing out Seaside in the 6.1 trunk image we discovered that LargePositiveInteger needs an #asByteArray method to enable the entity tag method to provide all that nice formatting stuff. For the specific case of LPI it's trivial "self as: ByteArray" works fine and sure, maybe it could be optimised. However, there is actual usage of #asByteArray in the main image that appears to be unsatisfied. For example, Magnitude>>#putOn: for binary streams. It appears no subclass of Magnitude implements #asByteArray, which seems unfortunate.#putOn: is used a fair bit in writing to streams. There's also some clashing with potentially important behaviour where collections of (very)smallintegers can be converted to ByteArrays so long as all the numeric values are <255. If we were to make an #asByteArray for SmallInteger that produced up to 8 bytes, how might that affect some of these usages? And what is a good byte array representation of a LargeNegativeInteger? And should every conversion be reversible? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: EF: Emulate Fireworks

11 33

infinite recursion on updating
by Eliot Miranda 03 Feb '24

03 Feb '24

Hi All, I'm guessing there's some package ordering update missing to ensure the new debugger cue is defined. I just attempted to update a VMMaker image and got the following infinite recursion: 0x1465199e8 s UndefinedObject>handleSignal: 0x1186898e0: a(n) UndefinedObject 0x146518030 s MessageNotUnderstood(Exception)>signal 0x146517c30: a(n) MessageNotUnderstood 0x146517818 s UndefinedObject(Object)>doesNotUnderstand: new 0x1186898e0: a(n) UndefinedObject 0x146517c78 s ProcessorScheduler>debugContext:title:full:contents: 0x11869afe0: a(n) ProcessorScheduler 0x1465180e8 s ECToolSet class(StandardToolSet class)>handleError: 0x1195d6c88: a(n) ECToolSet 0x146518500 s ToolSet class>handleError: 0x118a26690: a(n) ToolSet 0x146518900 s UnhandledError>defaultAction 0x146518e50: a(n) UnhandledError 0x146518d98 s UndefinedObject>handleSignal: 0x1186898e0: a(n) UndefinedObject 0x1465191d0 s UnhandledError(Exception)>signal 0x146518e50: a(n) UnhandledError 0x146519668 s UnhandledError class>signalForException: 0x118a27df8: a(n) UnhandledError 0x146519aa0 s MessageNotUnderstood(Error)>defaultAction 0x1465185b8: a(n) MessageNotUnderstood 0x146519f38 s MessageNotUnderstood>defaultAction 0x1465185b8: a(n) MessageNotUnderstood 0x14651a370 s UndefinedObject>handleSignal: 0x1186898e0: a(n) UndefinedObject 0x1465189b8 s MessageNotUnderstood(Exception)>signal 0x1465185b8: a(n) MessageNotUnderstood 0x1465181a0 s UndefinedObject(Object)>doesNotUnderstand: new 0x1186898e0: a(n) UndefinedObject 0x146518600 s ProcessorScheduler>debugContext:title:full:contents: 0x11869afe0: a(n) ProcessorScheduler 0x146518a70 s ECToolSet class(StandardToolSet class)>handleError: 0x1195d6c88: a(n) ECToolSet 0x146518e88 s ToolSet class>handleError: 0x118a26690: a(n) ToolSet 0x146519288 s UnhandledError>defaultAction 0x1465197d8: a(n) UnhandledError 0x146519720 s UndefinedObject>handleSignal: 0x1186898e0: a(n) UndefinedObject 0x146519b58 s UnhandledError(Exception)>signal 0x1465197d8: a(n) UnhandledError 0x146519ff0 s UnhandledError class>signalForException: 0x118a27df8: a(n) UnhandledError 0x14651a428 s MessageNotUnderstood(Error)>defaultAction 0x146518f40: a(n) MessageNotUnderstood 0x14651a8c0 s MessageNotUnderstood>defaultAction 0x146518f40: a(n) MessageNotUnderstood 0x14651acf8 s UndefinedObject>handleSignal: 0x1186898e0: a(n) UndefinedObject 0x146519340 s MessageNotUnderstood(Exception)>signal 0x146518f40: a(n) MessageNotUnderstood 0x146518b28 s UndefinedObject(Object)>doesNotUnderstand: new 0x1186898e0: a(n) UndefinedObject 0x146518f88 s ProcessorScheduler>debugContext:title:full:contents: 0x11869afe0: a(n) ProcessorScheduler 0x1465193f8 s ECToolSet class(StandardToolSet class)>handleError: 0x1195d6c88: a(n) ECToolSet 0x146519810 s ToolSet class>handleError: 0x118a26690: a(n) ToolSet 0x146519c10 s UnhandledError>defaultAction 0x14651a160: a(n) UnhandledError 0x14651a0a8 s UndefinedObject>handleSignal: 0x1186898e0: a(n) UndefinedObject 0x14651a4e0 s UnhandledError(Exception)>signal 0x14651a160: a(n) UnhandledError 0x14651a978 s UnhandledError class>signalForException: 0x118a27df8: a(n) UnhandledError 0x14651adb0 s MessageNotUnderstood(Error)>defaultAction 0x1465198c8: a(n) MessageNotUnderstood 0x14651b248 s MessageNotUnderstood>defaultAction 0x1465198c8: a(n) MessageNotUnderstood 0x14651b680 s UndefinedObject>handleSignal: 0x1186898e0: a(n) UndefinedObject 0x146519cc8 s MessageNotUnderstood(Exception)>signal 0x1465198c8: a(n) MessageNotUnderstood 0x1465194b0 s UndefinedObject(Object)>doesNotUnderstand: new 0x1186898e0: a(n) UndefinedObject 0x146519910 s ProcessorScheduler>debugContext:title:full:contents: 0x11869afe0: a(n) ProcessorScheduler _,,,^..^,,,_ best, Eliot

7 30

lowMemoryWatcher--a different question
by Hal Eden 02 Feb '24

02 Feb '24

Hi all. i’ve been wanting to send this for a while but haven’t been receiving the squeak lists, so i wasn’t sure if it might have been discussed as part of the low-memory-watcher discussion. i was working to get my subscription to the mailing working to no avail. however, i have reviewed the archives and it doesn’t appear that this aspect has been raised. btw, i finally registered with my gmail address instead, so i’m getting the list again. since i’m seeing some traffic on lowSpaceWatcher, i thought i’d send this along. we are running an ancient swiki server (squeak 3.7, swiki 1.5—same as wiki.squeak.org, i guess) and we will occasionally have it go into a low space condition displaying the “space is low” debug window even though the Memory Usage Morph indicates there is a reasonable amount of memory available. in addition i don’t seem to be able to escape out of the “space is low” debug window once this happens. i’m not asking for a fix to an old Squeak version, just wondering what might be a reasonable approach here and whether the insights might still inform current systems. in looking at what might cause this, it seems that this is triggered when a “new:” (rather “basicNew:”) primitive fails. i understand that the VM primitive only returns success or failure, so the reason why it fails is assumed to be low memory, thus the low space condition trigger. of course, i haven’t been able to get this to happen in production since i started looking into it, so i don’t have any debug traces to look at and trace back the real cause. so i tried Array new: <a very large number> and was able to trigger the condition, and indeed the memory variables still show space available (Smalltalk bytesLeft is still much greater than Smalltalk lowSpaceThreshold), which would seem to indicate that the issue is not “low memory” but “impossible request” (i know this is somewhat of a distinction without a difference, since if a new: request fails it is effectively an “impossible request” but the difference i see is that the request is much larger than is usual in the system, and this occurs when memoryLeft is much greater than lowSpaceThreshold, i.e., space is NOT low) i imagine that when this happens within a swiki/comanche request, it is caused by someone trying to overflow a buffer or something using http. when i do it from a workspace, the "space is low” debug window is triggered, but i am able to abandon it. what i wonder is whether some other error should be raised in this case rather than signalling low memory. if one were to check the state of the memory variables before signalling "out of memory” it might avoid this. but i’m not sure what error should be raised in this case. i guess some report of an “impossible” request in the web log might be useful. i haven’t been able to replicate this in newer versions of squeak with a more robust memory handling system, since it seems to rely more on virtual memory than on some sort of fixed allocation. but the code appears to do the same thing if “basicNew:” fails, so perhaps insights might be applicable here although it seems very difficult to trigger in new systems. (of course, i don’t think anyone has ported the swiki to newer systems?) anyway, your insights would be appreciated. hal

3 5

The Inbox: KernelTests-jar.418.mcz
by commits＠source.squeak.org 01 Feb '24

01 Feb '24

A new version of KernelTests was added to project The Inbox: http://source.squeak.org/inbox/KernelTests-jar.418.mcz ==================== Summary ==================== Name: KernelTests-jar.418 Author: jar Time: 20 December 2021, 9:37:26.122961 pm UUID: 229ac303-0cfa-2d45-8d4e-e2b19b88cba8 Ancestors: KernelTests-ct.415 add a test (expected failure) to document a bug in #priority via a failing test case. The bug was summarized in http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217473… and discussed in http://forum.world.st/The-Inbox-Kernel-jar-1368-mcz-td5126894.html and most likely requires a new primitive to fix it correctly. An interim fix was proposed in Kernel-jar.1368 to show the desirable functionality that satisfies this test. =============== Diff against KernelTests-ct.415 =============== Item was added: + ----- Method: ProcessTest>>expectedFailures (in category 'failures') ----- + expectedFailures + + ^ #(testDecreaseActiveProcessPriority)! Item was added: + ----- Method: ProcessTest>>testDecreaseActiveProcessPriority (in category 'tests') ----- + testDecreaseActiveProcessPriority + "test whether #priority: reschedules active process to allow higher priority processes run; + presently (12/2021) the test fails and is here to remind about the #priority bug discussed + in http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217473… + and http://forum.world.st/The-Inbox-Kernel-jar-1368-mcz-td5126894.html" + + | val oldPriority oldPreemptionYields | + val := nil. + oldPriority := Processor activePriority. + oldPreemptionYields := Smalltalk processPreemptionYields. + + [ + Processor activeProcess priority: oldPriority + 2. + [ val := false ] forkAt: oldPriority + 1. + [ val := true ] forkAt: oldPriority. + Processor activeProcess priority: oldPriority. + "depending on processPreemptionYields value the active process should be placed + either at the beginning or the end of the quiescentProcessLists at: oldPriority" + self assert: val = Smalltalk processPreemptionYields. + + "test both alternative settings (true/false) of processPreemptionYields" + val := nil. + Smalltalk processPreemptionYields: oldPreemptionYields not. + + Processor activeProcess priority: oldPriority + 2. + [ val := false ] forkAt: oldPriority + 1. + [ val := true ] forkAt: oldPriority. + Processor activeProcess priority: oldPriority. + self assert: val = Smalltalk processPreemptionYields. + + ] ensure: [ + "make sure processPreemptionYields is reset to its original value even if the test fails" + Smalltalk processPreemptionYields: oldPreemptionYields. + self assert: Smalltalk processPreemptionYields equals: oldPreemptionYields]!

3 4

The Trunk: System-ct.1445.mcz
by commits＠source.squeak.org 31 Jan '24

31 Jan '24

Christoph Thiede uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-ct.1445.mcz ==================== Summary ==================== Name: System-ct.1445 Author: ct Time: 31 January 2024, 7:11:29.83716 pm UUID: e2a27ec4-4978-f04f-bbeb-594f83577d30 Ancestors: System-ct.1444 Bumps recommended VM build to latest release of OpenSmalltalk VM. =============== Diff against System-ct.1444 =============== Item was changed: ----- Method: SystemVersion>>recommendedVMBuildNumber (in category 'accessing') ----- recommendedVMBuildNumber + ^ 202312181441! - ^ 202206021410!

1 0

The Trunk: KernelTests-ct.451.mcz
by commits＠source.squeak.org 31 Jan '24

31 Jan '24

Christoph Thiede uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-ct.451.mcz ==================== Summary ==================== Name: KernelTests-ct.451 Author: ct Time: 31 January 2024, 6:59:47.634204 pm UUID: 070fbef2-8e58-d847-9528-cdc80374447b Ancestors: KernelTests-dtl.450 Documents process termination while resuming from an exception. See https://github.com/squeak-smalltalk/squeak-object-memory/issues/112. May be fixed by Kernel-jar.1553 and Kernel-jar.1554. =============== Diff against KernelTests-dtl.450 =============== Item was added: + ----- Method: ProcessTest>>testTerminateEverywhere (in category 'tests') ----- + testTerminateEverywhere + + | block steps | + block := [([[Notification signal] + ensure: []] + on: Notification do: [:ex | ex resume: 6]) + * 7]. + + steps := 0. + [steps] whileNotNil: + [| process | + process := Process forContext: block asContext priority: Processor activePriority. + steps timesRepeat: + [(process suspendedContext stackPtr > 0 and: [process suspendedContext top = 42]) + ifTrue: [steps := nil] + ifFalse: [process step]]. + steps ifNotNil: [steps := steps + 1]. + + process terminate. + self assert: process isTerminated].!

1 0

The Inbox: System-dtl.1446.mcz
by commits＠source.squeak.org 30 Jan '24

30 Jan '24

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-dtl.1446.mcz ==================== Summary ==================== Name: System-dtl.1446 Author: dtl Time: 30 January 2024, 4:35:00.140218 pm UUID: cede9a72-39dd-4d82-91ba-9e60fe24a06a Ancestors: System-dtl.1445 Split lowSpaceWatcher into smaller methods with comments to explain each step in the low space handling process. HelpBrowser openOn: LowSpaceWatcher. =============== Diff against System-dtl.1445 =============== Item was added: + ----- Method: LowSpaceWatcher>>disableVirtualMachineNotifications (in category 'process steps') ----- + disableVirtualMachineNotifications + "Ask the virtual machine to stop sending low space interrupts, and forget the current semaphore and watcher process." + + self primSignalAtBytesLeft: 0. "disable low space interrupts" + self primLowSpaceSemaphore: nil. + lowSpaceProcess := nil. + ! Item was added: + ----- Method: LowSpaceWatcher>>findPreemptedProcess (in category 'process steps') ----- + findPreemptedProcess + "Find the process that was active at the time of the low space interrupt. Check + first if the virtual machine has recorded the process that was active at the time + that it detected the low space detection, otherwise answer the process that was + most recently preempted when the semaphore was signalled." + + | preemptedProcess | + preemptedProcess := (Smalltalk specialObjectsArray at: 23) + ifNil: [Processor preemptedProcess "if in-image signal of OutOfMemory"]. + Smalltalk specialObjectsArray at: 23 put: nil. + ^ preemptedProcess + + ! Item was added: + ----- Method: LowSpaceWatcher>>handleLowSpaceCondition (in category 'process steps') ----- + handleLowSpaceCondition + "A low space condition has been detected. Do whatever may be necessary to free + some memory in the image before proceeding." + + | preemptedProcess | + preemptedProcess := self findPreemptedProcess. + self notifyMemoryHogs ifFalse: [ + self logError: preemptedProcess. + self notifyUser: preemptedProcess ]. + + ! Item was added: + ----- Method: LowSpaceWatcher>>initializeVirtualMachineNotifications (in category 'process steps') ----- + initializeVirtualMachineNotifications + "Let the virtual machine know how to notify the image of low space conditions." + + Smalltalk specialObjectsArray at: 23 put: nil. "process causing low space will be saved here" + lowSpaceSemaphore := Semaphore new. + self primLowSpaceSemaphore: lowSpaceSemaphore. + self primSignalAtBytesLeft: Smalltalk lowSpaceThreshold. "enable low space interrupts" + ! Item was added: + ----- Method: LowSpaceWatcher>>logError: (in category 'process steps') ----- + logError: preemptedProcess + + Preferences logDebuggerStackToFile ifTrue: [ + Smalltalk + logError: 'Space is low' + inContext: preemptedProcess suspendedContext + to: 'LowSpaceDebug.log' ]. + ! Item was changed: ----- Method: LowSpaceWatcher>>lowSpaceWatcher (in category 'process') ----- lowSpaceWatcher + "Wait until the low space semaphore is signalled, then take appropriate actions. This + method is run once in the low space watcher process. Before terminating, it schedules + a new process to handle the next low space condition." - "Wait until the low space semaphore is signalled, then take appropriate actions." + self safeToInstall ifFalse: [ ^ Beeper beep]. + self initializeVirtualMachineNotifications. + lowSpaceSemaphore wait. + self disableVirtualMachineNotifications; handleLowSpaceCondition. + self start. "schedule a new process to handle the next low space condition" - | free preemptedProcess | - Smalltalk garbageCollectMost <= Smalltalk lowSpaceThreshold - ifTrue: [self garbageCollect <= Smalltalk lowSpaceThreshold - ifTrue: ["free space must be above threshold before - starting low space watcher" - ^ Beeper beep]]. - Smalltalk specialObjectsArray at: 23 put: nil. "process causing low space will be saved here" - lowSpaceSemaphore := Semaphore new. - self primLowSpaceSemaphore: lowSpaceSemaphore. - self primSignalAtBytesLeft: Smalltalk lowSpaceThreshold. "enable low space interrupts" - - lowSpaceSemaphore wait. "wait for a low space condition..." - - self primSignalAtBytesLeft: 0. "disable low space interrupts" - self primLowSpaceSemaphore: nil. - lowSpaceProcess := nil. - - "The process that was active at the time of the low space interrupt." - preemptedProcess := (Smalltalk specialObjectsArray at: 23) - ifNil: [Processor preemptedProcess "if in-image signal of OutOfMemory"]. - Smalltalk specialObjectsArray at: 23 put: nil. - - "Note: user now unprotected until the low space watcher is re-installed" - - self memoryHogs isEmpty - ifFalse: [free := Smalltalk bytesLeft. - self memoryHogs - do: [ :hog | hog freeSomeSpace ]. - self bytesLeft > free - ifTrue: [ ^ LowSpaceWatcher installLowSpaceWatcher ]]. - - Preferences logDebuggerStackToFile ifTrue: [ - self - logError: 'Space is low' - inContext: preemptedProcess suspendedContext - to: 'LowSpaceDebug.log']. - - Project current - interruptName: 'Space is low' - message: self lowSpaceChoices - preemptedProcess: preemptedProcess ! Item was added: + ----- Method: LowSpaceWatcher>>notifyMemoryHogs (in category 'process steps') ----- + notifyMemoryHogs + "Try to clean up memory hogs. Answer true if sufficient memory was released." + + | free | + self memoryHogs isEmpty + ifTrue: [ ^ false ] + ifFalse: [ free := Smalltalk bytesLeft. + self memoryHogs + do: [ :hog | hog freeSomeSpace ]. + ^ Smalltalk bytesLeft > free ] + + ! Item was added: + ----- Method: LowSpaceWatcher>>notifyUser: (in category 'process steps') ----- + notifyUser: preemptedProcess + "Interrupt the user to allow the low space condition to be corrected. The user + is now unprotected until the low space watcher is re-installed." + + Project current + interruptName: 'Space is low' + message: self lowSpaceChoices + preemptedProcess: preemptedProcess. + ! Item was added: + ----- Method: LowSpaceWatcher>>safeToInstall (in category 'process steps') ----- + safeToInstall + "Free space must be above threshold before starting low space watcher" + + Smalltalk garbageCollectMost > Smalltalk lowSpaceThreshold + ifFalse: [ ^ Smalltalk garbageCollect > Smalltalk lowSpaceThreshold ]. + ^ true + ! Item was changed: ----- Method: LowSpaceWatcher>>start (in category 'initialize-release') ----- start "Start a new low space watcher process that will register a semaphore with the virtual machine and wait for the semaphore to be signalled if a low space condition is detected." + lowSpaceProcess := [self lowSpaceWatcher] forkAt: Processor lowIOPriority. - lowSpaceProcess := [self lowSpaceWatcher] newProcess. - lowSpaceProcess priority: Processor lowIOPriority. - lowSpaceProcess resume. !

1 0

← Newer
1
2
3
4
5
6
7
8
9
Older →