Squeak-dev April 2022

squeak-dev@lists.squeakfoundation.org

29 participants
332 discussions

The Trunk: Collections-ct.1005.mcz
by commits＠source.squeak.org 02 Apr '22

02 Apr '22

Christoph Thiede uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ct.1005.mcz ==================== Summary ==================== Name: Collections-ct.1005 Author: ct Time: 2 April 2022, 8:27:14.574869 pm UUID: ff06a248-ec0b-7947-982c-accabd65f28e Ancestors: Collections-ct.1004 Recategorizes SparseLargeTable>>#sparseElementsAndIndicesDo:. =============== Diff against Collections-ct.1004 =============== Item was changed: + ----- Method: SparseLargeTable>>sparseElementsAndIndicesDo: (in category 'enumerating') ----- - ----- Method: SparseLargeTable>>sparseElementsAndIndicesDo: (in category 'accessing') ----- sparseElementsAndIndicesDo: binaryBlock "Evaluate binaryBlock for each element and index in the receiver that has a non-default value." 1 to: self basicSize do: [:chunkIndex | (self basicAt: chunkIndex) ifNotNil: [:chunk | chunk withIndexDo: [:element :innerIndex | element ~= defaultValue ifTrue: [ binaryBlock value: element value: innerIndex + base - 1 + (chunkIndex - 1 * chunkSize)]]]].!

1 0

Editors' "hidden info"/TextAction>>#analyze:
by christoph.thiede＠student.hpi.uni-potsdam.de 02 Apr '22

02 Apr '22

Hi all, is there any reachable code path from the editor to unpack the "hidden infos" from TextAttribute? There are the "Edit hidden info" and "Copy hidden info" blocks, but they are indexed in SmalltalkEditor>>#emphasisExtras. Should they be? Or is there any other shortcut for this? Should we introduce one, maybe <opt><? I think we already might have had such a shortcut in the past, but I cannot find it ... Best, Christoph --- Sent from Squeak Inbox Talk

1 0

The Trunk: ST80-ct.264.mcz
by commits＠source.squeak.org 02 Apr '22

02 Apr '22

Christoph Thiede uploaded a new version of ST80 to project The Trunk: http://source.squeak.org/trunk/ST80-ct.264.mcz ==================== Summary ==================== Name: ST80-ct.264 Author: ct Time: 3 January 2021, 8:34:46.789366 pm UUID: 69dbd2d8-5dbf-f043-8ff4-893f45185436 Ancestors: ST80-mt.262 Proposal: Add inspect item to ST80 window blue-button menu. =============== Diff against ST80-mt.262 =============== Item was changed: ----- Method: StandardSystemController class>>initialize (in category 'class initialization') ----- initialize "StandardSystemController initialize" ScheduledBlueButtonMenu := SelectionMenu labels: 'edit label choose color... two-tone/full color move frame full screen collapse + inspect controller close' lines: #(3 7) + selections: #(label chooseColor toggleTwoTone move reframe fullScreen collapse inspect close). - selections: #(label chooseColor toggleTwoTone move reframe fullScreen collapse close). VBorderCursor := Cursor extent: 16@16 fromArray: #( 2r1010000000000000 2r1010000000000000 2r1010000000000000 2r1010000000000000 2r1010000000000000 2r1010010000100000 2r1010110000110000 2r1011111111111000 2r1010110000110000 2r1010010000100000 2r1010000000000000 2r1010000000000000 2r1010000000000000 2r1010000000000000 2r1010000000000000 2r1010000000000000) offset: 0@0. HBorderCursor := Cursor extent: 16@16 fromArray: #( 2r1111111111111111 2r0000000000000000 2r1111111111111111 2r0000000100000000 2r0000001110000000 2r0000011111000000 2r0000000100000000 2r0000000100000000 2r0000000100000000 2r0000000100000000 2r0000011111000000 2r0000001110000000 2r0000000100000000 2r0000000000000000 2r0000000000000000 2r0000000000000000) offset: 0@0.!

1 0

The Trunk: Collections-ct.1004.mcz
by commits＠source.squeak.org 02 Apr '22

02 Apr '22

Christoph Thiede uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ct.1004.mcz ==================== Summary ==================== Name: Collections-ct.1004 Author: ct Time: 2 April 2022, 7:37:33.198869 pm UUID: 9ab359d2-35da-d34b-9844-16a0e4c09abf Ancestors: Collections-ct.1003 Makes it possible to cancel from an "add URL..." dialog. Gives a little bit more space in the dialog to support multi-line code:// URLs. =============== Diff against Collections-ct.1003 =============== Item was changed: ----- Method: TextURL>>analyze: (in category 'initialize-release') ----- analyze: aString + | list answer | - | list | list := super analyze: aString. + answer := Project uiManager multiLineRequest: 'URL to open' translated centerAt: Sensor cursorPoint initialAnswer: (list at: 1) answerHeight: 200. + answer isEmptyOrNil ifTrue: [^ nil]. + url := answer. - (Project uiManager request: 'URL to open' translated initialAnswer: (list at: 1)) - in: [:answer | answer ifEmpty: [url := list at: 1] ifNotEmpty: [url := answer]]. ^ list at: 2!

1 0

The Trunk: SystemReporter-ct.61.mcz
by commits＠source.squeak.org 02 Apr '22

02 Apr '22

Christoph Thiede uploaded a new version of SystemReporter to project The Trunk: http://source.squeak.org/trunk/SystemReporter-ct.61.mcz ==================== Summary ==================== Name: SystemReporter-ct.61 Author: ct Time: 2 April 2022, 6:47:45.377896 pm UUID: 3f75ee7c-fb80-c24a-a21b-dd095ab761b2 Ancestors: SystemReporter-mt.60 Fixes slip in report of image packages for treated versions. =============== Diff against SystemReporter-mt.60 =============== Item was changed: ----- Method: SystemReporter>>reportImagePackages: (in category 'reporting') ----- reportImagePackages: aStream | organizer trunk treated inbox release releaseRepo attribute others | organizer := PackageOrganizer default. self header: 'System Categories with Unknown Package' on: aStream. SystemOrganization categories select: [:category | (organizer packageOfSystemCategory: category ifNone: []) isNil] thenDo: [:category | aStream nextPutAll: category; cr]. aStream cr. self header: 'Packages with Only Cache Repository' on: aStream. organizer packages select: [:package | | repos | repos := package mcPackage workingCopy repositoryGroup repositories. repos size = 1 and: [repos first == MCRepository packageCache]] thenDo: [:package | aStream nextPutAll: package mcPackage workingCopy description; cr]. aStream cr. self header: 'Official Packages' on: aStream. others := OrderedCollection new. trunk := MCRepository trunk allVersionNames. inbox := MCRepository inbox allVersionNames. treated := MCRepository treated allVersionNames. releaseRepo := [[ReleaseBuilder releaseRepository] valueSupplyingAnswer: {'*'. true}] on: ReleaseBuilderFailed do: [:ex | nil]. release := releaseRepo ifNotNil: [:repo | repo allVersionNames] ifNil: [#()]. (organizer packages sorted: [:a :b | a packageName <= b packageName]) collect: [:package | package mcPackage workingCopy] thenDo: [:workingCopy | | version repo | version := workingCopy ancestry ancestors ifNotEmpty: [:a | a first]. version ifNotNil: [version := version name]. attribute := TextEmphasis normal. (release includes: version) ifTrue: [repo := releaseRepo] ifFalse: [(trunk includes: version) ifTrue: [repo := MCRepository trunk] ifFalse: [(inbox includes: version) ifTrue: [repo := MCRepository inbox. attribute := TextEmphasis bold] ifFalse: [(treated includes: version) + ifTrue: [repo := MCRepository treated. attribute := TextColor gray] - ifTrue: [repo := treated. attribute := TextColor gray] ifFalse: [others add: workingCopy]]]. repo ifNotNil: [ "Only official packages here." aStream withAttribute: attribute do: [ aStream nextPutAll: workingCopy description; nextPutAll: ' --- '; nextPutAll: repo description; cr]]]]. aStream cr. self header: 'Other Packages' on: aStream. others select: [:workingCopy | workingCopy repositoryGroup repositories size > 1] thenDo: [:workingCopy | aStream nextPutAll: workingCopy description; nextPutAll: ' --- '; nextPutAll: workingCopy repositoryGroup repositories second description; cr] !

1 0

The Trunk: PreferenceBrowser-ct.141.mcz
by commits＠source.squeak.org 02 Apr '22

02 Apr '22

Christoph Thiede uploaded a new version of PreferenceBrowser to project The Trunk: http://source.squeak.org/trunk/PreferenceBrowser-ct.141.mcz ==================== Summary ==================== Name: PreferenceBrowser-ct.141 Author: ct Time: 2 April 2022, 6:38:32.234896 pm UUID: 7edb9fb0-df4d-5748-9edc-70fb650d163a Ancestors: PreferenceBrowser-mt.140 Fixes keyboard shortcuts cmd + c/C in preference browser. =============== Diff against PreferenceBrowser-mt.140 =============== Item was changed: ----- Method: PreferenceBrowserMorph>>keyPressedOn:event: (in category 'event handling') ----- keyPressedOn: aPreferenceView event: anEvent anEvent commandKeyPressed ifFalse: [ anEvent keyValue caseOf: { [27] -> [aPreferenceView offerPreferenceNameMenu: self model]. [30] -> [self upKeyPressed: anEvent]. [31] -> [self downKeyPressed: anEvent]. [1] -> [self homeKeyPressed: anEvent]. [4] -> [self endKeyPressed: anEvent]. [11] -> [self pageUpKeyPressed: anEvent]. [12] -> [self pageDownKeyPressed: anEvent] } otherwise: [self basicKeyPressed: anEvent]. ^ self]. anEvent keyCharacter caseOf: { [$b] -> [self model findCategoryFromPreference: aPreferenceView preference]. + [$c] -> [aPreferenceView preference copyName]. + [$C] -> [aPreferenceView preference copyCode]. - [$c] -> [aPreferenceView copyName]. - [$C] -> [aPreferenceView copyCode]. [$i] -> [aPreferenceView preference inspect]. [$m] -> [aPreferenceView browse]. [$n] -> [aPreferenceView browseSenders]} otherwise: [].!

1 0

The Trunk: Collections-ct.1003.mcz
by commits＠source.squeak.org 02 Apr '22

02 Apr '22

Christoph Thiede uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ct.1003.mcz ==================== Summary ==================== Name: Collections-ct.1003 Author: ct Time: 2 April 2022, 1:46:18.637455 pm UUID: 8f588405-6ab6-2342-8fe8-ebdaff0733ea Ancestors: Collections-ul.1002 Corrects merge slip from Collections-ul.1001 which had reverted Collections-ct.999. Corrects the description of nil, true, and false within literal variables. See: http://lists.squeakfoundation.org/pipermail/squeak-dev/2022-April/219714.ht…. =============== Diff against Collections-ul.1002 =============== Item was changed: ----- Method: Text class>>codeSample (in category 'filler text') ----- codeSample + self flag: #linebreaks. "Samples are used in FontImporterTool and must contain manual linebreaks (visually stable example texts per line)." ^ 'exampleWithNumber: x + "A method that illustrates every part of Smalltalk method syntax + including primitives. It has unary, binary, and keyboard messages; + declares arguments and temporaries; accesses a global variable + (but not an instance variable); uses literals (array, nested array, + character, symbol, string, integer, float, scaled decimal, and byte + array); uses the pseudo variables nil, true, false, self, super, and + thisContext; shows that within a literal array nil, true, and false are + still pseudo variables; and has sequence, assignment, return, + cascade, and tuple (array) creation. It has both zero argument + and one argument blocks, and has a block temporary." - "A method that illustrates every part of Smalltalk method syntax including primitives. It has unary, binary, and keyboard messages; declares arguments and temporaries; accesses a global variable (but not an instance variable); uses literals (array, nested array, character, symbol, string, integer, float, scaled decimal, and byte array); uses the pseudo variables nil, true, false, self, super, and thisContext; shows that within a literal array nil, true, and false are symbols not pseudo variables; and has sequence, assignment, return, cascade, and tuple (array) creation. It has both zero argument and one argument blocks, and has a block temporary." <primitive: ''primitiveCopyBits'' module: #BitBltPlugin error: ec> | y | true & false not & (nil isNil) ifFalse: [self halt]. y := self size + super size. #($a #a ''a'' "a" (1 1.0 1.0s2) nil true false), { #[65]. thisContext. nil. true. false } do: [ :each | | class | class := each class. Transcript show: (class name); show: '' '']. ^ x < y'!

1 0

The Trunk: Collections-eem.992.mcz
by commits＠source.squeak.org 02 Apr '22

02 Apr '22

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.992.mcz ==================== Summary ==================== Name: Collections-eem.992 Author: eem Time: 1 March 2022, 12:39:53.850609 pm UUID: 677dd86e-ae58-41d3-b125-af837d2cdb61 Ancestors: Collections-mt.991 Add some missing features to the imfamous postcard. =============== Diff against Collections-mt.991 =============== Item was changed: ----- Method: Text class>>codeSample (in category 'filler text') ----- codeSample ^ 'exampleWithNumber: x "A method that illustrates every part of Smalltalk method syntax including primitives. It has unary, binary, and keyboard messages, declares arguments and temporaries, accesses a global variable + (but not an instance variable), uses literals (array, character, symbol, + string, integer, float, byte array), uses the pseudo variables nil, true, + false, self, super, and thisContext, shows that within a literal array + nil, true and false are symbols not pseudo variables, and has sequence, + assignment, return, cascade, and tuple (array) creation. It has both + zero argument and one argument blocks, and has a block temporary." - (but not an instance variable), uses literals (array, character, - symbol, string, integer, float), uses the pseudo variables true, - false, nil, self, and super, and has sequence, assignment, return - and cascade. It has both zero argument and one argument blocks." <primitive: ''primitiveCopyBits'' module: #BitBltPlugin error: ec> | y | true & false not & (nil isNil) ifFalse: [self halt]. y := self size + super size. + #($a #a ''a'' "a" 1 1.0 nil true false), { #[65]. thisContext. nil. true. false } + do: [ :each | | class | + class := each class. - #($a #a ''a'' "a" 1 1.0) - do: [ :each | Transcript + show: (class name); - show: (each class name); show: '' '']. ^ x < y'!

6 7

Review Request: robust-forceChangesToDisk.1.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 01 Apr '22

01 Apr '22

Please review. :-) Best, Christoph =============== Summary =============== Change Set: robust-forceChangesToDisk Date: 25 March 2022 Author: Christoph Thiede Increases the robustness of Smalltalk forceChangesToDisk. When this method is interrupted, make sure to maintain the invariant that the source file is always opened and set to the right position. In the course of this, also makes StandardFileStream>>#open:forWrite: more robust. Adds a smoke/regression test. For context: Interrupting Smalltalk forceChangesToDisk is not a fictional scenario. In combination with a slow file system access, I could reproduce this many times when running StringTest>>#testPercentEncodingJa with a too small timeout. =============== Diff =============== SmalltalkImage>>forceChangesToDisk {sources, changes log} · ct 3/25/2022 14:17 (changed) forceChangesToDisk "Ensure that the changes file has been fully written to disk by closing and re-opening it. This makes the system more robust in the face of a power failure or hard-reboot." | changesFile | changesFile := SourceFiles at: 2. (changesFile isKindOf: FileStream) ifTrue: [ changesFile flush. - SecurityManager default hasFileAccess ifTrue:[ - changesFile close. - changesFile open: changesFile name forWrite: true]. - changesFile setToEnd. - ]. + SecurityManager default hasFileAccess + ifTrue: [ + [changesFile close. + changesFile open: changesFile name forWrite: true. + changesFile setToEnd] + ifCurtailed: [ + changesFile closed ifFalse: [changesFile close]. + changesFile open: changesFile name forWrite: true. + changesFile setToEnd]] + ifFalse: [changesFile setToEnd]]. SmalltalkImageTest>>testForceChangesToDiskRobustness {tests} · ct 3/25/2022 14:23 + testForceChangesToDiskRobustness + <timeout: 11 "seconds"> + <fatal "regression test! Unless this bug is fixed, this may damage your image."> + + 50 timesRepeat: + [[[Smalltalk forceChangesToDisk] repeat] valueWithin: 0.1 seconds onTimeout: []]. + + self shouldnt: [Smalltalk logChange: ('Test from {1}' format: {self})] raise: Error. StandardFileStream>>open:forWrite: {open/close} · ct 3/25/2022 14:42 (changed) open: fileName forWrite: writeMode "Open the file with the given name. If writeMode is true, allow writing, otherwise open the file in read-only mode." "Changed to do a GC and retry before failing ar 3/21/98 17:25" - | f | + | f newFileID | f := fileName asVmPathName. - - fileID := StandardFileStream retryWithGC:[self primOpen: f writable: writeMode] - until:[:id| id notNil] - forFileNamed: fileName. + + fileID := nil. + fileID := [StandardFileStream + retryWithGC: + [newFileID := nil. + newFileID := self primOpen: f writable: writeMode] + until: [:id | id notNil] + forFileNamed: fileName] + ifCurtailed: + [newFileID ifNotNil: [self primClose: newFileID]]. fileID ifNil: [^ nil]. "allows sender to detect failure" name := fileName. self register. rwmode := writeMode. buffer1 := String new: 1. - self enableReadBuffering - + self enableReadBuffering. ["robust-forceChangesToDisk.1.cs"] --- Sent from Squeak Inbox Talk ["robust-forceChangesToDisk.1.cs"]

2 2

The Trunk: Tests-ct.481.mcz
by commits＠source.squeak.org 01 Apr '22

01 Apr '22

Christoph Thiede uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-ct.481.mcz ==================== Summary ==================== Name: Tests-ct.481 Author: ct Time: 1 April 2022, 1:08:52.165996 pm UUID: f2f47e66-29d1-274c-a7e4-2acb06c95ad7 Ancestors: Tests-ul.480 Merges robust-forceChangesToDisk.1.cs/complements System-ct.1333. =============== Diff against Tests-ul.480 =============== Item was added: + ----- Method: SmalltalkImageTest>>testForceChangesToDiskRobustness (in category 'tests') ----- + testForceChangesToDiskRobustness + "Interrupting #forceChangesToDisk must always keep the SourceFiles opened and intact." + <timeout: 11 "seconds"> + <fatal "regression test!! Unless this bug is fixed, this may damage your image."> + + 50 timesRepeat: + [[[Smalltalk forceChangesToDisk] repeat] valueWithin: 0.1 seconds onTimeout: []]. + + self shouldnt: [Smalltalk logChange: ('Test from {1}' format: {self})] raise: Error.!

1 0

Jump to page: