Squeak-dev April 2022

squeak-dev@lists.squeakfoundation.org

29 participants
332 discussions

Review Request: changeSetNameInUse.4.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 05 Apr '22

05 Apr '22

=============== Summary =============== Change Set: changeSetNameInUse Date: 5 April 2022 Author: Christoph Thiede When creating/filing a changeset with a name that is already in use, offer the user to append or overwrite the changeset instead canceling the operation. Also improves multilingual support. To test this out, just file in this changeset a second time. =============== Diff =============== ChangeSet class>>basicNewChangeSet: {enumerating} · ct 4/5/2022 20:57 (changed) basicNewChangeSet: newName | newSet | newName ifNil: [^ nil]. - (self named: newName) ifNotNil: - [self inform: 'Sorry that name is already used'. - ^ nil]. + (self named: newName) ifNotNil: [:existing | + ((Project uiManager + chooseFromLabeledValues: (OrderedDictionary new + at: 'Append' translated put: [^ existing]; + at: 'Overwrite' translated put: [self removeChangeSet: existing]; + at: 'Cancel' translated put: nil; + yourself) + title: ('A changeset with the name <b>"{1}"</b> already exists.' translated asTextFromHtml format: {newName})) ifNil: [^ nil]) value]. newSet := self basicNewNamed: newName. AllChangeSets add: newSet. ^ newSet ChangeSet class>>newChangesFromStream:named: {services} · ct 4/5/2022 20:54 (changed) newChangesFromStream: aStream named: aName "File in the code from the stream into a new change set whose name is derived from aName. Leave the 'current change set' unchanged. Return the new change set or nil on failure." | oldChanges newName newSet | oldChanges := ChangeSet current. PreviousSet := oldChanges name. "so a Bumper update can find it" newName := aName sansPeriodSuffix. newSet := self basicNewChangeSet: newName. [ | newStream |newSet ifNotNil:[ (aStream respondsTo: #converter:) ifFalse: [ newStream := MultiByteBinaryOrTextStream with: (aStream contentsOfEntireFile). newStream reset. ] ifTrue: [ newStream := aStream. ]. self newChanges: newSet. newStream setConverterForCode. - newStream fileInAnnouncing: 'Loading ', newName, '...'. - Transcript cr; show: 'File ', aName, ' successfully filed in to change set ', newName]. + newStream fileInAnnouncing: ('Loading {1}...' translated format: {newName}). + Transcript cr; show: ('File {1} successfully filed in to change set {2}' translated format: {aName. newName})]. aStream close] ensure: [self newChanges: oldChanges]. PreviousSet := nil. ^ newSet --- Sent from Squeak Inbox Talk ["changeSetNameInUse.4.cs"] ["changeSetNameInUse.png"]

1 0

The Trunk: EToys-ct.471.mcz
by commits＠source.squeak.org 05 Apr '22

05 Apr '22

Christoph Thiede uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-ct.471.mcz ==================== Summary ==================== Name: EToys-ct.471 Author: ct Time: 5 April 2022, 6:32:17.636304 pm UUID: 10627a4f-d87e-ce46-8976-21be79745d1f Ancestors: EToys-ul.470 Complements System-ct.1335 (reapplied removal of #automaticPlatformSettings). =============== Diff against EToys-ul.470 =============== Item was changed: ----- Method: Preferences class>>cambridge (in category '*Etoys-Squeakland-themes') ----- cambridge "A theme for Squeakland and OLPC project" "Preferences cambridge" "This method has three parts. Don't forget to look at the stuff at the bottom." self setPreferencesFrom: #( (allowCelesteTell false) (alternativeScrollbarLook true) (alternativeWindowLook true) (annotationPanes true) (automaticKeyGeneration true) (biggerHandles true) (blinkParen false) (browseWithDragNDrop true) (canRecordWhilePlaying true) (classicNavigatorEnabled false) (compactViewerFlaps true) (enableLocalSave false) (eToyFriendly true) (eToyLoginEnabled true) (extraDebuggerButtons false) (gradientMenu false) (haloTransitions false) (honorDesktopCmdKeys true) (includeSoundControlInNavigator true) (magicHalos false) (menuAppearance3d false) (menuKeyboardControl false) (modalColorPickers true) (mouseOverHalos false) (mvcProjectsAllowed false) (preserveTrash true) (projectViewsInWindows false) (promptForUpdateServer false) (propertySheetFromHalo false) (roundedMenuCorners false) (roundedWindowCorners false) (securityChecksEnabled true) (standaloneSecurityChecksEnabled true) (duplicateControlAndAltKeys true) (showDirectionHandles false) (showDirectionForSketches true) (showProjectNavigator false) (showSecurityStatus false) (soundQuickStart true) "see setPlatformPreferences" (soundReverb false) (soundStopWhenDone true) "see setPlatformPreferences" (startInUntrustedDirectory true) (sugarAutoSave false) (swapControlAndAltKeys false) "see setPlatformPreferences" (uniqueNamesInHalos true) (unlimitedPaintArea false) (useArtificialSweetenerBar true) (useBiggerPaintingBox true) (useFormsInPaintBox false) (useLocale true) (usePopUpArrows true) (warnAboutInsecureContent false) "The following is to make sure the default is set properly." (allowEtoyUserCustomEvents false) (alphabeticalProjectMenu false) (alternativeBrowseIt false) (alternativeWindowBoxesLook true) (alwaysHideHScrollbar false) (alwaysShowConnectionVocabulary false) (alwaysShowHScrollbar false) (alwaysShowVScrollbar true) (areaFillsAreTolerant false) (areaFillsAreVeryTolerant false) (automaticFlapLayout true) - (automaticPlatformSettings true) "enables setPlatformPreferences" (automaticViewerPlacement true) (balloonHelpEnabled true) (balloonHelpInMessageLists false) (batchPenTrails false) (biggerCursors true) (capitalizedReferences true) (caseSensitiveFinds false) (cautionBeforeClosing false) (celesteHasStatusPane false) (celesteShowsAttachmentsFlag false) (changeSetVersionNumbers true) (checkForSlips true) (checkForUnsavedProjects true) (clickOnLabelToEdit false) (cmdDotEnabled true) (collapseWindowsInPlace false) (colorWhenPrettyPrinting false) (confirmFirstUseOfStyle true) (conversionMethodsAtFileOut false) (debugHaloHandle false) (debugPrintSpaceLog false) (debugShowDamage false) (decorateBrowserButtons true) (diffsInChangeList true) (diffsWithPrettyPrint false) (dismissAllOnOptionClose false) (dismissEventTheatreUponPublish true) (dropProducesWatcher true) (duplicateControlAndAltKeys false) (easySelection false) (enablePortraitMode false) (enableVirtualOLPCDisplay false) (expandedPublishing true) (fastDragWindowForMorphic true) (fenceEnabled true) (fenceSoundEnabled false) (fullScreenLeavesDeskMargins true) (gradientScrollBars true) (haloEnclosesFullBounds false) (higherPerformance false) (ignoreStyleIfOnlyBold true) (implicitSelfInTiles false) (inboardScrollbars true) (infiniteUndo false) (keepTickingWhilePainting false) (logDebuggerStackToFile true) (menuColorFromWorld false) (menuWithIcons true) (mouseOverForKeyboardFocus false) (navigatorOnLeftEdge true) (noviceMode false) (okToReinitializeFlaps true) (oliveHandleForScriptedObjects false) (optionalButtons true) (passwordsOnPublish false) (personalizedWorldMenu true) (postscriptStoredAsEPS false) (printAlternateSyntax false) (projectsSentToDisk false) (projectZoom true) (readDocumentAtStartup true) (restartAlsoProceeds false) (reverseWindowStagger true) (rotationAndScaleHandlesInPaintBox false) (scrollBarsNarrow false) (scrollBarsOnRight true) (scrollBarsWithoutMenuButton false) (selectionsMayShrink true) (selectiveHalos true) (showAdvancedNavigatorButtons false) (showBoundsInHalo false) (showDeprecationWarnings false) (showFlapsWhenPublishing false) (showSharedFlaps true) (signProjectFiles true) (simpleMenus false) (slideDismissalsToTrash true) (smartUpdating true) (swapMouseButtons false) (systemWindowEmbedOK false) (tabAmongFields true) (tileTranslucentDrag true) (timeStampsInMenuTitles true) (turnOffPowerManager false) (twentyFourHourFileStamps true) (typeCheckingInTileScripting true) (uniTilesClassic true) (universalTiles false) (updateFromServerAtStartup false) (updateSavesFile false) (useButtonPropertiesToFire false) (useUndo true) (useVectorVocabulary false) (viewersInFlaps true) (warnIfNoChangesFile false) (warnIfNoSourcesFile false) (wordStyleCursorMovement true) ). Preferences setPreference: #haloTheme toValue: #iconicHaloSpecifications. !

1 0

The Trunk: System-ct.1335.mcz
by commits＠source.squeak.org 05 Apr '22

05 Apr '22

Christoph Thiede uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-ct.1335.mcz ==================== Summary ==================== Name: System-ct.1335 Author: ct Time: 5 April 2022, 6:30:12.004304 pm UUID: f01dddfd-d921-e744-bf4f-5954cef59031 Ancestors: System-mt.1334 Fixes merge slip from System-mt.1259 and reapplies System-ct.1257 (removal of #automaticPlatformSettings preference). =============== Diff against System-mt.1334 =============== Item was changed: ----- Method: Preferences class>>defaultValueTableForCurrentRelease (in category 'defaults') ----- defaultValueTableForCurrentRelease "Answer a table defining default values for all the preferences in the release. Returns a list of (pref-symbol, boolean-symbol) pairs" ^ #( (alternativeBrowseIt false) (annotationPanes false) (areaFillsAreTolerant false) (areaFillsAreVeryTolerant false) (automaticFlapLayout true) (automaticKeyGeneration false) - (automaticPlatformSettings true) (automaticViewerPlacement true) (balloonHelpEnabled true) (balloonHelpInMessageLists false) (batchPenTrails false) (capitalizedReferences true) (caseSensitiveFinds false) (cautionBeforeClosing false) (changeSetVersionNumbers true) (checkForSlips true) (checkForUnsavedProjects true) (classicNavigatorEnabled false) (cmdDotEnabled true) (collapseWindowsInPlace false) (compactViewerFlaps false) (confirmFirstUseOfStyle true) (conversionMethodsAtFileOut false) (debugHaloHandle true) (debugPrintSpaceLog false) (debugShowDamage false) (decorateBrowserButtons true) (diffsInChangeList true) (diffsWithPrettyPrint false) (dismissAllOnOptionClose false) (eToyFriendly false) (eToyLoginEnabled false) (enableLocalSave true) (fastDragWindowForMorphic true) (fenceEnabled true) (fullScreenLeavesDeskMargins true) (haloTransitions false) (higherPerformance false) (honorDesktopCmdKeys true) (includeSoundControlInNavigator false) (infiniteUndo false) (logDebuggerStackToFile true) (magicHalos false) (menuColorFromWorld false) (menuKeyboardControl false) (modalColorPickers true) (mouseOverForKeyboardFocus false) (mouseOverHalos false) (mvcProjectsAllowed true) (navigatorOnLeftEdge true) (noviceMode false) (okToReinitializeFlaps true) (optionalButtons true) (passwordsOnPublish false) (personalizedWorldMenu true) (postscriptStoredAsEPS false) (projectViewsInWindows true) (projectZoom true) (projectsSentToDisk false) (propertySheetFromHalo false) (readDocumentAtStartup true) (restartAlsoProceeds false) (reverseWindowStagger true) (roundedMenuCorners true) (scrollBarsNarrow false) (scrollBarsOnRight true) (securityChecksEnabled false) (selectiveHalos false) (showBoundsInHalo false) (showDirectionForSketches false) (showDirectionHandles false) (showFlapsWhenPublishing false) (showProjectNavigator false) (showSecurityStatus true) (showSharedFlaps true) (signProjectFiles true) (simpleMenus false) (smartUpdating true) (startInUntrustedDirectory false) (systemWindowEmbedOK false) (tileTranslucentDrag true) (timeStampsInMenuTitles true) (turnOffPowerManager false) (twentyFourHourFileStamps true) (typeCheckingInTileScripting true) (uniTilesClassic true) (uniqueNamesInHalos false) (universalTiles false) (unlimitedPaintArea false) (useButtonPropertiesToFire false) (useUndo true) (viewersInFlaps true) (warnAboutInsecureContent true) (warnIfNoChangesFile true) (warnIfNoSourcesFile true)) " Preferences defaultValueTableForCurrentRelease do: [:pair | (Preferences preferenceAt: pair first ifAbsent: [nil]) ifNotNilDo: [:pref | pref defaultValue: (pair last == true)]]. Preferences chooseInitialSettings. "!

1 0

The Trunk: Multilingual-mt.275.mcz
by commits＠source.squeak.org 05 Apr '22

05 Apr '22

Marcel Taeumel uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-mt.275.mcz ==================== Summary ==================== Name: Multilingual-mt.275 Author: mt Time: 5 April 2022, 5:11:53.218013 pm UUID: 78036f07-7964-4e69-bcd9-ef8a71100a67 Ancestors: Multilingual-mt.274 Fixes several Unicode input interpreters to consider third buffer position (i.e. ASCII) if the sixth is zero, which aligns with the implementation in UTF32InputInterpreter and UTF32JPInputInterpreter. =============== Diff against Multilingual-mt.274 =============== Item was changed: ----- Method: MacUnicodeInputInterpreter>>nextCharFrom:firstEvt: (in category 'keyboard') ----- nextCharFrom: sensor firstEvt: evtBuf | keyValue mark | keyValue := evtBuf at: 6. + keyValue = 0 ifTrue: [keyValue := evtBuf at: 3]. mark := self japaneseSpecialMark: keyValue. + mark notNil ifTrue: [^ mark]. - mark notNil - ifTrue: [^ mark]. - "Smalltalk systemLanguage charsetClass charFromUnicode: keyValue." ^ Unicode value: keyValue! Item was changed: ----- Method: UTF32CNInputInterpreter>>nextCharFrom:firstEvt: (in category 'as yet unclassified') ----- nextCharFrom: sensor firstEvt: evtBuf | keyValue | keyValue := evtBuf at: 6. + keyValue = 0 ifTrue: [keyValue := evtBuf at: 3]. keyValue < 256 ifTrue: [^Character value: keyValue]. ^ Character leadingChar: SimplifiedChineseEnvironment leadingChar code: keyValue! Item was changed: ----- Method: UTF32GreekInputInterpreter>>nextCharFrom:firstEvt: (in category 'as yet unclassified') ----- nextCharFrom: sensor firstEvt: evtBuf | keyValue | keyValue := evtBuf at: 6. + keyValue = 0 ifTrue: [keyValue := evtBuf at: 3]. keyValue < 256 ifTrue: [^Character value: keyValue]. ^ Character leadingChar: GreekEnvironment leadingChar code: keyValue! Item was changed: ----- Method: UTF32NPInputInterpreter>>nextCharFrom:firstEvt: (in category 'all') ----- nextCharFrom: sensor firstEvt: evtBuf | keyValue | keyValue := evtBuf at: 6. + keyValue = 0 ifTrue: [keyValue := evtBuf at: 3]. keyValue < 256 ifTrue: [^Character value: keyValue]. ^ Character leadingChar: NepaleseEnvironment leadingChar code: keyValue! Item was changed: ----- Method: UTF32RussianInputInterpreter>>nextCharFrom:firstEvt: (in category 'keyboard') ----- nextCharFrom: sensor firstEvt: evtBuf | keyValue | keyValue := evtBuf at: 6. + keyValue = 0 ifTrue: [keyValue := evtBuf at: 3]. keyValue < 256 ifTrue: [^Character value: keyValue]. ^ Character leadingChar: RussianEnvironment leadingChar code: keyValue!

1 0

The Trunk: MultilingualTests-mt.43.mcz
by commits＠source.squeak.org 05 Apr '22

05 Apr '22

Marcel Taeumel uploaded a new version of MultilingualTests to project The Trunk: http://source.squeak.org/trunk/MultilingualTests-mt.43.mcz ==================== Summary ==================== Name: MultilingualTests-mt.43 Author: mt Time: 5 April 2022, 5:04:30.780349 pm UUID: b6f83d06-9399-4276-9fa4-1126c3aa6a45 Ancestors: MultilingualTests-mt.42 Fixes font tests. =============== Diff against MultilingualTests-mt.42 =============== Item was changed: ----- Method: FontTest>>testMultistringFallbackFont (in category 'tests') ----- testMultistringFallbackFont "self debug: #testMultistringFallbackFont" | text p style height width | + TextStyle defaultFont isFontSet ifFalse: [^ self]. + TextStyle defaultFont fontArray + at: JapaneseEnvironment leadingChar + ifAbsent: [^ self]. - [(TextStyle default fontArray at: JapaneseEnvironment leadingChar) - ifNil: [^ self]] - ifError: [:err :rcvr | ^ self]. text := ((#(20983874 20983876 20983878 ) collect: [:e | e asCharacter]) as: String) asText. p := NewParagraph new. style := TextStyle new newFontArray: {Preferences standardFlapFont}. p compose: text style: style from: 1 in: (0 @ 0 corner: 100 @ 100). "See CompositionScanner>>setActualFont: & CompositionScanner>>composeFrom:inRectangle:firstLine:leftSide:rightSide:" height := style defaultFont lineGrid. width := p caretWidth + (text inject: 0 into: [:tally :next | tally + (style defaultFont widthOf: next)]). p adjustRightX. self assert: p extent = (width @ height). "Display getCanvas paragraph: p bounds: (10 @ 10 extent: 100 @ 100) color: Color black"! Item was changed: ----- Method: FontTest>>testMultistringFont (in category 'tests') ----- testMultistringFont "self debug: #testMultistringFont" | text p style height width | + TextStyle defaultFont isFontSet ifFalse: [^ self]. + TextStyle defaultFont fontArray + at: JapaneseEnvironment leadingChar + ifAbsent: [^ self]. - [(TextStyle default fontArray at: JapaneseEnvironment leadingChar) - ifNil: [^ self]] - ifError: [:err :rcvr | ^ self]. text := ((#(20983874 20983876 20983878 ) collect: [:e | e asCharacter]) as: String) asText. p := NewParagraph new. style := TextStyle default. p compose: text style: style from: 1 in: (0 @ 0 corner: 100 @ 100). "See CompositionScanner>>setActualFont: & CompositionScanner>>composeFrom:inRectangle:firstLine:leftSide:rightSide:" height := style defaultFont lineGrid. width := p caretWidth + (text inject: 0 into: [:tally :next | tally + (style defaultFont widthOf: next)]). p adjustRightX. self assert: p extent = (width @ height). "Display getCanvas paragraph: p bounds: (10 @ 10 extent: 100 @ 100) color: Color black"! Item was changed: ----- Method: FontTest>>testParagraph (in category 'tests') ----- testParagraph "self debug: #testParagraph" | text p style height width | text := 'test' asText. p := NewParagraph new. style := TextStyle default. p compose: text style: style from: 1 in: (0 @ 0 corner: 1000000 @ 1000000). "See CompositionScanner>>setActualFont: & CompositionScanner>>composeFrom:inRectangle:firstLine:leftSide:rightSide:" height := style defaultFont lineGrid. width := (text inject: 0 into: [:tally :next | tally + + (style defaultFont widthOf: next)]). - + (style defaultFont widthOf: next)]) + p caretWidth. "because it is added by the paragraph formatting" p adjustRightX. self assert: p extent = (width @ height)! Item was changed: ----- Method: FontTest>>testParagraphFallback (in category 'tests') ----- testParagraphFallback "self debug: #testParagraphFallback" | text p style height width e expect | e := (Character value: 257) asString. text := ('test' , e , e , e , e , 'test') asText. expect := 'test????test'. p := NewParagraph new. style := TextStyle default. p compose: text style: style from: 1 in: (0 @ 0 corner: 1000000 @ 1000000). "See CompositionScanner>>setActualFont: & CompositionScanner>>composeFrom:inRectangle:firstLine:leftSide:rightSide:" height := style defaultFont lineGrid. width := (expect inject: 0 into: [:tally :next | tally + + (style defaultFont widthOf: next)]). - + (style defaultFont widthOf: next)]) + p caretWidth. p adjustRightX. self assert: p extent = (width @ height). "Display getCanvas paragraph: p bounds: (10 @ 10 extent: 100 @ 100) color: Color black"! Item was changed: ----- Method: FontTest>>testResetAfterEmphasized (in category 'tests') ----- testResetAfterEmphasized "self debug: #testResetAfterEmphasized" + | normal code derivative | - | normal derivative | normal := TextStyle defaultFont. + code := TextEmphasis bold emphasisCode bitOr: TextEmphasis italic emphasisCode. + derivative := normal emphasized: code. + self assert: (normal derivativeFonts at: code) == derivative. + normal isTTCFont ifFalse: [ + normal reset. + self assert: (normal derivativeFonts select:[:any| any isSynthetic]) isEmpty]. - derivative := normal emphasized: 3. - self assert: (normal derivativeFonts at: 3) == derivative. - normal reset. - self assert: (normal derivativeFonts select:[:any| any isSynthetic]) isEmpty !

1 0

The Trunk: MorphicTests-mt.85.mcz
by commits＠source.squeak.org 05 Apr '22

05 Apr '22

Marcel Taeumel uploaded a new version of MorphicTests to project The Trunk: http://source.squeak.org/trunk/MorphicTests-mt.85.mcz ==================== Summary ==================== Name: MorphicTests-mt.85 Author: mt Time: 5 April 2022, 4:53:39.334186 pm UUID: f3f26703-4a52-4861-b543-bb410ed24a66 Ancestors: MorphicTests-mt.84 Fixes text-anchor layout tests. =============== Diff against MorphicTests-mt.84 =============== Item was changed: TestCase subclass: #TextAnchorTest + instanceVariableNames: 'anchoredMorph anchorAttribute font text textMorph' - instanceVariableNames: 'anchoredMorph anchorAttribute text textMorph' classVariableNames: '' poolDictionaries: '' category: 'MorphicTests-Text Support'! Item was changed: ----- Method: TextAnchorTest>>prepareTextMorph (in category 'utility') ----- prepareTextMorph textMorph := text asMorph. + textMorph font: font. self refreshTextMorph.! Item was changed: ----- Method: TextAnchorTest>>setUp (in category 'running') ----- setUp super setUp. anchoredMorph := TextAnchorTestMorph new. anchorAttribute := TextAnchor new anchoredMorph: anchoredMorph. text := Text streamContents: [:stream | stream nextPutAll: 'Here is a contrived example '; nextPutAll: (Text string: Character startOfHeader asString attributes: { anchorAttribute. TextColor color: Color transparent}); nextPutAll: ' whose morph is in the center.' ]. + font := TextStyle defaultFont. self prepareTextMorph.! Item was changed: ----- Method: TextAnchorTest>>testHavingADocumentAnchorShouldNotAffectTheLineHeight (in category 'tests') ----- testHavingADocumentAnchorShouldNotAffectTheLineHeight | firstLine | anchoredMorph := Morph new. + anchoredMorph height: font height * 2. - anchoredMorph height: 50. anchoredMorph textAnchorProperties positionInDocument: 20 @ 10; anchorLayout: #document. anchorAttribute anchoredMorph: anchoredMorph. self prepareTextMorph. firstLine := textMorph paragraph lines first. self + assert: firstLine lineHeight < anchoredMorph height - assert: (firstLine bottom - firstLine top) < 25 description: '#document layouted anchor should not affect line height'. ! Item was changed: ----- Method: TextAnchorTest>>testPaddingBottom (in category 'tests-padding') ----- testPaddingBottom self after: [ anchoredMorph height: 20. anchoredMorph textAnchorProperties verticalAlignment: #(bottom baseline). anchoredMorph textAnchorProperties padding: (anchoredMorph textAnchorProperties padding bottom: 10)] paddingChangesTo: [:line | + self assert: line baseline equals: anchoredMorph bottom + 10 ]! - self assert: anchoredMorph bottom + 10 = line baseline ]! Item was changed: ----- Method: TextAnchorTest>>testPaddingBottomAndBottom (in category 'tests-padding') ----- testPaddingBottomAndBottom self after: [ anchoredMorph height: 20. anchoredMorph textAnchorProperties verticalAlignment: #(bottom bottom). anchoredMorph textAnchorProperties padding: (anchoredMorph textAnchorProperties padding bottom: 10)] paddingChangesTo: [:line | + self assert: line baseline + font descent "= visual line bottom" equals: anchoredMorph bottom + 10 ]! - self assert: anchoredMorph bottom + 10 = line bottom ]! Item was changed: ----- Method: TextAnchorTest>>testPaddingBottomAndBottomWithConvenienceAlignment (in category 'tests-padding') ----- testPaddingBottomAndBottomWithConvenienceAlignment self after: [ anchoredMorph height: 20. anchoredMorph textAnchorProperties verticalAlignment: #bottom. anchoredMorph textAnchorProperties padding: (anchoredMorph textAnchorProperties padding bottom: 10)] paddingChangesTo: [:line | + self assert: line baseline + font descent "= visual line bottom" equals: anchoredMorph bottom + 10 ]! - self assert: anchoredMorph bottom + 10 = line bottom ]! Item was changed: ----- Method: TextAnchorTest>>testPaddingTop (in category 'tests-padding') ----- testPaddingTop self after: [ anchoredMorph height: 20. anchoredMorph textAnchorProperties verticalAlignment: #(top baseline). anchoredMorph textAnchorProperties padding: (anchoredMorph textAnchorProperties padding top: 10)] + paddingChangesTo: [:line | + self assert: line baseline equals: anchoredMorph top - 10 ]! - paddingChangesTo: [:line | | anchoredMorphTop | - anchoredMorphTop := anchoredMorph top - textMorph top. - self assert: anchoredMorphTop - 10 = line baseline ]! Item was changed: ----- Method: TextAnchorTest>>testPaddingTopAndBottom (in category 'tests-padding') ----- testPaddingTopAndBottom self after: [ anchoredMorph height: 30. anchoredMorph textAnchorProperties verticalAlignment: #(#bottom #bottom). anchoredMorph textAnchorProperties padding: (anchoredMorph textAnchorProperties padding bottom: 10). anchoredMorph textAnchorProperties padding: (anchoredMorph textAnchorProperties padding top: 10).] paddingChangesTo: [:line | + self assert: line baseline + font descent "= visual line bottom" equals: anchoredMorph bottom + 10. + self + deny: line baseline - font ascent "= visual line top" + equals: anchoredMorph top - 10 + description: 'We only apply padding to the morph position'.]! - self assert: anchoredMorph bottom + 10 = line bottom. - self deny: anchoredMorph top - 10= line top description: 'We only apply padding to the morph position'.]! Item was changed: ----- Method: TextAnchorTest>>testPaddingTopAndTop (in category 'tests-padding') ----- testPaddingTopAndTop self after: [ anchoredMorph height: 20. + anchoredMorph textAnchorProperties verticalAlignment: #(top top). - anchoredMorph textAnchorProperties verticalAlignment: #(top baseline). anchoredMorph textAnchorProperties padding: (anchoredMorph textAnchorProperties padding top: 10)] + paddingChangesTo: [:line | + self assert: line baseline - font ascent "= visual line top" equals: anchoredMorph top - 10 ]! - paddingChangesTo: [:line | | anchoredMorphTop | - anchoredMorphTop := anchoredMorph top - textMorph top. - self assert: anchoredMorphTop - 10 = line baseline ]!

1 0

The Trunk: SUnitGUI-mt.87.mcz
by commits＠source.squeak.org 05 Apr '22

05 Apr '22

Marcel Taeumel uploaded a new version of SUnitGUI to project The Trunk: http://source.squeak.org/trunk/SUnitGUI-mt.87.mcz ==================== Summary ==================== Name: SUnitGUI-mt.87 Author: mt Time: 5 April 2022, 3:37:02.213949 pm UUID: 76f6e024-4ac9-ef4e-9e3e-704fd2a2e440 Ancestors: SUnitGUI-ct.86 We usually need 3 lines of text in the status field. =============== Diff against SUnitGUI-ct.86 =============== Item was changed: ----- Method: TestRunner>>statusHeight (in category 'building') ----- statusHeight + ^ ToolBuilder default inputFieldHeightFor: 3! - ^Preferences standardCodeFont height * 2 + 12!

1 0

The Trunk: Morphic-mt.1957.mcz
by commits＠source.squeak.org 05 Apr '22

05 Apr '22

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1957.mcz ==================== Summary ==================== Name: Morphic-mt.1957 Author: mt Time: 5 April 2022, 3:30:34.499949 pm UUID: cc3da8b2-65c1-4045-8227-46b2545f5c63 Ancestors: Morphic-ul.1956 Enable image-side composition buffer for Morphic on all macOS platforms. See commentary in #startUpActions. =============== Diff against Morphic-ul.1956 =============== Item was changed: ----- Method: MorphicProject>>startUpActions (in category 'enter') ----- startUpActions super startUpActions. self world install. + self world firstHand position: 100@100. + + "April 2022: None of the currently supported graphics backends on macOS (i.e., -metal -core-graphics, -opengl) in the OSVM supports an extra display buffer at the VM side, which may result in flickering during compositing or an expensive (over-)committing at vsync boundaries. Thus, use an image-side buffer for compositing to mitigate (or avoid) these issues." + WorldState disableDeferredUpdates: Smalltalk platformName = 'Mac OS'.! - self world firstHand position: 100@100.! Item was changed: ----- Method: PasteUpMorph>>installFlaps (in category 'world state') ----- installFlaps "Get flaps installed within the bounds of the receiver" | localFlapTabs | Project current assureFlapIntegrity. self addGlobalFlaps. localFlapTabs := self localFlapTabs. localFlapTabs do: [:each | each visible: false]. + localFlapTabs keysAndValuesDo: [:i :each | + each adaptToWorld. + each visible: true. + self changed]. - Preferences eToyFriendly ifTrue: [ - ProgressInitiationException display: 'Building Viewers...' translated - during: [:bar | - localFlapTabs keysAndValuesDo: [:i :each | - each adaptToWorld. - each visible: true. - each unhibernate. - self changed. - bar value: i / self localFlapTabs size]]. - ] ifFalse: [ - localFlapTabs keysAndValuesDo: [:i :each | - each adaptToWorld. - each visible: true. - self changed]]. self assureFlapTabsFitOnScreen. self bringTopmostsToFront! Item was changed: + (PackageInfo named: 'Morphic') postscript: 'Preferences maxBalloonHelpLineLength: 45. + + "See commentary in MorphicProject >> #startUpActions." + WorldState disableDeferredUpdates: Smalltalk platformName = ''Mac OS''.'! - (PackageInfo named: 'Morphic') postscript: 'Preferences maxBalloonHelpLineLength: 45.'!

1 0

The Trunk: System-mt.1334.mcz
by commits＠source.squeak.org 05 Apr '22

05 Apr '22

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1334.mcz ==================== Summary ==================== Name: System-mt.1334 Author: mt Time: 5 April 2022, 3:28:26.895949 pm UUID: d03e8df4-a41b-0d46-9afc-94959770ade2 Ancestors: System-ct.1333 Minor clean up and more documentation around Project startUp and shutDown. =============== Diff against System-ct.1333 =============== Item was changed: ----- Method: Project class>>shutDown: (in category 'snapshots') ----- shutDown: quitting + "1) Give the current project a chance to clean-up if we are about to quit." + quitting ifTrue: [Project current shutDownActions]. + + "2) To save some space in the .image file, shrink the display bits. Not sure why we need to #invalidate, though..." + Project current invalidate; shrinkDisplay.! - Project current - invalidate; - shrinkDisplay. - - quitting ifTrue: [ - Project current world triggerEvent: #aboutToLeaveWorld].! Item was changed: ----- Method: Project class>>startUp: (in category 'snapshots') ----- startUp: startAfresh + "0) No blitting onto Display must be performed before this point!! Or the VM will crash." + + "1) We just shrunk the display form to save space in the .image file. We have to restore it now. Also, when we start afresh, we MUST communicate display form and depth to the VM as both are cannot be retrieved from the image header." Project current restoreDisplay. + "2) Give the current project a chance to initialize if we start afresh. After that, repaint everything to avoid flickering if the start-up actions changed something." + startAfresh ifTrue: [Project current startUpActions; restore].! - startAfresh ifTrue: [ - Project current startUpActions. - Project current world triggerEvent: #aboutToEnterWorld]. - - Project current restore.! Item was added: + ----- Method: Project>>shutDownActions (in category 'enter') ----- + shutDownActions + "The image is about to be snapshotted *and* quitting after that." + + self world triggerEvent: #aboutToLeaveWorld. + ! Item was changed: ----- Method: Project>>startUpActions (in category 'enter') ----- startUpActions "The image is being newly started, not just snapshotted." + self world triggerEvent: #aboutToEnterWorld. !

1 0

The Trunk: MultilingualTests-mt.42.mcz
by commits＠source.squeak.org 05 Apr '22

05 Apr '22

Marcel Taeumel uploaded a new version of MultilingualTests to project The Trunk: http://source.squeak.org/trunk/MultilingualTests-mt.42.mcz ==================== Summary ==================== Name: MultilingualTests-mt.42 Author: mt Time: 5 April 2022, 3:15:31.575397 pm UUID: 255b0130-5a2b-4cb6-8c3b-9799e047dcb0 Ancestors: MultilingualTests-ct.41 Ignore KOI8FTextConverter from the tests because it maps two different bytes to the same Unicode code points. We cannot go back. 16r9A -> 16rA0 16rA0 -> 16rA0 =============== Diff against MultilingualTests-ct.41 =============== Item was changed: ----- Method: MultiByteFileStreamTest>>testByteTextConverter (in category 'tests') ----- testByteTextConverter | byteCharacters converterClasses | byteCharacters := Character allByteCharacters. converterClasses := ByteTextConverter allSubclasses + copyWithoutAll: {ISO8859TextConverter . WinCPTextConverter . MacOSCPTextConverter . KOI8FTextConverter }. - copyWithoutAll: {ISO8859TextConverter . WinCPTextConverter . MacOSCPTextConverter}. converterClasses do: [ :converterClass | | converter stream encoded decoded encoded2 | converter := converterClass new. stream := byteCharacters readStream. "Find bytes that can be decoded by this converter." encoded := byteCharacters select: [ :e | (converter nextFromStream: stream) notNil ]. "Decode those bytes." stream := encoded readStream. decoded := encoded collect: [ :e | converter nextFromStream: stream ]. self assert: stream atEnd. "Re-encode the decoded bytes using #nextPutAll:toStream:, and check if they match the original bytes." encoded2 := String streamContents: [ :writeStream | converter nextPutAll: decoded toStream: writeStream ]. encoded with: encoded2 do: [ :original :reencoded | self assert: original charCode = reencoded charCode description: [ '{1} could not decode or re-encode {2} using #nextPutAll:toStream:. Instead, it yielded {3}.' format: { converterClass name. original charCode. reencoded charCode } ] ]. "Re-encode the decoded bytes using #nextPut:toStream:, and check if they match the original bytes." encoded2 := String streamContents: [ :writeStream | decoded do: [:e | converter nextPut: e toStream: writeStream ] ]. encoded with: encoded2 do: [ :original :reencoded | self assert: original charCode = reencoded charCode description: [ '{1} could not decode or re-encode {2} using #nextPut:toStream:. Instead, it yielded {3}.' format: { converterClass name. original charCode. reencoded charCode } ] ] ]!

1 0

Jump to page: