Squeak-dev April 2022

squeak-dev@lists.squeakfoundation.org

29 participants
332 discussions

The Trunk: Multilingual-mt.274.mcz
by commits＠source.squeak.org 05 Apr '22

05 Apr '22

Marcel Taeumel uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-mt.274.mcz ==================== Summary ==================== Name: Multilingual-mt.274 Author: mt Time: 5 April 2022, 3:09:01.613197 pm UUID: e384534c-f1fa-4754-8e4b-a1562f60b990 Ancestors: Multilingual-mt.273 Clean-up some MC-related move-method issues, step 2 of 2. =============== Diff against Multilingual-mt.273 =============== Item was removed: - ----- Method: M17nEnvironment class>>fileNameConverterClass (in category 'subclass responsibilities') ----- - fileNameConverterClass - - ^ UTF8TextConverter. - ! Item was removed: - ----- Method: M17nEnvironment class>>leadingChar (in category 'subclass responsibilities') ----- - leadingChar - - ^ Unicode leadingChar. - ! Item was removed: - ----- Method: NepaleseEnvironment class>>fileNameConverterClass (in category 'subclass responsibilities') ----- - fileNameConverterClass - - ^ UTF8TextConverter. - !

2 1

The Trunk: Multilingual-mt.273.mcz
by commits＠source.squeak.org 05 Apr '22

05 Apr '22

Marcel Taeumel uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-mt.273.mcz ==================== Summary ==================== Name: Multilingual-mt.273 Author: mt Time: 5 April 2022, 3:08:30.567971 pm UUID: c11e9352-82d9-4d10-b72f-6041b36cf093 Ancestors: Multilingual-ct.272 Initialize Latin2TextConverter to make tests pass. Clean-up some MC-related move-method issues, step 1 of 2. =============== Diff against Multilingual-ct.272 =============== Item was added: + ----- Method: M17nEnvironment class>>fileNameConverterClass (in category 'subclass responsibilities') ----- + fileNameConverterClass + + ^ UTF8TextConverter. + ! Item was added: + ----- Method: M17nEnvironment class>>leadingChar (in category 'subclass responsibilities') ----- + leadingChar + + ^ Unicode leadingChar. + ! Item was added: + ----- Method: NepaleseEnvironment class>>fileNameConverterClass (in category 'subclass responsibilities') ----- + fileNameConverterClass + + ^ UTF8TextConverter. + ! Item was changed: + (PackageInfo named: 'Multilingual') postscript: 'Latin2TextConverter initializeTables.'! - (PackageInfo named: 'Multilingual') postscript: 'Smalltalk removeFromStartUpList: LanguageEnvironment. - LanguageEnvironment resetKnownEnvironments.'!

1 0

The Trunk: MorphicTests-mt.84.mcz
by commits＠source.squeak.org 05 Apr '22

05 Apr '22

Marcel Taeumel uploaded a new version of MorphicTests to project The Trunk: http://source.squeak.org/trunk/MorphicTests-mt.84.mcz ==================== Summary ==================== Name: MorphicTests-mt.84 Author: mt Time: 5 April 2022, 2:36:45.389025 pm UUID: 6a7e9954-f900-44f9-b876-f2d43a5ee8bc Ancestors: MorphicTests-lrnp.83 Fixes some layout tests. =============== Diff against MorphicTests-lrnp.83 =============== Item was changed: ----- Method: TableLayoutTest>>testPluggableTextMorph (in category 'tests') ----- testPluggableTextMorph + | ptm ptmExtent | + ptmExtent := 100 @ (TextStyle defaultFont height * 3). - | ptm | ptm := PluggableTextMorph new + extent: ptmExtent; - extent: 100@50; setText: 'Hello World!! Hello World!! Hello World!! Hello World!!'; wrapFlag: true. container := self newContainer addMorphBack: ptm. self ensureLayout: container. + self assert: ptmExtent equals: container extent. - self assert: 100@50 equals: container extent. self assert: ptm vIsScrollbarShowing. self deny: ptm hIsScrollbarShowing. "Make it a one-liner." ptm wrapFlag: false. self ensureLayout: container. self deny: ptm vIsScrollbarShowing. self assert: ptm hIsScrollbarShowing. "Make it a one-liner without the horizontal scrollbar." ptm hideScrollBarsIndefinitely. self ensureLayout: container. self deny: ptm vIsScrollbarShowing. self deny: ptm hIsScrollbarShowing. ! Item was changed: ----- Method: TableLayoutTest>>testTwoTextMorphsHorizontal (in category 'tests') ----- testTwoTextMorphsHorizontal | str1 str2 label2 label1 heightAt200 | str1 := 'abc def'. str2 := 'tzu ghj qwe'. container := self newContainer hResizing: #spaceFill; vResizing: #shrinkWrap; addMorphBack: (label1 := TextMorph new contents: str1; wrapFlag: true; hResizing: #spaceFill); addMorphBack: (label2 := TextMorph new contents: str2; wrapFlag: true; hResizing: #spaceFill). container width: 200. self ensureLayout: container. heightAt200 := container height. self assert: 100 equals: label1 width. self assert: 100 equals: label2 width. container width: 100. self ensureLayout: container. self assert: 50 equals: label1 width. self assert: 50 equals: label2 width. self assert: container height > heightAt200. container width: 10000. self ensureLayout: container. self assert: 5000 equals: label1 width. self assert: 5000 equals: label2 width. + self assert: self defaultFont lineGrid equals: container height! - self assert: self defaultFont height + 2 equals: container height! Item was changed: ----- Method: TableLayoutTest>>testTwoTextMorphsVertical (in category 'tests') ----- testTwoTextMorphsVertical + | str1 str2 label2 label1 font minWidth | - | str1 str2 label2 label1 font | str1 := 'abc def'. str2 := 'tzu ghj qwe'. container := self newContainer hResizing: #spaceFill; vResizing: #shrinkWrap; listDirection: #topToBottom; addMorphBack: (label1 := TextMorph new contents: str1; wrapFlag: true; hResizing: #spaceFill); addMorphBack: (label2 := TextMorph new contents: str2; wrapFlag: true; hResizing: #spaceFill). font := self defaultFont. + minWidth := label1 minWidth max: label2 minWidth. + #(1 2 4 8) do: [:factor | + container width: factor * minWidth. + self ensureLayout: container. + self assert: container width equals: label1 width. + self assert: container width equals: label2 width. + self assert: 0 equals: container height \\ font lineGrid].! - container width: 200. - self ensureLayout: container. - self assert: 200 @ (font height + 2) equals: label1 extent. - self assert: 200 @ (font height + 2) equals: label2 extent. - - container width: 50. - self ensureLayout: container. - self assert: 50 equals: label1 width. - self assert: 50 equals: label2 width. - " check that we land on a multiple of the line height " - self assert: 0 equals: container height \\ (font height + 2). - - container width: 20. - self ensureLayout: container. - self assert: 20 equals: label1 width. - self assert: 20 equals: label2 width. - " check that we land on a multiple of the line height " - self assert: 0 equals: container height \\ (font height + 2)!

1 0

The Trunk: MorphicTests-lrnp.83.mcz
by commits＠source.squeak.org 05 Apr '22

05 Apr '22

Marcel Taeumel uploaded a new version of MorphicTests to project The Trunk: http://source.squeak.org/trunk/MorphicTests-lrnp.83.mcz ==================== Summary ==================== Name: MorphicTests-lrnp.83 Author: lrnp Time: 29 March 2022, 10:37:07.821731 pm UUID: 4be0f980-b341-4fd3-80ac-9d187d1caf7d Ancestors: MorphicTests-ct.82 handle preferences that alter test results Turn off Always Show V Scrollbar. This causes many tests to fail when turned on. Use the preference-friendly #lineGridForMorphs method instead of #height. There are two font heights based on the Use Compact Lists preference; this method picks the correct one. =============== Diff against MorphicTests-ct.82 =============== Item was changed: ----- Method: TableLayoutTest>>setUp (in category 'running') ----- setUp super setUp. reset := { ([:enable | [self useRetractableScrollBars: enable]] + value: self useRetractableScrollBars). + ([:previous | [Preferences setFlag: #alwaysShowVScrollbar toValue: previous]] + value: (Preferences valueOfFlag: #alwaysShowVScrollbar)) - value: self useRetractableScrollBars) }. + self useRetractableScrollBars: false. + Preferences setFlag: #alwaysShowVScrollbar toValue: false.! - self useRetractableScrollBars: false! Item was changed: ----- Method: TableLayoutTest>>testBrowser (in category 'tests - example layouts') ----- testBrowser " replicate the layout used by the system browser with a table layout " | buttons | buttons := #('browse' 'senders' 'implementors' 'versions' 'inheritance' 'hierarchy' 'vars' 'source') collect: [:label | self newMorph hResizing: #spaceFill; vResizing: #shrinkWrap; wrapCentering: #center; layoutPolicy: TableLayout new; layoutInset: 8; addMorph: (StringMorph new contents: label)]. container := self newContainer listDirection: #topToBottom; layoutInset: 8; cellGap: 8; addMorphBack: (self newContainer cellGap: 8; listDirection: #leftToRight; hResizing: #spaceFill; vResizing: #spaceFill; minimumHeight: 30; addMorphBack: (self newMorph hResizing: #spaceFill; vResizing: #spaceFill); addMorphBack: (self newMorph hResizing: #spaceFill; vResizing: #spaceFill); addMorphBack: (self newMorph hResizing: #spaceFill; vResizing: #spaceFill); addMorphBack: (self newMorph hResizing: #spaceFill; vResizing: #spaceFill)); addMorphBack: (self newContainer vResizing: #shrinkWrap; hResizing: #spaceFill; cellGap: 2; addAllMorphsBack: buttons); addMorphBack: (self newMorph minimumHeight: 100; hResizing: #spaceFill; vResizing: #spaceFill). container extent: 0 @ 0. "container openInHand." self ensureLayout: container. + self assert: 100 + 30 + self defaultFont lineGridForMorphs + (8 * 6) equals: container height! - self assert: 100 + 30 + self defaultFont height + (8 * 6) equals: container height!

1 0

What is happening here?
by Stéphane Rollandin 04 Apr '22

04 Apr '22

Hello all, I just spent an hour or so chasing a strange glitch in my game, which makes a massive usage of Random, and the culprit is as follow: 1) This, as expected, yields a Set of 10 different numbers: | b s | b := [Random new]. s := Set new. 10 timesRepeat: [s add: b value next]. s 2) This yields a Set of one single number: | b s | b := [Random new]. s := Set new. 10 timesRepeat: [s add: b]. s collect: [:d | d value next] Unless I am missing something, this looks like a pretty serious bug. Tested in the latest trunk image, on win 64. Stef

3 6

The Trunk: Multilingual-ct.272.mcz
by commits＠source.squeak.org 04 Apr '22

04 Apr '22

Christoph Thiede uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-ct.272.mcz ==================== Summary ==================== Name: Multilingual-ct.272 Author: ct Time: 4 April 2022, 8:15:09.254857 pm UUID: a7842107-2da9-804f-a666-54806f1ad376 Ancestors: Multilingual-ct.271 Increases robustness of Unicode class>>#reinitializeData. In some cases, NetNameResolver might access Unicode data during downloading, so do not clear them prior to parsing. Also, the former implementation was not interactively debuggable. =============== Diff against Multilingual-ct.271 =============== Item was changed: ----- Method: Unicode class>>reinitializeData (in category 'class initialization') ----- reinitializeData + self initializeTagConstants. + + self flag: #deduplicate. "Currently, we are downloading and parsing #unicodeData twice." + self initializeCompositionMappings. + self initializeUnicodeData.! - Compositions := GeneralCategory := nil. - self initialize.!

1 0

The Trunk: ReleaseBuilder-ct.231.mcz
by commits＠source.squeak.org 04 Apr '22

04 Apr '22

Christoph Thiede uploaded a new version of ReleaseBuilder to project The Trunk: http://source.squeak.org/trunk/ReleaseBuilder-ct.231.mcz ==================== Summary ==================== Name: ReleaseBuilder-ct.231 Author: ct Time: 4 April 2022, 7:58:04.67046 pm UUID: 8dc82f1b-fdfc-1a42-b23a-c0098c471822 Ancestors: ReleaseBuilder-mt.230 Multilingual-ct.271 (unicode data). Fetch latest Unicode data when building a new image. =============== Diff against ReleaseBuilder-mt.230 =============== Item was changed: ----- Method: ReleaseBuilder class>>prepareSourceCode (in category 'preparing') ----- prepareSourceCode "Update packages. Remove foreign packages. Recompile." CurrentReadOnlySourceFiles cacheDuring: [self updateCorePackages; unloadForeignPackages; checkForDirtyPackages; loadWellKnownPackages; checkForUndeclaredSymbols; checkForNilCategories; + recompileAll; + updateDatabases]! - recompileAll]! Item was added: + ----- Method: ReleaseBuilder class>>updateDatabases (in category 'scripts - support') ----- + updateDatabases + + Unicode reinitializeData.!

1 0

The Trunk: MultilingualTests-ct.41.mcz
by commits＠source.squeak.org 04 Apr '22

04 Apr '22

Christoph Thiede uploaded a new version of MultilingualTests to project The Trunk: http://source.squeak.org/trunk/MultilingualTests-ct.41.mcz ==================== Summary ==================== Name: MultilingualTests-ct.41 Author: ct Time: 4 April 2022, 7:57:59.15946 pm UUID: 6d66c120-b0b2-3b4f-8177-8c4c1c92343d Ancestors: MultilingualTests-mt.40 Complements Multilingual-ct.271 (unicode data). Tests unicode category protocol and fetching/parsing of unicode data. =============== Diff against MultilingualTests-mt.40 =============== Item was changed: SystemOrganization addCategory: #'MultilingualTests-TextConversion'! SystemOrganization addCategory: #'MultilingualTests-Display'! + SystemOrganization addCategory: #'MultilingualTests-Encodings'! Item was added: + TestCase subclass: #UnicodeTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'MultilingualTests-Encodings'! Item was added: + ----- Method: UnicodeTest class>>resources (in category 'accessing') ----- + resources + + ^ super resources copyWith: UnicodeTestResource! Item was added: + ----- Method: UnicodeTest>>testGeneralCategoryLabel (in category 'tests - character classification') ----- + testGeneralCategoryLabel + + self assert: 'Letter, Lowercase' equals: (Unicode generalCategoryLabelOf: $a asUnicode). + self assert: 'Letter, Uppercase' equals: (Unicode generalCategoryLabelOf: $Z asUnicode). + + self assert: 'Number, Decimal' equals: (Unicode generalCategoryLabelOf: $5 asUnicode). + self assert: 'Symbol, Other' equals: (Unicode generalCategoryLabelOf: 16r1F388). + + self assert: 'n/a' equals: (Unicode generalCategoryLabelOf: Float infinity).! Item was added: + ----- Method: UnicodeTest>>testGeneralCategoryLabelForTag (in category 'tests - character classification') ----- + testGeneralCategoryLabelForTag + + self assert: 'Letter, Lowercase' equals: (Unicode generalCategoryLabelForTag: #Ll).! Item was added: + ----- Method: UnicodeTest>>testGeneralCategoryTag (in category 'tests - character classification') ----- + testGeneralCategoryTag + + self assert: #Ll equals: (Unicode generalCategoryTagOf: $a asUnicode). + self assert: #Lu equals: (Unicode generalCategoryTagOf: $Z asUnicode). + + self assert: #Nd equals: (Unicode generalCategoryTagOf: $5 asUnicode). + self assert: #So equals: (Unicode generalCategoryTagOf: 16r1F388). + + self assert: #Cn equals: (Unicode generalCategoryTagOf: Float infinity).! Item was added: + TestResource subclass: #UnicodeTestResource + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'MultilingualTests-Encodings'! Item was added: + ----- Method: UnicodeTestResource>>setUp (in category 'running') ----- + setUp + + super setUp. + + "Test the functionality of this update logic" + Unicode initializeCompositionMappings. + Unicode initializeUnicodeData.!

1 0

The Trunk: Multilingual-ct.271.mcz
by commits＠source.squeak.org 04 Apr '22

04 Apr '22

Christoph Thiede uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-ct.271.mcz ==================== Summary ==================== Name: Multilingual-ct.271 Author: ct Time: 4 April 2022, 7:57:21.50746 pm UUID: de94b8ca-494e-d149-b2e0-e7e6d714d25b Ancestors: Multilingual-mt.270 Merges UnicodeData.cs: This changeset repairs the fetching & parsing of unicode category data and adds new interface #generalCategoryTagOf: and protocol for converting between unicode categories and tags.. Usage: Unicode reinitializeData. Unicode generalCategoryLabelOf: 16r1F388. 'Symbol, Other' Still present limitations include: - Duplication between #parseUnicodeDataFrom: and #parseCompositionMappingFrom: - Redundant and scattered declaration of character categories Revision from 3.cs: Minor clean-up in #parseUnicodeDataFrom:, fix default category values. Note that this change will not yet upgrade your Unicode database, which will only happen when building a new image. However, you can run "Unicode reinitializeData" to benefit from the new data right now. The only reason why I did not put this into the postscript is literally to avoid any trouble with proxies or firewalls. :-) Thanks to Levente (ul) and Marcel (mt) for their help! For more information, see: http://lists.squeakfoundation.org/pipermail/squeak-dev/2020-March/208020.ht… =============== Diff against Multilingual-mt.270 =============== Item was changed: EUCCNTextConverter subclass: #CNGBTextConverter instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'Multilingual-TextConversion'! + + !CNGBTextConverter commentStamp: '<historical>' prior: 0! + Text converter for Simplified Chinese variation of EUC. (Even though the name doesn't look so, it is what it is.)! Item was added: + ----- Method: Unicode class>>allCategoryTags (in category 'character classification') ----- + allCategoryTags + + ^ #(Cn Cc Cf Co Cs Ll Lm Lo Lt Lu Mc Me Mn Nd Nl No Pc Pd Pe Pf Pi Po Ps Sc Sk Sm So Zl Zp Zs)! Item was changed: ----- Method: Unicode class>>blocks320Comment (in category 'comments') ----- blocks320Comment + "http://www.unicode.org/Public/3.2-Update/Blocks-3.2.0.txt" "# Blocks-3.2.0.txt # Correlated with Unicode 3.2 # Start Code..End Code; Block Name 0000..007F; Basic Latin 0080..00FF; Latin-1 Supplement 0100..017F; Latin Extended-A 0180..024F; Latin Extended-B 0250..02AF; IPA Extensions 02B0..02FF; Spacing Modifier Letters 0300..036F; Combining Diacritical Marks 0370..03FF; Greek and Coptic 0400..04FF; Cyrillic 0500..052F; Cyrillic Supplementary 0530..058F; Armenian 0590..05FF; Hebrew 0600..06FF; Arabic 0700..074F; Syriac 0780..07BF; Thaana 0900..097F; Devanagari 0980..09FF; Bengali 0A00..0A7F; Gurmukhi 0A80..0AFF; Gujarati 0B00..0B7F; Oriya 0B80..0BFF; Tamil 0C00..0C7F; Telugu 0C80..0CFF; Kannada 0D00..0D7F; Malayalam 0D80..0DFF; Sinhala 0E00..0E7F; Thai 0E80..0EFF; Lao 0F00..0FFF; Tibetan 1000..109F; Myanmar 10A0..10FF; Georgian 1100..11FF; Hangul Jamo 1200..137F; Ethiopic 13A0..13FF; Cherokee 1400..167F; Unified Canadian Aboriginal Syllabics 1680..169F; Ogham 16A0..16FF; Runic 1700..171F; Tagalog 1720..173F; Hanunoo 1740..175F; Buhid 1760..177F; Tagbanwa 1780..17FF; Khmer 1800..18AF; Mongolian 1E00..1EFF; Latin Extended Additional 1F00..1FFF; Greek Extended 2000..206F; General Punctuation 2070..209F; Superscripts and Subscripts 20A0..20CF; Currency Symbols 20D0..20FF; Combining Diacritical Marks for Symbols 2100..214F; Letterlike Symbols 2150..218F; Number Forms 2190..21FF; Arrows 2200..22FF; Mathematical Operators 2300..23FF; Miscellaneous Technical 2400..243F; Control Pictures 2440..245F; Optical Character Recognition 2460..24FF; Enclosed Alphanumerics 2500..257F; Box Drawing 2580..259F; Block Elements 25A0..25FF; Geometric Shapes 2600..26FF; Miscellaneous Symbols 2700..27BF; Dingbats 27C0..27EF; Miscellaneous Mathematical Symbols-A 27F0..27FF; Supplemental Arrows-A 2800..28FF; Braille Patterns 2900..297F; Supplemental Arrows-B 2980..29FF; Miscellaneous Mathematical Symbols-B 2A00..2AFF; Supplemental Mathematical Operators 2E80..2EFF; CJK Radicals Supplement 2F00..2FDF; Kangxi Radicals 2FF0..2FFF; Ideographic Description Characters 3000..303F; CJK Symbols and Punctuation 3040..309F; Hiragana 30A0..30FF; Katakana 3100..312F; Bopomofo 3130..318F; Hangul Compatibility Jamo 3190..319F; Kanbun 31A0..31BF; Bopomofo Extended 31F0..31FF; Katakana Phonetic Extensions 3200..32FF; Enclosed CJK Letters and Months 3300..33FF; CJK Compatibility 3400..4DBF; CJK Unified Ideographs Extension A 4E00..9FFF; CJK Unified Ideographs A000..A48F; Yi Syllables A490..A4CF; Yi Radicals AC00..D7AF; Hangul Syllables D800..DB7F; High Surrogates DB80..DBFF; High Private Use Surrogates DC00..DFFF; Low Surrogates E000..F8FF; Private Use Area F900..FAFF; CJK Compatibility Ideographs FB00..FB4F; Alphabetic Presentation Forms FB50..FDFF; Arabic Presentation Forms-A FE00..FE0F; Variation Selectors FE20..FE2F; Combining Half Marks FE30..FE4F; CJK Compatibility Forms FE50..FE6F; Small Form Variants FE70..FEFF; Arabic Presentation Forms-B FF00..FFEF; Halfwidth and Fullwidth Forms FFF0..FFFF; Specials 10300..1032F; Old Italic 10330..1034F; Gothic 10400..1044F; Deseret 1D000..1D0FF; Byzantine Musical Symbols 1D100..1D1FF; Musical Symbols 1D400..1D7FF; Mathematical Alphanumeric Symbols 20000..2A6DF; CJK Unified Ideographs Extension B 2F800..2FA1F; CJK Compatibility Ideographs Supplement E0000..E007F; Tags F0000..FFFFF; Supplementary Private Use Area-A 100000..10FFFF; Supplementary Private Use Area-B "! Item was added: + ----- Method: Unicode class>>generalCategoryIndexFromTag: (in category 'character classification') ----- + generalCategoryIndexFromTag: tag + + ^ (self allCategoryTags indexOf: tag) - 1! Item was added: + ----- Method: Unicode class>>generalCategoryLabelForTag: (in category 'character classification') ----- + generalCategoryLabelForTag: tag + + ^ self generalCategoryLabels at: (self generalCategoryIndexFromTag: tag) + 1! Item was added: + ----- Method: Unicode class>>generalCategoryTagOf: (in category 'character classification') ----- + generalCategoryTagOf: aCharacterCode + + ^ (self generalCategoryOf: aCharacterCode) + ifNotNil: [:code | self allCategoryTags at: code + 1 ifAbsent: [#Cn]] + ifNil: [#Cn]! Item was changed: ----- Method: Unicode class>>initialize (in category 'class initialization') ----- initialize " Unicode initialize " self initializeTagConstants. + + self flag: #deduplicate. "Currently, we are downloading and parsing #unicodeData twice." + Compositions isEmptyOrNil ifTrue: [self initializeCompositionMappings]. + GeneralCategory isEmptyOrNil ifTrue: [self initializeUnicodeData].! - Compositions isEmptyOrNil ifTrue:[self initializeCompositionMappings].! Item was added: + ----- Method: Unicode class>>initializeUnicodeData (in category 'unicode data') ----- + initializeUnicodeData + "self initializeUnicodeData" + + self parseUnicodeDataFrom: self unicodeData readStream.! Item was changed: ----- Method: Unicode class>>parseUnicodeDataFrom: (in category 'unicode data') ----- parseUnicodeDataFrom: stream + "self initializeUnicodeData." - " - self halt. - self parseUnicodeDataFile - " + | line fieldEnd point fieldStart toNumber generalCategory decimalProperty tag | - | line fieldEnd point fieldStart toNumber generalCategory decimalProperty | toNumber := [:quad | ('16r', quad) asNumber]. + GeneralCategory := SparseLargeTable new: 16rE0080 chunkSize: 1024 arrayClass: Array base: 1 defaultValue: Cn. - GeneralCategory := SparseLargeTable new: 16rE0080 chunkSize: 1024 arrayClass: Array base: 1 defaultValue: 'Cn'. DecimalProperty := SparseLargeTable new: 16rE0080 chunkSize: 32 arrayClass: Array base: 1 defaultValue: -1. + GeneralCategory atAll: (16r3400 to: 16r4DB5) +1 put: Lo. + GeneralCategory atAll: (16r4E00 to: 16r9FA5) + 1 put: Lo. + GeneralCategory atAll: (16rAC00 to: 16rD7FF) + 1 put: Lo. - 16r3400 to: 16r4DB5 do: [:i | GeneralCategory at: i+1 put: 'Lo']. - 16r4E00 to: 16r9FA5 do: [:i | GeneralCategory at: i+1 put: 'Lo']. - 16rAC00 to: 16rD7FF do: [:i | GeneralCategory at: i+1 put: 'Lo']. [(line := stream nextLine) size > 0] whileTrue: [ fieldEnd := line indexOf: $; startingAt: 1. point := toNumber value: (line copyFrom: 1 to: fieldEnd - 1). point > 16rE007F ifTrue: [ GeneralCategory zapDefaultOnlyEntries. DecimalProperty zapDefaultOnlyEntries. ^ self]. 2 to: 3 do: [:i | fieldStart := fieldEnd + 1. fieldEnd := line indexOf: $; startingAt: fieldStart. ]. + tag := line copyFrom: fieldStart to: fieldEnd - 1. + generalCategory := self generalCategoryIndexFromTag: tag. - generalCategory := line copyFrom: fieldStart to: fieldEnd - 1. GeneralCategory at: point+1 put: generalCategory. + generalCategory = Nd ifTrue: [ - generalCategory = 'Nd' ifTrue: [ 4 to: 7 do: [:i | fieldStart := fieldEnd + 1. fieldEnd := line indexOf: $; startingAt: fieldStart. ]. decimalProperty := line copyFrom: fieldStart to: fieldEnd - 1. DecimalProperty at: point+1 put: decimalProperty asNumber. ]. ]. GeneralCategory zapDefaultOnlyEntries. + DecimalProperty zapDefaultOnlyEntries.! - DecimalProperty zapDefaultOnlyEntries. - ! Item was added: + ----- Method: Unicode class>>reinitializeData (in category 'class initialization') ----- + reinitializeData + + Compositions := GeneralCategory := nil. + self initialize.!

1 0

Review Request: openToolsInHandStrategy.1.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 04 Apr '22

04 Apr '22

=============== Summary =============== Change Set: openToolsInHandStrategy Date: 1 April 2022 Author: Christoph Thiede Revises preferences for opening tools in hand. Deprecates #openToolsAttachedToMouseCursor and replaces it with a new #openToolsInHandStrategy that can be set to #never, #always, or #clicks. The third mode preserves the behavior of the former preference, whereas the second mode is new and will open every tool in hand, independently on whether it was triggered via a mouse or keyboard interaction. This behavior has been requested by multiple Squeakers before. See: http://lists.squeakfoundation.org/pipermail/squeak-dev/2022-February/218981… Other changes in this patch: - Update the preference wizard morph to support all strategies. - Add commonly-used util #dontOpenToolsInHandDuring: on UIManager. - While installing updates, do not open the transcript in the hand any longer to improve readability. - Simplify SystemWindow>>#justDroppedInto:event:. !! Merger note: !! When merging interactionModes.cs, make sure to move the new logic from SystemWindow>>#openAsTool to UIManager>>#shouldOpenToolsInHandNow. =============== Postscript =============== PreferenceWizardMorph removeSelector: #toggleAttachToolsToMouse =============== Diff =============== BrowseTest>>withImmediatelyOpeningWindowsDo: {private} · ct 3/26/2022 20:34 (changed) withImmediatelyOpeningWindowsDo: aBlock "Turn off any preferences that defer to the user to open a window." - | openToolsAttachedToMouseCursor | - (UIManager default respondsTo: #openToolsAttachedToMouseCursor:) ifFalse: - [^aBlock value]. - openToolsAttachedToMouseCursor := UIManager default openToolsAttachedToMouseCursor. - UIManager default openToolsAttachedToMouseCursor: false. - ^aBlock ensure: - [UIManager default openToolsAttachedToMouseCursor: openToolsAttachedToMouseCursor] + ^ UIManager dontOpenToolsInHandDuring: aBlock MCMcmUpdater>>configureTranscript:during: {private} · ct 4/1/2022 15:26 + configureTranscript: interactive during: aBlock + + self flag: #hacked. "ct: Do not open transcript in hand to guarantee readability of update logs while the update is being performed. Otherwise, the transcript might stick at any corner of the display and cannot be moved before the update is completed." + ^ UIManager dontOpenToolsInHandDuring: [ + | ensureTranscriptSetting | + ensureTranscriptSetting := MCConfiguration ensureOpenTranscript. + MCConfiguration ensureOpenTranscript: interactive. + ^ aBlock ensure: + [MCConfiguration ensureOpenTranscript: ensureTranscriptSetting]] MCMcmUpdater>>doUpdate: {updating} · ct 4/1/2022 15:22 (changed) doUpdate: interactive "Update the image by loading all pending updates from the server. If this is the default updater for the system, update the system version when complete. If interteractive use a modal notifier, otherwise only update the transcript. Flush all caches. If a previous download failed this is often helpful" - | previousUpdateLevel ensureTranscriptSetting | + | previousUpdateLevel | previousUpdateLevel := SystemVersion current highestUpdate. MCFileBasedRepository flushAllCaches. - ensureTranscriptSetting := MCConfiguration ensureOpenTranscript. - [MCConfiguration ensureOpenTranscript: interactive. - self updateFromRepository - ifNil: - [interactive ifTrue: [ ^self inform: 'Unable to retrieve updates from remote repository.' translated ]. - Transcript cr; show: '========== Unable to retrieve updates from remote repository. ==========' translated; cr. - ^ self ] - ifNotNil: [:config| self logUpdateOf: config previousUpdateLevel: previousUpdateLevel interactive: interactive]] - ensure: - [MCConfiguration ensureOpenTranscript: ensureTranscriptSetting] + self configureTranscript: interactive during: + [self updateFromRepository + ifNil: + [interactive ifTrue: [ ^self inform: 'Unable to retrieve updates from remote repository.' translated ]. + Transcript cr; show: '========== Unable to retrieve updates from remote repository. ==========' translated; cr. + ^ self] + ifNotNil: [:config | self logUpdateOf: config previousUpdateLevel: previousUpdateLevel interactive: interactive]] PreferenceWizardMorph>>adjustSettingsForLowPerformance {support} · ct 3/26/2022 20:41 (changed) adjustSettingsForLowPerformance self updateLowPerformanceLabel: 'Please wait, optimizing performance...' translated. self refreshWorld. self stateGradients "flat look" ifFalse: [self toggleGradients]. self stateBlinkingCursor ifTrue: [self toggleBlinkingCursor]. self stateFastDrag ifFalse: [self toggleFastDrag]. self stateSoftShadows ifTrue: [self toggleSoftShadows]. self stateHardShadows ifTrue: [self toggleHardShadows]. self stateRoundedWindowLook ifTrue: [self toggleRoundedWindowLook]. self stateRoundedButtonLook ifTrue: [self toggleRoundedButtonLook]. - self stateAttachToolsToMouse ifTrue: [self toggleAttachToolsToMouse]. + self stateAttachToolsToMouseForClicks ifTrue: [self toggleAttachToolsToMouseForClicks]. + self stateAttachToolsToMouseAlways ifTrue: [self toggleAttachToolsToMouseAlways]. self stateToolAndMenuIcons ifTrue: [self toggleToolAndMenuIcons]. self stateSmartHorizontalSplitters ifTrue: [self toggleSmartHorizontalSplitters]. self stateSmartVerticalSplitters ifTrue: [self toggleSmartVerticalSplitters]. PluggableListMorph highlightHoveredRow: false; filterableLists: false; highlightPreSelection: true; "Feedback is important!" flashOnErrors: false. TheWorldMainDockingBar showSecondsInClock: false. Preferences disable: #balloonHelpInMessageLists. "Set simple background." self currentWorld setAsBackground: MorphicProject defaultFill. "Done." self updateLowPerformanceLabel: 'Settings were adjusted for optimal performance.' translated. PreferenceWizardMorph>>initializePage04InteractionMore {initialization - pages} · ct 3/26/2022 20:38 (changed) initializePage04InteractionMore | currentPage pane | currentPage := pages add: self createPage. pane := self createScrollPane. currentPage addMorphBack: (self createLabel: 'Choose more interaction settings' color: Color white). currentPage addMorphBack: pane. pane scroller firstSubmorph addAllMorphsBack: { self createCheckbox: 'Windows raise on click' translated for: #WindowsRaiseOnClick help: #(window raise). self createCheckbox: 'Windows always active' for: #WindowsAlwaysActive help: #(window content active). self createCheckbox: 'Window buttons always active' translated for: #WindowButtonsAlwaysActive help: #(window control active). self createVerticalSpace. self createCheckbox: 'Smart horizontal splitters' translated for: #SmartHorizontalSplitters help: #(horizontal splitter). self createCheckbox: 'Smart vertical splitters' translated for: #SmartVerticalSplitters help: #(vertical splitter). self createVerticalSpace. self createCheckbox: 'Filterable lists and trees' translated for: #FilterableLists help: 'Type something to filter lists. Press [return] to clear the filter. Press [backspace] to clear and restore prior selection.' translated. self createCheckbox: 'Filters clear if unfocused' translated for: #ClearFilterAutomatically help: #(filter clear). self createVerticalSpace. - self createCheckbox: 'Attach tools to mouse' translated for: #AttachToolsToMouse help: #(tools attach). + self createCheckbox: 'Attach tools to mouse - for clicks' translated for: #AttachToolsToMouseForClicks help: #(tools attach). + self createCheckbox: 'Attach tools to mouse - always' translated for: #AttachToolsToMouseAlways help: #(tools attach). }. PreferenceWizardMorph>>stateAttachToolsToMouseAlways {actions - buttons} · ct 3/26/2022 20:40 + stateAttachToolsToMouseAlways + + ^ UIManager openToolsInHandAlways PreferenceWizardMorph>>stateAttachToolsToMouseForClicks {actions - buttons} · ct 3/26/2022 20:40 + stateAttachToolsToMouseForClicks + + ^ UIManager openToolsInHandForClicks PreferenceWizardMorph>>toggleAttachToolsToMouseAlways {actions - buttons} · ct 3/26/2022 20:44 + toggleAttachToolsToMouseAlways + + UIManager openToolsInHandAlways: UIManager openToolsInHandAlways not. + self changed: #stateAttachToolsToMouseAlways. + self changed: #stateAttachToolsToMouseForClicks. PreferenceWizardMorph>>toggleAttachToolsToMouseForClicks {actions - buttons} · ct 3/26/2022 20:44 + toggleAttachToolsToMouseForClicks + + UIManager openToolsInHandForClicks: UIManager openToolsInHandForClicks not. + self changed: #stateAttachToolsToMouseAlways. + self changed: #stateAttachToolsToMouseForClicks. ReleaseBuilder class>>setPreferences {scripts} · ct 3/26/2022 20:35 (changed) setPreferences "Preferences class defaultValueTableForCurrentRelease" " Preferences outOfTheBox." "<-- uncomment after #defaultValueTableForCurrentRelease is fixed up." "General User interaction" Preferences enable: #generalizedYellowButtonMenu ; enable: #swapMouseButtons; disable: #mouseOverForKeyboardFocus. Morph indicateKeyboardFocus: true. - Project uiManager openToolsAttachedToMouseCursor: false. + Project uiManager openToolsInHandStrategy: #never. SearchBar useScratchPad: false. HandMorph sendMouseWheelToKeyboardFocus: false. HandMorph synthesizeMouseWheelEvents: true. "Text input." TextEditor autoEnclose: true ; autoIndent: true ; encloseSelection: true ; destructiveBackWord: false ; blinkingCursor: true ; dumbbellCursor: false. PluggableTextMorph simpleFrameAdornments: false. TextMorphForEditView draggableTextSelection: true. "Windows" SystemWindow reuseWindows: false. SystemWindow windowsRaiseOnClick: true. SystemWindow windowTitleActiveOnFirstClick: true. Model windowActiveOnFirstClick: false. "Not good for little screen real estate." Model useColorfulWindows: false. Preferences disable: #fastDragWindowForMorphic. AbstractResizerMorph gripThickness: 4; handleLength: 16. CornerGripMorph drawCornerResizeHandles: false; drawEdgeResizeHandles: false. ProportionalSplitterMorph showSplitterHandles: false; smartHorizontalSplitters: false; smartVerticalSplitters: false. "Scroll bars." Preferences enable: #scrollBarsNarrow; enable: #scrollBarsOnRight; enable: #alwaysHideHScrollbar; disable: #alwaysShowHScrollbar; disable: #alwaysShowVScrollbar. ScrollBar scrollBarsWithoutArrowButtons: true; scrollBarsWithoutMenuButton: true. ScrollPane useRetractableScrollBars: false. "Rounded corners." Morph preferredCornerRadius: 8. SystemWindow roundedWindowCorners: false. DialogWindow roundedDialogCorners: false. MenuMorph roundedMenuCorners: false. PluggableButtonMorph roundedButtonCorners: false. ScrollBar roundedScrollBarLook: false. "Gradients." SystemWindow gradientWindow: false. DialogWindow gradientDialog: false. MenuMorph gradientMenu: false. PluggableButtonMorph gradientButton: false. ScrollBar gradientScrollBar: false. "Shadows" Preferences enable: #menuAppearance3d. Morph useSoftDropShadow: true. "Lists and Trees" PluggableListMorph filterableLists: true; clearFilterAutomatically: false; clearFilterDelay: 500; highlightHoveredRow: true; highlightPreSelection: false; menuRequestUpdatesSelection: true. PluggableTreeMorph filterByLabelsOnly: false; maximumSearchDepth: 1. "Standard Tools" TheWorldMainDockingBar showWorldMainDockingBar: true; showSecondsInClock: true; twentyFourHourClock: true. SearchBar useSmartSearch: true. Workspace shouldStyle: false. TranscriptStream forceUpdate: true; redirectToStdOut: false; characterLimit: 20000. Browser listClassesHierarchically: true; showClassIcons: true; showMessageIcons: true; sortMessageCategoriesAlphabetically: true. SystemBrowser browseWithDragNDrop: true. MessageSet useUnifiedMessageLabels: true. Preferences enable: #annotationPanes; defaultAnnotationRequests: #(timeStamp author messageCategory implementorsCount allChangeSets); enable: #optionalButtons; disable: #diffsWithPrettyPrint; enable: #traceMessages; enable: #alternativeBrowseIt; enable: #menuWithIcons; enable: #visualExplorer; disable: #showSharedFlaps; maxBalloonHelpLineLength: 45. Preferences disable: #debugLogTimestamp. "Halo" Preferences enable: #showBoundsInHalo ; disable: #alternateHandlesLook; disable: #showDirectionHandles; enable: #biggerHandles. Morph haloForAll: true; metaMenuForAll: true. "System" NetNameResolver enableIPv6: false. Scanner allowUnderscoreAsAssignment: true; prefAllowUnderscoreSelectors: true. Deprecation showDeprecationWarnings: true "that's all, folks" SystemWindow>>justDroppedInto:event: {geometry} · ct 3/26/2022 20:09 (changed) justDroppedInto: aMorph event: anEvent isCollapsed ifTrue: [self position: ((self position max: 0@0) grid: 8@8). collapsedFrame := self bounds] ifFalse: [fullFrame := self bounds]. self beKeyWindow. self hasDropShadow: Preferences menuAppearance3d. "See #startDragFromLabel:." aMorph == self world ifTrue: [self assureLabelAreaVisible]. - (Project uiManager openToolsAttachedToMouseCursor and: (self hasProperty: #initialDrop)) - ifTrue: [ - self removeProperty: #initialDrop. + (self removeProperty: #initialDrop) + ifNotNil: [ (self submorphs detect: [:m | m isKindOf: BottomRightGripMorph] ifNone: []) ifNotNil: [:grip | grip referencePoint: anEvent position - grip position; backupAndHideTargetDropShadows. "See MorphicToolBuilder >> #open:" self lookFocused. anEvent hand newMouseFocus: grip]]. ^super justDroppedInto: aMorph event: anEvent SystemWindow>>openAsTool {*ToolBuilder-Morphic-opening} · ct 4/1/2022 15:34 (changed) openAsTool "Open this window as a tool, that is, honor the preferences such as #reuseWindows and #openToolsAttachedToMouseCursor." - + | meOrSimilarWindow | meOrSimilarWindow := self openInWorldExtent: self extent. - (Project uiManager openToolsAttachedToMouseCursor "and: [ | event | - event := self currentEvent. - event isMouse and: [event isMouseUp]]") ifTrue: [ + Project uiManager shouldOpenToolsInHandNow ifTrue: [ meOrSimilarWindow setProperty: #initialDrop toValue: true. meOrSimilarWindow hasDropShadow: false. self currentHand attachMorph: meOrSimilarWindow]. ^ meOrSimilarWindow UIManager class>>dontOpenToolsInHandDuring: {support} · ct 3/26/2022 20:46 + dontOpenToolsInHandDuring: aBlock + "Utility for various UI test/automation code." + + | oldStrategy | + oldStrategy := self openToolsInHandStrategy. + self openToolsInHandStrategy: #never. + ^ aBlock ensure: [self openToolsInHandStrategy: oldStrategy] UIManager class>>openToolsAttachedToMouseCursor {*60Deprecated-preferences} · ct 4/1/2022 15:40 (changed and recategorized) openToolsAttachedToMouseCursor - <preference: 'Open Tools Attached to Mouse Cursor' - categoryList: #(Tools mouse) - description: 'If enabled, new tool windows will be attached to the mouse cursor to be positioned on screen with an additional click-drag. Only occurs if a mouse event triggered that tool opening to not interfere with keyboard-based interaction.' - type: #Boolean> - ^ OpenToolsAttachedToMouseCursor ifNil: [false] + self deprecated. + ^ self openToolsInHandStrategy ~= #never UIManager class>>openToolsAttachedToMouseCursor: {*60Deprecated-preferences} · ct 3/26/2022 20:30 (changed and recategorized) openToolsAttachedToMouseCursor: aBoolean - OpenToolsAttachedToMouseCursor := aBoolean. + self deprecated. + self openToolsInHandForClicks: aBoolean. UIManager class>>openToolsInHandAlways {preferences} · ct 3/26/2022 20:25 + openToolsInHandAlways + + <preference: 'Open Tools Attached to Mouse Cursor - Always' + categoryList: #(Tools mouse) + description: 'If enabled, new tool windows will be attached to the mouse cursor, allowing users to position and resize them with a single click-drag gesture. NOTE: This mode activates the gesture always, even if the tool was opened via keyboard-based interaction.' + type: #Boolean> + ^ self openToolsInHandStrategy = #always UIManager class>>openToolsInHandAlways: {preferences} · ct 3/26/2022 20:29 + openToolsInHandAlways: aBoolean + + self openToolsInHandStrategy: + (aBoolean ifTrue: [#always] ifFalse: [#never]). UIManager class>>openToolsInHandForClicks {preferences} · ct 3/26/2022 20:25 + openToolsInHandForClicks + + <preference: 'Open Tools Attached to Mouse Cursor - for Clicks' + categoryList: #(Tools mouse) + description: 'If enabled, new tool windows will be attached to the mouse cursor, allowing users to position and resize them with a single click-drag gesture. NOTE: Only occurs if the tool was opened via a click; keyboard-based interactions remain unaffected.' + type: #Boolean> + ^ self openToolsInHandStrategy = #clicks UIManager class>>openToolsInHandForClicks: {preferences} · ct 3/26/2022 20:28 + openToolsInHandForClicks: aBoolean + + self openToolsInHandStrategy: + (aBoolean ifTrue: [#clicks] ifFalse: [#never]). UIManager class>>openToolsInHandStrategy {preferences} · ct 3/26/2022 20:32 + openToolsInHandStrategy + + self flag: #todo. "Once we have 'enumValues'-style preferences, merge #openToolsInHandAlways and #openToolsInHandForClicks here." + ^ OpenToolsInHandStrategy ifNil: [#never] UIManager class>>openToolsInHandStrategy: {preferences} · ct 3/26/2022 20:15 + openToolsInHandStrategy: aSymbol + + self assert: (#(always clicks never) includes: aSymbol). + OpenToolsInHandStrategy := aSymbol. UIManager>>openToolsAttachedToMouseCursor {*60Deprecated-accessing} · ct 4/1/2022 15:39 (changed and recategorized) openToolsAttachedToMouseCursor - self flag: #todo. "mt: Let each instances of ui manager have its own setting." + + self deprecated. ^ self class openToolsAttachedToMouseCursor UIManager>>openToolsAttachedToMouseCursor: {*60Deprecated-accessing} · ct 3/26/2022 20:35 (changed and recategorized) openToolsAttachedToMouseCursor: aBoolean - self flag: #todo. "mt: Let each instances of ui manager have its own setting." - self class openToolsAttachedToMouseCursor: aBoolean. + + self deprecated. + ^ self class openToolsAttachedToMouseCursor: aBoolean UIManager>>openToolsInHandStrategy {accessing} · ct 4/1/2022 15:44 + openToolsInHandStrategy + + self flag: #discuss. "Should each instance have its own setting?" + ^ self class openToolsInHandStrategy UIManager>>openToolsInHandStrategy: {accessing} · ct 3/26/2022 20:19 + openToolsInHandStrategy: aBoolean + + self class openToolsInHandStrategy: aBoolean. UIManager>>shouldOpenToolsInHandNow {accessing} · ct 4/1/2022 15:43 + shouldOpenToolsInHandNow + + ^ self openToolsInHandStrategy caseOf: + {[#never] -> [false]. + [#clicks] -> [ + | event | + self flag: '<<<<<<<<< workingCopy'. "ct: When merging interactionMode.cs, paste new logic from #openAsTool here!" + event := self currentEvent. + event isMouse or: [event isDropEvent]]. + [#always] -> [true]} ["openToolsInHandStrategy.1.cs"] --- Sent from Squeak Inbox Talk ["openToolsInHandStrategy.1.cs"]

2 3

Jump to page: