Squeak-dev November 2022

squeak-dev@lists.squeakfoundation.org

24 participants
94 discussions

The Trunk: Morphic-mt.2053.mcz
by commits＠source.squeak.org 21 Nov '22

21 Nov '22

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.2053.mcz ==================== Summary ==================== Name: Morphic-mt.2053 Author: mt Time: 21 November 2022, 11:26:08.284072 am UUID: e5103676-4f14-f245-8dee-e81e3f692664 Ancestors: Morphic-ct.2052 More commentary for mouse and keyboard events. =============== Diff against Morphic-ct.2052 =============== Item was changed: ----- Method: Morph>>handleKeyDown: (in category 'events-processing') ----- handleKeyDown: anEvent + "System level event handling. AVOID OVERRIDE if possible. Instead, please use #handlesKeyboard: and #keyDown: in your custom morphs." + - "System level event handling." anEvent wasHandled ifTrue: [^ self]. (self handlesKeyboard: anEvent) ifFalse: [^ self]. (anEvent hand keyboardFocus ~~ self and: [self handlesKeyboardOnlyOnFocus]) ifTrue: [^ self]. anEvent wasHandled: true. ^ self keyDown: anEvent! Item was changed: ----- Method: Morph>>handleKeyUp: (in category 'events-processing') ----- handleKeyUp: anEvent + "System level event handling. AVOID OVERRIDE if possible. Instead, please use #handlesKeyboard: and #keyUp: in your custom morphs." + - "System level event handling." anEvent wasHandled ifTrue: [^ self]. (self handlesKeyboard: anEvent) ifFalse: [^ self]. (anEvent hand keyboardFocus ~~ self and: [self handlesKeyboardOnlyOnFocus]) ifTrue: [^ self]. anEvent wasHandled: true. ^ self keyUp: anEvent! Item was changed: ----- Method: Morph>>handleKeystroke: (in category 'events-processing') ----- handleKeystroke: anEvent + "System level event handling. Supports automatically grabbing the keyboard focus via keyboard focus delegate; see #newKeyboardFocus:. - "System level event handling. Has support for automatically grabbing the keyboard focus considering the keyboard focus delegate. See #newKeyboardFocus:" + AVOID OVERRIDE if possible. Instead, please use #handlesKeyboard: and #keyStroke: in your custom morphs." + | handler | anEvent wasHandled ifTrue: [^ self]. (self handlesKeyboard: anEvent) ifFalse: [^ self]. (anEvent hand keyboardFocus ~~ self and: [self handlesKeyboardOnlyOnFocus]) ifTrue: [^ self]. handler := self wantsKeyboardFocus ifFalse: [self] ifTrue: [(anEvent hand newKeyboardFocus: self) ifNil: [self]]. anEvent handler: handler. anEvent wasHandled: true. ^ handler keyStroke: anEvent! Item was changed: ----- Method: Morph>>handleMouseDown: (in category 'events-processing') ----- handleMouseDown: anEvent + "System level event handling. AVOID OVERRIDE if possible. Instead, please use #handlesMouseDown: and #mouseDown: in your custom morphs. See #handlerForMouseDown: and #mouseDownPriority." + - "System level event handling." anEvent wasHandled ifTrue:[^self]. "not interested" anEvent hand removePendingBalloonFor: self. anEvent hand removePendingHaloFor: self. anEvent wasHandled: true. "Make me modal during mouse transitions" anEvent hand newMouseFocus: self event: anEvent. "this mouse down could be the start of a gesture, or the end of a gesture focus" (self isGestureStart: anEvent) ifTrue: [^ self gestureStart: anEvent]. self mouseDown: anEvent. (self handlesMouseStillDown: anEvent) ifTrue:[ self startStepping: #handleMouseStillDown: at: Time millisecondClockValue + self mouseStillDownThreshold arguments: {anEvent copy resetHandlerFields} stepTime: self mouseStillDownStepRate ]. ! Item was changed: ----- Method: Morph>>handleMouseEnter: (in category 'events-processing') ----- handleMouseEnter: anEvent + "System level event handling. AVOID OVERRIDE if possible. Instead, please use #handlesMouseOver: and #mouseEnter: in your custom morphs. Also see/use #handlesMouseOverDragging: and #mouseEnterDragging:." + - "System level event handling." (anEvent isDraggingEvent) ifTrue:[ (self handlesMouseOverDragging: anEvent) ifTrue:[ anEvent wasHandled: true. self mouseEnterDragging: anEvent]. ^self]. self wantsHalo "If receiver wants halo and balloon, trigger balloon after halo" ifTrue:[anEvent hand triggerHaloFor: self after: self haloDelayTime] ifFalse:[self wantsBalloon ifTrue:[anEvent hand triggerBalloonFor: self after: self balloonHelpDelayTime]]. (self handlesMouseOver: anEvent) ifTrue:[ anEvent wasHandled: true. self mouseEnter: anEvent. ].! Item was changed: ----- Method: Morph>>handleMouseLeave: (in category 'events-processing') ----- handleMouseLeave: anEvent + "System level event handling. AVOID OVERRIDE if possible. Instead, please use #handlesMouseOver: and #mouseLeave: in your custom morphs. Also see/use #handlesMouseOverDragging: and #mouseLeaveDragging:." + - "System level event handling." anEvent hand removePendingBalloonFor: self. anEvent hand removePendingHaloFor: self. anEvent isDraggingEvent ifTrue:[ (self handlesMouseOverDragging: anEvent) ifTrue:[ anEvent wasHandled: true. self mouseLeaveDragging: anEvent]. ^self]. (self handlesMouseOver: anEvent) ifTrue:[ anEvent wasHandled: true. self mouseLeave: anEvent. ]. ! Item was changed: ----- Method: Morph>>handleMouseMove: (in category 'events-processing') ----- handleMouseMove: anEvent + "System level event handling. AVOID OVERRIDE if possible. Instead, please use #handlesMouseMove: and #mouseMove: in your custom morphs. Also see/use #wantsEveryMouseMove." + - "System level event handling." anEvent wasHandled ifTrue: [ ^ self ]. "not interested" (self handlesMouseMove: anEvent) ifFalse: [ ^ self ]. anEvent wasHandled: true. self mouseMove: anEvent. (self handlesMouseStillDown: anEvent) ifTrue: [ "Step at the new location" self startStepping: #handleMouseStillDown: at: Time millisecondClockValue arguments: {anEvent copy resetHandlerFields} stepTime: self mouseStillDownStepRate ]! Item was changed: ----- Method: Morph>>handleMouseOver: (in category 'events-processing') ----- handleMouseOver: anEvent + "System level event handling. DO NOT OVERRIDE. See #handleMouseMove:, #handleMouseEnter:, #handleMouseLeave:." + - "System level event handling." anEvent hand mouseFocus == self ifTrue:[ "Got this directly through #handleFocusEvent: so check explicitly" (self containsPoint: anEvent position event: anEvent) ifFalse:[^self]]. anEvent hand noticeMouseOver: self event: anEvent! Item was changed: ----- Method: Morph>>handleMouseUp: (in category 'events-processing') ----- handleMouseUp: anEvent + "System level event handling. Complements #handleMouseDown: (and #mouseDown:). AVOID OVERRIDE if possible. Instead, please use #handlesMouseDown: and #mouseUp: in your custom morphs. See #handlerForMouseDown: and #mouseDownPriority." + - "System level event handling." anEvent wasHandled ifTrue:[^self]. "not interested" anEvent hand mouseFocus == self ifFalse:[^self]. "Not interested in other parties" anEvent hand releaseMouseFocus: self. anEvent wasHandled: true. self mouseUp: anEvent. self stopSteppingSelector: #handleMouseStillDown:.! Item was changed: ----- Method: Morph>>handleMouseWheel: (in category 'events-processing') ----- handleMouseWheel: anEvent + "System level event handling. AVOID OVERRIDE if possible. Instead, please use #handlesMouseWheel: and #mouseWheel: in your custom morphs." - "System level event handling." anEvent wasHandled ifTrue: [^self]. (self handlesMouseWheel: anEvent) ifFalse: [^ self]. anEvent wasHandled: true. ^ self mouseWheel: anEvent! Item was changed: ----- Method: Morph>>keyDown: (in category 'event handling') ----- keyDown: anEvent + "Handle a key down event. The default response is to let my eventHandler, if any, handle it. Ask anEvent for #key to work with a cross-platform representation of virtual-key presses. DO NOT access #keyValue or #keyCharacter as those are for #keyStroke: only. + + For #virtualModifiers, ask for #shiftPressed, #controlKeyPressed, #optionKeyPressed, or #commandKeyPressed. Note that if you want to SHOW platform-specific information about modifiers (e.g., ALT on Windows), see #physicalModifiers. For control-flow expressions (e.g., #ifTrue:), only use #virtualModifiers to remain cross-platform compatible." - "Handle a key down event. The default response is to let my eventHandler, if any, handle it." self eventHandler ifNotNil: [self eventHandler keyDown: anEvent fromMorph: self]. ! Item was changed: ----- Method: Morph>>keyStroke: (in category 'event handling') ----- keyStroke: anEvent + "Handle a keystroke event. The default response is to let my eventHandler, if any, handle it. Ask anEvent for #keyCharacter to work with the (Unicode) character the user entered. See class comment in Character. + + Please implement keyboard shortcuts via #keyDown: instead. Here, as in #keyDown: and #keyUp, you may ask anEvent for #key but should do that in #keyDown: or #keyUp: if possible. + + Please AVOID checking #modifiers (or #virtualModifiers) in combination with #keyCharacter as, for example, #shiftPressed has an effect on #keyCharacter as well. This is not the case for #key (or #virtualKey)." - "Handle a keystroke event. The default response is to let my eventHandler, if any, handle it." self eventHandler ifNotNil: [self eventHandler keyStroke: anEvent fromMorph: self]. ! Item was changed: ----- Method: Morph>>keyUp: (in category 'event handling') ----- keyUp: anEvent + "Handle a key up event. The default response is to let my eventHandler, if any, handle it. Ask anEvent for #key to work with a cross-platform representation of virtual-key releases. DO NOT access #keyValue or #keyCharacter as those are for #keyStroke: only. + + For #virtualModifiers, ask for #shiftPressed, #controlKeyPressed, #optionKeyPressed, or #commandKeyPressed. Note that if you want to SHOW platform-specific information about modifiers (e.g., ALT on Windows), see #physicalModifiers. For control-flow expressions (e.g., #ifTrue:), only use #virtualModifiers to remain cross-platform compatible." - "Handle a key up event. The default response is to let my eventHandler, if any, handle it." self eventHandler ifNotNil: [self eventHandler keyUp: anEvent fromMorph: self]. !

1 0

The Trunk: EToys-ct.486.mcz
by commits＠source.squeak.org 19 Nov '22

19 Nov '22

Christoph Thiede uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-ct.486.mcz ==================== Summary ==================== Name: EToys-ct.486 Author: ct Time: 19 November 2022, 7:04:16.24343 pm UUID: 7824dd20-441e-3342-a4bf-18f7463f6c65 Ancestors: EToys-ct.485 Makes WatchMorph scale-factor-aware. =============== Diff against EToys-ct.485 =============== Item was changed: ----- Method: WatchMorph>>initialize (in category 'initialization') ----- initialize "initialize the state of the receiver" super initialize. "" self handsColor: Color red. self centerColor: Color gray. romanNumerals := false. antialias := false. fontName := 'NewYork'. + self extent: 130 px @ 130 px. - self extent: 130 @ 130. self start!

1 0

Windows mapping from CF_UNICODE to Unicode
by Eliot Miranda 18 Nov '22

18 Nov '22

Hi All, does anyone know how Windows maps Unicode text to the CF_UNICODE format used in the clipboard? It seems to me that CF_UNICODE might simply be two-byte characters, excluding any codes beyond 16rFFFF. Is it in fact UTF-16? If it is UTF-16 has anyone fixed our UTF16TextConverter? I don't see any of the conveniences that exist for the UTF8TextConverter such as decodeString: etc. _,,,^..^,,,_ best, Eliot

2 1

Fwd: Posits [circular mapping between real numbers and the repressntation]
by Eliot Miranda 14 Nov '22

14 Nov '22

It would be nice to have these alongside Float. Perhaps with a 128 bit representation… Begin forwarded message: > From: Annick Fron <annick.fron(a)afceurope.com> > Date: November 9, 2022 at 1:14:46 AM PST > To: vwnc NC <vwnc(a)cs.uiuc.edu> > Subject: [vwnc] Posits > Reply-To: Annick Fron <annick.fron(a)afceurope.com> > > Hi, > > Does anybody know about posits ? > > https://www.cs.cornell.edu/courses/cs6120/2019fa/blog/posits/ > > Best regards > > Annick Eliot _,,,^..^,,,_ (phone)

6 11

OH NO!!! .morph format change?
by Jim Rosenberg 11 Nov '22

11 Nov '22

Oh dear. Big trouble. I use Squeak for artistic work, and rely crucially on .morph files to preserve my content. (Since you changed the format at one point for projects and didn't provide a way to convert, ahem ahem ahem ...) I have a morph saved under Squeak 4.3 and am trying to load it into Squeak 6.0. I am getting an error from SmartRefStream>>verifyStructure that there is a missing key, #DisplayObject. HELP!!! How do I convert .morph files to the format used by 6.0??? PLEASE PLEASE PLEASE!!!: When you guys change a format like this, please give a thought to us content developers. -Thanks in advance, Jim

2 2

The Trunk: KernelTests-ct.374.mcz
by commits＠source.squeak.org 07 Nov '22

07 Nov '22

Christoph Thiede uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-ct.374.mcz ==================== Summary ==================== Name: KernelTests-ct.374 Author: ct Time: 9 January 2020, 3:45:07.818555 pm UUID: a7466380-609b-8146-b983-af77736d55f0 Ancestors: KernelTests-nice.373 Tests #haltOnce and #haltOnceIf:. Refactors tests for #haltIf:. Complements Kernel-ct.1294. =============== Diff against KernelTests-nice.373 =============== Item was added: + ----- Method: ObjectTest>>resetHaltOnceAfter: (in category 'running') ----- + resetHaltOnceAfter: aBlock + + | outerState | + outerState := self haltOnceEnabled. + ^ aBlock ensure: [ + outerState + ifTrue: [self setHaltOnce] + ifFalse: [self clearHaltOnce] ]! Item was added: + ----- Method: ObjectTest>>shouldHalt: (in category 'asserting') ----- + shouldHalt: aBlock + + ^ self + should: aBlock + raise: Halt! Item was added: + ----- Method: ObjectTest>>shouldntHalt: (in category 'asserting') ----- + shouldntHalt: aBlock + + ^ self + shouldnt: aBlock + raise: Halt! Item was changed: + ----- Method: ObjectTest>>testHaltIf (in category 'tests - debugging') ----- - ----- Method: ObjectTest>>testHaltIf (in category 'tests - testing') ----- testHaltIf + self shouldHalt: [self haltIf: true]. + self shouldntHalt: [self haltIf: false]. - self should: [self haltIf: true] raise: Halt. - self haltIf: false. + self shouldHalt: [self haltIf: [true]]. + self shouldntHalt: [self haltIf: [false]]. - self should: [self haltIf: [true]] raise: Halt. - self haltIf: [false]. + self shouldHalt: [self haltIf: #testHaltIf]. + self shouldntHalt: [self haltIf: #teadfasdfltIf]. - self should: [self haltIf: #testHaltIf.] raise: Halt. - self haltIf: #teadfasdfltIf. + self shouldHalt: [self a]. + self shouldntHalt: [self a1]. - self should: [self a] raise: Halt. - self a1. + self shouldHalt: [self haltIf: [:o | o class = self class]]. + self shouldntHalt: [self haltIf: [:o | o class ~= self class]]. - self should: [self haltIf: [:o | o class = self class]] raise: Halt. - self haltIf: [:o | o class ~= self class]. ! Item was added: + ----- Method: ObjectTest>>testHaltOnce (in category 'tests - debugging') ----- + testHaltOnce + + self resetHaltOnceAfter: [ + self setHaltOnce. + self assert: [self haltOnceEnabled]. + self shouldHalt: [self haltOnce]. + self deny: [self haltOnceEnabled]. + self shouldntHalt: [self haltOnce]. + + self setHaltOnce. + self assert: [self haltOnceEnabled]. + self clearHaltOnce. + self deny: [self haltOnceEnabled]. + self shouldntHalt: [self haltOnce]].! Item was added: + ----- Method: ObjectTest>>testHaltOnceIf (in category 'tests - debugging') ----- + testHaltOnceIf + + self resetHaltOnceAfter: [ + | requested | + self setHaltOnce. + self shouldHalt: [self haltOnceIf: true]. + self shouldntHalt: [self haltOnceIf: true]. + + self setHaltOnce. + self shouldntHalt: [self haltOnceIf: false]. + self assert: [self haltOnceEnabled]. + + self setHaltOnce. + requested := false. + self shouldHalt: [self haltOnceIf: [requested := true]]. + self assert: requested. + requested := false. + self shouldntHalt: [self haltOnceIf: [requested := true]]. + self deny: requested. + + self setHaltOnce. + requested := false. + self shouldntHalt: [self haltOnceIf: [(requested := true) not]]. + self assert: [self haltOnceEnabled]. + self assert: requested. + requested := false. + self shouldntHalt: [self haltOnceIf: [(requested := true) not]]. + self assert: [self haltOnceEnabled]. + self assert: requested].! Item was changed: + ----- Method: ObjectTest>>testNotNil (in category 'tests - debugging') ----- - ----- Method: ObjectTest>>testNotNil (in category 'tests - testing') ----- testNotNil self assert: Object new notNil!

1 0

The Trunk: Kernel-ct.1294.mcz
by commits＠source.squeak.org 07 Nov '22

07 Nov '22

Christoph Thiede uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-ct.1294.mcz ==================== Summary ==================== Name: Kernel-ct.1294 Author: ct Time: 9 January 2020, 3:42:36.672555 pm UUID: 7409dcc3-160e-9d44-9712-f266e0f25973 Ancestors: Kernel-nice.1292 Proposal: Add #haltOnceIf: to Object, which combines the strengths of #haltOnce and #haltIf:. Especially useful in performance-critical situations: It HaltOnce is disabled, the condition will not be evaluated at all. =============== Diff against Kernel-nice.1292 =============== Item was changed: ----- Method: Object>>haltIf: (in category 'debugging') ----- + haltIf: aCondition + "This is the typical message to use for inserting breakpoints during debugging. Param can be a block or expression, halt if true. - haltIf: condition - "This is the typical message to use for inserting breakpoints during - debugging. Param can be a block or expression, halt if true. If the Block has one arg, the receiver is bound to that. + If the condition is a selector, we look up in the callchain. Halt if any method's selector equals selector." - If the condition is a selector, we look up in the callchain. Halt if - any method's selector equals selector." - | cntxt | + ^ (self meetsHaltCondition: aCondition) + ifTrue: [self halt]! - condition isSymbol ifTrue:[ - "only halt if a method with selector symbol is in callchain" - cntxt := thisContext. - [cntxt sender isNil] whileFalse: [ - cntxt := cntxt sender. - (cntxt selector = condition) ifTrue: [Halt signal]. - ]. - ^self. - ]. - (condition isBlock - ifTrue: [condition cull: self] - ifFalse: [condition] - ) ifTrue: [ - Halt signal - ].! Item was added: + ----- Method: Object>>haltOnceIf: (in category 'debugging') ----- + haltOnceIf: aCondition + "Check aCondition and halt, unless we have already done it once. See #meetsHaltCondition:." + + self haltOnceEnabled ifFalse: [^ self]. + ^ (self meetsHaltCondition: aCondition) + ifTrue: [ + self clearHaltOnce; halt].! Item was added: + ----- Method: Object>>meetsHaltCondition: (in category 'debugging') ----- + meetsHaltCondition: aCondition + "If the Block has one arg, the receiver is bound to that. + If the condition is a selector, we look up in the callchain. Halt if any method's selector equals selector." + + aCondition isSymbol ifTrue: [ | ctxt | + "only halt if a method with selector symbol is in callchain" + ctxt := thisContext. + [(ctxt := ctxt sender) isNil] whileFalse: [ + (ctxt selector = aCondition) ifTrue: [^ true] ]. + ^ false ]. + ^ aCondition isBlock + ifTrue: [aCondition cull: self] + ifFalse: [aCondition value]!

1 0

The Trunk: KernelTests-ct.437.mcz
by commits＠source.squeak.org 07 Nov '22

07 Nov '22

Christoph Thiede uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-ct.437.mcz ==================== Summary ==================== Name: KernelTests-ct.437 Author: ct Time: 7 November 2022, 8:51:49.281226 pm UUID: fc0ce7a3-e562-e741-a923-d825e2ff3b4e Ancestors: KernelTests-jar.436, KernelTests-ct.374 Merges KernelTests-ct.374: Tests #haltOnce and #haltOnceIf:. Refactors tests for #haltIf:. Complements Kernel-ct.1294. Revision: Minor refactoring. =============== Diff against KernelTests-jar.436 =============== Item was added: + ----- Method: ObjectTest>>resetHaltOnceAfter: (in category 'running') ----- + resetHaltOnceAfter: aBlock + + | outerState | + outerState := self haltOnceEnabled. + ^ aBlock ensure: [ + outerState + ifTrue: [self setHaltOnce] + ifFalse: [self clearHaltOnce] ]! Item was added: + ----- Method: ObjectTest>>shouldHalt: (in category 'asserting') ----- + shouldHalt: aBlock + + ^ self + should: aBlock + raise: Halt! Item was added: + ----- Method: ObjectTest>>shouldntHalt: (in category 'asserting') ----- + shouldntHalt: aBlock + + ^ self + shouldnt: aBlock + raise: Halt! Item was changed: + ----- Method: ObjectTest>>testHaltIf (in category 'tests - debugging') ----- - ----- Method: ObjectTest>>testHaltIf (in category 'tests - testing') ----- testHaltIf + self shouldHalt: [self haltIf: true]. + self shouldntHalt: [self haltIf: false]. + + self shouldHalt: [self haltIf: [true]]. + self shouldntHalt: [self haltIf: [false]]. + + self shouldHalt: [self haltIf: #testHaltIf]. + self shouldntHalt: [self haltIf: #teadfasdfltIf]. + + self shouldHalt: [self a]. + self shouldntHalt: [self a1]. + + self shouldHalt: [self haltIf: [:o | o class = self class]]. + self shouldntHalt: [self haltIf: [:o | o class ~= self class]].! - self should: [self haltIf: true] raise: Halt. - self haltIf: false. - - self should: [self haltIf: [true]] raise: Halt. - self haltIf: [false]. - - self should: [self haltIf: #testHaltIf.] raise: Halt. - self haltIf: #teadfasdfltIf. - - self should: [self a] raise: Halt. - self a1. - - self should: [self haltIf: [:o | o class = self class]] raise: Halt. - self haltIf: [:o | o class ~= self class]. - ! Item was added: + ----- Method: ObjectTest>>testHaltOnce (in category 'tests - debugging') ----- + testHaltOnce + + self resetHaltOnceAfter: [ + self setHaltOnce. + self assert: [self haltOnceEnabled]. + self shouldHalt: [self haltOnce]. + self deny: [self haltOnceEnabled]. + self shouldntHalt: [self haltOnce]. + + self setHaltOnce. + self assert: [self haltOnceEnabled]. + self clearHaltOnce. + self deny: [self haltOnceEnabled]. + self shouldntHalt: [self haltOnce]].! Item was added: + ----- Method: ObjectTest>>testHaltOnceIf (in category 'tests - debugging') ----- + testHaltOnceIf + + self resetHaltOnceAfter: [ + | tested | + self setHaltOnce. + self shouldHalt: [self haltOnceIf: true]. + self shouldntHalt: [self haltOnceIf: true]. + + self setHaltOnce. + self shouldntHalt: [self haltOnceIf: false]. + self assert: [self haltOnceEnabled]. + + self setHaltOnce. + tested := false. + self shouldHalt: [self haltOnceIf: [tested := true]]. + self assert: tested. + tested := false. + self shouldntHalt: [self haltOnceIf: [tested := true]]. + self deny: tested. + + self setHaltOnce. + tested := false. + self shouldntHalt: [self haltOnceIf: [(tested := true) not]]. + self assert: [self haltOnceEnabled]. + self assert: tested. + tested := false. + self shouldntHalt: [self haltOnceIf: [(tested := true) not]]. + self assert: [self haltOnceEnabled]. + self assert: tested].! Item was changed: + ----- Method: ObjectTest>>testNotNil (in category 'tests - debugging') ----- - ----- Method: ObjectTest>>testNotNil (in category 'tests - testing') ----- testNotNil self assert: Object new notNil!

1 0

The Trunk: Kernel-ct.1491.mcz
by commits＠source.squeak.org 07 Nov '22

07 Nov '22

Christoph Thiede uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-ct.1491.mcz ==================== Summary ==================== Name: Kernel-ct.1491 Author: ct Time: 7 November 2022, 8:51:11.997226 pm UUID: 78f3b27b-1a68-4d42-b796-c7edbe07870c Ancestors: Kernel-ct.1489, Kernel-ct.1294 Merges Kernel-ct.1294: Add #haltOnceIf: to Object, which combines the strengths of #haltOnce and #haltIf:. Especially useful in performance-critical situations: It HaltOnce is disabled, the condition will not be evaluated at all. Revision: Minor refactoring. Argument renaming, make use of #findContextSuchThat:. =============== Diff against Kernel-ct.1489 =============== Item was changed: ----- Method: Object>>haltIf: (in category 'debugging') ----- + haltIf: aBooleanOrBlockOrSelector + "This is the typical message to use for inserting breakpoints during debugging. Param can be a boolean block or value, halt if true. + If the block has one arg, the receiver is bound to that. + If the argument is a selector, we look up in the callchain. Halt if any method's selector equals selector." - haltIf: condition - "This is the typical message to use for inserting breakpoints during - debugging. Param can be a block or expression, halt if true. - If the Block has one arg, the receiver is bound to that. - If the condition is a selector, we look up in the callchain. Halt if - any method's selector equals selector." - | cntxt | + ^ (self meetsHaltCondition: aBooleanOrBlockOrSelector) + ifTrue: [self halt]! - condition isSymbol ifTrue:[ - "only halt if a method with selector symbol is in callchain" - cntxt := thisContext. - [cntxt sender isNil] whileFalse: [ - cntxt := cntxt sender. - (cntxt selector = condition) ifTrue: [Halt signal]. - ]. - ^self. - ]. - (condition isBlock - ifTrue: [condition cull: self] - ifFalse: [condition] - ) ifTrue: [ - Halt signal - ].! Item was added: + ----- Method: Object>>haltOnceIf: (in category 'debugging') ----- + haltOnceIf: aBooleanOrBlockOrSelector + "Check aBooleanOrBlockOrSelector and halt, unless we have already done it once. See #meetsHaltCondition:." + + self haltOnceEnabled ifFalse: [^ self]. + ^ (self meetsHaltCondition: aBooleanOrBlockOrSelector) + ifTrue: + [self clearHaltOnce; halt]! Item was added: + ----- Method: Object>>meetsHaltCondition: (in category 'debugging') ----- + meetsHaltCondition: aBooleanOrBlockOrSelector + "If the condition block has one arg, the receiver is bound to that. + If the condition is a selector, we look up in the callchain. Halt if any method's selector equals selector." + + aBooleanOrBlockOrSelector isSymbol ifTrue: + [^ (thisContext home sender findContextSuchThat: [:ctxt | + ctxt selector = aBooleanOrBlockOrSelector]) + notNil]. + ^ aBooleanOrBlockOrSelector isBlock + ifTrue: [aBooleanOrBlockOrSelector cull: self] + ifFalse: [aBooleanOrBlockOrSelector value]!

1 0

The Trunk: VersionNumber-eem.5.mcz
by commits＠source.squeak.org 07 Nov '22

07 Nov '22

Eliot Miranda uploaded a new version of VersionNumber to project The Trunk: http://source.squeak.org/trunk/VersionNumber-eem.5.mcz ==================== Summary ==================== Name: VersionNumber-eem.5 Author: eem Time: 5 November 2022, 1:36:25.499057 pm UUID: 8883b385-6d1b-4659-b488-c677c700707a Ancestors: VersionNumber-cmm.4 Fix VersionNumber>>< so that version numbers of different lengths can be compared. e.g. 1.8 is clearly less than 1.7.4. At the same time fix the comparison so that it terminates as soon as a difference is found. =============== Diff against VersionNumber-cmm.4 =============== Item was changed: ----- Method: VersionNumber>>< (in category 'comparing') ----- < another + "Answer whether the receiver is less than the argument, another VersionNumber." - "Answer whether the receiver is less than the argument." + | tmp thisSize thatSize this that | - | tmp | - (self inSameBranchAs: another) ifFalse: - [^self error: 'Receiver and argument in different branches']. - tmp := another numbers. + thisSize := numbers size. + thatSize := tmp size. + 1 to: (thisSize min: thatSize) do: + [:i| + (this := numbers at: i) = (that := tmp at: i) ifFalse: + [^this < that]]. + ^thisSize < thatSize! - (tmp size = numbers size) ifTrue: - [1 to: numbers size do: - [ :in | (numbers at: in) < (tmp at: in) ifTrue: [^true]]. - ^false]. - - ^numbers size < tmp size - !

4 5

← Newer
1
2
3
4
5
6
7
8
9
10
Older →