Squeak-dev November 2022

squeak-dev@lists.squeakfoundation.org

24 participants
94 discussions

Full block closure return value testing/using in workspace?
by LawsonEnglish 28 Nov '22

28 Nov '22

I was trying to test some ideas and was using the new FullBlockClosure to return values for further use in a workspace. This works with “print it”: [Transcript show: 2;cr. ^2] value => 2 This does not work: test := [Transcript show: 2;cr. ^2] value <do it> test => nil. nor does this: test :=( [Transcript show: 2;cr. ^2] value) <do it> test => nil print it still works: test := ([Transcript show: 2;cr. ^2] value) => 2 test => nil. In all cases, a 2 appears in the Transcript window, so I know that *something* is happening. I would have thought that if print-it and do-it work, then the returned value would be put in the test variable, but that is not the case. I can use a workspace global variable to access the output, but that kinda makes the ^ a one-trick-pony: useful for breaking out of loops, but not giving me access to the return value. [test := 2. Transcript show: test;cr. ^test] value => 2 test => 2 Is this an oversight or bug or feature for workspaces, or is it working as intended? Lawson

4 4

Encoding issue with pipermail archives
by christoph.thiede＠student.hpi.uni-potsdam.de 28 Nov '22

28 Nov '22

Hi all, while debugging some encoding issues in Squeak Inbox Talk, I observed a possible encoding issues with the pipermail archives for squeak-dev. Specifically, I'm referring to the downloadable versions, e.g., http://lists.squeakfoundation.org/pipermail/squeak-dev/2022-November.txt or http://lists.squeakfoundation.org/pipermail/squeak-dev/2022-November.txt.gz. When I retrieve such a file which is encoded as UTF-8 using the WebClient, the Content-Type header of the server response does not include the charset used, so Squeak does not decode the UTF-8 again. I'm not sure, but shouldn't the server indicate this? Of course, I can work around, just wanted to document this here. :-) (Note that this bug report is independent of the multipart encoding issue I analyzed in http://lists.squeakfoundation.org/pipermail/squeak-dev/2022-November/222729… which turned out to be my fault.) Best, Christoph --- Sent from Squeak Inbox Talk

1 1

Please ignore | Encoding test for squeak-dev pipermail archive
by Christoph Thiede 28 Nov '22

28 Nov '22

Sometimes tab characters seem to be encoded as U+FFFD, does this depend on the mail client from which I am sending my messages? Tab tab tab Ümläutß Sorry for the noisé! Best, Christoph

3 6

Squeak 6 on SqueakJS
by Vanessa Freudenberg 26 Nov '22

26 Nov '22

... works now with release 1.0.5 of SqueakJS: https://squeak.js.org/run/#zip=https://files.squeak.org/6.0/Squeak6.0-22104… We only had to recognize the new image format – sorry it took me so long. Thank you, Christoph Tiede and Dave Lewis! (https://github.com/codefrau/SqueakJS/pull/138) TODO: actually implement primitive 578 (but then, quite a few non-essential prims are still missing) Enjoy! Vanessa

4 4

The Trunk: Compiler-eem.480.mcz
by commits＠source.squeak.org 26 Nov '22

26 Nov '22

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.480.mcz ==================== Summary ==================== Name: Compiler-eem.480 Author: eem Time: 22 November 2022, 7:10:27.324796 pm UUID: 3e5ba19e-c44a-4390-9004-de1246736cbc Ancestors: Compiler-eem.479 Do not warn of an uninitialized temporary if it is being sent ifNil: or ifNotNil:. =============== Diff against Compiler-eem.479 =============== Item was changed: ----- Method: Parser>>primaryExpression (in category 'expression types') ----- primaryExpression hereType == #word ifTrue: [parseNode := self variable. + (parseNode isUndefTemp + and: [(#('ifNil:' 'ifNotNil:') includes: here) not + and: [self interactive]]) + ifTrue: + [self queryUndefined]. - (parseNode isUndefTemp and: [self interactive]) - ifTrue: [self queryUndefined]. parseNode nowHasRef. ^ true]. hereType == #leftBracket ifTrue: [self advance. self blockExpression. ^true]. hereType == #leftBrace ifTrue: [self braceExpression. ^true]. hereType == #leftParenthesis ifTrue: [self advance. self expression ifFalse: [^self expected: 'expression']. (self match: #rightParenthesis) ifFalse: [^self expected: 'right parenthesis']. ^true]. (hereType == #string or: [hereType == #number or: [hereType == #literal or: [hereType == #character]]]) ifTrue: [parseNode := encoder encodeLiteral: self advance. ^true]. (here == #- and: [tokenType == #number and: [1 + hereEnd = mark]]) ifTrue: [self advance. parseNode := encoder encodeLiteral: self advance negated. ^true]. ^false!

11 22

The Inbox: Morphic-ct.2051.mcz
by commits＠source.squeak.org 26 Nov '22

26 Nov '22

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.2051.mcz ==================== Summary ==================== Name: Morphic-ct.2051 Author: ct Time: 19 November 2022, 8:35:59.299387 pm UUID: 6d037f4d-9ad4-8f48-8a0b-b40df261c00c Ancestors: Morphic-mt.2049 Makes keyboard exerciser scale-factor-aware. Fixes layout of instruction text, which was previously not wrapped within the morph, overlapped the check buttons, and caused invalidations when moving or closing the exerciser. For this, uses a classical row-based tabel layout. =============== Diff against Morphic-mt.2049 =============== Item was changed: Morph subclass: #KeyboardExerciser + instanceVariableNames: 'checkButtons eventPane' - instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'Morphic-Demo'! Item was added: + ----- Method: KeyboardExerciser>>addCheckButtons (in category 'initialization') ----- + addCheckButtons + + | buttonPane | + buttonPane := Morph new + beTransparent; + changeTableLayout; + hResizing: #spaceFill; + vResizing: #shrinkWrap; + listDirection: #leftToRight; + wrapDirection: #topToBottom; + cellGap: 10 px; + yourself. + + checkButtons := OrderedCollection new. + #(processKeyStroke 'Test key stroke' + processKeyDown 'Test key down' + processKeyUp 'Test key up') + groupsDo: [:selector :label | + | button | + button := ThreePhaseButtonMorph checkBox + target: self; + actionSelector: selector; + label: label; + yourself. + checkButtons addLast: button. + buttonPane addMorphBack: button]. + + self addMorphBack: buttonPane. + ^ buttonPane! Item was added: + ----- Method: KeyboardExerciser>>addEventPane (in category 'initialization') ----- + addEventPane + + eventPane := Morph new + beTransparent; + changeTableLayout; + listDirection: #leftToRight; + wrapDirection: #topToBottom; + hResizing: #spaceFill; + vResizing: #shrinkWrap; + cellGap: 10 px; + height: 0; + yourself. + + self addMorphBack: eventPane. + ^ eventPane! Item was added: + ----- Method: KeyboardExerciser>>addTitle (in category 'initialization') ----- + addTitle + + | title | + title := TextMorph new + contents: 'Move your mouse cursor to here and start typing. Try modifiers, too.' translated; + font: Preferences standardButtonFont; + color: Color gray; + hResizing: #spaceFill; + lock; + yourself. + + self addMorphBack: title. + ^ title! Item was changed: ----- Method: KeyboardExerciser>>checkButton: (in category 'initialization') ----- checkButton: checkIndex + self checkButtons do: [:button | + button state: #off]. - 1 to: 3 do: [:index | - (self submorphs at: index) - state: #off]. + (self checkButtons at: checkIndex) state: #on.! - (self submorphs at: checkIndex) state: #on.! Item was added: + ----- Method: KeyboardExerciser>>checkButtons (in category 'accessing') ----- + checkButtons + + ^ checkButtons! Item was changed: ----- Method: KeyboardExerciser>>clear (in category 'initialization') ----- clear + eventPane removeAllMorphs. + eventPane height: 0.! - (self submorphs allButFirst: 3) do: [:m | m delete].! Item was removed: - ----- Method: KeyboardExerciser>>drawOn: (in category 'drawing') ----- - drawOn: aCanvas - - super drawOn: aCanvas. - - aCanvas - drawString: 'Move your mouse cursor to here and start typing. Try modifiers, too.' translated - at: self topLeft - font: Preferences standardButtonFont - color: Color gray.! Item was added: + ----- Method: KeyboardExerciser>>eventMorphs (in category 'accessing') ----- + eventMorphs + + ^ eventPane submorphs! Item was changed: ----- Method: KeyboardExerciser>>handleEvent:inspect: (in category 'actions') ----- handleEvent: mouseEvent inspect: morph + mouseEvent shiftPressed - mouseEvent shiftPressed ifTrue: [(morph valueOfProperty: #event) explore] ifFalse: [(morph valueOfProperty: #event) inspect].! Item was changed: ----- Method: KeyboardExerciser>>initialize (in category 'initialization') ----- initialize super initialize. self + color: ((self userInterfaceTheme get: #color for: #ScrollPane) ifNil: [Color white]); + borderStyle: ((self userInterfaceTheme get: #borderStyle for: #ScrollPane) ifNil: [BorderStyle simple]) copy; + borderColor: ((self userInterfaceTheme get: #borderColor for: #ScrollPane) ifNil: [Color gray: 0.6]); + borderWidth: (((self userInterfaceTheme get: #borderWidth for: #ScrollPane) ifNil: [1]) * RealEstateAgent scaleFactor) truncated; + extent: 300 px @ 50 px; - color: (self userInterfaceTheme get: #color for: #ScrollPane); - extent: 300@50; layoutPolicy: TableLayout new; + listDirection: #topToBottom; - listDirection: #leftToRight; - wrapDirection: #topToBottom; hResizing: #rigid; vResizing: #shrinkWrap; + cellGap: 10 px; + layoutInset: 20 px; - cellGap: 10; - layoutInset: 20; yourself. + self addTitle. + self addCheckButtons. + self addEventPane. - #(processKeyStroke 'Test key stroke' - processKeyDown 'Test key down' - processKeyUp 'Test key up') - groupsDo: [:selector :label | - self addMorphBack: (ThreePhaseButtonMorph checkBox - target: self; - actionSelector: selector; - label: label; - yourself)]. self processKeyStroke.! Item was added: + ----- Method: KeyboardExerciser>>instructionMorph (in category 'accessing') ----- + instructionMorph + + ^ self hasSubmorphs ifTrue: [self firstSubmorph]! Item was changed: ----- Method: KeyboardExerciser>>lastEvent (in category 'accessing') ----- lastEvent | view event | + view := (self eventMorphs ifEmpty: [^ nil]) last. - view := self submorphs last. (view hasProperty: #event) ifFalse: [^ nil]. event := view valueOfProperty: #event. event isCollection ifTrue: [event := event last]. ^ event! Item was changed: ----- Method: KeyboardExerciser>>logEvent: (in category 'event handling') ----- logEvent: evt | eventMorph | evt = self lastEvent ifTrue: [^ self logEventRepetition: evt]. eventMorph := evt asMorph. eventMorph setProperty: #event toValue: evt copy; balloonText: ('Click to inspect. Shift+click to explore.\\Virtual key: {8}\Virtual modifiers: {5}\\Physical key: {9}\Physical modifiers: {6}\\Key value: 0x{1} ({2}) \Key character: {3}\Key string: {4}\\{7}' translated withCRs format: { evt keyValue printPaddedWith: $0 to: 2 base: 16. evt keyValue. evt isKeystroke ifTrue: [evt keyCharacter printString] ifFalse: ['-']. evt isKeystroke ifTrue: [evt keyString printString] ifFalse: ['-']. (evt virtualModifiers joinSeparatedBy: ' ') asUppercase. (evt physicalModifiers joinSeparatedBy: ' ') asUppercase. evt printString. evt virtualKey printString. evt physicalKey asString printString}). eventMorph on: #mouseEnter send: #handleEvent:emphasize: to: self; on: #mouseLeave send: #handleEvent:deemphasize: to: self; on: #mouseDown send: #handleEvent:inspect: to: self. + eventPane addMorphBack: eventMorph.! - self addMorphBack: eventMorph.! Item was changed: ----- Method: KeyboardExerciser>>logEventRepetition: (in category 'event handling') ----- logEventRepetition: evt | label lastEvents box | + (self eventMorphs last hasProperty: #repetition) + ifTrue: [box := self eventMorphs last. label := box submorphs first] - (self submorphs last hasProperty: #repetition) - ifTrue: [box := self submorphs last. label := box submorphs first] ifFalse: [ box := Morph new setProperty: #repetition toValue: true; color: Color transparent; layoutPolicy: TableLayout new; hResizing: #shrinkWrap; vResizing:#shrinkWrap; yourself. label := '' asText asMorph lock. box addMorph: label. box setProperty: #event toValue: (OrderedCollection with: self lastEvent). + eventPane addMorphBack: box]. - self addMorphBack: box]. lastEvents := box valueOfProperty: #event. lastEvents add: evt copy. box setProperty: #event toValue: lastEvents. label newContents: (('x ', (lastEvents size)) asText addAttribute: (TextFontReference toFont: Preferences standardButtonFont); yourself). box balloonText: ('{1}{2}' format: { lastEvents size > 10 ifTrue: ['... {1} older events and:\' translated withCRs format: {lastEvents size - 10}] ifFalse: ['']. (lastEvents last: (10 min: lastEvents size)) joinSeparatedBy: String cr. }). box on: #mouseEnter send: #handleEvent:emphasize: to: self; on: #mouseLeave send: #handleEvent:deemphasize: to: self; on: #mouseDown send: #handleEvent:inspect: to: self.!

3 2

The Inbox: System-ct.1374.mcz
by commits＠source.squeak.org 26 Nov '22

26 Nov '22

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-ct.1374.mcz ==================== Summary ==================== Name: System-ct.1374 Author: ct Time: 19 November 2022, 4:38:24.247392 pm UUID: 24c7f156-4cfc-7b43-8110-31c482fa909e Ancestors: System-ct.1372 Fixes formatting of greeting message when entering author initials. Commonly, punctuation marks after a word should have the same bold emphasis as the word before. =============== Diff against System-ct.1372 =============== Item was changed: ----- Method: Utilities class>>setAuthorInitials (in category 'identification') ----- setAuthorInitials "Put up a dialog allowing the user to specify the author's initials. Inform the user about collisions with known contributors. See SystemNavigation class >> #authors. " | newInitials newName | newInitials := Project uiManager request: 'Please type your initials:' translated initialAnswer: AuthorInitials. newInitials ifEmpty: [^ self "No Change"]. (SystemNavigation authorsInverted at: newInitials ifPresent: [:existingNames | newName := existingNames sorted joinSeparatedBy: '/'. + (self confirm: ('Hello, {1}!! :-) Our <a href="code://{3}">list of known contributors</{4}> associates the initials you have entered with this name. If this is not you, please consider alternative initials, preferably more than just a few characters, to avoid collisions. Do you want to use these author initials? {2}' translated format: { - (self confirm: ('Hello, {1}!! :-) Our <a href="code://{3}">list of known contributors</{4}> associates the initials you have entered with this name. If this is not you, please consider alternative initials, preferably more than just a few characters, to avoid collisions. Do you want to use these author initials? {2}' translated format: { newName ifNil: [newInitials]. newInitials. 'SystemReporter open model categoryAt: 1 put: true'. "mt: Avoid triggering the Windows Defender. See http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217346…" 'a' }) asTextFromHtml) ] ifAbsent: [true]) ifTrue: [self authorInitials: newInitials].!

4 3

The Trunk: System-ct.1375.mcz
by commits＠source.squeak.org 26 Nov '22

26 Nov '22

Christoph Thiede uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-ct.1375.mcz ==================== Summary ==================== Name: System-ct.1375 Author: ct Time: 26 November 2022, 3:32:09.169627 pm UUID: 48f83c02-9051-4c40-b43e-f5aade1bb7ab Ancestors: System-dtl.1374, System-ct.1374 Merges System-ct.1374: Fixes formatting of greeting message when entering author initials. =============== Diff against System-dtl.1374 =============== Item was changed: ----- Method: Utilities class>>setAuthorInitials (in category 'identification') ----- setAuthorInitials "Put up a dialog allowing the user to specify the author's initials. Inform the user about collisions with known contributors. See SystemNavigation class >> #authors. " | newInitials newName | newInitials := Project uiManager request: 'Please type your initials:' translated initialAnswer: AuthorInitials. newInitials ifEmpty: [^ self "No Change"]. (SystemNavigation authorsInverted at: newInitials ifPresent: [:existingNames | newName := existingNames sorted joinSeparatedBy: '/'. + (self confirm: ('Hello, {1}!! :-) Our <a href="code://{3}">list of known contributors</{4}> associates the initials you have entered with this name. If this is not you, please consider alternative initials, preferably more than just a few characters, to avoid collisions. Do you want to use these author initials? {2}' translated format: { - (self confirm: ('Hello, {1}!! :-) Our <a href="code://{3}">list of known contributors</{4}> associates the initials you have entered with this name. If this is not you, please consider alternative initials, preferably more than just a few characters, to avoid collisions. Do you want to use these author initials? {2}' translated format: { newName ifNil: [newInitials]. newInitials. 'SystemReporter open model categoryAt: 1 put: true'. "mt: Avoid triggering the Windows Defender. See http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217346…" 'a' }) asTextFromHtml) ] ifAbsent: [true]) ifTrue: [self authorInitials: newInitials].!

1 0

The Trunk: Installer-Core-ct.453.mcz
by commits＠source.squeak.org 26 Nov '22

26 Nov '22

Christoph Thiede uploaded a new version of Installer-Core to project The Trunk: http://source.squeak.org/trunk/Installer-Core-ct.453.mcz ==================== Summary ==================== Name: Installer-Core-ct.453 Author: ct Time: 19 November 2022, 12:05:57.795955 am UUID: d2a0cc9f-69ed-a149-b661-62b19024829a Ancestors: Installer-Core-ct.452 Proposal: Stores API selectors for Metacello in MetacelloStub to avoid UnknownSelector warnings upon initial Metacello usage. E.g., if you evaluate any installation script from the web in a vanilla Squeak image that uses Metacello's #githubUser:project:path: selector, the image will no longer complain about an unknown selector, which sometimes causes confusion in beginners and experts. :-) =============== Diff against Installer-Core-ct.452 =============== Item was added: + ----- Method: MetacelloStub class>>apiSelectors (in category 'support') ----- + apiSelectors + "To avoid UnknownSelector warnings upon initial Metacello usage. Support only. By adding this method, these selectors will already be contained in the symbol table before Metacello is installed." + + "(Metacello selectors , Metacello class selectors) withoutDuplicates sorted" + ^ #(#addStatement:args: #baseline: #bitbucketUser:project:commitish:path: #blueplane: #cacheRepository: #className: #classic #configuration: #croquet: #execute:args: #executorSpec #executorSpec: #fetch #fetch: #filetreeDirectory: #gemsource: #get #githubUser:project:commitish:path: #githubUser:project:path: #ignoreImage #image #impara: #list #load #load: #lock #locked #onConflict: #onConflictUseIncoming #onConflictUseIncoming:useLoaded: #onConflictUseLoaded #onDowngrade: #onDowngradeUseIncoming #onDowngradeUseIncoming: #onLock: #onLockBreak #onLockBreak: #onUpgrade: #onUpgradeUseLoaded #onUpgradeUseLoaded: #onWarning: #onWarningLog #password: #project: #record #record: #register #registrations #registry #renggli: #repository: #repositoryOverrides: #saltypickle: #scriptExecutor #scriptExecutorClass #scriptExecutorClass: #silently #smalltalkhubUser:project: #squeakfoundation: #squeaksource3: #squeaksource: #ss3: #statements #statements: #swa: #swasource: #unlock #unregister #usernam e: #version: #wiresong:) !

1 0

The Inbox: Morphic-ct.2057.mcz
by commits＠source.squeak.org 26 Nov '22

26 Nov '22

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.2057.mcz ==================== Summary ==================== Name: Morphic-ct.2057 Author: ct Time: 26 November 2022, 1:50:40.467518 pm UUID: 0bc53b37-9fd5-9643-8be1-722f0c6fd475 Ancestors: Morphic-ct.2056 Prevents pluggable buttons without a menu from acting on yellow-click. Why did we never notice this earlier? Yellow-click is for menus only ... =============== Diff against Morphic-ct.2056 =============== Item was changed: ----- Method: PluggableButtonMorph>>mouseUp: (in category 'event handling') ----- mouseUp: evt + evt yellowButtonChanged ifTrue: [^ super mouseUp: evt]. self updateFillStyle: evt. (self containsPoint: evt cursorPoint) ifTrue: [self performAction].!

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →