Squeak-dev November 2022

squeak-dev@lists.squeakfoundation.org

24 participants
94 discussions

RawBitsArray vs. DataStream
by Marcel Taeumel 23 Nov '22

23 Nov '22

Hi all -- Should the following work? class := DoubleByteArray. size := 10. dummy := 123. array := class new: size. array atAllPut: dummy. (DataStream newFileNamed: 'numbers') nextPut: array; close. stream := DataStream fileNamed: 'numbers'. load := stream readArray. stream close. load explore Best, Marcel

4 10

The Trunk: Collections-eem.1025.mcz
by commits＠source.squeak.org 23 Nov '22

23 Nov '22

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.1025.mcz ==================== Summary ==================== Name: Collections-eem.1025 Author: eem Time: 23 November 2022, 6:43:09.849872 am UUID: b326199c-16c6-4df6-9f70-fc55b0718f20 Ancestors: Collections-eem.1024 Respond to Marcel's excellent suggestion. Rename SequenceableCollection>>subStrings: to subsequences: and implement String>>subStrings: upon it. =============== Diff against Collections-eem.1024 =============== Item was removed: - ----- Method: SequenceableCollection>>subStrings: (in category 'converting') ----- - subStrings: separatorsOrElement - "Answer an array containing the substrings in the receiver separated - by the elements of separatorsOrElement, if it is a Collection, or a - singleton separator object, if it is not." - - | result size thing subsequenceStart | - result := OrderedCollection new. - size := self size. - separatorsOrElement isCollection - ifTrue: - [1 to: size do: - [:i| - thing := self at: i. - (separatorsOrElement includes: thing) - ifTrue: - [subsequenceStart ifNotNil: - [result addLast: (self copyFrom: subsequenceStart to: i - 1)]. - subsequenceStart := nil] - ifFalse: - [subsequenceStart ifNil: [subsequenceStart := i]]]] - ifFalse: - [1 to: size do: - [:i| - thing := self at: i. - separatorsOrElement = thing - ifTrue: - [subsequenceStart ifNotNil: - [result addLast: (self copyFrom: subsequenceStart to: i - 1)]. - subsequenceStart := nil] - ifFalse: - [subsequenceStart ifNil: [subsequenceStart := i]]]]. - subsequenceStart ifNotNil: - [result addLast: (self copyFrom: subsequenceStart to: size)]. - ^result asArray - - "'Now is the time for all good people to come to the aid of the cause of world peace. It is just fine, even desirable, to love your country, if that means wanting it to play a beneficial role in the course of world events and be the best possible example of a good society. But if it means wanting dominion over the rest of the world, it is not love but defensiveness or self-glorification, and will lead only to oblivion.' subStrings: Character space" - - "'Now is the time for all good people to come to the aid of the cause of world peace. It is just fine, even desirable, to love your country, if that means wanting it to play a beneficial role in the course of world events and be the best possible example of a good society. But if it means wanting dominion over the rest of the world, it is not love but defensiveness or self-glorification, and will lead only to oblivion.' subStrings: ' ,.-'"! Item was added: + ----- Method: SequenceableCollection>>subsequences: (in category 'converting') ----- + subsequences: separatorsOrElement + "Answer an array containing the subsequences in the receiver separated + by the elements of separatorsOrElement, if it is a Collection, or a + single separator object, if it is not." + + | result size thing subsequenceStart | + result := OrderedCollection new. + size := self size. + separatorsOrElement isCollection + ifTrue: + [1 to: size do: + [:i| + thing := self at: i. + (separatorsOrElement includes: thing) + ifTrue: + [subsequenceStart ifNotNil: + [result addLast: (self copyFrom: subsequenceStart to: i - 1)]. + subsequenceStart := nil] + ifFalse: + [subsequenceStart ifNil: [subsequenceStart := i]]]] + ifFalse: + [1 to: size do: + [:i| + thing := self at: i. + separatorsOrElement = thing + ifTrue: + [subsequenceStart ifNotNil: + [result addLast: (self copyFrom: subsequenceStart to: i - 1)]. + subsequenceStart := nil] + ifFalse: + [subsequenceStart ifNil: [subsequenceStart := i]]]]. + subsequenceStart ifNotNil: + [result addLast: (self copyFrom: subsequenceStart to: size)]. + ^result asArray + + "'Now is the time for all good people to come to the aid of the cause of world peace. It is just fine, even desirable, to love your country, if that means wanting it to play a beneficial role in the course of world events and be the best possible example of a good society. But if it means wanting dominion over the rest of the world, it is not love but defensiveness or self-glorification, and will lead only to oblivion.' subStrings: Character space" + + "'Now is the time for all good people to come to the aid of the cause of world peace. It is just fine, even desirable, to love your country, if that means wanting it to play a beneficial role in the course of world events and be the best possible example of a good society. But if it means wanting dominion over the rest of the world, it is not love but defensiveness or self-glorification, and will lead only to oblivion.' subStrings: ' ,.-'"! Item was changed: ----- Method: String>>subStrings: (in category 'converting') ----- subStrings: separators "Answer an array containing the substrings in the receiver separated by the elements of separators, which should be a collection of Characters, or, for convenience, a single character.." (separators isCharacter or: [separators isString or:[separators allSatisfy: [:element | element isCharacter]]]) ifTrue: + [^self subsequences: separators]. - [^super subStrings: separators]. ^self error: 'separators must be Characters.' "'Now is the time for all good people to come to the aid of the cause of world peace. It is just fine, even desirable, to love your country, if that means wanting it to play a beneficial role in the course of world events and be the best possible example of a good society. But if it means wanting dominion over the rest of the world, it is not love but defensiveness or self-glorification, and will lead only to oblivion.' subStrings: Character space" "'Now is the time for all good people to come to the aid of the cause of world peace. It is just fine, even desirable, to love your country, if that means wanting it to play a beneficial role in the course of world events and be the best possible example of a good society. But if it means wanting dominion over the rest of the world, it is not love but defensiveness or self-glorification, and will lead only to oblivion.' subStrings: ' ,.-'"!

1 0

The Trunk: Collections-eem.1023.mcz
by commits＠source.squeak.org 23 Nov '22

23 Nov '22

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.1023.mcz ==================== Summary ==================== Name: Collections-eem.1023 Author: eem Time: 22 November 2022, 7:12:52.434373 pm UUID: 9c7f84f0-35b9-476f-9d51-75cc12248c26 Ancestors: Collections-eem.1022 Reimplement subStrings: in SequenceableCollection (this is where it belongs; subStrings: on arbitrary sequeances is useful). Allow the argument to be a singleton, if not a collection. Reimplement to use an index and copyFrom:to: instead of consing up a string on each element. =============== Diff against Collections-eem.1022 =============== Item was added: + ----- Method: SequenceableCollection>>subStrings: (in category 'converting') ----- + subStrings: separatorsOrElement + "Answer an array containing the substrings in the receiver separated + by the elements of separatorsOrElement, if it is a Collection, or a + singleton separator object, if it is not." + + | result size thing subsequenceStart | + result := OrderedCollection new. + size := self size. + separatorsOrElement isCollection + ifTrue: + [1 to: size do: + [:i| + thing := self at: i. + (separatorsOrElement includes: thing) + ifTrue: + [subsequenceStart ifNotNil: + [result addLast: (self copyFrom: subsequenceStart to: i - 1)]. + subsequenceStart := nil] + ifFalse: + [subsequenceStart ifNil: [subsequenceStart := i]]]] + ifFalse: + [1 to: size do: + [:i| + thing := self at: i. + separatorsOrElement = thing + ifTrue: + [subsequenceStart ifNotNil: + [result addLast: (self copyFrom: subsequenceStart to: i - 1)]. + subsequenceStart := nil] + ifFalse: + [subsequenceStart ifNil: [subsequenceStart := i]]]]. + subsequenceStart ifNotNil: + [result addLast: (self copyFrom: subsequenceStart to: size)]. + ^result asArray + + "'Now is the time for all good people to come to the aid of the cause of world peace. It is just fine, even desirable, to love your country, if that means wanting it to play a beneficial role in the course of world events and be the best possible example of a good society. But if it means wanting dominion over the rest of the world, it is not love but defensiveness or self-glorification, and will lead only to oblivion.' subStrings: Character space" + + "'Now is the time for all good people to come to the aid of the cause of world peace. It is just fine, even desirable, to love your country, if that means wanting it to play a beneficial role in the course of world events and be the best possible example of a good society. But if it means wanting dominion over the rest of the world, it is not love but defensiveness or self-glorification, and will lead only to oblivion.' subStrings: ' ,.-'"! Item was changed: ----- Method: String>>subStrings: (in category 'converting') ----- subStrings: separators "Answer an array containing the substrings in the receiver separated + by the elements of separators, which should be a collection of Characters, + or, for convenience, a single character.." + (separators isCharacter or: [separators isString or:[separators allSatisfy: [:element | element isCharacter]]]) ifTrue: + [^super subStrings: separators]. + ^self error: 'separators must be Characters.' + + "'Now is the time for all good people to come to the aid of the cause of world peace. It is just fine, even desirable, to love your country, if that means wanting it to play a beneficial role in the course of world events and be the best possible example of a good society. But if it means wanting dominion over the rest of the world, it is not love but defensiveness or self-glorification, and will lead only to oblivion.' subStrings: Character space" + + "'Now is the time for all good people to come to the aid of the cause of world peace. It is just fine, even desirable, to love your country, if that means wanting it to play a beneficial role in the course of world events and be the best possible example of a good society. But if it means wanting dominion over the rest of the world, it is not love but defensiveness or self-glorification, and will lead only to oblivion.' subStrings: ' ,.-'"! - by the elements of separators." - | char result sourceStream subString | - #Collectn. - "Changed 2000/04/08 For ANSI <readableString> protocol." - (separators isString or:[separators allSatisfy: [:element | element isCharacter]]) ifFalse: - [^ self error: 'separators must be Characters.']. - sourceStream := ReadStream on: self. - result := OrderedCollection new. - subString := String new. - [sourceStream atEnd] - whileFalse: - [char := sourceStream next. - (separators includes: char) - ifTrue: [subString notEmpty - ifTrue: - [result add: subString copy. - subString := String new]] - ifFalse: [subString := subString , (String with: char)]]. - subString notEmpty ifTrue: [result add: subString copy]. - ^ result asArray!

3 3

The Trunk: Collections-eem.1024.mcz
by commits＠source.squeak.org 23 Nov '22

23 Nov '22

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.1024.mcz ==================== Summary ==================== Name: Collections-eem.1024 Author: eem Time: 22 November 2022, 7:37:55.158009 pm UUID: 4c57a48d-50a0-4209-a01b-643c0da598f6 Ancestors: Collections-eem.1023 Replace the two implementations of [Byte]String>>substrings with one using the same scheme as SequenceableCollection>>subStrings:; it's at least 23% faster. =============== Diff against Collections-eem.1023 =============== Item was removed: - ----- Method: ByteString>>substrings (in category 'converting') ----- - substrings - "Answer an array of the substrings that compose the receiver." - - ^Array streamContents: [ :stream | - | end start | - end := 1. - "find one substring each time through this loop" - [ "find the beginning of the next substring" - (start := self - indexOfAnyOf: CharacterSet nonSeparators - startingAt: end) = 0 ] - whileFalse: [ - "find the end" - end := self - indexOfAnyOf: CharacterSet separators - startingAt: start - ifAbsent: [ self size + 1 ]. - stream nextPut: (self copyFrom: start to: end - 1) ] ]! Item was changed: ----- Method: String>>substrings (in category 'converting') ----- substrings "Answer an array of the substrings that compose the receiver." + | result size subsequenceStart | + result := OrderedCollection new. + size := self size. + 1 to: size do: + [:i| + (self at: i) isSeparator + ifTrue: + [subsequenceStart ifNotNil: + [result addLast: (self copyFrom: subsequenceStart to: i - 1)]. + subsequenceStart := nil] + ifFalse: + [subsequenceStart ifNil: [subsequenceStart := i]]]. + subsequenceStart ifNotNil: + [result addLast: (self copyFrom: subsequenceStart to: size)]. + ^result asArray + ! - | result end beginning | - result := WriteStream on: (Array new: 10). - end := 0. - "find one substring each time through this loop" - [ "find the beginning of the next substring" - beginning := end+1. - [beginning <= self size and:[(self at: beginning) isSeparator]] - whileTrue:[beginning := beginning + 1]. - beginning <= self size] whileTrue: [ - "find the end" - end := beginning. - [end <= self size and:[(self at: end) isSeparator not]] - whileTrue:[end := end + 1]. - end := end - 1. - result nextPut: (self copyFrom: beginning to: end). - ]. - ^result contents!

1 0

The Inbox: Collections-cmm.1022.mcz
by commits＠source.squeak.org 23 Nov '22

23 Nov '22

Chris Muller uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-cmm.1022.mcz ==================== Summary ==================== Name: Collections-cmm.1022 Author: cmm Time: 18 November 2022, 11:14:01.223447 pm UUID: 9a05d251-4f02-43de-94e8-0f077ec51680 Ancestors: Collections-nice.1021 Allow empty fields when using #subStrings:. =============== Diff against Collections-nice.1021 =============== Item was changed: ----- Method: String>>subStrings: (in category 'converting') ----- subStrings: separators "Answer an array containing the substrings in the receiver separated by the elements of separators." | char result sourceStream subString | - #Collectn. - "Changed 2000/04/08 For ANSI <readableString> protocol." (separators isString or:[separators allSatisfy: [:element | element isCharacter]]) ifFalse: [^ self error: 'separators must be Characters.']. sourceStream := ReadStream on: self. result := OrderedCollection new. subString := String new. [sourceStream atEnd] whileFalse: [char := sourceStream next. (separators includes: char) + ifTrue: [result add: subString copy. + subString := String new] - ifTrue: [subString notEmpty - ifTrue: - [result add: subString copy. - subString := String new]] ifFalse: [subString := subString , (String with: char)]]. subString notEmpty ifTrue: [result add: subString copy]. ^ result asArray!

8 10

The Trunk: Tests-eem.494.mcz
by commits＠source.squeak.org 22 Nov '22

22 Nov '22

Eliot Miranda uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-eem.494.mcz ==================== Summary ==================== Name: Tests-eem.494 Author: eem Time: 22 November 2022, 4:48:01.49217 am UUID: 6a6ee2f8-2a13-4372-b7cc-d43e0bbb8ffe Ancestors: Tests-mt.493 Test that various RawBitsArrays are serializable on DataStream et al. =============== Diff against Tests-mt.493 =============== Item was added: + ----- Method: DataStreamTest>>testRawBits (in category 'tests') ----- + testRawBits + ((RawBitsArray subclasses reject: #isAbstract), ((RawBitsArray subclasses select: #isAbstract) collect: #subclasses)) flatten do: + [:class| | instance | + instance := class new: 10. + instance first isColor + ifTrue: + [1 to: instance size do: [:i| instance at: i put: (Color r: i * 1 g: i * 2 b: i * 3)]] + ifFalse: + [1 to: instance size do: [:i| instance at: i put: i]]. + self assert: instance equals: (self testObject: instance) description: 'A ', class name, ' should be serializable']!

1 0

The Trunk: Collections-eem.1022.mcz
by commits＠source.squeak.org 22 Nov '22

22 Nov '22

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.1022.mcz ==================== Summary ==================== Name: Collections-eem.1022 Author: eem Time: 21 November 2022, 9:26:32.233055 pm UUID: 11b99e4c-0597-4f7d-b3bf-667ea9ad2edf Ancestors: Collections-nice.1021 Fix PositionableStream>>#isBinary, which was implemented in terms of ByteArray, implemented using the new Collection>>isUnsignedIntegerArray. Add Collection>>isSignedIntegerArray for symmetry. =============== Diff against Collections-nice.1021 =============== Item was added: + ----- Method: Collection>>isSignedIntegerArray (in category 'testing') ----- + isSignedIntegerArray + ^false! Item was added: + ----- Method: Collection>>isUnsignedIntegerArray (in category 'testing') ----- + isUnsignedIntegerArray + ^false! Item was changed: ----- Method: PositionableStream>>isBinary (in category 'testing') ----- isBinary + "Answer if the receiver is a binary stream" + ^collection isCollection and: [collection isUnsignedIntegerArray]! - "Return true if the receiver is a binary byte stream" - ^collection class == ByteArray! Item was added: + ----- Method: SignedIntegerArray>>isSignedIntegerArray (in category 'testing') ----- + isSignedIntegerArray + ^true! Item was added: + ----- Method: UnsignedIntegerArray>>isUnsignedIntegerArray (in category 'testing') ----- + isUnsignedIntegerArray + ^true!

1 0

any objections if I make TextConverter>>decodeString: consume unsigned integer arrays (ByteArray et al) also?
by Eliot Miranda 21 Nov '22

21 Nov '22

Hi All, in porting the ClipboardExtendedPlugin to Windows and starting using it I want to do UTF-16 => string conversion on ByteArray. The innards of textConverter>>decodeString: et al are specific for characters for no good reason I can see. If I don't break the tests does anyone object my adding this polymorphism? _,,,^..^,,,_ best, Eliot

3 3

Looking for presenters for UK Smalltalk User Group online meetings
by Giovanni Corriga 21 Nov '22

21 Nov '22

Hi, The UK Smalltalk User Group is looking for presenters for the online events that we have been running since April 2020. If you have anything you'd like to share with the community - no matter how small! - please contact us at info(a)uksmalltalk.org or giovanni(a)corriga.net to discuss what you can offer. Cheers, Giovanni

1 0

The Inbox: Installer-Core-ct.453.mcz
by commits＠source.squeak.org 21 Nov '22

21 Nov '22

Christoph Thiede uploaded a new version of Installer-Core to project The Inbox: http://source.squeak.org/inbox/Installer-Core-ct.453.mcz ==================== Summary ==================== Name: Installer-Core-ct.453 Author: ct Time: 19 November 2022, 12:05:57.795955 am UUID: d2a0cc9f-69ed-a149-b661-62b19024829a Ancestors: Installer-Core-ct.452 Proposal: Stores API selectors for Metacello in MetacelloStub to avoid UnknownSelector warnings upon initial Metacello usage. E.g., if you evaluate any installation script from the web in a vanilla Squeak image that uses Metacello's #githubUser:project:path: selector, the image will no longer complain about an unknown selector, which sometimes causes confusion in beginners and experts. :-) =============== Diff against Installer-Core-ct.452 =============== Item was added: + ----- Method: MetacelloStub class>>apiSelectors (in category 'support') ----- + apiSelectors + "To avoid UnknownSelector warnings upon initial Metacello usage. Support only. By adding this method, these selectors will already be contained in the symbol table before Metacello is installed." + + "(Metacello selectors , Metacello class selectors) withoutDuplicates sorted" + ^ #(#addStatement:args: #baseline: #bitbucketUser:project:commitish:path: #blueplane: #cacheRepository: #className: #classic #configuration: #croquet: #execute:args: #executorSpec #executorSpec: #fetch #fetch: #filetreeDirectory: #gemsource: #get #githubUser:project:commitish:path: #githubUser:project:path: #ignoreImage #image #impara: #list #load #load: #lock #locked #onConflict: #onConflictUseIncoming #onConflictUseIncoming:useLoaded: #onConflictUseLoaded #onDowngrade: #onDowngradeUseIncoming #onDowngradeUseIncoming: #onLock: #onLockBreak #onLockBreak: #onUpgrade: #onUpgradeUseLoaded #onUpgradeUseLoaded: #onWarning: #onWarningLog #password: #project: #record #record: #register #registrations #registry #renggli: #repository: #repositoryOverrides: #saltypickle: #scriptExecutor #scriptExecutorClass #scriptExecutorClass: #silently #smalltalkhubUser:project: #squeakfoundation: #squeaksource3: #squeaksource: #ss3: #statements #statements: #swa: #swasource: #unlock #unregister #usernam e: #version: #wiresong:) !

2 1

← Newer
1
2
3
4
5
6
7
8
9
10
Older →