Squeak-dev June 2020

squeak-dev@lists.squeakfoundation.org

43 participants
346 discussions

Performance regression
by Jakob Reschke 29 Jun '20

29 Jun '20

Hi all, On Monday I noticed that some Squot tests started to fail on Travis CI due to timeouts (test cases exceeding the 5 sec default timeout). The problems are not due to changes in Squot itself because if I retrigger an older build which was already green, it also fails. So I suspect a change in Squeak Trunk, since the Squeak 5.2 builds are also not affected. I did not yet find the cause, but would like to make known what I found so far. Does anyone have an idea what could have caused this? Of course I don't expect you to debug my test cases, but maybe you have a hint for me. - The Mac builds are much more affected than the Linux builds. This could be due to differences in Travis CI's setup for the operating systems. The Linux test runs also got slower, but not by so much. - Both the 64 bit and 32 bit Mac builds got slower. The 64 bit ones scratch at the 5 sec mark, but did not exceed it yet. - If I repeat older Mac builds, they experience the same slowdown. - The tests on Squeak 5.2 are unaffected on either platform. - Some tests take about 6x up to 20x more time than before. On Linux it is only up to x3 times slower and in sum hardly noticeable. For the rest of this, I will only talk about the Mac Trunk builds. - testTrackingAPackage has the worst ratio, whereas testTrackingAClass is virtually unaffected. - Only tests that involve whole packages, not individual objects or single classes, seem to be affected. Is the regression in something that PackageInfo does (enumerating classes, methods, accessing categories)? - Surprisingly, the tests with Git are less worse than the tests with a stub in-memory repository (these are the same test cases, but with a different backend object). I think the Git tests by chance ran after the in-memory tests, maybe that affects things, I don't know yet. The Git tests did not reach the 5 sec mark. - Tests that involve Monticello (such as the Monticello->Git conversion) and do not only create MCDefinitions and pass them around, take about 2x as long now. For reference: Good build: https://travis-ci.org/github/hpi-swa/Squot/jobs/698280144 Bad build: https://travis-ci.org/github/hpi-swa/Squot/jobs/700640404 The runtimes are annotated to the test cases when you expand them. If you do want to look at the code, just load the Git Browser, then you will also have the test cases. If I find out more on the weekend, I will post again. Kind regards, Jakob

3 6

The Trunk: WebClient-Core-ul.123.mcz
by commits＠source.squeak.org 29 Jun '20

29 Jun '20

Levente Uzonyi uploaded a new version of WebClient-Core to project The Trunk: http://source.squeak.org/trunk/WebClient-Core-ul.123.mcz ==================== Summary ==================== Name: WebClient-Core-ul.123 Author: ul Time: 23 June 2020, 2:18:02.417391 pm UUID: ddad9c69-fa09-4c2e-bb38-156425f9baa0 Ancestors: WebClient-Core-tobe.121 WebMessage >> #streamDirectlyFrom:to:size:progress: - avoid infinite loop when there are fewer bytes available than specified - fix progress notifications - avoid unnecessary buffer copying WebMessage: - use #contentType: and #contentLength: methods to set the corresponding headers to avoid string duplication =============== Diff against WebClient-Core-tobe.121 =============== Item was changed: ----- Method: WebClient>>httpPost:content:type:do: (in category 'methods') ----- httpPost: urlString content: postData type: contentType do: aBlock "POST the data to the given url" | request | self initializeFromUrl: urlString. request := self requestWithUrl: urlString. request method: 'POST'. + contentType ifNotNil:[request contentType: contentType]. + request contentLength: postData size. - contentType ifNotNil:[request headerAt: 'Content-Type' put: contentType]. - request headerAt: 'Content-Length' put: postData size. userAgent ifNotNil:[request headerAt: 'User-Agent' put: userAgent]. aBlock value: request. ^self sendRequest: request content: postData readStream size: postData size! Item was changed: ----- Method: WebClient>>httpPostChunked:content:type:do: (in category 'methods') ----- httpPostChunked: urlString content: chunkBlock type: contentType do: aBlock "POST the data to the given url using chunked transfer-encoding. The chunkBlock takes a request and can be fed using #nextChunkPut: until all the data has been sent. Chunked encoding can be used for long-lasting connections to a server, but care must be taken to ensure that the client isn't running afoul of the server expecting to read the full response (i.e., you should use this only if you have control over both ends). However, it is a great way to send output from commands that take awhile and other time-consuming operations if authentication has been handled." | request | self initializeFromUrl: urlString. request := self requestWithUrl: urlString. request method: 'POST'. + contentType ifNotNil:[request contentType: contentType]. - contentType ifNotNil:[request headerAt: 'Content-Type' put: contentType]. request headerAt: 'Transfer-Encoding' put: 'chunked'. userAgent ifNotNil:[request headerAt: 'User-Agent' put: userAgent]. aBlock value: request. "Send the chunked data" ^self sendRequest: request contentBlock:[:aStream| "Set the stream in the request and pass it in the chunk block" request stream: aStream. chunkBlock value: request. "send termination chunk" aStream nextPutAll: '0'; crlf; crlf; flush. ]. ! Item was changed: ----- Method: WebClient>>httpPut:content:type:do: (in category 'methods') ----- httpPut: urlString content: postData type: contentType do: aBlock "PUT the data to the given url" | request | self initializeFromUrl: urlString. request := self requestWithUrl: urlString. request method: 'PUT'. + contentType ifNotNil:[request contentType: contentType]. + request contentLength: postData size. - contentType ifNotNil:[request headerAt: 'Content-Type' put: contentType]. - request headerAt: 'Content-Length' put: postData size. userAgent ifNotNil:[request headerAt: 'User-Agent' put: userAgent]. aBlock value: request. ^self sendRequest: request content: postData readStream size: postData size! Item was changed: ----- Method: WebMessage>>streamDirectlyFrom:to:size:progress: (in category 'streaming') ----- streamDirectlyFrom: srcStream to: dstStream size: sizeOrNil progress: progressBlock "Stream the content of srcStream to dstStream. + If a size is given, try to stream that many elements. It's the senders responsibility to verify that enough bytes were read. If no size is given, stream all available data." - If a size is given, stream that many elements, otherwise stream up to the end." + | buffer bufferSize totalBytesRead bytesInBuffer | - | buffer remaining size totalRead | sizeOrNil = 0 ifTrue:[^self]. + bufferSize := 4096. + buffer := (srcStream isBinary ifTrue:[ByteArray] ifFalse:[String]) new: bufferSize. + totalBytesRead := 0. + [ + progressBlock ifNotNil:[ progressBlock value: sizeOrNil value: totalBytesRead ]. + srcStream atEnd or: [ sizeOrNil notNil and: [ totalBytesRead >= sizeOrNil ]] ] + whileFalse: [ + bytesInBuffer := srcStream + readInto: buffer + startingAt: 1 + count: (sizeOrNil + ifNil: [ bufferSize ] + ifNotNil: [ sizeOrNil - totalBytesRead min: bufferSize ]). + dstStream next: bytesInBuffer putAll: buffer startingAt: 1. + totalBytesRead := totalBytesRead + bytesInBuffer ]. + dstStream flush! - - buffer := (srcStream isBinary ifTrue:[ByteArray] ifFalse:[String]) new: 4096. - totalRead := 0. - size := sizeOrNil ifNil:[0]. - [(sizeOrNil == nil and:[srcStream atEnd not]) or:[totalRead < size]] whileTrue:[ - progressBlock ifNotNil:[progressBlock value: sizeOrNil value: totalRead]. - remaining := sizeOrNil ifNil:[99999] ifNotNil:[sizeOrNil - totalRead]. - remaining > buffer size ifTrue:[remaining := buffer size]. - buffer := srcStream next: remaining into: buffer startingAt: 1. - dstStream nextPutAll: (remaining < buffer size - ifTrue:[(buffer copyFrom: 1 to: remaining)] - ifFalse:[buffer]). - totalRead := totalRead + buffer size. - ]. - dstStream flush. - progressBlock ifNotNil:[progressBlock value: sizeOrNil value: totalRead].! Item was changed: ----- Method: WebRequest>>send200Response:contentType:do: (in category 'responses') ----- send200Response: aString contentType: contentType do: aBlock "Send a 200 OK response" | resp | resp := self newResponse protocol: 'HTTP/1.1' code: 200. + resp contentType: contentType. - resp headerAt: 'Content-Type' put: contentType. aBlock value: resp. ^self sendResponse: resp content: aString.! Item was changed: ----- Method: WebRequest>>send404Response: (in category 'responses') ----- send404Response: body "Send a 404 not found response" ^self send404Response: (body convertToWithConverter: UTF8TextConverter new) + do: [ :resp | resp contentType: 'text/html; charset=utf-8' ]! - do: [ :resp | resp headerAt: 'Content-Type' put: 'text/html; charset=utf-8' ]! Item was changed: ----- Method: WebRequest>>send404Response:do: (in category 'responses') ----- send404Response: body do: aBlock "Send a 404 not found response" | resp | resp := self newResponse protocol: 'HTTP/1.1' code: 404. + resp contentType: 'text/html; charset=utf-8'. - resp headerAt: 'Content-Type' put: 'text/html; charset=utf-8'. aBlock value: resp. ^self sendResponse: resp content: body. ! Item was changed: ----- Method: WebRequest>>send405Response:content: (in category 'responses') ----- send405Response: allowed content: body "Send a 405 method not allowed response" | resp | resp := self newResponse protocol: 'HTTP/1.1' code: 405. + resp contentType: 'text/html; charset=utf-8'. - resp headerAt: 'Content-Type' put: 'text/html; charset=utf-8'. resp headerAt: 'allow' put: (String streamContents:[:s| allowed do:[:m| s nextPutAll: m] separatedBy:[s nextPut: $,] ]). ^self sendResponse: resp content: body.! Item was changed: ----- Method: WebRequest>>sendResponse:contentStream:size: (in category 'sending') ----- sendResponse: resp contentStream: aStream size: streamSize "Sends a WebResponse, streaming its contents from aStream. If a size is provided, insert a Content-Length header, otherwise ensure that the connection is transient." streamSize ifNil:[self headerAt: 'Connection' put: 'close'] "mark transient" + ifNotNil:[resp contentLength: streamSize]. - ifNotNil:[resp headerAt: 'Content-Length' put: streamSize]. ^self sendResponse: resp contentBlock:[:sockStream| resp streamFrom: aStream to: sockStream size: streamSize progress: nil ]! Item was changed: ----- Method: WebRequest>>sendResponseCode:content:type:do: (in category 'responses') ----- sendResponseCode: code content: aString type: contentType do: aBlock "Send a 500 Internal server error response" | resp | resp := self newResponse protocol: 'HTTP/1.1' code: code. + contentType ifNotNil:[resp contentType: contentType]. - contentType ifNotNil:[resp headerAt: 'Content-Type' put: contentType]. aBlock value: resp. ^self sendResponse: resp content: aString.! Item was changed: ----- Method: WebRequest>>stream200Response:size:type:do: (in category 'responses') ----- stream200Response: aStream size: streamSize type: contentType do: aBlock "Stream a 200 OK response" | resp | resp := self newResponse protocol: 'HTTP/1.1' code: 200. + resp contentType: contentType. - resp headerAt: 'Content-Type' put: contentType. aBlock value: resp. ^self sendResponse: resp contentStream: aStream size: streamSize.! Item was changed: ----- Method: WebServer class>>browseFile:request: (in category 'examples') ----- browseFile: file request: request "Responds with a file back to the original request" | fileSize mimeTypes resp | file binary. fileSize := file size. mimeTypes := file mimeTypes ifNil:[#('application/octet-stream')]. resp := request newResponse protocol: 'HTTP/1.1' code: 200. + resp contentType: mimeTypes first. - resp headerAt: 'Content-Type' put: mimeTypes first. request sendResponse: resp contentStream: file size: fileSize.! Item was changed: ----- Method: WebServer>>authenticate:realm:methods:do: (in category 'authentication') ----- authenticate: request realm: realm methods: accepted do: aBlock "Authenticates an incoming request using one of the accepted methods. Evaluates aBlock upon successful authentication. Responds with a 401 (Unauthorized) if the authentication fails." | method resp | request headersAt: 'Authorization' do:[:authHeader| method := authHeader copyUpTo: Character space. (accepted anySatisfy:[:auth| auth sameAs: method]) ifTrue:[ (self authAccept: method request: request realm: realm header: authHeader) ifTrue:[^aBlock value]. ]. ]. "Send a 401 (unauthorized) response" resp := request newResponse protocol: 'HTTP/1.1' code: 401. + resp contentType: 'text/html; charset=utf-8'. - resp headerAt: 'Content-Type' put: 'text/html; charset=utf-8'. accepted do:[:auth| | hdr | hdr := self authHeader: auth request: request realm: realm. hdr ifNotNil:[resp addHeader: 'WWW-Authenticate' value: hdr]. ]. request sendResponse: resp content: '<html><head><title>401 Unauthorized</title></head><body><h1>401 Unauthorized</h1><p>You are not authorized to access the requested URL</p></body></html>'. !

1 0

The Trunk: CollectionsTests-ul.340.mcz
by commits＠source.squeak.org 29 Jun '20

29 Jun '20

Levente Uzonyi uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-ul.340.mcz ==================== Summary ==================== Name: CollectionsTests-ul.340 Author: ul Time: 29 June 2020, 4:14:52.34981 am UUID: 2375f0fe-f9e4-4934-92af-078354aa29c8 Ancestors: CollectionsTests-nice.339 - added a test case for ReadStream >> #match: =============== Diff against CollectionsTests-nice.339 =============== Item was added: + ----- Method: ReadStreamTest>>testMatch (in category 'tests - testing') ----- + testMatch + + | stream | + stream := ReadStream on: 'foobarbaz'. + self assert: (stream match: 'foo'). + self assert: stream position = 3. + self assert: (stream match: 'baz'). + self assert: stream position = 9. + self assert: stream atEnd. + self assert: (stream match: ''). + self deny: (stream match: 'foo'). + stream reset. + self deny: (stream match: '1'). + self assert: stream atEnd!

1 0

The Trunk: Collections-ul.900.mcz
by commits＠source.squeak.org 29 Jun '20

29 Jun '20

Levente Uzonyi uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ul.900.mcz ==================== Summary ==================== Name: Collections-ul.900 Author: ul Time: 23 June 2020, 10:48:18.28482 pm UUID: ff11e218-b6f4-44db-bd02-2e2284158946 Ancestors: Collections-mt.898 - enable the use of primitive 158 in String >> #compareWith:collated: because when collation is specified, the VM does not use the jitted version - fix: String >> #compare:caseSensitive: needs to transform the return value of String >> #compareWith:collated: - speed up ReadStream >> #match: when the receiver's class is ReadStream =============== Diff against Collections-mt.898 =============== Item was added: + ----- Method: ReadStream>>match: (in category 'positioning') ----- + match: subCollection + "Faster version than the one implemented by super, but due to my subclasses breaking various invariants true for actual ReadStreams, only use it when the receiver's class is ReadStream." + + | matchPosition | + self class == ReadStream ifFalse: [ ^super match: subCollection ]. + subCollection isEmpty ifTrue: [ ^true ]. + matchPosition := collection indexOfSubCollection: subCollection startingAt: position + 1. + matchPosition = 0 ifTrue: [ ^false ]. + matchPosition <= readLimit ifFalse: [ ^false ]. + position := matchPosition + subCollection size - 1. + ^true! Item was changed: ----- Method: String>>compare:caseSensitive: (in category 'comparing') ----- compare: aString caseSensitive: aBool "Answer a comparison code telling how the receiver sorts relative to aString: 1 - before 2 - equal 3 - after. " + | map result | - | map | map := aBool ifTrue:[CaseSensitiveOrder] ifFalse:[CaseInsensitiveOrder]. + result := self compareWith: aString collated: map. + result = 0 ifTrue: [ ^2 ]. + ^result > 0 + ifTrue: [ 3 ] + ifFalse: [ 1 ]! - ^(self compareWith: aString collated: map) + 2! Item was changed: ----- Method: String>>compareWith:collated: (in category 'comparing') ----- compareWith: aString collated: collation + <primitive: 158> - "<primitive: 158>" ^(self compare: self with: aString collated: collation) - 2!

3 2

The Trunk: Collections-ul.901.mcz
by commits＠source.squeak.org 29 Jun '20

29 Jun '20

Levente Uzonyi uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ul.901.mcz ==================== Summary ==================== Name: Collections-ul.901 Author: ul Time: 29 June 2020, 2:08:55.776619 am UUID: 8df577a2-3856-4432-b54c-25c93831b5a8 Ancestors: Collections-ul.900 Fix regression in ReadStream >> #match:. When the subCollection is not present in the receiver, the stream's position must be set to the end to match the original behavior. =============== Diff against Collections-ul.900 =============== Item was changed: ----- Method: ReadStream>>match: (in category 'positioning') ----- match: subCollection "Faster version than the one implemented by super, but due to my subclasses breaking various invariants true for actual ReadStreams, only use it when the receiver's class is ReadStream." | matchPosition | self class == ReadStream ifFalse: [ ^super match: subCollection ]. subCollection isEmpty ifTrue: [ ^true ]. matchPosition := collection indexOfSubCollection: subCollection startingAt: position + 1. + matchPosition = 0 ifTrue: [ + position := readLimit. + ^false ]. - matchPosition = 0 ifTrue: [ ^false ]. matchPosition <= readLimit ifFalse: [ ^false ]. position := matchPosition + subCollection size - 1. ^true!

1 0

2 failures in Tests-Monticello
by Robert Withers 29 Jun '20

29 Jun '20

I am still getting 2 failures with updated image in Tests-Monticello. K, r

3 4

The Inbox: Tests-jr.436.mcz
by commits＠source.squeak.org 28 Jun '20

28 Jun '20

A new version of Tests was added to project The Inbox: http://source.squeak.org/inbox/Tests-jr.436.mcz ==================== Summary ==================== Name: Tests-jr.436 Author: jr Time: 28 June 2020, 10:18:05.236052 pm UUID: 049894aa-5f79-a44d-a2c0-ee65887af7ac Ancestors: Tests-mt.435 Test class definition reading testClassDefinitionFromPseudoClass exposes the traitComposition bug triggered by Collections-ul.900. Monticello-jr.726 is supposed to fix this bug. =============== Diff against Tests-mt.435 =============== Item was added: + ----- Method: MCStReaderTest>>testClassDefinition (in category 'tests') ----- + testClassDefinition + | reader definition | + reader := MCStReader on: 'Object subclass: #NewClass + instanceVariableNames: ''instVar1 instVar2'' + classVariableNames: ''ClassVar1 ClassVar2'' + poolDictionaries: ''Pool1 Pool2'' + category: ''NewCategory''!!' readStream. + definition := reader definitions first. + self assert: definition isClassDefinition; + assert: #NewClass equals: definition className; + assert: #(instVar1 instVar2) equals: definition instVarNames asArray; + assert: #(ClassVar1 ClassVar2) equals: definition classVarNames asArray; + assert: #(Pool1 Pool2) equals: definition poolDictionaries asArray; + assert: 'NewCategory' equals: definition category; + assert: '{}' equals: definition traitCompositionString; + assert: '{}' equals: definition classTraitCompositionString.! Item was added: + ----- Method: MCStReaderTest>>testClassDefinitionFromPseudoClass (in category 'tests') ----- + testClassDefinitionFromPseudoClass + | reader pseudoClass definition | + reader := MCStReader new. + pseudoClass := PseudoClass new + name: #NewClass; + definition: 'Object subclass: #NewClass + instanceVariableNames: ''instVar1 instVar2'' + classVariableNames: ''ClassVar1 ClassVar2'' + poolDictionaries: ''Pool1 Pool2'' + category: ''NewCategory'''; + yourself. + definition := reader classDefinitionFrom: pseudoClass. + self assert: definition isClassDefinition; + assert: #NewClass equals: definition className; + assert: #(instVar1 instVar2) equals: definition instVarNames asArray; + assert: #(ClassVar1 ClassVar2) equals: definition classVarNames asArray; + assert: #(Pool1 Pool2) equals: definition poolDictionaries asArray; + assert: 'NewCategory' equals: definition category; + assert: '{}' equals: definition traitCompositionString; + assert: '{}' equals: definition classTraitCompositionString.!

1 0

The Inbox: Monticello-jr.726.mcz
by commits＠source.squeak.org 28 Jun '20

28 Jun '20

A new version of Monticello was added to project The Inbox: http://source.squeak.org/inbox/Monticello-jr.726.mcz ==================== Summary ==================== Name: Monticello-jr.726 Author: jr Time: 28 June 2020, 10:07:19.980052 pm UUID: e8c6b590-8826-0144-a535-13cfa140b5dd Ancestors: Monticello-mt.725 Fix wrong traitCompositions in packages loaded from source.st As of Collections-ul.900, ReadStream>>match: does not alter the Stream position if the search sequence was not found. Failure to find the search sequence is indicated via the return value, but it was not checked in classDefinitionFrom:. The error could trigger load failures after loading Monticello-jr.720, in which the trait composition became relevant beyond just creating the class. The error did not surface for .mcz version files that contain a correct snapshot.bin file, which allows to forego the reading of the source.st file. There are versions out there without the snapshot.bin file. INIFile-jf.3.mcz as served by Squeaksource is such a version at the moment. =============== Diff against Monticello-mt.725 =============== Item was changed: ----- Method: MCStReader>>classDefinitionFrom: (in category 'converting') ----- classDefinitionFrom: aPseudoClass + | tokens definitionStream hasTraitComposition traitCompositionString lastIndex hasClassTraitComposition classTraitCompositionString typeOfSubclass className | - | tokens traitCompositionString lastIndex classTraitCompositionString typeOfSubclass className | tokens := Scanner new scanTokens: aPseudoClass definition. + definitionStream := ReadStream on: aPseudoClass definition. + hasTraitComposition := definitionStream match: 'uses:'. + traitCompositionString := hasTraitComposition ifTrue: [(definitionStream upToAll: 'instanceVariableNames:') withBlanksTrimmed] ifFalse: ['{}']. + definitionStream := ReadStream on: aPseudoClass metaClass definition asString. + hasClassTraitComposition := definitionStream match: 'uses:'. + classTraitCompositionString := hasClassTraitComposition ifTrue: [(definitionStream upToAll: 'instanceVariableNames:') withBlanksTrimmed] ifFalse: ['{}']. - traitCompositionString := ((ReadStream on: aPseudoClass definition) - match: 'uses:'; - upToAll: 'instanceVariableNames:') withBlanksTrimmed. - classTraitCompositionString := ((ReadStream on: aPseudoClass metaClass definition asString) - match: 'uses:'; - upToAll: 'instanceVariableNames:') withBlanksTrimmed. - traitCompositionString isEmpty ifTrue: [traitCompositionString := '{}']. - classTraitCompositionString isEmpty ifTrue: [classTraitCompositionString := '{}']. lastIndex := tokens size. className := tokens at: 3. typeOfSubclass := self typeOfSubclass: (tokens at: 2). "Compiled code classes are special cases of the #bytes class type" (#bytes == typeOfSubclass and: [self compiledCodeClassNames includes: className]) ifTrue: [typeOfSubclass := #compiledMethod]. ^ MCClassDefinition name: className superclassName: (tokens at: 1) traitComposition: traitCompositionString classTraitComposition: classTraitCompositionString category: (tokens at: lastIndex) instVarNames: ((tokens at: lastIndex - 6) findTokens: ' ') classVarNames: ((tokens at: lastIndex - 4) findTokens: ' ') poolDictionaryNames: ((tokens at: lastIndex - 2) findTokens: ' ') classInstVarNames: (self classInstVarNamesFor: aPseudoClass) type: typeOfSubclass comment: (self commentFor: aPseudoClass) commentStamp: (self commentStampFor: aPseudoClass)!

1 0

The Inbox: ToolBuilder-MVC-ct.60.mcz
by commits＠source.squeak.org 27 Jun '20

27 Jun '20

Christoph Thiede uploaded a new version of ToolBuilder-MVC to project The Inbox: http://source.squeak.org/inbox/ToolBuilder-MVC-ct.60.mcz ==================== Summary ==================== Name: ToolBuilder-MVC-ct.60 Author: ct Time: 27 June 2020, 10:37:01.784959 pm UUID: dd09ecec-d16e-854c-8564-d21576eb58fc Ancestors: ToolBuilder-MVC-mt.59 Don't fail in MVCToolBuilder when opening a menu The semantics of ToolBuilder >> #open: are to work regardless of the build state of the passed object (thus "anObject"). As a consequence, [MVCToolBuilder new open: (MVCToolBuilder new build: PluggableMenuSpec new)] should work, too. =============== Diff against ToolBuilder-MVC-mt.59 =============== Item was changed: ----- Method: MVCToolBuilder>>open: (in category 'opening') ----- open: anObject "Build and open the object. Answer the widget opened." | window | + window := (anObject isKindOf: View orOf: PopUpMenu) - window := (anObject isKindOf: View) ifTrue: [anObject] ifFalse: [self build: anObject]. (window isKindOf: PopUpMenu) ifTrue: [window invokeOn: nil]. (window isKindOf: View) ifTrue: [window controller open]. ^window!

1 0

The Inbox: ToolBuilder-Kernel-ct.140.mcz
by commits＠source.squeak.org 27 Jun '20

27 Jun '20

A new version of ToolBuilder-Kernel was added to project The Inbox: http://source.squeak.org/inbox/ToolBuilder-Kernel-ct.140.mcz ==================== Summary ==================== Name: ToolBuilder-Kernel-ct.140 Author: ct Time: 27 June 2020, 10:27:56.320705 pm UUID: 41f2d454-481e-354d-9b19-6a275ef01e56 Ancestors: ToolBuilder-Kernel-mt.138 Don't fail in PluggableMenuSpec when building an empty menu =============== Diff against ToolBuilder-Kernel-mt.138 =============== Item was changed: ----- Method: PluggableMenuSpec>>analyzeItemLabels (in category 'construction') ----- analyzeItemLabels "Analyze the item labels" + self items do: [:item | item analyzeLabel].! - items do:[:item| item analyzeLabel]. - !

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
35
Older →

Jump to page: