Squeak-dev June 2020

squeak-dev@lists.squeakfoundation.org

43 participants
347 discussions

[ANN] TruffleSqueak 20.1.0 released
by Fabio Niephaus 22 Jun '20

22 Jun '20

Hi all, I'd like to officially announce the first stable release of TruffleSqueak [1], a Squeak/Smalltalk VM and Polyglot Programming Environment for the GraalVM [2]. As some of you know, we at HPI [3] have been working on this for quite a while and open-sourced it a few weeks after our presentation at ESUG'19 [4]. The virtual machine is implemented in Truffle [5], GraalVM's Java-based language implementation framework. The image has direct access to GraalVM's language interoperability protocol [6] and based on this, we have adapted the workspace and inspection tools so that they work consistently for objects from Javascript, Python, R, Ruby, and all other languages supported by GraalVM. In addition, the image comes with our polyglot notebook system [7] and a polyglot code editor [8]. You may also find our paper on TruffleSqueak (formerly GraalSqueak) [9] and our blog post on "Smalltalk with the GraalVM" [10] an interesting read. Nonetheless, please keep in mind that TruffleSqueak is a research project, so there will be bugs (please report them at [11]) and things left to do (feedback is welcome!). You can follow TruffleSqueak on Twitter [12] for more updates. On June 24, I'm also going to talk about TruffleSqueak in the UK Smalltalk User Group meeting [13], and you are invited to join us. Lastly, I’d like to thank everyone who has contributed to TruffleSqueak and I'm excited to see what you’re going to do with it. Fabio [1] https://github.com/hpi-swa/trufflesqueak [2] https://www.graalvm.org [3] https://hpi.de/swa [4] https://www.youtube.com/watch?v=FAk3Ec8hmzk [5] https://github.com/oracle/graal/tree/master/truffle [6] https://www.graalvm.org/truffle/javadoc/com/oracle/truffle/api/interop/Inte… [7] https://doi.org/10.1145/3328433.3328434 [8] https://medium.com/graalvm/hpi-polyglot-programming-seminar-3fd06ffa59d2 [9] https://doi.org/10.1145/3357390.3361024 [10] https://www.javaadvent.com/2019/12/smalltalk-with-the-graalvm.html [11] https://github.com/hpi-swa/trufflesqueak/issues [12] https://twitter.com/TruffleSqueak/ [13] https://www.meetup.com/UKSTUG/events/cbklbrybcjbgc/

6 21

The Inbox: WebClient-Core-ul.122.mcz
by commits＠source.squeak.org 21 Jun '20

21 Jun '20

Levente Uzonyi uploaded a new version of WebClient-Core to project The Inbox: http://source.squeak.org/inbox/WebClient-Core-ul.122.mcz ==================== Summary ==================== Name: WebClient-Core-ul.122 Author: ul Time: 21 June 2020, 10:38:13.218064 pm UUID: bdff4473-51a4-4b1a-9836-70fba261bcaa Ancestors: WebClient-Core-tobe.121 WebMessage >> #streamDirectlyFrom:to:size:progress: - avoid infinite loop when there are fewer bytes available than specified - fix progress notifications - avoid unnecessary buffer copying WebMessage: - use #contentType: and #contentLength: methods to set the corresponding headers to avoid string duplication =============== Diff against WebClient-Core-tobe.121 =============== Item was changed: ----- Method: WebClient>>httpPost:content:type:do: (in category 'methods') ----- httpPost: urlString content: postData type: contentType do: aBlock "POST the data to the given url" | request | self initializeFromUrl: urlString. request := self requestWithUrl: urlString. request method: 'POST'. + contentType ifNotNil:[request contentType: contentType]. + request contentLength: postData size. - contentType ifNotNil:[request headerAt: 'Content-Type' put: contentType]. - request headerAt: 'Content-Length' put: postData size. userAgent ifNotNil:[request headerAt: 'User-Agent' put: userAgent]. aBlock value: request. ^self sendRequest: request content: postData readStream size: postData size! Item was changed: ----- Method: WebClient>>httpPostChunked:content:type:do: (in category 'methods') ----- httpPostChunked: urlString content: chunkBlock type: contentType do: aBlock "POST the data to the given url using chunked transfer-encoding. The chunkBlock takes a request and can be fed using #nextChunkPut: until all the data has been sent. Chunked encoding can be used for long-lasting connections to a server, but care must be taken to ensure that the client isn't running afoul of the server expecting to read the full response (i.e., you should use this only if you have control over both ends). However, it is a great way to send output from commands that take awhile and other time-consuming operations if authentication has been handled." | request | self initializeFromUrl: urlString. request := self requestWithUrl: urlString. request method: 'POST'. + contentType ifNotNil:[request contentType: contentType]. - contentType ifNotNil:[request headerAt: 'Content-Type' put: contentType]. request headerAt: 'Transfer-Encoding' put: 'chunked'. userAgent ifNotNil:[request headerAt: 'User-Agent' put: userAgent]. aBlock value: request. "Send the chunked data" ^self sendRequest: request contentBlock:[:aStream| "Set the stream in the request and pass it in the chunk block" request stream: aStream. chunkBlock value: request. "send termination chunk" aStream nextPutAll: '0'; crlf; crlf; flush. ]. ! Item was changed: ----- Method: WebClient>>httpPut:content:type:do: (in category 'methods') ----- httpPut: urlString content: postData type: contentType do: aBlock "PUT the data to the given url" | request | self initializeFromUrl: urlString. request := self requestWithUrl: urlString. request method: 'PUT'. + contentType ifNotNil:[request contentType: contentType]. + request contentLength: postData size. - contentType ifNotNil:[request headerAt: 'Content-Type' put: contentType]. - request headerAt: 'Content-Length' put: postData size. userAgent ifNotNil:[request headerAt: 'User-Agent' put: userAgent]. aBlock value: request. ^self sendRequest: request content: postData readStream size: postData size! Item was changed: ----- Method: WebMessage>>streamDirectlyFrom:to:size:progress: (in category 'streaming') ----- streamDirectlyFrom: srcStream to: dstStream size: sizeOrNil progress: progressBlock "Stream the content of srcStream to dstStream. + If a size is given, try to stream that many elements. It's the senders responsibility to verify that enough bytes were read. If no size is given, stream all available data." - If a size is given, stream that many elements, otherwise stream up to the end." + | buffer bufferSize totalBytesRead bytesInBuffer | - | buffer remaining size totalRead | sizeOrNil = 0 ifTrue:[^self]. + bufferSize := 4096. + buffer := (srcStream isBinary ifTrue:[ByteArray] ifFalse:[String]) new: bufferSize. + totalBytesRead := 0. + [ + progressBlock ifNotNil:[ progressBlock value: sizeOrNil value: totalBytesRead ]. + srcStream atEnd or: [ sizeOrNil notNil and: [ totalBytesRead >= sizeOrNil ]] ] + whileFalse: [ + bytesInBuffer := srcStream + readInto: buffer + startingAt: 1 + count: (sizeOrNil + ifNil: [ bufferSize ] + ifNotNil: [ sizeOrNil - totalBytesRead min: bufferSize ]). + dstStream next: bytesInBuffer putAll: buffer startingAt: 1. + totalBytesRead := totalBytesRead + bytesInBuffer ]. + dstStream flush! - - buffer := (srcStream isBinary ifTrue:[ByteArray] ifFalse:[String]) new: 4096. - totalRead := 0. - size := sizeOrNil ifNil:[0]. - [(sizeOrNil == nil and:[srcStream atEnd not]) or:[totalRead < size]] whileTrue:[ - progressBlock ifNotNil:[progressBlock value: sizeOrNil value: totalRead]. - remaining := sizeOrNil ifNil:[99999] ifNotNil:[sizeOrNil - totalRead]. - remaining > buffer size ifTrue:[remaining := buffer size]. - buffer := srcStream next: remaining into: buffer startingAt: 1. - dstStream nextPutAll: (remaining < buffer size - ifTrue:[(buffer copyFrom: 1 to: remaining)] - ifFalse:[buffer]). - totalRead := totalRead + buffer size. - ]. - dstStream flush. - progressBlock ifNotNil:[progressBlock value: sizeOrNil value: totalRead].! Item was changed: ----- Method: WebRequest>>send200Response:contentType:do: (in category 'responses') ----- send200Response: aString contentType: contentType do: aBlock "Send a 200 OK response" | resp | resp := self newResponse protocol: 'HTTP/1.1' code: 200. + resp contentType: contentType. - resp headerAt: 'Content-Type' put: contentType. aBlock value: resp. ^self sendResponse: resp content: aString.! Item was changed: ----- Method: WebRequest>>send404Response: (in category 'responses') ----- send404Response: body "Send a 404 not found response" ^self send404Response: (body convertToWithConverter: UTF8TextConverter new) + do: [ :resp | resp contentType: 'text/html; charset=utf-8' ]! - do: [ :resp | resp headerAt: 'Content-Type' put: 'text/html; charset=utf-8' ]! Item was changed: ----- Method: WebRequest>>send404Response:do: (in category 'responses') ----- send404Response: body do: aBlock "Send a 404 not found response" | resp | resp := self newResponse protocol: 'HTTP/1.1' code: 404. + resp contentType: 'text/html; charset=utf-8'. - resp headerAt: 'Content-Type' put: 'text/html; charset=utf-8'. aBlock value: resp. ^self sendResponse: resp content: body. ! Item was changed: ----- Method: WebRequest>>send405Response:content: (in category 'responses') ----- send405Response: allowed content: body "Send a 405 method not allowed response" | resp | resp := self newResponse protocol: 'HTTP/1.1' code: 405. + resp contentType: 'text/html; charset=utf-8'. - resp headerAt: 'Content-Type' put: 'text/html; charset=utf-8'. resp headerAt: 'allow' put: (String streamContents:[:s| allowed do:[:m| s nextPutAll: m] separatedBy:[s nextPut: $,] ]). ^self sendResponse: resp content: body.! Item was changed: ----- Method: WebRequest>>sendResponse:contentStream:size: (in category 'sending') ----- sendResponse: resp contentStream: aStream size: streamSize "Sends a WebResponse, streaming its contents from aStream. If a size is provided, insert a Content-Length header, otherwise ensure that the connection is transient." streamSize ifNil:[self headerAt: 'Connection' put: 'close'] "mark transient" + ifNotNil:[resp contentLength: streamSize]. - ifNotNil:[resp headerAt: 'Content-Length' put: streamSize]. ^self sendResponse: resp contentBlock:[:sockStream| resp streamFrom: aStream to: sockStream size: streamSize progress: nil ]! Item was changed: ----- Method: WebRequest>>sendResponseCode:content:type:do: (in category 'responses') ----- sendResponseCode: code content: aString type: contentType do: aBlock "Send a 500 Internal server error response" | resp | resp := self newResponse protocol: 'HTTP/1.1' code: code. + contentType ifNotNil:[resp contentType: contentType]. - contentType ifNotNil:[resp headerAt: 'Content-Type' put: contentType]. aBlock value: resp. ^self sendResponse: resp content: aString.! Item was changed: ----- Method: WebRequest>>stream200Response:size:type:do: (in category 'responses') ----- stream200Response: aStream size: streamSize type: contentType do: aBlock "Stream a 200 OK response" | resp | resp := self newResponse protocol: 'HTTP/1.1' code: 200. + resp contentType: contentType. - resp headerAt: 'Content-Type' put: contentType. aBlock value: resp. ^self sendResponse: resp contentStream: aStream size: streamSize.! Item was changed: ----- Method: WebServer class>>browseFile:request: (in category 'examples') ----- browseFile: file request: request "Responds with a file back to the original request" | fileSize mimeTypes resp | file binary. fileSize := file size. mimeTypes := file mimeTypes ifNil:[#('application/octet-stream')]. resp := request newResponse protocol: 'HTTP/1.1' code: 200. + resp contentType: mimeTypes first. - resp headerAt: 'Content-Type' put: mimeTypes first. request sendResponse: resp contentStream: file size: fileSize.! Item was changed: ----- Method: WebServer>>authenticate:realm:methods:do: (in category 'authentication') ----- authenticate: request realm: realm methods: accepted do: aBlock "Authenticates an incoming request using one of the accepted methods. Evaluates aBlock upon successful authentication. Responds with a 401 (Unauthorized) if the authentication fails." | method resp | request headersAt: 'Authorization' do:[:authHeader| method := authHeader copyUpTo: Character space. (accepted anySatisfy:[:auth| auth sameAs: method]) ifTrue:[ (self authAccept: method request: request realm: realm header: authHeader) ifTrue:[^aBlock value]. ]. ]. "Send a 401 (unauthorized) response" resp := request newResponse protocol: 'HTTP/1.1' code: 401. + resp contentType: 'text/html; charset=utf-8'. - resp headerAt: 'Content-Type' put: 'text/html; charset=utf-8'. accepted do:[:auth| | hdr | hdr := self authHeader: auth request: request realm: realm. hdr ifNotNil:[resp addHeader: 'WWW-Authenticate' value: hdr]. ]. request sendResponse: resp content: '<html><head><title>401 Unauthorized</title></head><body><h1>401 Unauthorized</h1><p>You are not authorized to access the requested URL</p></body></html>'. !

1 0

The Trunk: WebClient-Tests-ul.60.mcz
by commits＠source.squeak.org 21 Jun '20

21 Jun '20

Levente Uzonyi uploaded a new version of WebClient-Tests to project The Trunk: http://source.squeak.org/trunk/WebClient-Tests-ul.60.mcz ==================== Summary ==================== Name: WebClient-Tests-ul.60 Author: ul Time: 21 June 2020, 10:41:01.553461 pm UUID: f295c74c-8e63-487d-aa28-db2210c9b776 Ancestors: WebClient-Tests-nice.59 - added WebMessageTest with test cases covering WebMessage >> #streamDirectlyFrom: to: size: progress: =============== Diff against WebClient-Tests-nice.59 =============== Item was added: + TestCase subclass: #WebMessageTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'WebClient-Tests'! Item was added: + ----- Method: WebMessageTest>>testStreamDirectlyFromToSizeProgressWhenSizeIsNotSpecified (in category 'tests') ----- + testStreamDirectlyFromToSizeProgressWhenSizeIsNotSpecified + + | message | + message := WebMessage new. + { + ByteArray. #yourself. + ByteString. #asString + } groupsDo: [ :bufferClass :byteArrayToBufferClassConverterSelector | + | maxSize source destination progressData totalRead | + maxSize := 10000. "Should be greater than the buffer size used by #streamDirectlyFrom:to:size:progress:" + source := ((ByteArray new: maxSize streamContents: [ :stream | + 1 to: maxSize do: [ :i | stream nextPut: (i bitAnd: 16rFF) ] ]) perform: byteArrayToBufferClassConverterSelector) readStream. + destination := (bufferClass new: maxSize) writeStream. + progressData := OrderedCollection new. + 0 to: maxSize do: [ :bytesToStream | + totalRead := 0. + source position: maxSize - bytesToStream. + destination originalContents from: 1 to: destination position put: (bufferClass == ByteArray ifTrue: [ 0 ] ifFalse: [ Character value: 0 ]). + destination resetToStart. + progressData reset. + message + streamDirectlyFrom: source + to: destination + size: nil + progress: [ :size :bytesRead | + self assert: nil equals: size description: 'Progress block''s first argument should be the requested size - in this case nil'. + progressData add: bytesRead ]. + bytesToStream > 0 + ifTrue: [ + self assert: progressData notEmpty description: 'Missing progress data.'. + self assert: 0 equals: progressData first description: 'First progress data should report 0 size.'. + self assert: bytesToStream equals: progressData last description: 'Last progress data should be the number of bytes streamed'. + self assert: progressData isSorted description: 'Progress data should be monotonic' ] + ifFalse: [ + self assert: (progressData isEmpty or: [ progressData size = 1 and: [ progressData first = 0 ] ]) description: 'Unexpected progress data' ]. + self assert: bytesToStream equals: destination position description: 'All bytes should be streamed'. + 1 to: bytesToStream do: [ :i | + (destination originalContents at: i) = (source originalContents at: maxSize - bytesToStream + i) ifFalse: [ "This comparison is the same as the next assertion but it's significantly cheaper." + self assert: (source originalContents at: maxSize - bytesToStream + i) equals: (destination originalContents at: i) description: 'Copied data doesn''t match source.' ] ] ] ]! Item was added: + ----- Method: WebMessageTest>>testStreamDirectlyFromToSizeProgressWhenSizeIsSpecified (in category 'tests') ----- + testStreamDirectlyFromToSizeProgressWhenSizeIsSpecified + <timeout: 20> + + | message | + message := WebMessage new. + { + ByteArray. #yourself. + ByteString. #asString + } groupsDo: [ :bufferClass :byteArrayToBufferClassConverterSelector | + | maxSize source destination progressData totalRead | + maxSize := 10000. "Should be greater than the buffer size used by #streamDirectlyFrom:to:size:progress:" + source := ((ByteArray new: maxSize streamContents: [ :stream | + 1 to: maxSize do: [ :i | stream nextPut: (i bitAnd: 16rFF) ] ]) perform: byteArrayToBufferClassConverterSelector) readStream. + destination := (bufferClass new: maxSize) writeStream. + progressData := OrderedCollection new. + 0 to: maxSize + 1 do: [ :bytesToStream | + totalRead := 0. + source reset. + destination resetToStart. + destination originalContents from: 1 to: destination position put: (bufferClass == ByteArray ifTrue: [ 0 ] ifFalse: [ Character value: 0 ]). + progressData reset. + message + streamDirectlyFrom: source + to: destination + size: bytesToStream + progress: [ :size :bytesRead | + self assert: bytesToStream equals: size description: 'Progress block''s first argument should be the requested size'. + progressData add: bytesRead ]. + bytesToStream > 0 + ifTrue: [ + self assert: 0 equals: progressData first description: 'First progress data should report 0 size.'. + self assert: (bytesToStream min: maxSize) equals: progressData last description: 'Last progress data should be the minimum of the number of bytes available and the number of bytes requested'. + self assert: progressData isSorted description: 'Progress data should be monotonic' ] + ifFalse: [ + self assert: (progressData isEmpty or: [ progressData size = 1 and: [ progressData first = 0 ] ]) ]. + self assert: (bytesToStream min: maxSize) equals: destination position description: 'Last progress data should be the number of bytes read'. + 1 to: destination position do: [ :i | + (destination originalContents at: i) = (source originalContents at: i) ifFalse: [ "This comparison is the same as the next assertion but it's significantly cheaper." + self assert: (source originalContents at: maxSize - bytesToStream + i) equals: (destination originalContents at: i) description: 'Copied data doesn''t match source.' ] ] ] ]!

1 0

FFI Inbox: FFI-Tests-nice.22.mcz
by commits＠source.squeak.org 21 Jun '20

21 Jun '20

Nicolas Cellier uploaded a new version of FFI-Tests to project FFI Inbox: http://source.squeak.org/FFIinbox/FFI-Tests-nice.22.mcz ==================== Summary ==================== Name: FFI-Tests-nice.22 Author: nice Time: 21 June 2020, 10:39:31.548387 pm UUID: 6cc5d336-7a73-402b-8409-ae6de4d03dd1 Ancestors: FFI-Tests-mt.21 Fix testIntAliasCall by calling the version that answers an int, not an IntAlias. Fix testPointers - at least for the experimental FFI branch https://github.com/OpenSmalltalk/opensmalltalk-vm/tree/experimental_FFI This version of FFI does not return an ExternalStructure when we return a pointer. It returns an ExternalData! This is logical, we have no idea if the function returns a pointer to a single struct or to a whole array. =============== Diff against FFI-Tests-mt.21 =============== Item was changed: ----- Method: FFIPluginTests>>testIntAliasCall (in category 'tests - type alias') ----- testIntAliasCall | result | result := FFITestLibrary + ffiTest4IntAliasSum: (FFITestIntAlias fromHandle: 1) - ffiTestIntAlias4IntSum: (FFITestIntAlias fromHandle: 1) with: (FFITestIntAlias fromHandle: 2) with: (FFITestIntAlias fromHandle: 3) with: (FFITestIntAlias fromHandle: 4). self assert: 10 equals: result.! Item was changed: ----- Method: FFIPluginTests>>testPointers (in category 'tests - structure') ----- testPointers "Test passing and returning of pointers to structs" + | pt1 pt2 pt3 p3ptr | - | pt1 pt2 pt3 | pt1 := FFITestPoint4 new. pt1 x: 1. pt1 y: 2. pt1 z: 3. pt1 w: 4. pt2 := FFITestPoint4 new. pt2 x: 5. pt2 y: 6. pt2 z: 7. pt2 w: 8. + p3ptr := FFITestLibrary ffiTestPointers: pt1 with: pt2. + pt3 := p3ptr at: 1. - pt3 := FFITestLibrary ffiTestPointers: pt1 with: pt2. self assert: pt3 x = 6. self assert: pt3 y = 8. self assert: pt3 z = 10. self assert: pt3 w = 12.!

1 0

Directory name sorting in file list and file chooser/saver dialogues
by tim Rowledge 21 Jun '20

21 Jun '20

I've not made a lot of use of the filelist in a long time but recently it seems to be something I need more frequently. It was bugging me for some reason and I finally realised why - the directory tree isn't sorting subdirectories alphabetically - they're just random (presumably strictly speaking in order of unix file node number of linkage or whatever) and that makes finding stuff surprisingly hard. The file dialogues are sorted but... There's an easy fix but there is also a UI issue; sort by strict ASCII type sort or by case-ignore ASCII? I prefer case-ignore but I suspect that isn't universal. So, before I commit something, chime in about your preferences. I'd really prefer not to add yet another preference - we have orders of magnitude too many - but if it is really neccessary... And I suppose there may be some issue about hidden files too. Your hate mail will be graded. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim May the bugs of many programs nest on your hard drive.

3 5

The Trunk: Collections-mt.898.mcz
by commits＠source.squeak.org 21 Jun '20

21 Jun '20

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-mt.898.mcz ==================== Summary ==================== Name: Collections-mt.898 Author: mt Time: 16 June 2020, 8:55:38.416917 am UUID: 89207449-befb-f84f-83a0-ff0d727d40bc Ancestors: Collections-mt.896, Collections-ul.897 Merges ancestry. Does somebody know where to find Collections-ul.896? =============== Diff against Collections-mt.896 =============== Item was removed: - ----- Method: ByteArray>>atAllPut: (in category 'accessing') ----- - atAllPut: value - "Fill the receiver with the given value" - - <primitive: 145> - super atAllPut: value! Item was changed: ----- Method: String>>< (in category 'comparing') ----- < aString "Answer whether the receiver sorts before aString. The collation order is simple ascii (with case differences)." + ^(self compareWith: aString) < 0! - ^ (self compare: self with: aString collated: AsciiOrder) = 1! Item was changed: ----- Method: String>><= (in category 'comparing') ----- <= aString "Answer whether the receiver sorts before or equal to aString. The collation order is simple ascii (with case differences)." + ^(self compareWith: aString) <= 0! - ^ (self compare: self with: aString collated: AsciiOrder) <= 2! Item was changed: ----- Method: String>>= (in category 'comparing') ----- = aString "Answer whether the receiver sorts equally as aString. The collation order is simple ascii (with case differences)." self == aString ifTrue: [ ^true ]. aString isString ifFalse: [ ^false ]. self size = aString size ifFalse: [ ^false ]. + ^ (self compareWith: aString) = 0! - ^ (self compare: self with: aString collated: AsciiOrder) = 2! Item was changed: ----- Method: String>>> (in category 'comparing') ----- > aString "Answer whether the receiver sorts after aString. The collation order is simple ascii (with case differences)." + ^(self compareWith: aString) > 0! - ^ (self compare: self with: aString collated: AsciiOrder) = 3! Item was changed: ----- Method: String>>>= (in category 'comparing') ----- >= aString "Answer whether the receiver sorts after or equal to aString. The collation order is simple ascii (with case differences)." + ^(self compareWith: aString) >= 0! - ^ (self compare: self with: aString collated: AsciiOrder) >= 2! Item was changed: ----- Method: String>>compare:caseSensitive: (in category 'comparing') ----- compare: aString caseSensitive: aBool "Answer a comparison code telling how the receiver sorts relative to aString: 1 - before 2 - equal 3 - after. " | map | map := aBool ifTrue:[CaseSensitiveOrder] ifFalse:[CaseInsensitiveOrder]. + ^(self compareWith: aString collated: map) + 2! - ^self compare: self with: aString collated: map! Item was added: + ----- Method: String>>compareWith: (in category 'comparing') ----- + compareWith: aString + + "<primitive: 158>" + ^(self compare: self with: aString collated: AsciiOrder) - 2! Item was added: + ----- Method: String>>compareWith:collated: (in category 'comparing') ----- + compareWith: aString collated: collation + + "<primitive: 158>" + ^(self compare: self with: aString collated: collation) - 2! Item was removed: - ----- Method: WeakIdentityDictionary>>cleanupIndex: (in category 'private') ----- - cleanupIndex: anInteger - array at: anInteger put: vacuum. - tally := tally - 1. - self fixCollisionsFrom: anInteger.! Item was changed: ----- Method: WeakIdentityDictionary>>fixCollisionsFrom: (in category 'private') ----- fixCollisionsFrom: start "The element at start has been removed and replaced by vacuum. This method moves forward from there, relocating any entries that had been placed below due to collisions with this one." | element index | index := start. [ (element := array at: (index := index \\ array size + 1)) == vacuum ] whileFalse: [ element ifNil: [ "The binding at this slot was reclaimed - finish the cleanup" array at: index put: vacuum. tally := tally - 1 ] ifNotNil: [| newIndex | + (newIndex := self scanFor: element key) = index ifFalse: [ - (newIndex := self scanWithoutGarbagingFor: element key) = index ifFalse: [ array at: newIndex put: element; at: index put: vacuum ] ] ]! Item was changed: ----- Method: WeakIdentityDictionary>>removeKey:ifAbsent: (in category 'removing') ----- removeKey: key ifAbsent: aBlock "Remove key (and its associated value) from the receiver. If key is not in the receiver, answer the result of evaluating aBlock. Otherwise, answer the value externally named by key." | index association | index := self scanFor: key. (association := (array at: index)) == vacuum ifTrue: [ ^aBlock value ]. + array at: index put: vacuum. + tally := tally - 1. + self fixCollisionsFrom: index. - self cleanupIndex: index. ^association value! Item was changed: ----- Method: WeakIdentityDictionary>>scanFor: (in category 'private') ----- scanFor: anObject "Scan the array for the first slot containing either - a vacuum object indicating an empty slot - or a binding whose key matches anObject. + Answer the index of that slot or raise an error if no slot is found which should never happen." - Answer the index of that slot or raise an error if no slot is found. - When garbage collected slots are encountered, perform a clean-up." + | index start size | + index := start := anObject scaledIdentityHash \\ (size := array size) + 1. + [ + (array at: index) ifNotNil: [ :element | + (element == vacuum or: [ element key == anObject ]) + ifTrue: [ ^index ] ]. + (index := index \\ size + 1) = start ] whileFalse. - | index start rescan | - [ - rescan := false. - index := start := anObject scaledIdentityHash \\ array size + 1. - [ - (array at: index) - ifNil: - ["Object at this slot has been garbage collected. - A rescan is necessary because fixing collisions - might have moved the target before current index." - self cleanupIndex: index. - rescan := true] - ifNotNil: - [:element | (element == vacuum or: [ element key == anObject ]) - ifTrue: [ ^index ]. - (index := index \\ array size + 1) = start ] ] whileFalse. - rescan ] whileTrue. self errorNoFreeSpace! Item was changed: ----- Method: WeakIdentityDictionary>>scanForEmptySlotFor: (in category 'private') ----- scanForEmptySlotFor: anObject + "Scan the array for the first empty slot marked by vacuum object or nil. + Answer the index of that slot or raise an error if no slot is found, which should never happen." - "Scan the array for the first empty slot marked by vacuum object. - Answer the index of that slot or raise an error if no slot is found. - Ignore the slots that have been garbage collected (those containing nil)." | index start | index := start := anObject scaledIdentityHash \\ array size + 1. [ + | element | + ((element := array at: index) == vacuum or: [ element == nil ]) ifTrue: [ ^index ]. - (array at: index) - ifNotNil: - [:element | element == vacuum ifTrue: [ ^index ] ]. (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was removed: - ----- Method: WeakIdentityDictionary>>scanWithoutGarbagingFor: (in category 'private') ----- - scanWithoutGarbagingFor: anObject - "Scan the array for the first slot containing either - - a vacuum object indicating an empty slot - - or a binding whose key matches anObject. - Answer the index of that slot or raise an error if no slot is found. - Ignore the slots that have been garbage collected (those containing nil)" - - | index start | - index := start := anObject scaledIdentityHash \\ array size + 1. - [ - (array at: index) - ifNotNil: - [:element | (element == vacuum or: [ element key == anObject ]) - ifTrue: [ ^index ] ]. - (index := index \\ array size + 1) = start ] whileFalse. - self errorNoFreeSpace!

5 6

FFI: FFI-Win32-nice.20.mcz
by commits＠source.squeak.org 20 Jun '20

20 Jun '20

Nicolas Cellier uploaded a new version of FFI-Win32 to project FFI: http://source.squeak.org/FFI/FFI-Win32-nice.20.mcz ==================== Summary ==================== Name: FFI-Win32-nice.20 Author: nice Time: 20 June 2020, 9:52:22.045086 pm UUID: e133cbfa-42f8-4502-a685-5f0e4d29cb7b Ancestors: FFI-Win32-mt.19 Let Win32Handle be an ExternalTypeAlias. Nuke the *autogenerated fields. =============== Diff against FFI-Win32-mt.19 =============== Item was changed: + ExternalTypeAlias subclass: #Win32Handle - ExternalStructure subclass: #Win32Handle instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'FFI-Win32-Examples'! Item was removed: - ----- Method: Win32Handle class>>fields (in category 'accessing') ----- - fields - "Win32Handle defineFields" - "The following really means - typedef void* Win32Handle; - " - ^ #(nil 'uintptr_t')! Item was added: + ----- Method: Win32Handle class>>originalTypeName (in category 'accessing') ----- + originalTypeName + "Win32Handle defineFields" + "The following really means + typedef void* Win32Handle; + " + ^ 'uintptr_t'! Item was removed: - ----- Method: Win32Point>>x (in category 'accessing') ----- - x - "This method was automatically generated. See Win32Point class>>fields." - <generated> - ^handle signedLongAt: 1! Item was removed: - ----- Method: Win32Point>>x: (in category 'accessing') ----- - x: anInteger - "This method was automatically generated. See Win32Point class>>fields." - <generated> - handle signedLongAt: 1 put: anInteger! Item was removed: - ----- Method: Win32Point>>y (in category 'accessing') ----- - y - "This method was automatically generated. See Win32Point class>>fields." - <generated> - ^handle signedLongAt: 5! Item was removed: - ----- Method: Win32Point>>y: (in category 'accessing') ----- - y: anInteger - "This method was automatically generated. See Win32Point class>>fields." - <generated> - handle signedLongAt: 5 put: anInteger! Item was removed: - ----- Method: Win32Rectangle>>bottom (in category 'accessing') ----- - bottom - "This method was automatically generated. See Win32Rectangle class>>fields." - <generated> - ^handle signedLongAt: 13! Item was removed: - ----- Method: Win32Rectangle>>bottom: (in category 'accessing') ----- - bottom: anInteger - "This method was automatically generated. See Win32Rectangle class>>fields." - <generated> - handle signedLongAt: 13 put: anInteger! Item was removed: - ----- Method: Win32Rectangle>>left (in category 'accessing') ----- - left - "This method was automatically generated. See Win32Rectangle class>>fields." - <generated> - ^handle signedLongAt: 1! Item was removed: - ----- Method: Win32Rectangle>>left: (in category 'accessing') ----- - left: anInteger - "This method was automatically generated. See Win32Rectangle class>>fields." - <generated> - handle signedLongAt: 1 put: anInteger! Item was removed: - ----- Method: Win32Rectangle>>right (in category 'accessing') ----- - right - "This method was automatically generated. See Win32Rectangle class>>fields." - <generated> - ^handle signedLongAt: 9! Item was removed: - ----- Method: Win32Rectangle>>right: (in category 'accessing') ----- - right: anInteger - "This method was automatically generated. See Win32Rectangle class>>fields." - <generated> - handle signedLongAt: 9 put: anInteger! Item was removed: - ----- Method: Win32Rectangle>>top (in category 'accessing') ----- - top - "This method was automatically generated. See Win32Rectangle class>>fields." - <generated> - ^handle signedLongAt: 5! Item was removed: - ----- Method: Win32Rectangle>>top: (in category 'accessing') ----- - top: anInteger - "This method was automatically generated. See Win32Rectangle class>>fields." - <generated> - handle signedLongAt: 5 put: anInteger!

1 0

Showing hands
by Thiede, Christoph 20 Jun '20

20 Jun '20

Hi all, did you know the implementation of HandMorph >> #visible:? visible: aBoolean self needsToBeDrawn ifFalse: [ ^self ]. super visible: aBoolean This is just bothering me as I am trying to hide my hand before I attach some morph to it, so it does not yet need to be drawn. Is this logic anywhere in use? I already have played with #needsToBeDrawn in the past (remember XmasDecorations? ;)), and it should be a protocol between WorldState and HandMorph, only. But I cannot find any affected sender of #visible: in WorldState; the only one is #restoreMorphicDisplay which does not relate to #needsToBeDrawn as far as I can see. Do you think we can nuke this override? Best, Christoph

2 2

The Inbox: CommandLine-TheresaHMartenK.17.mcz
by commits＠source.squeak.org 20 Jun '20

20 Jun '20

A new version of CommandLine was added to project The Inbox: http://source.squeak.org/inbox/CommandLine-TheresaHMartenK.17.mcz ==================== Summary ==================== Name: CommandLine-TheresaHMartenK.17 Author: TheresaHMartenK Time: 20 June 2020, 4:33:21.503561 pm UUID: 1e990100-46c5-7b4a-966c-d1908837d2ca Ancestors: CommandLine-mt.16 Same reason as: ToolBuilder-Morphic-TheresaHMartenK.261 Copy: The current implementation searches for the supplied answer in the valueList and if found returns the value at the found index in the valueList which of course is the supplied answer. However from the behaviour that gets mimicked you would expect the implementation to look for the suppliedAnswer in the labelList - the same as you click on the label and not on its connected value. Additionally this produces less readable / understandable code compared to supplying the label, especially if the value happens to be a block. With the new implementation, the answer is searched in the labelList, and the returned value is the coresponding value from the valueList. =============== Diff against CommandLine-mt.16 =============== Item was changed: ----- Method: DummyUIManager>>chooseFrom:values:lines:title: (in category 'ui requests') ----- chooseFrom: labelList values: valueList lines: linesArray title: aString self askForProvidedAnswerTo: aString ifSupplied: [:answer | (answer = #cancel or: [answer isNil]) ifTrue: [^ nil]. + ^ valueList at: (labelList indexOf: answer) ifAbsent: [ - ^ valueList at: (valueList indexOf: answer) ifAbsent: [ answer isNumber ifTrue: [valueList at: answer ifAbsent: [nil]] ifFalse: [nil]]]. ^ valueList first!

1 0

The Inbox: ToolBuilder-MVC-TheresaHMartenK.60.mcz
by commits＠source.squeak.org 20 Jun '20

20 Jun '20

A new version of ToolBuilder-MVC was added to project The Inbox: http://source.squeak.org/inbox/ToolBuilder-MVC-TheresaHMartenK.60.mcz ==================== Summary ==================== Name: ToolBuilder-MVC-TheresaHMartenK.60 Author: TheresaHMartenK Time: 20 June 2020, 4:32:44.419561 pm UUID: ce7849e7-d47c-434e-8bbd-f6ec2b896a4c Ancestors: ToolBuilder-MVC-mt.59 Same reason as: ToolBuilder-Morphic-TheresaHMartenK.261 Copy: The current implementation searches for the supplied answer in the valueList and if found returns the value at the found index in the valueList which of course is the supplied answer. However from the behaviour that gets mimicked you would expect the implementation to look for the suppliedAnswer in the labelList - the same as you click on the label and not on its connected value. Additionally this produces less readable / understandable code compared to supplying the label, especially if the value happens to be a block. With the new implementation, the answer is searched in the labelList, and the returned value is the coresponding value from the valueList. =============== Diff against ToolBuilder-MVC-mt.59 =============== Item was changed: ----- Method: MVCUIManager>>chooseFrom:values:lines:title: (in category 'ui requests') ----- chooseFrom: labelList values: valueList lines: linesArray title: aString "Choose an item from the given list. Answer the selected item." | menu | self askForProvidedAnswerTo: aString ifSupplied: [:answer | (answer = #cancel or: [answer isNil]) ifTrue: [^ nil]. + ^ valueList at: (labelList indexOf: answer) ifAbsent: [ - ^ valueList at: (valueList indexOf: answer) ifAbsent: [ answer isNumber ifTrue: [valueList at: answer ifAbsent: [nil]] ifFalse: [nil]]]. menu := SelectionMenu labels: labelList lines: linesArray selections: valueList. ^ aString ifEmpty: [menu startUp] ifNotEmpty: [menu startUpWithCaption: aString]!

1 0

← Newer
1
...
9
10
11
12
13
14
15
...
35
Older →

Jump to page: