Squeak-dev June 2020

squeak-dev@lists.squeakfoundation.org

43 participants
346 discussions

tedious programming-in-the-debugger error needs fixing
by Eliot Miranda 09 Oct '20

09 Oct '20

Hi All, if in a block in the debugger and one redefines the method, the debugger says "I will need to go back to the method that defined this block" or some such. If there is a syntax error in the new code one is trying to compile then the original method is displayed, the syntax error is displayed in that original text, and one's edited text is lost. _,,,^..^,,,_ best, Eliot

16 51

Why is ModificationForbidden not an Error?
by Thiede, Christoph 03 Oct '20

03 Oct '20

Hi all, please take a short look at this behavior: TestRunner openForSuite: MorphicUIManagerTest suite. "Run Selected" <http://www.hpi.de/> At the moment (#19541), a bug in FileList2 class >> #endingSpecs (which I'm going to fix ASAP) breaks the test #testShowAllBinParts. But because ModificationForbidden is not an Error, it is not caught by the TestRunner so the whole suite run blows up, too. I could make another example by triggering a ModificationForbidden in a #drawOn: method to destroy the whole image, too. (Morph newSubclass compile: 'drawOn: x #(1) at: 1 put: 2'; new) openInHand) So my question is: Why doesn't ModificationForbidden derive from Error? Isn't it actually an error? Similar illegal operations such as "#() at: 0" or "{} at: 1 put: #foo" raise some kind of Error, too. Everything I learned so far about Squeak's exception framework tells me that you should have a very good reason if you design an exception neither to derive from Error, nor from Notification. At the moment, we only do have 9 exceptions (bad pun ...) to this rule (and I'm not even sure whether MCNoChangesException couldn't be a notification, and Abort does not even have senders in the Trunk). I'd be happy if you could give me some pointers on why ModificationForbidden does not follow this rule. How can we deal with this in order to fix the bugs/unexpected behaviors mentioned above? Possibly related stuff: * http://forum.world.st/Squeak-s-AssertionFailure-vs-SUnit-s-TestFailure-td51… * http://forum.world.st/The-Trunk-Kernel-eem-1294-mcz-td5112196.html * http://forum.world.st/The-Trunk-Kernel-eem-1317-mcz-tp5113273p5113433.html Best, Christoph

12 53

The Inbox: ToolBuilder-Kernel-ct.135.mcz
by commits＠source.squeak.org 01 Oct '20

01 Oct '20

Christoph Thiede uploaded a new version of ToolBuilder-Kernel to project The Inbox: http://source.squeak.org/inbox/ToolBuilder-Kernel-ct.135.mcz ==================== Summary ==================== Name: ToolBuilder-Kernel-ct.135 Author: ct Time: 24 January 2020, 6:34:43.604574 pm UUID: 3ec2613e-56d3-2d41-b5c3-799a66a986e9 Ancestors: ToolBuilder-Kernel-mt.134 Provides fallback implementations for some UIManager messages =============== Diff against ToolBuilder-Kernel-mt.134 =============== Item was changed: ----- Method: UIManager>>chooseFrom:values:lines:title: (in category 'ui requests') ----- chooseFrom: labelList values: valueList lines: linesArray title: aString + "Choose an item from the given list. Answer the corresponding value." + | result | + result := self chooseFrom: labelList lines: linesArray title: aString. + (result isNil or: [result isZero]) ifTrue: [^ nil]. + ^ valueList at: result! - "Choose an item from the given list. Answer the selected item." - ^self subclassResponsibility! Item was changed: ----- Method: UIManager>>confirm:orCancel: (in category 'ui requests') ----- confirm: aString orCancel: cancelBlock + "Put up a yes/no/cancel menu with caption aString. Answer true if the response is yes, false if no. If cancel is chosen, evaluate cancelBlock. This is a modal question--the user must respond yes or no." + ^ (self confirm: aString) + ifFalse: [cancelBlock value]; + yourself! - "Put up a yes/no/cancel menu with caption aString. Answer true if - the response is yes, false if no. If cancel is chosen, evaluate - cancelBlock. This is a modal question--the user must respond yes or no." - ^self subclassResponsibility! Item was changed: ----- Method: UIManager>>confirm:orCancel:title: (in category 'ui requests') ----- confirm: aString orCancel: cancelBlock title: titleString + "Put up a yes/no/cancel menu with caption aString, and titleString to label the dialog. Answer true if the response is yes, false if no. If cancel is chosen, evaluate cancelBlock. This is a modal question--the user must respond yes or no." + ^ (self confirm: aString title: titleString) + ifFalse: [cancelBlock value]; + yourself! - "Put up a yes/no/cancel menu with caption aString, and titleString to label the dialog. - Answer true if the response is yes, false if no. If cancel is chosen, evaluate cancelBlock. - This is a modal question--the user must respond yes or no." - ^self subclassResponsibility! Item was changed: ----- Method: UIManager>>request:initialAnswer:centerAt: (in category 'ui requests - text') ----- request: queryString initialAnswer: defaultAnswer centerAt: aPoint + "Create an instance of me whose question is queryString with the given initial answer. Invoke it centered at the given point, and answer the string the user accepts. Answer the empty string if the user cancels." - "Create an instance of me whose question is queryString with the given - initial answer. Invoke it centered at the given point, and answer the - string the user accepts. Answer the empty string if the user cancels." + ^ self request: queryString initialAnswer: defaultAnswer! - ^self subclassResponsibility!

3 3

TranslucentColor for World: Rendering issue
by Thiede, Christoph 19 Sep '20

19 Sep '20

Hi, should it be a valid state for the World (not an arbitrary PasteUpMorph, but one that #isWorldMorph) to have a transparent TranslucentColor? The current implementation does not forbid this. I know this would not make much sense, but I discovered a quite interesting rendering problem: World color: (Color darkGray alpha: 0.2). MagnifierMorph new openInWorld. bg := BackgroundMorph new addMorph: Morph new; position: 200 @ 100; extent: 128 @ 128; "works" openInWorld. Hover the BackgroundMorph, and the magnifier will work as expected. Now do: bg extent: 128 @ 127. "fails" On my machine (SqueakCog, build 15341b5, on Win1903), the magnifier now does not always display the BackgroundMorph but most of the time its background. I can also perceive some flickering, only few frames are rendered correctly. I also tested other ratios, it seems as if the error occurs iff the BackgroundMorph's bounds area (number of pixels) is lower than 2e14. By debugging the number of unique colors in #magnifiedForm|form, I found out that the defect must occur somewhere in Display>>#copy:. Unfortunately, I could not reproduce it by stepping through the code. As said before, I see that a transparent World color is probably useless, but as I do not understand all relevant code entirely, I thought there could be a more general defect somewhere, beyond this situation. tldr: 1. The given code piece produces a failure. Should we forbid transparent World colors? 2. Where does this weird 2e14 limit come from? 3. By the way: For testing, I turned the conditional in #magnifiedForm off, in order to always call PasteUpMorph>>#patchAt:without:andNothingAbove:. The comment indicates that Display>>#copy: would be faster, but I could not measure any difference in performance. Is this conditional still needed? The #patchAt:without:andNothingAbove: variant also seems not to be affected by the described rendering issue. I would be very happy about your reactions :-) Best, Christoph

3 5

The Inbox: Morphic-ct.1540.mcz
by commits＠source.squeak.org 19 Sep '20

19 Sep '20

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1540.mcz ==================== Summary ==================== Name: Morphic-ct.1540 Author: ct Time: 23 September 2019, 4:44:32.818523 pm UUID: 064f7940-90ea-1646-a6f5-6c0a82c06e91 Ancestors: Morphic-mt.1539 Proposal: Remember & explore provenance of any morph. Sure, this is a performance regression (that's why it's turned off by default), but when you are debugging, I could tell you of so many cases in which this can be a useful utility. Looking at #browseCreatorMethod, we can also use this to allow beginners for quickly browsing the <example> method that created a morph. =============== Diff against Morphic-mt.1539 =============== Item was changed: Object subclass: #Morph instanceVariableNames: 'bounds owner submorphs fullBounds color extension' + classVariableNames: 'HaloForAll IndicateKeyboardFocus MetaMenuForAll PreferredCornerRadius RememberProvenance UseSoftDropShadow' - classVariableNames: 'HaloForAll IndicateKeyboardFocus MetaMenuForAll PreferredCornerRadius UseSoftDropShadow' poolDictionaries: '' category: 'Morphic-Kernel'! !Morph commentStamp: 'klc 3/14/2017 11:30' prior: 0! A Morph (from the Greek "shape" or "form") is an interactive graphical object. General information on the Morphic system can be found at http://wiki.squeak.org/squeak/30. Morphs exist in a tree, rooted at a World (generally a PasteUpMorph). The morphs owned by a morph are its submorphs. Morphs are drawn recursively; if a Morph has no owner it never gets drawn. To hide a Morph and its submorphs, set its #visible property to false using the #visible: method. The World (screen) coordinate system is used for most coordinates, but can be changed if there is a TransformMorph somewhere in the owner chain. My instance variables have accessor methods (e.g., #bounds, #bounds:). Most users should use the accessor methods instead of using the instance variables directly. Structure: instance var Type Description bounds Rectangle A Rectangle indicating my position and a size that will enclose me. owner Morph My parent Morph, or nil for the top-level Morph, which is a or nil world, typically a PasteUpMorph. submorphs Array My child Morphs. fullBounds Rectangle A Rectangle minimally enclosing me and my submorphs. color Color My primary color. Subclasses can use this in different ways. extension MorphExtension Allows extra properties to be stored without adding a or nil storage burden to all morphs. By default, Morphs do not position their submorphs. Morphs may position their submorphs directly or use a LayoutPolicy to automatically control their submorph positioning. Although Morph has some support for BorderStyle, most users should use BorderedMorph if they want borders.! Item was added: + ----- Method: Morph class>>rememberProvenance (in category 'preferences') ----- + rememberProvenance + + <preference: 'Remember provenance of each morph' + categoryList: #(Morphic) + description: 'If enabled, each morph will contain a debug item to view its creator stack. This allows you to explore its provenance later. May affect performance.' + type: #Boolean> + ^ RememberProvenance ifNil: [false]! Item was added: + ----- Method: Morph class>>rememberProvenance: (in category 'preferences') ----- + rememberProvenance: aBoolean + + RememberProvenance := aBoolean.! Item was added: + ----- Method: Morph>>browseCreatorMethod (in category 'debug and other') ----- + browseCreatorMethod + + ^ (self valueOfProperty: #officialCreator) browse! Item was changed: ----- Method: Morph>>buildDebugMenu: (in category 'debug and other') ----- buildDebugMenu: aHand "Answer a debugging menu for the receiver. The hand argument is seemingly historical and plays no role presently" | aMenu aPlayer | aMenu := MenuMorph new defaultTarget: self. aMenu addStayUpItem. (self hasProperty: #errorOnDraw) ifTrue: [aMenu add: 'start drawing again' translated action: #resumeAfterDrawError. aMenu addLine]. (self hasProperty: #errorOnStep) ifTrue: [aMenu add: 'start stepping again' translated action: #resumeAfterStepError. aMenu addLine]. aMenu add: 'inspect morph' translated action: #inspectInMorphic:. aMenu add: 'inspect owner chain' translated action: #inspectOwnerChain. Smalltalk isMorphic ifFalse: [aMenu add: 'inspect morph (in MVC)' translated action: #inspect]. self isMorphicModel ifTrue: [aMenu add: 'inspect model' translated target: self model action: #inspect; add: 'explore model' translated target: self model action: #explore]. (aPlayer := self player) ifNotNil: [aMenu add: 'inspect player' translated target: aPlayer action: #inspect]. aMenu add: 'explore morph' translated target: self selector: #exploreInMorphic:. aMenu addLine. aPlayer ifNotNil: [ aMenu add: 'viewer for Player' translated target: self player action: #beViewed. aMenu balloonTextForLastItem: 'Opens a viewer on my Player -- this is the same thing you get if you click on the cyan "View" halo handle' translated ]. aMenu add: 'viewer for Morph' translated target: self action: #viewMorphDirectly. aMenu balloonTextForLastItem: 'Opens a Viewer on this Morph, rather than on its Player' translated. aMenu addLine. aPlayer ifNotNil: [aPlayer class isUniClass ifTrue: [ aMenu add: 'browse player class' translated target: aPlayer selector: #haveFullProtocolBrowsedShowingSelector: argumentList: #(nil)]]. aMenu add: 'browse morph class' translated target: self selector: #browseHierarchy. + self isMorphicModel - (self isMorphicModel) ifTrue: [aMenu add: 'browse model class' target: self model selector: #browseHierarchy]. + (self valueOfProperty: #officialCreator ifAbsent: [nil]) ifNotNil: [ + aMenu add: 'browse creator method' action: #browseCreatorMethod]. + (self hasProperty: #creatorStack) ifTrue: [ + aMenu add: 'explore creator stack' action: #exploreCreatorStack]. aMenu addLine. self addViewingItemsTo: aMenu. aMenu add: 'make own subclass' translated action: #subclassMorph; add: 'save morph in file' translated action: #saveOnFile; addLine; add: 'call #tempCommand' translated action: #tempCommand; add: 'define #tempCommand' translated action: #defineTempCommand; addLine; add: 'control-menu...' translated target: self selector: #invokeMetaMenu:; add: 'edit balloon help' translated action: #editBalloonHelpText. ^ aMenu! Item was added: + ----- Method: Morph>>exploreCreatorStack (in category 'debug and other') ----- + exploreCreatorStack + + ^ (self valueOfProperty: #creatorStack) explore! Item was changed: ----- Method: Morph>>initialize (in category 'initialization') ----- initialize "initialize the state of the receiver" owner := nil. submorphs := Array empty. bounds := self defaultBounds. + color := self defaultColor. + self class rememberProvenance ifTrue: [ + | creatorStack | + creatorStack := thisContext home stack collect: #method. + self setProperty: #creatorStack toValue: creatorStack. + creatorStack + detect: [:method | method hasPragma: #example] + ifFound: [:method | self setProperty: #officialCreator toValue: method]].! - color := self defaultColor!

5 10

The Inbox: Sound-ct.70.mcz
by commits＠source.squeak.org 19 Sep '20

19 Sep '20

A new version of Sound was added to project The Inbox: http://source.squeak.org/inbox/Sound-ct.70.mcz ==================== Summary ==================== Name: Sound-ct.70 Author: ct Time: 1 October 2019, 11:24:29.223339 pm UUID: 2f133210-3aa3-7140-96bf-52dc03b1dea6 Ancestors: Sound-eem.66 Add example "Yesterday" for SampledSound This commit is part of reconstruction of Objectland (also known as "The Worlds of Squeak"). For more information, see: http://forum.world.st/The-Inbox-MorphicExtras-ct-267-mcz-td5104764.html =============== Diff against Sound-eem.66 =============== Item was added: + ----- Method: SampledSound class>>exampleYesterday (in category 'examples') ----- + exampleYesterday + "SampledSound exampleYesterday play" + + ^ SampledSound + samples: (SoundBuffer fromByteArray: (Base64MimeConverter mimeDecodeToBytes: + self yesterdaySamples readStream) contents) + samplingRate: 22050! Item was added: + ----- Method: SampledSound class>>yesterdaySamples (in category 'examples') ----- (excessive size, no diff calculated)

5 6

The Inbox: Graphics-ct.419.mcz
by commits＠source.squeak.org 17 Sep '20

17 Sep '20

A new version of Graphics was added to project The Inbox: http://source.squeak.org/inbox/Graphics-ct.419.mcz ==================== Summary ==================== Name: Graphics-ct.419 Author: ct Time: 20 September 2019, 7:45:53.388726 pm UUID: 5deebfce-0321-9645-aebd-0b4bfb428259 Ancestors: Graphics-nice.417 Add Rectangle>>#pointAtFraction: Example: [(5@5 rect: 10@20) pointAtFraction: 0.5@1] will give you 7.5 @ 20. dep:feat-ol =============== Diff against Graphics-nice.417 =============== Item was added: + ----- Method: Rectangle>>pointAtFraction: (in category 'rectangle functions') ----- + pointAtFraction: relativePoint + + ^ self origin + (self extent * relativePoint)!

4 4

UndeclaredVariable correction raises Error in Parser
by Thiede, Christoph 17 Sep '20

17 Sep '20

Hi all, maybe someone has time and knowledge to fix the following bug? Scenario: Try to compile the following method: foo ba := nil. 42 ifNotNil: [:ba | ba]. Then accept it and answer the UndeclaredVariable dialog with 'declare temp variable'. Expected behavior: The method should be corrected to: foo | ba | ba := nil. 42 ifNotNil: [: "Name already used in this method ->"ba | ba]. Actual behavior: UndeclaredVariableNode>>#sizeCodeForStorePop: is called and raises a #shouldNotImplement. Interpretation: I guess the problem is in #undeclaredTemps, where the encoder does not declare ba which was shadowed by the declaration in the block. How could that be solved? My first approach would be to store all UndeclaredTempVars in #bindUndeclaredTemp: separately, but I'm quite sure this is not efficient ... How would you solve this problem the best way? However, I attached a change set for my attempt, all tests are green. I'm excited to hear your answers! :) Best, Christoph

2 2

How to change the update URL for Trunk HTTPS?
by Thiede, Christoph 11 Sep '20

11 Sep '20

Hi all, I spent a number of attempts during the latest months on changing my image's update URL to use HTTPS, but unfortunately, it gets reset each time. Shouldn't I be able to simply change the update URL in the preferences by adding a small "s" behind the "http"? But if I do so, when I press the update button the next time, Squeak starts loading all packages from their initial version (Tools-xyz.1, Morphic-xyz.1, ...). Is there a way to easily change the URL? Best, Christoph

6 11

The Trunk: MonticelloConfigurations-mt.160.mcz
by commits＠source.squeak.org 08 Sep '20

08 Sep '20

Marcel Taeumel uploaded a new version of MonticelloConfigurations to project The Trunk: http://source.squeak.org/trunk/MonticelloConfigurations-mt.160.mcz ==================== Summary ==================== Name: MonticelloConfigurations-mt.160 Author: mt Time: 17 April 2020, 5:17:27.82286 pm UUID: 6d32501e-f519-3b4a-ae1a-58b52360a937 Ancestors: MonticelloConfigurations-mt.159 Shows the current CI status in the update dialog. =============== Diff against MonticelloConfigurations-mt.159 =============== Item was changed: ----- Method: MCMcmUpdater>>doUpdate: (in category 'updating') ----- doUpdate: interactive "Update the image by loading all pending updates from the server. If this is the default updater for the system, update the system version when complete. If interteractive use a modal notifier, otherwise only update the transcript. Flush all caches. If a previous download failed this is often helpful" | config previousUpdateLevel ensureTranscriptSetting | previousUpdateLevel := SystemVersion current highestUpdate. MCFileBasedRepository flushAllCaches. ensureTranscriptSetting := MCConfiguration ensureOpenTranscript. [ MCConfiguration ensureOpenTranscript: interactive. config := self updateFromRepository. config ifNil: [ interactive ifTrue: [ ^self inform: 'Unable to retrieve updates from remote repository.' translated ]. Transcript cr; show: '========== Unable to retrieve updates from remote repository. ==========' translated; cr. ^ self ]. MCMcmUpdater default == self ifTrue: [ config setSystemVersion. + interactive ifTrue: [ + self inform: (self updateMessageFor: previousUpdateLevel)]. - interactive ifTrue: [ - self inform: ('Update completed.\\Version: {1}\Update: {3}{2}\\Url: {4}\Map: ''{5}''{6}' translated withCRs format: { - SystemVersion current version. - SystemVersion current highestUpdate. - previousUpdateLevel = SystemVersion current highestUpdate - ifTrue: [''] - ifFalse: [previousUpdateLevel asString, ' -> ']. - self repository. - MCMcmUpdater updateMapName. - SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d | String cr, String cr, d]})]. Transcript cr; show: '========== Update completed: ' translated; show: previousUpdateLevel; show: ' -> ' ; show: SystemVersion current highestUpdate; show: ' =========='; cr ] ifFalse: [ interactive ifTrue: [ self inform: 'Update completed.' ]. Transcript cr; show: '========== Update completed. ==========' translated; cr ] ] ensure: [ MCConfiguration ensureOpenTranscript: ensureTranscriptSetting]. ! Item was changed: ----- Method: MCMcmUpdater>>doUpdate:upTo: (in category 'updating') ----- doUpdate: interactive upTo: versionNumber "Update the image by loading all pending updates from the server. If this is the default updater for the system, update the system version when complete. If interteractive use a modal notifier, otherwise only update the transcript. Flush all caches. If a previous download failed this is often helpful" | config previousUpdateLevel | previousUpdateLevel := SystemVersion current highestUpdate. MCFileBasedRepository flushAllCaches. config := self updateFromRepositories: { self repository } upTo: versionNumber. config ifNil: [ interactive ifTrue: [ ^self inform: 'Unable to retrieve updates from remote repository.' translated ]. Transcript cr; show: '========== Unable to retrieve updates from remote repository. ==========' translated; cr. ^ self ]. MCMcmUpdater default == self ifTrue: [ config setSystemVersion. + interactive ifTrue: [ + self inform: (self updateMessageFor: previousUpdateLevel)]. - interactive ifTrue: [ - self inform: ('Update completed.\\Version: {1}\Update: {3}{2}\\Url: {4}\Map: ''{5}''{6}' translated withCRs format: { - SystemVersion current version. - SystemVersion current highestUpdate. - previousUpdateLevel = SystemVersion current highestUpdate - ifTrue: [''] - ifFalse: [previousUpdateLevel asString, ' -> ']. - self repository. - MCMcmUpdater updateMapName. - SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d | String cr, String cr, d]})]. Transcript cr; show: '========== Update completed: ' translated; show: previousUpdateLevel; show: ' -> ' ; show: SystemVersion current highestUpdate; show: ' =========='; cr ] ifFalse: [ interactive ifTrue: [ self inform: 'Update completed.' ]. Transcript cr; show: '========== Update completed. ==========' translated; cr ] ! Item was added: + ----- Method: MCMcmUpdater>>updateMessageFor: (in category 'private') ----- + updateMessageFor: previousUpdateLevel + + ^ ('Update completed. Version: {1} Update: {3}{2} Url: <a href="{4}">{4}</a> Map: ''{5}'' TravisCI status: <a href="{8}"><img src="{7}" /></a>{6}' translated format: { + SystemVersion current version. + SystemVersion current highestUpdate. + previousUpdateLevel = SystemVersion current highestUpdate + ifTrue: [''] + ifFalse: [previousUpdateLevel asString, ' -> ']. + self repository. + MCMcmUpdater updateMapName. + SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d | + ' ', (d copyReplaceAll: String cr with: ' ')]. + SystemVersion current ciStatusBadgeUrl. + SystemVersion current ciStatusPageUrl. + }) asTextFromHtml!

7 18

← Newer
1
2
3
4
5
6
7
8
9
...
35
Older →

Jump to page: