Squeak-dev April 2019

squeak-dev@lists.squeakfoundation.org

36 participants
122 discussions

The Trunk: Morphic-cmm.1484.mcz
by commits＠source.squeak.org 13 Jan '20

13 Jan '20

Chris Muller uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-cmm.1484.mcz ==================== Summary ==================== Name: Morphic-cmm.1484 Author: cmm Time: 4 April 2019, 5:46:17.398582 pm UUID: 5a57ba6f-fa15-44a3-9581-c919060f0378 Ancestors: Morphic-cmm.1483 Metacello and GitInfrastructure tools are currently the best way to load projects hosted by github.com. Promote installation of the these tools to the Tools menu. =============== Diff against Morphic-cmm.1483 =============== Item was added: + ----- Method: TheWorldMainDockingBar>>gitInfrastructureMenuItemOn: (in category 'submenu - tools') ----- + gitInfrastructureMenuItemOn: menu + menu addItem: + [ : item | item + contents: 'Git Infrastructure' translated ; + help: 'Load tools for accessing github repositories.' translated ; + icon: (self colorIcon: Color lightGray) ; + target: Installer ; + selector: #installGitInfrastructure ]! Item was added: + ----- Method: TheWorldMainDockingBar>>metacelloMenuItemOn: (in category 'submenu - tools') ----- + metacelloMenuItemOn: menu + menu addItem: + [ : item | item + contents: 'Metacello' translated ; + help: 'Install Metacello' translated ; + icon: (self colorIcon: Color lightGray) ; + target: Installer ; + selector: #ensureRecentMetacello ]! Item was changed: ----- Method: TheWorldMainDockingBar>>toolsMenuOn: (in category 'construction') ----- toolsMenuOn: aDockingBar aDockingBar addItem: [ :item | item contents: 'Tools' translated; addSubMenu: [ :menu | self browserMenuItemOn: menu; workspaceMenuItemOn: menu; transcriptMenuItemOn: menu; testRunnerMenuItemOn: menu; methodFinderMenuItemOn: menu; messageNamesMenuItemOn: menu. menu addLine. self - monticelloBrowserMenuItemOn: menu; - monticelloConfigurationsMenuItemOn: menu; simpleChangeSorterMenuItemOn: menu; + dualChangeSorterMenuItemOn: menu; + monticelloBrowserMenuItemOn: menu; + monticelloConfigurationsMenuItemOn: menu ; + metacelloMenuItemOn: menu ; + gitInfrastructureMenuItemOn: menu. - dualChangeSorterMenuItemOn: menu. menu addLine. self processBrowserMenuItemOn: menu; preferenceBrowserMenuItemOn: menu; fileListMenuItemOn: menu. ] ]! Item was changed: + (PackageInfo named: 'Morphic') postscript: '"updated Tools menu" + TheWorldMainDockingBar updateInstances'! - (PackageInfo named: 'Morphic') postscript: 'TheWorldMainDockingBar updateInstances'!

10 21

inescapable modal dialog in trunk
by Chris Muller 11 Jan '20

11 Jan '20

1. Make a method in a browser dirty. 2. Click on another method. Squeak displays, "Changes have not been saved, is it okay to cancel those changes?" 3. Click "No". 4. Now try click anywhere else or do anything else in other windows or the desktop. Every click anywhere causes the dialog to reappear until you say "Yes" or cancel the method changes.

7 20

The Trunk: Graphics-mt.406.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Marcel Taeumel uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-mt.406.mcz ==================== Summary ==================== Name: Graphics-mt.406 Author: mt Time: 17 January 2019, 11:18:39.003727 am UUID: 027d00a7-113d-4b9f-aaec-79e3373339c1 Ancestors: Graphics-mt.405 Adds an informative string representation for LayoutFrame to support layout design and debugging. =============== Diff against Graphics-mt.405 =============== Item was added: + ----- Method: LayoutFrame>>printOn: (in category 'printing') ----- + printOn: aStream + + super printOn: aStream. + + aStream nextPutAll: '( '. + + { {'l'. self leftFraction. self leftOffset}. {'t'. self topFraction. self topOffset}. {'r'. self rightFraction. self rightOffset}. {'b'. self bottomFraction. self bottomOffset} } do: [:spec | + aStream nextPutAll: spec first; space. + + spec second printOn: aStream maxDecimalPlaces: 2. + + aStream nextPutAll: ((spec third ifNil: [0]) >= 0 ifTrue: ['+'] ifFalse: ['-']). + (spec third ifNil: [0]) abs printOn: aStream maxDecimalPlaces: 0] + separatedBy: [aStream space]. + + aStream nextPutAll: ' )'.!

3 2

Drag and drop to reorder items in a single list
by Jakob Reschke 26 Nov '19

26 Nov '19

Hello everyone, tl;dr: the current PluggableTextMorph/Plus does not support the reordering of items in a single list via drag and drop. Attached you find a change set that fixes this, but it might also break in other places. Thus, I kindly ask for a review. Today I found myself implementing a ToolBuilder-built list in which the items should be reorderable via drag and drop. Unfortunately, the current implementation of PluggableTextMorph/Plus does not allow this: you first have to drag the item out of the list before you can drop it in again. Seems like the list morph needs the mouse focus to be able to accept the drop. However, the current implementation explicitly releases the focus from the list upon grabbing the item. Then I changed the PluggableTextMorphPlus to not drop the focus, but keep it, when starting to drag an item. Now the focus would not even be released anymore when the item was indeed dragged out of a list if that list itself does not accept any drops (such as the method list in the system browser: it does not accept drops, but the methods can be dragged from it to the message categories list). So I have changed further methods to make the list morphs always handle dragging events, even if they are not interested in drops. But I do not know what else that might have broken. So, please have a look at the attached change sets. The one without "all" in the file name contains only the actual changes. The one with "all" also contains other relevant (unchanged) methods that I touched during my investigation. Eventually, I would like to put this or a revised edition of it in the inbox because list reordering via drag and drop should not be impossible. The third file contains a simple Model subclass with a list whose items should be reorderable via drag and drop, so you do not have to write it yourself. Grab a sample instance and open it with the ToolBuilder: ToolBuilder open: DragDropInSingleList new. In case I simply got it wrong and there is no need to change Morphic lists to achieve what I want, please tell me how to do it right. ;-) Best regards, Jakob

3 3

When did it become a good idea for selected text to be enclosed by () instead of replaced by 9 ?
by tim Rowledge 06 Nov '19

06 Nov '19

In trying to see if anything had changed re WaveEditor etc I updated an image to update 16963. When I went to save this image a Squeak5.1-16963… I selected the last thre digits of the prior name (Squeak5.1-16549…) intending to type 963. Imagine my surprise - nay, alarm! - when I got ‘Squeak5.1-16(963) instead. Oh my, I said to myself, what has Pooh done now. As best I can work out this is a result of the change in TextEditor>enclose: that added ‘9’ some time ago (and which did not affect me since I normally turn off the annoying enclose stuff in preferences) combined with a more recent change to TextEditor>dispatchOnKeyboardEvent: wherein a use of TextEditor>enclose: was added near the end. I see two obviously related Preferences for enclosing text. I see this as a dangerous thing, because multiple preferences interacting on the same issue can cause chaos, not to say confusion. And every time a preference is added it is yet another sheaf of potential problems to test. So, yes, I can turn it off easily enough. But how could it ever be unsurprising to a user to get a(bc)d instead of the expected a9d ? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Useful random insult:- Fell out of the family tree.

6 6

Plans for 5.3 Morphic / Readability (Re: Squeak Oversight Board Election 2019)
by H. Hirzel 17 Sep '19

17 Sep '19

Hello Marcel a question, see below. Regards Hannes On 1/11/19, Marcel Taeumel <marcel.taeumel(a)hpi.de> wrote: > Hi, there. > > I would like to continue serving on the Squeak Oversight Board in 2019, too. > My main interests encompass user interaction (Morphic), > code modularity > (readability/extensibility), What are your suggestions / plans for 5.3 for enhancing the Morphic user interaction expericence? How do you think better readability of code could be achived? > backwards compatibility (Etoys), and > programming/productivity tools. > > During the past years, it has been a healthy mix of promising ideas, > enlightening discussions, and challenging viewpoints. I do value such > programming experiences as a great addition to my daily life. Squeak's > community is great! Thank you. :-) > > Let us continue shaping Squeak for many opportunities to come! It is an > intriguing programming system with its liveness promoting exploratory > working habits. What a time to be a "programmer". ;-) > > Best, > Marcel > Am 10.01.2019 20:38:30 schrieb Ron Teitelbaum <ron(a)usmedrec.com>: > Hi All, > > Thank you Craig for jumping right in! I would encourage everyone else to > follow Craig's lead. I know some people like to wait but the more > candidates the better. > > The lack of candidates shouldn't be an incentive for people to run and a > large number of candidates shouldn't be a reason for you to decide against > volunteering to run! We have had some excellent people run and not be > elected that would have been terrific members of the board! You show your > commitment to Squeak just by running! For those of you that say you don't > have the time or are not sure what you would have to do, we have had some > excellent answers in the past. There is no requirement or specific demands > and the board decides when and how it will meet. Most, if not all, meetings > are electronic so the demands on your time are very low! Plus the members > are all terrific people you will enjoy working with! > > Jump on in and add your name to the candidate list! > > Thanks! > > Ron Teitelbaum > > On Thu, Jan 10, 2019 at 2:49 AM Craig Latta <craig(a)blackpagedigital.com > [mailto:craig@blackpagedigital.com]> wrote: > > > Hi all-- > > I'd like to serve on the Squeak Oversight Board in 2019. With you > and my fellow board members, I intend to continue... > > - ...representing Squeak at conferences, including ESUG and the > International Conference on Live Coding[1]. > > - ...maintaining the agenda and notes at the board meetings. I > anticipate having the time to make posts to the board blog this > term. > > - ...developing symbiosis between the Squeak, JavaScript, and Web > platform communities through my work with Caffeine[2] and > SqueakJS[3]. > > I would be honored to have your vote. > > > cheers! > > Craig > > -- > > [1] http://iclc.livecodenetwork.org/2019/ingles.html > [http://iclc.livecodenetwork.org/2019/ingles.html] > [2] https://caffeine.js.org [https://caffeine.js.org] > [3] https://squeak.js.org [https://squeak.js.org] > > -- > Craig Latta > Black Page Digital > Amsterdam :: San Francisco > craig(a)blackpagedigital.com [mailto:craig@blackpagedigital.com] > +31 6 2757 7177 (SMS ok) > + 1 415 287 3547 (no SMS) > > >

2 3

The Inbox: Collections-nice.825.mcz
by commits＠source.squeak.org 16 Sep '19

16 Sep '19

Nicolas Cellier uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-nice.825.mcz ==================== Summary ==================== Name: Collections-nice.825 Author: nice Time: 7 April 2019, 11:10:11.564693 pm UUID: c9836c60-9acc-45eb-83b2-851f147b70ca Ancestors: Collections-nice.824 Try to improve some Interval of Float Behavior. - change #last so that it agrees with (self at: self size) Note that last behavior slightly changes for empty Interval: (3 to: 0) last is now 2 instead of 0 previously. I don't know of any code impacted, but it's not a completely neutral change Note: this solves 2 out of the 3 failures of #testIntervalOfFloatLast... The last element might still overshoot the prescribed upper bound. I can also fix it, but implementation of #last is getting overkill. - implement a ReversedInterval that lazily reverse an Interval of Float, and resolves #testIntervalOfFloatReversed. The alternative would be resorting to an Array... - renounce fuzzy inclusion test. As exhibited by #testSurprisingFuzzyInclusionBehavior, it creates more weirdness than it tries to solve. There will be two more test failing, asserting this fuzzy inclusion, but we can later change them. =============== Diff against Collections-nice.824 =============== Item was changed: ----- Method: Interval>>indexOf:startingAt: (in category 'accessing') ----- indexOf: anElement startingAt: startIndex "startIndex is an positive integer, the collection index where the search is started." - "during the computation of val , floats are only used when the receiver contains floats" + | index | - | index val | (self rangeIncludes: anElement) ifFalse: [ ^0 ]. + index := (anElement - start / step) rounded + 1. - val := anElement - self first / self increment. - val isFloat - ifTrue: [ - (val - val rounded) abs * 100000000 < 1 ifFalse: [ ^0 ]. - index := val rounded + 1 ] - ifFalse: [ - val isInteger ifFalse: [ ^0 ]. - index := val + 1 ]. - "finally, the value of startIndex comes into play:" (index between: startIndex and: self size) ifFalse: [ ^0 ]. + (self at: index) = anElement ifFalse: [ ^0 ]. ^index! Item was changed: ----- Method: Interval>>last (in category 'accessing') ----- last "Refer to the comment in SequenceableCollection|last." + ^start + (step * (self size - 1))! - ^stop - (stop - start \\ step)! Item was changed: ----- Method: Interval>>reversed (in category 'converting') ----- reversed self isEmpty ifTrue: [^stop to: start by: step negated]. + (start isFraction and: [step isFraction]) ifFalse: [^ReversedInterval newFrom: self]. ^self last to: start by: step negated! Item was added: + SequenceableCollection subclass: #ReversedInterval + instanceVariableNames: 'original' + classVariableNames: '' + poolDictionaries: '' + category: 'Collections-Sequenceable'! + + !ReversedInterval commentStamp: 'nice 4/6/2019 16:30' prior: 0! + A ReversedInterval is an Interval reversed. + An Interval reversed is generally an Interval, except when made of Float. + This is because Float arithmetic does not guarantee reversible operations. + + Instead of transforming the reversed Float Interval into an Array, I keep a lazier and cheaper representation. + I can even pretend being an Interval myself. As long as I quake like a duck... + + Instance Variables + original: <Interval> + + original + - the Interval being reversed + ! Item was added: + ----- Method: ReversedInterval class>>newFrom: (in category 'as yet unclassified') ----- + newFrom: aCollection + "Answer an instance of me containing the same elements as aCollection, reversed." + + aCollection isInterval ifTrue: [^self basicNew setOriginal: aCollection]. + ^(Interval newFrom: aCollection) reversed! Item was added: + ----- Method: ReversedInterval>>+ (in category 'arithmetic') ----- + + aNumber + ^(original + aNumber) reversed! Item was added: + ----- Method: ReversedInterval>>- (in category 'arithmetic') ----- + - aNumber + ^(original - aNumber) reversed! Item was added: + ----- Method: ReversedInterval>>= (in category 'comparing') ----- + = anObject + ^ self == anObject + or: [anObject class = self class + and: [original = anObject reversed]]! Item was added: + ----- Method: ReversedInterval>>at: (in category 'accessing') ----- + at: anInteger + ^original at: original size + 1 - anInteger! Item was added: + ----- Method: ReversedInterval>>copyFrom:to: (in category 'copying') ----- + copyFrom: startIndex to: stopIndex + (startIndex = 1 and: [stopIndex = self size]) ifTrue: [^self]. + stopIndex < startIndex ifTrue: [^self copyEmpty]. + ^((self at: stopIndex) to: (self at: startIndex) by: original increment) reversed! Item was added: + ----- Method: ReversedInterval>>do: (in category 'enumerating') ----- + do: aBlock + original reverseDo: aBlock! Item was added: + ----- Method: ReversedInterval>>hash (in category 'comparing') ----- + hash + ^original hash bitXor: SmallInteger maxVal! Item was added: + ----- Method: ReversedInterval>>isEmpty (in category 'testing') ----- + isEmpty + ^self size = 0! Item was added: + ----- Method: ReversedInterval>>printOn: (in category 'printing') ----- + printOn: aStream + aStream + nextPut: $(; + print: original; + nextPut: $); + space; + nextPutAll: #reversed! Item was added: + ----- Method: ReversedInterval>>reverseDo: (in category 'enumerating') ----- + reverseDo: aBlock + original do: aBlock! Item was added: + ----- Method: ReversedInterval>>reversed (in category 'converting') ----- + reversed + ^original! Item was added: + ----- Method: ReversedInterval>>setOriginal: (in category 'private') ----- + setOriginal: anInterval + original := anInterval! Item was added: + ----- Method: ReversedInterval>>size (in category 'accessing') ----- + size + ^original size! Item was added: + ----- Method: ReversedInterval>>sorted (in category 'sorting') ----- + sorted + original increment > 0 ifTrue: [^original]. + ^self! Item was added: + ----- Method: ReversedInterval>>species (in category 'private') ----- + species + + ^original species! Item was added: + ----- Method: ReversedInterval>>storeOn: (in category 'printing') ----- + storeOn: aStream + aStream + nextPut: $(; + store: original; + nextPut: $); + space; + nextPutAll: #reversed! Item was added: + ----- Method: ReversedInterval>>sum (in category 'accessing') ----- + sum + ^original sum!

6 8

Re: [squeak-dev] The Trunk: Collections-pre.822.mcz
by Chris Muller 21 Aug '19

21 Aug '19

My main objection is about growing the "mutator" nomenclature further instead of trimming it back. I'm working on a GraphQL framework. GraphQL has a first-class notion of "mutations". https://graphql.org/learn/queries/ Currently, we have almost zero mention of the word "mutator" in the image. I would appreciate if, instead of germinating the overloading the word, we uproot it and keep the nomenclature for this Smalltalk tooling confined to "getter" and "setter" that we have now. So, instead of #asMutator and #isMutator, how about #asSimpleSetter and #isSimpleSetter? We can end up removing a method instead of adding one. We already have many existing methods which are dealing with this conversion, all of which use the traditional Smalltalk / developer linguisitic of "setter". Browsing through all the "setter" nomenclature we have in a message names browser, including Utilities class>>#getterSelectorFor: Utilities class>>#setterSelectorFor: Utilities class>>#simpleSetterFor: which instruct Etoys users to use existing methods on String, #asSetterSelector or #asSimpleSetter. Of special note is SyntaxMorph>>#isStandardSetterKeyword: which, by its use of a utility-method implementation, acknowledges that this behavior is _application-specific_. I, myself, would just write: someSelector asSimpleSetter = someSelector "same as isMutator / isSimpleSetter" instead of #isSimpleSetter, but can appreciate both styles. They both better avoid the awkwardness of "mutator" as a general, reliable behavior when: #at: isMutator "true" while #at:put: isMutator "false" Best, Chris On Thu, Mar 21, 2019 at 1:16 AM <patrick.rein(a)hpi.uni-potsdam.de> wrote: > > Which one are you refering to? I only see Symbol>>#asMutator in Collections in the method category converting. It is also used in a few other places beyond generating instance variable accessors. > > Bests, > Patrick > > >#asMutator: is for "generate instVar accessors" code-generation, and > >that's why it's in the Tools package. > > > >IMHO, if #isMutator belongs anywhere, it isn't in Collections. > > > >Regards, > > Chris > > > > > > > >On Wed, Mar 20, 2019 at 3:08 PM Chris Muller <asqueaker(a)gmail.com> wrote: > >> > >> Assuming a single-keyword is a mutator? Object>>#at: is not a > >> mutator. #indexOf: is not. #first: is not. Obviously many more.. > >> > >> If API balance is the goal of this, perhaps #asMutator should be > >> removed instead. This feels application-specific... > >> > >> On Wed, Mar 20, 2019 at 2:05 PM <commits(a)source.squeak.org> wrote: > >> > > >> > Patrick Rein uploaded a new version of Collections to project The Trunk: > >> > http://source.squeak.org/trunk/Collections-pre.822.mcz > >> > > >> > ==================== Summary ==================== > >> > > >> > Name: Collections-pre.822 > >> > Author: pre > >> > Time: 20 March 2019, 8:05:20.383677 pm > >> > UUID: 483c4461-cee4-4a4f-82d3-fbc03e7201cc > >> > Ancestors: Collections-dtl.821 > >> > > >> > Adds #isMutator to Symbol which is analogous to asMutator. > >> > > >> > =============== Diff against Collections-dtl.821 =============== > >> > > >> > Item was added: > >> > + ----- Method: Symbol>>isMutator (in category 'testing') ----- > >> > + isMutator > >> > + > >> > + ^ self isKeyword and: [self numArgs = 1]! > >> > > >> > > > >

6 12

The Trunk: Kernel-fn.1223.mcz
by commits＠source.squeak.org 23 Jul '19

23 Jul '19

Fabio Niephaus uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-fn.1223.mcz ==================== Summary ==================== Name: Kernel-fn.1223 Author: fn Time: 29 April 2019, 12:52:13.424813 pm UUID: 910aa151-72fe-4f6c-9645-fa735fb17f63 Ancestors: Kernel-nice.1222 SmallInteger and SmallFloat64 shouldNotImplement postCopy. =============== Diff against Kernel-nice.1222 =============== Item was added: + ----- Method: SmallFloat64>>postCopy (in category 'copying') ----- + postCopy + "I will never be copied" + ^self shouldNotImplement! Item was added: + ----- Method: SmallInteger>>postCopy (in category 'copying') ----- + postCopy + "I will never be copied" + ^self shouldNotImplement!

5 5

The Inbox: ShoutCore-nice.63.mcz
by commits＠source.squeak.org 19 Jul '19

19 Jul '19

Nicolas Cellier uploaded a new version of ShoutCore to project The Inbox: http://source.squeak.org/inbox/ShoutCore-nice.63.mcz ==================== Summary ==================== Name: ShoutCore-nice.63 Author: nice Time: 7 April 2019, 3:24:31.721529 pm UUID: 7440b898-b497-493b-adfa-67aef04e0980 Ancestors: ShoutCore-eem.62 Attempt to fix highlighting of 1to:-1 I don't see the point of testing the presence of a binary selector character after a colon $:, except maybe the case of assignment :=, so only test that case. =============== Diff against ShoutCore-eem.62 =============== Item was changed: ----- Method: SHParserST80>>scanIdentifier (in category 'scan') ----- scanIdentifier | c start | start := sourcePosition. [ (c := self nextChar) isAlphaNumeric or: [ allowUnderscoreSelectors and: [ c == $_ ] ] ] whileTrue. + (c == $: and: [ self peekChar ~= $= ]) - (c == $: and: [ (self isSelectorCharacter: self peekChar) not ]) ifTrue: [ self nextChar ]. currentToken := source copyFrom: start to: sourcePosition - 1. currentTokenSourcePosition := start!

3 3