Squeak-dev April 2019

squeak-dev@lists.squeakfoundation.org

36 participants
122 discussions

The Trunk: ToolBuilder-Morphic-pre.227.mcz
by commits＠source.squeak.org 30 Apr '19

30 Apr '19

Patrick Rein uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-pre.227.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-pre.227 Author: pre Time: 30 April 2019, 3:27:02.905906 pm UUID: cac10ed0-f94c-2446-bbe2-418edc5c9e1a Ancestors: ToolBuilder-Morphic-pre.226 Makes the ProvideAnswerNotification handling more robust with regard to the input (actual value or index) =============== Diff against ToolBuilder-Morphic-pre.226 =============== Item was changed: ----- Method: MorphicUIManager>>chooseFrom:values:lines:title: (in category 'ui requests') ----- chooseFrom: labelList values: valueList lines: linesArray title: aString "Choose an item from the given list. Answer the selected item." | index | self askForProvidedAnswerTo: aString ifSupplied: [:answer | (answer = #cancel or: [answer isNil]) ifTrue: [^ nil]. + ^ valueList at: (valueList indexOf: answer) ifAbsent: [ + answer isNumber + ifTrue: [valueList at: answer ifAbsent: [nil]] + ifFalse: [nil]]]. - ^ valueList at: (valueList indexOf: answer) ifAbsent: [nil]]. index := self chooseFrom: labelList lines: linesArray title: aString. ^ index = 0 ifTrue: [ nil ] ifFalse: [ valueList at: index ]!

1 0

The Trunk: ToolBuilder-MVC-pre.55.mcz
by commits＠source.squeak.org 30 Apr '19

30 Apr '19

Patrick Rein uploaded a new version of ToolBuilder-MVC to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-MVC-pre.55.mcz ==================== Summary ==================== Name: ToolBuilder-MVC-pre.55 Author: pre Time: 30 April 2019, 3:26:24.726906 pm UUID: 378599a0-73a3-c84b-b02d-a96fd5352da1 Ancestors: ToolBuilder-MVC-pre.54 Makes the ProvideAnswerNotification handling more robust with regard to the input (actual value or index) =============== Diff against ToolBuilder-MVC-pre.54 =============== Item was changed: ----- Method: MVCUIManager>>chooseFrom:values:lines:title: (in category 'ui requests') ----- chooseFrom: labelList values: valueList lines: linesArray title: aString "Choose an item from the given list. Answer the selected item." | menu | self askForProvidedAnswerTo: aString ifSupplied: [:answer | (answer = #cancel or: [answer isNil]) ifTrue: [^ nil]. + ^ valueList at: (valueList indexOf: answer) ifAbsent: [ + answer isNumber + ifTrue: [valueList at: answer ifAbsent: [nil]] + ifFalse: [nil]]]. - ^ valueList at: (valueList indexOf: answer)]. menu := SelectionMenu labels: labelList lines: linesArray selections: valueList. ^ aString ifEmpty: [menu startUp] ifNotEmpty: [menu startUpWithCaption: aString]!

1 0

The Trunk: KernelTests-pre.359.mcz
by commits＠source.squeak.org 30 Apr '19

30 Apr '19

Patrick Rein uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-pre.359.mcz ==================== Summary ==================== Name: KernelTests-pre.359 Author: pre Time: 30 April 2019, 3:24:23.948906 pm UUID: 6e90bf67-9160-3e40-99e7-cb9d9aa6f794 Ancestors: KernelTests-nice.358 Adds a test case for #valueSupplyingAnswers: for selecting from a list through specifying the element or the index. =============== Diff against KernelTests-nice.358 =============== Item was added: + ----- Method: BlockClosureTest>>testSupplySpecificAnswerToSelection (in category 'tests - supply answer') ----- + testSupplySpecificAnswerToSelection + + | windowTitle | + windowTitle := 'What is your favorite letter?'. + UIManager subclassesDo: [:managerClass | + self should: [#b = ([managerClass new chooseFrom: #(a b c) values: #(a b c) title: windowTitle] + valueSupplyingAnswer: {windowTitle . #b})]]. + + UIManager subclassesDo: [:managerClass | + self should: [#b = ([managerClass new chooseFrom: #(a b c) values: #(a b c) title: windowTitle] + valueSupplyingAnswer: {windowTitle . 2})]]!

1 0

The Trunk: ToolBuilder-Morphic-jr.225.mcz
by commits＠source.squeak.org 29 Apr '19

29 Apr '19

Patrick Rein uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-jr.225.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-jr.225 Author: jr Time: 3 February 2019, 12:02:36.955839 am UUID: f93f39b3-2e20-ea44-b023-1ec44691e5e1 Ancestors: ToolBuilder-Morphic-mt.224 Fix: FileSaverDialog would answer 'nil' instead of nil when nothing was done except for accepting the dialog =============== Diff against ToolBuilder-Morphic-mt.224 =============== Item was changed: ----- Method: FileSaverDialog>>inputText: (in category 'filename') ----- inputText: aText "Initialize the filename entry field to aString. If a file with that name already exists, set up to highlight it." + aText ifNil: [^ self]. fileName := aText asString. self selectExistingFilename!

1 0

The Trunk: ToolBuilder-Morphic-pre.226.mcz
by commits＠source.squeak.org 29 Apr '19

29 Apr '19

Patrick Rein uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-pre.226.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-pre.226 Author: pre Time: 29 April 2019, 8:34:39.917145 pm UUID: 2f50877e-d948-2a4d-a14b-e73efca9711f Ancestors: ToolBuilder-Morphic-jr.225 Fix: FileSaverDialog would answer 'nil' instead of nil when nothing was done except for accepting the dialog Merged from inbox commit ToolBuilder-Morphic-jr.225 =============== Diff against ToolBuilder-Morphic-mt.224 =============== Item was changed: ----- Method: FileSaverDialog>>inputText: (in category 'filename') ----- inputText: aText "Initialize the filename entry field to aString. If a file with that name already exists, set up to highlight it." + aText ifNil: [^ self]. fileName := aText asString. self selectExistingFilename!

1 0

The Trunk: Morphic-pre.1488.mcz
by commits＠source.squeak.org 29 Apr '19

29 Apr '19

Patrick Rein uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-pre.1488.mcz ==================== Summary ==================== Name: Morphic-pre.1488 Author: pre Time: 29 April 2019, 8:20:28.689145 pm UUID: 72aff730-f2b8-9e4b-b830-b56fcf18438b Ancestors: Morphic-cmm.1487 Improves the check for whether a keystroke for the text morph for edit view will change the text to send the #editText callback. Refactors the check by creating a cached character set. =============== Diff against Morphic-cmm.1487 =============== Item was changed: TextMorph subclass: #TextMorphForEditView instanceVariableNames: 'editView acceptOnCR' + classVariableNames: 'DraggableTextSelection TextModificationCharacterSet' - classVariableNames: 'DraggableTextSelection' poolDictionaries: '' category: 'Morphic-Text Support'! Item was added: + ----- Method: TextMorphForEditView class>>defaultTextModificationCharacterSet (in category 'constants') ----- + defaultTextModificationCharacterSet + + ^ (ByteCharacterSet newFrom: (((0 to: 30) collect: [:code | Character value: code]) difference: Character separators asArray , {Character backspace})) complement! Item was added: + ----- Method: TextMorphForEditView class>>initialize (in category 'class initialization') ----- + initialize + + TextModificationCharacterSet := self defaultTextModificationCharacterSet! Item was added: + ----- Method: TextMorphForEditView class>>textModificationCharacterSet (in category 'constants') ----- + textModificationCharacterSet + + ^ TextModificationCharacterSet! Item was added: + ----- Method: TextMorphForEditView>>eventCharacterModifiesText: (in category 'private') ----- + eventCharacterModifiesText: aCharacter + + ^ self class textModificationCharacterSet includes: aCharacter! Item was changed: ----- Method: TextMorphForEditView>>keyStroke: (in category 'event handling') ----- keyStroke: evt | view | + editView deleteBalloon. self editor model: editView model. "For evaluateSelection" view := editView. "Copy into temp for case of a self-mutating doit" (acceptOnCR and: [evt keyCharacter = Character cr]) ifTrue: [^ self editor accept]. super keyStroke: evt. view scrollSelectionIntoView. "Make a cheap check and guess editing. (Alternative would be to copy the old contents and then compare them against the new ones. Maybe add a better hook in the TextEditor." + (self readOnly not and: [self eventCharacterModifiesText: evt keyCharacter]) + ifTrue: [view textEdited: self contents]! - (self readOnly not and: [evt keyCharacter isAlphaNumeric or: [evt keyCharacter isSeparator]]) - ifTrue: [view textEdited: self contents].!

1 0

The Trunk: MorphicTests-pre.50.mcz
by commits＠source.squeak.org 29 Apr '19

29 Apr '19

Patrick Rein uploaded a new version of MorphicTests to project The Trunk: http://source.squeak.org/trunk/MorphicTests-pre.50.mcz ==================== Summary ==================== Name: MorphicTests-pre.50 Author: pre Time: 29 April 2019, 8:16:16.145145 pm UUID: ac21cd61-1da9-5a47-9186-f3b430ce2218 Ancestors: MorphicTests-mt.49 Adds tests for the text morph for edit view which checks whether the right characters are filtered for editText: callbacks =============== Diff against MorphicTests-mt.49 =============== Item was added: + TestCase subclass: #TextMorphForEditViewTest + instanceVariableNames: 'morph' + classVariableNames: '' + poolDictionaries: '' + category: 'MorphicTests-Text Support'! Item was added: + ----- Method: TextMorphForEditViewTest>>setUp (in category 'running') ----- + setUp + + morph := TextMorphForEditView new! Item was added: + ----- Method: TextMorphForEditViewTest>>testCharactersModifyingText (in category 'tests') ----- + testCharactersModifyingText + + {$a . $: . $+ . Character backspace . Character delete . $2 . Character space . Character tab .$ü } do: [:char | + self assert: (morph eventCharacterModifiesText: char)] + ! Item was added: + ----- Method: TextMorphForEditViewTest>>testCharactersNotModifyingText (in category 'tests') ----- + testCharactersNotModifyingText + + #(0 1 2 3) do: [:charCode | + self deny: (morph eventCharacterModifiesText: (Character value: charCode))]!

1 0

implicit type coercion
by Chris Muller 29 Apr '19

29 Apr '19

Kudos Fabio for noticing the non-symmetry in type coercion between Strings and Characters. I was doing a little more research and noticed we have all these adapt'ing methods on *Object* (!!). Object>>#adaptToFloat:andCompare: Object>>#adaptToFloat:andSend: Object>>#adaptToFraction:andCompare: Object>>#adaptToFraction:andSend: Object>>#adaptToInteger:andCompare: Object>>#adaptToInteger:andSend: Object>>#adaptToScaledDecimal:andCompare: Browse origin showed methods added in 2006 by Kernel-nice.398 (version notes below). The explanation given there and in all three Mantis reports relates to coercions between Integers and Floats. So, it doesn't appear that these were intended to encourage automatic coercion of ANY object to the numbers domain for interoperation with numbers, but its presence on Object maybe was the common superclass for the implementation. I submitted an alternative version to the Inbox which proposes symmetry between Strings and Characters to be that they both require explicit coercion. Whether to do automatic coercion in the language feels like a weighty decision. My gut is telling me its better to be conservative in doing auto coercing, but I'm sure Nicolas' and others' can better articulate an the most intelligent path forward. - Chris _____________ Name: Kernel-nice.398 Author: nice Time: 13 February 2010, 4:31:00.389 am UUID: f1525362-d01a-214c-94fe-2bb3a5fffa89 Ancestors: Kernel-nice.397 Fix http://bugs.squeak.org/view.php?id=3360 http://bugs.squeak.org/view.php?id=3374 http://bugs.squeak.org/view.php?id=6601 hash and = are now reconciled for numbers. = is now transitive for numbers. WARNING: now, tests like (1/10 = 0.1) will answer false. This is expected, and more than expected, this is wanted. Float are inexact and testing for strict equality is not a clever thing to do. All this has been longly debated at http://permalink.gmane.org/gmane.comp.lang.smalltalk.pharo.devel/10642 http://thread.gmane.org/gmane.comp.lang.smalltalk.sapphire.devel/10223/focu… Please, read carefully this thread to make an opinion before raising your voice. It can break code eventually, so I'm all ears to real case, and willing to help fixing. But please, real examples, not theoretical (after 8 month change in Pharo, I'm not aware of further complaints).

3 3

The Inbox: Collections-cmm.826.mcz
by commits＠source.squeak.org 29 Apr '19

29 Apr '19

Chris Muller uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-cmm.826.mcz ==================== Summary ==================== Name: Collections-cmm.826 Author: cmm Time: 15 April 2019, 8:08:23.890925 pm UUID: ad291896-9fa1-4fa1-b587-658cd87d888a Ancestors: Collections-fn.825 Restrict automatic type coercions in numerical operations to the domain of numbers only; Float, Integer, Fraction and ScaledDecimal. For objects outside the numerical domain such as Strings, Characters, Points, and other objects, it's desirable to require explicit coercion. =============== Diff against Collections-fn.825 =============== Item was removed: - ----- Method: Character>>adaptToNumber:andSend: (in category 'converting') ----- - adaptToNumber: rcvr andSend: selector - "If I am involved in arithmetic with a number, convert me to an integer." - - ^ rcvr perform: selector with: self asInteger! Item was removed: - ----- Method: String>>adaptToNumber:andSend: (in category 'converting') ----- - adaptToNumber: rcvr andSend: selector - "If I am involved in arithmetic with a number, convert me to a number." - - ^ rcvr perform: selector with: self asNumber! Item was removed: - ----- Method: String>>adaptToPoint:andSend: (in category 'converting') ----- - adaptToPoint: rcvr andSend: selector - "If I am involved in arithmetic with a point, convert me to a number." - - ^ rcvr perform: selector with: self asNumber!

2 1

[ANN] ScriptBook 0.3
by Chris Cunnington 29 Apr '19

29 Apr '19

>Would be cool if ScriptBook could support the loading part >somehow (mostly done through Metacello). That'd make lots of projects [2] >directly loadable from GitHub. That sounds powerful. My GitHub knowledge isn’t broad, but I can work on that. I’ll take a look at these links to understand what you mean. Thanks for a great suggestion. Chris

2 1

← Newer
1
2
3
4
5
6
7
...
13
Older →