Squeak-dev November 2018

squeak-dev@lists.squeakfoundation.org

48 participants
94 discussions

#= ==> #hash issues
by Chris Cunningham 22 Nov '18

22 Nov '18

Hi. I'm slowly (very) working towards crating a usable test for validating for classes where #= is true, #hash will also be true. Last week, the Date issue showed up. This week? Intervals: (0 to: 1) = (0 to: 5/3). "true" (0 to: 1) hash = (0 to: 5/3) hash. "false" CharacterBlock: | cb1 cb2 | cb1 := (CharacterBlock new stringIndex: 5 text: 'StandardText' asText topLeft: (100@100) extent: (20@20)). cb2 := (CharacterBlock new stringIndex: 5 text: 'StandardText' asText topLeft: (200@200) extent: (20@20)). cb1 = cb2. "true" cb1 hash = cb2 hash. "false" These were found by comparing a random sampling of instances of classes that implement #= or #hash (or both), and finding which have these deviant properties. The hard part is figuring out instances that are going to have issues - Date didn't show up in my prototype scanning. Also most classes don't have instances floating around to compare. Thanks, -cbc

9 30

Message>>#= & Message>>#hash
by Eliot Miranda 22 Nov '18

22 Nov '18

Hi All, In VisualWorks Message implements #= & #hash naturally; two messages whose selectors and arguments are #= are also equal. But in Cuis, Squeak and Pharo Message inherits #= and #hash from Object, i.e. uses identity comparison. This is, to say the least, annoying. Any objections to implementing comparing in Message to match VisualWorks? _,,,^..^,,,_ best, Eliot

8 19

UTCDateAndTime discussion + Q&A
by Chris Muller 22 Nov '18

22 Nov '18

Hi Dave, Thanks for making UTCDateAndTime available on SqueakMap that "just works" -- not having to go research how to properly install it left me some time to actually start looking at it today. A cursory look reveals that, at least functionally, everything appears to be essentially the same as original Chronology except the on-going million-dollar question: What are the point-in-time endpoints of a timespan identified by a particular "Date"? There are two reasonable answers to this question: 1) "local" e.g., a period that begins from 12am to 11:59:59.999999 of my LOCAL time, or 2) "global" e.g., a period that begins from 12am to 11:59:59.999999 of UTC (offset 0). We already know that original Chronlology supports ability for applications to represent their Dates either way. What about UTCDateAndTime? When I do: DateAndTime now asDate = Date today I get "true", even though MY 22-Oct-2018 begins and ends at a different point-in-time than those in the UTC timezone.. I realize most applications want a canonical representation of Dates, but where does this leave the timespan use-cases? Are they even possible at all? What if I truly need the same local representation of 22-Oct-2018 that everyone else recognizes in my local area? Thanks, Chris

6 12

The Trunk: Kernel-eem.1197.mcz
by commits＠source.squeak.org 20 Nov '18

20 Nov '18

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1197.mcz ==================== Summary ==================== Name: Kernel-eem.1197 Author: eem Time: 20 November 2018, 1:43:36.839917 pm UUID: bf505221-c2ce-4adb-8f51-144901828649 Ancestors: Kernel-eem.1196 Define #= and #hash for Message such that distinct Messages with the identical selector and lookupClass, and literalEqual: arguments are equal. =============== Diff against Kernel-eem.1196 =============== Item was added: + ----- Method: Message>>= (in category 'comparing') ----- + = anObject + ^self class == anObject class + and: [selector == anObject selector "selector lookup is by identity" + and: [lookupClass == anObject lookupClass + and: [args literalEqual: anObject arguments]]]! Item was added: + ----- Method: Message>>hash (in category 'comparing') ----- + hash + "#hash is implemented, because #= is implemented." + ^(selector hash bitXor: args hash) bitXor: lookupClass hash!

1 0

The Trunk: KernelTests-eem.353.mcz
by commits＠source.squeak.org 20 Nov '18

20 Nov '18

Eliot Miranda uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-eem.353.mcz ==================== Summary ==================== Name: KernelTests-eem.353 Author: eem Time: 20 November 2018, 1:41:04.77042 pm UUID: 50504d29-30ef-4845-a6e5-34bf17226f9c Ancestors: KernelTests-pre.352 Add tests for Message equality =============== Diff against KernelTests-pre.352 =============== Item was added: + TestCase subclass: #MessageTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'KernelTests-Methods'! Item was added: + ----- Method: MessageTest>>testMessageEquality (in category 'tests') ----- + testMessageEquality + + self assert: (Message selector: #= argument: 1) equals: (Message selector: #= argument: 1). + self assert: (Message selector: #= argument: 1) hash equals: (Message selector: #= argument: 1) hash. + self deny: (Message selector: #= argument: 1) equals: (Message selector: #= argument: 1.0)!

1 0

The Trunk: Kernel-eem.1196.mcz
by commits＠source.squeak.org 20 Nov '18

20 Nov '18

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1196.mcz ==================== Summary ==================== Name: Kernel-eem.1196 Author: eem Time: 20 November 2018, 1:39:00.487858 pm UUID: d725b2e7-fe69-472d-8775-25948cabcc8c Ancestors: Kernel-eem.1195 Fix ClosureExtractor (embeddedBlockClosures) for exotic Sista blocks. =============== Diff against Kernel-eem.1195 =============== Item was changed: ----- Method: ClosureExtractor>>pushFullClosure:numCopied: (in category 'instruction decoding') ----- pushFullClosure: aCompiledBlock numCopied: numCopied "Create a BlockClosure corresponding to the closure bytecode and execute the action block with it. The created BlockClosure is only a pseudo value, it is not populated with meaningful context and argument information." + self pushFullClosure: aCompiledBlock numCopied: numCopied receiverOnStack: false ignoreOuterContext: false! - | block | - block := FullBlockClosure - receiver: nil - outerContext: currentContext - method: aCompiledBlock - copiedValues: (Array new: numCopied). - currentContext := block asContextWithSender: currentContext. - action value: block! Item was added: + ----- Method: ClosureExtractor>>pushFullClosure:numCopied:receiverOnStack:ignoreOuterContext: (in category 'instruction decoding') ----- + pushFullClosure: aCompiledBlock numCopied: numCopied receiverOnStack: rcvrOnStack ignoreOuterContext: ignoreOuterContext + "Create a BlockClosure corresponding to the closure bytecode + and execute the action block with it. The created BlockClosure is only a pseudo value, + it is not populated with meaningful context and argument information." + | block encoderClass endPC extractor subScanner | + block := FullBlockClosure + receiver: (rcvrOnStack ifTrue: [#onStackReceiver]) + outerContext: (ignoreOuterContext ifFalse: [currentContext]) + method: aCompiledBlock + copiedValues: (Array new: numCopied). + currentContext := block asContextWithSender: currentContext. + action value: block. + subScanner := aCompiledBlock scanner. + extractor := self class withAction: action andScanner: subScanner. + endPC := aCompiledBlock endPC. + encoderClass := aCompiledBlock encoderClass. + [subScanner pc <= endPC] whileTrue: + [encoderClass interpretNextInstructionFor: extractor in: subScanner]!

1 0

The Trunk: Compiler-eem.396.mcz
by commits＠source.squeak.org 20 Nov '18

20 Nov '18

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.396.mcz ==================== Summary ==================== Name: Compiler-eem.396 Author: eem Time: 20 November 2018, 1:34:47.963843 pm UUID: 4b9317db-2d11-4ae6-a183-9ec139110eb1 Ancestors: Compiler-eem.395 Fix a slip in Sista block creation =============== Diff against Compiler-eem.395 =============== Item was changed: ----- Method: BytecodeEncoder>>sizePushFullClosure:numCopied:receiverOnStack:ignoreOuterContext: (in category 'opcode sizing') ----- sizePushFullClosure: compiledBlockLiteralIndex numCopied: numCopied receiverOnStack: receiverOnStack ignoreOuterContext: ignoreOuterContext + ^self sizeOpcodeSelector: #genPushFullClosure:numCopied:receiverOnStack:ignoreOuterContext: - ^self sizeOpcodeSelector: #genPushFullClosure:numCopied:receiverOnStack:ignoreOuterContext withArguments: {compiledBlockLiteralIndex. numCopied. receiverOnStack. ignoreOuterContext}! Item was changed: BytecodeEncoder subclass: #EncoderForSistaV1 (excessive size, no diff calculated)

1 0

The Inbox: Collections-cbc.813.mcz
by commits＠source.squeak.org 20 Nov '18

20 Nov '18

Chris Cunningham uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-cbc.813.mcz ==================== Summary ==================== Name: Collections-cbc.813 Author: cbc Time: 20 November 2018, 11:28:59.501218 am UUID: 78c08e62-a381-284a-b476-6e638d99f91d Ancestors: Collections-cbc.812 Altered Interval>>hash to increase entropy =============== Diff against Collections-cbc.812 =============== Item was changed: ----- Method: Interval>>hash (in category 'comparing') ----- hash "Hash is reimplemented because = is implemented." + ^((start hash hashMultiply bitXor: self last hash) hashMultiply + bitXor: self size)! - - ^(((start hash bitShift: 2) - bitOr: self last hash) - bitShift: 1) - bitOr: self size!

1 0

The Trunk: SUnit-eem.113.mcz
by commits＠source.squeak.org 19 Nov '18

19 Nov '18

Eliot Miranda uploaded a new version of SUnit to project The Trunk: http://source.squeak.org/trunk/SUnit-eem.113.mcz ==================== Summary ==================== Name: SUnit-eem.113 Author: eem Time: 19 November 2018, 9:53:01.453709 am UUID: 7071263a-3791-4acb-bdac-70931fffb7f6 Ancestors: SUnit-ul.112 Add deny:equals: to complement assert:equals: =============== Diff against SUnit-ul.112 =============== Item was added: + ----- Method: TestCase>>deny:equals: (in category 'accessing') ----- + deny: unexpected equals: actual + + ^self + deny: unexpected = actual + description: 'Actual equals unexpected' + !

1 0

The Inbox: Collections-cbc.812.mcz
by commits＠source.squeak.org 19 Nov '18

19 Nov '18

Chris Cunningham uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-cbc.812.mcz ==================== Summary ==================== Name: Collections-cbc.812 Author: cbc Time: 15 November 2018, 10:06:05.244237 pm UUID: 1977358c-ec82-5442-8f1d-027d4bc817a3 Ancestors: Collections-eem.811 Make intervals that are #= have the same hash. Also, slight adjustment to #=. =============== Diff against Collections-eem.811 =============== Item was changed: ----- Method: Interval>>= (in category 'comparing') ----- = anObject - ^ self == anObject + or: [anObject isInterval + ifFalse: [super = anObject] + ifTrue: + [start = anObject first + and: [step = anObject increment + and: [self last = anObject last]]]]! - ifTrue: [true] - ifFalse: [anObject isInterval - ifTrue: [start = anObject first - and: [step = anObject increment - and: [self last = anObject last]]] - ifFalse: [super = anObject]]! Item was changed: ----- Method: Interval>>hash (in category 'comparing') ----- hash "Hash is reimplemented because = is implemented." ^(((start hash bitShift: 2) + bitOr: self last hash) - bitOr: stop hash) bitShift: 1) bitOr: self size!

6 5

← Newer
1
2
3
4
5
6
7
8
9
10
Older →