Squeak-dev November 2018

squeak-dev@lists.squeakfoundation.org

48 participants
94 discussions

32 vs 64 bits and large integer hash
by Eliot Miranda 26 Nov '18

26 Nov '18

Hi All, right now we have the following definition of Large(Positive)Integer>>hash: hash ^ByteArray hashBytes: self startingWith: self species hash which means that for all integers outside of the 32-bit SmallInteger range (-2 ^ 30 to 2 ^ 30 - 1), the 32-bit system and the 64-bit system answer different values for hash. e.g. in 64 bits: (2 raisedTo: 30) hash 1073741824 but in 32 bits: (2 raisedTo: 30) hash 230045764 This is unsatisfactory. I propose changing Large(Positive)Integer>>hash to hash ^self digitLength <= 8 ifTrue: [self] ifFalse: [ByteArray hashBytes: self startingWith: self species hash] P.S. Note that this will not break Float hash, which is defined as Float>>hash "Hash is reimplemented because = is implemented. Both words of the float are used. (The bitShift:'s ensure that the intermediate results do not become a large integer.) Care is taken to answer same hash as an equal Integer." (self isFinite and: [self fractionPart = 0.0]) ifTrue: [^self truncated hash]. ^ ((self basicAt: 1) bitShift: -4) + ((self basicAt: 2) bitShift: -4) P.P.S. I *think* that "(self isFinite and: [self fractionPart = 0.0])" is equivalent to "self - self = self fractionPart" ;-) _,,,^..^,,,_ best, Eliot

8 19

Fuel update for UTCDateAndTime
by David T. Lewis 26 Nov '18

26 Nov '18

The Fuel serializer is loadable in Squeak 5.2 from the SqueakMap loader, and is supported for Pharo, Squeak, and Cuis (great kudos to the maintainers for doing this). In order to change DateAndTime to a simpler UTC-based implementation in Squeak, with two instance variables rather than four, an update will be needed for Fuel to understand the new format. The attached change set provides the necessary support, while maintaining compatibility with the traditional DateAndTime and interoperability between images that support either format. For example, an image can serialize a traditional DateAndTime with Fuel, and another image with UTC DateAndTime can materialize it in the new UTC format. I am not yet sure how to submit this to the Fuel maintainers, so I'm posting it here as a change set for now. Dave

2 1

The Inbox: Kernel-cmm.1198.mcz
by commits＠source.squeak.org 26 Nov '18

26 Nov '18

Chris Muller uploaded a new version of Kernel to project The Inbox: http://source.squeak.org/inbox/Kernel-cmm.1198.mcz ==================== Summary ==================== Name: Kernel-cmm.1198 Author: cmm Time: 23 November 2018, 11:12:47.414703 pm UUID: fe228ca8-2ec7-4432-b3d9-76da98be4475 Ancestors: Kernel-eem.1197 - Suggestion that #basicClass should be inlined while #class should be a message send, so that Proxy's can be supported. - If so, then #xxxClass can be banished. - With #xxxClass banished, the Squeak code that called it can be written normally, simply as "class". =============== Diff against Kernel-eem.1197 =============== Item was added: + ----- Method: Object>>basicClass (in category 'class membership') ----- + basicClass + "Primitive. Answer the object which is the receiver's class. Essential. See + Object documentation whatIsAPrimitive." + + <primitive: 111> + self primitiveFailed! Item was changed: ----- Method: Object>>class (in category 'class membership') ----- class + "Answer the object which is the receiver's class. Essential." - "Primitive. Answer the object which is the receiver's class. Essential. See - Object documentation whatIsAPrimitive." + ^ self basicClass! - <primitive: 111> - self primitiveFailed! Item was changed: ----- Method: Object>>storeDataOn: (in category 'objects from disk') ----- storeDataOn: aDataStream "Store myself on a DataStream. Answer self. This is a low-level DataStream/ReferenceStream method. See also objectToStoreOnDataStream. NOTE: This method must send 'aDataStream beginInstance:size:' and then (nextPut:/nextPutWeak:) its subobjects. readDataFrom:size: reads back what we write here." | cntInstVars cntIndexedVars | cntInstVars := self class instSize. cntIndexedVars := self basicSize. aDataStream + beginInstance: self class - beginInstance: self xxxClass size: cntInstVars + cntIndexedVars. 1 to: cntInstVars do: [:i | aDataStream nextPut: (self instVarAt: i)]. "Write fields of a variable length object. When writing to a dummy stream, don't bother to write the bytes" ((aDataStream byteStream class == DummyStream) and: [self class isBits]) ifFalse: [ 1 to: cntIndexedVars do: [:i | aDataStream nextPut: (self basicAt: i)]]. ! Item was removed: - ----- Method: Object>>xxxClass (in category 'class membership') ----- - xxxClass - "For subclasses of nil, such as ObjectOut" - ^ self class!

4 8

[ANN] Open Croquet for Squeak 5.2 (32bit) release
by Nikolay Suslov 25 Nov '18

25 Nov '18

Hi all, I'm pleased to announce, that the experimental version of Open Croquet for Squeak (https://blog.krestianstvo.org/en/open-croquet-for-squeak-6/) is now updated to the recent Squeak 5.2 (32bit) <http://files.squeak.org/5.2/Squeak5.2-18225-32bit>. This update includes critical FIX for the Croquet's IslandReader, which is related to the new Squeak image segment loader code. The included Croquet demos have become usable in network scenarios, but with some requirements: For replication to work, a participant must run a Master of the selected demo at least once on its image (for example doing: CroquetMaster new openInWorld). Then that participant could connect to any running Master on a network (for example doing: CroquetParticipant new openInWorld). In the future updates this will be fixed. *Preloaded images:* - All-In-One Squeak 5.2 VM with preloaded Open Croquet image and content: https://www.krestianstvo.org/sdk/croquet/Squeak5.2-18225-32bit-All-in-One-C… - Only Squeak 5.2 with image with preloaded Open Croquet: https://www.krestianstvo.org/sdk/croquet/Squeak5.2-18225-32bit-Croquet-Imag… - Only content (Textures, Models, etc.): https://www.krestianstvo.org/sdk/croquet/Content.zip *Loading manually:* (Installer fromUrl: ' http://sdk.krestianstvo.org/sdk/croquet/croquet-sn.3.mcm') install. Don't forget to download and extract 'Only content <https://www.krestianstvo.org/sdk/croquet/Content.zip>' package to /Contents/Resources/ folder. *How to use it on the network:* If Master wanted to be discoverable, it's network address must be specified here: CroquetHarness dispatcherAddress. Participant should specify a Master's network address here: CroquetHarness defaultBroadcaster. Here is the screenshot of one Master (on macOS) and two Participants (on Windows and macOS) collaborating together. [image: Screenshot-croquet.jpg] Best reagards, Nikolai

7 11

The Trunk: Kernel-eem.1199.mcz
by commits＠source.squeak.org 25 Nov '18

25 Nov '18

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1199.mcz ==================== Summary ==================== Name: Kernel-eem.1199 Author: eem Time: 24 November 2018, 3:19:28.081135 pm UUID: 7d8e709b-a9c9-49ad-b733-e34ce715a79c Ancestors: Kernel-eem.1198 Remove a mistaken halt from the postscript of the previous commit. =============== Diff against Kernel-eem.1198 =============== Item was changed: (PackageInfo named: 'Kernel') postscript: '"below, add code to be run after the loading of this package" "Since Kernel-eem.1198 redefines LargePositiveInteger hash, rehash all hashed collections that contain hashed large integers." HashedCollection allSubclassesDo: [:c| | f | f := (c includesBehavior: Set) ifTrue: [[:i| i]] ifFalse: [[:i| i keys]]. c allInstancesDo: [:h| ((f value: h) detect: [:e| e isInteger and: [e class ~~ SmallInteger]] ifNone: nil) ifNotNil: + [h rehash]]]'! - [h halt rehash]]]'!

1 0

The Trunk: Kernel-eem.1198.mcz
by commits＠source.squeak.org 25 Nov '18

25 Nov '18

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1198.mcz ==================== Summary ==================== Name: Kernel-eem.1198 Author: eem Time: 24 November 2018, 1:44:47.526422 pm UUID: 100137c4-2514-4b7f-9064-3dcdfe7d8cc9 Ancestors: Kernel-eem.1197 Redefine LargePositiveInteger hash for compatibility between 32-bit and 64-bit systems. =============== Diff against Kernel-eem.1197 =============== Item was changed: ----- Method: LargePositiveInteger>>hash (in category 'comparing') ----- hash + "Answer an integer value that is related to the value of the receiver. + Take care that the hash value is the same in both 32-bit and 64-bit versions. + Since the integers are by definition perfectly distributed a SmallInteger's hash is itself + (it is impossible to derive a hash function that is better distributed than the SmallIntegers + themselves). Therefore, for integers that could possibly fit in the SmallInteger range, answer + self. For values well outside of the SmallInteger range on 64-bits answer a hash that avoids + large integer arithmetic." + ^self digitLength <= 8 + ifTrue: [self] + ifFalse: + [ByteArray + hashBytes: self + startingWith: self species hash]! - - ^ByteArray - hashBytes: self - startingWith: self species hash! Item was changed: ----- Method: SmallInteger>>hash (in category 'comparing') ----- hash + "Answer an integer value that is related to the value of the receiver. + Since the integers are by definition perfectly distributed answer self + (it is impossible to derive a hash function that is better distributed + than the SmallIntegers themselves). c.f. LargePositiveInteger hash." ^self! Item was changed: (PackageInfo named: 'Kernel') postscript: '"below, add code to be run after the loading of this package" + "Since Kernel-eem.1198 redefines LargePositiveInteger hash, + rehash all hashed collections that contain hashed large integers." + HashedCollection allSubclassesDo: + [:c| | f | + f := (c includesBehavior: Set) + ifTrue: [[:i| i]] + ifFalse: [[:i| i keys]]. + c allInstancesDo: + [:h| + ((f value: h) detect: [:e| e isInteger and: [e class ~~ SmallInteger]] ifNone: nil) ifNotNil: + [h halt rehash]]]'! - ((ByteArray subclasses includes: CompiledMethod) - and: [CompiledMethod superclass ~= ByteArray]) ifTrue: - [ByteArray removeSubclass: CompiledMethod]. - (Smalltalk classNamed: #FullBlockClosure) ifNotNil: - [:fbc| - (fbc identityHash ~= 38) ifTrue: - [fbc tryPrimitive: 161 withArgs: #(38 true)]]'!

4 3

The Inbox: KernelTests-tcj.350.mcz
by commits＠source.squeak.org 24 Nov '18

24 Nov '18

A new version of KernelTests was added to project The Inbox: http://source.squeak.org/inbox/KernelTests-tcj.350.mcz ==================== Summary ==================== Name: KernelTests-tcj.350 Author: tcj Time: 24 November 2018, 1:50:04.681743 am UUID: a0951193-8488-47c9-bcc1-13f18a9a6f47 Ancestors: KernelTests-pre.349 Beginning some tests to ensure messages being sent from menus actually exist in default receivers =============== Diff against KernelTests-pre.349 =============== Item was changed: SystemOrganization addCategory: #'KernelTests-Classes'! SystemOrganization addCategory: #'KernelTests-Methods'! + SystemOrganization addCategory: #'KernelTests-Models'! SystemOrganization addCategory: #'KernelTests-Numbers'! SystemOrganization addCategory: #'KernelTests-Objects'! SystemOrganization addCategory: #'KernelTests-Processes'! Item was added: + TestCase subclass: #StringHolderTest + instanceVariableNames: 'mvcEditor morphicEditor' + classVariableNames: '' + poolDictionaries: '' + category: 'KernelTests-Models'! Item was added: + ----- Method: StringHolderTest>>setUp (in category 'as yet unclassified') ----- + setUp + mvcEditor := ParagraphEditor new. + morphicEditor := TextMorph defaultEditorClass new. "may be SmalltalkEditor" + ! Item was added: + ----- Method: StringHolderTest>>testYellowButtonMenuItems (in category 'as yet unclassified') ----- + testYellowButtonMenuItems + | tuples actions mvcDnu morphicDnu | + "Morphic and MVC share StringHolder. Ensure that both respond to its menu items." + tuples := StringHolder shiftedYellowButtonMenuItems reject: [:tuple | tuple size < 2]. "ignore lines/bars" + actions := tuples collect: [:ea | ea at: 2]. + mvcDnu := actions reject: [:action | mvcEditor respondsTo: action]. + self + assert: mvcDnu isEmpty + description: 'An MVC editor should respond to all menu items.'. + morphicDnu := actions reject: [:action | morphicEditor respondsTo: action]. + self + assert: (morphicDnu hasEqualElements: #( sendContentsToPrinter yellowButtonActivity) ) + description: 'A Morphic editor should respond to all menu items.'!

1 0

The Inbox: Morphic-tcj.1467.mcz
by commits＠source.squeak.org 24 Nov '18

24 Nov '18

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-tcj.1467.mcz ==================== Summary ==================== Name: Morphic-tcj.1467 Author: tcj Time: 24 November 2018, 1:43:41.12951 am UUID: 3ebcd06a-9435-4def-b94b-17e1d488cc0d Ancestors: Morphic-tcj.1466 Copy a method from MVC's ParagraphEditor to Morphic's TextEditor. #printerSetup is sent by StringHolder's shifted yellow button menu and so can be sent to both ParagraphEditor (in MVC) and TextEditor (in Morphic). =============== Diff against Morphic-tcj.1466 =============== Item was added: + ----- Method: TextEditor>>printerSetup (in category 'menu messages') ----- + printerSetup + "copied from ParagraphEditor" + TextPrinter defaultTextPrinter inspect + !

1 0

The Inbox: Tools-tcj.834.mcz
by commits＠source.squeak.org 24 Nov '18

24 Nov '18

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-tcj.834.mcz ==================== Summary ==================== Name: Tools-tcj.834 Author: tcj Time: 24 November 2018, 1:33:48.408468 am UUID: 1cf61cee-2719-46d5-be5c-bc5b25b43a19 Ancestors: Tools-eem.833 Add 'alphabetize' to Package Pane Browser's class category menu, as is found on standard Browser. =============== Diff against Tools-eem.833 =============== Item was changed: ----- Method: PackagePaneBrowser>>mainPackageMenu: (in category 'package list') ----- mainPackageMenu: aMenu "Answer a Menu of operations on class packages to be displayed when the operate menu button is pressed." <packageListMenu> ^aMenu addList: #( ('find class...' findClass) ('recent classes...' recent) - ('reorganize' editSystemCategories) + ('alphabetize' alphabetizeSystemCategories) + - ('update' updatePackages)); yourself. !

1 0

The Inbox: Morphic-tcj.1466.mcz
by commits＠source.squeak.org 23 Nov '18

23 Nov '18

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-tcj.1466.mcz ==================== Summary ==================== Name: Morphic-tcj.1466 Author: tcj Time: 22 November 2018, 8:20:25.420925 pm UUID: e770db4d-e763-4a8f-89c1-83cec7b2c843 Ancestors: Morphic-eem.1464 Prevent DockingBar menu item labels from being edited, by default. This hides three possible defects in current item label editing behavior: the editor appears with its position slightly off, it only allows one keypress before automatically accepting the input, and if a menubar icon is shift-clicked then it is erased and replaced by text input by the user. Note that the menubar can be easily restored to its default contents by clicking Extras->Rebuild Menus, or evaluating: TheWorldMainDockingBar updateInstances =============== Diff against Morphic-eem.1464 =============== Item was changed: ----- Method: DockingBarItemMorph>>wantsKeyboardFocusOnShiftClick (in category 'events') ----- wantsKeyboardFocusOnShiftClick "set this preference to false to prevent user editing of docking bar menu items" + ^Preferences valueOfPreference: #allowMenubarItemEditing ifAbsent: [false]! - ^Preferences valueOfPreference: #allowMenubarItemEditing ifAbsent: [true]!

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →