Squeak-dev October 2018

squeak-dev@lists.squeakfoundation.org

41 participants
130 discussions

The Trunk: Collections-eem.811.mcz
by commits＠source.squeak.org 31 Oct '18

31 Oct '18

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.811.mcz ==================== Summary ==================== Name: Collections-eem.811 Author: eem Time: 31 October 2018, 10:44:24.941583 am UUID: a01f9f2a-1915-4520-8dbd-dfe7f43b1026 Ancestors: Collections-ul.810 Use the integerAt[Put] primitive to implement signedByteAt:[put:] =============== Diff against Collections-ul.810 =============== Item was changed: ----- Method: ByteArray>>signedByteAt: (in category 'platform independent access') ----- signedByteAt: index + "Answer an 8-bit signed integer quantity from the given byte index." + <primitive: 165> - "Return an 8-bit signed integer quantity from the given byte index." - | byte | (byte := self at: index) <= 16r7F ifTrue: [ ^byte ]. ^byte - 16r100! Item was changed: ----- Method: ByteArray>>signedByteAt:put: (in category 'platform independent access') ----- signedByteAt: index put: anInteger "Store an 8-bit signed integer quantity at the given byte index." + <primitive: 166> - anInteger >= 0 ifTrue: [ ^self at: index put: anInteger ]. self at: index put: anInteger + 16r100. ^anInteger!

1 0

The Inbox: Collections-cbc.810.mcz
by commits＠source.squeak.org 30 Oct '18

30 Oct '18

Chris Cunningham uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-cbc.810.mcz ==================== Summary ==================== Name: Collections-cbc.810 Author: cbc Time: 28 October 2018, 5:15:56.960512 pm UUID: 729c4dd2-f677-3c40-9ded-4a407a71f824 Ancestors: Collections-topa.809 Do NOT move to trunk! Various option for fixing the internval hash issue related to collectionsTests cbc.296. Some explanation to go to mailing list - this is so interested folks can try out the code. =============== Diff against Collections-topa.809 =============== Item was added: + ----- Method: Array>>hashBetterFastIntervalCompatible (in category 'comparing') ----- + hashBetterFastIntervalCompatible + | hash | + self size < 48 ifTrue: [^super hash]. "Just check every element." + hash := self species hash. + 1 to: 16 do: [:i| hash := (hash + (self at: i) hash) hashMultiply]. + self size - 15 to: self size do: [:i| hash := (hash + (self at: i) hash) hashMultiply]. + ^(hash + self size hash) hashMultiply! Item was added: + ----- Method: Array>>hashFastIntervalCompatible (in category 'comparing') ----- + hashFastIntervalCompatible + self size = 0 ifTrue: [^self species hash]. + ^(self species hash + + (((((self at: 1) hash bitShift: 2) + bitOr: (self at: self size) hash) + bitShift: 1) + bitOr: self size) + ) hashMultiply! Item was changed: ----- Method: Interval>>hash (in category 'comparing') ----- hash "Hash is reimplemented because = is implemented." ^(((start hash bitShift: 2) bitOr: stop hash) bitShift: 1) bitOr: self size! Item was added: + ----- Method: Interval>>hashBetter (in category 'comparing') ----- + hashBetter + "Hash is reimplemented because = is implemented." + + ^(((start hash bitShift: 2) + bitOr: self last hash) + bitShift: 1) + bitOr: self size! Item was added: + ----- Method: Interval>>hashBetterAlsoFixBug3380 (in category 'comparing') ----- + hashBetterAlsoFixBug3380 + "Hash is reimplemented because = is implemented." + "Altered so that we has the same as self asArray hash" + ^self inject: Array hash into: [:workingHash :each| (workingHash + each hash) hashMultiply ].! Item was added: + ----- Method: Interval>>hashBetterFastArrayCompatible (in category 'comparing') ----- + hashBetterFastArrayCompatible + | hash | + self size < 48 ifTrue: [^self slowHash]. "Just check every element." + hash := Array hash. + 1 to: 16 do: [:i| hash := (hash + (self at: i) hash) hashMultiply]. + self size - 15 to: self size do: [:i| hash := (hash + (self at: i) hash) hashMultiply]. + ^(hash + self size hash) hashMultiply! Item was added: + ----- Method: Interval>>hashFastArrayCompatible (in category 'comparing') ----- + hashFastArrayCompatible + "Hash is reimplemented because = is implemented." + self size = 0 ifTrue: [^Array hash]. + ^(Array hash + + ((((start hash bitShift: 2) + bitOr: self last hash) + bitShift: 1) + bitOr: self size) + ) hashMultiply! Item was added: + ----- Method: Interval>>hashSlowerBetterAlsoFixBug3380 (in category 'comparing') ----- + hashSlowerBetterAlsoFixBug3380 + "Hash is reimplemented because = is implemented." + "Altered so that we has the same as self asArray hash" + | hash | + + hash := Array hash. + 1 to: self size do: [:i | hash := (hash + (self at: i) hash) hashMultiply]. + ^hash! Item was added: + ----- Method: Interval>>slowHash (in category 'comparing') ----- + slowHash + "Hash is reimplemented because = is implemented." + "Altered so that we has the same as self asArray hash" + ^self inject: Array hash into: [:workingHash :each| (workingHash + each hash) hashMultiply ].!

4 3

What should Integer>>digitCompare: return?
by Chris Cunningham 30 Oct '18

30 Oct '18

Looking at LargeIntegers (I'm 64 bit, so these are big): { 1152921504606846977 digitCompare: -1152921504606846977. 1152921504606846977 digitCompare: -1152921504606846978. 1152921504606846978 digitCompare: -1152921504606846977. } "#(0 -1 1)" { 1249 digitCompare: -1249. 1249 digitCompare: -1250. 1250 digitCompare: -1249. } #(1 1 1)

4 8

The Trunk: Collections-ul.810.mcz
by commits＠source.squeak.org 30 Oct '18

30 Oct '18

Levente Uzonyi uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ul.810.mcz ==================== Summary ==================== Name: Collections-ul.810 Author: ul Time: 30 October 2018, 1:26:22.149414 am UUID: 33532c8f-187e-4914-9573-9a6a5390a97c Ancestors: Collections-topa.809 - renamed the methods #stringHashWithInitialHash: and #bytesHashWithInitialHash: to #hashWithInitialHash: =============== Diff against Collections-topa.809 =============== Item was removed: - ----- Method: ByteArray>>bytesHashWithInitialHash: (in category 'private') ----- - bytesHashWithInitialHash: speciesHash - "Answer the hash of a byte-indexed array, using speciesHash as the initial value. - See SmallInteger>>hashMultiply." - <primitive: 'primitiveStringHash' module: 'MiscPrimitivePlugin'> - - ^String stringHash: self initialHash: speciesHash! Item was changed: ----- Method: ByteArray>>hash (in category 'comparing') ----- hash "#hash is implemented, because #= is implemented" + ^self hashWithInitialHash: self species hash! - ^self bytesHashWithInitialHash: self species hash! Item was added: + ----- Method: ByteArray>>hashWithInitialHash: (in category 'private') ----- + hashWithInitialHash: speciesHash + "Answer the hash of a byte-indexed array, using speciesHash as the initial value. + See SmallInteger>>hashMultiply." + <primitive: 'primitiveStringHash' module: 'MiscPrimitivePlugin'> + + ^String stringHash: self initialHash: speciesHash! Item was added: + ----- Method: ByteString>>hashWithInitialHash: (in category 'private') ----- + hashWithInitialHash: speciesHash + "Answer the hash of a byte-indexed string, using speciesHash as the initial value. + See SmallInteger>>hashMultiply." + <primitive: 'primitiveStringHash' module: 'MiscPrimitivePlugin'> + + ^super hashWithInitialHash: speciesHash! Item was removed: - ----- Method: ByteString>>stringHashWithInitialHash: (in category 'private') ----- - stringHashWithInitialHash: speciesHash - "Answer the hash of a byte-indexed string, using speciesHash as the initial value. - See SmallInteger>>hashMultiply." - <primitive: 'primitiveStringHash' module: 'MiscPrimitivePlugin'> - - ^super stringHashWithInitialHash: speciesHash! Item was added: + ----- Method: ByteSymbol>>hashWithInitialHash: (in category 'private') ----- + hashWithInitialHash: speciesHash + "Answer the hash of a byte-indexed string, using speciesHash as the initial value. + See SmallInteger>>hashMultiply." + <primitive: 'primitiveStringHash' module: 'MiscPrimitivePlugin'> + + ^super hashWithInitialHash: speciesHash! Item was removed: - ----- Method: ByteSymbol>>stringHashWithInitialHash: (in category 'private') ----- - stringHashWithInitialHash: speciesHash - "Answer the hash of a byte-indexed string, using speciesHash as the initial value. - See SmallInteger>>hashMultiply." - <primitive: 'primitiveStringHash' module: 'MiscPrimitivePlugin'> - - ^super stringHashWithInitialHash: speciesHash! Item was changed: ----- Method: String>>hash (in category 'comparing') ----- hash "#hash is implemented, because #= is implemented" "ar 4/10/2005: I had to change this to use ByteString hash as initial hash in order to avoid having to rehash everything and yet compute the same hash for ByteString and WideString. md 16/10/2006: use identityHash as initialHash, as behavior hash will use String hash (name) to have a better hash soon. eem 4/17/2017 it's not possible to use String hash (name) for the initial hash because that would be recursive." + ^self hashWithInitialHash: ByteString identityHash! - ^self stringHashWithInitialHash: ByteString identityHash! Item was changed: + ----- Method: String>>hashWithInitialHash: (in category 'private') ----- + hashWithInitialHash: speciesHash + "Answer the hash of a byte-indexed string, using speciesHash as the initial value. + See SmallInteger>>hashMultiply." + | hash | + hash := speciesHash bitAnd: 16r0FFFFFFF. + 1 to: self size do: + [:pos | + hash := (hash + (self basicAt: pos)) hashMultiply]. + ^hash! - ----- Method: String>>hashWithInitialHash: (in category 'comparing') ----- - hashWithInitialHash: initialHash - - ^ self class stringHash: self initialHash: initialHash! Item was removed: - ----- Method: String>>stringHashWithInitialHash: (in category 'private') ----- - stringHashWithInitialHash: speciesHash - "Answer the hash of a byte-indexed string, using speciesHash as the initial value. - See SmallInteger>>hashMultiply." - | hash | - hash := speciesHash bitAnd: 16r0FFFFFFF. - 1 to: self size do: - [:pos | - hash := (hash + (self basicAt: pos)) hashMultiply]. - ^hash!

1 0

The Trunk: Kernel-eem.1193.mcz
by commits＠source.squeak.org 30 Oct '18

30 Oct '18

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1193.mcz ==================== Summary ==================== Name: Kernel-eem.1193 Author: eem Time: 29 October 2018, 4:05:45.263515 pm UUID: 003c6ae4-79d6-48f7-8f8a-9cc1a37690f8 Ancestors: Kernel-ul.1192 Provide changeClassTo: as a convenient way of accessing adoptInstance:, and a better replacement for the older primitiveChangeClassTo:. =============== Diff against Kernel-ul.1192 =============== Item was added: + ----- Method: Object>>changeClassTo: (in category 'converting') ----- + changeClassTo: aBehavior + "Change the class of the receiver to the argument, provided + that the format of the argument matches the format of the receiver's class." + aBehavior adoptInstance: self. + ^self!

1 0

Effect Handlers
by Eliot Miranda 29 Oct '18

29 Oct '18

Hi All, I found this write up instructive and well-written: https://www.quora.com/What-are-some-features-youd-want-a-new-programming-la… _,,,^..^,,,_ (phone)

3 2

The Inbox: CollectionsTests-cbc.296.mcz
by commits＠source.squeak.org 29 Oct '18

29 Oct '18

Chris Cunningham uploaded a new version of CollectionsTests to project The Inbox: http://source.squeak.org/inbox/CollectionsTests-cbc.296.mcz ==================== Summary ==================== Name: CollectionsTests-cbc.296 Author: cbc Time: 28 October 2018, 5:12:30.875512 pm UUID: 12a1d6bf-85c7-8d40-aa1c-022556c1cb18 Ancestors: CollectionsTests-topa.295 Test for #hash and #= bugs. In anticipation of fixing these. =============== Diff against CollectionsTests-topa.295 =============== Item was added: + ----- Method: IntervalTest>>testHashBug3380 (in category 'tests') ----- + testHashBug3380 + "Array and Interval equate, but their hashes didn't. Test that this is fixed. + It is about mantis bug http://bugs.squeak.org/view.php?id=6455" + | interval array | + interval := (1 to: 3). + array:= #(1 2 3). + self assert: interval equals: array. + self assert: interval hash equals: array hash.! Item was added: + ----- Method: IntervalTest>>testHashEqualIfIntervalEqual (in category 'tests') ----- + testHashEqualIfIntervalEqual + | interval1 interval2 | + interval1 := 0 to: 1. + interval2 := 0 to: 5/3. "Taken from an actual issue in an image" + self assert: interval1 equals: interval2. + self assert: interval1 hash equals: interval2 hash.!

4 3

The Trunk: Collections-topa.809.mcz
by commits＠source.squeak.org 28 Oct '18

28 Oct '18

Tobias Pape uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-topa.809.mcz ==================== Summary ==================== Name: Collections-topa.809 Author: topa Time: 28 October 2018, 8:16:44.149252 pm UUID: 65e8b64d-f325-47d8-8f83-ab4a9793ba9f Ancestors: Collections-eem.808 Add #histogramOf: convenience + test =============== Diff against Collections-eem.808 =============== Item was added: + ----- Method: Collection>>histogramOf: (in category 'converting') ----- + histogramOf: aBlock + + ^ self collect: aBlock as: Bag!

3 2

The Trunk: CollectionsTests-topa.295.mcz
by commits＠source.squeak.org 28 Oct '18

28 Oct '18

Tobias Pape uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-topa.295.mcz ==================== Summary ==================== Name: CollectionsTests-topa.295 Author: topa Time: 28 October 2018, 8:14:02.430507 pm UUID: dc71a7c1-c330-4af2-a4c9-78459f5193f3 Ancestors: CollectionsTests-ul.294 Add #histogramOf: convenience + test =============== Diff against CollectionsTests-ul.294 =============== Item was added: + ----- Method: CollectionTest>>testHistogramOf (in category 'testing') ----- + testHistogramOf + " could be collect:as: Bag, but histogram is what it's used for " + | baseCollection collection | + baseCollection := {#x -> 2 . #y -> 3 . #y -> 4. #z -> 2 }. + { Array . OrderedCollection . Set } do: + [:collectionClass | + collection := baseCollection as: collectionClass. + self + assert: collection asBag + equals: (collection histogramOf: [:ea | ea]) + description: 'For ', collectionClass, ', #asBag and identity-histograms should match'. + self + assert: (Bag withAll: #( x y y z)) + equals: (collection histogramOf: [:ea | ea key]) + description: 'For ', collectionClass, ', histogramming contents should work '. + self + assert: (Bag withAll: #( 2 3 4 2 )) + equals: (collection histogramOf: [:ea | ea value]) + description: 'For ', collectionClass, ', histogramming contents should work']. + + collection := baseCollection as: KeyedSet. + self + assert: collection asBag + equals: (collection histogramOf: [:ea | ea]) + description: 'For KeyedSet, #asBag and identity-histograms should match'. + self + assert: (Bag withAll: #( x y z)) + equals: (collection histogramOf: [:ea | ea key]) + description: 'For KeyedSet, histogramming contents should work '. + self + assert: (Bag withAll: #( 2 3 2 )) + equals: (collection histogramOf: [:ea | ea value]) + description: 'For KeyedSet, histogramming contents should work'. + + baseCollection := {#x -> 2 . "#y -> 3 ." #y -> 4. #z -> 2 }. "No duplicate keyes" + collection := baseCollection as: Dictionary. + self + assert: (Bag withAll: #( 2 2 4 )) + equals: (collection histogramOf: [:ea | ea]) + description: 'For Dictionary, histogramming should work on values.'. + self + assert: (collection values histogramOf: [:ea | ea]) + equals: (collection histogramOf: [:ea | ea]) + description: 'For Dictionary, histogramming should be the same as histogramming the values.'. + self + assert: collection asBag + equals: (collection histogramOf: [:ea | ea]) + description: 'For Dictionary, #asBag should match histogramming.'. + self + assert: (Bag withAll: #(x y z)) + equals: (collection keys histogramOf: [:ea |ea]) + description: 'For Dictionary, histogramming keys is ok to be less convenient.'. + !

1 0

Re: [squeak-dev] Open Croquet will ahve issues in next version of Mac OS X
by LawsonEnglish 28 Oct '18

28 Oct '18

Well, the OpenGL plugin itself isn’t 64-bit last I checked, and I’m not sure what else. Croquet/Cobalt may auto-install stuff that I never noticed. There’s also an issue with Croquet/Cobalt only working properly because every vlirny generates exactly the same (bit-identical) values in every possible respect. Integer handling (and 32-bit floating point) in 32-bit vs 64-bit squeak may break that. It may be possible to create “proxy” classes for integers and floats and use those in both 32-bit and 64-bit Croquet, and allow the objects on the client-side resolve any oddness, but as it stands now, my understanding is that a SmallInteger on a 32-bit VM isn't the same as a SmallInteger on a 64-bit VM and that is an automatic fail for the paradigm that Croquet is based on, so simply updating Croquet to 64-bit will automatically make it incompatible with 32-bit Croquet. Which kinda defeats the original "deploy everywhere that Squeak works” philosophy. L > On Oct 22, 2018, at 4:36 PM, David T. Lewis <lewis(a)mail.msen.com> wrote: > > Hi Lawson, > > On Mon, Oct 22, 2018 at 01:24:16PM -0700, LawsonEnglish wrote: >> https://blog.krestianstvo.org/en/open-croquet-for-squeak-6/ <https://blog.krestianstvo.org/en/open-croquet-for-squeak-6/> >> >> >> This sounds really cool, but there???s an issue coming up: >> >> Apple is doing away with ANY support for 32-bit apps and plugins and of course, Croquet is built for 32-bits and uses 32-bit plugins all over the place. >> > > We collectively have a good deal of experience in updating plugins > for 64 bits, and of course the VMs (the "application") are already > there. Can you remind us what plugins are needed for Croquet that are > not already in the supported VMs? > > Thanks, > Dave > > > >> >> >> Croquet could STILL be the killer-app for Smalltalk even though it never realized its potential in the past, and it won???t be able to if something isn???t done about the looming 32-bit vs 64-bit issue. >> >> Need I point out that it should work on Pharo just the same way it does on Squeak? >> >> L >> > >

3 2