Squeak-dev September 2015

squeak-dev@lists.squeakfoundation.org

40 participants
134 discussions

Re: [squeak-dev] The Trunk: SMLoader-cmm.85.mcz
by Chris Muller 17 Sep '15

17 Sep '15

After review and some thought, it has become clear to me that Dave's change is incorrect. Please take a look at the SqueakMap filters and consider them from the context of the use-cases -- what users need to do with SqueakMap, and NOT from the context of a database that needs to produce generalized "query results" <---- because it doesn't. "Published" are the ones which have software to install, while "Auto-installable" shows only packages that are installable from the "Install" menu selection within the image. These two filters are useful together in a restricting fashion, not an inflating one, so that newbies can see what's ready to go. It was then that I also realized that Hannes' combination was not a use-case either. The use-cases we have are: 1) user wants to install software or, 2) user wants to see what they have already installed. Seeing a cumulative list of both installed and uninstalled satisfies neither use-case. Nevertheless you may once again "Clear all filters" (which was broken by Dave's commit) if you want to see everything. I still say SqueakMap catalog can and needs improvement, but we need to really consider our changes because its clear that Göran put a lot of thought into the usage of SqueakMap and its role in the community; so I think we can afford to be a bit more skeptical before thinking something like that was a bug in the first place and for nine years running.. On Tue, Sep 15, 2015 at 2:58 PM, <commits(a)source.squeak.org> wrote: > Chris Muller uploaded a new version of SMLoader to project The Trunk: > http://source.squeak.org/trunk/SMLoader-cmm.85.mcz > > ==================== Summary ==================== > > Name: SMLoader-cmm.85 > Author: cmm > Time: 15 September 2015, 2:58:07.033 pm > UUID: 21a75b8d-4a1b-49c8-8f82-fbbd74fae96b > Ancestors: SMLoader-dtl.84 > > Revert dtl.84, because it broke the Catalog filters. > > =============== Diff against SMLoader-dtl.84 =============== > > Item was changed: > ----- Method: SMLoaderPlus>>packageListCalculated (in category 'lists') ----- > packageListCalculated > "Return a list of the SMPackages that should be visible > by applying all the filters. Also filter based on the currently > selected category - if any." > ^ self packages select: [:p | > + filters allSatisfy: [:currFilter | > - filters anySatisfy: [:currFilter | > currFilter isSymbol > ifTrue: [(self perform: currFilter) value: p] > ifFalse: [self package: p filteredByCategory: (map object: currFilter)]]]! > >

3 3

The Trunk: Compiler-eem.309.mcz
by commits＠source.squeak.org 17 Sep '15

17 Sep '15

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.309.mcz ==================== Summary ==================== Name: Compiler-eem.309 Author: eem Time: 16 September 2015, 5:26:18.544 pm UUID: 89f65602-802e-41c5-b52c-c85cf61e299f Ancestors: Compiler-eem.308 Fix the compiler to collapse optimized block temps of the same name to the same temp location for a better debugging UX. =============== Diff against Compiler-eem.308 =============== Item was changed: ----- Method: BlockNode>>addHoistedTemps: (in category 'code generation (closures)') ----- addHoistedTemps: additionalTemporaries "<SequenceableCollection>" + | tempsToBeMerged additionalTempsToAdd | additionalTemporaries do: [:temp| temp definingScope ifNil: [temp definingScope: self]]. + (temporaries isNil or: [temporaries isEmpty]) ifTrue: + [temporaries := additionalTemporaries copy. + ^self]. + tempsToBeMerged := additionalTemporaries select: + [:t| + t isBlockArg + and: [temporaries anySatisfy: [:existing| existing isBlockArg and: [existing key = t key]]]]. + additionalTempsToAdd := tempsToBeMerged isEmpty + ifTrue: [additionalTemporaries copy] + ifFalse: [additionalTemporaries reject: [:temp| tempsToBeMerged identityIncludes: temp]]. temporaries := (temporaries isNil or: [temporaries isEmpty]) + ifTrue: [additionalTempsToAdd] - ifTrue: [additionalTemporaries copy] ifFalse: [temporaries last isIndirectTempVector + ifTrue: [temporaries allButLast, additionalTempsToAdd, { temporaries last }] + ifFalse: [temporaries, additionalTempsToAdd]]. + tempsToBeMerged do: + [:t| | merge | + merge := temporaries detect: [:existing| existing isBlockArg and: [existing key = t key]]. + merge absorbHoistedTemp: t]! - ifTrue: [temporaries allButLast, additionalTemporaries, { temporaries last }] - ifFalse: [temporaries, additionalTemporaries]]! Item was changed: ----- Method: BytecodeEncoder>>bindTemp: (in category 'temps') ----- bindTemp: name "Declare a temporary; error not if a field or class variable or out-of-scope temp. Read the comment in Encoder>>bindBlockArg:within: and subclass implementations." self supportsClosureOpcodes ifFalse: [^super bindTemp: name]. scopeTable at: name ifPresent: [:node| "When non-interactive raise the error only if it is a duplicate" node isTemp ifTrue:[node scope >= 0 ifTrue: + [^self notify: 'Name already used in this method']] - [^self notify:'Name is already defined']] ifFalse:[self warnAboutShadowed: name]]. ^self reallyBind: name! Item was added: + ----- Method: TempVariableNode>>absorbHoistedTemp: (in category 'code generation (closures)') ----- + absorbHoistedTemp: aTempVar + "Collapse aTempVar into the receiver, being sure to update any closure analysis." + aTempVar copyScopeAccessTo: self. + aTempVar becomeForward: self! Item was added: + ----- Method: TempVariableNode>>copyScopeAccessTo: (in category 'code generation (closures)') ----- + copyScopeAccessTo: aTempVar + "For absorbHoistedTemp:, copy the receiver's reads and writes into the record in aTempVar." + readingScopes ifNotNil: + [readingScopes keysAndValuesDo: + [:scopeBlock :reads| + reads do: + [:location| + aTempVar addReadWithin: scopeBlock "<BlockNode>" at: location]]]. + writingScopes ifNotNil: + [writingScopes keysAndValuesDo: + [:scopeBlock :writes| + writes do: + [:location| + aTempVar addWriteWithin: scopeBlock "<BlockNode>" at: location]]]! Item was changed: + (PackageInfo named: 'Compiler') postscript: '"Make sure all affected methods are recompiled" + UIManager default + informUser: ''Recompiling affected methods'' + during: + [(self systemNavigation allMethodsSelect: + [:m| | ebc | "All affected methods send one of these optimized selectors..." + (#(to:do: to:by:do: ifNotNil: ifNil:ifNotNil: ifNotNil:ifNil:) anySatisfy: [:l| m refersToLiteral: l]) + "but the textDomain properties confuse method comparison below..." + and: [(m propertyValueAt: #textDomain ifAbsent: nil) isNil + and: [m numTemps > m numArgs "and have non-argument temporaries in them..." + or: [(ebc := m embeddedBlockClosures) notEmpty + and: [ebc anySatisfy: [:bc| bc numTemps > bc numArgs]]]]]]) do: + [:mr| | old new | + old := mr compiledMethod. + "do a test recompile of the method..." + new := (mr actualClass compile: old getSource asString notifying: nil trailer: old trailer ifFail: nil) method. + "and if it changed, report it to the transcript and really recompile it..." + old ~= new ifTrue: + [Transcript cr. old printReferenceOn: Transcript. Transcript flush. + mr actualClass recompile: old selector]]]'! - (PackageInfo named: 'Compiler') postscript: '"Migrate preference value" - Scanner allowBlockArgumentAssignment: Preferences allowBlockArgumentAssignment'!

1 0

The Trunk: Kernel-eem.952.mcz
by commits＠source.squeak.org 17 Sep '15

17 Sep '15

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.952.mcz ==================== Summary ==================== Name: Kernel-eem.952 Author: eem Time: 16 September 2015, 4:42:02.543 pm UUID: 31ef882e-64d5-4e23-8e4f-d870d3bc0086 Ancestors: Kernel-eem.951 The comparison of the initial literal in plugin primitive methods needs to compare the first two entries, not the first three. =============== Diff against Kernel-eem.951 =============== Item was changed: ----- Method: CompiledMethod>>= (in category 'comparing') ----- = method "Answer whether the receiver implements the same code as the argument, method. Here ``same code'' means that if the receiver's source is compiled with the same compiler it should produce the same sequence of bytecodes and literals, same trailer and same properties. Hence this definition of #= (only one of many plausible definitions) can be used to quickly identify changes in the compiler's output." | numLits | method isCompiledMethod ifFalse: [^false]. self size = method size ifFalse: [^false]. self header = method header ifFalse: [^false]. "N.B. includes numLiterals comparison." self initialPC to: self endPC do: [:i | (self at: i) = (method at: i) ifFalse: [^false]]. numLits := self numLiterals. 1 to: numLits do: [:i| | lit1 lit2 | lit1 := self literalAt: i. lit2 := method literalAt: i. (lit1 == lit2 or: [lit1 literalEqual: lit2]) ifFalse: [(i = 1 and: [#(117 120) includes: self primitive]) ifTrue: [lit1 isArray ifTrue: + [(lit2 isArray and: [(lit1 first: 2) = (lit2 first: 2)]) ifFalse: - [(lit2 isArray and: [lit1 allButLast = lit2 allButLast]) ifFalse: [^false]] ifFalse: "ExternalLibraryFunction" [(lit1 analogousCodeTo: lit2) ifFalse: [^false]]] ifFalse: [i = (numLits - 1) ifTrue: "properties" [(self properties analogousCodeTo: method properties) ifFalse: [^false]] ifFalse: "last literal (methodClassAssociation) of class-side methods is not unique" [(i = numLits and: [lit1 isVariableBinding and: [lit2 isVariableBinding and: [lit1 key == lit2 key and: [lit1 value == lit2 value]]]]) ifFalse: [^false]]]]]. ^true!

1 0

Daily Commit Log
by commits＠source.squeak.org 16 Sep '15

16 Sep '15

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2015-September/008966.… Name: Kernel-eem.951 Ancestors: Kernel-eem.950 Implement callPrimitive: in the simulator so that, for example, the debugger does not get into an infinite recursion when accepting a new version of a method that has a primitive. Simplify skipCallPrimitive. Fix classCommentBlank so that it always answers the blank, even when there's an existing comment (shurely shome mistake, hic, ed).. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-September/008967.… Name: Compiler-eem.308 Ancestors: Compiler-eem.307 Addition: Scanner>>typedScan:do:, useful for tools (watch this space). Optimisation: Avoid an expensive visit of the parse tree if there are no temps when checking if they need nilling before being read. Polish: Better error message with bindTemp:. Decompile empty blocks as [] not [nil]. Nuke obsolete method creation methods generateMethodOfClass:trailer:from:. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-September/008968.… Name: System-eem.766 Ancestors: System-mt.765 Fix some methods with carriage returns in their time stamps. =============================================

1 0

[Reminder] SqueakMap entries for Squeak 5.0
by H. Hirzel 16 Sep '15

16 Sep '15

Repost of what Chris Muller posted today to make it more visible: (includes links to the relevant wiki pages, SqueakMap delivers a one-click installation experience! Questions are welcome ) ------------------------------------------------------------------------------------------------ Just a gentle reminder, the best way to talk about SqueakMap and figure out how to improve it is to orient ourselves with the requirements: http://wiki.squeak.org/squeak/6183 Publishers who simply follow these publishing guidelines [1] are able to meet these requirements, and so what users see in the list is what WORKS. Thankfully, we DON'T have a blank list in 5.0. Thanks to those in the community who have gotten on board with the publishing guidelines we have packages on SM that actually WORK (if they were done right) and have single one of those requirements met. Users are able to consume those packages with one click instead of being forced to come begging to the list for "how to load it".. We will get there! [1] -- SqueakMap Publishing Guidelines http://wiki.squeak.org/squeak/6182 [2] -- How to designate existing SqueakMap packages for a new version of Squeak http://wiki.squeak.org/squeak/6180

1 0

The Trunk: System-eem.766.mcz
by commits＠source.squeak.org 16 Sep '15

16 Sep '15

Eliot Miranda uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-eem.766.mcz ==================== Summary ==================== Name: System-eem.766 Author: eem Time: 16 September 2015, 11:47:41 am UUID: 9c1c1e34-5f47-43ac-a6de-58be7bc6d6db Ancestors: System-mt.765 Fix some methods with carriage returns in their time stamps. =============== Diff against System-mt.765 =============== Item was changed: ----- Method: DataStream>>objectAt: (in category 'write and read') ----- objectAt: anInteger + "PRIVATE -- Read & return the object at a given stream position. anInteger is a relative file position. " - "PRIVATE -- Read & return the object at a given stream position. 08:18 tk anInteger is a relative file position. " | savedPosn anObject refPosn | savedPosn := byteStream position. "absolute" refPosn := self getCurrentReference. "relative position" byteStream position: anInteger + basePos. "was relative" anObject := self next. self setCurrentReference: refPosn. "relative position" byteStream position: savedPosn. "absolute" ^ anObject! Item was changed: ----- Method: FilePackage>>fullName: (in category 'accessing') ----- fullName: aString fullName := aString! Item was changed: ----- Method: FilePackage>>initialize (in category 'initialize') ----- initialize classes := Dictionary new. classOrder := OrderedCollection new. sourceSystem := ''. doIts := OrderedCollection new.! Item was changed: ----- Method: FilePackage>>packageName (in category 'accessing') ----- packageName ^FileDirectory localNameFor: self fullPackageName! Item was changed: ----- Method: SmartRefStream>>applyConversionMethodsTo:className:varMap: (in category 'import image segment') ----- applyConversionMethodsTo: objectIn className: className varMap: varMap "Modify the object's instance vars to have the proper values for its new shape. Mostly, fill in defaut values of new inst vars. Can substitute an object of a different class. (Beware: if substituted, varMap will not be correct when the new object is asked to convert.)" | anObject prevObject | self flag: #bobconv. anObject := objectIn. [ prevObject := anObject. anObject := anObject convertToCurrentVersion: varMap refStream: self. prevObject == anObject ] whileFalse. + ^anObject! - ^anObject - !

1 0

The Trunk: Compiler-eem.308.mcz
by commits＠source.squeak.org 16 Sep '15

16 Sep '15

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.308.mcz ==================== Summary ==================== Name: Compiler-eem.308 Author: eem Time: 16 September 2015, 11:42:08.344 am UUID: 0420593e-81fc-463c-8d0d-5a0cc7de2845 Ancestors: Compiler-eem.307 Addition: Scanner>>typedScan:do:, useful for tools (watch this space). Optimisation: Avoid an expensive visit of the parse tree if there are no temps when checking if they need nilling before being read. Polish: Better error message with bindTemp:. Decompile empty blocks as [] not [nil]. Nuke obsolete method creation methods generateMethodOfClass:trailer:from:. =============== Diff against Compiler-eem.307 =============== Item was changed: ----- Method: BlockNode>>nilReadBeforeWrittenTemps (in category 'code generation (closures)') ----- nilReadBeforeWrittenTemps | visitor readBeforeWritten | + temporaries isEmpty ifTrue: + [^self]. self accept: (visitor := OptimizedBlockLocalTempReadBeforeWrittenVisitor new). readBeforeWritten := visitor readBeforeWritten. temporaries reverseDo: [:temp| ((readBeforeWritten includes: temp) and: [temp isRemote not]) ifTrue: [statements addFirst: (AssignmentNode new variable: temp value: NodeNil)]]! Item was changed: ----- Method: BytecodeEncoder class>>extensionsFor:in:into: (in category 'instruction stream support') ----- extensionsFor: pc in: aCompiledMethod into: trinaryBlock "If the bytecode at pc is an extension, or if the bytecode at pc is preceeded by extensions, then evaluate aTrinaryBlock with the values of extA and extB and number of extension *bytes*. If the bytecode at pc is neither an extension or extended then evaluate with 0, 0, 0." + + | prevPC | + "If there is what appears to be an extension bytecode before this bytecode + then scan for the previous pc to confirm." + (pc - 2 >= aCompiledMethod initialPC + and: [self isExtension: (aCompiledMethod at: pc - 2)]) ifTrue: + [prevPC := aCompiledMethod pcPreviousTo: pc. + (self nonExtensionPcAt: prevPC in: aCompiledMethod) = pc ifTrue: + [^self extensionsAt: prevPC in: aCompiledMethod into: trinaryBlock]]. + ^self extensionsAt: pc in: aCompiledMethod into: trinaryBlock! - - self subclassResponsibility! Item was added: + ----- Method: BytecodeEncoder class>>nonExtensionPcAt:in: (in category 'instruction stream support') ----- + nonExtensionPcAt: pc in: method + "Answer the pc of the actual bytecode at pc in method, skipping past any preceeding extensions." + | thePC bytecode | + thePC := pc. + [self isExtension: (bytecode := method at: thePC)] whileTrue: + [thePC := thePC + (self bytecodeSize: bytecode)]. + ^thePC! Item was removed: - ----- Method: BytecodeEncoder>>generateMethodOfClass:trailer:from: (in category 'method generation') ----- - generateMethodOfClass: aCompiledMethodClass trailer: trailer from: methodNode - "methodNode is the root of a parse tree. Answer an instance of aCompiledMethodClass - in the receiver's bytecode set and using the receiver's method header format. - The argument, trailer, is arbitrary but is typically either the reference to the source code - that is stored with every CompiledMethod, or an encoding of the method's temporary names." - - self subclassResponsibility! Item was changed: ----- Method: Decompiler>>blockTo: (in category 'control') ----- blockTo: end "Decompile a range of code as in statementsTo:, but return a block node." + | exprs block oldBase lastStatementOfBlockIsNil | - | exprs block oldBase | oldBase := blockStackBase. blockStackBase := stack size. exprs := self statementsTo: end. + lastStatementOfBlockIsNil := pc < method endPC and: [exprs notEmpty and: [exprs last == (constTable at: 4)]]. + lastStatementOfBlockIsNil ifTrue: + [exprs := exprs allButLast]. block := constructor codeBlock: exprs returns: lastReturnPc = lastPc. blockStackBase := oldBase. lastReturnPc := -1. "So as not to mislead outer calls" ^block! Item was changed: ----- Method: Encoder>>bindTemp: (in category 'temps') ----- bindTemp: name "Declare a temporary; error not if a field or class variable." scopeTable at: name ifPresent:[:node| "When non-interactive raise the error only if its a duplicate" + node isTemp + ifTrue:[^self notify:'Name already used in this method'] - (node isTemp) - ifTrue:[^self notify:'Name is already defined'] ifFalse:[self warnAboutShadowed: name]]. ^self reallyBind: name! Item was removed: - ----- Method: EncoderForV3>>generateMethodOfClass:trailer:from: (in category 'method generation') ----- - generateMethodOfClass: aCompiledMethodClass trailer: trailer from: methodNode - "The receiver is the root of a parse tree. Answer an instance of aCompiledMethodClass. - The argument, trailer, is arbitrary but is typically either the reference to the source code - that is stored with every CompiledMethod, or an encoding of the method's temporary names." - - | primErrNode blkSize nLits literals header method stack | - primErrNode := methodNode primitiveErrorVariableName ifNotNil: - [self fixTemp: methodNode primitiveErrorVariableName]. - blkSize := (methodNode block sizeCodeForEvaluatedValue: self) - + (primErrNode - ifNil: [0] - ifNotNil: [primErrNode sizeCodeForStore: self "The VM relies on storeIntoTemp: (129)"]). - header := self computeMethodHeaderForNumArgs: methodNode arguments size - numTemps: self maxTemp - numLits: (nLits := (literals := self allLiterals) size) - primitive: methodNode primitive. - method := trailer - createMethod: blkSize - class: aCompiledMethodClass - header: header. - 1 to: nLits do: [:lit | method literalAt: lit put: (literals at: lit)]. - self streamToMethod: method. - stack := ParseStack new init. - primErrNode ifNotNil: [primErrNode emitCodeForStore: stack encoder: self]. - stack position: method numTemps. - [methodNode block emitCodeForEvaluatedValue: stack encoder: self] - on: Error "If an attempt is made to write too much code the method will be asked" - do: [:ex| "to grow, and the grow attempt will fail in CompiledMethod class>>#new:" - ex signalerContext sender method = (CompiledMethod class>>#new:) - ifTrue: [^self error: 'Compiler code size discrepancy'] - ifFalse: [ex pass]]. - stack position ~= (method numTemps + 1) ifTrue: - [^self error: 'Compiler stack discrepancy']. - self methodStreamPosition ~= (method size - trailer size) ifTrue: - [^self error: 'Compiler code size discrepancy']. - method needsFrameSize: stack size - method numTemps. - ^method! Item was removed: - ----- Method: EncoderForV3PlusClosures>>generateMethodOfClass:trailer:from: (in category 'method generation') ----- - generateMethodOfClass: aCompiledMethodClass trailer: trailer from: methodNode - "The receiver is the root of a parse tree. Answer an instance of aCompiledMethodClass. - The argument, trailer, is arbitrary but is typically either the reference to the source code - that is stored with every CompiledMethod, or an encoding of the method's temporary names." - - | primErrNode blkSize nLits locals literals header method stack | - primErrNode := methodNode primitiveErrorVariableName ifNotNil: - [self fixTemp: methodNode primitiveErrorVariableName]. - methodNode ensureClosureAnalysisDone. - self rootNode: methodNode. "this is for BlockNode>>sizeCodeForClosureValue:" - blkSize := (methodNode block sizeCodeForEvaluatedValue: self) - + (primErrNode - ifNil: [0] - ifNotNil: - [primErrNode - index: methodNode arguments size + methodNode temporaries size; - sizeCodeForStore: self "The VM relies on storeIntoTemp: (129)"]). - locals := methodNode arguments, methodNode temporaries, (primErrNode ifNil: [#()] ifNotNil: [{primErrNode}]). - self noteBlockExtent: methodNode block blockExtent hasLocals: locals. - header := self computeMethodHeaderForNumArgs: methodNode arguments size - numTemps: locals size - numLits: (nLits := (literals := self allLiterals) size) - primitive: methodNode primitive. - method := trailer - createMethod: blkSize - class: aCompiledMethodClass - header: header. - 1 to: nLits do: [:lit | method literalAt: lit put: (literals at: lit)]. - self streamToMethod: method. - stack := ParseStack new init. - primErrNode ifNotNil: [primErrNode emitCodeForStore: stack encoder: self]. - stack position: method numTemps. - [methodNode block emitCodeForEvaluatedValue: stack encoder: self] - on: Error "If an attempt is made to write too much code the method will be asked" - do: [:ex| "to grow, and the grow attempt will fail in CompiledMethod class>>#new:" - ex signalerContext sender method = (CompiledMethod class>>#new:) - ifTrue: [^self error: 'Compiler code size discrepancy'] - ifFalse: [ex pass]]. - stack position ~= (method numTemps + 1) ifTrue: - [^self error: 'Compiler stack discrepancy']. - self methodStreamPosition ~= (method size - trailer size) ifTrue: - [^self error: 'Compiler code size discrepancy']. - method needsFrameSize: stack size - method numTemps. - ^method! Item was added: + ----- Method: Scanner>>typedScan:do: (in category 'public access') ----- + typedScan: textOrString do: aBinaryBlock + "Evaluate aBinaryBlock with the token and its type for the first token in input, + mapping literals to type #literal and anything else to type #word." + | theTokensType atNumber theToken | + self initScannerForTokenization. + self scan: (ReadStream on: textOrString asString). + atNumber := hereChar notNil and: [hereChar isDigit]. + theTokensType := tokenType. + theToken := self advance. + (theToken == #- and: [atNumber and: [token isNumber]]) ifTrue: + [theToken := self advance negated]. + theToken isNumber ifTrue: [theTokensType := #number]. + ^aBinaryBlock + value: theToken + value: ((#(number string literal) includes: theTokensType) + ifTrue: [#literal] + ifFalse: [#word])!

1 0

The Trunk: Kernel-eem.951.mcz
by commits＠source.squeak.org 16 Sep '15

16 Sep '15

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.951.mcz ==================== Summary ==================== Name: Kernel-eem.951 Author: eem Time: 16 September 2015, 10:46:01.276 am UUID: 43df7732-200e-421c-9be0-2c6d33244069 Ancestors: Kernel-eem.950 Implement callPrimitive: in the simulator so that, for example, the debugger does not get into an infinite recursion when accepting a new version of a method that has a primitive. Simplify skipCallPrimitive. Fix classCommentBlank so that it always answers the blank, even when there's an existing comment (shurely shome mistake, hic, ed).. =============== Diff against Kernel-eem.950 =============== Item was changed: ----- Method: ClassDescription>>classCommentBlank (in category 'accessing comment') ----- classCommentBlank + ^String streamContents: + [:stream| + stream + nextPutAll: 'A'; + nextPutAll: (self name first isVowel ifTrue: ['n '] ifFalse: [' ']); + nextPutAll: self name; + nextPutAll: ' is xxxxxxxxx.'; + cr; cr; + nextPutAll: 'Instance Variables'. - | existingComment stream | - existingComment := self theNonMetaClass organization classComment. - existingComment isEmpty - ifFalse: [^existingComment]. + self instVarNames asSortedCollection do: [:each | + stream + crtab; nextPutAll: each; + nextPut: $:; + tab: 2; + nextPutAll: '<Object>']. + stream cr. + self instVarNames asSortedCollection do: [:each | + stream + cr; nextPutAll: each; + crtab; nextPutAll: '- xxxxx'; cr]]! - stream := WriteStream on: (String new: 100). - stream - nextPutAll: 'A'; - nextPutAll: (self name first isVowel ifTrue: ['n '] ifFalse: [' ']); - nextPutAll: self name; - nextPutAll: ' is xxxxxxxxx.'; - cr; cr; - nextPutAll: 'Instance Variables'. - - self instVarNames asSortedCollection do: [:each | - stream - cr; tab; nextPutAll: each; - nextPut: $:; - tab; tab; - nextPutAll: '<Object>']. - - stream cr. - self instVarNames asSortedCollection do: [:each | - stream - cr; nextPutAll: each; - cr; tab; nextPutAll: '- xxxxx'; cr]. - - ^stream contents! Item was changed: ----- Method: InstructionStream>>skipCallPrimitive (in category 'decoding') ----- skipCallPrimitive + "If the receiver's method starts with a callPrimitive: bytecode, skip it." + | method encoderClass callPrimitiveCode | + method := self method. + encoderClass := method encoderClass. + callPrimitiveCode := encoderClass callPrimitiveCode. + (method byteAt: pc) = callPrimitiveCode ifTrue: + [pc := pc + (encoderClass bytecodeSize: callPrimitiveCode)]! - self method encoderClass callPrimitiveCode ifNotNil: - [:callPrimitiveCode| - (self method byteAt: pc) = callPrimitiveCode ifTrue: - [pc := pc + (self method encoderClass bytecodeSize: callPrimitiveCode)]]! Item was added: + ----- Method: MethodContext>>callPrimitive: (in category 'instruction decoding') ----- + callPrimitive: primNumber + "Evaluate the primitive, either normal or inlined, and answer the new context resulting from that + (either the sender if a successful non-inlined primitive, or the current context, if not)." + | maybePrimFailToken | + primNumber >= (1 << 15) ifTrue: "Inlined primitive, cannot fail" + [^self callInlinedPrimitive: primNumber]. + maybePrimFailToken := self doPrimitive: primNumber + method: method + receiver: receiver + args: self arguments. + "Normal primitive. Always at the beginning of methods." + (self isPrimFailToken: maybePrimFailToken) ifFalse: "On success return the result" + [^self methodReturnTop]. + "On failure, store the error code if appropriate and keep interpreting the method" + (method encoderClass isStoreAt: pc in: method) ifTrue: + [self at: stackp put: maybePrimFailToken last]. + ^self!

1 0

Re: [squeak-dev] The Trunk: SMLoader-cmm.85.mcz -- SqueakMap Installable packages / installed packages display
by H. Hirzel 16 Sep '15

16 Sep '15

On 9/15/15, Chris Muller <asqueaker(a)gmail.com> wrote: > After review and some thought, it has become clear to me that Dave's > change is incorrect. Please take a look at the SqueakMap filters and > consider them from the context of the use-cases -- what users need to > do with SqueakMap, and NOT from the context of a database that needs > to produce generalized "query results" <---- because it doesn't. > > "Published" are the ones which have software to install, while > "Auto-installable" shows only packages that are installable from the > "Install" menu selection within the image. These two filters are > useful together in a restricting fashion, not an inflating one, so > that newbies can see what's ready to go. > > It was then that I also realized that Hannes' combination was not a > use-case either. The use-cases we have are: 1) user wants to install > software or, 2) user wants to see what they have already installed. > Seeing a cumulative list of both installed and uninstalled satisfies > neither use-case. I disagree. >From a user interface perspective the problem lies in the fact that it allows me to _select_ 1) show installable software 2) show installed software at the _same_ time. Then I expect to see the set of installable software unified with the set of installed software. What is implemented corresponds to check boxes. What is implemented is radio buttons behaviour. But the radio buttons do not work as it is possible to have more than one buttion active at the same time. Cumulative selections should not be allowed. At the moment they are. The behaviour of the GUI is not what is expected. Some people actually do call this a bug. > Nevertheless you may once again "Clear all filters" (which was broken > by Dave's commit) if you want to see everything. > > I still say SqueakMap catalog can and needs improvement, +1 but we need > to really consider our changes because its clear that Göran put a lot > of thought into the usage of SqueakMap and its role in the community; Yes, he did but but this surely not the right spot to illustrate this point. The GUI seems to be abandoned as of now. I think it is worthwhile to fix obvious issues. > so I think we can afford to be a bit more skeptical before thinking > something like that was a bug in the first place and for nine years > running.. There could be other reasons for no change in 9 years a) Not many people use it and see it as a legacy app which does not need to be fixed. b) Idiosyncrasies are accepted as other parts of the GUI have similar problems. The fact that there was no change in 9 years is not an argument for the quality as such as you easily can imagine. > > On Tue, Sep 15, 2015 at 2:58 PM, <commits(a)source.squeak.org> wrote: >> Chris Muller uploaded a new version of SMLoader to project The Trunk: >> http://source.squeak.org/trunk/SMLoader-cmm.85.mcz >> >> ==================== Summary ==================== >> >> Name: SMLoader-cmm.85 >> Author: cmm >> Time: 15 September 2015, 2:58:07.033 pm >> UUID: 21a75b8d-4a1b-49c8-8f82-fbbd74fae96b >> Ancestors: SMLoader-dtl.84 >> >> Revert dtl.84, because it broke the Catalog filters. >> >> =============== Diff against SMLoader-dtl.84 =============== >> >> Item was changed: >> ----- Method: SMLoaderPlus>>packageListCalculated (in category 'lists') >> ----- >> packageListCalculated >> "Return a list of the SMPackages that should be visible >> by applying all the filters. Also filter based on the currently >> selected category - if any." >> ^ self packages select: [:p | >> + filters allSatisfy: [:currFilter | >> - filters anySatisfy: [:currFilter | >> currFilter isSymbol >> ifTrue: [(self perform: currFilter) value: >> p] >> ifFalse: [self package: p >> filteredByCategory: (map object: currFilter)]]]! >> >> > >

4 3

SqueakMap error -- display of installed packages
by H. Hirzel 16 Sep '15

16 Sep '15

Hello Error report: If in SqueakMap both options are ticked 'New safely available packages' 'Installed packages' nothing is shown. However if I only tick 'Installed packages' then the installed package is shown. So the selection is not cumulative. Regards Hannes

4 5

← Newer
1
2
3
4
5
6
7
8
9
...
14
Older →

Jump to page: