Squeak-dev February 2014

squeak-dev@lists.squeakfoundation.org

71 participants
188 discussions

New LRUCache causing core dump
by Chris Muller 04 Feb '14

04 Feb '14

Hi Levente, the new structure of LRUCache seems to expose a problem with chasing pointers. When I try to chase pointers to any object, one of the LRUCache's I'm still digging to try and see whether its a bug with chasing pointers or just a stack-depth limitation. What I see so far is that PointerFinder wants to ask whether the 'head' var of the new LRUCache #isLiteral. That is what leads to the VM crash. (LRUCache allInstances anyOne instVarNamed: 'head') isLiteral I noticed the 'head' var is initialized as a two-element Array, with each element being the array itself. So trying to ask an Array #isLiteral won't work in that case, e.g., |a| a:=Array new: 1. a at: 1 put: a. a isLiteral causes the same issue. Clearly, we cannot release with a broke PointerFinder. So, what's the best fix folks? My first reaction is a guard in Array>>#isLiteral? isLiteral ^ self class == Array and: [ (self includes: self) not and: [ self allSatisfy: [ : each | each isLiteral ] ] ] Thanks.

4 4

Daily Commit Log
by commits＠source.squeak.org 04 Feb '14

04 Feb '14

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2014-February/006950.h… Name: Collections-ul.564 Ancestors: Collections-ul.563 Make sure that Array >> #isLiteral won't get into an infinite recursion, even if the receiver has an recursive structure. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-February/006951.h… Name: Tools-cmm.518 Ancestors: Tools-topa.517 References through named instVars are strong even on weak classes. Fix PointerFinder behavior accordingly. Add comment reminding about the purpose of Object>>#shouldFollowOutboundPointers. =============================================

1 0

One week left before voting starts
by Ron Teitelbaum 03 Feb '14

03 Feb '14

Hi All, This is a reminder to everyone: there is only one week left. If you are planning on running for a Squeak Oversight Board please announce your candidacy soon. So far we have 8 candidates (in order of announcement). 1. Tim Rowledge 2. Craig Latta 3. Frank Shearar 4. Chris Muller 5. Eliot Miranda 6. Casey Ransberger 7. Edgar De Cleene 8. Rob Withers Last year we had 12 candidates. There is still plenty of room for more! All the best, Ron Teitelbaum

2 1

Re: [squeak-dev] The Trunk: Tools-cmm.518.mcz
by Chris Muller 03 Feb '14

03 Feb '14

I'm too chicken to take out the isLiteral optimization at this stage, but it definitely should honor strong refs from named instVars of weak classes. On Mon, Feb 3, 2014 at 3:43 PM, <commits(a)source.squeak.org> wrote: > Chris Muller uploaded a new version of Tools to project The Trunk: > http://source.squeak.org/trunk/Tools-cmm.518.mcz > > ==================== Summary ==================== > > Name: Tools-cmm.518 > Author: cmm > Time: 3 February 2014, 3:40:50.779 pm > UUID: 6277da39-26fa-467e-9b30-244ee58b4000 > Ancestors: Tools-topa.517 > > References through named instVars are strong even on weak classes. Fix PointerFinder behavior accordingly. > Add comment reminding about the purpose of Object>>#shouldFollowOutboundPointers. > > =============== Diff against Tools-topa.517 =============== > > Item was changed: > ----- Method: Object>>shouldFollowOutboundPointers (in category '*Tools-Debugger') ----- > shouldFollowOutboundPointers > + "Allow other subclasses of ProtoObject to hook this method." > (self class isPointers or: [ self isCompiledMethod ]) ifFalse: [ ^ false ]. > + ^ (self class isWeak not or: [ self class instSize > 0 ]) and: [ self isLiteral not ]! > - ^ self class isWeak not and: [ self isLiteral not ]! > >

1 0

Re: [squeak-dev] The Trunk: Tools-cmm.518.mcz
by Chris Muller 03 Feb '14

03 Feb '14

shouldFollowOutboundPointers was recently introduced so that other subclasses of ProtoObject can override it the way they want. On Mon, Feb 3, 2014 at 3:43 PM, <commits(a)source.squeak.org> wrote: > Chris Muller uploaded a new version of Tools to project The Trunk: > http://source.squeak.org/trunk/Tools-cmm.518.mcz > > ==================== Summary ==================== > > Name: Tools-cmm.518 > Author: cmm > Time: 3 February 2014, 3:40:50.779 pm > UUID: 6277da39-26fa-467e-9b30-244ee58b4000 > Ancestors: Tools-topa.517 > > References through named instVars are strong even on weak classes. Fix PointerFinder behavior accordingly. > Add comment reminding about the purpose of Object>>#shouldFollowOutboundPointers. > > =============== Diff against Tools-topa.517 =============== > > Item was changed: > ----- Method: Object>>shouldFollowOutboundPointers (in category '*Tools-Debugger') ----- > shouldFollowOutboundPointers > + "Allow other subclasses of ProtoObject to hook this method." > (self class isPointers or: [ self isCompiledMethod ]) ifFalse: [ ^ false ]. > + ^ (self class isWeak not or: [ self class instSize > 0 ]) and: [ self isLiteral not ]! > - ^ self class isWeak not and: [ self isLiteral not ]! > >

1 1

Re: [squeak-dev] The Inbox: Collections-ul.565.mcz
by Chris Muller 03 Feb '14

03 Feb '14

Any senders of shouldBePrintedAsLiteralVisiting:? The other fix for isLiteral was crucial, is this fix crucial to the release too? Thanks. On Mon, Feb 3, 2014 at 11:38 AM, <commits(a)source.squeak.org> wrote: > A new version of Collections was added to project The Inbox: > http://source.squeak.org/inbox/Collections-ul.565.mcz > > ==================== Summary ==================== > > Name: Collections-ul.565 > Author: ul > Time: 3 February 2014, 6:28:21.892 pm > UUID: b59d3510-2193-4790-b372-84aa2ff111fa > Ancestors: Collections-ul.564 > > Let the following return true: > > | a | > a := #(1). > { a. a} shouldBePrintedAsLiteral. > > =============== Diff against Collections-ul.564 =============== > > Item was changed: > ----- Method: Array>>shouldBePrintedAsLiteralVisiting: (in category 'testing') ----- > shouldBePrintedAsLiteralVisiting: aSet > + > + | result | > self class == Array ifFalse: > [^false]. > (aSet includes: self) ifTrue: > [^false]. > aSet add: self. > + result := self allSatisfy: [:each | each shouldBePrintedAsLiteralVisiting: aSet]. > + aSet remove: self. > + ^result! > - ^self allSatisfy: [:each | each shouldBePrintedAsLiteralVisiting: aSet]! > >

1 0

The Trunk: Tools-cmm.518.mcz
by commits＠source.squeak.org 03 Feb '14

03 Feb '14

Chris Muller uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-cmm.518.mcz ==================== Summary ==================== Name: Tools-cmm.518 Author: cmm Time: 3 February 2014, 3:40:50.779 pm UUID: 6277da39-26fa-467e-9b30-244ee58b4000 Ancestors: Tools-topa.517 References through named instVars are strong even on weak classes. Fix PointerFinder behavior accordingly. Add comment reminding about the purpose of Object>>#shouldFollowOutboundPointers. =============== Diff against Tools-topa.517 =============== Item was changed: ----- Method: Object>>shouldFollowOutboundPointers (in category '*Tools-Debugger') ----- shouldFollowOutboundPointers + "Allow other subclasses of ProtoObject to hook this method." (self class isPointers or: [ self isCompiledMethod ]) ifFalse: [ ^ false ]. + ^ (self class isWeak not or: [ self class instSize > 0 ]) and: [ self isLiteral not ]! - ^ self class isWeak not and: [ self isLiteral not ]!

1 0

The Inbox: Tools-ul.518.mcz
by commits＠source.squeak.org 03 Feb '14

03 Feb '14

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-ul.518.mcz ==================== Summary ==================== Name: Tools-ul.518 Author: ul Time: 3 February 2014, 6:32:58.482 pm UUID: 83289b35-b273-47cd-a97c-7a189fb0178e Ancestors: Tools-topa.517 PointerFinder >> #follow:from: works for weak objects with named slots. It also uses safe checks instead of #isLiteral to cut the object graph. Removed the now unused Object >> #shouldFollowOutboundPointers =============== Diff against Tools-topa.517 =============== Item was removed: - ----- Method: Object>>shouldFollowOutboundPointers (in category '*Tools-Debugger') ----- - shouldFollowOutboundPointers - (self class isPointers or: [ self isCompiledMethod ]) ifFalse: [ ^ false ]. - ^ self class isWeak not and: [ self isLiteral not ]! Item was changed: ----- Method: PointerFinder>>follow:from: (in category 'application') ----- + follow: anObject from: parentObject + + | class | - follow: anObject from: parentObject anObject == goal ifTrue: [ parents at: anObject put: parentObject. ^ true ]. + class := anObject class. + (class isPointers or: [ anObject isCompiledMethod ]) ifFalse: [ ^false ]. + class isWeak + ifTrue: [ class instSize = 0 ifTrue: [ ^false ] ] + ifFalse: [ + (class instSize = 0 and: [ + class isVariable not or: [ + anObject basicSize = 0 ] ]) ifTrue: [ ^false ] ]. + ((parents includesKey: anObject) or: [ class = self class ]) ifTrue: [ ^ false ]. - anObject shouldFollowOutboundPointers ifFalse: [ ^ false ]. - ((parents includesKey: anObject) or: [ anObject class = self class ]) ifTrue: [ ^ false ]. parents at: anObject put: parentObject. toDoNext add: anObject. ^ false!

1 0

The Inbox: CollectionsTests-ul.215.mcz
by commits＠source.squeak.org 03 Feb '14

03 Feb '14

A new version of CollectionsTests was added to project The Inbox: http://source.squeak.org/inbox/CollectionsTests-ul.215.mcz ==================== Summary ==================== Name: CollectionsTests-ul.215 Author: ul Time: 3 February 2014, 6:28:52.614 pm UUID: e6ad2d76-10b9-427d-a742-2784787723b8 Ancestors: CollectionsTests-dtl.214 - added a test for Array >> #shouldBePrintedAsLiteral =============== Diff against CollectionsTests-dtl.214 =============== Item was added: + ----- Method: ArrayTest>>testShouldBePrintedAsLiteral (in category 'testing') ----- + testShouldBePrintedAsLiteral + "We work with a copy of literalArray, to avoid corrupting the code." + + | a | + a := #(1). + self assert: #() shouldBePrintedAsLiteral. + self assert: #(1) shouldBePrintedAsLiteral. + self assert: { a. a } shouldBePrintedAsLiteral!

1 0

The Inbox: Collections-ul.565.mcz
by commits＠source.squeak.org 03 Feb '14

03 Feb '14

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ul.565.mcz ==================== Summary ==================== Name: Collections-ul.565 Author: ul Time: 3 February 2014, 6:28:21.892 pm UUID: b59d3510-2193-4790-b372-84aa2ff111fa Ancestors: Collections-ul.564 Let the following return true: | a | a := #(1). { a. a} shouldBePrintedAsLiteral. =============== Diff against Collections-ul.564 =============== Item was changed: ----- Method: Array>>shouldBePrintedAsLiteralVisiting: (in category 'testing') ----- shouldBePrintedAsLiteralVisiting: aSet + + | result | self class == Array ifFalse: [^false]. (aSet includes: self) ifTrue: [^false]. aSet add: self. + result := self allSatisfy: [:each | each shouldBePrintedAsLiteralVisiting: aSet]. + aSet remove: self. + ^result! - ^self allSatisfy: [:each | each shouldBePrintedAsLiteralVisiting: aSet]!

1 0

Jump to page: